[Koha-bugs] [Bug 14631] Change to "Patron" in patroncard toolbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 --- Comment #11 from Marc Véron --- A small translatability woe (sentence splitting by tags): [% duplicate_count %] duplicate patron(s) found and removed from batch [% batch_id %]. Maybe something like: Duplicate patron(s) removed from batch [% batch_id %]: [% duplicate_count %] or: Duplicates removed from batch [% batch_id %]: [% duplicate_count %] patron(s) or even: Duplicates removed from batch [% batch_id %]: [% duplicate_count %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 --- Comment #10 from Marc Véron --- (In reply to Aleisha Amohia from comment #9) >(...)I'm still not seeing any warning message when I log in. I can reproduce the behaviour. It is related to a system preference OpacRenewalAllowed: [Allow] patrons to renew their own books on the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4054] Double-clicking the 'place hold' button can result in duplicate holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4054 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Nicholas van Oudtshoorn changed: What|Removed |Added Attachment #45898|0 |1 is obsolete|| --- Comment #16 from Nicholas van Oudtshoorn --- Created attachment 45899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45899&action=edit Limit web-based self-checkout to specific IP addresses Minor change to the last patch, that simply also removes a no longer needed use Net::CIDR. Also removes the whitespace error :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Nicholas van Oudtshoorn changed: What|Removed |Added Attachment #45894|0 |1 is obsolete|| --- Comment #15 from Nicholas van Oudtshoorn --- Created attachment 45898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45898&action=edit Limit web-based self-checkout to specific IP addresses Minor change to the last patch, that simply also removes a no longer needed use Net::CIDR -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12549] Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12549 Nicholas van Oudtshoorn changed: What|Removed |Added Version|3.16|master Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12549] Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12549 Nicholas van Oudtshoorn changed: What|Removed |Added Assignee|gmcha...@gmail.com |vano...@gmail.com Status|NEW |Needs Signoff --- Comment #2 from Nicholas van Oudtshoorn --- Created attachment 45897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45897&action=edit Allows selecting the path for fonts at installation time Allows for selection of DejaVu font path when installing from the command line. This is useful for non-debian distributions that don't store the fonts in the same place. Adds a new configuration variable to Makefile.PL: FONT_DIR Defaults to the Debian install location for the fonts. Test plan: 1. Run a CLI install, accepting the defaults. 2. Compare the generated koha-conf.xml to a previous install - the font path for DejaVu fonts should be the same. 3. Run another CLI install, this time choosing a custom path for the fonts 4. Check that the path selected is reflected in the koha-conf.xml file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15405] XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15405 Nicholas van Oudtshoorn changed: What|Removed |Added Assignee|gmcha...@gmail.com |vano...@gmail.com Status|NEW |Needs Signoff --- Comment #1 from Nicholas van Oudtshoorn --- Created attachment 45896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45896&action=edit Adjust modulePath in zebra config to also work on 64 bit non-debian boxes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15405] New: XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15405 Bug ID: 15405 Summary: XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcha...@gmail.com Reporter: vano...@gmail.com QA Contact: testo...@bugs.koha-community.org This patches the zebra configuration so that their modulePath will work on Fedora (CentOS) based systems out of the box. Similar to bug 14106, this simply adjusts the modulePath to search in the well-known location for 64 bit systems. Required for at least Fedora. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11602] Fix localcover display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11602 --- Comment #8 from Nicholas van Oudtshoorn --- Thanks everyone - great to have contributed to Koha! :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10988] Allow login via Google OAuth2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Nicholas van Oudtshoorn changed: What|Removed |Added Attachment #43791|0 |1 is obsolete|| Attachment #43792|0 |1 is obsolete|| Attachment #43938|0 |1 is obsolete|| Attachment #45668|0 |1 is obsolete|| --- Comment #52 from Nicholas van Oudtshoorn --- Created attachment 45895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45895&action=edit Allow Google OAuth2 Login Combines all of the patches above into one, and rebases it to current master, so that they all cleanly apply. Works for me on this end. Test plan remains the same. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Nicholas van Oudtshoorn changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Nicholas van Oudtshoorn changed: What|Removed |Added Attachment #40854|0 |1 is obsolete|| --- Comment #14 from Nicholas van Oudtshoorn --- Created attachment 45894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45894&action=edit Limit web-based self-checkout to specific IP addresses Allow web-based self-checkout to be limited to only certain IPs or IP ranges. Adds a function to C4::Auth called in_ipset that checks if the current client IP is in a provided IP set, as suggested in comment #11. (This function will be useful for other IP-based restrictions) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com --- Comment #27 from Aleisha Amohia --- Where can a librarian see the patron's chosen main contact method? I feel like it should be under their contact information on the Details page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10958] no need for home link on home page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com --- Comment #3 from Aleisha Amohia --- What if we replaced the Home link with a link the summary page (opac-user.pl) ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11569] Typo in userpermissions.sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11569 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11569] Typo in userpermissions.sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11569 --- Comment #1 from Aleisha Amohia --- Created attachment 45893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45893&action=edit Bug 11569: Correcting typos -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12039] Typo in ReservesMaxPickUpDelayCharge description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12039 Aleisha Amohia changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED CC||aleishaamo...@hotmail.com --- Comment #2 from Aleisha Amohia --- The description of this syspref no longer has this error in the current version of Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15355] Translatability: Fix issues on check in page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15355 Aleisha Amohia changed: What|Removed |Added Attachment #45611|0 |1 is obsolete|| --- Comment #3 from Aleisha Amohia --- Created attachment 45892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45892&action=edit Bug 15355: Translatability: Fix issues on check in page This patch fixes translatability issues on checkin page, due to sentence splitting by html tags at several places and ambiguous word 'to'. Additionally, fix message related to syspref AllowReturnToBranch set to 'only the library where the item is checked out from' (it wrongly displays the home library instead of the holding library), and streamline the display of similar messages to look more consistent. To test: - Apply patch - Go to Home > Circulation > Check in - Do check ins with different expected results / messages - Verify that the messages are meaningful and display nicely - Play with items checked out / checked in at different branches (home branch, holding branch, other branch) and different settings for syspref 'AllowREturnToBranch' and verify that the messages display properly (with correct home rsp. holding branch) - Carfully review code changes. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15355] Translatability: Fix issues on check in page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15355 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13177] Add help pages for Rotating collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13177] Add help pages for Rotating collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177 --- Comment #1 from Aleisha Amohia --- Created attachment 45891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45891&action=edit Bug 13177: Help page for Rotating Collections To test: Go to Tools -> Rotating Collections and click Help in the top-right. Confirm the Help page shows and gives correct accurate instructions with no typos or grammatical errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11371] Add a new report : Orders by budget
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bouzid changed: What|Removed |Added Attachment #45887|0 |1 is obsolete|| --- Comment #34 from Bouzid --- Created attachment 45890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45890&action=edit Bug 11371 - Add a new report : Orders by budget This patch adds the "Orders by budget" report to the reports page. This report can generate the list of all orders on a specific budget. The "All budgets" and "All active budgets" options are also available to have different views of all your orders. A "[i]" is also added before the names of inactive budgets in the budget selection box. How to test: Go to Home > Reports > Orders by budget Select one or all budgets Output to Scrren or CSV file Set a budget to inactive Verify that this budget is marked wit [i] in drop down list (Filters) Sponsored-by: ccsr http://bugs.koha-community.org/show_bug.cgi?id=11371 Author:bouzid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14631] Change to "Patron" in patroncard toolbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 --- Comment #10 from Aleisha Amohia --- Created attachment 45889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45889&action=edit Bug 14631: More changes from 'items' to 'patrons' Some of the changes Bernardo noticed were missed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15404] New: CanBookBeReserved: No count of biblio level holds if ReservesControlBranch is item's home library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15404 Bug ID: 15404 Summary: CanBookBeReserved: No count of biblio level holds if ReservesControlBranch is item's home library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: ve...@veron.ch QA Contact: testo...@bugs.koha-community.org If the system preference 'ReservesControlBranch' is set to "Check the [item's home library] to see if the patron can place a hold on the item.", the sub CanBookBeReserved does not count holds on bilio level. This is because there is no information about to which branch a biblio item hold should refer. The behaviour affects: - putting holds from OPAC (if RequestOnOpac is set to "[Allow] patrons to place holds on items from the OPAC." (Seems always to be an biblio level hold) - putting holds in staff interface for "Next available item" (= biblio level hold) Symptoms: In OPAC, patrons can put more holds than allowed for an item type (up to syspref 'maxreserve' = systemwide maximum holds) Same in staff client as long you do not put item level holds. With other words: You can put item level holds up to the maximum defined in the circulation rules and additionally biblio level holds up to the value set in 'maxreserve'. I think there is no way to overcome the situation (because a biblio has no home library, only items can have), but it should be documented e.g. in the text when setting the syspref 'ReservesContronBranch' and/or with a warning e.g. on the page where the circulation rules are set. I suppose that following Bugs could be related: Bug 6976 - User hold limit can be avoided by users in OPAC Bug 5159 - HomeOrHoldingBranch syspref description misleading Bug 4850 - CheckReserves does not respect holds circulation policies More? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15394] Confirm messages on OPAC lists interface strangely worded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15394 --- Comment #4 from Liz Rea --- Hi Jonathan, I've opened bug 15403 for the intranet. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Aleisha Amohia changed: What|Removed |Added Attachment #45878|0 |1 is obsolete|| --- Comment #19 from Aleisha Amohia --- Created attachment 45888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45888&action=edit Bug 4078 - Display active currency symbol on currency output and input Display active currency using international formatting patterns and active currency symbol withplugin price. To test: - Apply patch - Make sure that you have defined an active currency in Home > Administration > Currency & Exchange rates - Search for Syspref 'Currency Format' - Select a formatting pattern from the drop down list - Go to a page that uses Price formatting and verify that currency symbol displays wheere price formatting is applied (git grep '| $Price') (Amended patch to remove example opac-user.tt. To test with OPAC see bug 15374) Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15394] Confirm messages on OPAC lists interface strangely worded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15394 Liz Rea changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=15403 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15403] New: Confirm messages in intranet lists interface strangely worded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15403 Bug ID: 15403 Summary: Confirm messages in intranet lists interface strangely worded Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcha...@gmail.com Reporter: l...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Examples: List deleted with success. List inserted with success. These are developer ways of saying this. Let's make them user-english. :) Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 --- Comment #9 from Aleisha Amohia --- > With patch, I get: > - Warning message: > Please note: You cannot renew your books online. Reason: Your fines exceed > 100.00. Please pay your fines if you wish to renew your books. Go to your > account page > [As expected. Better wording / no sentence splitting for translatability] > > - Tab Heading: > Fines: 200.00 The fines tab looks much better now but I'm still not seeing any warning message when I log in. I get a warning message when I try to place a hold on something but not on the summary page when I log in. Also I tested with your patch for Bug 4078 and it works well, so can I sign off on that one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15401] New: runreport.pl should have the option to attach data.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15401 Bug ID: 15401 Summary: runreport.pl should have the option to attach data. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcha...@gmail.com Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Currently, the --email option of runreport.pl will put the text output from the report directly in the body of the email. It would be nice to have the option of attaching data, so that it could be saved or opened by the recipient's preferred program based on mime-type. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11371] Add a new report : Orders by budget
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #33 from Bouzid --- In this patch, I fix many problems, most important is note not appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11371] Add a new report : Orders by budget
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bouzid changed: What|Removed |Added Attachment #41463|0 |1 is obsolete|| Attachment #41464|0 |1 is obsolete|| Attachment #45245|0 |1 is obsolete|| Attachment #45338|0 |1 is obsolete|| --- Comment #32 from Bouzid --- Created attachment 45887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45887&action=edit Bug 11371 - Add a new report : Orders by budget This patch adds the "Orders by budget" report to the reports page. This report can generate the list of all orders on a specific budget. The "All budgets" and "All active budgets" options are also available to have different views of all your orders. A "[i]" is also added before the names of inactive budgets in the budget selection box. How to test: Go to Home > Reports > Orders by budget Select one or all budgets Output to Scrren or CSV file Set a budget to inactive Verify that this budget is marked wit [i] in drop down list (Filters) Sponsored-by: ccsr http://bugs.koha-community.org/show_bug.cgi?id=11371 Author:bouzid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7030] Define maximum number of holds on branch level
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7030 --- Comment #8 from Marc Véron --- ...and default_borrower_circ_rules, I suppose. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7030] Define maximum number of holds on branch level
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7030 Marc Véron changed: What|Removed |Added Summary|maximum number of holds |Define maximum number of ||holds on branch level --- Comment #7 from Marc Véron --- (In reply to Owen Leonard from comment #6) > (In reply to Marc Véron from comment #5) > > Is that not covered by the system preference 'maxreserves'? > > The system preference 'maxreserves' is a maximum across all libraries, > itemtypes, and patrons. This request is for something which is configurable > per library but covers all itemtypes and patrons at that library. Hi Owen, thanks for the clarification, I did not properly read comment #2. I changed the bug title a little bit. Would that be a new column in the table branch_borrower_circ_rules? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid changed: What|Removed |Added Attachment #45885|0 |1 is obsolete|| --- Comment #38 from Bouzid --- Created attachment 45886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45886&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC - Change the preference Enhancedmessagingpreference description. - Enable default EnhancedMessagingPreferences and OPACEnhancedMessagingPreferences. - not sent e-mail it's necessary, when user call opac-messaging.pl directly.. Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. Signed-off-by: Frederic Demians Works as expected. With the new syspref, patrons can be forbidden to modify themselves their own messaging preferences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15243] Place a hold on... Fix display issue and improve translatability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243 Marc Véron changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #8 from Marc Véron --- Setting back to Assigned because it seems that there are some more general issues with placing holds needing deeper exploration. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7030] maximum number of holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7030 --- Comment #6 from Owen Leonard --- (In reply to Marc Véron from comment #5) > Is that not covered by the system preference 'maxreserves'? The system preference 'maxreserves' is a maximum across all libraries, itemtypes, and patrons. This request is for something which is configurable per library but covers all itemtypes and patrons at that library. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7030] maximum number of holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7030 --- Comment #5 from Marc Véron --- What is the role of syspref 'maxreserves'? (In reply to Owen Leonard from comment #4) > This bug is still valid, because there is no setting in circulation and fine > rules for defining a maximum number of holds across all item types/patrons. Is that not covered by the system preference 'maxreserves'? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14631] Change to "Patron" in patroncard toolbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
CC||bgkrie...@gmail.com
--- Comment #9 from Bernardo Gonzalez Kriegel ---
On current master this has been fixed.
We have "Add patron(s) Remove selected patrons ... Export selected card(s)
Export card batch"
There are other strings that need attention:
alert(_("Deletion of item from a batch with only one item will delete the
batch.\n\nIf this is what you want, select 'Delete batch' option from
toolbar"));
[% duplicate_count %] duplicate item(s) found and removed from
batch [% batch_id %].
Items in batch number [% batch_id %]
There are no items in this batch yet
Add items by borrowernumber using the text area above or leave empty to add
via patron search.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7030] maximum number of holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7030 Owen Leonard changed: What|Removed |Added Status|REOPENED|NEW --- Comment #4 from Owen Leonard --- This bug is still valid, because there is no setting in circulation and fine rules for defining a maximum number of holds across all item types/patrons. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid changed: What|Removed |Added Attachment #44826|0 |1 is obsolete|| --- Comment #37 from Bouzid --- Created attachment 45885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45885&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC Change the preference Enhancedmessagingpreference description. Enable default EnhancedMessagingPreferences and OPACEnhancedMessagingPreferences. not sent e-mail it's necessary, when user call opac-messaging.pl directly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #45325|0 |1 is obsolete|| --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 45884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45884&action=edit [SIGNED-OFF] Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices This bug is the beginning of a conversion from our current bespoke syntax for slips and notices to Template Toolkit syntax. This patch is the initial seed which will evolve over time. With this addition, we can take advantage of our Koha Objects to greatly simplify the processing of Slips and Notices over time. Test Plan: 1) Apply this patch 2) Ensure you have the default CHECKOUT notice 3) Check out and return an item for a patron 4) Note the text of the CHECKOUT notice 5) Replace your CHECKOUT notice with the following: The following items have been checked out: [% biblio.title %] Thank you for visiting [% branch.branchname %]. 6) Repeat step 3 7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text Signed-off-by: Bernardo Gonzalez Kriegel New notice syntax works, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11450] Hold Request Confirm Deletion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 Owen Leonard changed: What|Removed |Added Severity|enhancement |normal Version|unspecified |master --- Comment #2 from Owen Leonard --- Still valid in master as of 21 Dec 2015 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015
--- Comment #8 from Marc Véron ---
(In reply to Jonathan Druart from comment #7)
> Comment on attachment 45873 [details] [review]
> Bug 14015 - Checkout: Fix software error if barcode '0' is given
>
> Review of attachment 45873 [details] [review]:
> -
>
> ::: circ/circulation.pl
> @@ +217,5 @@
> > }
> >
> > # check and see if we should print
> > +# but do not set to 'yes' if barcode given by user is '0'
> > +if ( ( @$barcodes == 0 ) && ( ! @$barcodes eq '0') && ( $print eq
> > 'maybe' ) ) {
>
> What is supposed to test !@$barcodes eq '0' ??
Hi Jonathan,
The first (already existing) part @$barcodes == 0 tests @$barcodes for
numerical equality (no barcodes given). While testing I found out that it
evaluates to true for a barcode that is '0'. Because it evaluated to true with
a barcode '0', $print was set to 'yes' (but we do not want to print, since we
have a barcode). With $print set to 'yes' the borrowernumber is set to '' in
line 235, and that leads to the software error in line 473.
By adding a test for the barcode not to be equal to '0' by the string equality
oparator eq ( ! @$barcodes eq '0'), the value of $print is not set to 'yes' and
the barcode '0' is treated as such. Koha will then display the message 'The
barcode was not found 0' (as expected)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 --- Comment #25 from Owen Leonard --- This bug is still valid in master as of 21 Dec 2015. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15367] Batch patron modification: Data loss with multiple repeatable patron attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15367] Batch patron modification: Data loss with multiple repeatable patron attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #45880|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 45883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45883&action=edit [SIGNED-OFF] Bug 15367: Do not display repeatable patron attributes in the batch patron modification The repeatable patron attributes are not correctly managed and can cause data lost. To avoid that, the easier way is not to display them in the batch patron modification tool. This should be implemented, as a new enhancement. Test plan: Create some patron attributes, some should be repeatable. Use the batch patron modification tool to modify patrons. With this patch, the patron attributes marked as repeatable won't be display anymore. Signed-off-by: Bernardo Gonzalez Kriegel Works as described, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] display patron age in useful places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Martin Stenberg changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] display patron age in useful places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #1 from Martin Stenberg --- Created attachment 45882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45882&action=edit Bug 15400: Show patron age in search results Display patron age in search results and checkout details. Test plan = 1. Go to checkout page for one patron (cgi-bin/koha/circ/circulation.pl) 2. In the circulation menu to the left, under the patrons name you should see a new field "Age:" showing the patrons age, if a date of birth is available. 3. Enter a search term that will match more than one patron in the checkout search field 4. A new table column "Age" should be visible and display each patrons age 5. In cgi-bin/koha/members/member.pl enter a search filter that will match more than one patron 6. Each patrons age should be visible within parentheses to the right of the patron name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12636] Batch patron modification should not update with unique patron attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12636 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12636] Batch patron modification should not update with unique patron attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12636 --- Comment #1 from Jonathan Druart --- Created attachment 45881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45881&action=edit Bug 12636: Do not display unique patron attributes in the batch patron modification Batch patron modification should not offer to update patron attributes with values which are designated as unique since such attributes are required to be unique to a single patron. Test plan: Create some patron attributes, some should be unique. Use the batch patron modification tool to modify patrons. With this patch, the patron attributes marked as unique won't be display anymore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12636] Batch patron modification should not update with unique patron attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12636 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|gmcha...@gmail.com |jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15367] Batch patron modification: Data loss with multiple repeatable patron attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15367] Batch patron modification: Data loss with multiple repeatable patron attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 --- Comment #1 from Jonathan Druart --- Created attachment 45880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45880&action=edit Bug 15367: Do not display repeatable patron attributes in the batch patron modification The repeatable patron attributes are not correctly managed and can cause data lost. To avoid that, the easier way is not to display them in the batch patron modification tool. This should be implemented, as a new enhancement. Test plan: Create some patron attributes, some should be repeatable. Use the batch patron modification tool to modify patrons. With this patch, the patron attributes marked as repeatable won't be display anymore. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15367] Batch patron modification: Data loss with multiple repeatable patron attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] display patron age in useful places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Martin Stenberg changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |mar...@bugs.koha-community. |ity.org |org.xinxidi.net -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] New: display patron age in useful places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Bug ID: 15400 Summary: display patron age in useful places Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: mar...@bugs.koha-community.org.xinxidi.net QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Show patrons age in checkout search, member search and patrons circulation details (top left menu). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7126] Transfer does not prompt with hold information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7126
--- Comment #3 from Jonathan Druart
---
>From C4::Circulation::transferbook
355 my ( $resfound, $resrec, undef ) =
356 CheckReserves( $itemnumber );
357 if ( $resfound and not $ignoreRs ) {
358 $resrec->{'ResFound'} = $resfound;
359
360 # $messages->{'ResFound'} = $resrec;
361 $dotransfer = 1;
362 }
The line 360 should not be commented I think.
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7126] Transfer does not prompt with hold information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7126 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart --- (In reply to Marc Véron from comment #1) > Still valid? Yes it is, everything is buggy... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 poonam banyal changed: What|Removed |Added CC||poonamban...@yahoo.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14991] Reword, clarify and add consistency to authority search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14991 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14991] Reword, clarify and add consistency to authority search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14991 Jonathan Druart changed: What|Removed |Added Attachment #45874|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 45879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45879&action=edit BUG 14991 Improve consistency of authority search At the moment we can search authorities from two places: authorities-home.pl and auth_finder.pl (while cataloguing). The auth_finder.pl page offers searching specifically in the $a of the main heading, while the authorities home page doesn't. Additionally, the wording and order of the options is different. authorities-home.pl has: Search main heading Search all headings Keyword search while auth_finder.pl has: Main entry ($a only) Main entry Anywhere Heading match This patch will add some consistency so that both pages offer: Search main heading ($a only) Search main heading Search all headings Search entire record Test plan: - apply patch - go to authorities home - check that previous searches are still working - check that the new ($a only) search is working - go to auth finder (from cataloguing) - check that searches are still working - check that we do have the same wording in both pages and that forms are now consistent Signed-off-by: Aleisha Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15394] Confirm messages on OPAC lists interface strangely worded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15394 Jonathan Druart changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15394] Confirm messages on OPAC lists interface strangely worded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15394 Jonathan Druart changed: What|Removed |Added Assignee|oleon...@myacpl.org |l...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15394] Confirm messages on OPAC lists interface strangely worded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15394 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Could you provide the same change for the staff interface please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015
--- Comment #7 from Jonathan Druart
---
Comment on attachment 45873
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45873
Bug 14015 - Checkout: Fix software error if barcode '0' is given
Review of attachment 45873:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14015&attachment=45873)
-
::: circ/circulation.pl
@@ +217,5 @@
> }
>
> # check and see if we should print
> +# but do not set to 'yes' if barcode given by user is '0'
> +if ( ( @$barcodes == 0 ) && ( ! @$barcodes eq '0') && ( $print eq 'maybe'
> ) ) {
What is supposed to test !@$barcodes eq '0' ??
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #10 from Katrin Fischer --- Looking a bit deeper into this, I think there is a confusion about the data in the reserves table: reserves.expirationdate is NOT the date when a hold expires for pick-up. It's the date the user set for not needing the hold any longer when placing it. It should probably be used to automatically cancel holds. I think this one should always display as it is in the database and the old feature was built on a wrong assumption about the existing column. What we would need additionally is a 'pickup-expirationdate'. We don't have a column for this in the reserves table currently. So we can either introduce a new column or calculate it to be put in the notices on the fly. And only this date should then take the ReservesMaxPickUpDelay into account and be calculated like Kyle says: waitingdate + ReservesMaxPickUpDelay. It shoudl also probably take the calendar into account in some way, maybe by using methods like the useDaysMode preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15380] Move the authority types related code to Koha::Authority::Type[s] - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 --- Comment #9 from Jonathan Druart --- (In reply to Ian Palko from comment #8) > I am wondering if changes with Koha::Authority here will help solve the > problem over in Bug 15358. No, I did not change this module, just rename it. > Perhaps before these changes to Koha::MetadataRecord::Authority are pushed > the necessary changes can be made to harmonize it with repairing of the > broken authorities merge. It will be easy to fix this conflict, no need to block this patch or the other one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #5 from Jonathan Druart --- (In reply to Frédéric Demians from comment #4) > For me what happens here is the same field as what you have observed with > system preferences. We have information serialized in the relational DB model > (so a lot of linked tables) which could be more easily represented in other > data structures. Koha is requesting ad nauseam multiple tables. I fear that > your patches are just overcomplexifying something which is already far too > complex. It's becoming byzantines. Finally, you're creating multiples classes > to access data found in one table (auth_types) which can contain up to 10 > records. I am following the same design for all admin scripts. I create a Koha::Object then use it for CRUD when it is possible to use it quickly. I have reduced the code to 2/3 and remove 4 subroutines in the deprecated C4 namespace, I think it is the way to go, and don't think it's overcomplexifying the area. If we will need to return auth types in another structure, it will be easy to create a new method in Koha::Authority::Types. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr --- Comment #4 from Frédéric Demians --- For me what happens here is the same field as what you have observed with system preferences. We have information serialized in the relational DB model (so a lot of linked tables) which could be more easily represented in other data structures. Koha is requesting ad nauseam multiple tables. I fear that your patches are just overcomplexifying something which is already far too complex. It's becoming byzantines. Finally, you're creating multiples classes to access data found in one table (auth_types) which can contain up to 10 records. On bug 5572, I've tried to simplify the authorities merge() function. On the road, I introduced a new function that gather info from auth_type, auth_subfield_structure, and marc_subfield_structure. A data structure represents all authority types. It can be something like that: GEO: type: GEO tag: 151 letters: 68abvxyz bibtags: 691 PERSO_NAME: type: PERSO_NAME tag: 100 letters: 68abcdefghjklmnopqrstvxyz THEME: type: THEME tag: 150 letters: 68abvxyz bibtags: 690|691 This can be cached. From that, we have all info needed by Koha code manipulating authorities, without having to go back to DB tables containing authorities definitions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 --- Comment #8 from Marc Véron --- Note: I amended "Bug 4078 - Display active currency symbol on currency output and input" in a way that it can be tested on top of this bug. (But it does not depend on this bug nor blocks this bug). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Marc Véron changed: What|Removed |Added Attachment #45877|0 |1 is obsolete|| --- Comment #18 from Marc Véron --- Created attachment 45878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45878&action=edit Bug 4078 - Display active currency symbol on currency output and input Display active currency using international formatting patterns and active currency symbol withplugin price. To test: - Apply patch - Make sure that you have defined an active currency in Home > Administration > Currency & Exchange rates - Search for Syspref 'Currency Format' - Select a formatting pattern from the drop down list - Go to a page that uses Price formatting and verify that currency symbol displays wheere price formatting is applied (git grep '| $Price') (Amended patch to remove example opac-user.tt. To test with OPAC see bug 15374) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Marc Véron changed: What|Removed |Added Attachment #43320|0 |1 is obsolete|| --- Comment #17 from Marc Véron --- Created attachment 45877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45877&action=edit Bug 4078 - Display active currency symbol on currency output and input Display active currency using international formatting patterns and active currency symbol withplugin price. To test: Without patch: - Go to 'Your summary'. The amount appears in the tab 'Credits'rsp. 'Fines' - Apply patch - Make sure that you have defined an active currency in Home > Administration > Currency & Exchange rates - Search for Syspref 'Currency Format' - Select a formatting pattern from the drop down list - Go to a page that uses Price formatting and verify that currency symbol displays wheere price formatting is applied (git grep '| $Price') (Amended patch to remove example opac-user.tt. To test with OPAC see bug 15374) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
