[Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381
--- Comment #12 from Frédéric Demians ---
(In reply to Martin Renvoize from comment #11)
> Comment on attachment 45903 [details] [review]
> Bug 15381: Fix error in SearchAuthorities when no authtypecode
>
> Review of attachment 45903 [details] [review]:
> -
>
> ::: C4/AuthoritiesMarc.pm
> @@ +291,5 @@
> > my %newline;
> > $newline{authid} = $authid;
> > if ( !$skipmetadata ) {
> > +my $auth_tag_to_report;
> > +$auth_tag_to_report =
> > Koha::Authority::Types->find($authtypecode)->auth_tag_to_report
>
> Does this not just move the error further downstream in the code, as you
> will now just be passing an undefined $auth_tag_to_report to line 298
> instead. Under what circumstance might $authtypecode be undefined in the
> first place?
This is how it was before Jonathan patch. The quick fix just restores the
previous operation. Without the patch, it was failing for me on line 295:
Koha::Authority::Types->find($authtypecode) was returning undef. With the
patch, it works how it used to.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381
--- Comment #11 from Martin Renvoize ---
Comment on attachment 45903
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45903
Bug 15381: Fix error in SearchAuthorities when no authtypecode
Review of attachment 45903:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15381&attachment=45903)
-
::: C4/AuthoritiesMarc.pm
@@ +291,5 @@
> my %newline;
> $newline{authid} = $authid;
> if ( !$skipmetadata ) {
> +my $auth_tag_to_report;
> +$auth_tag_to_report =
> Koha::Authority::Types->find($authtypecode)->auth_tag_to_report
Does this not just move the error further downstream in the code, as you will
now just be passing an undefined $auth_tag_to_report to line 298 instead.
Under what circumstance might $authtypecode be undefined in the first place?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381
--- Comment #10 from Martin Renvoize ---
Comment on attachment 45903
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45903
Bug 15381: Fix error in SearchAuthorities when no authtypecode
Review of attachment 45903:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15381&attachment=45903)
-
::: C4/AuthoritiesMarc.pm
@@ +291,5 @@
> my %newline;
> $newline{authid} = $authid;
> if ( !$skipmetadata ) {
> +my $auth_tag_to_report;
> +$auth_tag_to_report =
> Koha::Authority::Types->find($authtypecode)->auth_tag_to_report
Does this not just move the error further downstream in the code, as you will
now just be passing an undefined $auth_tag_to_report to line 298 instead.
Under what circumstance might $authtypecode be undefined in the first place?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15405] XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15405 --- Comment #4 from David Cook --- (In reply to Nicholas van Oudtshoorn from comment #3) > Thanks David - let's hope someone can sign off on it soon! :-) I'll put it on my "to do" list for the New Year, but hopefully someone gets to it before I try to find the time! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15380] Move the authority types related code to Koha::Authority::Type[s] - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize --- Another long needed foundations overhaul, well done Jonathan. Passing QA, no regressions found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15380] Move the authority types related code to Koha::Authority::Type[s] - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 Martin Renvoize changed: What|Removed |Added Attachment #45782|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 45934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45934&action=edit Bug 15380: Use Koha::Authority::Type[s] in admin script This path rewrites the admin/authtypes.pl script to use the new modules instead of executing the SQL queries from the script. Test plan: 1/ Create 1+ authority types 2/ Update one 3/ Delete it 4/ Create an authority record using this authority type. 5/ Try to delete the authority type Here there is a change in the behavior. Prior to this patch, the user was able to delete the authority type, now it's not. I think it was a bug, feel free to give your opinion if you disagree on this change. Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15380] Move the authority types related code to Koha::Authority::Type[s] - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 Martin Renvoize changed: What|Removed |Added Attachment #45781|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 45933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45933&action=edit Bug 15380: Introduce Koha::Authorit[y|ies] and Koha::Authority::Type[s] Based on Koha::Objects. Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15380] Move the authority types related code to Koha::Authority::Type[s] - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 Martin Renvoize changed: What|Removed |Added Attachment #45780|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 45932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45932&action=edit Bug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority The existing Koha::Authority does not use Koha::Objects and does not exclusively deal with DB objects. It makes much sense to move it to let the space free for a Koha::Authority and Koha::Authorities modules based on Koha::Object. Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #29 from Martin Renvoize --- More foundational work, well done Jonathan. Not found any regressions and code is much tidier now :) Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Martin Renvoize changed: What|Removed |Added Attachment #45765|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 45931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45931&action=edit Bug 15295! Koha::Libraries - Remove ModBranchCategoryInfo This has been replaced with Koha::Library->update_categories and Koha::Library->add_to_categories Signed-off-by: Martin Renvoize http://bugs.koha-community.org/show_bug.cgi?id=15294 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Martin Renvoize changed: What|Removed |Added Attachment #45763|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 45929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45929&action=edit Bug 15295: Koha::Libraries - Remove GetCategoryTypes 'searchdomain' and 'properties' were hardcoded in this subroutine. Now there are in the admin script. Not a big deal, we could improve that later if someone wants to add a third values. Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize http://bugs.koha-community.org/show_bug.cgi?id=15294 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Martin Renvoize changed: What|Removed |Added Attachment #45764|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 45930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45930&action=edit Bug 15295: Koha::Libraries - Remove GetBranchesCount This is replaced with Koha::Libraries->search->count. Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize http://bugs.koha-community.org/show_bug.cgi?id=15294 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Martin Renvoize changed: What|Removed |Added Attachment #45757|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 45927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45927&action=edit Bug 15295: Koha::Libraries - Remove GetBranchCategory This has been replaced with Koha::Libraries->find Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize http://bugs.koha-community.org/show_bug.cgi?id=15294 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Martin Renvoize changed: What|Removed |Added Attachment #45756|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 45926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45926&action=edit Bug 15295: Koha::Libraries - Remove CheckBranchCategorycode This verification is now done in admin/branches.pl, no need for a special subroutine/method, it's 1 line only called once. Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize http://bugs.koha-community.org/show_bug.cgi?id=15294 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Martin Renvoize changed: What|Removed |Added Attachment #45755|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize --- Created attachment 45925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45925&action=edit Bug 15295: Koha::Libraries - Remove CheckCategoryUnique This subroutine is not used anymore and was not really useful. The branchcategories table has a primary key defined on categorycode. Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize http://bugs.koha-community.org/show_bug.cgi?id=15294 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Martin Renvoize changed: What|Removed |Added Attachment #45754|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 45924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45924&action=edit Bug 15295: Koha::Libraries - Remove DelBranch and DelBranchCategory These 2 subroutines are not used anymore, there were only used from the admin script rewrote on bug 15294. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Martin Renvoize changed: What|Removed |Added Attachment #45760|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 45928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45928&action=edit Bug 15295: Koha::Libraries - Remove GetBranchCategories Test plan 1/ enable OpacAddMastheadLibraryPulldown 2/ Defined a group of libraries as searchdomain and tick 'show in pull down' 3/ At the OPAC, go on the advanced search form, limit by the group of libraries you have just created. 4/ The group should be selected by default in the dropdown list Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize http://bugs.koha-community.org/show_bug.cgi?id=15294 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #8 from Martin Renvoize --- Much needed architectural work, which I can't find any regressions in. Passing QA, well done Jonathan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Martin Renvoize changed: What|Removed |Added Attachment #45747|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 45923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45923&action=edit Bug 15294: Koha::Libraries - Rewrite the admin scripts This patch rewrites the admin/branches.pl script to use the new modules instead of C4::Branches. Test plan: 1/ Create libraries using all the fields available 2/ Create groups of libraries 3/ Assign 1+ libraries to some groups 4/ Delete libraries and groups of libraries You should not able to delete a library if items or patrons use it. You should not able to delete a group of libraries if there are still libraries using it. 5/ Update libraries and groups of libraries Followed test plan, works as expected. Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Martin Renvoize changed: What|Removed |Added Attachment #45746|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 45922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45922&action=edit Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] There was already 2 Koha::Branch[es] using Koha::Object[s] before. For this new rewrite, it seems preferable to start with good basis and name the new modules Koha::Library and Koha::Libraries. Tested both patches together, works as expected. Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15405] XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15405 --- Comment #3 from Nicholas van Oudtshoorn --- Thanks David - let's hope someone can sign off on it soon! :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15405] XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15405 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- Nice one, Nicholas. This is also an issue on openSUSE. We just made a symlink between /usr/lib/idzebra-2.0 and /usr/lib64/idzebra-2.0 to get around this issue, but it would be good to have this properly fixed via this patch. I haven't tested this, as I don't have time at the moment, but it looks good at a glance. Very helpful patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15416] New: Warns on Guided Reports page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416 Bug ID: 15416 Summary: Warns on Guided Reports page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcha...@gmail.com Reporter: aleishaamo...@hotmail.com QA Contact: testo...@bugs.koha-community.org guided_reports.pl: Use of uninitialized value $phase in string eq at /home/vagrant/kohaclone/reports/guided_reports.pl line 52 guided_reports.pl: Use of uninitialized value $phase in string eq at /home/vagrant/kohaclone/reports/guided_reports.pl line 52 guided_reports.pl: Use of uninitialized value $phase in string eq at /home/vagrant/kohaclone/reports/guided_reports.pl line 55 To reproduce, go to Tools -> Guided reports wizard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15415] New: Warn when creating new printer profile for patron card creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Bug ID: 15415 Summary: Warn when creating new printer profile for patron card creator Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: aleishaamo...@hotmail.com QA Contact: testo...@bugs.koha-community.org edit-profile.pl: profile_id is currently undefined. at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 187 To reproduce, go to Tools -> Patron Card Creator -> New profile -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15414] New: Noisy warns when creating new layout for patron card creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15414 Bug ID: 15414 Summary: Noisy warns when creating new layout for patron card creator Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: aleishaamo...@hotmail.com QA Contact: testo...@bugs.koha-community.org edit-layout.pl: Use of uninitialized value $field in numeric lt (<) at /home/vagrant/kohaclone/patroncards/edit-layout.pl line 239 edit-layout.pl: Use of uninitialized value $field in concatenation (.) or string at /home/vagrant/kohaclone/patroncards/edit-layout.pl line 239 edit-layout.pl: Use of uninitialized value $field in concatenation (.) or string at /home/vagrant/kohaclone/patroncards/edit-layout.pl line 239 edit-layout.pl: Use of uninitialized value $image in numeric lt (<) at /home/vagrant/kohaclone/patroncards/edit-layout.pl line 247 edit-layout.pl: Use of uninitialized value $image in concatenation (.) or string at /home/vagrant/kohaclone/patroncards/edit-layout.pl line 247 edit-layout.pl: Use of uninitialized value $image in concatenation (.) or string at /home/vagrant/kohaclone/patroncards/edit-layout.pl line 247. To reproduce, go to Tools -> Patron Card Creator -> New layout -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15413] Adding colons where they should appear in forms etc to be consistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15413 --- Comment #2 from Aleisha Amohia --- Something for a rainy day :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15413] Adding colons where they should appear in forms etc to be consistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15413 --- Comment #1 from Aleisha Amohia --- Created attachment 45921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45921&action=edit Bug 15413: Adding colons where appropriate To test: Apply patch and go to pretty much every page on the Intranet - look out for labels on forms etc where there should be colons but aren't. If you see any that I've missed but I'm 99% sure I got all of them! Make sure to click through some forms where creating a new thing involves continuing the submission on multiple pages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15413] Adding colons where they should appear in forms etc to be consistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15413 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15413] New: Adding colons where they should appear in forms etc to be consistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15413 Bug ID: 15413 Summary: Adding colons where they should appear in forms etc to be consistent Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamo...@hotmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15411] "Non fiction" is incorrect
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15411] "Non fiction" is incorrect
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 --- Comment #1 from Aleisha Amohia --- Created attachment 45920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45920&action=edit Bug 15411: Changing 'Non fiction' to 'Non-fiction' To test: 1) Apply patch 2) Run updatedatabase.pl 3) Go to advanced search in Staff Client (ie /cgi-bin/koha/catalogue/search.pl) 4) Confirm that it says 'Non-fiction' in the 'Any content' drop-down menu under 'Subtype limits' 5) Go to item search (ie /cgi-bin/koha/catalogue/itemsearch.pl) 6) Confirm that it says 'Non-fiction' under 'Collection code' 7) Go to advanced search in OPAC (ie /cgi-bin/koha/opac-search.pl) and click 'More options' 8) Confirm that it says 'Non-fiction' in the 'Content' drop-down menu 9) Go to the details page for a non-fiction book in the OPAC (ie /cgi-bin/koha/opac-detail.pl?biblionumber=2) and click 'Holdings' tab 10) Confirm that it says 'Non-fiction' under 'Collection' heading -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15412] New: Dropdowns in suspend holds date selector do not function in Firefox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15412 Bug ID: 15412 Summary: Dropdowns in suspend holds date selector do not function in Firefox Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: 1 - Place a hold through the opac 2 - View your account->Holds 3 - Click suspend hold 4 - You should be able to select a date using the arrows and calender but the dropdowns do not function. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15411] New: "Non fiction" is incorrect
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 Bug ID: 15411 Summary: "Non fiction" is incorrect Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: aleishaamo...@hotmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl The term "non fiction" is incorrect. Writing a patch which will change "non fiction" to "non-fiction" everywhere in OPAC and Staff Client. I would rather change to "nonfiction" rather than "non-fiction" because eliminating the hyphen takes no meaning away from the term, saves space and uses less characters, and solidifies the term. However Koha uses "non-musical recording" etc, so for consistency's sake, I'll use "non-fiction". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13519] alternate email address not showing on patron record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13519 Aleisha Amohia changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED CC||aleishaamo...@hotmail.com --- Comment #1 from Aleisha Amohia --- This error is fixed in the current version, both my primary and alternate email addresses show appropriately. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14631] Change to "Patron" in patroncard toolbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 --- Comment #12 from Aleisha Amohia --- Created attachment 45919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45919&action=edit Bug 14631: Translatability fix -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohia changed: What|Removed |Added Attachment #45876|0 |1 is obsolete|| --- Comment #11 from Aleisha Amohia --- Created attachment 45918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45918&action=edit Bug 15374 - Translatability: Fix issues on OPAC summary page Fix several issues on opac-user.tt with sentences splitted by tags, leading to odd translations. Additionally, fix a broken link that should point to opac-account.pl To test: - Apply patch - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions (Amended to add price formatting in fines tab label) Can see the warning message now :) signing off Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15410] New: merge authorities not showing records to merge
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15410 Bug ID: 15410 Summary: merge authorities not showing records to merge Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When merging authority records you are presented with nothing on the page that should show the two records you're merging http://screencast.com/t/14zepH4RFrXT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 sandbo...@biblibre.com changed: What|Removed |Added Attachment #45676|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #14 from sandbo...@biblibre.com --- Created attachment 45915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45915&action=edit Bug 11844: Use additional fields for order lines This patch makes use of new module Koha::AdditionalField to provide additional fields to order lines. Once created, these fields can be filled during order line creation or modification. If additional field is linked to a MARC field, then value from biblio record is retrieved at order line creation. When saving order line (at creation or modification), values in additional fields are saved into biblio record. If additional field is linked to an authorised value category, then authorised values are used. If not directly linked to an authorised value category, but linked to a MARC field, a search for a AV category is made on MARC default framework. This patch doesn't display additional fields value anywhere (except in order line creation/modification). Future patches will do that. Test plan: 1/ Go to Acquisitions home 2/ In the left menu, click on "Add order line fields" 3/ Click on "New field" button 4/ Give the field a name (unique), no AV category and no MARC field. 5/ Save. 6/ Create 5 other fields: a/ no AV category, a MARC field not linked to AV category b/ no AV category, a MARC field linked to AV category c/ a AV category, no MARC field d/ a AV category, a MARC field not linked to AV category e/ a AV category, a MARC field linked to another AV category In case of (e), the additional AV category should be used, not the AV category linked to MARC field 7/ Create everything you need to be able to create order lines (supplier, basket, ...) 8/ Create an order line. At bottom of the page, you should see your additional fields, with authorised values dropdrown list for fields (c), (d) and (e) (check this is the right AV category for (e)) 9/ Fill these fields with some data and save order line 10/ check that data was correctly saved into biblio for fields (a), (b), (d) and (e) 11/ modify the same order line, check that values you've filled is correctly retrieved. 12/ modify all values, save, and check biblio once again 13/ create a new order line on the same biblio used for previous order line. check that values are correctly retrieved from biblio Signed-off-by: Harold Dramer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #16 from sandbo...@biblibre.com --- Created attachment 45917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45917&action=edit Bug 11844: Fix additional field values when creating a new order line ordernumber was not correctly retrieved Signed-off-by: Harold Dramer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #15 from sandbo...@biblibre.com --- Created attachment 45916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45916&action=edit Bug 11844: Copy additional fields values when transfering order Signed-off-by: Harold Dramer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 sandbo...@biblibre.com changed: What|Removed |Added Attachment #45675|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 sandbo...@biblibre.com changed: What|Removed |Added Attachment #45674|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 sandbo...@biblibre.com changed: What|Removed |Added CC||sandbo...@biblibre.com Status|Needs Signoff |Signed Off --- Comment #13 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Harold Dramer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #11 from Jonathan Druart --- (In reply to Marc Véron from comment #8) > Sorry, I missed one: > > In Batch patron deletion / anonymization I see a branch restricted category > in the dropdown. > > Category restricted to Midway > Staff meber's library is set to Centerville. > > With patches the category is visible in dropdown (should not) > > Removed patches - now the category is no longer visible (as expected) Ho yes, the entire patch (replace GetBorrowercategoryList) was wrong actually. I have updated it, to use the search_limited instead of search method. Thanks for the catch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart changed: What|Removed |Added Attachment #45909|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 45913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45913&action=edit Bug 15407: Koha::Patron::Categories - replace GetBorrowercategoryList C4::Members::GetBorrowercategoryList returned all the patron categories, ordered by description. This can be done using the search method of the Koha::Patron::Categories module. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by description. - On the "patron attribute types" admin page (admin/patron-attr-types.pl). - On the "Batch patron deletion/anonymization" (tools/cleanborrowers.pl), the dropdown list should be filled correctly. - On the import patron tool - On the following report: reports/reserves_stats.pl Confirm that the patron categories are displayed and that the report still works as before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart changed: What|Removed |Added Attachment #45910|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 45914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45914&action=edit :x Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType This unnecessary complicated subroutine returned an arrayref and an hashref of the patron categories available for the logged in user, for a given category_type, ordered by categorycode. This can now be done with the search_limited method. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by categorycode. - Add/edit a patron, change his/her patron category value. - On the 3 following reports: reports/bor_issues_top.pl reports/borrowers_out.pl reports/cat_issues_top.pl The display for these 3 reports are different than the 2 from the first patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by categorycode and the ones limited to other libraries are not displayed (should certainly be fixed). Note that the big part of this patch has already been tested before (update child related: CATCODE_MULTI). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14594] Permanent withdrawn function
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14594 Josef Moravec changed: What|Removed |Added Assignee|gmcha...@gmail.com |josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14594] Permanent withdrawn function
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14594 Mike changed: What|Removed |Added Change sponsored?|--- |Sponsored CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #8 from Marc Véron --- Sorry, I missed one: In Batch patron deletion / anonymization I see a branch restricted category in the dropdown. Category restricted to Midway Staff meber's library is set to Centerville. With patches the category is visible in dropdown (should not) Removed patches - now the category is no longer visible (as expected) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #7 from Marc Véron --- I went through all tests with all patches applied, no problems found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14594] Permanent withdrawn function
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14594 --- Comment #3 from Josef Moravec --- *** Bug 14241 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14241] Ability to make permanent withdrawn of item (with withdrawn number)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14241 Josef Moravec changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Josef Moravec --- *** This bug has been marked as a duplicate of bug 14594 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15409] Plugins section missing from Admin menu sidebar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15409 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15409] Plugins section missing from Admin menu sidebar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15409 --- Comment #1 from Kyle M Hall --- Created attachment 45912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45912&action=edit Bug 15409 - Plugins section missing from Admin menu sidebar The sidebar menu in the Admin area of Koha is missing a section for Plugins. Test Plan: 1) Apply this patch 2) Log in with a user that has plugin permissions 3) Browse to a page with the admin menu sidebar, such as /cgi-bin/koha/admin/transport-cost-matrix.pl 4) Note the new Plugins section with a link to manage plugins 5) Log in with a user that has no plugin permissions 6) Revisit the same page, note the Plugins section is no longer visible -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15409] Plugins section missing from Admin menu sidebar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15409 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15409] New: Plugins section missing from Admin menu sidebar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15409 Bug ID: 15409 Summary: Plugins section missing from Admin menu sidebar Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The sidebar menu in the Admin area of Koha is missing a section for Plugins. This should be added. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15408] New: Timestamp not updated when you duplicate a budget
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Bug ID: 15408 Summary: Timestamp not updated when you duplicate a budget Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: sophie.meyni...@biblibre.com QA Contact: testo...@bugs.koha-community.org When you duplicate a budget from an existing one, the timestamp is copied from the existing budget rather than set to the time of creation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9181] Add patron messaging preference to Batch Patrons Modification tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9181 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12636] Batch patron modification should not update with unique patron attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12636 Marc Véron changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12636] Batch patron modification should not update with unique patron attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12636 Marc Véron changed: What|Removed |Added Attachment #45881|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 45911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45911&action=edit Bug 12636: Do not display unique patron attributes in the batch patron modification Batch patron modification should not offer to update patron attributes with values which are designated as unique since such attributes are required to be unique to a single patron. Test plan: Create some patron attributes, some should be unique. Use the batch patron modification tool to modify patrons. With this patch, the patron attributes marked as unique won't be display anymore. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10958] no need for home link on home page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958 --- Comment #5 from Marc Véron --- (In reply to Owen Leonard from comment #4) > I would prefer a solution which removed the breadcrumbs from the home page (...) +1 for removing the breadcrumbs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12504] Opac search by Language of the item and zebra @attr 1=54 Broken for Unimarc ?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12504 grharry changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #25 from Kyle M Hall --- Is there any chance you could write up a quick and dirty test plan that includes using these scripts *with* xnciptoolkit. I would really like to be able to test the full end-to-end functionality of this! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #6 from Jonathan Druart --- QA note: A false positive is raised by the qa script *** ERROR: Spurious =cut command at line 1021 in file C4/Members.pm It already exists before this patch set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10958] no need for home link on home page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958 --- Comment #4 from Owen Leonard --- I would prefer a solution which removed the breadcrumbs from the home page to one which changed the expected structure of the bookmarks link. I think it's good to let users make assumptions about what they're going to find in an element like breadcrumbs which might be familiar to them from other sites. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #2 from Jonathan Druart --- Created attachment 45907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45907&action=edit Bug 15407: Koha::Patron::Categories - replace C4::Category->all The C4::Category module contained only 1 method to return the patron categories available for the logged in user. The new method Koha::Patron::Categories->search_limited does exactly the same thing (see tests) and must be used in place of it. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. - On the 'Item circulation alerts' admin page (admin/item_circulation_alerts.pl), modify the settings for check-in and checkout (NOTE: Should not we display all patron categories on this page? If yes, it must be done in another bug report to ease backporting it). - Search for patrons in the admin (budget) and acquisition (order) module. - On the patron home page (search form in the header) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #5 from Jonathan Druart --- Created attachment 45910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45910&action=edit Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType This unnecessary complicated subroutine returned an arrayref and an hashref of the patron categories available for the logged in user, for a given category_type, ordered by categorycode. This can now be done with the search_limited method. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by categorycode. - Add/edit a patron, change his/her patron category value. - On the 3 following reports: reports/bor_issues_top.pl reports/borrowers_out.pl reports/cat_issues_top.pl The display for these 3 reports are different than the 2 from the first patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by categorycode and the ones limited to other libraries are not displayed (should certainly be fixed). Note that the big part of this patch has already been tested before (update child related: CATCODE_MULTI). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #3 from Jonathan Druart --- Created attachment 45908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45908&action=edit Bug 15407: Koha::Patron::Categories - replace GetBorrowercategory The purpose of C4::Members::GetBorrowercategory was to return the patron category for a given categorycode. This can be done easily with the Koha::Patron::Categories->find method. Test plan: - Same prerequisite as before - Edit a guarantor and confirm the information will be updated for his/her guarantee(s). - Update a child to adult patron (Note: Should not we hide the patron categories limited to others libraries? If yes, it must be done on another bug report). There is a special behavior if there is only 1 adult category, the user does not need to select a category. So the same as before with only 1 adult patron category. - Import a patron with a category_code which does not exist. You should be warned. - Modify some patron using the batch patron modification tool. The patron category descriptions should correctly be displayed. Note that the overduerules page has already been tested in a previous patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #1 from Jonathan Druart --- Created attachment 45906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45906&action=edit Bug 15407: Koha::Patron::Categories - remove sql queries in some pl and pm This patch replaces sql queries done in some pl script and in C4::Reports::Guided. Since we have now a Koha::Patron::Categories module, we should use it where it is possible. Test plan: - Prerequisite: Be sure you have several patron categories created, with different option enabled, and limit some to certain libraries. - On the 'Circulation and fine rules' admin page (admin/smart-rules.pl), all the patron categories should be displayed (even the ones limited to another library), ordered by description. Try to add/update existing rules. - On the overdue rules page (tools/overduerules.pl), all the patron categories with overduenoticerequired set should be displayed. Try to add/update existing rules. - On the following reports: reports/borrowers_stats.pl reports/issues_avg_stats.pl The patron categories should be displayed. Note that there is an inconsistency with these 2 reports: the patron categories limited to other libraries are displayed on them, when they are not on the other reports. This should certainly be fixed (on another bug report). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #4 from Jonathan Druart --- Created attachment 45909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45909&action=edit Bug 15407: Koha::Patron::Categories - replace GetBorrowercategoryList C4::Members::GetBorrowercategoryList returned all the patron categories, ordered by description. This can be done using the search method of the Koha::Patron::Categories module. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by description. - On the "patron attribute types" admin page (admin/patron-attr-types.pl). - On the "Batch patron deletion/anonymization" (tools/cleanborrowers.pl), the dropdown list should be filled correctly. - On the following report: reports/reserves_stats.pl Confirm that the patron categories are displayed and that the report still works as before. Note; tools/import_borrowers.pl and tools/modborrowers.pl have already been tested previously. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::Patron::Categories - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart changed: What|Removed |Added Summary|Move the patron categories |Move the patron categories |related code to |related code to |Koha::PatronCategories |Koha::Patron::Categories - ||part 1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] New: Move the patron categories related code to Koha::Patron::Categories - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Bug ID: 15407 Summary: Move the patron categories related code to Koha::Patron::Categories - part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 14836 This second part will move - C4::Category - the subroutines related to the patron categories in C4::Members (GetBorrowercategory, GetBorrowercategoryList and GetborCatFromCatType) - the sql queries in some pl script to Koha::Patron::Categories Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 [Bug 14836] Move the patron categories related code to Koha::PatronCategories -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart changed: What|Removed |Added Blocks||15407 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Magnus Enger changed: What|Removed |Added Attachment #45608|0 |1 is obsolete|| --- Comment #13 from Magnus Enger --- Created attachment 45905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45905&action=edit Bug 15304 - Remove Norwegian strings from nl-search.tt When nl-search.pl gets data from the Norwegian national patron database, it does so in an XML format that has Norwegian element names. nl-search.pl displays the data with the Noregian element names as labels. This means Norwegian words turn up in translations, which is messy. This patch replaces the Norwegian labels with English ones. To test: - Only Norwegian libraries and vendors get access to search against the national patron database, so a proper functional test is not possible - Alternative 1: Just have a look at the nl-search.tt template before and after the patch and verify that after the patch the Norwegian strings that would be visible to a user are gone - Alternative 2: - Verify that e.g. en-GB-staff-prog.po contains the Norwegian string "kjonn" - Apply the patch - Create new .po files with e.g. "./translate create en-GB" - Verify that "kjonn" is now gone from en-GB-staff-prog.po Version 2: Tweak a couple of labels to be more in line with labels used elsewhere in Koha, to avoid variants when translating. Version 3: Replace e.g. "Gender: " with "Gender: " to avoid similar-except-for-whitespace strings in translation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Magnus Enger changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] display patron age in useful places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #3 from Martin Stenberg --- They look related, but not contradicting or overlapping. Bug 15206 seems unnecessary code complex at first glance though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] display patron age in useful places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #2 from Marc Véron --- How is this related to "Bug 15206 - Show patron's age when filling date of birth in memberentry.pl" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What|Removed |Added Depends on||14167 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 [Bug 14167] Add Koha::Logger based on Log4perl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Kyle M Hall changed: What|Removed |Added Blocks||15253 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 [Bug 15253] Add Koha::Logger based logging for SIP2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13177] Add help pages for Rotating collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13177] Add help pages for Rotating collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177 Marc Véron changed: What|Removed |Added Attachment #45891|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 45904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45904&action=edit Bug 13177: Help page for Rotating Collections To test: Go to Tools -> Rotating Collections and click Help in the top-right. Confirm the Help page shows and gives correct accurate instructions with no typos or grammatical errors. Help displays as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10958] no need for home link on home page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4054] Double-clicking the 'place hold' button can result in duplicate holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4054 Marc Véron changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14891 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14891] Attempting to place hold with no item selected freezes the request screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14891
Marc Véron changed:
What|Removed |Added
See Also||http://bugs.koha-community.
||org/bugzilla3/show_bug.cgi?
||id=4054
--- Comment #2 from Marc Véron ---
Reproduced on current master.
It seems to be due to:
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt line 179
$('#hold-request-form').preventDoubleFormSubmit();
The issue goes away if I remove the line with the preventDoubleFormSubmit.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4054#c15
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4054] Double-clicking the 'place hold' button can result in duplicate holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4054
--- Comment #15 from Marc Véron ---
There seems to be some code to prevent double click submit:
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt line 179
$('#hold-request-form').preventDoubleFormSubmit();
Hmm, if I have a JavaScript alert e.g.
"- This patron had already placed a hold on this item"
and I click OK, I get an endless wait cursor!
This issue goes away if I remove the line with the preventDoubleFormSubmit.
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15406] New: Very SLOW OAI server performance
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406 Bug ID: 15406 Summary: Very SLOW OAI server performance Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: dhd.k...@gmail.com QA Contact: testo...@bugs.koha-community.org I noticed a very slow performance on oai server koha version 3.22 ! In particular the query ( SELECT biblioitems.biblionumber, biblioitems.timestamp, marcxml FROM biblioitems JOIN oai_sets_biblios ON biblioitems.biblionumber = oai_sets_biblios.biblionumber WHERE timestamp >= '1970-01-01 00:00:00' AND timestamp <= '2015-12-22 23:59:59' AND oai_sets_biblios.set_id = '4' ) UNION ( SELECT deletedbiblio.biblionumber, null as marcxml, timestamp FROM deletedbiblio JOIN oai_sets_biblios ON deletedbiblio.biblionumber = oai_sets_biblios.biblionumber WHERE DATE(timestamp) >= '1970-01-01T00:00:00Z' AND DATE(timestamp) <= '2015-12-22T23:59:59Z' AND oai_sets_biblios.set_id = '4' ) ORDER BY biblionumber LIMIT 51 OFFSET 0 As constructed by oai.pl Requires about a minute to get results for each fetch! So according to my rough calculations a 500K marcs catalogue would require about 6 days to be harvested! Harry! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4054] Double-clicking the 'place hold' button can result in duplicate holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4054 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #14 from Marc Véron --- (In reply to Liz Rea from comment #1) > http://screencast.com/t/N2RjNmNh > > Shows double clicking the place hold button causing a duplicate hold. There is a question in the screencast: 'If I can't place holds, why could I do it?' Maybe this is related to - place hold on next available item ( bilio level hold) - 'ReservesControlBranch' is set to "Check the [item's home library] to see if the patron can place a hold on the item." See bug 15404 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 Frédéric Demians changed: What|Removed |Added Depends on|5572| Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 [Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Frédéric Demians changed: What|Removed |Added Blocks|15381 | Status|Failed QA |Signed Off --- Comment #36 from Frédéric Demians --- (In reply to Jonathan Druart from comment #35) > (In reply to Frédéric Demians from comment #34) > > Bugs 15380 and 15381 should be pushed to master before refactoring this one > > to use new authorities related classes. > > This can be pushed before the refactoring, I will rebase bug 15381 if needed. OK thanks. So I reset this patch to signed-off. And let see which patch will be pushed first. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 --- Comment #35 from Jonathan Druart --- (In reply to Frédéric Demians from comment #34) > Bugs 15380 and 15381 should be pushed to master before refactoring this one > to use new authorities related classes. This can be pushed before the refactoring, I will rebase bug 15381 if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Frédéric Demians changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 --- Comment #34 from Frédéric Demians --- Bugs 15380 and 15381 should be pushed to master before refactoring this one to use new authorities related classes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 Frédéric Demians changed: What|Removed |Added Depends on||5572 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 [Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Frédéric Demians changed: What|Removed |Added Blocks||15381 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 --- Comment #9 from Frédéric Demians --- Created attachment 45903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45903&action=edit Bug 15381: Fix error in SearchAuthorities when no authtypecode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 Frédéric Demians changed: What|Removed |Added Attachment #45707|0 |1 is obsolete|| --- Comment #8 from Frédéric Demians --- Created attachment 45902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45902&action=edit Bug 15381: Remove GetAuthType and GetAuthTypeCode Test this patch with the previous one. Signed-off-by: Frédéric Demians -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
