[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson changed: What|Removed |Added Attachment #45845|0 |1 is obsolete|| --- Comment #10 from Martin Persson --- Created attachment 45935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45935&action=edit Bug 14272: Show single news item (backend) Updates: * Date formatting added to get_opac_new() * Proper filtering by way of GetNewsToDisplay Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson changed: What|Removed |Added Attachment #45820|0 |1 is obsolete|| --- Comment #11 from Martin Persson --- Created attachment 45936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45936&action=edit Bug 14272: Show single news item (OPAC) This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nees item heading should be clickable. * When clicked only that item should be shown. * When 'news_id' is present, only a single news item should show. * The breadcrumb should say 'News item' after 'Home'. Updates: * Renamed URL parameter and local variables with 'news_' prefix. * Fixed Search-And-Replace error; 'news_news_id' => 'news_id' * Added breadcrumb for viewing single news item. * Updated OPAC to use new GetNewsToDisplay parameters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15417] New: Status for duplicate SMS messages should not be 'failed'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15417 Bug ID: 15417 Summary: Status for duplicate SMS messages should not be 'failed' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: sophie.meyni...@biblibre.com QA Contact: testo...@bugs.koha-community.org Bug 11209 introduces the functionnality not to send multiple SMS with the same content to the same borrower in one day. As it is the expected behavior, the status of duplicate notices should not be set to 'failed' but to 'cancelled' or 'duplicate', to make the difference with notices that really failed and maybe have a specific treatment (send again, phone call, etc...) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15417] Status for duplicate SMS messages should not be 'failed'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15417 Sophie MEYNIEUX changed: What|Removed |Added Depends on||11209 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 [Bug 11209] Multi transport types: same messages are sent for a patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 Sophie MEYNIEUX changed: What|Removed |Added Blocks||15417 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15417 [Bug 15417] Status for duplicate SMS messages should not be 'failed' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15417] Status for duplicate SMS messages should not be 'failed'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15417 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12426 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=15417 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.dru...@bugs.koha-c |koha-b...@lists.koha-commun |ommunity.org|ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #10 from Jonathan Druart --- >From the doc http://search.cpan.org/~ribasushi/DBIx-Class-0.082820/lib/DBIx/Class/ResultSet.pm#reset "Implicitly resets the storage cursor, so a subsequent "next" will trigger another query." It is not a limitation or a bug, but a feature. I am not sure it's a good idea to make our methods behave differently than the DBIx::Class ones. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #11 from Jonathan Druart --- CCing Martin to get another feedback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #9 from Jonathan Druart
---
(In reply to Marc Véron from comment #8)
> (In reply to Jonathan Druart from comment #7)
> > Comment on attachment 45873 [details] [review] [review]
> > Bug 14015 - Checkout: Fix software error if barcode '0' is given
> >
> > Review of attachment 45873 [details] [review] [review]:
> > -
> >
> > ::: circ/circulation.pl
> > @@ +217,5 @@
> > > }
> > >
> > > # check and see if we should print
> > > +# but do not set to 'yes' if barcode given by user is '0'
> > > +if ( ( @$barcodes == 0 ) && ( ! @$barcodes eq '0') && ( $print eq
> > > 'maybe' ) ) {
> >
> > What is supposed to test !@$barcodes eq '0' ??
>
> Hi Jonathan,
>
> The first (already existing) part @$barcodes == 0 tests @$barcodes for
> numerical equality (no barcodes given). While testing I found out that it
> evaluates to true for a barcode that is '0'. Because it evaluated to true
> with a barcode '0', $print was set to 'yes' (but we do not want to print,
> since we have a barcode). With $print set to 'yes' the borrowernumber is set
> to '' in line 235, and that leads to the software error in line 473.
> By adding a test for the barcode not to be equal to '0' by the string
> equality oparator eq ( ! @$barcodes eq '0'), the value of $print is not set
> to 'yes' and the barcode '0' is treated as such. Koha will then display the
> message 'The barcode was not found 0' (as expected)
my $a = ['0'];
say "1.is 0" if @$a eq '0';
$a = [0];
say "2.is 0" if @$a eq '0';
Does not print anything.
I have tried your changes and remove the last 2 tests and everything looks ok.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson changed: What|Removed |Added Attachment #45936|0 |1 is obsolete|| --- Comment #12 from Martin Persson --- Created attachment 45937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45937&action=edit Bug 14272: Show single news item (OPAC) This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nees item heading should be clickable. * When clicked only that item should be shown. * When 'news_id' is present, only a single news item should show. * The breadcrumb should say 'News item' after 'Home'. Updates: * Renamed URL parameter and local variables with 'news_' prefix. * Fixed Search-And-Replace error; 'news_news_id' => 'news_id' * Added breadcrumb for viewing single news item. * Updated OPAC to use new GetNewsToDisplay parameters * Fixed template formatting and calling of GetNewsToDisplay -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078
--- Comment #20 from Jonathan Druart
---
Comment on attachment 45888
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45888
Bug 4078 - Display active currency symbol on currency output and input
Review of attachment 45888:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=4078&attachment=45888)
-
You will have to write tests.
I don't think it's the good approach. What about the other cases?
For instance : "-£127.54" vs "-127,54 €", you will have to add 3 values.
I think that what you are trying to add with this patch should be done at the
currency level (currency table), not the syspref.
Actually the syspref should be removed.
::: Koha/Number/Price.pm
@@ +79,4 @@
>
> sub _format_params {
> my ( $self, $params ) = @_;
> +my $with_symbol = $params->{with_symbol};
You do you remove this default value, it does not look mandatory.
@@ +96,5 @@
> +$p_cs_precedes = 1 unless ( defined $p_cs_precedes );
> +}
> +
> +if ( $currency_format =~ m/(_TRAIL)/ ) {
> +$p_cs_precedes = 0 unless ( defined $p_cs_precedes );
You are mixing ternary operator in the conditions, it does not make the code
easy to read.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #21 from Jonathan Druart --- (In reply to Jonathan Druart from comment #20) > You do you remove this default value, it does not look mandatory. s/You/Why -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart --- Kyle, please provide tests for this new feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15418] New: Switch Net::Server personality in sipserver to Fork
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15418 Bug ID: 15418 Summary: Switch Net::Server personality in sipserver to Fork Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Experience showed that using the pre-fork personality of Net::Server was using up resources for no benefit and that configuring the numbers in the config could be confusing. For the past year I've been running a a version using the Fork personality at our sites which use sipserver heavily both for self check and user authentication. Results seem more stable running for months and freeing resourses when connections close, with only sendig a SIGHUP to the controlling process to reread config and close active children. This merges the version we've been running back into the standard. Testing : As opposed to the pre-fork behaviour this will start up a single controlling instance to listem on the specified ports. Child processs will be created to handle handle sip connections and shutdown when the client closes the socket -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #149 from Jonathan Druart --- Héctor, I have just found a minor issue: At the OPAC, there is no radio buttons selected by default, so if you click on export, you get a iso2709. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Matthias Meusburger changed: What|Removed |Added Attachment #36679|0 |1 is obsolete|| --- Comment #70 from Matthias Meusburger --- Created attachment 45938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45938&action=edit BZ7677: New areas in subscriptions and new functions when receiving. When enabling the makePreviousSerialAvailable syspref, the previously received serial's itemtype is set as defined in the subscription. (Please note that the item-level_itypes syspref must be set to specific item.) It is also made available. Signed-off-by: Brendan Gallagher http://bugs.koha-community.org/show_bug.cgi?id=7767 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Matthias Meusburger changed: What|Removed |Added Attachment #36680|0 |1 is obsolete|| --- Comment #72 from Matthias Meusburger --- Created attachment 45940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45940&action=edit Bug 7677: UT: add unit tests for GetPreviousSerialid Signed-off-by: Brendan Gallagher http://bugs.koha-community.org/show_bug.cgi?id=7767 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Matthias Meusburger changed: What|Removed |Added Attachment #45938|0 |1 is obsolete|| --- Comment #71 from Matthias Meusburger --- Created attachment 45939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45939&action=edit BZ7677: New areas in subscriptions and new functions when receiving. When enabling the makePreviousSerialAvailable syspref, the previously received serial's itemtype is set as defined in the subscription. (Please note that the item-level_itypes syspref must be set to specific item.) It is also made available. Signed-off-by: Brendan Gallagher http://bugs.koha-community.org/show_bug.cgi?id=7767 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Matthias Meusburger changed: What|Removed |Added Attachment #36681|0 |1 is obsolete|| --- Comment #73 from Matthias Meusburger --- Created attachment 45941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45941&action=edit Bug 7677: FIX QA issues FAILC4/Serials.pm FAIL forbidden patterns forbidden pattern: trailing space char (line 1501) forbidden pattern: trailing space char (line 921) FAILserials/serials-edit.pl FAIL valid "my" variable $dbh masks earlier declaration in same scope Signed-off-by: Brendan Gallagher http://bugs.koha-community.org/show_bug.cgi?id=7767 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Matthias Meusburger changed: What|Removed |Added Attachment #42924|0 |1 is obsolete|| --- Comment #75 from Matthias Meusburger --- Created attachment 45943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45943&action=edit BZ7677 [Follow-up]: New areas in subscriptions and new functions when receiving. - Various fixes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Matthias Meusburger changed: What|Removed |Added Attachment #36682|0 |1 is obsolete|| --- Comment #74 from Matthias Meusburger --- Created attachment 45942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45942&action=edit Bug 7677: Fix tests They don't pass since bug 12098 has been pushed. Signed-off-by: Brendan Gallagher http://bugs.koha-community.org/show_bug.cgi?id=7767 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Matthias Meusburger changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #76 from Matthias Meusburger --- Rebased. And moved SQL update from updatedatabase to atomic update. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #7 from Jonathan Druart --- Should not we display the value (readonly) if it exists? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15418] Switch Net::Server personality in sipserver to Fork
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15418 Colin Campbell changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell --- Created attachment 45944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45944&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Julian, there is a "searchable" flag in the additional_fields table, I think you should use it to know if we want to display fields in the search form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #10 from Colin Campbell --- (In reply to Larry Baerveldt from comment #9) > Like Kyle, I am concerned about regression. The issue addressed by Bug 13432 > was a very serious one for us, and affected virtually every site using SIP. > New child processes were continually being created throughout the day, and > older child processes were never dying. In some cases the number of SIP > processes would literally max out the RAM. We had to introduce daily > restarts of SIP in our crons, and for some sites, even that was not enough. > And Bug 13432 DID fix that problem. > > As to the problem of the timeout logic causing dropped connections post > 13432, we simply fixed that on our servers by increasing the timeout in the > Service and Institution levels to 360. That worked for most SIP vendors. > > That said, I think this patch would be okay if it includes Kyle's suggestion > to have the client_timeout default to the timeout if not defined. If you apply the change in bug 15418 do you still see this problem? In Pre-Fork child processes should not die - but my suspicion is that due to the rather awkward way the callback was originally implemented they are not always left in a state ready to be reused. In part to deal with those problems I started using Fork in production and it seems more reliable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15419] New: Sipserver problem with stale db handles
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419 Bug ID: 15419 Summary: Sipserver problem with stale db handles Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com This is a very intermittent problem which appears to manifest in two ways and to date from when C4::Context->dbh stopped using ping way back in commit 4ae3665ad8afb5d283d989c4622a91690e1c4f8a Stale dbh remains active. This was seen on clients which are up for 24 hours, when after 12hours or so of only sending status requests (which do require db access) a real request comes in the database handle which should be refreshed is not but is treated as valid. e.g. a valid patron is entered but the sip server returns it as invalid (the undef returned from the invalid dbh is indistinguishable from returning 0 rows) - In practice I've circumvented this by getting the sepserver to restart all persistent connections at e.g. 6 or 7 am so that the reconnecting devices get a fresh db connection. Another possible solution may be to force a dbh connect in processing a status request. Second manifestation is in authentication I found that intermittently a login was being rejected with 'maintenence' or 'failure' this being the status return from check_api_auth unjustified in both cases. This may be a single occurence, a cluster of occurences and seems to then correct itself I've installed a kludge that does a ping using the dbh returned by context before calling check_api_auth, so far so good, but the intermittent nature of the prob means that I need to continue monitoring -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Marc Véron changed: What|Removed |Added Assignee|ve...@veron.ch |oleon...@myacpl.org --- Comment #22 from Marc Véron --- (In reply to Jonathan Druart from comment #20) > Comment on attachment 45888 [details] [review] > (...) should be done at the currency level (currency table), not the syspref. > Actually the syspref should be removed. > (...) Hi Jonathan, your approach will be better, for sure. I remove assignement from this long outstanding bug and will be happy to sign-off your solution. I simply hope that we soon have the possibility to display currency symbols and more currency formatting than the US and French ones only, e.g. 360'000.00 for Switzerland. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 --- Comment #12 from Martin Renvoize --- Totally agree with Jonathan here, I don't understand the point of this at all.. the idea of reset is to allow one to re-execute the query in the case that the data in the database may have changed between resultset usage. If you want to make it more likely $kyle1 == $kyle2 then add an order_by into the search. (but of course, this won't ensure unless of course you're ordering by id and you've not changed the original object at in the database) I've not looked into the code yet, but just on the description I'm not really sure what problem it's attempting to resolve. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 --- Comment #13 from Martin Renvoize --- OK, So, you're always calling ->all on he dbic resultset, even when you may only actually want the ->first result :(. Bad mojo, this is a big memory leak in my opinion. Yes calling ->all is a good idea when you know you want the full set (or you know the full set will always be sufficiently small that your not worried about the memory overhead, but calling it for all requests is just asking for trouble in my opinion. We should be encouraging thought behind these calls and good practice. Not coding around other coders deficiencies.. that's what QA is for, spotting such performance mistakes during QA time. All in all, this gets a definitive thumbs down from me -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15412] Dropdowns in suspend holds date selector do not function in Firefox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15412 Owen Leonard changed: What|Removed |Added Severity|enhancement |normal --- Comment #1 from Owen Leonard --- Checking out the original commit, it looks as if it never worked. Either that or Firefox has changed somehow in the past year to break it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15420] New: MARC21: Place of publication - Index 751$a with $4pup like 260$c
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15420 Bug ID: 15420 Summary: MARC21: Place of publication - Index 751$a with $4pup like 260$c Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org 751$a can contain the place of publication, if $4 is set to pup. In some cases this can be important information and should be searchable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15412] Dropdowns in suspend holds date selector do not function in Firefox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15412 --- Comment #2 from Owen Leonard --- Possible solution: http://stackoverflow.com/questions/13649459/twitter-bootstrap-multiple-modal-error/19190216#19190216 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 --- Comment #26 from Kyle M Hall --- FYI, I tried to install xncip2toolkit via your dockerfile ( https://github.com/moravianlibrary/xcncip2toolkit/tree/master/dockerfile ) and it failed: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile (default-compile) on project koha-jar: Compilation failure [ERROR] /home/xcncip2toolkit/xcncip2toolkit/connectors/koha/3.xx/trunk/jar/src/main/java/org/extensiblecatalog/ncip/v2/koha/KohaLookupItemService.java:[93,59] error: unreported exception ParseException; must be caught or declared to be thrown [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :koha-jar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #45905|0 |1 is obsolete|| --- Comment #14 from Bernardo Gonzalez Kriegel --- Created attachment 45945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45945&action=edit [SIGNED-OFF] Bug 15304: Remove Norwegian strings from nl-search.tt When nl-search.pl gets data from the Norwegian national patron database, it does so in an XML format that has Norwegian element names. nl-search.pl displays the data with the Noregian element names as labels. This means Norwegian words turn up in translations, which is messy. This patch replaces the Norwegian labels with English ones. To test: - Only Norwegian libraries and vendors get access to search against the national patron database, so a proper functional test is not possible - Alternative 1: Just have a look at the nl-search.tt template before and after the patch and verify that after the patch the Norwegian strings that would be visible to a user are gone - Alternative 2: - Verify that e.g. en-GB-staff-prog.po contains the Norwegian string "kjonn" - Apply the patch - Create new .po files with e.g. "./translate create en-GB" - Verify that "kjonn" is now gone from en-GB-staff-prog.po Version 2: Tweak a couple of labels to be more in line with labels used elsewhere in Koha, to avoid variants when translating. Version 3: Replace e.g. "Gender: " with "Gender: " to avoid similar-except-for-whitespace strings in translation. Signed-off-by: Bernardo Gonzalez Kriegel A few new strings, all previous removed. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #82 from Kyle M Hall --- Created attachment 45947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45947&action=edit Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What|Removed |Added Attachment #44916|0 |1 is obsolete|| Attachment #44917|0 |1 is obsolete|| Attachment #44918|0 |1 is obsolete|| Attachment #44919|0 |1 is obsolete|| Attachment #44920|0 |1 is obsolete|| Attachment #44921|0 |1 is obsolete|| Attachment #44922|0 |1 is obsolete|| Attachment #44923|0 |1 is obsolete|| Attachment #44924|0 |1 is obsolete|| Attachment #44925|0 |1 is obsolete|| Attachment #44926|0 |1 is obsolete|| --- Comment #81 from Kyle M Hall --- Created attachment 45946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45946&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #83 from Kyle M Hall --- Created attachment 45948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45948&action=edit Bug 14610 - Add and update scripts Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #84 from Kyle M Hall --- Created attachment 45949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45949&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #85 from Kyle M Hall --- Created attachment 45950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45950&action=edit Bug 14610 [QA Followup] - Rename AR_PRINT to AR_SLIP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #86 from Kyle M Hall --- Created attachment 45951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45951&action=edit Bug 14610 [QA Followup] - Remove bad copyright lines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #87 from Kyle M Hall --- Created attachment 45952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45952&action=edit Bug 14610 [QA Followup] - Fix issuingrules database update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #88 from Kyle M Hall --- Created attachment 45953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45953&action=edit Bug 14610 [QA Followup] - Make prompt tranlatable, only show comma if firstname is set -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #90 from Kyle M Hall --- Created attachment 45955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45955&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #89 from Kyle M Hall --- Created attachment 45954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45954&action=edit Bug 14610 [QA Followup] - Change 'Open' to 'Pending' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #91 from Kyle M Hall --- Created attachment 45956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45956&action=edit Bug 14610 - Update opac.css via less -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15421] New: Show all available actions in reports toolbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15421 Bug ID: 15421 Summary: Show all available actions in reports toolbar Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/reports/guided_reports.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Reports Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org The "Actions" dropdown on the main list of saved reports has a few actions which are not available in the reports toolbar: Duplicate, Schedule, and Delete. These should be available as toolbar buttons on saved reports pages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #11 from Larry Baerveldt --- We haven't seen the problem (of outrageous growth in number of SIP processes) since Bug 13432 was applied, so there's no way to see if 15418 helps any with that or not. As noted, Bug 13432 solved a very huge problem for us, and any issues with SIP devices timing out was easily solved by adjusting the timeout settings in SIPconfig.xml. We just don't want to see anything that may regress that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022
--- Comment #21 from Kyle M Hall ---
(In reply to Tomás Cohen Arazi from comment #20)
> I think this should be solved on indexing, no calculation on what is the
> status of the records/items should be done on rendering the results page.
>
> If you take a look at C4::Circulation::{AddIssue|AddReturn} you will notice
> that they call C4::Items::ModItem, which ultimately calls ModZebra...
>
> So we should always assume the data we retrieve from Zebra is current... and
> no calculation should be done outside the resultset...
>
> I belive at some point we messed up things A LOT (by adding the
> thing in the XSLT step... but until someone rewrites all that... I think we
> should do the search engine-way.
So what steps do we need to take to resolve this? It sounds like we need to
create an availability index. This would also mean we need to re-index whenever
other tables related to items change ( transfers and reserves at the least ).
I think that this patch could be pushed in the meantime as a band-aid at least,
until we can get such a system in place.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15410] merge authorities not showing records to merge
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15410 Craig changed: What|Removed |Added CC||bassplay...@hotmail.com --- Comment #1 from Craig --- Hi Nicole, This might be a duplicate of Bug 15358. I and several other have reported the same. Craig -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Kyle M Hall changed: What|Removed |Added Attachment #38476|0 |1 is obsolete|| Attachment #38477|0 |1 is obsolete|| Attachment #38478|0 |1 is obsolete|| --- Comment #22 from Kyle M Hall --- Created attachment 45957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45957&action=edit Bug 13022 - Hardcoded limit causes records with more than 20 items to show inaccurate statuses If a record has more than 20 items, all the items over 20 will show as available on the search results even if they are not! This is a hard coded limit in the Search module. This number should be configurable. Test Plan: 1) Create a record with more than 20 items 2) Set all the items to waiting holds or in transit 3) Search for results that will include that item 4) Note some say they are available even though they are not 5) Apply this patch 6) Run updatedatabase.pl 7) Set the new system preference MaxSearchResultsItemsPerRecordStatusCheck to a number larger than the number of items on your record 8) Re-run the search 9) Note that the hold and transit statuses for the items are now correct Signed-off-by: Andreas Hedström Mace Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 --- Comment #23 from Kyle M Hall --- Created attachment 45958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45958&action=edit Bug 13022 [QA Followup] - Allow the pref to be unset for unlimited item status checks Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 --- Comment #24 from Kyle M Hall --- Created attachment 45959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45959&action=edit Bug 13022 [QA Followup] - Highlight the results with inaccurate status, add explanation when mouse hovers over. Bug 13022 [QA Followup] - Revert changes in whitespace back to original for items count lines Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15405] XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15405 Chris Cormack changed: What|Removed |Added Attachment #45896|0 |1 is obsolete|| --- Comment #5 from Chris Cormack --- Created attachment 45960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45960&action=edit Bug 15405 - XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux Adjusts the modulePath to search in the well-known location for 64 bit systems. Required for at least Fedora. Test plan: Without this patch, doing a zebra reindex on a fedora-based install will cause errors like this: 15:10:47-01/05 zebraidx(16108) [warn] No such record type: dom./etc/koha/zebradb/biblios/etc/dom-config.xml With this patch, reindexing should just work. Signed-off-by: Chris Cormack I have tested this doesn't break on debian/ubuntu systems, someone with a non debian system will need to test it on that -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15405] XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15405 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14964] Email notices will be queued for patrons with no email address
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14034] User logged out on refresh after Shibboleth authentication
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 Chris Cormack changed: What|Removed |Added Attachment #42692|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 45961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45961&action=edit Bug 14034: Fix logout on refresh for shibboleth This is similar to bug 12877 Signed-off-by: Chris Cormack While this is missing a detailed test plan, what I did to test was 1/ Login to koha .. it works 2/ Apply patch 3/ Login to koha .. it still works, no regressions. I can't test the shibboleth part but it doesnt break anything else so I'm happy to sign off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14034] User logged out on refresh after Shibboleth authentication
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14580] Warn when accessing Help from error pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14580 --- Comment #6 from Aleisha Amohia --- Correction: This is triggered when there is no available Help for that page. You can test with Tools -> Rotating Collections too as this currently has no Help (Bug 13177) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Chris Cormack --- I tried to fix the conflict, but I wasn't sure of the changes in C4::Serials I will try to sign off again if you fix the conflicts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15086] Creators layout and template sql has warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Chris Cormack --- CONFLICT (content): Merge conflict in installer/data/mysql/it-IT/necessari/sample_creator_data.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14580] Warn when accessing Help from error pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14580 --- Comment #7 from Aleisha Amohia --- I'm going to add on to this bug - When you click 'Add help' to create a help page where there isn't one, it doesn't open and gives this error: edithelp.pl: print() on closed filehandle $fh at /home/vagrant/kohaclone/edithelp.pl line 82 which means the file open is failing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155 Liz Rea changed: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #23 from Liz Rea --- Hi, I'm happy to have a guess at how to test this, please in the future may we have a test plan? It makes things go a lot faster. :) Thanks very much, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #2 from Chris Cormack --- Hi Genevieve I am not quite sure how to test this, could you please add a test plan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Chris Cormack changed: What|Removed |Added Attachment #45886|0 |1 is obsolete|| --- Comment #39 from Chris Cormack --- Created attachment 45962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45962&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC - Change the preference Enhancedmessagingpreference description. - Enable default EnhancedMessagingPreferences and OPACEnhancedMessagingPreferences. - not sent e-mail it's necessary, when user call opac-messaging.pl directly.. Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. Signed-off-by: Frederic Demians Works as expected. With the new syspref, patrons can be forbidden to modify themselves their own messaging preferences. Signed-off-by: Chris Cormack Also, I like sysprefs http://www.quickmeme.com/img/d9/d99723bc544e8d33572dc92f242a6f6e2dbe0126a2e35fe3de073d30d62002e6.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15409] Plugins section missing from Admin menu sidebar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15409 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15409] Plugins section missing from Admin menu sidebar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15409 Aleisha Amohia changed: What|Removed |Added Attachment #45912|0 |1 is obsolete|| --- Comment #2 from Aleisha Amohia --- Created attachment 45963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45963&action=edit Bug 15409 - Plugins section missing from Admin menu sidebar The sidebar menu in the Admin area of Koha is missing a section for Plugins. Test Plan: 1) Apply this patch 2) Log in with a user that has plugin permissions 3) Browse to a page with the admin menu sidebar, such as /cgi-bin/koha/admin/transport-cost-matrix.pl 4) Note the new Plugins section with a link to manage plugins 5) Log in with a user that has no plugin permissions 6) Revisit the same page, note the Plugins section is no longer visible Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] New: Number of items to order on holds ratio report will not fulfill the holds ratio.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422
Bug ID: 15422
Summary: Number of items to order on holds ratio report will
not fulfill the holds ratio.
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Reports
Assignee: gmcha...@gmail.com
Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
When running the holds ratio report ( circ/reserveratios.pl ), I have the hold
ratio set to 3 (this is the threshold ratio, set in the Refine results box on
the right).
This is from the first row on the page:
Holds : 40
Items : 3
Hold Ratio : 13.33
...
Items needed: 4 to order
If we add the recommended 4 items, we have 40 holds and 7 items, which brings
the hold ratio to 5.7, which is still above the threshold ratio of 3.
In order to bring the actual hold ratio below the threshold ratio of 3,
I would need
40 / ( 3 + x ) = 3
40 = 9 + 3x
31 = 3x
10.3 = x
Or, more generally
$data->{reservecount} / ( $data->{itemcount} + $needed ) = $ratio
$data->{reservecount} / $ratio = $data->{itemcount} +
$needed
$needed = ( $data->{reservecount} / $ratio ) - $data->{itemcount}
Instead at circ/reserveratios.pl line 158, we have
ratiocalc => sprintf( "%.0d", $ratio_atleast1 ? ( $thisratio / $ratio ) :
$thisratio ),
which translates to
$needed = ( $data->{reservecount} / $data->{itemcount} ) / $ratio
This means that if the library orders the recommended number of copies, the
title will show up again on the holds ratio report, assuming that the number of
holds stays more or less constant.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12289] stage_file.pl does not allow control of nomatch options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289 Chris Cormack changed: What|Removed |Added Attachment #28330|0 |1 is obsolete|| --- Comment #6 from Chris Cormack --- Created attachment 45964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45964&action=edit Bug 12289: Add --no-create options to stage_file.pl This patch adds the no-create options to the command line interface for bulk loading of records. To test 1/ Apply both patches 2/ Call the script with --no-create and your will find that new records are not created when no match is found. The default, of create_new remains the same as before. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12289] stage_file.pl does not allow control of nomatch options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12289] stage_file.pl does not allow control of nomatch options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289 Chris Cormack changed: What|Removed |Added Attachment #42134|0 |1 is obsolete|| --- Comment #7 from Chris Cormack --- Created attachment 45965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45965&action=edit Bug 12289: (follow-up) fix the compilation error Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Aleisha Amohia changed: What|Removed |Added Attachment #44218|0 |1 is obsolete|| --- Comment #22 from Aleisha Amohia --- Created attachment 45966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45966&action=edit Bug 13501: Move "Required" and checkbox after input/select Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||aleishaamo...@hotmail.com --- Comment #24 from Aleisha Amohia --- Applying: Bug 11651: Add possibility to print holds from holds queue fatal: sha1 information is lacking or useless (C4/HoldsQueue.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11651: Add possibility to print holds from holds queue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Chris Cormack changed: What|Removed |Added Attachment #40827|0 |1 is obsolete|| --- Comment #14 from Chris Cormack --- Created attachment 45967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45967&action=edit Bug 14457: Integrate LIBRIS spellchecking This patch makes it possible to configure LIBRIS spellchecker as a "did you mean" feature. When searching for a word or phrase and misspelling the query will be sent to LIBRIS and if they have a suggestion it will be shown in the yellow did you mean box in the results page. The API is not very quick so this type of implementation was chosen to not disrupt the real-time feeling of the search. To test: 1. Apply the patch. 2. Go to http://api.libris.kb.se/bibspell/, enter the koha servers IP and click on the "Generera nyckel" button. 3. Under "Nyckel" you can copy the value that looks like this: E47B44829E265607274B677BC17B8D78, and enter it into the LibrisKey syspref (cgi-bin/koha/admin/preferences.pl?tab=searching). 4. In cgi-bin/koha/admin/didyoumean.pl check the box for using the LIBRIS API. It is only implemented for OPAC. 5. Perform some searches: tset - Did you mean should suggest: test jeg är på smester - suggestion: jag är på semester dantes inferna - suggestion: dantes inferno Restored opac-search.pl Signed-off-by: Chris Cormack Seems to work, of course I can't tell if it is giving me accurate suggestions :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15386] Checkout / patron pages: Hide menu items leading to 404 page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15386 Lucio Moraes changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||lmor...@catalyst.net.nz --- Comment #2 from Lucio Moraes --- Looks like ok -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Chris Cormack changed: What|Removed |Added Attachment #42704|0 |1 is obsolete|| --- Comment #4 from Chris Cormack --- Created attachment 45969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45969&action=edit Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Chris Cormack changed: What|Removed |Added Attachment #42703|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 45968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45968&action=edit Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15386] Checkout / patron pages: Hide menu items leading to 404 page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15386 --- Comment #3 from Lucio Moraes --- Bug 15386: Checkout / patron pages: Hide menu items leading to 404 pages Some of the menu items on patron / Checkout related pages lead to a 404 page depending on the permissions. This patch hides them as appropriate. To test: - For a staff member A, set permission 'borrowers' only (+ 'catalogue') - Log in as A - Search a patron and display details - Verify that none of the menu items at the left lead to the 404 page - For a staff member B, set permission 'circulate_remaining_permission' only (+ catalogue) - Log in as B - Go to Circulation > Checkout, search a patron - Click menu items at the left, some of them lead to the 404 page - Verify that none of the menu items at the left lead to the 404 page - Do the same for a staff member C with both permissions set - Verify that menu items appear as expecte Signed-off-by: Lucio Moraes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #150 from Héctor Eduardo Castro Avalos --- Created attachment 45970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45970&action=edit Bug 13642: (followup) OAI-DC checked by default in OPAC modal Fixing default option checked for OAI-DC in OPAC modal This follow-up fix the QA comment in comment 149 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #151 from Héctor Eduardo Castro Avalos --- (In reply to Jonathan Druart from comment #149) > Héctor, I have just found a minor issue: > At the OPAC, there is no radio buttons selected by default, so if you click > on export, you get a iso2709. I found two issues more in OPAC, the modal doesn't display in MARC view and ISBD view. I will fix this in the last follow-up. Regards -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #45970|0 |1 is obsolete|| --- Comment #152 from Héctor Eduardo Castro Avalos --- Created attachment 45971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45971&action=edit Bug 13642: (followup) OAI-DC checked by default in OPAC modal -Fixing default option checked for OAI-DC in OPAC modal -Move OPAC modal to opac-detail-sidebar.inc to display in MARC view and ISBD view This follow-up fix the QA comment in comment 149 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #153 from Héctor Eduardo Castro Avalos --- I wish all of you a Merry Christmas and a Happy New Year Regards -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #44847|0 |1 is obsolete|| --- Comment #36 from Héctor Eduardo Castro Avalos --- Created attachment 45973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45973&action=edit [SIGNED-OFF]Bug 6934: Fix code in CashRegisterStats (dataTables pagination, more accurate descriptions, add a delimiter pull down, change C4::Dates to Koha::DateUtils) I cleaned up the code according to comment #23. I got rid of DHTMLcalendar_dateformat, beacause it wasn't use in cash_register_stats.tt. C4::Dates is deprecated, Koha::DateUtils is now used. Some column names are changed and the pagination for the dataTables is fixed. Signed-off-by: Hector Castro -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #44853|0 |1 is obsolete|| --- Comment #37 from Héctor Eduardo Castro Avalos --- Created attachment 45974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45974&action=edit [SIGNED-OFF]Bug 6934: New features, note added to transaction information, total caculated for negative types of transaction To be more specific, the column note from accountlines is now displayed in the table of the transactions. The grand total is now calculated for neagtive types like Credit or Payment and isn't counted for Write off types. Credit (return item) 'CR' has been added to drop down of transaction type Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #42564|0 |1 is obsolete|| --- Comment #35 from Héctor Eduardo Castro Avalos --- Created attachment 45972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45972&action=edit [SIGNED-OFF]Bug 6934: New report Cash Register Statistics This patch creates a new report that outputs cash register stats for a specific period. Changes: koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc - Added cash register report link koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash-register_stats.tt - new file koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt - Added cash register report link reports/cash-register_stats.pl - new file Testing: I Apply the patch 0) Go to reports home page (Home > Reports); 1) Validate link << Cash Register >> under Statistics wizards; 2) Click link; 3) Validate page with three fieldsets; 4) Chose a date interval, a transaction type, a library and an output; 5) Validade the result. Signed-off-by: Nicole Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6849] idzebra modules not found on openSUSE 64-bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6849 Nicholas van Oudtshoorn changed: What|Removed |Added Resolution|--- |DUPLICATE CC||vano...@gmail.com Status|NEW |RESOLVED --- Comment #2 from Nicholas van Oudtshoorn --- Just found this bug. Marking it as a duplicate of 15405, which contains a working patch that fixes this. *** This bug has been marked as a duplicate of bug 15405 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15405] XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15405 Nicholas van Oudtshoorn changed: What|Removed |Added CC||bob-ew...@bobsown.com --- Comment #6 from Nicholas van Oudtshoorn --- *** Bug 6849 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
