[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15357] Deleting all items on a record with title level holds creates orphaned/ghost holds

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15357

--- Comment #5 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #4)
> If we do not allow to place a hold on a record without items, wouldn't it be
> more consistent to delete all title level holds for a biblio when deleting
> the last item?

In any case, this patch is needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022

--- Comment #25 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #21)
> (In reply to Tomás Cohen Arazi from comment #20)
> > I think this should be solved on indexing, no calculation on what is the
> > status of the records/items should be done on rendering the results page.
> > 
> > If you take a look at C4::Circulation::{AddIssue|AddReturn} you will notice
> > that they call C4::Items::ModItem, which ultimately calls ModZebra...
> > 
> > So we should always assume the data we retrieve from Zebra is current... and
> > no calculation should be done outside the resultset...
> > 
> > I belive at some point we messed up things A LOT (by adding the 
> > thing in the XSLT step... but until someone rewrites all that... I think we
> > should do the search engine-way.
> 
> So what steps do we need to take to resolve this? It sounds like we need to
> create an availability index. This would also mean we need to re-index
> whenever other tables related to items change ( transfers and reserves at
> the least ).
> 
> I think that this patch could be pushed in the meantime as a band-aid at
> least, until we can get such a system in place.

I would like to see a comment from Tomas before these patches are pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #38607|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 45983
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45983&action=edit
Bug 12178: Update serial status to "claimed" when exporting to CSV

On the same way as late issues, the serial status should be updated to
'claimed' when the issues as exported as csv.

QA note: The updateClaim and UpdateClaimdateIssues subroutine did almost the
same thing, I kick the second on off to centralize the code.

Test plan:
1/ Export some late issues as CSV (serials/claims.pl).
2/ Refresh the page (the export does not do it) and confirm that the
status, the claim date and the claim count have been updated.
3/ Select some others issues, select a notice and send the notification.
Confirm that the behavior is the same.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14034] User logged out on refresh after Shibboleth authentication

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034

--- Comment #4 from Jonathan Druart  
---
Matts, could you please test this patch and confirm that it works as expected?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

--- Comment #3 from Marc Véron  ---
Created attachment 45984
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45984&action=edit
Bug 1983: Checkout: Hold request when checking out an item already on loan or
reserved

This patch allows to put a hold on an item that is already checked out or
reserved.

To test:

- Check out an item A
- Put a hold on an item B
- Verify thath the staff user has permission to put holds
- Check out item A to a patron X
- Try to checkout item A to a patron Y
- Verify that you see near the buttons for Checkin/Checkout a link "Click here
to place hold"
- Verify that the link is stylable (span class circ-scheckoutplacehold)
- Verify that the link takes you to the page for placing holds as appropriate
- Do the same for item B and verify that it works for reserved items as well.
- Log in with a staff client who has no permission to place holds
- Repeat steps above, verify that the link does not appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

--- Comment #40 from Jonathan Druart  
---
Comment on attachment 45962
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45962
Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC

Review of attachment 45962:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12528&attachment=45962)
-

Please provide a quick fix, it's easy :)

::: installer/data/mysql/atomicupdate/sysprefs_Bug12528.sql
@@ +1,4 @@
> +INSERT INTO systempreferences ( variable, value, options, explanation,type ) 
> VALUES
> +('OPACEnhancedMessagingPreferences', '1', NULL, 'If ON, show patrons 
> messaging setting on the OPAC.', 'YesNo') ON DUPLICATE KEY UPDATE value ='1';
> +INSERT INTO systempreferences ( variable, value, options, explanation,type ) 
> VALUES
> +('EnhancedMessagingPreferences', '1', NULL, 'If ON, allows patrons to select 
> to receive additional messages about items due or nearly due.', 'YesNo') ON 
> DUPLICATE KEY UPDATE value ='1';

Why do you want to modify the values on duplicate?
You just need to insert the new pref OPACEnhancedMessagingPreferences with the
same value as EnhancedMessagingPreferences.

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
@@ +157,5 @@
> + - pref: OPACEnhancedMessagingPreferences
> +   choices:
> +   yes: Show
> +   no: "Don't show"
> + - "patron messaging setting on the OPAC (NOTE: 
> EnhancedMessagingPreferences must be enabled)."

No need to uppercase NOTE.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12289] stage_file.pl does not allow control of nomatch options

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #45964|0   |1
is obsolete||
  Attachment #45965|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 45985
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45985&action=edit
Bug 12289: Add --no-create options to stage_file.pl

This patch adds the no-create options to the command line interface
for bulk loading of records.

To test
1/ Apply both patches
2/ Call the script with --no-create and your will find that new
records are not created when no match is found.  The default, of
create_new remains the same as before.

Signed-off-by: Chris Cormack 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12289] stage_file.pl does not allow control of nomatch options

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12289] stage_file.pl does not allow control of nomatch options

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289

--- Comment #9 from Jonathan Druart  
---
Created attachment 45986
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45986&action=edit
Bug 12289: (follow-up) fix the compilation error

Signed-off-by: Chris Cormack 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #23 from Jonathan Druart  
---
Aleisha, you have only signed off the last patch, could you confirm you have
tested the whole feature?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8628] Add digital signs to the OPAC

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #5 from Jonathan Druart  
---
Martin,
Following the coding guidelines, new modules added to the Koha namespace should
be object-oriented.
You should have a look at Koha::Object ( see Koha::Patron::Categories and
Koha::Virtualshel* for examples).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15405] XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15405

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Needs Signoff

--- Comment #7 from Jonathan Druart  
---
Waiting for another signoff from someone using a non debian-based system.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15386] Checkout / patron pages: Hide menu items leading to 404 page

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15386

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15386] Checkout / patron pages: Hide menu items leading to 404 page

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15386

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #45726|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 45987
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45987&action=edit
Bug 15386: Checkout / patron pages: Hide menu items leading to 404 pages

Some of the menu items on patron / Checkout related pages lead to a 404 page
depending on the permissions. This patch hides them as appropriate.

To test:

- For a staff member A, set permission 'borrowers' only (+ 'catalogue')
- Log in as A
- Search a patron and display details
- Verify that none of the menu items at the left lead to the 404 page

- For a staff member B, set permission 'circulate_remaining_permission'
  only (+ catalogue)
- Log in as B
- Go to Circulation > Checkout, search a patron
- Click menu items at the left, some of them lead to the 404 page
- Verify that none of the menu items at the left lead to the 404 page

- Do the same for a staff member C with both permissions set
- Verify that menu items appear as expected

Signed-off-by: Lucio Moraes 

Signed-off-by: Jonathan Druart 
Amended patch: I have remove the double if
CAN_user_circulate_circulate_remaining_permissions statement (and group
block into one). And also remove unecessary change ('IF a IF b' instead
of existing 'IF a && b')

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15423] New: Batch checkout dateformat error

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15423

Bug ID: 15423
   Summary: Batch checkout dateformat error
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cost...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When checking out in batch mode the system crashes:

The given date (26/08/2021 00:00) does not match the date format (sql) at
/usr/share/koha/lib/Koha/DateUtils.pm line 153.

Syspref dateformat is set to dd/mm/ but the error occurs with other
dateformat configuration.

See image attached please.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15423] Batch checkout dateformat error

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15423

--- Comment #1 from bondiurbano  ---
Created attachment 45988
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45988&action=edit
Batch checkout dateformat error

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15423] Batch checkout dateformat error

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15423

bondiurbano  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15423] Batch checkout dateformat error

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15423

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|minor   |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15423] Batch checkout dateformat error

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15423

--- Comment #2 from bondiurbano  ---
Tested in 3.22 and 3.22.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15424] New: 3.20.7 has inconsistent version stamps

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15424

Bug ID: 15424
   Summary: 3.20.7 has inconsistent version stamps
 Change sponsored?: ---
   Product: Koha
   Version: 3.20
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: gmcha...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

In the 3.20.7 release, Koha.pm sets the version to 3.20.07.001 while
updatedatabase.pl sets it to 3.20.07.000.  Upon upgrade, this results in Koha
instances never successfully getting past the web installer schema upgrade
step.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15424] 3.20.7 has inconsistent version stamps

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15424

Galen Charlton  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |frede...@tamil.fr
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15424] 3.20.7 has inconsistent version stamps

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15424

Galen Charlton  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15424] 3.20.7 has inconsistent version stamps

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15424

--- Comment #1 from Galen Charlton  ---
Created attachment 45989
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45989&action=edit
Bug 15424: fix version stamp for 3.20.07 release

This patch makes the version in Koha.pm match
the version set in updatedatabase.pl for the
3.20.07 release.

To test
---
[1] Apply to a Koha system that was already upgraded
to the 3.20.07 release; observe that opening the
staff interface no longer results in being stuck
at the web installer.

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15424] 3.20.7 has inconsistent version stamps

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15424

--- Comment #2 from Galen Charlton  ---
Whoops, never mind, I see that Frédéric has already handled this as an RMaint
erratum.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15424] 3.20.7 has inconsistent version stamps

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15424

Galen Charlton  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|Needs Signoff   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15425] New: Patron batch modification error on expiry date

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15425

Bug ID: 15425
   Summary: Patron batch modification error on expiry date
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cost...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When trying to modify patron's expiry date in batch mode an error occurs. 

See PDF attached please.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15425] Patron batch modification error on expiry date

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15425

--- Comment #1 from bondiurbano  ---
Created attachment 45990
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45990&action=edit
Patron batch modification error on expiry date

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15425] Patron batch modification error on expiry date

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15425

--- Comment #2 from bondiurbano  ---
Tested in 3.22

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15426] New: RSS Feed does not work.

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15426

Bug ID: 15426
   Summary: RSS Feed does not work.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: matthew.charleswo...@hekima.ac.ke
QA Contact: testo...@bugs.koha-community.org

Hello,

> List of URL's referenced in this post:
>> [1] 
>> http://koha.1045719.n5.nabble.com/Display-of-Scrolling-New-Arrivals-List-on-Koha-OPAC-td5847767.html
>> [2] 
>> http://library.sj.org.za/cgi-bin/koha/opac-search.pl?idx=kw&idx=kw&idx=kw&limit=mc-itype%2Cphr%3ABK&sort_by=acqdate_dsc&do=Search
>> [3] 
>> http://library.sj.org.za/cgi-bin/koha/opac-search.pl?&limit=mc-itype%252Cphr%253ABK&count=50&sort_by=acqdate_dsc&format=rss2
>> [4] 
>> http://library.sj.org.za/cgi-bin/koha/opac-search.pl?&limit=mc-itype%252Cphr%253ABK&count=50&sort_by=acqdate_dsc&format=html

I had implemented the suggestion at URL [1] on Koha 3.20. It was working before
I upgraded to 3.22. Now the RSS link on the Advanced Search Results (with
limiting item-type to Books and Sort Ordered to Acquisition Date: Newest to
Oldest) page at URL [2] appears to be URL [3] which does not work with the RSS
Feed software (http://feed.mikle.com) described by Vinod in his post at URL [1]
above.

I tried to validate [3] at https://validator.w3.org/feed/ but I get the
following error:

"Server returned [Errno -2] Name or service not known [help]"

The help message for this error says:

"This usually means that the URL was wrong, or that permissions on the server
don't allow us to fetch that file. The error shows the message that the server
sent, which may help."

The file permissions for opac-search.pl is:

-rwxr-xr-x 1 library-koha library-koha 40740 Dec 25 14:16 opac-search.pl

If I change the format=rss2 to format=html it works, as in URL [4]

My Server Information in About Koha is:

> Koha version: 3.22.01.000
> OS version ('uname -a'):  Linux ip-172-31-38-247 3.13.0-71-generic
>   #114-Ubuntu SMP Tue Dec 1 02:34:22 UTC 2015 x86_64 
> x86_64 x86_64 GNU/Linux
> Perl interpreter: /usr/bin/perl
> Perl version: 5.018002
> Perl @INC:/usr/share/koha/lib, /etc/perl, 
> /usr/local/lib/perl/5.18.2 
>   /usr/local/share/perl/5.18.2, /usr/lib/perl5, 
> /usr/share/perl5 
>   /usr/lib/perl/5.18, /usr/share/perl/5.18, 
> /usr/local/lib/site_perl, . 
> MySQL version:mysql Ver 14.14 Distrib 5.5.46, for 
> debian-linux-gnu (x86_64) using readline 6.3
> Apache version:   Server version: Apache/2.4.7 (Ubuntu)
> Zebra version:Zebra 2.0.44

If you need to test the links, you can login to the OPAC with the username:
guest; password: guest

The entries in my error log are:

[Sat Dec 26 22:05:48.405262 2015] [cgi:error] [pid 10246] [client
173.33.162.8:57341] AH01215: [Sat Dec 26 22:05:48 2015] opac-search.pl:
CGI::param called in list context from
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 86, this can lead to
vulnerabilities. See the warning in "Fetching the value or values of a single
named parameter" at /usr/local/share/perl/5.18.2/CGI.pm line 404.
[Sat Dec 26 22:05:48.405677 2015] [cgi:error] [pid 10246] [client
173.33.162.8:57341] AH01215: [Sat Dec 26 22:05:48 2015] opac-search.pl:
CGI::param called in list context from
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 87, this can lead to
vulnerabilities. See the warning in "Fetching the value or values of a single
named parameter" at /usr/local/share/perl/5.18.2/CGI.pm line 404.
[Sat Dec 26 22:05:48.413331 2015] [cgi:error] [pid 10246] [client
173.33.162.8:57341] AH01215: [Sat Dec 26 22:05:48 2015] opac-search.pl: Use of
uninitialized value in hash element at /usr/share/koha/lib/C4/Languages.pm line
352.
[Sat Dec 26 22:05:48.413532 2015] [cgi:error] [pid 10246] [client
173.33.162.8:57341] AH01215: [Sat Dec 26 22:05:48 2015] opac-search.pl: Use of
uninitialized value in hash element at /usr/share/koha/lib/C4/Languages.pm line
353.
[Sat Dec 26 22:05:48.417325 2015] [cgi:error] [pid 10246] [client
173.33.162.8:57341] AH01215: [Sat Dec 26 22:05:48 2015] opac-search.pl: Use of
uninitialized value in hash element at /usr/share/koha/lib/C4/Languages.pm line
352.
[Sat Dec 26 22:05:48.417570 2015] [cgi:error] [pid 10246] [client
173.33.162.8:57341] AH01215: [Sat Dec 26 22:05:48 2015] opac-search.pl: Use of
uninitialized value in hash element at /usr/share/koha/lib/C4/Languages.pm line
353.
[Sat Dec 26 22:05:48.432903 2015] [cgi:error] [pid 10246] [client
173.33.162.8:57341] AH01215: [Sat Dec 26 22:05:48 2015] opac-search.pl: Use of
uninitialized value in hash element at /usr/share/koha/lib/C4/Languages.pm line
352.
[Sat Dec 26 22:05:48.433142 

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Chris Cormack  changed:

   What|Removed |Added

  Attachment #45984|0   |1
is obsolete||

--- Comment #4 from Chris Cormack  ---
Created attachment 45991
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45991&action=edit
Bug 1983: Checkout: Hold request when checking out an item already on loan or
reserved

This patch allows to put a hold on an item that is already checked out or
reserved.

To test:

- Check out an item A
- Put a hold on an item B
- Verify thath the staff user has permission to put holds
- Check out item A to a patron X
- Try to checkout item A to a patron Y
- Verify that you see near the buttons for Checkin/Checkout a link "Click here
to place hold"
- Verify that the link is stylable (span class circ-scheckoutplacehold)
- Verify that the link takes you to the page for placing holds as appropriate
- Do the same for item B and verify that it works for reserved items as well.
- Log in with a staff client who has no permission to place holds
- Repeat steps above, verify that the link does not appear.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15427] New: Allow db connections using TLS

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427

Bug ID: 15427
   Summary: Allow db connections using TLS
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Database
  Assignee: gmcha...@gmail.com
  Reporter: ch...@bigballofwax.co.nz
QA Contact: testo...@bugs.koha-community.org

Currently if the database server is a different machine to another we connect
to it without using an encrypted connection. This will allow it to use TLS
instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15427] Allow db connections using TLS

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427

--- Comment #1 from Chris Cormack  ---
Created attachment 45992
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45992&action=edit
Bug 15427 : Enable TLS support for MySQL

In summary, changes are:
1) If you have chosen MySQL, Makefile.PL will ask you if you want TLS (default:
"no"), and then the locations for CA cert, client cert and client key
(reasonable defaults are provided). Settings , ,  and  are
added in koha-conf.xml
2) If yes in koha-conf.xml, the installer and database connection
scripts add the TLS options in both DBI connection strings and mysql command
line

To test
1/ Apply patch
2/ Check everything still works and db connections are the same as before
3/ Either run Makefile.PL and step through the options or edit your
koha-conf.xml to
enable TLS
4/ Check db connections are still working

Patch provided to me by Dimitris Kamenopoulos and I reformatted it into a git
patch,
any errors are probably mine

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15427] Allow db connections using TLS

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427

Chris Cormack  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15423] Batch checkout dateformat error

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15423

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #3 from Marc Véron  ---
Confirmed for the following situation:

Enter 2 valid barcodes
Then enter a line with one space character
Then enter one more empty line or a barcode

e.g.
1
2

3
('empty' line contains one space character)


Result:
The given date (13/05/2022 00:00) does not match the date format (iso) at
/usr/share/kohaclone/Koha/DateUtils.pm line 153.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/