[Koha-bugs] [Bug 14686] New menu option and permission for file uploading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Marcel de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Marcel de Rooy --- Let's get this one moving.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15749] Add library menu to OPAC header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15749 Zeno Tajoli changed: What|Removed |Added CC||z.taj...@cineca.it --- Comment #4 from Zeno Tajoli --- Why don't use 'OpacAddMastheadLibraryPulldown' sys pref ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Julian Maurice changed: What|Removed |Added Depends on|13799 |15126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 [Bug 15126] REST API: Use newer version of Swagger2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What|Removed |Added Blocks|13903 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 [Bug 13903] Add API routes to list, create, update, delete reserves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15126] REST API: Use newer version of Swagger2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Julian Maurice changed: What|Removed |Added Blocks||13903 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 [Bug 13903] Add API routes to list, create, update, delete reserves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Jonathan Druart changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #15 from Jonathan Druart --- Switch to "In discussion' according to the ML thread. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15734] Audio Alerts broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Jonathan Druart changed: What|Removed |Added Attachment #47644|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 47735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47735&action=edit Bug 15734: Audio Alerts broken In master there is a JSON error thrown when AudioAlerts are enabled. This is caused by changes in master from bug 13618. Test Plan: 1) Enable audio alerts 2) Note audio alerts don't work 3) Apply this patch 4) Note audio alerts now work Signed-off-by: Hector Castro Works as described Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15734] Audio Alerts broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Jonathan Druart changed: What|Removed |Added Attachment #47645|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 47736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47736&action=edit Bug 15735: Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert Signed-off-by: Hector Castro Bug 15734 applied on top. Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15721] About page does not display Apache version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 Jonathan Druart changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #6 from Jonathan Druart --- Marc, On bug 13486, Tomas removed `apache2 -V`, to use `apache2clt -v` instead. Your patch restores the behavior prior to bug 13486: C4::Context::get_versions does not call apache2ctl. Tomas, any ideas what is the best way to fix this one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15734] Audio Alerts broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Jonathan Druart changed: What|Removed |Added Depends on||13618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What|Removed |Added Blocks||15734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 [Bug 15734] Audio Alerts broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15754] New: html tags displayed when editing frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 Bug ID: 15754 Summary: html tags displayed when editing frameworks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 13618 When editing subfields the "repeatable", "mandatory" and "is url" checkboxes are not displayed: the input html tag is displayed instead. Caused by bug 13618. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What|Removed |Added Blocks||15754 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 [Bug 15754] html tags displayed when editing frameworks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15754] html tags displayed when editing frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15754] html tags displayed when editing frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 --- Comment #1 from Jonathan Druart --- Created attachment 47737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47737&action=edit Bug 15754: Fix regression on editing framework subfields When editing subfields the "repeatable", "mandatory" and "is url" checkboxes are not displayed: the input html tag is displayed instead. Caused by bug 13618. Test plan: Edit subfields and confirm the bug. Apply the patch and confirm that you are not able to check/uncheck checkboxes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #208 from Julian Maurice --- Package accepted into Debian unstable: https://packages.debian.org/sid/libtemplate-stash-autoescaping-perl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15694] Date/time-last-modified not searchable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #8 from Jonathan Druart --- It does not work for me with only the first patch applied. The changes need to be made for normarc and unimarc as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15749] Add library menu to OPAC header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15749 --- Comment #5 from c...@pennmanor.net --- (In reply to Zeno Tajoli from comment #4) > Why don't use 'OpacAddMastheadLibraryPulldown' sys pref ? It has been a number of years since our librarians requested this feature but I think their concern with OpacAddMastheadLibaryPulldown was that it doesn't remember your search selection. If you click the Koha icon that takes you back to the home screen it defaults you to all libraries. The other advantage of this patch is the libraries can create shortcuts to the opac that sets the filter. For example they bookmark https://library.pennmanor.net/cgi-bin/koha/opac-setbranch.pl?newbranch=HAM At the time you couldn't do DNS subdomains to specific libraries. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15755] New: Default item type is not marked as "All" in circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755 Bug ID: 15755 Summary: Default item type is not marked as "All" in circulation rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 15354 Bug 15354 did not fix correctly the issue with the item type display. The default item type '*' should be "All", at the moment nothing is displayed in the column. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 [Bug 15354] item types aren't showing in default hold policies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15354] item types aren't showing in default hold policies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jonathan Druart changed: What|Removed |Added Blocks||15755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755 [Bug 15755] Default item type is not marked as "All" in circulation rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15755] Default item type is not marked as "All" in circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15755] Default item type is not marked as "All" in circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755 --- Comment #1 from Jonathan Druart --- Created attachment 47738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47738&action=edit Bug 15755: Display default item type as "All" in circ rules Bug 15354 did not fix correctly the issue with the item type display. The default item type '*' should be "All", at the moment nothing is displayed in the column. Test plan: 1/ Define a rule for default item types (All/*) and for specific item types. 2/ Translate some item type descriptions used in previous step 3/ Default item type should be "All" and correct translations should be displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13995] Proper Exception handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Olli-Antti Kivilahti changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #20 from Olli-Antti Kivilahti --- (In reply to M. Tompsett from comment #19) > (In reply to Marcel de Rooy from comment #18) > > Bug 14544 also introduces a Koha::Exceptions module. > > Has there been any interaction between the authors about the road to follow? > > This patch still applies, but there is no "t/Exceptions.t" test file. I > think this should be required for a sign off, in addition to answering > Marcel's question, since that bug (14544) has been pushed to master. > Changing status to 'In Discussion' (to be doomed for all eternity! -- since > that is what most 'In Discussion' bugs do) Hi! See the attached opendocument presentation about the pros and cons of the two different approaches. If you like this approach, sign off this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15108] OAI-PMH provider improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #14 from Olli-Antti Kivilahti --- Hi! We are upgrading our KohaSuomi branch (with 300 custom commits) built on top of Koha 3.16 to master this summer. I heard that it is "impossible". Looking forward to doing it with our soon-to-be continuous integration environment :) When this is ready, this patch is also rebased. Feel free to do it sooner. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 --- Comment #12 from Olli-Antti Kivilahti --- Hi! We are targeting to upgrade our Koha to master this summer and rebase this feature. Send me an email if you need this feature and we will share the latest code for you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #18 from Olli-Antti Kivilahti --- Hi! This feature work really well :) :) :) We are going to rebase it this summer (hopefully) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15756] New: Some tests for haspermission in C4::Auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 Bug ID: 15756 Summary: Some tests for haspermission in C4::Auth Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: m.de.r...@rijksmuseum.nl QA Contact: gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15756] Some tests for haspermission in C4::Auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |ASSIGNED Assignee|ch...@bigballofwax.co.nz|m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15756] Some tests for haspermission in C4::Auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15756] Some tests for haspermission in C4::Auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 --- Comment #1 from Marcel de Rooy --- Created attachment 47739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47739&action=edit Bug 15756: Some tests for haspermission in C4::Auth Test plan: Run this new test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14748] REST API Testing framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14748 --- Comment #6 from Olli-Antti Kivilahti --- Hi! This depends on the authentication system of the REST API which was under much scrutiny last time I checked. Bug 13920 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15756] Some tests for haspermission in C4::Auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 Marcel de Rooy changed: What|Removed |Added Blocks||14686 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 [Bug 14686] New menu option and permission for file uploading -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14686] New menu option and permission for file uploading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Marcel de Rooy changed: What|Removed |Added Depends on||15756 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 [Bug 15756] Some tests for haspermission in C4::Auth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 --- Comment #25 from Olli-Antti Kivilahti --- (In reply to M. Tompsett from comment #22) > *ping* Is this moving forward? Don't know about the Koha-community, but we are constantly improving this feature and it works really well in practice (albeit a bit slowly). All our web-testing scripts are based on this feature and together with the Permission system rewrite We have code to rapidly deploy and receive a bunch of serials as well, but we haven't shared it yet. Also this code is for Koha 3.16. This all is aimed to enable doing web-testing in Koha in an effortless way. Bug 14536 - PageObject-pattern base implementation We are targeting to migrate to a "possibly" rolling update cycle with the Koha-community versions this summer. And these modern testing features hopefully will help us gain confidence in our codebase and enable following the community branches in semi-real time. Time will tell. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12923] Improve error logging for advance_notices.pl; Show borrowernumber when no letter of type is found and force utf8 output.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12923 --- Comment #9 from Olli-Antti Kivilahti --- Happy new year to you too! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15757] New: Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757
Bug ID: 15757
Summary: Hard coded due loan/renewal period of 21 days if no
circ rule found in C4::Circulation::GetLoanLength
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: blocker
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
A library reported recently that an item with circulation period set to 0 for
all patron categories with a few exceptions set was checked out and was given a
checkout period of 21 days. This comes from the last lines in the
GetLoanLength subroutine:
1475 # if no rule is set => 21 days (hardcoded)
1476 return {
1477 issuelength => 21,
1478 renewalperiod => 21,
1479 lengthunit => 'days',
1480 };
1481
This should fire a1475 # if no rule is set => 21 days (hardcoded)
1476 return {
1477 issuelength => 21,
1478 renewalperiod => 21,
1479 lengthunit => 'days',
1480 };
1481 warning and/or stop the checkout rather than defaulting.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15721] About page does not display Apache version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 --- Comment #7 from Marc Véron --- Hi Jonathan, I think that in that case C4::Context::get_versions should be fixed in a separate bug that blocks this Bug 15271. Note: I do not touch C4::Context::get_versions, but I use it to remove code duplication. Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15293] Move the C4::Branch related code to Koha::Libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 Jonathan Druart changed: What|Removed |Added Depends on||15758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Jonathan Druart changed: What|Removed |Added Blocks||15758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Karl Holten changed: What|Removed |Added CC||khol...@switchinc.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] New: Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Bug ID: 15758 Summary: Move the C4::Branch related code to Koha::Libraries - part 4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 15629 Blocks: 15293 This fourth and last part will remove: - GetBranchName - GetBranchesLoop - GetBranches - GetBranch will move mybranch and onlymine to C4::Context and finally remove all occurrences of C4::Branch. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 [Bug 15293] Move the C4::Branch related code to Koha::Libraries https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15759] New: Allow Koha::Object derived objects to be used as hashrefs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759
Bug ID: 15759
Summary: Allow Koha::Object derived objects to be used as
hashrefs
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: gmcha...@gmail.com
Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
On occasion, bugs in Koha have been revealed to be a mis-use of Koha::Object.
This seems to be due to our long standing use of hashrefs for data in Koha.
For instance, a developer may accidentally write:
my $borrowernumber = $borrower->{borrowernumber};
instead of
my $borrowernumber = $borrower->borrowernumber;
Since our object is a blessed hashref, this does not cause an error. Instead,
we just access that key of the hashref, which is almost certainly undefined.
With some extra code in Koha/Object.pm, we can allow hashref-like use of our
Objects, which will not only prevent these errors, but allow drop-in use of
Koha::Objects where we currently use hashrefs!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15759] Allow Koha::Object derived objects to be used as hashrefs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759
--- Comment #1 from Kyle M Hall ---
Created attachment 47740
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47740&action=edit
Bug 15759 - Allow Koha::Object derived objects to be used as hashrefs
On occasion, bugs in Koha have been revealed to be a mis-use of
Koha::Object. This seems to be due to our long standing use of hashrefs
for data in Koha.
For instance, a developer may accidentally write:
my $borrowernumber = $borrower->{borrowernumber};
instead of
my $borrowernumber = $borrower->borrowernumber;
Since our object is a blessed hashref, this does not cause an error.
Instead, we just access that key of the hashref, which is almost
certainly undefined.
With some extra code in Koha/Object.pm, we can allow hashref-like use of
our Objects, which will not only prevent these errors, but allow drop-in
use of Koha::Objects where we currently use hashrefs!
Test Plan:
1) Apply this patch
2) prove t/db_dependent/Borrower.t
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15759] Allow Koha::Object derived objects to be used as hashrefs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15759] Allow Koha::Object derived objects to be used as hashrefs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759 Kyle M Hall changed: What|Removed |Added Assignee|gmcha...@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9964] Add plugins management link to the Administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9964 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #4 from Julian Maurice --- I believe those changes already have been pushed as part of bug 12412. Can we close this one ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15759] Allow Koha::Object derived objects to be used as hashrefs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15760] New: sql injection in poac-shelves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15760 Bug ID: 15760 Summary: sql injection in poac-shelves.pl Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Database Assignee: gmcha...@gmail.com Reporter: hblanc...@gmail.com QA Contact: testo...@bugs.koha-community.org In a security analisys with accunetix software can detect that opac-shelves.pl permit sql injection attack, an example can be the following: URL encoded GET input sortfield was set to if(now()=sysdate(),sleep(0),0)/*'XOR(if(now()=sysdate(),sleep(0),0))OR'"XOR(if(now()=sysdate(),sleep(0),0))OR"*/ URL encoded GET input sortfield was set to 1,(select case when (3*2*1=6 AND 000227=000227) then 1 else 1*(select table_name from information_schema.tables)end)=1 I believe that is needed to sanitize all variables in that script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15694] Date/time-last-modified not searchable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #9 from Héctor Eduardo Castro Avalos --- (In reply to Jonathan Druart from comment #8) > It does not work for me with only the first patch applied. > The changes need to be made for normarc and unimarc as well. Hi Jonathan It seems to be that NORMARC does not use this index. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15760] sql injection in opac-shelves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15760 Humberto Blanco changed: What|Removed |Added Summary|sql injection in|sql injection in |poac-shelves.pl |opac-shelves.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15694] Date/time-last-modified not searchable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #10 from Héctor Eduardo Castro Avalos --- Created attachment 47741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47741&action=edit Bug 15694: (followup)Update DOM index for UNIMARC/biblios Update for UNIMARC biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl To test follow the first test plan in UNIMARC environment -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15754] html tags displayed when editing frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15754] html tags displayed when editing frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #47737|0 |1 is obsolete|| --- Comment #2 from Héctor Eduardo Castro Avalos --- Created attachment 47742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47742&action=edit [SIGNED-OFF]Bug 15754: Fix regression on editing framework subfields When editing subfields the "repeatable", "mandatory" and "is url" checkboxes are not displayed: the input html tag is displayed instead. Caused by bug 13618. Test plan: Edit subfields and confirm the bug. Apply the patch and confirm that you are not able to check/uncheck checkboxes. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15756] Some tests for haspermission in C4::Auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #47739|0 |1 is obsolete|| --- Comment #2 from Héctor Eduardo Castro Avalos --- Created attachment 47743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47743&action=edit [SIGNED-OFF]Bug 15756: Some tests for haspermission in C4::Auth Test plan: Run this new test. Signed-off-by: Hector Castro All tests successful. koha-qa.pl run OK. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15756] Some tests for haspermission in C4::Auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15719] Silence warning in C4/Language.pm during web install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15719] Silence warning in C4/Language.pm during web install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #47534|0 |1 is obsolete|| --- Comment #4 from Héctor Eduardo Castro Avalos --- Created attachment 47745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47745&action=edit Bug 15719: Silence warning in C4/Language.pm during web install This problem was discovered the hard way: - Drop DB - Create DB - Webinstaller run until the screen is: We are ready to do some basic configuration. Please install basic configuration settings to continue the installation. -- The error log file will end with an error about splitting an uninitialized value. TEST PLAN - 0) First patch already applied 1) prove -v t/Languages.t -- success, but warn prints 2) Apply this patch 3) prove -v t/Languages.t -- success without warning messages 4) run koha qa test tools Signed-off-by: Hector Castro Works as described. QA test tools run OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15719] Silence warning in C4/Language.pm during web install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #47533|0 |1 is obsolete|| --- Comment #3 from Héctor Eduardo Castro Avalos --- Created attachment 47744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47744&action=edit [SIGNED-OFF]Bug 15719: Silence warning in C4/Language.pm during web install Test empty database case. TEST PLAN - 1) prove -v t/Languages.t -- success (because test case is missing) 2) Apply this patch 3) prove -v t/Languages.t -- success, but warning printed. 4) run koha qa test tools Signed-off-by: Hector Castro Works as advertised. QA test tools rus OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 claire.hernan...@biblibre.com changed: What|Removed |Added CC||claire.hernandez@biblibre.c ||om Assignee|koha-b...@lists.koha-commun |julian.maur...@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15759] Allow Koha::Object derived objects to be used as hashrefs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #1 from Jonathan Druart --- Created attachment 47746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47746&action=edit Bug 15758: Koha::Libraries - Remove GetBranchName This is the fourth and last patch set to remove C4::Branch. The real purpose of this patch is to standardise and refactor some code which is related to the libraries selection/display. Its unconfessed purpose is to remove the C4::Branch package. Before this patch set, only 6 subroutines still existed in the C4::Branch package: - GetBranchName - GetBranchesLoop - mybranch - onlymine - GetBranches - GetBranch GetBranchName basically returns the branchname for a given branchcode. The branchname is only used for a display purpose and we don't need to retrieve it in package or pl scripts (unless for a few exceptions). We have a `Branches` template plugin with a `GetName` method which does exactly this job. To achieve this removal, we will use this template plugin and delete the GetBranchName from pl and pm files. The `Branches.all()` will now select the library of the logged in user if no `selected` parameter has been passed. This new behavior could cause regressions, for instance there are some places where we do not want an option preselected (batch item modification for instance), keep that in mind when testing. GetBranchesLoop took 3 parameters: $branch and $onlymine. The first one was used to set a "selected" flag, for a display purpose: select an option in the libraries dropdown lists. The second one was useless: If not passed or set to 0, the `C4::Branch::onlymine` subroutine was called. This onlymine flag was use to know if the logged in user was able to see other libraries infos. A patron can see the infos from other libraries if IndependentBranches is not set OR if he has the superlibrarian permission. Prior to this patch set, the "onlymine test" was done on different places (neworderempty.pl, additem.pl, holidays.pl, etc.), including the Branches TT plugin. In this patch set, this test is only done on one place (C4::Context::only_my_library, code moved from C4::Branch::onlymine). To accomplish the same job as this subroutine, we just need to call the `Branches.all()` method from the `Branches` TT plugin. It already accepts a `selected` parameter to set a flag on the option to select. To avoid the repetitive [% IF selected %][% ELSE %][% END %] pattern, a new `html_helpers` TT include file has been created, it defines an `options_for_libraries` block, which takes a `selected` parameter. We could imagine to use this include file for other selects. The 'mybranch` and `onlymine` subroutines of the C4::Branch package have been moved to C4::Context. onlymine has been renamed with only_my_library. There are only 4 occurrences of it, against 11 before this patch set. There 2 subroutines are Context-centric and it makes sense to put them in `C4::Context` (at least it's the least worst place!) GetBranches is the tricky part of this patch set: It retrieves all the libraries, independently of the value of IndependentBranches. To keep the same way as the existing calls of `Branches.all()`, I have added a `unfiltered` parameter. If set, the `Branches.all()` will call a usual Koha::Libraries->search method, otherwise Koha::Libraries->search_filtered will be called. This new method will check if the logged in user is allowed to see other libraries or only its library. Note that this `GetBranches` subroutine also created a `category` key: it allowed to get the list of groups (of libraries) where this library existed. Thanks to a previous patch set (bug 15295), this value was not used anymore (I may have missed something!). Note that the only use of `GetBranch` was buggy (see bug 15746). Test plan (for the whole patch set): The best way to test this whole patch set is to test with 2 instances: 1 with the patch set applied, 1 using master, to be sure there is no regression. It would be good to test the same with `IndependentBranches` and the without `IndependentBranches`. No difference should be found. The tester must focus on the library dropdowns on as many forms as possible. You will notice changes in the order of the options: the libraries will now be ordered by branchname (instead of branchcode in some places). A special attention will be given to the following page: - acqui/neworderempty.pl - catalogue/search.pl - members/members-home.pl (header?) - opac/opac-topissues.pl - tools/holidays.pl - admin/branch_transfer_limits.pl - admin/item_circulation_alerts.pl - rotating_collections/transferCollection.pl - suggestion/suggestion.pl - tools/export.pl Notes for QA: - There are 2 FIXMEs in the patch set, I have kept the existing behavior, but I am not sure it's the good one. Feel free to open a bug report and I will fill a patch if you think it's not correct. Otherwise, remove the FIXME lines in a follow-up patch. - The whole patch set is huge an
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #2 from Jonathan Druart --- Created attachment 47747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47747&action=edit Bug 15758: Koha::Libraries - Remove GetBranchesLoop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #3 from Jonathan Druart --- Created attachment 47748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47748&action=edit Bug 15758: Koha::Libraries - Move mybranch to C4::Context -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #5 from Jonathan Druart --- Created attachment 47750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47750&action=edit Bug 15758: Koha::Libraries - Move onlymine to C4::Context::only_my_library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #6 from Jonathan Druart --- Created attachment 47751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47751&action=edit Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #4 from Jonathan Druart --- Created attachment 47749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47749&action=edit Bug 15758: Koha::Libraries - Remove GetBranches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #7 from Jonathan Druart --- Created attachment 47752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47752&action=edit Bug 15758: Koha::Libraries - Add tests for the Branches TT plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #8 from Jonathan Druart --- Created attachment 47753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47753&action=edit Bug 15758: Koha::Libraries - Do not select an option if selected is defined This will certainly need a few more tweaks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart changed: What|Removed |Added Attachment #47646|0 |1 is obsolete|| Attachment #47647|0 |1 is obsolete|| Attachment #47648|0 |1 is obsolete|| Attachment #47649|0 |1 is obsolete|| Attachment #47650|0 |1 is obsolete|| --- Comment #25 from Jonathan Druart --- Created attachment 47754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47754&action=edit Bug 15407: Koha::Patron::Categories - remove sql queries in some pl and pm This patch replaces sql queries done in some pl script and in C4::Reports::Guided. Since we have now a Koha::Patron::Categories module, we should use it where it is possible. Test plan: - Prerequisite: Be sure you have several patron categories created, with different option enabled, and limit some to certain libraries. - On the 'Circulation and fine rules' admin page (admin/smart-rules.pl), all the patron categories should be displayed (even the ones limited to another library), ordered by description. Try to add/update existing rules. - On the overdue rules page (tools/overduerules.pl), all the patron categories with overduenoticerequired set should be displayed. Try to add/update existing rules. - On the following reports: reports/borrowers_stats.pl reports/issues_avg_stats.pl The patron categories should be displayed. Note that there is an inconsistency with these 2 reports: the patron categories limited to other libraries are displayed on them, when they are not on the other reports. This should certainly be fixed (on another bug report). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #26 from Jonathan Druart --- Created attachment 47755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47755&action=edit Bug 15407: Koha::Patron::Categories - replace C4::Category->all The C4::Category module contained only 1 method to return the patron categories available for the logged in user. The new method Koha::Patron::Categories->search_limited does exactly the same thing (see tests) and must be used in place of it. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. - On the 'Item circulation alerts' admin page (admin/item_circulation_alerts.pl), modify the settings for check-in and checkout (NOTE: Should not we display all patron categories on this page? If yes, it must be done in another bug report to ease backporting it). - Search for patrons in the admin (budget) and acquisition (order) module. - On the patron home page (search form in the header) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #28 from Jonathan Druart --- Created attachment 47757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47757&action=edit Bug 15407: Koha::Patron::Categories - replace GetBorrowercategoryList C4::Members::GetBorrowercategoryList returned all the patron categories, ordered by description. This can be done using the search method of the Koha::Patron::Categories module. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by description. - On the "patron attribute types" admin page (admin/patron-attr-types.pl). - On the "Batch patron deletion/anonymization" (tools/cleanborrowers.pl), the dropdown list should be filled correctly. - On the import patron tool - On the following report: reports/reserves_stats.pl Confirm that the patron categories are displayed and that the report still works as before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #29 from Jonathan Druart --- Created attachment 47758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47758&action=edit Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType This unnecessary complicated subroutine returned an arrayref and an hashref of the patron categories available for the logged in user, for a given category_type, ordered by categorycode. This can now be done with the search_limited method. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by categorycode. - Add/edit a patron, change his/her patron category value. - On the 3 following reports: reports/bor_issues_top.pl reports/borrowers_out.pl reports/cat_issues_top.pl The display for these 3 reports are different than the 2 from the first patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by categorycode and the ones limited to other libraries are not displayed (should certainly be fixed). Note that the big part of this patch has already been tested before (update child related: CATCODE_MULTI). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #27 from Jonathan Druart --- Created attachment 47756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47756&action=edit Bug 15407: Koha::Patron::Categories - replace GetBorrowercategory The purpose of C4::Members::GetBorrowercategory was to return the patron category for a given categorycode. This can be done easily with the Koha::Patron::Categories->find method. Test plan: - Same prerequisite as before - Edit a guarantor and confirm the information will be updated for his/her guarantee(s). - Update a child to adult patron (Note: Should not we hide the patron categories limited to others libraries? If yes, it must be done on another bug report). There is a special behavior if there is only 1 adult category, the user does not need to select a category. So the same as before with only 1 adult patron category. - Import a patron with a category_code which does not exist. You should be warned. - Modify some patron using the batch patron modification tool. The patron category descriptions should correctly be displayed. Note that the overduerules page has already been tested in a previous patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart changed: What|Removed |Added Depends on||15629 --- Comment #30 from Jonathan Druart --- Patches rebased on top of bug 15629. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Jonathan Druart changed: What|Removed |Added Blocks||15407 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15761] New: SIP2 can not save statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15761 Bug ID: 15761 Summary: SIP2 can not save statistics Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: hblanc...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com When i try to checkin an item from 3m selfcheckin machine get the following error in /var/log/koha/catalogo/sip-output.log DBD::mysql::st execute failed: Data truncated for column 'value' at row 1 [for Statement "INSERT INTO statistics -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15761] SIP2 can not save statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15761 Humberto Blanco changed: What|Removed |Added CC||hblanc...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Jonathan Druart changed: What|Removed |Added Attachment #47747|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 47759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47759&action=edit Bug 15758: Koha::Libraries - Remove GetBranchesLoop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Jonathan Druart changed: What|Removed |Added Attachment #47748|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 47760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47760&action=edit Bug 15758: Koha::Libraries - Move mybranch to C4::Context -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Jonathan Druart changed: What|Removed |Added Attachment #47749|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 47761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47761&action=edit Bug 15758: Koha::Libraries - Remove GetBranches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Jonathan Druart changed: What|Removed |Added Attachment #47752|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 47764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47764&action=edit Bug 15758: Koha::Libraries - Add tests for the Branches TT plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Jonathan Druart changed: What|Removed |Added Attachment #47751|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart --- Created attachment 47763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47763&action=edit Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart changed: What|Removed |Added Blocks||15758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Jonathan Druart changed: What|Removed |Added Attachment #47750|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 47762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47762&action=edit Bug 15758: Koha::Libraries - Move onlymine to C4::Context::only_my_library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Jonathan Druart changed: What|Removed |Added Attachment #47753|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Created attachment 47765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47765&action=edit Bug 15758: Koha::Libraries - Do not select an option if selected is defined This will certainly need a few more tweaks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Jonathan Druart changed: What|Removed |Added Depends on|15629 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15746] A random library is used to record an individual payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15746 Jonathan Druart changed: What|Removed |Added Blocks||15758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Jonathan Druart changed: What|Removed |Added Depends on||15731, 15742, 15407, 15746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 [Bug 15731] C4::Reports::Guided::build_authorised_value_list is not used https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 [Bug 15742] Unnecessary loop in j2a cronjob https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15746 [Bug 15746] A random library is used to record an individual payment -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15742] Unnecessary loop in j2a cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 Jonathan Druart changed: What|Removed |Added Blocks||15758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15731] C4::Reports::Guided::build_authorised_value_list is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Jonathan Druart changed: What|Removed |Added Blocks||15758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Jonathan Druart changed: What|Removed |Added Blocks|15758 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13995] Proper Exception handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 --- Comment #21 from M. Tompsett --- (In reply to Olli-Antti Kivilahti from comment #20) > See the attached opendocument presentation about the pros and cons of the > two different approaches. > > If you like this approach, sign off this patch. While I may prefer the individual file for the reason of reducing potential conflicts, I still can't sign off for the very reason given in comment #19. "This patch still applies, but there is no "t/Exceptions.t" test file. I think this should be required for a sign off" Additionally, it has usually been the case that if one method is used first in Koha that either: a) you do it the way already there, OR b) you refactor the other way AFTER discussion on koha-devel. So, if (b) is the choice, then create a refactor bug, and make this depend on that. And of course, actually discuss this on koha-devel. And either way, there should be a test file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15753] String update in the README for qa-test-tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15753 M. Tompsett changed: What|Removed |Added Attachment #47718|0 |1 is obsolete|| CC||mtomp...@hotmail.com --- Comment #2 from M. Tompsett --- Created attachment 47766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47766&action=edit String update in the README for qa-test-tools It just adds 'sudo', which is correct, since the sample prompt is '$' and not '#'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15753] String update in the README for qa-test-tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15753 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Jason Burds changed: What|Removed |Added CC||jbu...@dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11405] Inventory tool enhancements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Jason Burds changed: What|Removed |Added CC||jbu...@dubuque.lib.ia.us --- Comment #51 from Jason Burds --- Working on the test plan, I was not able to get it to pass using the sandbox. Compare barcodes list to results doesn't work. Tried using an txt file with 5 items in it. There are 6 items with the call number FIC. I get stuck on number 6. 6) Note the item is listed as "should have been scanned" 7) Click back to return to the previous page 8) Select the shelving location from "If comparing barcodes list to results, assume items with the following locations should note have been scanned". 8) Re-run the inventory tool 9) Note the item is no longer listed as "should have been scanned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15737] Patron userid lost during test for duplicate users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15737 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Emma - is the PIN number an extended patron attribute in your installation? How is it configured? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
