[Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Josef Moravec changed: What|Removed |Added Attachment #48151|0 |1 is obsolete|| --- Comment #6 from Josef Moravec --- Created attachment 48154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48154&action=edit Bug 15830 - Move Rotating Collections actions into a drop-down list To test: 1) Go to Tools -> Rotating Collections 2) Confirm actions (Add or remove items, Transfer, Edit, Delete) have moved into a drop down menu 3) Confirm all of the actions work as expected Sponsored-by: Catalyst IT Signed-off-by: Marc Véron Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15578] Authority tests skip and hide a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #14 from Julian Maurice --- I think I'll push these patches even without a signoff, because it blocks bug 15358 which is a "blocker". Moreover, 15358's patch for 3.22 has been signed off, which mean this bug's patches kind of work too :) That being said, I would still like those patches to be signed off before I push them ;) (probably tomorrow or the day after) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12993] Add a default tax rate on item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #36 from Josef Moravec --- Could you please rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15835] Koha::Object does not save changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15835 Marc Véron changed: What|Removed |Added Summary|Koha::Object does not save |Koha::Object does not save |shanges |changes CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #24 from Julian Maurice --- Why Koha should allow to place hold that will be (probably) impossible to satisfy ? Let's take an example: - Patron 1 place a hold that starts on 2016-03-01 and ends on 2016-03-07 - Patron 2 place a hold that starts on 2016-03-02 and ends on 2016-03-06 If patron 1 get the book, patron 2 will never have it (unless patron 1 returns the book very quickly, which is very unlikely to happen imo) and is never informed about the high probability that this will happen. Another issue: - Patron 1 place a hold that starts on 2016-03-02 and ends on 2016-03-08 - Patron 2 place a hold (after patron 1 has placed their hold) that starts on 2016-03-01 (we don't care about the end date here) If priority is based on start date, then patron 2 will "steal" the book from patron 1. Patron 1 will never get the book while they have placed their hold first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What|Removed |Added CC|sandbo...@biblibre.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] New: Labels: Offer configuration option for splitting call number in layout definition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Bug ID: 15836 Summary: Labels: Offer configuration option for splitting call number in layout definition Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Currently the call number splitting seems to be mostly implemented for DDC and LC classifications. Those are both not very common in Germany and possibly other countries. A lot of our libraries use their own custom classification schemes so the call number splitting is something that should be individually configurable. One option would be using a regex expression, that can be set in the layout additional to the standard splitting offered by the checkbox. (see bug 2500 for some discussion about the splitting algorithms implemented atm) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call number in layout definition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=2500 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2500] Standing enhancement request for adding/updating call number splitting algorithms in C4/Labels.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2500 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15836 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #25 from Katrin Fischer --- I think ideally we shoudl have a proper reservation system that maybe even works separately from the holds system. But my main concern here is that the new behavioru should be optional - so we honor the different workflows. If the books is not checked out or only used on-site, the library can coordinate overlapping holds. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #23 from Jonathan Druart
---
(In reply to David Cook from comment #21)
> As you can observe in the warning itself, the warning is for "Fetching the
> value or values of a single named parameter". In the case of
> '$query->param("name")', we're fetching the value of a single named
> parameter. In the case of '$query->param()', we're fetching the names of all
> the parameters. It's completely different.
I don't understand, we both agree, it generates a warning.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15782] Paging on comments moderation broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15782 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #1 from Marc Véron --- I can not reproduce the issue on curent master. Tested with about 50 comments / 3 "pages". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #121 from Josef Moravec --- Could you rebase please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15782] Paging on comments moderation broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15782 --- Comment #2 from Katrin Fischer --- Interesting. I have tested it serveral times now for the library, but couldn't see it in the very beginning. Can you check the offset parameter in the pagination links maybe? In the library reporting they change by 1. If I manipulate the offset parameter in the URL, it works to make bigger 'jumps'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15835] Koha::Object does not save changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15835
--- Comment #1 from Jonathan Druart
---
Srdjan, what did you try exactly?
I have tried the following:
use Modern::Perl;
use Koha::Borrowers;
my $p = Koha::Borrowers->find(10);
$p->set({firstname => 'my new firstname', surname => 'my new surname'
})->store;
then
MariaDB [koha]> select firstname, surname from borrowers where
borrowernumber=10;
And I got my updated values.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15837] New: "Enter starting label position (for PDF):" for CSV export
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15837 Bug ID: 15837 Summary: "Enter starting label position (for PDF):" for CSV export Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org A library reports that it would be helfpul, if the option "Enter starting label position (for PDF):" when exporting labels, would also work exporting as CSV file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15782] Paging on comments moderation broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15782 --- Comment #3 from Marc Véron --- URL for 1st page: .../cgi-bin/koha/reviews/reviewswaiting.pl?status=1&page=1 URL for the 2nd page: .../cgi-bin/koha/reviews/reviewswaiting.pl?status=1&page=2 URL for 3rd page: .../cgi-bin/koha/reviews/reviewswaiting.pl?status=1&page=3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15782] Paging on comments moderation broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15782 Katrin Fischer changed: What|Removed |Added Version|master |3.18 --- Comment #4 from Katrin Fischer --- Interesting! The parameter is offset in this version (3.18) - I will recheck on master. Thx for testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart changed: What|Removed |Added Attachment #47641|0 |1 is obsolete|| --- Comment #52 from Jonathan Druart --- Created attachment 48155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48155&action=edit [3.22.x] Bug 15358: Fix authorities merge Bug 8064 (Merge several biblio records) change some code used in both biblios and authorities merge tool without updating the authorities merge tool. This patch fixes that. Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15578] Authority tests skip and hide a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Jonathan Druart changed: What|Removed |Added Attachment #47638|0 |1 is obsolete|| Attachment #47639|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Created attachment 48156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48156&action=edit [3.22.x] Bug 15578: Insert authority records before processing tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15578] Authority tests skip and hide a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #16 from Jonathan Druart --- Created attachment 48157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48157&action=edit [3.22.x] Bug 15578: Make sure all params will be taken into account when instantiating The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. Test plan: Apply the first patch, launch tests => Fail Apply the second patch, launch tests => \o/ Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15578] Authority tests skip and hide a bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #17 from Jonathan Druart --- Let's sign my own patches off... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Jonathan Druart changed: What|Removed |Added Attachment #48154|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 48158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48158&action=edit Bug 15830 - Move Rotating Collections actions into a drop-down list To test: 1) Go to Tools -> Rotating Collections 2) Confirm actions (Add or remove items, Transfer, Edit, Delete) have moved into a drop down menu 3) Confirm all of the actions work as expected Sponsored-by: Catalyst IT Signed-off-by: Marc Véron Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15838] New: syspref SubscriptionDuplicateDroppedInput does not work for all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15838 Bug ID: 15838 Summary: syspref SubscriptionDuplicateDroppedInput does not work for all fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: alex.arn...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Some fields (especially on second page?) are not reset when duplicating a subscription despite they are in SubscriptionDuplicateDroppedInput system preference. The reason is that these fields have an id different than the name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15838] syspref SubscriptionDuplicateDroppedInput does not work for all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15838 Alex Arnaud changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 --- Comment #13 from Jonathan Druart --- Created attachment 48160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48160&action=edit bug_6624: Added Open Library Search and Read API to openlibrary.js Signed-off-by: Nicole Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Jonathan Druart changed: What|Removed |Added Attachment #46655|0 |1 is obsolete|| Attachment #46656|0 |1 is obsolete|| Attachment #48152|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 48159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48159&action=edit bug_6624: OpenLibrarySearch syspref for OPAC If set to Yes, OPAC search results and details will include buton from Open Library Raed API. In addition, Number of titles held in Open Library and the results link will be reported on the search results screen. Signed-off-by: Nicole Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 --- Comment #14 from Jonathan Druart --- Created attachment 48161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48161&action=edit bug_6624: Added Open Library Search and Read API calls to opac-results.tt and opac-detail.tt Conditional to OpenLibrarySearch syspref Signed-off-by: Nicole Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 --- Comment #15 from Jonathan Druart --- Created attachment 48162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48162&action=edit Bug 6624: Add test for OpenLibrary -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15838] syspref SubscriptionDuplicateDroppedInput does not work for all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15838 --- Comment #1 from Alex Arnaud --- Created attachment 48163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48163&action=edit Bug 15838 - Subscription duplicating: Reset fields from SubscriptionDuplicateDroppedInput syspef by getting them using name instead of id -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15838] syspref SubscriptionDuplicateDroppedInput does not work for all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15838 Alex Arnaud changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What|Removed |Added Depends on||15839 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 [Bug 15839] Move the reviews related code to Koha::Reviews -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 --- Comment #9 from Jonathan Druart --- Bug 15839 - Move the reviews related code to Koha::Reviews -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15839] New: Move the reviews related code to Koha::Reviews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Bug ID: 15839 Summary: Move the reviews related code to Koha::Reviews Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Blocks: 15449 The subroutines in C4::Reviews are only doing CRUD operations. This module can be moved easily to Koha::Reviews. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8397] Can import patrons with duplicate userids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397
Mason James changed:
What|Removed |Added
CC||m...@kohaaloha.com
--- Comment #4 from Mason James ---
(In reply to Owen Leonard from comment #0)
> If you use the "import patrons" tool to upload a CSV file of patron records
> it is possible to create more than one patron with the same userid. This
> should not be possible.
I also hit this bug today, when attempting to import/update patrons with
undefined ("") userids
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 --- Comment #20 from Marcel de Rooy --- (In reply to David Cook from comment #19) Hi David. Thx for your interest in this patch. > Hmm... is koha-conf.xml really the most appropriate place to put > , since it's only going to be able to affect Debian package > installs? Hmm only Debian installs :) Your second remark is part of the answer btw. > I notice that it is in koha-conf.xml.in, so it should only appear in > koha-conf.xml files generated by the Debian packages... so I guess that's > OK... but it represents yet another deviation between the Debian package > installs and all other Koha installs... This is an interesting topic but really outside the scope of this tiny change. The percentage of Debian users of Koha will probably be quite substantial due to the tools developed for it. (We eventually switched from Fedora to Debian for such reasons.) The various install modes (default, single, dev), Debian packaging, gitified, having possibly different directory structures etc., imo really beg for being simplified and brough together. But realizing that is hard. In the meantime the Debian percentage will keep growing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #24 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #23)
> (In reply to David Cook from comment #21)
> > As you can observe in the warning itself, the warning is for "Fetching the
> > value or values of a single named parameter". In the case of
> > '$query->param("name")', we're fetching the value of a single named
> > parameter. In the case of '$query->param()', we're fetching the names of all
> > the parameters. It's completely different.
>
> I don't understand, we both agree, it generates a warning.
Misunderstanding? He talks about calling it without arguments (and without
warning). You mean calls with an argument (and warnings dependent on context).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8397] Can import patrons with duplicate userids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397
--- Comment #5 from Jonathan Druart
---
(In reply to Mason James from comment #4)
> (In reply to Owen Leonard from comment #0)
> > If you use the "import patrons" tool to upload a CSV file of patron records
> > it is possible to create more than one patron with the same userid. This
> > should not be possible.
>
> I also hit this bug today, when attempting to import/update patrons with
> undefined ("") userids
Which versions? Do you have the unique key defined? (see bug 1861).
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15840] New: Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 Bug ID: 15840 Summary: Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcha...@gmail.com Reporter: m...@kohaaloha.com QA Contact: testo...@bugs.koha-community.org to replicate the bug 1/ import a borrowers.csv file containing any row with a blank 'userid' value, - use the 'overwrite' option. 2/ repeat step 1/ koha dies with error.. DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '' for key 'userid' at /path/to/yr/koha/C4/Members.pm line 683 bug confirmed on 3.18.9 -> master 43bcc1c -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 --- Comment #1 from Mason James --- Created attachment 48164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48164&action=edit pic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15841] New: Final truth value in C4:Circulation has become displaced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15841 Bug ID: 15841 Summary: Final truth value in C4:Circulation has become displaced Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Last thing in a module should be a true value, looks as though a subroutine has been added after the one in circulation. Lets put it back where it should be -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8397] Can import patrons with duplicate userids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397 Mason James changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15840 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Mason James changed: What|Removed |Added Blocks||15840 See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15840 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 Mason James changed: What|Removed |Added Depends on||1861 See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=1861, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=8397 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 [Bug 1861] Unique patrons logins not (totally) enforced -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8397] Can import patrons with duplicate userids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397
--- Comment #6 from Mason James ---
(In reply to Mason James from comment #4)
> (In reply to Owen Leonard from comment #0)
> > If you use the "import patrons" tool to upload a CSV file of patron records
> > it is possible to create more than one patron with the same userid. This
> > should not be possible.
>
> I also hit this bug today, when attempting to import/update patrons with
> undefined ("") userids
i logged a new bug, as it is a little different from this one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15841] Final truth value in C4:Circulation has become displaced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15841 Colin Campbell changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell --- Created attachment 48165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48165&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8397] Can import patrons with duplicate userids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397
--- Comment #7 from Mason James ---
(In reply to Jonathan Druart from comment #5)
> (In reply to Mason James from comment #4)
> > (In reply to Owen Leonard from comment #0)
> > > If you use the "import patrons" tool to upload a CSV file of patron
> > > records
> > > it is possible to create more than one patron with the same userid. This
> > > should not be possible.
> >
> > I also hit this bug today, when attempting to import/update patrons with
> > undefined ("") userids
>
> Which versions? Do you have the unique key defined? (see bug 1861).
version 3.18.9 to master
in my situation the unique key is '', which is a valid value hey?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
|y.org |
--- Comment #5 from Marcel de Rooy ---
I am having the impression that we do not completely tackle the problem (read
vulnerability given) here.
Because just switching param to multi_param (without looking to the context)
does not really solve it. You only suppress the warning.
We could still be vulnerable with calls like:
my $hash = { a => multi_param('b'), c => 'd' )
If multi_param b returns ( b1, b2, b3), your hash is 'injected' with b2 => b3,
just the same as param b would have done.
So we should check (before or after this patch) if we are calling params in a
hash context. If so, prepend with scalar.
Redefining methods/routines for lower versions of a module is not the most
elegant solution (from QA perspective). If we could prevent doing so, we
should.
Since we do not need to add calls to multi_param yet and we do not address the
actual vulnerability in this patch, I would propose to not add this
redefinition. We should concentrate on the calls to param in a hash context and
scalarize them. (The warnings in the log show us where these calls are.)
Failed QA
I will also ask for another (QA) opinion on the dev list.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 Mason James changed: What|Removed |Added Severity|enhancement |major Priority|P5 - low|P3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #26 from Marcel de Rooy --- (In reply to Julian Maurice from comment #24) Thx for your response. > Let's take an example: > - Patron 1 place a hold that starts on 2016-03-01 and ends on 2016-03-07 > - Patron 2 place a hold that starts on 2016-03-02 and ends on 2016-03-06 > If patron 1 get the book, patron 2 will never have it (unless patron 1 > returns the book very quickly, which is very unlikely to happen imo) and is > never informed about the high probability that this will happen. "Unlikely to happen imo " is the problem here. As a special library we loan the book and it will normally be returned the same day. (The book does not really leave the building.) > Another issue: > - Patron 1 place a hold that starts on 2016-03-02 and ends on 2016-03-08 > - Patron 2 place a hold (after patron 1 has placed their hold) that starts > on 2016-03-01 (we don't care about the end date here) > If priority is based on start date, then patron 2 will "steal" the book from > patron 1. Patron 1 will never get the book while they have placed their hold > first. No. Patron2 may receive the book before patron1. That is no problem. Patron1 will probably have it the next day. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 from M. Tompsett --- (In reply to Liz Rea from comment #5) > I don't understand, that behaviour predates this patch. > > Liz That's not the issue. Read the code. I called a fresh install with create DB and the createoptions file was empty, because it generated the else case. That's the else case message. That's why I put it to Failed QA, because it doesn't notice when it was called with --create-db in the case of a fresh install. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 --- Comment #6 from Marcel de Rooy --- Still we have the other situation that we do want multiple values: my @a = param( 'b' ); Should this actually be solved in CGI? It generates a lot of false warnings. For reasons of compatibility param cannot just return a scalar. Would it be simpler to only clear $CGI::LIST_CONTEXT_WARN for individual cases? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8397] Can import patrons with duplicate userids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397 --- Comment #8 from Katrin Fischer --- I haven't seen this problem in recent vresions - maybe there is a twist to it. We have seen errors where users haven't been imported because the userid in the file was already in the database. - So that appears to be checked correctly. Also when the same userid was listed twice in one import file, only the first would be imported. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8397] Can import patrons with duplicate userids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397 --- Comment #9 from Mason James --- (In reply to Owen Leonard from comment #0) > If you use the "import patrons" tool to upload a CSV file of patron records > it is possible to create more than one patron with the same userid. This > should not be possible. I've confirmed that it's no longer possible to import duped useres, however the import tool now dies in some conditions see bug 15840 for details -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #27 from Julian Maurice --- (In reply to Marcel de Rooy from comment #26) > No. Patron2 may receive the book before patron1. That is no problem. Patron1 > will probably have it the next day. For a 1-day loan that is true. Looks like we are going to need another reserves syspref :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8397] Can import patrons with duplicate userids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397 --- Comment #10 from Mason James --- (In reply to Katrin Fischer from comment #8) > I haven't seen this problem in recent vresions - maybe there is a twist to > it. > We have seen errors where users haven't been imported because the userid in > the file was already in the database. - So that appears to be checked > correctly. Also when the same userid was listed twice in one import file, > only the first would be imported. i think the twist is that the bug is triggered when using the 'overwrite' import option, rather than 'ignore/skip' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8397] Can import patrons with duplicate userids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397 --- Comment #11 from Katrin Fischer --- Maybe it's some change since 3.18.x that we are using - because iirc that was with overwrite. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 --- Comment #2 from Mason James --- (In reply to Mason James from comment #0) > to replicate the bug > > 1/ import a borrowers.csv file containing any row with a blank 'userid' > value, > - use the 'overwrite' option. > actually the bug is triggered using *any* duplicated 'userid' value, not just "" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 --- Comment #3 from Mason James --- (In reply to Mason James from comment #2) > (In reply to Mason James from comment #0) > > to replicate the bug > > > > 1/ import a borrowers.csv file containing any row with a blank 'userid' > > value, > > - use the 'overwrite' option. > > > > actually the bug is triggered using *any* duplicated 'userid' value, not > just "" ..which means if you import any .csv file twice (with overwrite option), the error is triggered -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 --- Comment #7 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #5) > I am having the impression that we do not completely tackle the problem > (read vulnerability given) here. > Because just switching param to multi_param (without looking to the context) > does not really solve it. You only suppress the warning. Yes of course, but we are now aware of this problem, and it's the QA's job to catch them if they are wrongly used. > Redefining methods/routines for lower versions of a module is not the most > elegant solution (from QA perspective). If we could prevent doing so, we > should. > Since we do not need to add calls to multi_param yet and we do not address > the actual vulnerability in this patch, I would propose to not add this > redefinition. We should concentrate on the calls to param in a hash context > and scalarize them. (The warnings in the log show us where these calls are.) The goal was to remove the warnings for production installs using CGI < 4.08. As a developer, I am using > 4.08 and will see the warnings in my logs. (In reply to Marcel de Rooy from comment #6) > Still we have the other situation that we do want multiple values: > my @a = param( 'b' ); > > Should this actually be solved in CGI? It generates a lot of false warnings. > For reasons of compatibility param cannot just return a scalar. How do you want to fix that, I don't think I understand what you meant here. > Would it be simpler to only clear $CGI::LIST_CONTEXT_WARN for individual > cases? I don't think so, developers won't see the warnings, we should keep them to know where the issues could come from. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #3 from Jonathan Druart --- Created attachment 48168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48168&action=edit Bug 15839: Koha::Reviews - Remove getallreviews -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #2 from Jonathan Druart --- Created attachment 48167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48167&action=edit Bug 15839: Koha::Reviews - Remove getreviews The C4::Reviews::getreviews subroutine retrieved the reviews for a given record, depending on their status. This can be achieve with a call to Koha::Reviews->search. There were 2 calls to this subroutine. The one from opac-ISBDdetail.pl does not look in used: the reviews are not display on this page. It certainly comes from an old copy/paste from opac-detail.pl. The one from opac-detail only asked for the approved reviews. So the logged in user does not see its own review if it is pending approval. Actually this pending approval review is only displayed when the user submits it (because of a unecessary complex text replacement done in JS). With this patch, the approved reviews AND the unaproved review from the logged in user will be displayed. It will allow a future enhancement to add a way to delete our own reviews. Moreover, the reviews were retrieved even if they were not displayed (if reviewson is off), it's now fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #1 from Jonathan Druart --- Created attachment 48166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48166&action=edit Bug 15839: Koha::Reviews - Add Koha::Review[s] classes The subroutines in C4::Reviews are only doing CRUD operations. This patch set moves them to 2 new Koha::Review[s] classes. Test plan for the whole patch set: 0/ Set the reviewson syspref 1/ At the OPAC, create a couple of reviews for a record Try and create a review without html tags different that br b i em big small strong: You should get a warning. 2/ Edit a review 3/ On the Staff interface, you should see a "Comments pending approval" link on the mainpage 4/ Approve 1 review and delete the other 5/ At the OPAC you should only see 1 review (the approved one) in the "Comments" tab 6/ Modify the review 7/ The review should appear again in the "comments awaiting moderation" tab. Note that even the comment has not been changed, it will have to be reapproved (FIXME later). This behavior already existed prior to this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #6 from Jonathan Druart --- Created attachment 48171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48171&action=edit Bug 15839: Koha::Reviews - Remove deletereview Note that a future enhancement should take into account the possible error returned by ->approve, ->unapprove and ->delete -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #7 from Jonathan Druart --- Created attachment 48172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48172&action=edit Bug 15839: Koha::Reviews - Remove getreview Note that this (biblionumber, borrowernumber) pair should be defined as a unique key at the DB level (FIXME added) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #8 from Jonathan Druart --- Created attachment 48173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48173&action=edit Bug 15839: Koha::Reviews - Remove getnumberofreviews -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #4 from Jonathan Druart --- Created attachment 48169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48169&action=edit Bug 15839: Koha::Reviews - Remove approvereview & unapprovereview This patch adds 2 new methods to Koha::Review: approve and unapprove. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #9 from Jonathan Druart --- Created attachment 48174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48174&action=edit Bug 15839: Koha::Reviews - Remove updatereview -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #10 from Jonathan Druart --- Created attachment 48175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48175&action=edit Bug 15839: Koha::Reviews - Remove savereview -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #5 from Jonathan Druart --- Created attachment 48170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48170&action=edit Bug 15839: Koha::Reviews - Change default value for approved to 0 The reviews.approved column had a default value set to NULL. It does not make sense, the default value should be 0, this will avoid to have to specify the approved value when creating a new review. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #11 from Jonathan Druart --- Created attachment 48176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48176&action=edit Bug 15839: Koha::Reviews - Remove C4::Review residue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What|Removed |Added Attachment #47905|0 |1 is obsolete|| Attachment #47906|0 |1 is obsolete|| Attachment #47907|0 |1 is obsolete|| Attachment #47908|0 |1 is obsolete|| Attachment #47909|0 |1 is obsolete|| Attachment #47910|0 |1 is obsolete|| Attachment #47911|0 |1 is obsolete|| Attachment #47912|0 |1 is obsolete|| Attachment #47913|0 |1 is obsolete|| Attachment #47914|0 |1 is obsolete|| Attachment #47915|0 |1 is obsolete|| Attachment #47916|0 |1 is obsolete|| Attachment #47917|0 |1 is obsolete|| Attachment #47918|0 |1 is obsolete|| Attachment #47919|0 |1 is obsolete|| Attachment #47920|0 |1 is obsolete|| Attachment #47921|0 |1 is obsolete|| Attachment #47922|0 |1 is obsolete|| --- Comment #149 from Kyle M Hall --- Created attachment 48177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48177&action=edit Squashed followups into main patch set for ease of reading. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #150 from Kyle M Hall --- Created attachment 48178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48178&action=edit Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #152 from Kyle M Hall --- Created attachment 48180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48180&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #154 from Kyle M Hall --- Created attachment 48182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48182&action=edit Bug 14610 - Update opac.css via less -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #153 from Kyle M Hall --- Created attachment 48181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48181&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #151 from Kyle M Hall --- Created attachment 48179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48179&action=edit Bug 14610 - Add and update scripts Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 --- Comment #8 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #7) > The goal was to remove the warnings for production installs using CGI < 4.08. > As a developer, I am using > 4.08 and will see the warnings in my logs. Older CGI versions do not have this warning. I am not sure about the exact version, but it could well be that the introduction of multi_param also added this warning. How does your solution differentiate production from other installs? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 --- Comment #7 from M. Tompsett --- Created attachment 48184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48184&action=edit Bug 15088 - Follow for koha-create Logic in the koha-create was requiring a DEFAULTSQL to trigger. This patch moves it, such that --create-db will be registered all the time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Jonathan Druart changed: What|Removed |Added Blocks||15842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15842] New: Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Bug ID: 15842 Summary: Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Tools Assignee: k...@bywatersolutions.com Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 9303 When importing patrons with a csv file which does not contain the privacy_guarantor_checkouts column in the header, you will get DBIx::Class::Storage::DBI::_dbh_execute(): Column 'privacy_guarantor_checkouts' cannot be null at /home/koha/src/C4/Members.pm line 768 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 [Bug 9303] relative's checkouts in the opac -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15818] OPAC search with utf-8 characters and without results generates encoding error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818 --- Comment #3 from Dobrica Pavlinusic --- Jonathan, I'm wondering do you have libencode-perl package installed or are you using Encode which ships with perl (and which version?). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15843] New: Move MARC subfields structure JavaScript into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15843 Bug ID: 15843 Summary: Move MARC subfields structure JavaScript into separate file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Coding guideline JS1 (https://wiki.koha-community.org/wiki/Coding_Guidelines#JS1:_Embedding_JavaScript_blocks_in_templates) says "Whenever possible JavaScript should be placed in a separate file." The JavaScript embedded in admin/marc_subfields_structure.tt is not dependent on template processing, so it can be safely moved to a separate file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15843] Move MARC subfields structure JavaScript into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15843 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15843] Move MARC subfields structure JavaScript into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15843 --- Comment #1 from Owen Leonard --- Created attachment 48185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48185&action=edit Bug 15843 - Move MARC subfields structure JavaScript into separate file The JavaScript embedded in the MARC subfields structure template is not dependent on template processing and can safely be moved to a separate file. This patch does so. Removed in the process is some lines which were commented out. To test, apply the patch and go to Administration -> MARC framworks. - Click 'MARC structure' for a framework you can edit. - Click 'subfields' for a tag you can edit. - Click 'Edit' for a subfield you can edit. - Confirm that tabs and accordian sections work correctly. - Make changes under Advanced constraints -> Visibility and confirm that they are saved correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15840 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
See Also||https://bugs.koha-community
||.org/bugzilla3/show_bug.cgi
||?id=15842
--- Comment #5 from Jonathan Druart
---
I don't reproduce, because the import patron tool is broken at the moment, by
bug 15842.
But looking at the code, I don't understand how it could happen, there is:
733 $data{'userid'} = Generate_Userid( $data{'borrowernumber'},
$data{'firstname'}, $data{'surname'} )
734 if ( $data{'userid'} eq '' || !Check_Userid( $data{'userid'} ) );
in C4::Members::AddMember which should avoid that.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15662] String and translatability fix to Label Creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 Héctor Eduardo Castro Avalos changed: What|Removed |Added CC||hector.hecax...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15844] New: Correct JSHint errors in staff-global.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15844 Bug ID: 15844 Summary: Correct JSHint errors in staff-global.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Following coding guideline JS8: "Follow guidelines set by JSHint," some errors should be corrected in staff-global.js staff-global.js: line 7, col 73, Missing semicolon. staff-global.js: line 7, col 75, Missing semicolon. staff-global.js: line 16, col 2, Unnecessary semicolon. staff-global.js: line 103, col 13, 'newin' is already defined. staff-global.js: line 125, col 39, Use '===' to compare with '0'. staff-global.js: line 125, col 73, Use '===' to compare with '0'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 M. Tompsett changed: What|Removed |Added Attachment #48184|0 |1 is obsolete|| --- Comment #9 from M. Tompsett --- Created attachment 48187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48187&action=edit Bug 15088 - Follow for koha-create Logic in the koha-create was requiring a DEFAULTSQL to trigger. This patch moves it, such that --create-db will be registered all the time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 M. Tompsett changed: What|Removed |Added Attachment #44347|0 |1 is obsolete|| --- Comment #8 from M. Tompsett --- Created attachment 48186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48186&action=edit [SIGNED-OFF] Bug 15088 - notice when koha has been installed with --request-db instead of --create-db Patch does 2 major things - * creates an options file during koha-create that lets us know what database option was used when the instance was created /etc/koha/sites/$name/createoptions * when an instance is removed, we assume we can do things to the database, per usual. If we have a createoptions, we'll read it and find out if our instance was created with create-db or request-db. If it was requested, we don't do anything with the database because we assume we don't have rights to, and print a message. If it was created, we do the same thing we've always done - remove the database and users (unless we've specified --keep-mysql) To test: create a throwaway instance with --create-db remove that instance, all should happen as normal. your instance should have an /etc/koha/sites/$name/createoptions file with REQUEST_DB=0 in it. create another throwaway instance with --request-db remove that instance, you should see a message alerting you to the fact that you may still have database work to do after Koha is removed. your instance should have an /etc/koha/sites/$name/createoptions file with REQUEST_DB=1 in it. NOTE: Only works in conjuction with my patch. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 M. Tompsett changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #10 from M. Tompsett --- If you could test and sign off, Liz, I would be glad to have this set to signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 --- Comment #9 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #8) > (In reply to Jonathan Druart from comment #7) > > The goal was to remove the warnings for production installs using CGI < > > 4.08. > > As a developer, I am using > 4.08 and will see the warnings in my logs. > > Older CGI versions do not have this warning. I am not sure about the exact > version, but it could well be that the introduction of multi_param also > added this warning. You might be right. In this case, we could remove $CGI::LIST_CONTEXT_WARN = 0; from the patch. > How does your solution differentiate production from other installs? It does not -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
