[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #203 from Katrin Fischer  ---
Hi Kyle, I should try and clarify my comment :) I am not against including this
as an experimental feature at all! - I just think we need to be clear and
upfront in documentation on what is working and what not - so people know what
to expect. Right now I am not quite sure what to expect of the work available -
what should be working? What is intended to work? It would help me to
understand that better and give me a starting point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

--- Comment #46 from M. Tompsett  ---
(In reply to Nick Clemens from comment #44)
> On a fresh DB I am having issues with the loss of the 'letternumber' column 
> overdue_notices.pl throws errors for unknown column, I can't save triggers 
> I think the last line below was an accidental deletion?

Yes. I agree with that assessment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

--- Comment #45 from M. Tompsett  ---
Comment on attachment 38288
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38288
Bug 13624 - Remove columns branchcode, categorytype from table
overduerules_transport_types

This is the obsoleted patch where it accidentally disappeared.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967

Nick Clemens  changed:

   What|Removed |Added

  Attachment #48605|0   |1
is obsolete||

--- Comment #2 from Nick Clemens  ---
Created attachment 48654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48654=edit
Bug 15967: Fix regression from bug 14133 - notify the library if patron is not

Regression introduced by bug 14133, see but 14133 comment 13.

Test plan:
Without this patch applied, if a patron cannot be notified (no email
address or sms number), the print notice generated for the library was
not.
With this patch applied, the print notice should be generated using the
print template

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #44 from Nick Clemens  ---
On a fresh DB I am having issues with the loss of the 'letternumber' column 

overdue_notices.pl throws errors for unknown column, I can't save triggers 

I think the last line below was an accidental deletion?

diff --git a/installer/data/mysql/kohastructure.sql
b/installer/data/mysql/kohastructure.sql
...
@@ -2568,12 +2569,10 @@ CREATE TABLE `message_transport_types` (
 DROP TABLE IF EXISTS `overduerules_transport_types`;
 CREATE TABLE overduerules_transport_types(
 `id` INT(11) NOT NULL AUTO_INCREMENT,
-`branchcode` varchar(10) NOT NULL DEFAULT '',
-`categorycode` VARCHAR(10) NOT NULL DEFAULT '',
-`letternumber` INT(1) NOT NULL DEFAULT 1,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

--- Comment #7 from M. Tompsett  ---
Wow. Much more comprehensive tests.
I'll have to look into the clone issue.
I can't remember why I had hidden, except to perhaps clarify that a delete was
a hide. I'll look more closely at your comments.
Though, I just noticed you missed a perldoc change in the package, because you
renamed the test file. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #4 from Brendan Gallagher  ---
Needs some rebasing Owen - Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15950] Use Font Awesome icons for acquisitions basket close confirmation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15950

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15951] Use Font Awesome icons for acquisitions order cancellation confirmation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15951

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #4 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2106 Release.  Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15959] Use Font Awesome icons for attach item confirmations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #5 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15925] Correct some markup issues with patron lists pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15925

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15940] Remove unused JavaScript from authorities MARC subfield structure

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15755] Default item type is not marked as "All" in circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #4 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15864] SMS cellular providers link missing from administration sidebar menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15864

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #5 from Brendan Gallagher  ---
Pushed to Master - Should be in May 2016 Release.  Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #9 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 Release. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #10 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15976] test bug for a script we are developping.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15976

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |remi.mayrand-provencher@inL
   |y.org   |ibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15976] New: test bug for a script we are developping.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15976

Bug ID: 15976
   Summary: test bug for a script we are developping.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: bugs.koha-community.org
  Assignee: remi.mayrand-provenc...@inlibro.com
  Reporter: remi.mayrand-provenc...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: remi.mayrand-provenc...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Jesse Weaver  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #25 from Jesse Weaver  ---
Pushed to master, thanks for your work!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974

Jesse Weaver  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|pianohac...@gmail.com   |jwea...@bywatersolutions.co
   ||m
 CC||jwea...@bywatersolutions.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15350] DBIx::Class Startup speed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15350

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #48519|0   |1
is obsolete||

--- Comment #5 from Jesse Weaver  ---
Created attachment 48653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48653=edit
Bug 15350: Move the import of Koha::Schema to a basic `use`

This moves the import of Koha::Schema from an on-demand `require` to
just a `use`; most everything in Koha uses C4::Context, which will
indirectly end up calling Koha::Database->schema->new anyway, so this
was no longer saving anything.

Note that this saves time only when a Plack-based Koha needs to create
a database connection, which is usually only the case for a new worker.

Unscientific timings before patch:
  * First load of koha2marclinks.pl on a new worker: 0.70 seconds
  * Each load after: 0.17 seconds

After patch:
  * First load: 0.31 seconds
  * Each load after: 0.17 seconds

Jonathan, you seem to be right. NYTProf was making me think we needed to do
both, but timings suggest otherwise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #51 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #49 from Brendan Gallagher  ---
Pushed to MAster - Should be in the May 2016 Release.  Thanks!  (Let me know if
I missed something here - but I'm pretty sure we are good to go)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s]

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #26 from Brendan Gallagher  ---
Ah thanks Jonathan - I thought it was something silly like that.  Ok last patch
pushed to master - may 2016 release target.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11998] Syspref caching issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

--- Comment #100 from Chris Cormack  ---
Please note I have tested this under CGI, caching works fine, but it still
needs testing under plack.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #83 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release!  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11998] Syspref caching issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11998] Syspref caching issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Chris Cormack  changed:

   What|Removed |Added

  Attachment #48640|0   |1
is obsolete||

--- Comment #99 from Chris Cormack  ---
Created attachment 48652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48652=edit
Bug 11998: Use Koha::Cache to cache sysprefs

At the moment, the sysprefs are only cache in the thread memory
executing the processus
When using Plack, that means we need to clear the syspref cache on each
page.
To avoid that, we can use Koha::Cache to cache the sysprefs correctly.

A big part of the authorship of this patch goes to Robin Sheat.

Test plan:
1/ Add/Update/Delete local use prefs
2/ Update pref values and confirm that the changes are correctly taken
into account

Signed-off-by: Chris 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #58 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.   Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #202 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #198)
> We should avoid to repeat the Solr problem - I think part of the problem was
> that it was not production ready when included in Koha and I'd hate to see
> us get stuck in a similar way with ES. 

I think the problem was that Solr integration ran out of steam ( i.e.
development funding ). That is not going to happen with Elastic. I think it's
safe to say that we are fully committed to getting Elastic to work with Koha.
It's something of a chicken and egg problem. We can't let past failures cause
hesitation on future opportunities, that will only lead to stagnation.

As an aside, I'm looking forward to Elastic as a way to greatly speed up our
patron search. With Elastic we'll be able to index our patron data as well as
record data! In fact, we'll be able to use it for any type of data where we
search on large data sets! Once Elastic is part of Koha I plan on starting to
work on an (optional) way for the patron search to take advantage of Elastic.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15975] New: Add Owning Library Column to Checkouts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975

Bug ID: 15975
   Summary: Add Owning Library Column to Checkouts
 Change sponsored?: Seeking cosponsors
   Product: Koha
   Version: master
  Hardware: All
   URL: http://devs.bywatersolutions.com/projects/add-owning-l
ibrary-column-checkouts/
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Work to do:

Include owning library column on the list of checkouts for patrons.
Pages needing enhancement:
cgi-bin/koha/circ/circulation.pl
cgi-bin/koha/members/moremember.pl



Seeking Co Sponsors :
http://devs.bywatersolutions.com/projects/add-owning-library-column-checkouts/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974

Ed Veal  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |pianohac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930

--- Comment #5 from Heather Braum  ---
This issue is definitely a bug, and a step backward in Koha's search. 

Our system has used Koha for 8 years. And the behavior through 3.18.12 (where
our system was before we moved to 3.22.3), was that searching for patrons by
both firstname and surname always worked in all the various patron search
boxes: holds searching, search patrons, guarantor search, checkout search, etc. 

When we moved to 3.22.3 on Sunday, I could no longer search for patrons using
first name and surname on request.pl (holds requests) and guarantor search (The
test patron I used was white sox, but we saw this with numerous other patrons).
Checkout search with these names worked, as did using search patrons through
the patrons page OR moremember.pl. Yesterday, two librarians reported that the
search patrons tab on the Koha home page also returned no results. 

Nick has temporarily patched these three instances for us so the system is back
to behaving the way it always has behaved. 

There needs to be a more permanent fix for this issue. We can't be the only
system where librarians click in these patron search boxes and type in first
name and last name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

--- Comment #9 from Héctor Eduardo Castro Avalos  ---
Hi Nick and Barton
Community sign-off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #46098|0   |1
is obsolete||

--- Comment #8 from Héctor Eduardo Castro Avalos  ---
Created attachment 48651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48651=edit
Bug 14277: add zebra indexes for lexile that respect 521 indicator 1.

Added the following indexes:

Interest-age-level | 591$a ind1=1
Interest-grade-level | 591$a ind1=2
lexile-number | 591$a ind1=8
Reading-grade-level | 591$a ind1=0

Moved 'lex' from a zebra index to a ccl alias to lexile-number.

Changed the handling of st-numeric in C4/Search.pm to allow for search ranges.

Signed-off-by: Nick Clemens 
Signed-off-by: Hector Castro 
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15974] New: Rancor - 942c is always displaying first in the list.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974

Bug ID: 15974
   Summary: Rancor - 942c is always displaying first in the list.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: ed.v...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

When you open a record up using the advanced marc editor if there is a 942c the
display will show the first in the list of possible koha Itypes. If you change
this to the correct type it will save correctly. 

However, if you open a record and don't correct the 942c it will save based on
what appears in the field (the first option). 

Ed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15889] Login with LDAP deletes extended attributes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15889

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15889] Login with LDAP deletes extended attributes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15889

Chris Cormack  changed:

   What|Removed |Added

  Attachment #48327|0   |1
is obsolete||

--- Comment #2 from Chris Cormack  ---
Created attachment 48650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48650=edit
Bug 15889 - LDAP authentication: Only update mapped attributes.

Test plan:

- Update your configuration file to use LDAP authentication and enable update
  (1) option,
- login with an existing user with extended attrbitutes that are not in
LDAP mapping,
- check that all attributes are still here.

Signed-off-by: Chris 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||remi.mayrand-provencher@inL
   ||ibro.com

--- Comment #26 from Rémi Mayrand-Provencher 
 ---
fixed conflicts, patch should apply correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #25 from Rémi Mayrand-Provencher 
 ---
Created attachment 48649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48649=edit
Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Hostname : catalogue.banq.qc.ca
Port : 210
Database : IRIS
Syntax   : Marc21

2) Perform a z3950 search on that server.
Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
@attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

modified:   C4/Breeding.pm
modified:   Koha/Schema/Result/Z3950server.pm
modified:   admin/z3950servers.pl
new file:  
installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql
modified:   installer/data/mysql/kohastructure.sql
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168

--- Comment #30 from Brendan Gallagher  ---
Ok I should be caught up on this one now.  Please let me know if I did
something screwy or missed something.  

Thanks much

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

 CC||remi.mayrand-provencher@inL
   ||ibro.com
 Status|Patch doesn't apply |Needs Signoff

--- Comment #26 from Rémi Mayrand-Provencher 
 ---
Fixed conflicts, the patch should now apply properly. 

Like my coworker said earlier in this discussion, our sponsor is not interested
in developping a new preference that allows guarantors to be cc'd. We think
this patch is ok on its own and if there happens to be a need for guarantors to
be cc'd, the patch for this new feature should be in another bug report.
Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

--- Comment #25 from Rémi Mayrand-Provencher 
 ---
Created attachment 48645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48645=edit
Bug 12532 - Redirect guarantee email to guarantor

Added unit tests.
Added an atomicupdate file.
Reordered the sysprefs in alphabetical order.
Refactored some code.

TEST PLAN:

I Apply the patch
II Run updatedatabase.pl
III Run db_dependent/Letters.t and db_dependant/Members.t

0) Enable EnhancedMessagingPreferences preference;
0) Enable EnableRedirectGuaranteeEmail preference;
1) Select a patron with child;
2) Enable Item checkout -> email in patron messaging preferences;
3) Select the patron's child;
4) Checkout an item;
5) Valide child checkout message in patron's inbox;

sponsored by the ville de victoriaville

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #22 from Frédéric Demians  ---
Kyle, my patch was also about adding (In reply to Kyle M Hall from comment #21)
> I think the issue at hand is that this patch revealed a new bug in testing
> where the non-package version of Koha's apache conf no longer matches the
> package version in behavior and functionality. While appreciated, I think
> Frédéric's followup is not needed and we should instead fix the bug for
> non-package installs of Koha. That should solve the issue and once that and
> the license followup have been submitted this can move forward.

I agree with this plan...

Where is located the Apache conf file? Do you already know what is its
difference with etc/koha-http.conf?

My followup patch was also introducing a way to specify a local XSLT in
extended mode. See this:

https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46460=diff

But it could be added later when this patch will be in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11998] Syspref caching issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15973

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15973] Do not disable syspref cache for Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15973

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=11998

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11998] Syspref caching issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

--- Comment #98 from Jonathan Druart  
---
Patches squashed, rebased and adapted to current master.
I have rewritten and it seems to work as expected.
See also bug 15970, bug 15341 and bug 15873, to know why we need this patch.

Note that we still have 
Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo at
/usr/share/perl/5.20/fields.pm line 135.
Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo at
/usr/share/perl/5.20/fields.pm line 135.
Name "Tie::Hash::FIELDS" used only once: possible typo at
/usr/share/perl/5.20/fields.pm line 135.

Forget them, unless you know how to fix them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #41 from Héctor Eduardo Castro Avalos  
---
Of course otherwise works correctly. About QA comments (comment 38) we need to
await Jonathan's reply.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46464|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Failed QA   |Signed Off

--- Comment #21 from Kyle M Hall  ---
I think the issue at hand is that this patch revealed a new bug in testing
where the non-package version of Koha's apache conf no longer matches the
package version in behavior and functionality. While appreciated, I think
Frédéric's followup is not needed and we should instead fix the bug for
non-package installs of Koha. That should solve the issue and once that and the
license followup have been submitted this can move forward.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341

--- Comment #14 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #13)
> Something interesting:
> 
> on master:
> # spent 35.1ms within DBI::common::DESTROY which was called 12520 times, avg
> 3µs/call
> 
> with path:
> # spent 2.54s (697ms+1.85) within DBIx::Class::DESTROY which was called
> 118584 times, avg 21µs/call

Note that I don't get that without C4::Context->clear_syspref_cache, see bug
15970.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #48587|0   |1
is obsolete||

--- Comment #28 from Jesse Weaver  ---
Created attachment 48643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48643=edit
Bug 14168: (followup) require WWW::YouTube::Download only when syspref enabled

This patch fixes the problem of missing WWW::YouTube::Download breaking
record detail views. Instead of a general 'use', the module is only
required if the related syspref is enabled.

Signed-off-by: Jesse Weaver 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #48637|0   |1
is obsolete||

--- Comment #29 from Jesse Weaver  ---
Created attachment 48644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48644=edit
Bug 14168: (followup) atomic update for syspref

Signed-off-by: Jesse Weaver 
Fixed small typo (extra ').

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #40 from Héctor Eduardo Castro Avalos  
---
Created attachment 48642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48642=edit
Cash register image

Hi Rémi

Still capitalization in reports-menu.inc

>Serials
>Cash 
> Register

I could observe this:

When you start both calendars are set with the current date, i.e., 2016-03-03,
but if you change the "From:" date to 2016-01-01, the date in "To:" change also
and if you try to change it, for example, to the current date (2016-03-03), you
cannot do it at all with the calendar, just manually.

See image attached.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15970] Plack should not clear syspref cache

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970

--- Comment #3 from Jonathan Druart  
---
Created attachment 48641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48641=edit
Bug 15970: Do not clear syspref cache in psgi file

This in only in koha.psgi, it has been introduced by bug 13815 but
should not have been added by this patch.

Removing it should not introduce any changes.
Not that it won't impact debian packages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15970] Plack should not clear syspref cache

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11998] Syspref caching issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #36583|0   |1
is obsolete||
  Attachment #36584|0   |1
is obsolete||
  Attachment #36585|0   |1
is obsolete||
  Attachment #36586|0   |1
is obsolete||
  Attachment #36587|0   |1
is obsolete||
  Attachment #36588|0   |1
is obsolete||
  Attachment #36589|0   |1
is obsolete||
  Attachment #36590|0   |1
is obsolete||
  Attachment #36591|0   |1
is obsolete||
  Attachment #36592|0   |1
is obsolete||
  Attachment #36593|0   |1
is obsolete||
  Attachment #36594|0   |1
is obsolete||
  Attachment #36595|0   |1
is obsolete||

--- Comment #97 from Jonathan Druart  
---
Created attachment 48640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48640=edit
Bug 11998: Use Koha::Cache to cache sysprefs

At the moment, the sysprefs are only cache in the thread memory
executing the processus
When using Plack, that means we need to clear the syspref cache on each
page.
To avoid that, we can use Koha::Cache to cache the sysprefs correctly.

A big part of the authorship of this patch goes to Robin Sheat.

Test plan:
1/ Add/Update/Delete local use prefs
2/ Update pref values and confirm that the changes are correctly taken
into account

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11998] Syspref caching issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15973] Do not disable syspref cache for Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15973

--- Comment #2 from Jonathan Druart  
---
Created attachment 48638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48638=edit
Bug 15973: follow-up for the debian package psgi file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #48632|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 48639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48639=edit
Bug 14577 - Allow restriction of checkouts based on fines of guarantor's
guarantees

This enhancment allows a library to prevent patrons from checking out
items if his or her guarantees own too much.

Test Plan:
1) Apply this patch
2) Find or create a patron with a guarantor
3) Add a fine to the patron's account
4) Set the new system preference NoIssuesChargeGuarantees to be less
   than the amount owed by the patron
4) Attempt to check out an item to the guarantor, you will either
   be warned or prevented from checking out based on your system
   settings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15973] Do not disable syspref cache for Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15973

--- Comment #1 from Jonathan Druart  
---
Created attachment 48636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48636=edit
Bug 15973: Revert "Bug 13805: (Plack) Disable syspref cache"

This reverts commit ca00f0ddaeb76106b4aa274fd1848844ae042f58.

Bug 13805 fixes an installer bug by disabling the syspref cache.
It was not a good idea, it introduced performance issues (see bug 13805
comment 14).

Test plan:
Test plan:
0/ Create a new database and fill the database entry in the koha conf
with its name
1/ Go on the mainpage, you should be redirected to the installer
2/ Try to log in
You should not get the login form again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11998] Syspref caching issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15970


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970
[Bug 15970] Plack should not clear syspref cache
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15970] Plack should not clear syspref cache

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||11998


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998
[Bug 11998] Syspref caching issues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15970] Plack should not clear syspref cache

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970

--- Comment #2 from Jonathan Druart  
---
(In reply to Jacek Ablewicz from comment #1)
> (In reply to Jonathan Druart from comment #0)
> > Just played with nytprof and found something exciting:
> > 
> > If I remove the following line:
> >   C4::Context->clear_syspref_cache();
> > from the psgi file, the processing time is divided per 2 (!)
> > 
> > With the clear cache:
> > for 15.8s (of 18.6s), executing 2588556 statements and 903720 subroutine
> > calls in 421 source files and 63 string evals.
> > 
> > Without the clear cache:
> > for 7.82s (of 8.69s), executing 904432 statements and 262539 subroutine
> > calls in 421 source files and 63 string evals.
> 
> Such a difference looks kind of weird - unless the script you are testing
> calls (for whatever reasons) CGI->new() repeatedly ?
> 
> BTW, how many times was C4::Context::preference() called in that test?

No idea, patch is coming.

> > Am I missing something?
> 
> With that line removed, each time when you change some syspref value, you'll
> need to restart starman server/workers manually for that change to take
> effect. However, clearing syspref cache inside CGI->new() override sub is
> probably not 100% flawless method anyway, so serwer restarts are still
> needed if one wants to be on the safe side ;)

Yes indeed, I have fixed bug 11998 to solve this constraint.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13805] Installer does not work under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

--- Comment #18 from Jonathan Druart  
---
See bug 15973 for the revert.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168

--- Comment #27 from Mirko Tietgen  ---
Created attachment 48637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48637=edit
Bug 14168 Followup: Atomic update for syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15973] Do not disable syspref cache for Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15973

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #37 from Blou  ---
Created attachment 48635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48635=edit
Bug 11317 - Allows for multiple directories to be accessible

It is now possible to add as many SOMEDIR as needed to
the config file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15973] New: Do not disable syspref cache for Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15973

Bug ID: 15973
   Summary: Do not disable syspref cache for Plack
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 13805

Bug 13805 fixes an installer bug by disabling the syspref cache.
It was not a good idea, it introduced performance issues (see bug 13805 comment
14).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805
[Bug 13805] Installer does not work under Plack
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13805] Installer does not work under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15973


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15973
[Bug 15973] Do not disable syspref cache for Plack
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15965] Koha to MARC mapping - table changes with selection of drop down menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15965

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #2 from Frédéric Demians  ---
It works. But why this:

+$('#koha2marc').find("input:submit").hide();

Since you have already this:

-

If at first place, you hide in JS the submit button, isn't it in order to keep
working the form whether JS is disabled. So why suppressing the  itself?
For me, JS has to be activated in the pro interface, and as so, the JS line
should be suppressed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

 CC||remi.mayrand-provencher@inL
   ||ibro.com
 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #39 from Rémi Mayrand-Provencher 
 ---
Created attachment 48634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48634=edit
Bug 6934 - QA Follow-up

Tried to address every single thing that QA mentioned :
1)Removed isNull function
2)Changed datepicker properly
3)We have to fill in two dates not to be flooded with old entries if we don't
want to.
4)The first two fieldsets are now in one bigger field set
5)Removed the use of $fullreportname variable
6)Removed the use of dt_from_string when it already recieved a DT.
7)Removed comments starting with "###" in cash_register_stats.pl
8)Used Text::CSV::Encoded to generate the CSV file (used guided_reports.pl as
an example)
9)I am not sure if using C4::Reports::Guided is the right choice here. I
instead used the same column names as the one recieved by the query in
cash_register_stats because this report uses columns from 5 different tables in
addition of using both firstname and surname twice.

For the ninth point, I would like to know more about C4::Reports::Guided if you
still think using it would be a better solution. Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #48617|0   |1
is obsolete||

--- Comment #2 from Frédéric Demians  ---
Created attachment 48633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48633=edit
Bug 15968: Unnecessary loop in C4::Templates

From C4::Templates::output

 # add variables set via param to $vars for processing
 for my $k ( keys %{ $self->{VARS} } ) {
 $vars->{$k} = $self->{VARS}->{$k};
 }

This loop is not necessary, we could do the same with

 $vars = { %$vars, %{ $self->{VARS} } };

After a quick benchmark, it gains 100 microseconds when we pass 170 vars
to the template.

Test plan:
Do some clicks on the interface, everything should be ok.

Signed-off-by: Frédéric Demians 
  Perl idiosyncratic way of merging hash, clearer, if not quicker (not
  verified)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #47936|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 48632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48632=edit
Bug 14577 - Allow restriction of checkouts based on fines of guarantor's
guarantees

This enhancment allows a library to prevent patrons from checking out
items if his or her guarantees own too much.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15972] New: Make it possible to include additional title information in notices (such as 245$b)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15972

Bug ID: 15972
   Summary: Make it possible to include additional title
information in notices (such as 245$b)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

For some titles the 245$a (MARC21) is not specific enough and it would be
necessary to include the 245$b information in the notices, that is currently
not mapped in the database.

Apart from 245$b (remainder of title) other information like 245$n/$p for
volumes would be nice to have.

This was reported by a library using serial claims - where the title is often
the same and the correct serial can only be identified with the help of
additional information.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15971] New: Allow use of all biblio and biblioitems fields in serial claim letters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15971

Bug ID: 15971
   Summary: Allow use of all biblio and biblioitems fields in
serial claim letters
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

When creating a serial claim letter only title, author and serial are offered
as fields in the notice editor. It should be possible to print all fields from
the biblio and biblioitems tables including the ISSN in the notices.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #26 from Jonathan Druart  
---
New pref not added by the update DB process, please fix asap.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #48349|0   |1
is obsolete||

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 48631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48631=edit
Bug 15871: Improve PerlCritic level for t/RecordProcessor.t

perlcritic -5 failed.
Attempt to clean up to a higher level:
-- use English to address use of $@ variable
-- perltidy on the code
-- substitute q{} for ''
-- expand out single line hacky goodness (... s/\.pm$//) to more code
-- remove parenthesis on functions that don't need it
-- add x, s, and m as needed to regexps
-- change double quotes to single quotes where no variable involved
-- tweaked eval destroy test to check return value and use $EVAL_ERROR
-- renamed $processor to $record_processor in the subtest to avoid
   lexical warnings

TEST PLAN
-

$ perlcritic -5 t/RecordProcessor.t
Don't modify $_ in list functions at line 43, column 25.  See page 114 of PBP. 
(Severity: 5)

$ perlcritic -2 t/RecordProcessor.t
No package-scoped "$VERSION" variable found at line 1, column 1.  See page 404
of PBP.  (Severity: 2)
Quotes used with a string containing no non-whitespace characters at line 34,
column 36.  See page 53 of PBP.  (Severity: 2)
Quotes used with a string containing no non-whitespace characters at line 34,
column 39.  See page 53 of PBP.  (Severity: 2)
Quotes used with a string containing no non-whitespace characters at line 36,
column 33.  See page 53 of PBP.  (Severity: 2)
Quotes used with a string containing no non-whitespace characters at line 36,
column 36.  See page 53 of PBP.  (Severity: 2)
Don't modify $_ in list functions at line 43, column 25.  See page 114 of PBP. 
(Severity: 5)
Regular expression without "/s" flag at line 43, column 33.  See pages 240,241
of PBP.  (Severity: 2)
Regular expression without "/x" flag at line 43, column 33.  See page 236 of
PBP.  (Severity: 3)
Regular expression without "/m" flag at line 43, column 33.  See page 237 of
PBP.  (Severity: 2)
Regular expression without "/s" flag at line 43, column 66.  See pages 240,241
of PBP.  (Severity: 2)
Regular expression without "/x" flag at line 43, column 66.  See page 236 of
PBP.  (Severity: 3)
Regular expression without "/m" flag at line 43, column 66.  See page 237 of
PBP.  (Severity: 2)
Expression form of "grep" at line 47, column 8.  See page 169 of PBP. 
(Severity: 4)
Expression form of "grep" at line 50, column 20.  See page 169 of PBP. 
(Severity: 4)
Regular expression without "/s" flag at line 50, column 26.  See pages 240,241
of PBP.  (Severity: 2)
Regular expression without "/m" flag at line 50, column 26.  See page 237 of
PBP.  (Severity: 2)
Return value of eval not tested at line 73, column 1.  You can't depend upon
the value of $@/$EVAL_ERROR to tell whether an eval failed.  (Severity: 3)
Magic punctuation variable $@ used at line 78, column 5.  See page 79 of PBP. 
(Severity: 2)
Reused variable name in lexical scope: $processor at line 84, column 5.  Invent
unique variable names.  (Severity: 3)
Subroutine "new" called using indirect syntax at line 87, column 18.  See page
349 of PBP.  (Severity: 4)
Subroutine "new" called using indirect syntax at line 93, column 18.  See page
349 of PBP.  (Severity: 4)
Quotes used with a string containing no non-whitespace characters at line 96,
column 40.  See page 53 of PBP.  (Severity: 2)
Subroutine "new" called using indirect syntax at line 99, column 18.  See page
349 of PBP.  (Severity: 4)
Subroutine "new" called using indirect syntax at line 106, column 18.  See page
349 of PBP.  (Severity: 4)
$ prove -v t/RecordProcessor.t
t/RecordProcessor.t .. ok
All tests successful.
Files=1, Tests=13,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.22 cusr  0.02
csys =  0.25 CPU)
Result: PASS

$ prove -v t/RecordProcessor.t
...
$ git bz apply 15871

Repeat perlcritic level 2, and only $VERSION warning should exist.
Retest with the prove.
Run koha qa test tools.

Signed-off-by: Hector Castro 
Works as advertised

Signed-off-by: Jesse Maseto 
Signed-off-by: Tomas Cohen Arazi 
I don't really care about perlcritic as long as it involves changing '' into
qw{} (WTF?)
Anyway, I'd do this kind of things as we go, for example, if we were adding
more tests. In that
case it would just be a followup for this, after you provided a patch for an
enh/bugfix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/

[Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15963] Use Font Awesome icons for confirmation after deleting MARC tag

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15963

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||hector.hecax...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15963] Use Font Awesome icons for confirmation after deleting MARC tag

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15963

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #48560|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 48630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48630=edit
[SIGNED-OFF]Bug 15963: Use Font Awesome icons for confirmation after deleting
MARC tag

This patch revises the dialog which appears after you have deleted a
MARC tag.

To test, apply the patch and go to Administration -> MARC frameworks ->
MARC sturcture -> Delete.

- Confirm that you want to delete a MARC tag.
- Verify that the confirmation dialog you are shown is styled correctly.
- Verify that clicking "OK" redirects you to the right place.

Signed-off-by: Hector Castro 
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #6 from Tomás Cohen Arazi  ---
This bug was lacking functionality tests. As it is in my best interest to have
this moving, I've gone through the process of writing unit tests for this piece
of code.

Things that weren't tested:
- opac vs. intranet (interface option)
- test all the possible values.
- control fields and datafields traverse different code branches, and needed to
be tested.

The tests I wrote cover most of what is needed. Please read the TODO in the
commit message.

The tests fail.

Mark: you need to get rid of the clone. The RecordProcessor pipeline is
designed so it works on the original object. Doing so will make several tests
pass:

foreach my $current_record (@records) {
-my $result= $current_record->clone();
+my $result= $current_record;


There are still problems. Hopefully problems in the tests. I couldn't spend
more time on this.

Also, there is a weird construct you should get rid off, so you simplify the
code and make it more readable:

+else {
+# visibility is a "level" (-7 to +7), default to 0
+my $visibility = $marcsubfieldstructure->{$tag}->{q{@}}->{hidden};
+$visibility //= 0;
+my $hidden;
+if ( $display->{$interface}->{$visibility} ) {
+$hidden = 0;
+}
+else {
+$hidden = 1;
+$result->delete_fields($field);
+}
+}

could be just:

+else {
+# visibility is a "level" (-7 to +7), default to 0
+my $visibility = $marcsubfieldstructure->{$tag}->{q{@}}->{hidden};
+$visibility //= 0;
+if ( ! $display->{$interface}->{$visibility} ) {
+$result->delete_fields($field);
+}
+}

Looking forward to your comments and/or followups. Count on me to have this
done ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #36 from Blou  ---
The last patch introduced 'filesaccess', but didn't replace all 'publicdir'
reference.  I squashed the last three patches because I did not see the value
of having a patch that changed to publicdir signed off followed by a patch to
move it to accessdir then another patch to fix it...  This feature does not
warrant that many patches in Koha's history.

An historian...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Blou  changed:

   What|Removed |Added

  Attachment #39785|0   |1
is obsolete||
  Attachment #39786|0   |1
is obsolete||
  Attachment #44860|0   |1
is obsolete||

--- Comment #35 from Blou  ---
Created attachment 48629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48629=edit
Bug 11317 - Rename config to 'accessdir' and fix qa

Also translate date with datetime format preference and move to Tools.

Test preparation :
* Add the "accessdir" preference to your "koha-conf.xml" file. This
* preference should be in the "config" section. For this test cas, we
* will use the "/tmp/files-access" directory :

 ...
  /tmp/files-access
 ...

* Create the log directory on your server. Make sure this directory
* is readable by your web server :
$ mkdir /tmp/files-access
* Add a test file in the log directory :
$ cd /tmp/files-access
$ echo "Hello world!" > test.txt

Test :
* Go in the "tools/Additional tools" section in the intranet and select
"Report/log
* files"
* The "test.txt" should appear in the files list.
* Click on the "test.txt" file, a download dialog should appear.
* Download the file and verify its content. It should contain the
* text "Hello world!".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 48628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48628=edit
Bug 15870: (QA followup) Add tests

This patch introduces functionality tests for the new Koha::Filter.
It iterates over all the possible 'hidden' values defined in the docs
for hiding/showing fields and subfields, and checks the filter does the job.

It tests the functionality for both opac and intranet interfaces and tries
to catch all scenarios. It adds control fields to the sample record (they
traverse a different branch in the code).

TODO: Add another subfield to 245, set it to be hidden, and make sure 245 $a is
still
shown.

The original tests file has been renamed conveniently.

To test:
- Run
  $ prove t/db_dependent/Filter_MARC_ViewPolicy.t

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11998] Syspref caching issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |ASSIGNED
   Assignee|ro...@catalyst.net.nz   |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15937] Batch checkout buggy behavior

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15937

--- Comment #4 from Héctor Eduardo Castro Avalos  ---
(In reply to Jonathan Druart from comment #3)

Hi Jonathan

> > And again Koha let to checkout the first item without await for
> > confirmation, i.e., the expected behavior is: 1) enter the barcodes 2) show
> > table with checkboxes in titles, no checkout yet at this point, but program
> > checkout the first item in the table 3) Confirm checkout 4) The table with
> > all items checked out is presented.

Sometimes librarians make mistakes and enter an incorrect patron, if she or he
realizes that has made a mistake, she/he can change the patron at this point
without check out any item in the list.

> This is not as trivial as it seems :)

Yes, it could be.


Regards

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15970] Plack should not clear syspref cache

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

--- Comment #1 from Jacek Ablewicz  ---
(In reply to Jonathan Druart from comment #0)
> Just played with nytprof and found something exciting:
> 
> If I remove the following line:
>   C4::Context->clear_syspref_cache();
> from the psgi file, the processing time is divided per 2 (!)
> 
> With the clear cache:
> for 15.8s (of 18.6s), executing 2588556 statements and 903720 subroutine
> calls in 421 source files and 63 string evals.
> 
> Without the clear cache:
> for 7.82s (of 8.69s), executing 904432 statements and 262539 subroutine
> calls in 421 source files and 63 string evals.

Such a difference looks kind of weird - unless the script you are testing calls
(for whatever reasons) CGI->new() repeatedly ?

BTW, how many times was C4::Context::preference() called in that test?

> Am I missing something?

With that line removed, each time when you change some syspref value, you'll
need to restart starman server/workers manually for that change to take effect.
However, clearing syspref cache inside CGI->new() override sub is probably not
100% flawless method anyway, so serwer restarts are still needed if one wants
to be on the safe side ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #48624|0   |1
is obsolete||

--- Comment #140 from Nicole C. Engard  ---
Created attachment 48626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48626=edit
[SIGNED-OFF] [SIGNED-OFF] Bug 7736 Add Edifact order fields to Acquisition.t

Modification in Acquisition.t to support in test the new fields
of the table aqorders:
line_item_id, suppliers_reference_number,
suppliers_reference_qualifier, suppliers_report

Original patch by Zeno Tajoli
I amended to include the report field (ColinC)

Signed-off-by: Paul Johnson 

Signed-off-by: Sally Healey 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

--- Comment #141 from Nicole C. Engard  ---
Sally and Paul, I put your sign offs on these patches. Thanks for the update!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #48623|0   |1
is obsolete||

--- Comment #139 from Nicole C. Engard  ---
Created attachment 48625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48625=edit
[SIGNED-OFF] [SIGNED-OFF] Bug 7736: Support Ordering via Edifact EDI messages

Add support for processing incoming Edifact Quotes, Invoices
and order responses and generating and transmission of
Edifact Orders.
Basic workflow is that an incoming quote generates an aquisition
basket in Koha, with each line corresponding to an order record

The user can then generate an edifact order from this (or another)
basket, which is transferred to the vendor's site

The supplier generates an invoice on despatch and this will
result in corresponding invoices being generated in Koha
The orderlines on the invoice are receipted automatically.

We also support order response messages. This may include
simple order acknowledgements, supplier reports/amendments
on availability. Cancellation messages cause the koha order
to be cancelled, other messages are recorded against the order

Which messages are to be supported/processed is specifiable on a
vendor by vendor basis via the admin screens

You can also specify auto order i.e. to generate orders from quotes
without user intervention - This reflects existing
workflows where most work is done on the suppliers website
then generating a dummy quote

Received messages are stored in the edifact_messages table
and the original can be viewed via the online

Database changes are in installer/data/mysql/atomicchanges/edifact.sql
Note new perl dependencies:
Net::SFTP:Foreign
Text::Unidecode

Signed-off-by: Paul Johnson 

Signed-off-by: Sally Healey 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/