[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--- Comment #5 from Nick Clemens ---
/home/vagrant/kohaclone/.git/rebase-apply/patch:432: trailing whitespace.
my @biblionumbers = ref($query->param('biblionumbers')) eq 'Array'
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #52 from Héctor Eduardo Castro Avalos --- Rémi just another issue, when exporting there are problem with utf-8: branchname dateaccounttype amount title barcode itype Midway 2016-01-25T00:00:00 Rent5 A lot like love / 2015-0004 Midway 2016-01-28T00:00:00 Rent5 AntologÃa de entremeses del Siglo de Oro / 2016-0001 But I think IMHO this could be treated in another bug. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|In Discussion |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #48634|0 |1 is obsolete|| --- Comment #49 from Héctor Eduardo Castro Avalos --- Created attachment 48706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48706&action=edit [SIGNED-OFF]Bug 6934: QA Follow-up Tried to address every single thing that QA mentioned : 1)Removed isNull function 2)Changed datepicker properly 3)We have to fill in two dates not to be flooded with old entries if we don't want to. 4)The first two fieldsets are now in one bigger field set 5)Removed the use of $fullreportname variable 6)Removed the use of dt_from_string when it already recieved a DT. 7)Removed comments starting with "###" in cash_register_stats.pl 8)Used Text::CSV::Encoded to generate the CSV file (used guided_reports.pl as an example) 9)I am not sure if using C4::Reports::Guided is the right choice here. I instead used the same column names as the one recieved by the query in cash_register_stats because this report uses columns from 5 different tables in addition of using both firstname and surname twice. For the ninth point, I would like to know more about C4::Reports::Guided if you still think using it would be a better solution. Thank you! Signed-off-by: Hector Castro -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #48705|0 |1 is obsolete|| --- Comment #51 from Héctor Eduardo Castro Avalos --- Created attachment 48708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48708&action=edit [SIGNED-OFF]Bug 6934: second fix to calendars Signed-off-by: Hector Castro -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #48704|0 |1 is obsolete|| --- Comment #50 from Héctor Eduardo Castro Avalos --- Created attachment 48707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48707&action=edit [SIGNED-OFF]Bug 6934 Fixed Calendar and removed used of unexisting and unused C4::Budgets getCurrency Signed-off-by: Hector Castro -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #48 from Rémi Mayrand-Provencher --- Really sorry, it was my mistake, I should have tested it again just before sending my patch. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #47 from Rémi Mayrand-Provencher --- Created attachment 48705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48705&action=edit bug 6934 - second fix to calendars -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #46 from Héctor Eduardo Castro Avalos --- (In reply to Rémi Mayrand-Provencher from comment #45) > This bug should be ready to be signed-off now, thank you for noticing that > the calendar weren't functionning as they should have. I Fixed that now. Sorry Rémi but doesn't work The message presented is: Form not submitted because of the following problem(s) --- - Dates cannot be empty Probably about this bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
koha-bugs@lists.koha-community.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 Bug ID: 15987 Summary: Acq module fails with undefined subroutine &main::GetCurrency Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jonathan.dru...@bugs.koha-community.org Reporter: hector.hecax...@gmail.com QA Contact: testo...@bugs.koha-community.org Depends on: 15084 Acq module fails with undefined subroutine &main::GetCurrency Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Héctor Eduardo Castro Avalos changed: What|Removed |Added Blocks||15987 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 [Bug 15987] Acq module fails with undefined subroutine &main::GetCurrency -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Nick Clemens changed: What|Removed |Added CC||nic...@bywatersolutions.com ||, rhilli...@hotchkiss.org Assignee|gmcha...@gmail.com |n...@bywatersolutions.com Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15986] New: Add a script for sending hold waiting reminder notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Bug ID: 15986 Summary: Add a script for sending hold waiting reminder notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcha...@gmail.com Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Write a script that will take two parameters: a) Length of time hold has been waiting ( in days ) b) Letter code of notice to be emailed 2) Script will take these two parameters and send the specified notice for each hold a patron has. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14747] RESTful API with reverse proxy configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14747 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers test fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14746] Set up logging and configuration file reading for Mojolicious
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14746 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #45 from Rémi Mayrand-Provencher --- This bug should be ready to be signed-off now, thank you for noticing that the calendar weren't functionning as they should have. I Fixed that now. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8994] Make FindDuplicateAuthority behaviour customizable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8994 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Needs Signoff |Patch doesn't apply --- Comment #10 from Chris Cormack --- CONFLICT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #44 from Rémi Mayrand-Provencher --- Created attachment 48704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48704&action=edit Bug 6934 Fixed Calendar and removed used of unexisting and unused C4::Budgets getCurrency -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870
--- Comment #8 from M. Tompsett ---
(In reply to Tomás Cohen Arazi from comment #6)
> Mark: you need to get rid of the clone. The RecordProcessor pipeline is
> designed so it works on the original object.
I'm torn on that.
SNIP
sub process {
my $self = shift;
my $record = shift || $self->record;
return unless defined $record;
my $newrecord = $record;
foreach my $filterobj (@{$self->filters}) {
next unless $filterobj;
$newrecord = $filterobj->filter($newrecord);
}
return $newrecord;
}
SNIP
The clincher for me is that the $filterobj->filter call returns something. What
is the point of returning something if we are modifying the original object?
The return $newrecord is still necessary because of pre-call binding or passing
the record(s) directly. However, the "$newrecord =" makes no sense if the
original was not intended to stay intact, because it would have already been
modified!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15985] New: Include transacting library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Bug ID: 15985 Summary: Include transacting library in fines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Work to be done: 1) Add column issue_id to accountlines table 2) Modify fines generation to set issue_id for fine upon generation 3) Modify updatedatabase.pl to insert issue_id in accountlines for currently accruing fines 4) On the pay fines page, use this data to display the library where the item was checked out from -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13927] Add API route to check hold capabilities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13927 Chris Cormack changed: What|Removed |Added Attachment #37365|0 |1 is patch|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #51 from Kyle M Hall --- Created attachment 48703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48703&action=edit Bug 15084 [QA Followup] - Update Schema files Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13927] Add API route to check hold capabilities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13927 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Attachment #37365|1 |0 is patch|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Automatic item modification by age (Was "Toggle new status for items")
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #107 from Kyle M Hall --- I just had a thought about this. I think the db column 'new' is going to never be accessible via Koha::Item. I think a followup will be needed to change the column from 'new' to maybe 'new_status'? Any other column name suggestions would be appreciated! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15941] The template for cloning circulation and fine rules says "issuing rules"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15941 Owen Leonard changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15984 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15984] New: Correct templates which use the phrase "issuing rules"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15984 Bug ID: 15984 Summary: Correct templates which use the phrase "issuing rules" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: jonathan.dru...@bugs.koha-community.org, testo...@bugs.koha-community.org Two more templates uses the old "issuing rules" phrase. They should be updated to say "circulation and fine rules." help/admin/smart-rules.tt help/tools/automatic_item_modification_by_age.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15983] Use Font Awesome icons in serial numbering pattern deletion confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 --- Comment #1 from Owen Leonard --- Created attachment 48702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48702&action=edit Bug 15983 - Use Font Awesome icons in serial numbering pattern deletion confirmation dialog If you try to delete a serial numbering pattern which is in use by an existing subscription you will be shown a confirmation dialog. This dialog should use Font Awesome icons. Other minor changes: - Added "action" attributes to s to fix validation errors. - Added "alert" class to confirmation dialogs so that they correctly styled. To test, apply the patch and go to Serials -> Numbering patterns. - Click "Delete" on a numbering pattern which is in use by a subscription. - Verify that the confirmation dialog is styled correctly. - Test that the "No, do not delete" button works correctly. - Test that the "Yes, delete" button deletes the correct numbering pattern. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15983] Use Font Awesome icons in serial numbering pattern deletion confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard changed: What|Removed |Added Blocks||15980 Blocks||15983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15980 [Bug 15980] Use Font Awesome icons in subscription frequency deletion confirmation dialog https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 [Bug 15983] Use Font Awesome icons in serial numbering pattern deletion confirmation dialog -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15983] New: Use Font Awesome icons in serial numbering pattern deletion confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 Bug ID: 15983 Summary: Use Font Awesome icons in serial numbering pattern deletion confirmation dialog Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-numberpatterns.pl?o p=del&id=X OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 15785 If you try to delete a serials numbering pattern which is in use by an existing subscription you are presented with a confirmation dialog. This dialog should use Font Awesome icons. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15982] Serials numbering patterns can be deleted without warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15982 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15982] Serials numbering patterns can be deleted without warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15982 --- Comment #1 from Owen Leonard --- Created attachment 48701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48701&action=edit Bug 15982 - Serials numbering patterns can be deleted without warning A JavaScript alert should ask the user to confirm deletion of a serial numbering pattern. This patch adds this to the template. To test, apply the patch and go to Serials -> Manage numbering patterns. - In the list of patterns, click any "Delete" link. - Verify that a JavaScript alert is triggered. - Test that cancelling the alert cancels the deletion operation. - Test that confirming the alert allows the deletion to complete. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15955] Tuning function 'New child record' for Unimarc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 Frédéric Demians changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15955] Tuning function 'New child record' for Unimarc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 Frédéric Demians changed: What|Removed |Added Attachment #48692|0 |1 is obsolete|| Attachment #48693|0 |1 is obsolete|| --- Comment #9 from Frédéric Demians --- Created attachment 48700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48700&action=edit Tuning function 'New child record' for Unimarc 205$a -> 461$e Now the sYstem tries to insert value of 205$a into 461$a when a child is created from the father record. In UNIMARC 46x tags there is not present a subfield for ediction value (205$a in UNIMARC). To Test: 1) Check to have EasyAnalyticalRecords on 'off' 2) Check to use UNIMARC 3) Create a record with data in 200$a (title), 205$a (ediction), 700 (author) 215$a(Place), 215$d(date) 4) From those record create a child using 'New'->'New child record' 5) See the values in 461 tag: You can see that in 461$a there is the value of 205$a from father This is wrong, you need to have the value of 700 $a and $b from father record, and 205$a in 461$e. 6) Appy the patch 7) Redo 4-5 8) Now 461 is good Signed-off-by: Frédéric Demians -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15981] Serials frequencies can be deleted without warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 --- Comment #1 from Owen Leonard --- Created attachment 48699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48699&action=edit Bug 15981 - Serials frequencies can be deleted without warning A JavaScript alert should ask the user to confirm deletion of a serial frequency. This patch adds this to the template. To test, apply the patch and go to Serials -> Manage frequencies - In the list of frequencies, click any "Delete" link. - Verify that a JavaScript alert is triggered. - Test that cancelling the alert cancels the deletion operation. - Test that confirming the alert allows the deletion to complete. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15982] New: Serials numbering patterns can be deleted without warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15982 Bug ID: 15982 Summary: Serials numbering patterns can be deleted without warning Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-numberpatterns.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Serials Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com, testo...@bugs.koha-community.org When the user tries to delete a serials numbering pattern there should be a JavaScript alert asking for confirmation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15981] Serials frequencies can be deleted without warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15291] Can't import item data in acquisition from a stage file with modification templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15291 J Schmidt changed: What|Removed |Added CC||jschm...@switchinc.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15981] New: Serials frequencies can be deleted without warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Bug ID: 15981 Summary: Serials frequencies can be deleted without warning Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-frequencies.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Serials Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com There is some code in the serials frequencies template for triggering a JavaScript alert to confirm deletion of a frequency, but it is incomplete. You only get a warning about deleting a frequency which is in use by an existing subscription. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #50 from Marcel de Rooy --- Are we still missing some things here? I see some problems related to aqorder and currency when running TestBuilder.t Looking further, I also saw a foreign key for currency in aqorders that does not appear in kohastructure (although that is not the solution yet). Also we need some DBIx updates for Koha/Schema/Result; is that a RM action? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15979] Use Font Awesome icons subscription deletion confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 --- Comment #1 from Owen Leonard --- Created attachment 48697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48697&action=edit Bug 15979 - Use Font Awesome icons subscription deletion confirmation dialog When deleting a subscription which has not expired or which has linked issues or items, a dialog asks for confirmation. This patch updates the dialog to use Font Awesome icons. Other minor change: Corrected capitalization in dialog heading. To test, apply the patch and go to Serials. - Locate a subscription which can be deleted and which has not expired, has linked items, or has linked issues. - View the detail page for that subscription. - Choose "Delete subscription" from the "Edit" menu. - Verify that the confirmation dialog is correctly styled. - Verify that the "No, don't delete" button works correctly. - Verify that the "Yes, delete" button deletes the subscription. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15979] Use Font Awesome icons subscription deletion confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard changed: What|Removed |Added Blocks||15979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 [Bug 15979] Use Font Awesome icons subscription deletion confirmation dialog -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15979] New: Use Font Awesome icons subscription deletion confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Bug ID: 15979 Summary: Use Font Awesome icons subscription deletion confirmation dialog Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-detail.pl?subscript ionid=X&op=del OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 15785 If you try to delete a subscription which has not expired or which has linked issues or items you are presented with a confirmation dialog. This dialog should use Font Awesome icons. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15978] Use Font Awesome icons for guided reports error dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 Owen Leonard changed: What|Removed |Added URL|/cgi-bin/koha/admin/marctag |/cgi-bin/koha/reports/guide |structure.pl|d_reports.pl?phase=Create ||report from SQL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15436] Use semicolon between series name and volumne information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15436] Use semicolon between series name and volumne information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 --- Comment #7 from Nicole C. Engard --- Created attachment 48696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48696&action=edit no difference in staff And there is no difference in the staff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15436] Use semicolon between series name and volumne information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Nicole C. Engard changed: What|Removed |Added CC||neng...@gmail.com --- Comment #6 from Nicole C. Engard --- Created attachment 48695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48695&action=edit opac broken After applying this patch the OPAC display is completely broken. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Nicole C. Engard changed: What|Removed |Added CC||neng...@gmail.com Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Nicole C. Engard changed: What|Removed |Added Attachment #48497|0 |1 is obsolete|| --- Comment #3 from Nicole C. Engard --- Created attachment 48694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48694&action=edit Bug 15832 - Fix items split-up in pendingreserves.tt Test plna: - Go to circ/pendingreserves.pl (Ensure that there are biblios with many items on different branches), -check the libraries filter at the bottom of datatable. There should be duplicates. - Apply this patch and return to circ/pendingreserves.pl, - libraries filter should not contain duplicate. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard --- A minor problem: FAIL C4/Circulation.pm OK critic FAIL forbidden patterns forbidden pattern: Data::Dumper::Dumper (line 1870) forbidden pattern: Data::Dumper::Dumper (line 1872) I think this text could be improved: " Item location updated from CART (Not an authorized value) to Fiction shelf " I think that should be "Item shelving location" (since "location" could be confused with "library"). I think the text "Not an authorized value" is not helpful to the user and is potentially scary. Think "UNAUTHOIRZED VALUE!!" I still have an issue with the data-entry aspect of this feature. In testing, I was stopped right away by having not put a space after the colon: 'FIC: CART' works 'FIC:CART' fails silently I don't think it's reasonable to expect the user to know this. For that matter, I don't think it's reasonable to expect the user to know the code for all existing shelving location authorized values. I realize this is an administrative setting, but I think we can do better. At minimum we need: - Text describing explicitly the correct format. - Some way to warn the user if their entry is incorrect. - Text explaining that an "_ALL_" rule overrides all others, or better: - Some way to warn the user if they have set an "_ALL_" rule along with other rules Overall this new patch is a great improvement over the last. But I still think we can do better. I think a separate template is needed, although I wouldn't fail the patch for that unless there was some consensus. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15955] Tuning function 'New child record' for Unimarc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 --- Comment #8 from Zeno Tajoli --- Hi Frédéric , I have written a follow-up of the patch. Now data from 205$a (of father) will go into 461$e (of child). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15955] Tuning function 'New child record' for Unimarc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 Zeno Tajoli changed: What|Removed |Added Attachment #48543|0 |1 is obsolete|| --- Comment #6 from Zeno Tajoli --- Created attachment 48692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48692&action=edit Patch for Unimarc format -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15955] Tuning function 'New child record' for Unimarc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 --- Comment #7 from Zeno Tajoli --- Created attachment 48693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48693&action=edit Followup of the patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15978] Use Font Awesome icons for guided reports error dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #48689|0 |1 is obsolete|| --- Comment #2 from Héctor Eduardo Castro Avalos --- Created attachment 48691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48691&action=edit [SIGNED-OFF]Bug 15978: Use Font Awesome icons for guided reports error dialog If you try to save an SQL report with an invalid authorized value placeholder you will be presented with a confirmation dialog. This patch updates it to use Font Awesome icons. Also fixed: Validation error found in testing: Duplicated tag and series of redundant inputs. Each input cut had an exact duplicate in the same form. To test, apply the patch and go to Reports -> Create from SQL. - Create a new SQL report and fill in as many fields as possible to verify correct operation. - Try to save your report with an invalid authorized value placeholder, for example: SELECT * FROM items WHERE items.itype = <> - Confirm that the confirmation dialog is styled correctly. - Test the operation of the "Edit SQL" button. You should be sent back a page. - Test the operation of the "Save anyway" button and confirm that your report was saved. - Repeat these steps when editing an existing report. Signed-off-by: Hector Castro Works as described -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15978] Use Font Awesome icons for guided reports error dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||hector.hecax...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998
--- Comment #111 from Kyle M Hall ---
This must be a caching issue. If I simply make this change:
ok( exists($queue_item->{itype}), 'item type included in queued items list (bug
5825)' );
+warn "TEST: " . C4::Context->preference("StaticHoldsQueueWeight");
The tests begin to fail on master! I think the only reasonable solution is to
mock the actual expected value for the time being and write a replacement for
HoldsQueue.t from the ground up in time.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #110 from Kyle M Hall --- At some point in the tests, StaticHoldsQueueWeight becomes zero for reasons unknown and the unit tests rely on this bug! t/db_dependent/HoldsQueue.t .. 1..26 ok 1 - use C4::Reserves; ok 2 - use C4::HoldsQueue; 1 SET StaticHoldsQueueWeight: IggZam,xND8TnZydP,lfyZhGooM9 at t/db_dependent/HoldsQueue.t line 74. StaticHoldsQueueWeight: IggZam,xND8TnZydP,lfyZhGooM9 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 3 - take from homebranch (don't use cost matrix) pick up branch ok 4 - take from homebranch (don't use cost matrix) holding branch ok 5 - take from homebranch (use cost matrix) pick up branch ok 6 - take from homebranch (use cost matrix) holding branch StaticHoldsQueueWeight: IggZam,xND8TnZydP,lfyZhGooM9 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 7 - take from holdingbranch (don't use cost matrix) pick up branch ok 8 - take from holdingbranch (don't use cost matrix) holding branch ok 9 - take from holdingbranch (use cost matrix) pick up branch ok 10 - take from holdingbranch (use cost matrix) holding branch StaticHoldsQueueWeight: IggZam,xND8TnZydP,lfyZhGooM9 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 11 - take from lowest cost branch (don't use cost matrix) pick up branch ok 12 - take from lowest cost branch (don't use cost matrix) holding branch ok 13 - take from lowest cost branch (use cost matrix) pick up branch ok 14 - take from lowest cost branch (use cost matrix) holding branch ok 15 - GetHoldsQueueItems ok 16 - item type included in queued items list (bug 5825) ok 17 - C4::HoldsQueue::least_cost_branch returns the local branch if it is in the list of branches to pull from StaticHoldsQueueWeight: 0 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 18 - Holds queue filling correct number for default holds policy 'from home library' ok 19 - Holds queue filling 1st correct hold for default holds policy 'from home library' ok 20 - Holds queue filling 2nd correct hold for default holds policy 'from home library' ok 21 - Is today a holiday for pickup branch StaticHoldsQueueWeight: 0 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 22 - Holds not filled with items from closed libraries StaticHoldsQueueWeight: 0 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 23 - Holds queue filling correct number for holds for default holds policy 'from any library' StaticHoldsQueueWeight: 0 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 24 - Holds not filled with items from closed libraries 2 SET StaticHoldsQueueWeight: wVjTn,QwXVJjV,IhgDeror at t/db_dependent/HoldsQueue.t line 395. StaticHoldsQueueWeight: 0 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 25 - Bug 14297 - Holds Queue building ignoring holds where pickup & home branch don't match and item is not from le ok 26 - Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #31 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #30) > Signed-off-by: Katrin Fischer Great. Thx -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #43 from Héctor Eduardo Castro Avalos --- Hi Rémi About my comment 40, i don't know if is that the behavior expected, or, needs to be corrected? Is the patch ready to sign-off? If yes, I'll sign-off immediately. Regards -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Owen Leonard changed: What|Removed |Added Attachment #48584|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 48690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48690&action=edit [PASSED QA] Bug 15961 - Use Font Awesome icons for confirmation of currency deletion When deleting a currency, the confirmation and error dialogs should use Font Awesome icons. This patch makes this change. To test, apply the patch and go to Administration -> Currencies and exchange rates. - Click the "delete" link next to any currency. - Verify that the confirmation dialog is correctly styled. - Test the both cancel and confirm operations. - Verify that the deletion confirmation dialog is correctly styled. Bug 15962 prevents testing the error dialog which should appear if you try to delete a currency which is use (defined as a currency in a vendor record). To test this error you could manually enter a currency code into aqbooksellers.currency and then try to delete that currency. Signed-off-by: Nicole C Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15970] Plack should not clear syspref cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 --- Comment #5 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #4) > (In reply to Jonathan Druart from comment #3) > > Created attachment 48641 [details] [review] [review] > > Bug 15970: Do not clear syspref cache in psgi file > > > > This in only in koha.psgi, it has been introduced by bug 13815 but > > should not have been added by this patch. > > > > Removing it should not introduce any changes. > > Not that it won't impact debian packages. > > Yeah. No one cares about misc/plack/koha.psgi. Why not patching > debian/templates/plack.psgi instead? I do :) Because it does not disable the syspref cache, contrary to my earlier belief. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15978] Use Font Awesome icons for guided reports error dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 --- Comment #1 from Owen Leonard --- Created attachment 48689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48689&action=edit Bug 15978 - Use Font Awesome icons for guided reports error dialog If you try to save an SQL report with an invalid authorized value placeholder you will be presented with a confirmation dialog. This patch updates it to use Font Awesome icons. Also fixed: Validation error found in testing: Duplicated tag and series of redundant inputs. Each input cut had an exact duplicate in the same form. To test, apply the patch and go to Reports -> Create from SQL. - Create a new SQL report and fill in as many fields as possible to verify correct operation. - Try to save your report with an invalid authorized value placeholder, for example: SELECT * FROM items WHERE items.itype = <> - Confirm that the confirmation dialog is styled correctly. - Test the operation of the "Edit SQL" button. You should be sent back a page. - Test the operation of the "Save anyway" button and confirm that your report was saved. - Repeat these steps when editing an existing report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15978] Use Font Awesome icons for guided reports error dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 --- Comment #7 from Nick Clemens --- (In reply to Jonathan Druart from comment #6) > (In reply to Heather Braum from comment #5) > > > > Nick has temporarily patched these three instances > How? Nick, where is the patch? :) It is a quick patch to force contains on the affected pages, I don't think you like that solution :-) > 2/ add a pref to default on contains or start_with This is the best option I think so far > I like none of these solutions. Anything else to suggest? I think adding an options for phrase searching with qutoes would restore old and allow new behaviour as well. Terms could be split if not qutoed and used as now if quoted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #109 from Jonathan Druart --- (In reply to Jonathan Druart from comment #108) > (In reply to Jonathan Druart from comment #105) > > Created attachment 48687 [details] [review] [review] > > Bug 11998: Use t::lib::Mocks::mock_preference in tests > > > > Unless in t/db_dependent/Context.t where we want to test the cache > > behaviors. > > Note that tests in t/db_dependent/HoldsQueue.t do not pass, but I have no > idea why! If you use this file (modified by this patch) and prove it on top of master, they don't pass neither. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #108 from Jonathan Druart --- (In reply to Jonathan Druart from comment #105) > Created attachment 48687 [details] [review] > Bug 11998: Use t::lib::Mocks::mock_preference in tests > > Unless in t/db_dependent/Context.t where we want to test the cache > behaviors. Note that tests in t/db_dependent/HoldsQueue.t do not pass, but I have no idea why! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #107 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #104) > - bunch of t/* tests (quite o lot of them) is still using ->set_preference() > insted of mock_preference() - they don't commit changes to the database, but > running them may now result in syspref "cache poisoning", affecting > behaviour of the other processes Yes, that is addressed in the last 2 patches. > - remaining code chunks which are dealing with systempreferences table > directly (installer, updatedatabase.pl, some tests and admin/maintenance > scripts); updatedatabase.pl seems to be OK (at least at the 1st glance), not > sure about installer - it does call clear_syspref_cache() 1+ time, but not > necessarily everywhere where it should do it / not at the each and every > step (?) Yes, we should replace them, and avoid to update/insert sysprefs during the update DB process. > - up to now, when a given script retrieved some preference once, it was > guaranted that all subsequent ->preference() calls during the script run > will return the same value; now it will always use the current value instead > - I guess sometimes that will be a good thing, and sometimes not so much - > but probably not very important in practical circumstances Theoretically it could be an issue but, as you said, I don't think it could be a problem in practice. > Also there will be some (hopefully very) little performace hit due to > caching system overheads (and 10 sec deafult expire in case of Cache::Memory > - but it will affect only the long-running scripts) - how little, it remains > to be seen ;) In conjunction with other patches (depending on this bug report), I am expecting a gain. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #105 from Jonathan Druart --- Created attachment 48687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48687&action=edit Bug 11998: Use t::lib::Mocks::mock_preference in tests Unless in t/db_dependent/Context.t where we want to test the cache behaviors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #106 from Jonathan Druart --- Created attachment 48688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48688&action=edit Bug 11998: Use C4::Context->preference in Koha/Schema/Result/Item.pm Otherwise some tests won't pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15976] test bug for a script we are developping.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15976 --- Comment #3 from Rémi Mayrand-Provencher --- Created attachment 48686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48686&action=edit bug test CONFLICT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15976] test bug for a script we are developping.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15976 --- Comment #2 from Rémi Mayrand-Provencher --- Created attachment 48685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48685&action=edit bug test preparation for conflict -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer changed: What|Removed |Added Attachment #46251|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer changed: What|Removed |Added Attachment #46254|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer changed: What|Removed |Added Attachment #46252|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer changed: What|Removed |Added Attachment #46253|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #27 from Katrin Fischer --- Created attachment 48681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48681&action=edit [PASSED QA] Bug 14306: Show URL from MARC21 field 555$u under Title Notes/Descriptions This patch includes: [1] Add some logic to GetMarcNotes to embed the contents of MARC21 field 555$u in a html anchor tag. [2] Add a unit test for GetMarcNotes in Biblio.t [3] Remove calls to GetMarcNotes from sendbasket.pl (opac and staff). A closer look revealed that the data was not used; the notes in the mail of sendbasket are taken from GetBiblioData. Test plan: [1] Edit a record. Add one or two URLS in 555$u. Add something in 500$a too. [2] Check if you can click the URLs in opac and staff detail tab Notes or Descriptions. [3] Run the unit test t/db../Biblio.t [4] Add something in the cart. Click More Details and send the cart. Verify that you have something in Notes (from 500$a). Signed-off-by: Marc Veron Followed test plan. Works as expected. QA tools OK. Tested with all patches together, works as expected Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #28 from Katrin Fischer --- Created attachment 48682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48682&action=edit [PASSED QA] Bug 14306: Follow-up for URLs in 555$u This patch removes the code for inserting the anchor tags around URLs in GetMarcNotes (as added originally). The URLs are placed in separate array elements; the template should take care of further handling. The unit test has been adjusted accordingly. Test plan: Run the unit test. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #30 from Katrin Fischer --- Created attachment 48684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48684&action=edit [PASSED QA] Bug 14306: Remove call to GetMarcNotes from sendshelf Just as mentioned in the first patch for sendbasket, I discovered that the call of GetMarcNotes is not really used in sendshelf. The array is passed to the template, but the template does not use it. (It uses the information from GetBiblioData.) Test plan: [1] Send a list that includes a record with some notes (opac and staff). Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #29 from Katrin Fischer --- Created attachment 48683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48683&action=edit [PASSED QA] Bug 14306: Changes for basket and detail templates A simple regex is added to the basket and detail templates to select the URLs passed separately from MARC21 555$u by GetMarcNotes. Note that the regex tests if a note starts with http:// or https:// and does not contain any whitespace in order to be considered as a url. These URLs are put in an anchor tag. This touches four places: [1] opac detail, tab title notes [2] catalogue detail, tab Descriptions [3] opac basket, more details, notes [4] staff basket, more details, notes Test plan: [1] Edit a record. Add a 500$a, 555$a and a URL in 555$u. Put "http://this is not a url" in the 500$a (whitespace!). [2] Check opac-detail, tab Title Notes. Check the URL. [3] Do the same for catalogue/detail. [4] Add record to cart in OPAC. Open basket. Check More details. [5] Repeat previous step in staff. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15976] test bug for a script we are developping.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15976 --- Comment #1 from Rémi Mayrand-Provencher --- Created attachment 48680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48680&action=edit bug test boop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard changed: What|Removed |Added Blocks||15978 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 [Bug 15978] Use Font Awesome icons for guided reports error dialog -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15978] New: Use Font Awesome icons for guided reports error dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 Bug ID: 15978 Summary: Use Font Awesome icons for guided reports error dialog Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/marctagstructure.pl OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 15785 If you create or update an SQL report using an invalid authorized value a dialog will ask you to confirm before saving the report. This dialog should use Font Awesome icons. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15970] Plack should not clear syspref cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #3) > Created attachment 48641 [details] [review] > Bug 15970: Do not clear syspref cache in psgi file > > This in only in koha.psgi, it has been introduced by bug 13815 but > should not have been added by this patch. > > Removing it should not introduce any changes. > Not that it won't impact debian packages. Yeah. No one cares about misc/plack/koha.psgi. Why not patching debian/templates/plack.psgi instead? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #32 from Kyle M Hall --- Pushed to Master, should be in the May 2106 Release. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 Kyle M Hall changed: What|Removed |Added Attachment #43600|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 48679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48679&action=edit Bug 11565 - decreaseLoanHighHolds needs Override This patch allows the high holds loan length decrease to be overridden either by a checkbox that remembers its setting during a series of checkouts, or by a one time use override checkbox that will show in the warning popup if a checkout is affected by high holds. Test Plan: 1) Set up a checkout that will be affected by decreaseLoanHighHolds 2) Attempt to check out an item 3) Check the override checkbox 4) Note the checkout date is not reduced 5) Return the item 6) Start a new checkout for the patron 7) Check the "Don't decrease lean length based on holds" checkbox 8) Check out the item 9) Note you are not warned about the high holds decrease and that the checkout length is not reduced Signed-off-by: Kyle M Hall Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Attachment #48580|0 |1 is obsolete|| --- Comment #43 from Kyle M Hall --- Created attachment 48678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48678&action=edit Bug 14694: Create data the tests need Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #104 from Jacek Ablewicz --- Code itself looks fine to me, but I'm a bit worried about some potential problems this patch may introduce indirectly. As it would be now possible to set up permanent & shared cache for system preferences (memcache, fastmmap), in such installations we may expect some extra troubles, e.g. with: - bunch of t/* tests (quite o lot of them) is still using ->set_preference() insted of mock_preference() - they don't commit changes to the database, but running them may now result in syspref "cache poisoning", affecting behaviour of the other processes - remaining code chunks which are dealing with systempreferences table directly (installer, updatedatabase.pl, some tests and admin/maintenance scripts); updatedatabase.pl seems to be OK (at least at the 1st glance), not sure about installer - it does call clear_syspref_cache() 1+ time, but not necessarily everywhere where it should do it / not at the each and every step (?) - up to now, when a given script retrieved some preference once, it was guaranted that all subsequent ->preference() calls during the script run will return the same value; now it will always use the current value instead - I guess sometimes that will be a good thing, and sometimes not so much - but probably not very important in practical circumstances Also there will be some (hopefully very) little performace hit due to caching system overheads (and 10 sec deafult expire in case of Cache::Memory - but it will affect only the long-running scripts) - how little, it remains to be seen ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 --- Comment #19 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #18) > Created attachment 48675 [details] [review] > Bug 5404: [QA Follow-up] Add test descriptions > > Adding descriptions for changes in t/db_dependent/Biblio.t. Oops forgot that, thanks for the follow-up! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12607] TestBuilder - Refactoring Acquisition/GetBasketsInfosByBookseller.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12607 Jonathan Druart changed: What|Removed |Added Resolution|--- |WONTFIX CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Patch doesn't apply |RESOLVED --- Comment #4 from Jonathan Druart --- This is not needed anymore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12606] TestBuilder - Refactoring Acquisition/GetOrdersByBiblionumber.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12606 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Jonathan Druart --- This is not needed anymore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15977] New: Optional double screen message in Patron Info/Status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15977
Bug ID: 15977
Summary: Optional double screen message in Patron Info/Status
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: SIP2
Assignee: koha-bugs@lists.koha-community.org
Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com
This code in MsgType.pm:
$resp .= maybe_add( FID_SCREEN_MSG, $patron->{branchcode}, $server )
if ( $server->{account}->{send_patron_home_library_in_af} );
produces two AFs if you enable that attribute in your config.
Not sure if that should be the case and is conform protocol.
Also: are we solving a problem here in the wrong place? It looks kind of
inappropriate use..
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
