[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What|Removed |Added Attachment #47478|0 |1 is obsolete|| --- Comment #68 from Nick Clemens --- Created attachment 48833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48833&action=edit Bug 10612 - Add ability to delete patrons with batch patron deletion tool This patch adds the ability to select a patron list for deletetion when using the Batch patron deletion/anonymization tool. It also adds buttons to the the patron lists table to access both the batch deletion and batch modification directly from the lists view. This is a squash of previous patches but now adds a patron_list_id parameter to C4::Members::GetBorrowersToExpunge and uses that routine to fetch patrons from a list. Test Plan: 1) Apply this patch 2) Create a list of patrons with the new Patron Lists feature 3) Try using the batch edit link form the lists table 4) Try using the batch delete link from the lists table 5) Verify previous functionality has not changed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15331] Sort order breaks at offset=1000 (both OPAC and Intranet)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15331 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #3 from Nick Clemens --- Is this valid then, or does sortmax/bug 7041 solve this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15642] Batch patron deletion should not delete patrons with issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 Nick Clemens changed: What|Removed |Added Resolution|--- |INVALID Status|In Discussion |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16009] crash displaying pending offline circulations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16009 Galen Charlton changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16009] crash displaying pending offline circulations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16009 --- Comment #1 from Galen Charlton --- Created attachment 48832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48832&action=edit Bug 16009: fix GetMember() search on NULL/undef values This patch fixes a bug whereby GetMember(searchfield => undef) (i.e., searching for patron records where 'searchfield' is NULL) would crash. This fixes a regression introduced by bug 15344 that in turn exposed a long-standing bug in GetMember(). To test: [1] Import some offline circulation transactions that include at least one return. [2] Attempt to view the list of pending transactions; a crash will occur. [3] Apply the patch and view the list of pending transactions again; this time, it should work. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16001] Use standard message dialog when there are no cities to list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #4 from Owen Leonard --- (In reply to Christopher Brannon from comment #3) > While the menu works, it doesn't deliver. Duplicate just puts me in a new > report, not a duplicate. I do not find this to be the case. Have you tried it with more than one report? > The menu could also be visible when editing. I don't think that would pose > any issues. Do you? This is something which I describe in my latest update to the interface patterns page on the wiki: "In this view the toolbar is not displayed, because the user is expected to either submit a completed form or choose the 'Cancel' link to abort the process of creating a new entry." https://wiki.koha-community.org/wiki/Interface_patterns#The_.27New.27_entry_form However, the option of duplicating something might be relevant during an edit process. I wonder if we should have a "Save as new report" option or something like that? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16009] crash displaying pending offline circulations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16009 Galen Charlton changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16009] crash displaying pending offline circulations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16009 Galen Charlton changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16009] New: crash displaying pending offline circulations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16009 Bug ID: 16009 Summary: crash displaying pending offline circulations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: gmcha...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Displaying a list of pending offline circulation actions can now fail if the cardnumber is null (as can be the case with a return). The associated crash is: DBD::mysql::st execute failed: called with 1 bind variables when 0 are needed [for Statement "SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE cardnumber IS NULL"] at /usr/share/koha/lib/C4/Members.pm line 451. This appears to be a consequence of bug 15344; it turns out that GetMemberDetails handled cardnumber => NULL better than GetMember does at present. This looks like it affects master, 3.20.8+, and 3.22.2+ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Christopher Brannon changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #3 from Christopher Brannon --- While the menu works, it doesn't deliver. Duplicate just puts me in a new report, not a duplicate. The menu could also be visible when editing. I don't think that would pose any issues. Do you? The other menu items appear to work as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What|Removed |Added Attachment #47318|0 |1 is obsolete|| Attachment #47319|0 |1 is obsolete|| --- Comment #16 from Nick Clemens --- Created attachment 48831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48831&action=edit Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page Currently if not logged in when browsing to http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl You are redirected to opac-auth.tt and SCOUserCSS and SCOUserJS are not loaded. This page passes through a parameter to the template to indicate this is an SCO login and appropriate CSS and JS should be loaded. Additionally this patch ensure that when loggin in using the form you are redirected to the sco-main.pl instead of the patron account page for the user. To test: 1 - Verify that normal login works on both staff and opac 2 - Verify that SCO link goes to login page if AutoSelfCheckAllowed is not allowed 3 - Enter changes into SCOUserJS and SCOUserCSS and observe these are present on SOC log in page 4 - Verify that a logged in opac user without permissions cannot access the self-checkout module 5 - Verify that AutoSelfCheckAllowed and associated system preferences function as expected 6 - Verify the AutoSelfCheck user is logged out if they attempt to visit another page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #60 from Brendan Gallagher --- Pushed the last two patches (48772 and 48783) Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15936] Revise layout and behavior of SMS cellular providers management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15936 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15445] DateUtils.t fails on Jenkins due to server sluggishness
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15445 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16006] merge_authorities.pl doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16006 Rémi Mayrand-Provencher changed: What|Removed |Added CC||eric.be...@inlibro.com, ||francois.charbonnier@inlibr ||o.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16008] noisy "fatal" warning when new file is moved in another patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 M. Tompsett changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16008] noisy "fatal" warning when new file is moved in another patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 M. Tompsett changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16008] noisy "fatal" warning when new file is moved in another patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 --- Comment #1 from M. Tompsett --- Created attachment 48830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48830&action=edit Bug 16008: noisy "fatal" warning when new file is moved in another patch The failure was tracked down to check_forbidden_patterns in QohA/File.pm's check_forbidden_patterns function. As there can't be any forbidden patterns on a non-existent file, this patch returns the default 1 when the file being checked does not exist. TEST PLAN - apply bug 15870 to your koha run qa test tools -- see the warning apply this patch to your qa test tools run qa test tools -- no more warning -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16006] merge_authorities.pl doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16006 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Severity|enhancement |major --- Comment #1 from Katrin Fischer --- Changing severity as this is an existing, but sadly broken feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16008] New: noisy "fatal" warning when new file is moved in another patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 Bug ID: 16008 Summary: noisy "fatal" warning when new file is moved in another patch Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: QA tools Assignee: koha-bugs@lists.koha-community.org Reporter: mtomp...@hotmail.com While working on Bug 15870, koha qa test tools gave this error fatal: ambiguous argument 't/db_dependent/RecordProcessor_ViewPolicy.t': unknown revision or path not in the working tree. This is in part, because a test file was moved/renamed and the files changed list includes the old filename. Gracefully handle the file no longer existing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16002] ALL/MULTI choices in report dropdowns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16002 Nicole C. Engard changed: What|Removed |Added CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16001] Use standard message dialog when there are no cities to list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Nicole C. Engard changed: What|Removed |Added CC||neng...@gmail.com --- Comment #2 from Nicole C. Engard --- This might be user error, but I applied the patch and see no difference. Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Nicole C. Engard changed: What|Removed |Added Attachment #48785|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard --- Created attachment 48829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48829&action=edit Bug 16000 - Duplicate a report from the New Reports button This patch creates a combined edit/duplicate/delete toolbar menu option similar to the one on the bibliographic detail page. Also added is the "Schedule" link which was previously only available from the main list of saved reports. Also added is some deletion confirmation JavaScript for deletions initiated from the toolbar. To test, apply the patch and go to Reports -> Saved reports. - Click "Show" in the menu for any saved report. The toolbar which appears on this page should show the new menu items. - Confirm the behavior of all the buttons. - As you check the behavior of the button actions, check that the toolbar is shown and hidden appropriately for each action. - Confirm that the toolbar is correctly shown or hidden when building a guided report. - Confirm that the "Schedule" button is shown or hidden according to the logged-in user's "schedule_tasks" permission. - Confirm that clicking the "Delete" menu option triggers a JS confirmation. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15995] Moving libraries actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Nicole C. Engard changed: What|Removed |Added Attachment #48722|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard --- Created attachment 48828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48828&action=edit Bug 15995: Moving libraries actions into a drop-down menu To test: 1) Go to Administration -> Libraries and Groups 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and buttons behave as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15993] Moving currency actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15995] Moving libraries actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15994] Adding font awesome icons to Funds actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 Nicole C. Engard changed: What|Removed |Added Attachment #48721|0 |1 is obsolete|| --- Comment #4 from Nicole C. Engard --- Created attachment 48827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48827&action=edit Bug 15994: Adding font awesome icons to Funds actions To test: 1) Go to Administration -> Funds 2) Confirm that appropriate Font Awesome icons now appear to each action in drop down menu Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15994] Adding font awesome icons to Funds actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15993] Moving currency actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Nicole C. Engard changed: What|Removed |Added Attachment #48720|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard --- Created attachment 48826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48826&action=edit Bug 15993: Moving currency actions into a drop-down menu To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15992] Moving item search fields actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15992] Moving item search fields actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Nicole C. Engard changed: What|Removed |Added Attachment #48719|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard --- Created attachment 48825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48825&action=edit Bug 15992: Moving item search fields actions into a drop-down menu To test: 1) Go to Administration -> Item search fields 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15991] Moving OAI sets actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15991 Nicole C. Engard changed: What|Removed |Added Attachment #48718|0 |1 is obsolete|| --- Comment #3 from Nicole C. Engard --- Created attachment 48824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48824&action=edit Bug 15991: Moving OAI sets actions into a drop-down menu To test: 1) Go to Administration -> OAI sets 2) Confirm that the actions 'Modify', 'Delete' and 'Define mappings' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15991] Moving OAI sets actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15991 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15932] Moving Authorities actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15932] Moving Authorities actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Nicole C. Engard changed: What|Removed |Added Attachment #48717|0 |1 is obsolete|| --- Comment #6 from Nicole C. Engard --- Created attachment 48823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48823&action=edit Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15966] Move MARC frameworks actions into a drop down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15966 Nicole C. Engard changed: What|Removed |Added Attachment #48716|0 |1 is obsolete|| --- Comment #3 from Nicole C. Engard --- Created attachment 48822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48822&action=edit Bug 15966: Move MARC frameworks actions into a drop down menu To test: 1) Go to Administration -> MARC bibliographic framework (admin/biblio_framework.pl) 2) Confirm that all actions have now been moved into drop down menus. a) For Default framework, actions available are 'MARC structure', 'Export' and 'Import'. b) Confirm these buttons all work as expected. c) For all other frameworks, actions available are 'MARC structure', 'Edit', 'Delete', 'Export' and 'Import'. d) Confirm these buttons all work as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15966] Move MARC frameworks actions into a drop down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15966 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15989] Moving classification sources actions into drop-down menus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15990] Moving record matching rules actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Nicole C. Engard changed: What|Removed |Added Attachment #48713|0 |1 is obsolete|| --- Comment #4 from Nicole C. Engard --- Created attachment 48821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48821&action=edit Bug 15990: Moving record matching rules actions into a drop-down menu To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15990] Moving record matching rules actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15989] Moving classification sources actions into drop-down menus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Nicole C. Engard changed: What|Removed |Added Attachment #48714|0 |1 is obsolete|| --- Comment #3 from Nicole C. Engard --- Created attachment 48820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48820&action=edit Bug 15989: Moving classification sources actions into drop-down menus To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and work as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 Edie Discher changed: What|Removed |Added CC||edisc...@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15988] Moving authority types actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15988
Nicole C. Engard changed:
What|Removed |Added
Attachment #48715|0 |1
is obsolete||
--- Comment #3 from Nicole C. Engard ---
Created attachment 48819
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48819&action=edit
Bug 15988: Moving authority types actions into a drop-down menu
To test:
1) Go to Administration -> Authority types
2) Confirm all actions ('MARC Structure', Edit', 'Delete') have been moved into
a drop down menu for each auth type, and each action behaves as expected.
Sponsored-by: Catalyst IT
Signed-off-by: Nicole C Engard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15988] Moving authority types actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15988 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15982] Serials numbering patterns can be deleted without warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15982 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15982] Serials numbering patterns can be deleted without warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15982 Nicole C. Engard changed: What|Removed |Added Attachment #48701|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard --- Created attachment 48818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48818&action=edit Bug 15982 - Serials numbering patterns can be deleted without warning A JavaScript alert should ask the user to confirm deletion of a serial numbering pattern. This patch adds this to the template. To test, apply the patch and go to Serials -> Manage numbering patterns. - In the list of patterns, click any "Delete" link. - Verify that a JavaScript alert is triggered. - Test that cancelling the alert cancels the deletion operation. - Test that confirming the alert allows the deletion to complete. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15981] Serials frequencies can be deleted without warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Nicole C. Engard changed: What|Removed |Added Attachment #48699|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard --- Created attachment 48817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48817&action=edit Bug 15981 - Serials frequencies can be deleted without warning A JavaScript alert should ask the user to confirm deletion of a serial frequency. This patch adds this to the template. To test, apply the patch and go to Serials -> Manage frequencies - In the list of frequencies, click any "Delete" link. - Verify that a JavaScript alert is triggered. - Test that cancelling the alert cancels the deletion operation. - Test that confirming the alert allows the deletion to complete. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15981] Serials frequencies can be deleted without warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15979] Use Font Awesome icons subscription deletion confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Nicole C. Engard changed: What|Removed |Added Attachment #48697|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard --- Created attachment 48816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48816&action=edit Bug 15979 - Use Font Awesome icons subscription deletion confirmation dialog When deleting a subscription which has not expired or which has linked issues or items, a dialog asks for confirmation. This patch updates the dialog to use Font Awesome icons. Other minor change: Corrected capitalization in dialog heading. To test, apply the patch and go to Serials. - Locate a subscription which can be deleted and which has not expired, has linked items, or has linked issues. - View the detail page for that subscription. - Choose "Delete subscription" from the "Edit" menu. - Verify that the confirmation dialog is correctly styled. - Verify that the "No, don't delete" button works correctly. - Verify that the "Yes, delete" button deletes the subscription. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15979] Use Font Awesome icons subscription deletion confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16007] Correction of 'Remove columns branchcode, categorytype from table overduerules_transport_types'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Charles Farmer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |charles.far...@inlibro.com |y.org | Assignee|gmcha...@gmail.com |charles.far...@inlibro.com Status|NEW |ASSIGNED Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16007] New: Correction of 'Remove columns branchcode, categorytype from table overduerules_transport_types'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Bug ID: 16007 Summary: Correction of 'Remove columns branchcode, categorytype from table overduerules_transport_types' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: charles.far...@inlibro.com QA Contact: testo...@bugs.koha-community.org Bug 13624 definitely broke the master by removing the column `overduerules_transport_type`.`letternumber` from kohastructure.sql. This seems to be a mistake, since we only dropped columns `branchcode` and `categorycode` in the atomicupdate file. This new bug is to keep track of everything made to address this issue. I don't know if we'll start with a patch correcting the master, or if we'll rebase to old patch and move from there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #59 from Katrin Fischer --- Ithink it would be the easiest fix that way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #48769|0 |1 is obsolete|| --- Comment #19 from Héctor Eduardo Castro Avalos --- Created attachment 48815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48815&action=edit [SIGNED-OFF]Bug 15870: potential follow up to comment #8 This patch: - makes the Koha::RecordProcessor code more clear by removing the unnecessary newrecord variable. - revises the filter to be more clear about the expectation that operations are done directly on the record parameter. TEST PLAN - prove t/RecordProcessor.t prove t/db_dependent/Filter_MARC_ViewPolicy.t run koha qa test tools Signed-off-by: Hector Castro Works as advertised. NO koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #48767|0 |1 is obsolete|| --- Comment #17 from Héctor Eduardo Castro Avalos --- Created attachment 48813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48813&action=edit [SIGNED-OFF]Bug 15870: (QA followup) Add tests This patch introduces functionality tests for the new Koha::Filter. It iterates over all the possible 'hidden' values defined in the docs for hiding/showing fields and subfields, and checks the filter does the job. It tests the functionality for both opac and intranet interfaces and tries to catch all scenarios. It adds control fields to the sample record (they traverse a different branch in the code). TODO: Add another subfield to 245, set it to be hidden, and make sure 245 $a is still shown. The original tests file has been renamed conveniently. To test: - Run $ prove t/db_dependent/Filter_MARC_ViewPolicy.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #48766|0 |1 is obsolete|| --- Comment #16 from Héctor Eduardo Castro Avalos --- Created attachment 48812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48812&action=edit [SIGNED-OFF]Bug 15870: MARC Filter to exclude fields/subfields lacking visibility TEST PLAN - 0) Apply 15777 and 15871 as required. 1) Apply patch 2) prove -v t/db_dependpent/RecordProcessor_ViewPolicy.t -- all should pass. 3) koha qa test tools. BONUS 4) perlcritic -1 t/db_dependpent/RecordProcessor_ViewPolicy.t -- using the koha qa test tools perlcriticrc, it should pass though I am excluding checking print return values. (see bug 15646) Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #48768|0 |1 is obsolete|| --- Comment #18 from Héctor Eduardo Castro Avalos --- Created attachment 48814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48814&action=edit [SIGNED-OFF]Bug 15870: Follow-up of filter and tests This patch: - improves perlcritic messages in the filter and tests. - changes should display logic to should hide logic to simplify filter. - perltidies the scripts - debugs the issues outstanding on the comprehensive tests provided in the second commit. Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
Nicole C. Engard changed:
What|Removed |Added
Attachment #48618|0 |1
is obsolete||
--- Comment #2 from Nicole C. Engard ---
Created attachment 48811
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48811&action=edit
Bug 15969 - Allow use of Template Toolkit syntax for Phone Notices
By allowing the use of Template Toolkit for generating the outgoing
Talking Tech CSV files, we can give libaries more control over the data
they send to Itiva. This enhancement would also make it possible to use
the script for other services since the output is no longer fixed to a
single format.
Test Plan:
1) Apply this patch
2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout
3) Generate the CSV file via the script
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
4) Enable Template Toolkit for the notices and update the notice text to be:
[% FILTER remove("\r\n") %]
"[% format %]",
"[% language %]",
"[% type %]",
"[% level %]",
"[% borrower.cardnumber %]",
"[% borrower.title %]",
"[% borrower.firstname %]",
"[% borrower.surname %]",
"[% borrower.phone %]",
"[% borrower.email %]",
"[% library_code %]",
"[% branch.id %]",
"[% branch.branchname %]",
"[% item.barcode %]",
"[% due_date %]",
"[% biblio.title %]",
"__MESSAGE_ID__"
[% END %]
5) Regenerate the notices
6) Compare the originals, note the format is the same
Signed-off-by: Sean McGarvey
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Nicole C. Engard changed: What|Removed |Added Attachment #48620|0 |1 is obsolete|| --- Comment #27 from Nicole C. Engard --- Created attachment 48807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48807&action=edit Bug 14757 [QA Followup] - Add Unit Tests Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Nicole C. Engard changed: What|Removed |Added Attachment #48622|0 |1 is obsolete|| --- Comment #29 from Nicole C. Engard --- Created attachment 48809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48809&action=edit Bug 14757 [QA Followup] - Change method type() to _type() for Koha objects Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Nicole C. Engard changed: What|Removed |Added Attachment #48805|0 |1 is obsolete|| --- Comment #30 from Nicole C. Engard --- Created attachment 48810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48810&action=edit Bug 14757 [QA Followup] - Change all references to Koha::Borrower to Koha::Patron Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Nicole C. Engard changed: What|Removed |Added Attachment #48619|0 |1 is obsolete|| --- Comment #26 from Nicole C. Engard --- Created attachment 48806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48806&action=edit Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices This bug is the beginning of a conversion from our current bespoke syntax for slips and notices to Template Toolkit syntax. This patch is the initial seed which will evolve over time. With this addition, we can take advantage of our Koha Objects to greatly simplify the processing of Slips and Notices over time. Test Plan: 1) Apply this patch 2) Ensure you have the default CHECKOUT notice 3) Check out and return an item for a patron 4) Note the text of the CHECKOUT notice 5) Replace your CHECKOUT notice with the following: The following items have been checked out: [% biblio.title %] Thank you for visiting [% branch.branchname %]. 6) Repeat step 3 7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text Signed-off-by: Bernardo Gonzalez Kriegel New notice syntax works, no koha-qa errors Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Nicole C. Engard changed: What|Removed |Added Attachment #48621|0 |1 is obsolete|| --- Comment #28 from Nicole C. Engard --- Created attachment 48808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48808&action=edit Bug 14757 [QA Followup] - Make the use of TT a controllable switch, hide it behind a syspref Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Chris Cormack changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14560] Introduce a way of handling Rameau composed authorities, without breaking normal workflow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14560 I'm just a bot changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||git...@bugs.koha-community. ||org --- Comment #8 from I'm just a bot --- .git/rebase-apply/patch:30: trailing whitespace. my ($counteditedbiblio,$countunmodifiedbiblio,$counterrors)=(0,0,0); .git/rebase-apply/patch:35: trailing whitespace. .git/rebase-apply/patch:97: trailing whitespace. # Get All candidate Tags for the change .git/rebase-apply/patch:101: trailing whitespace. # May be used as a template for a bulkedit field .git/rebase-apply/patch:115: trailing whitespace. my $tag=$field->tag(); warning: squelched 1 whitespace error warning: 6 lines add whitespace errors. .git/rebase-apply/patch:30: trailing whitespace. my ($counteditedbiblio,$countunmodifiedbiblio,$counterrors)=(0,0,0); .git/rebase-apply/patch:35: trailing whitespace. .git/rebase-apply/patch:97: trailing whitespace. # Get All candidate Tags for the change .git/rebase-apply/patch:101: trailing whitespace. # May be used as a template for a bulkedit field .git/rebase-apply/patch:115: trailing whitespace. my $tag=$field->tag(); error: patch failed: C4/AuthoritiesMarc.pm:1553 error: C4/AuthoritiesMarc.pm: patch does not apply error: Did you hand edit your patch? It does not apply to blobs recorded in its index. at ./getter.pl line 196. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 I'm just a bot changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #27 from I'm just a bot --- fatal: previous rebase directory .git/rebase-apply still exists but mbox given. at ./getter.pl line 196. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #8 from Kyle M Hall --- I think using quotes to define names to not split apart makes the most sense. so a starts_with search for Kyle Hall will look for fields starting with "Kyle" and/or fields starting with "Hall" where a search for "Kyle Hall" will look for fields starting with "Kyle Hall" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #25 from Kyle M Hall --- Created attachment 48805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48805&action=edit Bug 14757 [QA Followup] - Change all references to Koha::Borrower to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
koha-bugs@lists.koha-community.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #58 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #57) > Aarrggg > This was hard to find: > The foreign key constraint (in AQorder) will sometimes fail on you: > Why? > aqorder: > | currency| varchar(3)| YES | MUL | NULL | > currency: > | currency | varchar(10) | NO | PRI | | > > Length is not the SAME !! So I take it we need a dbrev to update aqorder.currency to varchar(10) as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #45 from Kyle M Hall --- Created attachment 48804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48804&action=edit Bug 14694 [QA Followup] - Update Koha::Borrower references to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What|Removed |Added Status|In Discussion |ASSIGNED --- Comment #15 from Nick Clemens --- You are correct Joubu, there are easier methods, patch to follow later -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16006] New: merge_authorities.pl doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16006 Bug ID: 16006 Summary: merge_authorities.pl doesn't work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: remi.mayrand-provenc...@inlibro.com Reporter: remi.mayrand-provenc...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Running the merge_authorities.pl script with options -f and -t set properly returns this on a clean master installation: Can't locate object method "authtypecode" via package "2" (perhaps you forgot to load "2"?) at ./merge_authority.pl line 58. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #74 from Kyle M Hall --- Created attachment 48797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48797&action=edit Bug 14695 - Tidy C4::Reserves::CanItemBeReserved Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #75 from Kyle M Hall --- Created attachment 48798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48798&action=edit Bug 14695 - Add ability to place multiple item holds on a given record per patron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #80 from Kyle M Hall --- Created attachment 48803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48803&action=edit Bug 14695 - Don't use holds_to_place_count when checking an item. This fix the following bug: If you select 2 in "Holds to place (count)" and finally check an item, so you get 2 holds for the same item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #79 from Kyle M Hall --- Created attachment 48802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48802&action=edit Bug 14695 - Warn librarian if max_holds_per_record is reached -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #78 from Kyle M Hall --- Created attachment 48801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48801&action=edit Bug 14695 [QA Followup] - Fix clearing of all holds by patron at checkout Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #76 from Kyle M Hall --- Created attachment 48799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48799&action=edit Bug 14695 [QA Followup] - Filling one hold fills all of them Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #77 from Kyle M Hall --- Created attachment 48800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48800&action=edit Bug 14695 [QA Followup] - Make existing unit tests pass * Removes tests no longer needed * Updates rules to work with existing tests * Fixes code issues revealed by unit tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #73 from Kyle M Hall --- Created attachment 48796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48796&action=edit Bug 14695 - Add new circulation rule Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #72 from Kyle M Hall --- Created attachment 48795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48795&action=edit Bug 14695 - Update DB Schema file Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Nick Clemens changed: What|Removed |Added Attachment #48514|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 48794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48794&action=edit Bug 14629 - [QA Followup] Pass invalid ISSN through GetVariationsOfISSN This is an optional follow up depending on community opinion. While copying over the code form the ISBN portion I noticed that with aggressive matching enabled invalid ISBNs (and hence ISSNs) were being stripped from the record. I think in the case of a library exporting records, making changes, and reimporting they would expect to get a match on ISSN or ISBN whether or not the number is valid. This patch changes the subroutine to return the original ISSN in the case of it being invalid. To test: With first patch only export a record with an invalid ISSN and reimport with AggressiveMatchOnISSN enabled and match on ISSN - you should not get a match Apply this patch reimport the file and you should find a match. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Nick Clemens changed: What|Removed |Added Attachment #48513|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 48793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48793&action=edit Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher This patch adds a syspref "AggressiveMatchOnISSN" allowing for a match of ISSNs with or without hyphens. It uses Business::ISSN in order to follow the use of Business::ISBN and allow for validation of ISSNs To test: 1 - Find a record in your system with an ISSN (or add one) 2 - Stage a record containing the same ISSN but lacking a hyphen 3 - Matching on ISSN should find 0 matches 4 - Repeat with no hyphen ISSN in system and hyphen ISSN in import 5 - Matching should find 0 6 - Apply patch 7 - Update datbase and install Business::ISSN 8 - Leave AggressiveMatchOnISSN as don't and repeat original tests- no change 9 - Set AggressiveMatchOnISSN as do and repeat original test 10 - You should find a match 11 - prove t/Koha.t - all tests pass Sponsored by North Central Regional Library System (NCRL) www.ncrl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What|Removed |Added Attachment #47606|0 |1 is obsolete|| Attachment #47607|0 |1 is obsolete|| Attachment #47608|0 |1 is obsolete|| Attachment #47609|0 |1 is obsolete|| Attachment #47610|0 |1 is obsolete|| Attachment #47611|0 |1 is obsolete|| Attachment #47612|0 |1 is obsolete|| Attachment #47613|0 |1 is obsolete|| Attachment #47614|0 |1 is obsolete|| Attachment #47615|0 |1 is obsolete|| --- Comment #71 from Kyle M Hall --- Created attachment 48792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48792&action=edit Bug 14695 - Update database Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #57 from Marcel de Rooy --- Aarrggg This was hard to find: The foreign key constraint (in AQorder) will sometimes fail on you: Why? aqorder: | currency| varchar(3)| YES | MUL | NULL | currency: | currency | varchar(10) | NO | PRI | | Length is not the SAME !! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16003] Add spelling exclusion patch to QA Test tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003
--- Comment #6 from M. Tompsett ---
Created attachment 48791
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48791&action=edit
Bug 16003 - Add exceptions file logic to codespell call
I created an exceptions file by:
$ git grep "isnt(" | cut -f2- -d":" | sort -u >
~/qa-test-tools/spelling.exceptions
I then patched QohA/File.pm to include a -x extension to the
codespell call if the exceptions file existed.
TEST PLAN
-
In your koha development directory apply bug 15870
run the koha qa test tools
-- you will get a complaint about isnt(,
likely because it is tokenized as isnt.
apply this patch to your qa test tools
run the koha qa test tools on bug 15870 again
-- spelling issue passed!
THIS IS A COUNTER PATCH.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #41 from Kyle M Hall --- This latest patch should fix both of your issues Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Kyle M Hall changed: What|Removed |Added Attachment #48749|0 |1 is obsolete|| --- Comment #40 from Kyle M Hall --- Created attachment 48790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48790&action=edit Bug 11360 - Disable barcode field and submit button when a hold is found At the moment when scanning in returns, it can be easy to miss a hold trap due to the fact that the barcode and submit are still active and the barcode field is focused on. A librarian who is focused on scanning can easily scan another item and pass over the form, which is equivalent to clicking the "ignore" button. Test Plan: 1) Apply this patch 2) Trap a hold, note the new modal 3) Check the hold in a second time 4) Note the new modal 5) For each modal, test each button -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16005] New: Standardize use of icons for delete and cancel operations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16005 Bug ID: 16005 Summary: Standardize use of icons for delete and cancel operations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Right now we are using a mix of similar icons for operations like delete, cancel, close, etc. We need to set a standard so that it is clear which icon means what. I propose that the "trash" icon be used anywhere something is being deleted, removed, or cleared: http://fortawesome.github.io/Font-Awesome/icon/trash/ I propose that we use the "times" (for which "remove" is an alias) icon for cancel operations (where buttons are used): http://fortawesome.github.io/Font-Awesome/icon/times/ I propose that we use the "times-circle" icon to mean "close:" http://fortawesome.github.io/Font-Awesome/icon/times-circle/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #49 from Blou --- So, we need a patch that corrects the pushed-to-master patch, for future installations. AND that patch must also provide a fix to those who already installed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
