[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice changed: What|Removed |Added Attachment #48418|0 |1 is obsolete|| --- Comment #48 from Julian Maurice --- Created attachment 49061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49061&action=edit Bug 11904: Example usage of new module Koha::Messages Test plan: 1/ Go to members/moremember.pl 2/ Click on "More" -> "Renew patron" and confirm 3/ A message should appear "Patron's account has been renewed until ..." 4/ In a shell, go to misc/translator and run ./translate create fr-FR (or ./translate update fr-FR) ./translate install fr-FR (you can use your own language of course) 5/ Edit po/fr-FR-messages.po and translate the string "Patron's account has been renewed until ..." 6/ In staff interface change language to French and renew patron once again. 7/ The translated message should appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice changed: What|Removed |Added Attachment #48417|0 |1 is obsolete|| --- Comment #47 from Julian Maurice --- Created attachment 49060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49060&action=edit Bug 11904: Unit tests for Koha::Messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice changed: What|Removed |Added Attachment #48415|0 |1 is obsolete|| Attachment #48416|0 |1 is obsolete|| --- Comment #46 from Julian Maurice --- Created attachment 49059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49059&action=edit Bug 11904: New module Koha::Messages Rebased on master Use current style for dialogs instead of adding a new style -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16054] Plack - variable scope error in paycollect.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16054 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16048] Making notices actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16048 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16026] Use Font Awesome icons on cataloging home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16026 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15397] Pay selected does not works as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15397 --- Comment #4 from bondiurbano --- Jonathan, I have tested in a local installation (3.22.4) and works fine! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15694] Date/time-last-modified not searchable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #21 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15955] Tuning function 'New child record' for Unimarc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #11 from Brendan Gallagher --- Pushed to MAster - Should be in the May 2016 release! Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16022] Use Font Awesome icons on patron lists page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16022 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238 --- Comment #9 from M. Tompsett --- Valid point. I stand by the sign off for this string revision. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15952] Moving cataloging search actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15952 Owen Leonard changed: What|Removed |Added Attachment #48567|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 49058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49058&action=edit [SIGNED-OFF] Bug 15952: Moving cataloging search actions into a drop-down menu Edit: Have removed the datatables stuff - wasn't necessary. Also fixed a merge conflict To test: 1) Go to Cataloging and do a search in the catalog and reservoir (cataloguing/addbooks.pl) 2) Confirm that for the results found in catalog, the options (MARC and Card preview, Edit biblio, Add/edit items) are there and behave as expected. 3) Confirm that for the results found in reservoir, the options (MARC and Card preview, Add biblio) are there and behave as expected. 4) Set user permissions so that the user cannot edit the catalog or items. (editcatalogue -> edit_catalogue and edit_items) 5) Confirm that you no longer see the options to edit or add items/biblio in either table. Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians Expected result following the test plan. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15952] Moving cataloging search actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15952 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15990] Making record matching rules actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15990] Making record matching rules actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Owen Leonard changed: What|Removed |Added Attachment #48902|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 49057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49057&action=edit [SIGNED-OFF] Bug 15990: Making record matching rules actions buttons To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' are not buttons and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15932] Moving Authorities actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard --- Was this change intentional? It's a regression from Bug 15927. + [% UNLESS ( loop.odd ) %] + + [% ELSE %] + + [% END %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16056] New: Error when deleting MARC authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16056 Bug ID: 16056 Summary: Error when deleting MARC authority Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/authorities/authorities-home.pl OS: All Status: NEW Severity: major Priority: P5 - low Component: MARC Authority data support Assignee: gmcha...@gmail.com Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org When I try to delete a MARC authority record from the authority search results list (Authorities -> Search) I get an error. Can't call method "authtypecode" on an undefined value at C4/AuthoritiesMarc.pm line 305. I think the authority is being deleted correctly but the out-of-date index is triggering an error, because reloading the search results page triggers the error again. Reindexing makes it go away. I'm guessing this is related to Bug 15380 or Bug 15381. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15656] Move the guarantor/guarantees code to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656
Kyle M Hall changed:
What|Removed |Added
Attachment #48108|0 |1
is obsolete||
Attachment #48109|0 |1
is obsolete||
--- Comment #5 from Kyle M Hall ---
Created attachment 49054
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49054&action=edit
Bug 15656: Move guarantor/guarantees code - GetGuarantees
2 subroutines of C4::Members deal with guarantor/guarantees:
GetGuarantees and GetMemberRelatives.
Since we already have a Koha::Patron->guarantor method, it makes sense
to move these 2 subroutines to this module.
This first patch deals with GetGuarantees.
Test plan for the entire patch set:
1/ Create 5 patrons A (adult), B (child), C (child), D (child), E
(child), F (adult)
2/ Add relation between them: A is father of B, C and D.
E does not have a guarantor
F does not have guarantees
3/ Check some items out for all of these patrons
4/ On the "Check out" and "Details" tabs, you should not see any
differences with these patch applied : The "Relatives' checkouts" tabs
should list all of the guarantor/guarantee/siblings checkouts
Note:
$template->param('C' => 1);
I have not found any reference of this 'C' in the template.
It seems it's an old c/p from members/memberentrygen.tt
Signed-off-by: Josef Moravec
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15656] Move the guarantor/guarantees code to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 --- Comment #7 from Kyle M Hall --- Created attachment 49056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49056&action=edit Bug 15656 [QA Followup] - Return without searching if patron has no guarantor Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15656] Move the guarantor/guarantees code to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 --- Comment #6 from Kyle M Hall --- Created attachment 49055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49055&action=edit Bug 15656: Move guarantor/guarantees code - GetMemberRelatives Note: QA question: Does the Koha::Patron->siblings method should return undef if there is no guarantor? It would avoid the weird != undef, = $borrowernumber conditions. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15656] Move the guarantor/guarantees code to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16034] Integration with OverDrive Patron API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jesse Weaver changed: What|Removed |Added CC||jwea...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15989] Making classification sources actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 --- Comment #10 from Owen Leonard --- Created attachment 49053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49053&action=edit Bug 15989 [Follow-up] Making classification sources actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. Also changed in this patch: A couple of capitalization errors. To test, apply the patch for Bug 16048 and go to Administration -> Classification sources. Confirm that the "Edit" and "Delete" buttons do not stack on top of each other even at narrow browser widths. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15989] Making classification sources actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Owen Leonard changed: What|Removed |Added Attachment #48901|0 |1 is obsolete|| --- Comment #9 from Owen Leonard --- Created attachment 49052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49052&action=edit [SIGNED-OFF] Bug 15989: Making classification sources actions buttons To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' now show as buttons for BOTH tables and work as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15653] Updating a guarantor has never updated its guarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15653
Kyle M Hall changed:
What|Removed |Added
Attachment #48662|0 |1
is obsolete||
--- Comment #4 from Kyle M Hall ---
Created attachment 49051
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49051&action=edit
Bug 15653: Remove unused C4::Members::UpdateGuarantees subroutine
Looking at the code, there is some broken with the guarantees code.
It seems that the expected behavior would be to update address, fax,
B_city, mobile, city and phone info of the guarantees when a guarantor
is modified.
But the code in C4::Members::ModMember is broken:
668 my $borrowercategory= GetBorrowercategory(
$data{'category_type'} );
669 if ( exists $borrowercategory->{'category_type'} &&
$borrowercategory->{'category_type'} eq ('A' || 'S') ) {
670 # is adult check guarantees;
671 UpdateGuarantees(%data);
672 }
First, GetBorrowerCategory expects a categorycode, not a category_type.
Then UpdateGuarantees retrieves the param like:
989 sub UpdateGuarantees {
990 my %data = shift;
Which means that %data will always be something like ( a_key => undef )
And nothing more.
The updateguarantees subroutine (It has been renamed) has been introduced by
commit 56825e415fc232e38f0a874dc9a81fa2169ef06b
Date: Mon Aug 30 13:48:58 2004 +
modularizing (with Members.pm) members management
(beginning of...)
And the `%data = shift` already existed...
This code has never worked and could be removed.
See
http://lists.koha-community.org/pipermail/koha-devel/2016-January/042241.html
Test plan:
Confirm the previous assertions.
Note that I have found this bug working on bug 15631, see patch "Bug
15631: Koha::Cities - remove getidcity and GetCities"
Signed-off-by: Hector Castro
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15653] Updating a guarantor has never updated its guarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15653 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16038] Moving basketgroups actions into dropdown menus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16038 Owen Leonard changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16055 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Owen Leonard changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16055 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16055] New: Deleting a basket group containing baskets fails silently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16055 Bug ID: 16055 Summary: Deleting a basket group containing baskets fails silently Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/basketgroup.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org In the list of basket groups for a vendor there is a "delete" option for each basket group whether or not the basket group contains baskets. If you choose "delete" for a basket group containing a basket it will fail silently and an error will be logged: DBD::mysql::st execute failed: Cannot delete or update a parent row: a foreign key constraint fails (`aqbasket`, CONSTRAINT `aqbasket_ibfk_3` FOREIGN KEY (`basketgroupid`) REFERENCES `aqbasketgroups` (`id`) ON UPDATE CASCADE) [for Statement "DELETE FROM aqbasketgroups WHERE id=?" with ParamValues: 0="3"] Since the template knows the number of baskets in a basket group it should be easy to hide or disable the delete button in those cases. It also would be nice to add a JavaScript confirmation before deleting a basket. Right now deletions are completed without any warning. Keep in mind the work being done in Bug 16038 and Bug 11708 when considering this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16037] Printing a closed basket group doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16037 --- Comment #2 from Owen Leonard --- (In reply to Katrin Fischer from comment #1) > maybe we could rename the link anyway? I think calling it "Save as PDF" would be sensible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16038] Moving basketgroups actions into dropdown menus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16038 --- Comment #2 from Owen Leonard --- This looks good, but I see that Bug 11708 will make major changes to this page. Patches on that bug are signed off, so you might want to apply your changes on top of that? Maybe after it has passed QA, just in case? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16014] OAI sets can be deleted without warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16014 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15995] Making libraries actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Owen Leonard changed: What|Removed |Added Attachment #48904|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15995] Making libraries actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 --- Comment #8 from Owen Leonard --- Created attachment 49050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49050&action=edit Bug 15995 [Follow-up] Making libraries actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and go to Administration -> Libraries and Groups. Confirm that the "Edit" and "Delete" buttons do not wrap even at narrow browser window widths. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15995] Making libraries actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 --- Comment #7 from Owen Leonard --- Created attachment 49049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49049&action=edit [SIGNED-OFF] Bug 15995: Making libraries actions buttons To test: 1) Go to Administration -> Libraries and Groups 2) Confirm that the actions 'Edit' and 'Delete' are now buttons for BOTH tables under one column 'Actions' and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15962] Currency deletion doesn't correctly identify currencies in use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15962 Owen Leonard changed: What|Removed |Added Attachment #48774|0 |1 is obsolete|| --- Comment #9 from Owen Leonard --- Created attachment 49048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49048&action=edit [SIGNED-OFF] Bug 15962: Block the currency deletion if used A currency should not be deleted if used by a vendor or a basket. Test plan: 1/ Add a new currency 2/ Create a vendor using this currency 3/ Create a basket using this currency 4/ Try to delete the currency 5/ Delete the basket 6/ Try to delete the currency 7/ Delete the vendor 8/ Delete the currency Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15962] Currency deletion doesn't correctly identify currencies in use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15962 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15962] Currency deletion doesn't correctly identify currencies in use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15962 Owen Leonard changed: What|Removed |Added Attachment #48773|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 49047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49047&action=edit [SIGNED-OFF] Bug 15962: Add messages on the currency admin page Bug 15084 rewrote the currency admin page but forgot to add the messages block. Test plan: Add/update/delete vendors. You should get information messages. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16053] Edit the active currency removes its 'active' flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16053 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16053] Edit the active currency removes its 'active' flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16053 Owen Leonard changed: What|Removed |Added Attachment #49004|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 49045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49045&action=edit [SIGNED-OFF] Bug 16053: Add tests Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16053] Edit the active currency removes its 'active' flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16053 Owen Leonard changed: What|Removed |Added Attachment #49005|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 49046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49046&action=edit [SIGNED-OFF] Bug 16053: Do not remove the active flag when editing the active currency >From commit b574b615919a6463708d4c1d7b1153a061c1ea0a Bug 15084: Make sure the previous active currency is marked as inactive When a currency is stored, all the active flags of all currencies are unset. Only the active ones and different than the one we are editing should be updated. Test plan: Edit the active currency => Without this patch the active flag was removed => With this patch, the active flag is kept Edit another currency and set it the active flag => The active flag must have been removed from the previously active currency. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15531] Add support for standing orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Jonathan Field changed: What|Removed |Added CC||jonathan.field@ptfs-europe. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15993] Making currency actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Owen Leonard changed: What|Removed |Added Attachment #48903|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 49043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49043&action=edit [SIGNED-OFF] Bug 15993: Making currency actions buttons To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' are now buttons and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15993] Making currency actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 --- Comment #8 from Owen Leonard --- Created attachment 49044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49044&action=edit Bug 15993 [Follow-up] Making currency actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and go to Administration -> Currencies and exchange rates. In the table of currencies, confirm that the "Edit" and "Delete" buttons are not stacked one on top of the other even at narrow browser window widths. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #152 from Kyle M Hall --- Created attachment 49040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49040&action=edit Bug 7736 [QA Followup] - Fix column headers, values and spelling Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #154 from Kyle M Hall --- Created attachment 49042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49042&action=edit Bug 7736 [QA Followup] - Fix spelling and pod errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #151 from Kyle M Hall --- Created attachment 49039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49039&action=edit Bug 7736 [QA Followup] - Fix collation Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall changed: What|Removed |Added Attachment #48971|0 |1 is obsolete|| Attachment #48972|0 |1 is obsolete|| Attachment #48973|0 |1 is obsolete|| Attachment #48976|0 |1 is obsolete|| --- Comment #149 from Kyle M Hall --- Created attachment 49037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49037&action=edit Bug 7736: Support Ordering via Edifact EDI messages Add support for processing incoming Edifact Quotes, Invoices and order responses and generating and transmission of Edifact Orders. Basic workflow is that an incoming quote generates an aquisition basket in Koha, with each line corresponding to an order record The user can then generate an edifact order from this (or another) basket, which is transferred to the vendor's site The supplier generates an invoice on despatch and this will result in corresponding invoices being generated in Koha The orderlines on the invoice are receipted automatically. We also support order response messages. This may include simple order acknowledgements, supplier reports/amendments on availability. Cancellation messages cause the koha order to be cancelled, other messages are recorded against the order Which messages are to be supported/processed is specifiable on a vendor by vendor basis via the admin screens You can also specify auto order i.e. to generate orders from quotes without user intervention - This reflects existing workflows where most work is done on the suppliers website then generating a dummy quote Received messages are stored in the edifact_messages table and the original can be viewed via the online Database changes are in installer/data/mysql/atomicchanges/edifact.sql Note new perl dependencies: Net::SFTP:Foreign Text::Unidecode Signed-off-by: Paul Johnson Signed-off-by: Sally Healey Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #150 from Kyle M Hall --- Created attachment 49038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49038&action=edit Bug 7736 Add Edifact order fields to Acquisition.t Modification in Acquisition.t to support in test the new fields of the table aqorders: line_item_id, suppliers_reference_number, suppliers_reference_qualifier, suppliers_report Original patch by Zeno Tajoli I amended to include the report field (ColinC) Signed-off-by: Paul Johnson Signed-off-by: Sally Healey Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #153 from Kyle M Hall --- Created attachment 49041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49041&action=edit Bug 7736 [QA Followup] - Fix SQL, Add description field for Library EANs Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Kyle M Hall changed: What|Removed |Added Depends on||15656 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 [Bug 15656] Move the guarantor/guarantees code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Kyle M Hall changed: What|Removed |Added Attachment #48784|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 49036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49036&action=edit Bug 14577 - Allow restriction of checkouts based on fines of guarantor's guarantees This enhancment allows a library to prevent patrons from checking out items if his or her guarantees own too much. Test Plan: 1) Apply this patch 2) Find or create a patron with a guarantor 3) Add a fine to the patron's account 4) Set the new system preference NoIssuesChargeGuarantees to be less than the amount owed by the patron 4) Attempt to check out an item to the guarantor, you will either be warned or prevented from checking out based on your system settings. Signed-off-by: Cathi Wiggin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15656] Move the guarantor/guarantees code to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 Kyle M Hall changed: What|Removed |Added Blocks||14577 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16042] Missing closing quote in checkin template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16042 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #3 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16031] sitemap.pl shouldn't append protocol to OPACBaseURL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16033] Quotes upload preview broken for 973 days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16033 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16009] crash displaying pending offline circulations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16009 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #6 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #49013|0 |1 is obsolete|| --- Comment #23 from Héctor Eduardo Castro Avalos --- Created attachment 49035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49035&action=edit [SIGNED-OFF]Bug 15870: Follow up to address comment #20 - $OUTPUT_AUTOFLUSH wasn't used to it was removed - Use English was removed since $OUTPUT_AUTOFLUSH wasn't not needed - transaction start and end were moved to subtests - prepare was moved outside loop - partial MARC agnosticism was added TEST PLAN - 1) apply patch 2) prove t/db_dependent/Filter_MARC_ViewPolicy.t 3) run koha qa test tools Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16046] Use Font Awesome icons on patron edit pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16046 Christian Stelzenmüller changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||christian.stelzenmueller@bs ||z-bw.de --- Comment #2 from Christian Stelzenmüller --- tested patch for sandbox, everything ok -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #6 from Owen Leonard --- (In reply to Jonathan Druart from comment #5) > I'd prefer the contrary: update all existing occurrences of [% INCLUDE > 'doc-head-close.inc' %] with [% INCLUDE 'doc-head-close.old.inc' %] # > s/old/whatever That's fine with me. I wonder if the name of the "old" include should reflect the version? I'm concerned that we are going to end up with doc-head-close.old.inc, doc-head-close.older.inc, and doc-head-close.even-older.inc if newer jQuery upgrades start getting added before the last upgrade is complete! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- (In reply to Owen Leonard from comment #3) > (In reply to Chris Nighswonger from comment #1) > > Just for clarification: Is this nomenclature intended to be permanent or is > > this just temporary until everything is upgraded? > > Theoretically temporary I guess. I'd prefer the contrary: update all existing occurrences of [% INCLUDE 'doc-head-close.inc' %] with [% INCLUDE 'doc-head-close.old.inc' %] # s/old/whatever I can provide a follow-up if you agree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Fiona Borthwick changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Alex Arnaud changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Alex Arnaud changed: What|Removed |Added Attachment #47541|0 |1 is obsolete|| --- Comment #57 from Alex Arnaud --- Created attachment 49033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49033&action=edit Bug 15206 - Make CalculateAge a reusable function Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Alex Arnaud changed: What|Removed |Added Attachment #47542|0 |1 is obsolete|| --- Comment #58 from Alex Arnaud --- Created attachment 49034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49034&action=edit Bug 15206: Make strings translatable Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Alex Arnaud changed: What|Removed |Added Attachment #47540|0 |1 is obsolete|| --- Comment #56 from Alex Arnaud --- Created attachment 49032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49032&action=edit Bug 15206 - Show patron's age under date of birth in memberentry.pl Test plan: Create or edit a patron (members/memberentry.pl), enter a date of birth (for a new patron), patron'a age should be shown under Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15263] XSLT display fetches sysprefs for every result processed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Mirko Tietgen changed: What|Removed |Added Attachment #48963|0 |1 is obsolete|| --- Comment #8 from Mirko Tietgen --- Created attachment 49031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49031&action=edit Bug 15263: (follow-up) XSLT display fetches sysprefs for every result processed Set variables ($sysxml, $xslfilename, $lang) if they are not passed to the subroutine. This happens from catalogue/detail.pl, opac/opac-shelves.pl, opac/opac-tags.pl and virtualshelves/shelves.pl. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #152 from Jonathan Druart --- Jacek, I am interesting by your signoff if you think I am in the right direction with the L1 cache. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 David Roberts changed: What|Removed |Added CC||david.roberts@ptfs-europe.c ||om --- Comment #5 from David Roberts --- Tested this on a customer's system at 3.22. The duplicate libraries still display. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13371] Add filters to the supplier list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #53 from Jonathan Druart --- (In reply to Alex Arnaud from comment #52) > Patches rebased. A test is needed now Thanks Alex for having revived this amazing patch set ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13371] Add filters to the supplier list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #52 from Alex Arnaud --- Patches rebased. A test is needed now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi changed: What|Removed |Added Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi changed: What|Removed |Added Attachment #48935|0 |1 is obsolete|| --- Comment #150 from Tomás Cohen Arazi --- Created attachment 49029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49029&action=edit Bug 11998: Add a L1 cache for sysprefs Accessing to the cache for each call to C4::Context->preference might have an impact on performances. To avoid that this patch introduces a L1 cache (simple hashref). It will be populated by accessing the L2 cache (Koha::Cache). If a pref is retrieved 10x, the first one will get the value from the L2 cache, then the L1 cache will be check. To do so we will need to clear the L1 cache every time a page is loaded. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi changed: What|Removed |Added Attachment #48961|0 |1 is obsolete|| --- Comment #151 from Tomás Cohen Arazi --- Created attachment 49030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49030&action=edit Bug 11998: Clear L1 cache from psgi files Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi changed: What|Removed |Added Attachment #48933|0 |1 is obsolete|| --- Comment #148 from Tomás Cohen Arazi --- Created attachment 49027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49027&action=edit Bug 11998: Revert "Bug 13805: (Plack) Disable syspref cache" This reverts commit ca00f0ddaeb76106b4aa274fd1848844ae042f58. Bug 13805 fixes an installer bug by disabling the syspref cache. It was not a good idea, it introduced performance issues (see bug 13805 comment 14). Test plan: Test plan: 0/ Create a new database and fill the database entry in the koha conf with its name 1/ Go on the mainpage, you should be redirected to the installer 2/ Try to log in You should not get the login form again. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi changed: What|Removed |Added Attachment #48932|0 |1 is obsolete|| --- Comment #147 from Tomás Cohen Arazi --- Created attachment 49026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49026&action=edit Bug 11998: Do not clear syspref cache in psgi file This in only in koha.psgi, it has been introduced by bug 13815 but should not have been added by this patch. Removing it should not introduce any changes. Not that it won't impact debian packages. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi changed: What|Removed |Added Attachment #48931|0 |1 is obsolete|| --- Comment #146 from Tomás Cohen Arazi --- Created attachment 49025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49025&action=edit Bug 11998: Make HoldsQueue.t tests pass [TO REVERT] This patch should not be the way to make these tests pass. The prefs should not be updated using set_preference, it will modify the values in the cache. I have no idea how to make them pass using the correct way, please help :) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13371] Add filters to the supplier list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Alex Arnaud changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi changed: What|Removed |Added Attachment #48934|0 |1 is obsolete|| --- Comment #149 from Tomás Cohen Arazi --- Created attachment 49028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49028&action=edit Bug 11998: follow-up for the debian package psgi file Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi changed: What|Removed |Added Attachment #48930|0 |1 is obsolete|| --- Comment #145 from Tomás Cohen Arazi --- Created attachment 49024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49024&action=edit Bug 11998: Use C4::Context->preference in Koha/Schema/Result/Item.pm Otherwise some tests won't pass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi changed: What|Removed |Added Attachment #48929|0 |1 is obsolete|| --- Comment #144 from Tomás Cohen Arazi --- Created attachment 49023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49023&action=edit Bug 11998: Use t::lib::Mocks::mock_preference in tests Unless in t/db_dependent/Context.t where we want to test the cache behaviors. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13371] Add filters to the supplier list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Alex Arnaud changed: What|Removed |Added CC||alex.arn...@biblibre.com Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi changed: What|Removed |Added Attachment #48928|0 |1 is obsolete|| --- Comment #143 from Tomás Cohen Arazi --- Created attachment 49022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49022&action=edit Bug 11998: Use Koha::Cache to cache sysprefs At the moment, the sysprefs are only cache in the thread memory executing the processus When using Plack, that means we need to clear the syspref cache on each page. To avoid that, we can use Koha::Cache to cache the sysprefs correctly. A big part of the authorship of this patch goes to Robin Sheat. Test plan: 1/ Add/Update/Delete local use prefs 2/ Update pref values and confirm that the changes are correctly taken into account Signed-off-by: Chris Signed-off-by: Josef Moravec Tested with plack with syspref cache enabled, there is some time between setting the syspref and applying it, but it takes just one reload of page, it shouldn't be problem, should it? Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13371] Add filters to the supplier list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Alex Arnaud changed: What|Removed |Added Attachment #36759|0 |1 is obsolete|| --- Comment #51 from Alex Arnaud --- Created attachment 49021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49021&action=edit Bug 13371: Add a simple view This patch adds the ability to switch to a simple view if the complete view to too complex. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13371] Add filters to the supplier list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371
Alex Arnaud changed:
What|Removed |Added
Attachment #34439|0 |1
is obsolete||
--- Comment #50 from Alex Arnaud ---
Created attachment 49020
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49020&action=edit
Bug 13371: Move firstname and surname closer
On this way, they can be searched together ("my_firstname my_surname").
Signed-off-by: Paola Rossi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13371] Add filters to the supplier list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Alex Arnaud changed: What|Removed |Added Attachment #34436|0 |1 is obsolete|| --- Comment #47 from Alex Arnaud --- Created attachment 49017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49017&action=edit Bug 13371: change the filters wording Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13371] Add filters to the supplier list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Alex Arnaud changed: What|Removed |Added Attachment #34438|0 |1 is obsolete|| --- Comment #49 from Alex Arnaud --- Created attachment 49019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49019&action=edit Bug 13371: Fix filtering on numbers This patch fixes a weird bug on some instances. Since the sort is disabled on this table, we don't care on the type of the data. It should allow to filter on all columns of the table. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13371] Add filters to the supplier list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Alex Arnaud changed: What|Removed |Added Attachment #34434|0 |1 is obsolete|| --- Comment #45 from Alex Arnaud --- Created attachment 49015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49015&action=edit Bug 13371: Reintroduce the action buttons Confirm the the "New basket" and "Receive shipment" buttons work as before. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13371] Add filters to the supplier list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Alex Arnaud changed: What|Removed |Added Attachment #34437|0 |1 is obsolete|| --- Comment #48 from Alex Arnaud --- Created attachment 49018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49018&action=edit Bug 13371: List suppliers even if they don't have basket. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13371] Add filters to the supplier list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Alex Arnaud changed: What|Removed |Added Attachment #34435|0 |1 is obsolete|| --- Comment #46 from Alex Arnaud --- Created attachment 49016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49016&action=edit Bug 13371: Add a filter for opened baskets This patch adds a new link to filter on opened baskets only. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13371] Add filters to the supplier list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Alex Arnaud changed: What|Removed |Added Attachment #34433|0 |1 is obsolete|| --- Comment #44 from Alex Arnaud --- Created attachment 49014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49014&action=edit Bug 13371: Add filters on the supplier list view This patch adds the ability to filter the basket list depending on its creator name, basketgroup name, dates (creation, close), etc. Test plan: Go on the supplier list view (acqui/booksellers.pl) and confirm that the view is more ergonomic and the filters permit to the librarians to find a basket more easily than before. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 M. Tompsett changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 --- Comment #22 from M. Tompsett --- Created attachment 49013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49013&action=edit Bug 15870: Follow up to address comment #20 - $OUTPUT_AUTOFLUSH wasn't used to it was removed - Use English was removed since $OUTPUT_AUTOFLUSH wasn't not needed - transaction start and end were moved to subtests - prepare was moved outside loop - partial MARC agnosticism was added TEST PLAN - 1) apply patch 2) prove t/db_dependent/Filter_MARC_ViewPolicy.t 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16036] Making basket actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 --- Comment #6 from Owen Leonard --- Created attachment 49012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49012&action=edit Bug 16036 [Follow-up] Making basket actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and search for a vendor in Acquisitions which has at least one open basket. Confirm that the "View" and "Add to basket" buttons look correct and do not wrap when you make your browser window narrower. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16036] Making basket actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Owen Leonard changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16052] Styling buttons after MARC records have been staged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16052 --- Comment #2 from Owen Leonard --- I think these buttons look good. However, my desire for logical consistency makes me wonder whether they are the correct thing to use here. Usually we use buttons to signify an action which is performed "with" something: Submitting a form, usually. These buttons are navigational. If a plain link doesn't feel right, do we need to think about introducing a new style that is neither a plain link nor a button? And how would that fit in with other areas that have something similar? I also think we need to think about the use of "back" links, not just where but anywhere they are used. In this case "back" might more accurately be labeled "Stage more MARC records?" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
