[Koha-bugs] [Bug 14211] Clean up printing lists in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14211 --- Comment #1 from Owen Leonard --- We might want to hide the checkboxes and the hold links, but otherwise this looks like it has improved a lot. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Alex Sassmannshausen changed: What|Removed |Added Depends on||16086 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 [Bug 16086] Add Koha::Issue objects. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16025] Use Font Awesome icons on item types localization page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16025 Marc Véron changed: What|Removed |Added Attachment #49221|0 |1 is obsolete|| --- Comment #4 from Marc Véron --- Created attachment 49224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49224&action=edit Bug 16025 [Revised] Use Font Awesome icons on item types localization page The item types localization page uses a Glyphicon. This patch converts it to a Font Awesome icon. Also changed in this patch: "Delete" text has been added to the delete link, and a dummy "href" attribute has been added to the link so that it triggers the right kind of cursor. The deletion confirmation JavaScript has been edited to ignore the default click action. To test, apply the patch and go to Administration -> Item types. - Edit any existing item type and click the "Translate into other languages" link. - If there is not an existing translation, add one. Close the modal window and click the "Translate into other languages" link again to redisplay it. - Confirm that there is a "Delete" link next to your translation which is styled correctly. - Confirm that the behavior of the "Delete" link is correct both when confirming and when canceling. Revision adds the "actions" class to the table cell with the delete link to prevent a line break between the icon and the text. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16037] Printing a closed basket group doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16037 Marc Véron changed: What|Removed |Added Attachment #49070|0 |1 is obsolete|| --- Comment #4 from Marc Véron --- Created attachment 49231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49231&action=edit Bug 16037: Renaming 'Print basket group' as 'Export as PDF' To test: 1) Go to Acquisitions 2) Go to the basket groups for a vendor 3) Confirm that an open basket group has the option to 'Close and export as PDF' 4) Confirm that a closed basket group has the option to 'Export as PDF' 5) Confirm these buttons still work as expected Sponsored-by: Catalyst IT Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15997] Hold Ratios for ordered items doesn't count orders where AcqCreateItem is set to 'receiving'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15997 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16025] Use Font Awesome icons on item types localization page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16025 Owen Leonard changed: What|Removed |Added Attachment #48879|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 49221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49221&action=edit Bug 16025 [Revised] Use Font Awesome icons on item types localization page The item types localization page uses a Glyphicon. This patch converts it to a Font Awesome icon. Also changed in this patch: "Delete" text has been added to the delete link, and a dummy "href" attribute has been added to the link so that it triggers the right kind of cursor. The deletion confirmation JavaScript has been edited to ignore the default click action. To test, apply the patch and go to Administration -> Item types. - Edit any existing item type and click the "Translate into other languages" link. - If there is not an existing translation, add one. Close the modal window and click the "Translate into other languages" link again to redisplay it. - Confirm that there is a "Delete" link next to your translation which is styled correctly. - Confirm that the behavior of the "Delete" link is correct both when confirming and when canceling. Revision adds the "actions" class to the table cell with the delete link to prevent a line break between the icon and the text. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Nicole C. Engard changed: What|Removed |Added Attachment #49270|0 |1 is obsolete|| --- Comment #4 from Nicole C. Engard --- Created attachment 49271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49271&action=edit Bug 15630 - Make Edifact module pluggable Koha's EDIFACT module works great for many European vendors, but does not work will for US vendors, which have a much different interpretation of 'standard'. In fact, each vendor may require different arrangements of values in EDIFACT messages. It would be impossible to encompass all these requirements within Koha's EDIFACT module itself. Instead, we should allow the module to be pluggable, so versions of the module can be developed for vendors that require EDIFACT messages that don't conform to the standard set by Koha's EDIFACT module. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable Koha plugins 4) Install the Edifact stub plugin available at https://github.com/bywatersolutions/koha-plugin-edifact-stub 5) Edit the EDI Vendor account, assign the plugin to a Vendor EDI account 6) Test EDI functionality ( ORDER, INVOICE ), there should be no errors or changes to the EDIFACT message input or output Signed-off-by: Jason DeShaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16103] FK in deletedborrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16103 --- Comment #1 from Marcel de Rooy --- Created attachment 49312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49312&action=edit Bug 16103: Remove FK sms_provider_id in deletedborrowers This patch removes the FK constraint for sms_provider_id in table deletedborrowers. (We do not need FKs in that table.) It just corrects a newly added db revision in updatedatabase. If this is pushed before releasing master, no need to do anything more. Note that this key was not found in kohastructure and the DBIx schema. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16091] Can not delete branch category not used by any library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16091 Marc Véron changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16047 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16062] Remove CSS and images related to old "approve" and "deny" button styles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16062
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #3 from Jonathan Druart
---
What about
1126 td input.approve {
1127 background-color : #FFC;
1128 }
?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16032] Use Font Awesome icon in "note" styled divs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16032 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16099] Make name required field when creating subscription field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16099 --- Comment #1 from Aleisha Amohia --- Created attachment 49294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49294&action=edit Bug 16099: Make name required field when creating subscription field To test: 1) Notice behaviour when adding subcription field (Serials) without a name 2) Apply patch 3) Attempt to create subscription field without a name and click Save 4) Notice that you not cannot submit the form without adding the name Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #8 from sandbo...@biblibre.com --- Created attachment 49283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49283&action=edit Bug 14784 : Fix checkin message for debarred patrons If there is an overdue but finedays equals 0, then we have to see if the patron is debarred and if he was forever debarred. So we have to go through the same code a if it was a debarred patron with no overdue. Signed-off-by: barton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #81 from M. Tompsett --- Created attachment 49290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49290&action=edit Biblio tweak for MARCSUBJECT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16087] Add Koha::OldIssues Objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16087 --- Comment #1 from Alex Sassmannshausen --- Created attachment 49262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49262&action=edit Add Koha::OldIssue objects Add the objects. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16025] Use Font Awesome icons on item types localization page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16025 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15421] Show all available actions in reports toolbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15421 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored CC||aleishaamo...@hotmail.com Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979
--- Comment #30 from M. Tompsett ---
Comment on attachment 44210
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44210
[SIGNED-OFF] Bug 5979 - OPAC ISBD view has its own syspref
Review of attachment 44210:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5979&attachment=44210)
-
::: t/Biblio/Isbd.t
@@ +26,5 @@
> +use_ok('C4::Biblio');
> +}
> +
> +my $dbh = C4::Context->dbh;
> +# Start transaction
Perhaps this is better suited for t/db_dependent?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jonathan Druart changed: What|Removed |Added Blocks||16088 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088 [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14686] New menu option and permission for file uploading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #4 from Marcel de Rooy --- Created attachment 49259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49259&action=edit Bug 14686: Add Upload to Tools menu This patch makes sure that the added granular permissions work as advertised. Note: The field owner was not included in the Koha::Upload->get response. The code to verify if a user is allowed to delete an upload, is concentrated in the template now. When get returns a Koha::Object, this check could be relocated. Test plan: [1] Verify that the current user has permission for tools, or has at least upload_general_files. [2] Do you see Upload in the Tools menu? Follow the link. [3] Upload a permanent file (with a category). [4] Do you see the Delete button in the results form? [5] Make sure that another user has no permission to upload. [6] Login as that user and check the Tools menu. Try the URL [yourserver]/cgi-bin/koha/tools/upload.pl You should have no access to the upload form. [7] Enable upload_general_files for this user. Go to upload and search for the upload from step 3. You should not see a Delete button. [8] Enable upload_manage for this user. Search for the upload again. Delete the upload. [9] Go to upload via the Cataloguing editor (856$u plugin) or add parameter "plugin=1" to the URL. You should not see the Tools menu. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16087] New: Add Koha::OldIssues Objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16087 Bug ID: 16087 Summary: Add Koha::OldIssues Objects Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: alex.sassmannshau...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org This bug adds the prospect of Koha::OldIssue and Koha::OldIssues objects. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #18 from Jacek Ablewicz --- For some reason, deep copying of MARC frameworks structures with clone() is insanely slow: - clone() from the Clone module: 62 ms !!! - clone() from Clone::Fast: 21 ms - Storable dclone(): 16.9 ms - Storable thaw(freeze()): 17.0 ms - fetching framework from DB directly (caching disabled in GetMarcStructure()): 36.6 ms If I replace clone() with Storable dclone() in Koha::Cache, search speed is back to normal. Well, almost - looks like fetching the framework directly from L2 cache is still faster (12.8 ms, L2 = memcache) then getting a clone from L1 cache. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16089] Acquisitions -> Invoice broken by Bug 15084
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 Marc Véron changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |ve...@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #5 from Srdjan Jankovic --- Please disregard, previous message, error in reading -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15421] Show all available actions in reports toolbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15421 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16087] Add Koha::OldIssues Objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16087 Alex Sassmannshausen changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9069] Make it possible to import MARC21 authorities from VIAF into Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9069 Indranil Das Gupta changed: What|Removed |Added Assignee|gmcha...@gmail.com |indr...@gmail.com QA Contact||indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16088] New: Excessive CGI->new() calls hurting cache performace under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088 Bug ID: 16088 Summary: Excessive CGI->new() calls hurting cache performace under plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: a...@biblos.pk.edu.pl QA Contact: testo...@bugs.koha-community.org Under plack, CGI->new is overriden (in misc/plack/koha.psgi etc.) - we are flushing L1 syspref cache in there. C4::Language::getlanguage() subroutine calls CGI->new().. Problem is, getlanguage() is getting called surprisingly often in Koha (e.g., ~100 times per single catalogue search), and that hurts syspref caching performance under plack very significantly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16074] Making frequencies actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16074 Aleisha Amohia changed: What|Removed |Added Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16086] New: Add Koha::Issue objects.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 Bug ID: 16086 Summary: Add Koha::Issue objects. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: alex.sassmannshau...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org This bug raises the prospect of adding the Koha::Issue objects. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15486] Restrict number of holds placed by day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Nicole C. Engard changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | Change sponsored?|Seeking cosponsors |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16099] Make name required field when creating subscription field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16099 Owen Leonard changed: What|Removed |Added Attachment #49294|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 49310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49310&action=edit [SIGNED-OFF] Bug 16099: Make name required field when creating subscription field To test: 1) Notice behaviour when adding subcription field (Serials) without a name 2) Apply patch 3) Attempt to create subscription field without a name and click Save 4) Notice that you not cannot submit the form without adding the name Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Owen Leonard changed: What|Removed |Added Attachment #49059|0 |1 is obsolete|| --- Comment #49 from Owen Leonard --- Created attachment 49263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49263&action=edit [SIGNED-OFF] Bug 11904: New module Koha::Messages This patch provides a uniform way to send messages to user interface. It uses CGI::Session to store messages and allow to render them thanks to a Template::Toolkit plugin (Koha::Template::Plugin::Messages) and a template include file (messages.inc) This patch doesn't introduce the new template include file anywhere. It will require additional patches to make it work. To use it, simply call messages_set() in a Perl script or module, then put [% INCLUDE 'messages.inc' %] at the right place in the right template file. See POD documentation of Koha::Messages for more information. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16104] Warnings "used only once: possible typo" should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104
--- Comment #1 from Jonathan Druart
---
Created attachment 49314
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49314&action=edit
Bug 16104: Remove warnings "used only once: possible typo"
Since bug 11998, the following warnings are raised:
Name "Tie::Hash::FIELDS" used only once: possible typo at
/usr/share/perl/5.22/fields.pm line 135.
Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo at
/usr/share/perl/5.22/fields.pm line 135.
Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo at
/usr/share/perl/5.22/fields.pm line 135.
It comes from the Koha::Cache
103 if ( can_load( modules => { 'Cache::Memory' => undef } ) ) {
Test plan:
perl -wc C4/AuthoritiesMarc.pm
should return green
QA note: this may have an impact on performance but I have not found any other
workarounds.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 --- Comment #9 from Christopher Brannon --- Would love to see this in the May release as well. Will it make it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16071] Use Font Awesome icons in authority record duplicate warning dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16071 Jonathan Druart changed: What|Removed |Added Attachment #49230|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 49246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49246&action=edit Bug 16071: Use Font Awesome icons in authority duplicate warning dialog In the authority editor, when a duplicate record is suspected a dialog is shown. This patch updates the template to show Font Awesome icons in this dialog. Also changed: Using instead of in dialog so that it is correctly styled. Adding "popup" class to duplicate record link to indicate that a new window will be opened. To test, apply the patch and go to Authorities -> New record. - Use Z39.50 to import a record which is already in your catalog. - Save the record. Confirm that the duplicate warning dialog is styled correctly. - Confirm that both the "Save as new" and "Edit existing" buttons work correctly. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088 Jonathan Druart changed: What|Removed |Added Depends on|16044 | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16044 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 [Bug 16044] Define a L1 cache for all objects set in cache -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #155 from Colin Campbell --- Created attachment 49307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49307&action=edit patch to get logdir correctly Change to call to C4::Context to use the syntax required since bug 9006 applied -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16015] Cannot delete a group of libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16015 Jonathan Druart changed: What|Removed |Added CC||ve...@veron.ch --- Comment #7 from Jonathan Druart --- *** Bug 16091 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16105] New: Cache::Memory is loaded even if memcache is used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16105 Bug ID: 16105 Summary: Cache::Memory is loaded even if memcache is used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 11998, 16104 Cache::Memory is loaded and Koha::Cache::_initialize_memory is called even if a memcached cache has been correctly initialize, it does not make sense. It should only be initialize if needed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 [Bug 11998] Syspref caching issues https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104 [Bug 16104] Warnings "used only once: possible typo" should be removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #6 from Owen Leonard --- (In reply to Christopher Brannon from comment #5) > > I do not find this to be the case. Have you tried it with more than one > > report? > > Yes. You can see this in action here: http://screencast.com/t/TS06SJOhpyY I still can't reproduce this problem. Can you please post the SQL of a report which is showing the problem? Does the "Duplicate" option work from the "Actions" menu on the list of saved reports? > I would suggest a secondary Update button, such as "Update and Duplicate", > since we don't use the term Save on the screen. I think that should be its own enhancement request. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16032] Use Font Awesome icon in "note" styled divs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16032 Jonathan Druart changed: What|Removed |Added Attachment #49226|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 49248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49248&action=edit Bug 16032 - Use Font Awesome icon in "note" styled divs Several pages use to display important information about the functionality on the page. The style of this div can be modified to use Font Awesome, eliminating an image file. To test, apply the patch and clear your browser cache if necessary. - Go to Administration -> Authorized values. - Confirm that the "NOTE" box is styled correctly. - Edit an existing authorized value. - Confirm that the "NOTE" box is styled correctly. - Go to Tools -> Batch record deletion. - Submit a batch of biblionumbers. - Confirm that the "Reminder" box is styled correctly. - Go back and submit a batch of authority numbers. - Confirm that the "Reminder" box is styled correctly. - Go to Tools -> Batch record modification. - Submit a batch of biblionumbers. - Confirm that the "Reminder" box is styled correctly. - Go back and submit a batch of authority numbers. - Confirm that the "Reminder" box is styled correctly. - Check that there are no other references to "note.png" in the templates. Followed test plan, works as expected Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16078] Remove unused YUI CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16078 Marc Véron changed: What|Removed |Added Attachment #49220|0 |1 is obsolete|| --- Comment #11 from Marc Véron --- Created attachment 49222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49222&action=edit Bug 16078 [Revised] Remove unused YUI CSS The YUI CSS file "skin.css" is no longer relevant to the staff client templates and can be removed. Other references to YUI-related classes, with the exception of grids, can also be removed. This patch removes references in CSS to: .yuimenuitemlabel .yui-button .yui-menu-button ...and removes the "yui-skin-sam" class from two templates' body tag. skin.css is also included in a list of assets cached by the offline circulation page. It can be safely removed. To test, apply the patch and clear your cache if necessary. Look around and confirm that the style of the staff client is unchanged. Search for references to the listed classes and confirm that none are found. Revised patch squashes in the follow-up as well as a missing commit removing skin.css from staff-global.css. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16074] Making frequencies actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16074 --- Comment #6 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #5) > Should not we replace "Modify" with "Edit"? I've always thought that 'Modify' should be 'Edit' when making patches like this but I was never sure if 'Modify' was there for a reason or not. I can easily change them all though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16098] Making subscription fields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16098 --- Comment #1 from Aleisha Amohia --- Created attachment 49293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49293&action=edit Bug 16098: Making subscription fields actions buttons To test: 1) Go to Serials -> Add subscription fields 2) Confirm actions "Edit" and "Delete" now show as buttons and work as expected 3) When you make your browser narrow, confirm that the Actions column does not wrap 4) Confirm that you cannot sort on the Actions column Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16047] Software error on deleting a group with no category code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16047 Marc Véron changed: What|Removed |Added Attachment #49267|0 |1 is obsolete|| --- Comment #4 from Marc Véron --- Created attachment 49268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49268&action=edit Bug 16047 [Follow-up] Software error on deleting a group with no category code This follow-up take the original patch a little further, making category name required on the entry form as well. Without a category name there is no label in the interface when selecting a category. That doens't make any sense. Also changed on the group entry form: - Added "required" attribute to labels on required fields. - Changed "Update" submit button label to "Submit." - Added a "Cancel" link. - Added the "validated" class to the form so that our built-in validation script will process it (not strictly necessary but makes the validation appearance more consistent). Followed test plan, form displays and behaves as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16071] Use Font Awesome icons in authority record duplicate warning dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16071 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #49133|0 |1 is obsolete|| --- Comment #2 from Héctor Eduardo Castro Avalos --- Created attachment 49230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49230&action=edit [SIGNED-OFF]Bug 16071: Use Font Awesome icons in authority duplicate warning dialog In the authority editor, when a duplicate record is suspected a dialog is shown. This patch updates the template to show Font Awesome icons in this dialog. Also changed: Using instead of in dialog so that it is correctly styled. Adding "popup" class to duplicate record link to indicate that a new window will be opened. To test, apply the patch and go to Authorities -> New record. - Use Z39.50 to import a record which is already in your catalog. - Save the record. Confirm that the duplicate warning dialog is styled correctly. - Confirm that both the "Save as new" and "Edit existing" buttons work correctly. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 M. Tompsett changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16101 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16104] Warnings "used only once: possible typo" should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #2 from M. Tompsett --- *** Bug 16101 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16036] Making basket actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #11 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16103] FK in deletedborrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16103 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16091] Can not delete branch category not used by any library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16091 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Resolution|--- |DUPLICATE Status|Signed Off |RESOLVED --- Comment #3 from Jonathan Druart --- Do not forget to use http://splitter.koha-community.org/files to avoid duplication of work. *** This bug has been marked as a duplicate of bug 16015 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809
--- Comment #21 from Marcel de Rooy ---
Created attachment 49300
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49300&action=edit
Bug 15809: Redefine multi_param is CGI < 4.08 is used
On debian Jessie, the CGI version is >= 4.08
Since this version, the param method raise a warning
"CGI::param called in list context".
Indeed, it can cause vulnerability if called in list context
https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named-parameter
http://blog.gerv.net/2014/10/new-class-of-vulnerability-in-perl-web-applications/
There is a long journey to get rid of these warnings.
First I suggest to redefine the multi_param method when the CGI version
installed is < 4.08, it will allow us to move the wrong ->param calls to
->multi_param without waiting for everybody to upgrade.
The different ways to call these 2 methods are:
my $foo = $cgi->param('foo'); # OK
my @foo = $cgi->param('foo'); # NOK, will raise the warning
my @foo = $cgi->multi_param('foo'); #OK
$template->param( foo => $cgi->param('foo') ); # NOK, will raise the warning
# and vulnerable
$template->param( foo => scalar $cgi->param('foo') ); # OK
Signed-off-by: Mark Tompsett
Signed-off-by: Marcel de Rooy
Tested a call to multi_param with CGI < 4.08.
With reference to the comments on Bugzilla, this workaround is arguable,
but provides a base to move to multi_param. If we come up with a better
solution, it should be easy to adjust.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15672] Show descriptions instead of codes on the hold ratios report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15672 Owen Leonard changed: What|Removed |Added Attachment #48552|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 49228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49228&action=edit Bug 15672 [Revised] Show descriptions instead of codes on the hold ratios report This patch revises the hold ratios report so that it uses template plugins to display descriptions instead of codes for item holding branch, item home branch, item type, and shelving location. To test you should have multiple items on the hold ratio report (set the ratio to a small number to increase the number of results). It should include one or more items which have a shelving location set. View the hold ratios report and confirm that library names, shelving location descriptions, and item type descriptions are shown instead of codes. This revised patch steals from Bug 15560 to enable the correct display of multiple home libraries, holding libraries, shelving locations, item types, and call numbers. To properly test you should have records in your report which have multiple values for each of those fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16073] Circulation is completely broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16073 Tomás Cohen Arazi changed: What|Removed |Added Attachment #49203|0 |1 is obsolete|| --- Comment #5 from Tomás Cohen Arazi --- Created attachment 49274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49274&action=edit Bug 16073: (follow-up) Fix software error in circulation.pl Do not crash if the patron does not exist. Test plan: Access circ/circulation.pl?borrowernumber=42424242 you should get an error without this patch With this patch, you will get an empty patron detail page (should be fixed in another patch, but this behavior exists for a while) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14686] New menu option and permission for file uploading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Marcel de Rooy changed: What|Removed |Added Depends on|15756 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 [Bug 15756] Some tests for haspermission in C4::Auth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16015] Cannot delete a group of libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16015 Héctor Eduardo Castro Avalos changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16092 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 Olli-Antti Kivilahti changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16092] Use Font Awesome Icons when deleting branch category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Héctor Eduardo Castro Avalos changed: What|Removed |Added Assignee|oleon...@myacpl.org |hector.hecax...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #17 from Jacek Ablewicz --- I'm also trying to test this, but with kinda weird results so far.. Searching (medium-size dataset, 120k biblios, 300k items, 10-200-2 hits, XSLT processing enabled, testing with initial patch set - without the last 2 followups): 1) CGI + memcache - no measurable differences between patched/unpatched 2) CGI + Cache::Memory - it's ca 2x slower for the searches with 50+ hits With the 1st followup (attachment #49239), both CGI + memcache and CGI + Cache::Memory are 2x slower :( But why is that? Supposedly, it should be neutral re/ search speed (or even a bit faster on average). 2nd followup (#49240) just disables "safety measures" in the 2 most speed-sensitive places - an instant, enormous performance gain! Not very "step-by-step", though. Would it be safe enough/reasonably safe thing to do at this stage - I have no idea. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16096] Change 'Modify' to 'Edit' for OAI sets config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16096 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 sandbo...@biblibre.com changed: What|Removed |Added Attachment #49282|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16099] Make name required field when creating subscription field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16099 Aleisha Amohia changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #15 from Jonathan Druart --- (In reply to Jesse Weaver from comment #13) > Two tiny nitpicks: > > * Why do the commit messages say L2 instead of L1? It's a typo. > * Why is the variable named L1_cache instead of l1_cache or _l1_cache? I don't care about the name of the var, we can change it. I thought L1_cache was the more appropriate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16025] Use Font Awesome icons on item types localization page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16025 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16106] New: minor spelling correction to comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16106 Bug ID: 16106 Summary: minor spelling correction to comment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: gmcha...@gmail.com Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org I think the import of the comment in koha.psgi is that the utf8 flag is lost when running under Plack not that it is less securely attached. Correct usage to lose rather than loose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088 --- Comment #4 from Jonathan Druart --- Jacek, btw it's an excellent catch, thanks for that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16097] Making messages for subscription fields more user friendly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16097 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jacek Ablewicz changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16088 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jonathan Druart changed: What|Removed |Added Blocks|16088 | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16088 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088 [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16104] Warnings "used only once: possible typo" should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104
M. Tompsett changed:
What|Removed |Added
Attachment #49314|0 |1
is obsolete||
--- Comment #3 from M. Tompsett ---
Created attachment 49325
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49325&action=edit
Bug 16104: Remove warnings "used only once: possible typo"
Since bug 11998, the following warnings are raised:
Name "Tie::Hash::FIELDS" used only once: possible typo at
/usr/share/perl/5.22/fields.pm line 135.
Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo at
/usr/share/perl/5.22/fields.pm line 135.
Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo at
/usr/share/perl/5.22/fields.pm line 135.
It comes from the Koha::Cache
103 if ( can_load( modules => { 'Cache::Memory' => undef } ) ) {
Test plan:
perl -wc C4/AuthoritiesMarc.pm
should return green
QA note: this may have an impact on performance but I have not found any other
workarounds.
NOTE: I applied 15870 to master, got the error (-v 2 -c 5), applied 16104,
rebased it in front, error disappeared (still only -c 5), rebased it at the
end,
and signed off 16104.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15421] Show all available actions in reports toolbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15421 Marc Véron changed: What|Removed |Added Attachment #49286|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 49301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49301&action=edit Bug 15421: Show 'Duplicate' and 'Schedule' on Reports toolbar To test: 1) Go to Reports -> Use saved 2) Click 'Show' on the dropdown for any report 3) Confirm that 'Duplicate and 'Schedule' are now on the toolbar and work as expected Sponsored-by: Catalyst IT Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16059] Use Font Awesome icons in standard cataloging duplicate warning dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16059 Jonathan Druart changed: What|Removed |Added Attachment #49233|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 49243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49243&action=edit Bug 16059: Use Font Awesome icons in standard cataloging duplicate warning dialog In the standard MARC editor, when a duplicate record is suspected a dialog is shown. This patch updates the template to show Font Awesome icons in this dialog. Also changed: Using instead of in dialog so that it is correctly styled. Adding "popup" class to duplicate record link to indicate that a new window will be opened. To test, apply the patch and go to Cataloging -> New record. - Use Z39.50 to import a record which is already in your catalog. - Save the record. Confirm that the duplicate warning dialog is styled correctly. - Confirm that both the "Save as new" and "Edit items" buttons work correctly. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16062] Remove CSS and images related to old "approve" and "deny" button styles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16062 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16072] Include only one small spinner gif in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16072 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16100] Buttons in patron toolbar are styled differently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16100 Aleisha Amohia changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16090] New: FK branchcode in issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16090 Bug ID: 16090 Summary: FK branchcode in issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15044] add suggestion's date on Your purchase suggestions tab in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15044 Jonathan Druart changed: What|Removed |Added Attachment #49138|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 49216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49216&action=edit Bug 15044: Add date suggestion to OPAC suggestions table To test: 1) Log in to OPAC, go to your purchase suggestions (opac-suggestions.pl) 2) Confirm there is now a 'Suggested on' column displaying the date of your past suggestions 3) Add a new purchase suggestion and confirm that the date displayed is correct Sponsored-by: Catalyst IT Signed-off-by: Marjorie Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9069] Make it possible to import MARC21 authorities from VIAF into Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9069 --- Comment #1 from Stefano Bargioni --- The import process could save the VIAF ID, and eventually other IDs from (national) libraries whose records compose the VIAF record. IDs can be used in linked open data construction, e.g. in triples with owl:sameAs. In my library, we store the VIAF ID in auth tag 024. This could be the default of a syspref. Here is an example: viaf 58552590 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14294] Umbrella report for tracking improvements to File upload feature (see also 6874)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14294 --- Comment #7 from Marcel de Rooy --- Bug 14686 has been submitted now.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15672] Show descriptions instead of codes on the hold ratios report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15672 Marc Véron changed: What|Removed |Added Attachment #49228|0 |1 is obsolete|| --- Comment #8 from Marc Véron --- Created attachment 49234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49234&action=edit Bug 15672 [Revised] Show descriptions instead of codes on the hold ratios report This patch revises the hold ratios report so that it uses template plugins to display descriptions instead of codes for item holding branch, item home branch, item type, and shelving location. To test you should have multiple items on the hold ratio report (set the ratio to a small number to increase the number of results). It should include one or more items which have a shelving location set. View the hold ratios report and confirm that library names, shelving location descriptions, and item type descriptions are shown instead of codes. This revised patch steals from Bug 15560 to enable the correct display of multiple home libraries, holding libraries, shelving locations, item types, and call numbers. To properly test you should have records in your report which have multiple values for each of those fields. Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16097] Making messages for subscription fields more user friendly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16097 --- Comment #1 from Aleisha Amohia --- Created attachment 49292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49292&action=edit Bug 16097: Making messages for subscription fields more user friendly To test: 1) Go to Serials -> Add Subscription fields 2) Create a field, confirm message. 3) Attempt to create a new field that has the same name as an existing field, confirm message. 4) Create another field with a different name. Attempt to edit this field to have the same name as another field. Confirm message 5) Edit field (change name to something different) 6) Delete field, confirm message. 6) Turn off permissions to delete subcriptions ONLY. Attempt to delete a field, confirm message. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16083] Accept CLI params for the Makefile.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 Alex Sassmannshausen changed: What|Removed |Added Assignee|gmcha...@gmail.com |alex.sassmannshausen@ptfs-e ||urope.com Status|NEW |ASSIGNED Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16078] Remove unused YUI CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16078 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #80 from M. Tompsett --- Created attachment 49289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49289&action=edit Applying filtering to opac interface. Applying the filtering and then... Debugging opac/opac-detail.pl filtering Debugging opac/opac-ISBDdetail.pl more Debugging opac/opac-export.pl Tweak opac/opac-export.pl fix variable declarations, conditional assignments Debugging opac/opac-showmarc.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16086] Add Koha::Issue objects.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 Alex Sassmannshausen changed: What|Removed |Added Blocks||13895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 [Bug 13895] Add API routes for checkouts retrieval and renewal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16064] Remove use of image to indicate approval in tags moderation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16064 Jonathan Druart changed: What|Removed |Added Attachment #49127|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 49215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49215&action=edit Bug 16064 - Remove use of image to indicate approval in tags moderation This patch updates the tags moderation template to use text labels to mark tag moderation status, eliminating the use of an image file to signify approval. To test you should have some tags in each approval state: pending, approved, and rejected. - Apply the patch and go to Tools -> Tags. - Confirm that the status of each tag is clearly shown with a text label. Works as expected (Do not forget to set filter at the left to 'all' for testing) Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16084] log4perl.conf not properly set on packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16084 Jonathan Druart changed: What|Removed |Added Attachment #49238|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 49302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49302&action=edit Bug 16084: log4perl.conf not properly set on packages - Run koha-create to create an instance or just fire kohadevbox:ansible => FAIL: Notice the instance's koha-conf.xml points to __KOHA_CONF_DIR__ instead of /etc/koha/sites/kohadev/ on the log4perl entry. => FAIL: the /etc/koha/sites/kohadev/log4perl.conf contains __LOG_DIR__ instead of /var/log/koha/kohadev/ - Apply this patch and pick the koha-conf-site.xml.in and koha-create files - Create a new instance => SUCCESS: All placeholders are filled correctly. - Sign off Regards Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15672] Show descriptions instead of codes on the hold ratios report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15672 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16019] Remove unused blue.css
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16019 --- Comment #6 from Jonathan Druart --- Created attachment 49323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49323&action=edit Bug 16019: Add a warning in the update DB process if intranetcolorstylesheet=blue.css -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16019] Remove unused blue.css
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16019 Jonathan Druart changed: What|Removed |Added Attachment #48925|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 49324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49324&action=edit Bug 16019 - Remove unused blue.css This patch removes blue.css and one image which was used only by blue.css, css_header.png. To test, apply the patch and search Koha files for references to blue.css and css_header.png. There should be none. Signed-off-by: Frédéric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16100] Buttons in patron toolbar are styled differently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16100 --- Comment #3 from Owen Leonard --- Aleisha I'm glad you took this up, because it was bugging me too and I couldn't figure out what was causing it. Having now done some more digging I think we can fix this with CSS changes rather than markup changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16089] Acquisitions -> Invoice broken by Bug 15084
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 --- Comment #5 from Owen Leonard --- Another issue I just noticed, and I assume it is at least related. In the table of invoice details where it used to show the currency code Total tax exc. (USD) it now reads Total tax exc. (Koha::Acquisition::Currency=HASH(0x7587d38)) A separate issue, or the fix is incomplete? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15877] C4::Barcodes does not correctly calculate db_max for 'annual' barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15877 --- Comment #7 from Jonathan Druart --- Comment on attachment 49197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49197 [SIGNED-OFF] Bug 15877 - Unit tests Review of attachment 49197: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15877&attachment=49197) - A warning is raised by C4::Barcodes, use warning_is to catch it. ::: t/db_dependent/Barcodes.t @@ +53,5 @@ > +barcode => $barcodevalue > +} > +}); > + > +ok($barcodevalue eq $barcodeobj->db_max(), "(annual) First barcode saved to > db is equal to db_max" ); use is instead of ok. @@ +59,5 @@ > +$barcodevalue = $barcodeobj->next_value(); > +$barcodevalue = $barcodeobj->next_value($barcodevalue); > +$barcodevalue = $barcodeobj->next_value($barcodevalue); > +$barcodevalue = $barcodeobj->next_value($barcodevalue); > +$barcodevalue = $barcodeobj->next_value($barcodevalue); Why are you calling 4x this method? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849 --- Comment #8 from Jonathan Druart --- This patch will set it to NULL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14686] New menu option and permission for file uploading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Marcel de Rooy changed: What|Removed |Added Attachment #49259|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 49261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49261&action=edit Bug 14686: Add Upload to Tools menu This patch makes sure that the added granular permissions work as advertised. Note: The field owner was not included in the Koha::Upload->get response. The code to verify if a user is allowed to delete an upload, is concentrated in the template now. When get returns a Koha::Object, this check could be relocated. Test plan: [1] Verify that the current user has permission for tools, or has at least upload_general_files. [2] Do you see Upload in the Tools menu? Follow the link. [3] Upload a permanent file (with a category). [4] Do you see the Delete button in the results form? [5] Make sure that another user has no permission to upload. [6] Login as that user and check the Tools menu. Try the URL [yourserver]/cgi-bin/koha/tools/upload.pl You should have no access to the upload form. [7] Enable upload_general_files for this user. Go to upload and search for the upload from step 3. You should not see a Delete button. [8] Enable upload_manage for this user. Search for the upload again. Delete the upload. [9] Go to upload via the Cataloguing editor (856$u plugin) or add parameter "plugin=1" to the URL. You should not see the Tools menu. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 J Schmidt changed: What|Removed |Added CC||jschm...@switchinc.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16057] Use font awesome button for cleaning a batch of staged MARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16057 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #25 from Jesse Weaver --- I think that trying to protect cache users from themselves for complex structures is going to come at too high a cost of complexity or performance, based on the discussions we've been having so far... Auditing use of functions that call APIs that return large cached structures to either add clone()s as necessary or remove mutation will be more work but likely more benefit in the long run. We could look at using Hash::Util::lock_hash. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
