[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Arslan Farooq changed: What|Removed |Added CC||arslan...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #19 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15413] Adding colons where they should appear in forms etc to be consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15413 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #6 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16139] Renaming 'Unseen since' column in Inventory/Stocktaking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16139 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16141] Making 'Transfers to receive' action a button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16141 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16142] Making 'order' a button for new order suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16142 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #14 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15838] syspref SubscriptionDuplicateDroppedInput does not work for all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15838 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16145] Regression: Bug 15632 broke display of library name on circulation messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16145 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15009] Planning dropdown button in aqbudget can have empty line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 --- Comment #13 from Charles Farmer --- Created attachment 49601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49601&action=edit Bug 15009 - Adds unit tests for C4::Budget::GetBudgetAuthCats -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15009] Planning dropdown button in aqbudget can have empty line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 Charles Farmer changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16084] log4perl.conf not properly set on packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16084 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15877] C4::Barcodes does not correctly calculate db_max for 'annual' barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15877 --- Comment #9 from Nick Clemens --- (In reply to Jonathan Druart from comment #7) > Review of attachment 49197 [details] [review]: > use is instead of ok. ok (or should I say is ;-) ) > @@ +59,5 @@ > > +$barcodevalue = $barcodeobj->next_value(); > > +$barcodevalue = $barcodeobj->next_value($barcodevalue); > > +$barcodevalue = $barcodeobj->next_value($barcodevalue); > > +$barcodevalue = $barcodeobj->next_value($barcodevalue); > > +$barcodevalue = $barcodeobj->next_value($barcodevalue); > Why are you calling 4x this method? To set the value higher without using any constants. It's arbitrary to use 4, I just knew that triggered the problem for me each time and it felt more illustrative than 1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15877] C4::Barcodes does not correctly calculate db_max for 'annual' barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15877 Nick Clemens changed: What|Removed |Added Attachment #49197|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 49600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49600&action=edit Bug 15877 - Unit tests Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15877] C4::Barcodes does not correctly calculate db_max for 'annual' barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15877 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15928] Show unlinked guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15928 Nick Clemens changed: What|Removed |Added Attachment #49598|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 49599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49599&action=edit Bug 15928 - Show unlinked guarantor To test: 1 - Add guarantor data to patron account by typing it in but do not 'Set to patron' 2 - Note it is not displayed on patron details 3 - Apply patch 4 - Note the info is displayed 5 - Test that linked guarantors show as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15928] Show unlinked guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15928 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15928] Show unlinked guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15928 Nick Clemens changed: What|Removed |Added Attachment #48414|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 49598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49598&action=edit Bug 15928 - Show unlinked guarantor To test: 1 - Add guarantor data to patron account 2 - Note it is not displayed on patron details 3 - Apply patch 4 - Note the info is displayed 5 - Test that linked guarantors show as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13691] Add some selenium scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|gmcha...@gmail.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #77 from Nick Clemens --- (In reply to Jonathan Druart from comment #74) > > +use Koha::Database; > Not used. Removed > @@ +128,5 @@ > I don't understand this line, GetBorrowersToExpunge won't return a > DBIx::Class object, so the || > $patrons_to_delete->[$i]->get_column('borrowernumber'); part is not > necessary. > @@ +179,4 @@ > Same here. Both removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #75 from Nick Clemens --- Created attachment 49596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49596&action=edit Bug 10612 - Add ability to delete patrons with batch patron deletion tool This patch adds the ability to select a patron list for deletetion when using the Batch patron deletion/anonymization tool. It also adds buttons to the the patron lists table to access both the batch deletion and batch modification directly from the lists view. This is a squash of previous patches but now adds a patron_list_id parameter to C4::Members::GetBorrowersToExpunge and uses that routine to fetch patrons from a list. Test Plan: 1) Apply this patch 2) Create a list of patrons with the new Patron Lists feature 3) Try using the batch edit link form the lists table 4) Try using the batch delete link from the lists table 5) Verify previous functionality has not changed Signed-off-by: Owen Leonard Patron batches are correctly passed to the edit and delete pages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What|Removed |Added Attachment #48892|0 |1 is obsolete|| --- Comment #76 from Nick Clemens --- Created attachment 49597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49597&action=edit Bug 10612 [Follow-up] Combine and clarify menu items This follow-up patch for Bug 10612 moves all list operations into one menu while (hopefully) clarifying the labels for each. Also in this patch: Changed datatables sorting configuration to use the "nosort" attribute. To test, apply the patch and go to Tools -> Patron lists. - On a patron list with no patrons, confirm that the "Actions" menu lists "Add patrons," "Edit list," and "Delete list." - On a patron list containing one or more patrons, confirm that the "Actions" menu /also/ has these options: "Print patron cards," "Batch edit patrons," and "Batch delete patrons." - Confirm that the "actions" column is not sortable. - Test logging in as a user who has various combinations of permission to batch edit and batch delete. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What|Removed |Added Attachment #48831|0 |1 is obsolete|| --- Comment #19 from Nick Clemens --- Created attachment 49595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49595&action=edit Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page Currently if not logged in when browsing to http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl You are redirected to opac-auth.tt and SCOUserCSS and SCOUserJS are not loaded. This page passes through a parameter to the template to indicate this is an SCO login and appropriate CSS and JS should be loaded. Additionally this patch ensure that when loggin in using the form you are redirected to the sco-main.pl instead of the patron account page for the user. To test: 1 - Verify that normal login works on both staff and opac 2 - Verify that SCO link goes to login page if AutoSelfCheckAllowed is set to "Don't allow" 3 - Enter changes into SCOUserJS and SCOUserCSS and observe these are present on SCO log in page with AutoSelfCheck disabled 4 - Verify that a logged in opac user without permissions cannot access the self-checkout module 5 - Verify that AutoSelfCheckAllowed and associated system preferences function as expected 6 - Verify the AutoSelfCheck user is logged out if they attempt to visit another page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13691] Add some selenium scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Jonathan Druart changed: What|Removed |Added CC||jwea...@bywatersolutions.co ||m --- Comment #18 from Jonathan Druart --- This is still needed! We need it to add more tests and graph performances over the versions. I have updated the test plan to wget the last version. Please get involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13691] Add some selenium scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Jonathan Druart changed: What|Removed |Added Attachment #35797|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart --- Created attachment 49593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49593&action=edit Bug 13691: Add basic selenium script This script has been used to compare 3.16.x and 3.18.x performances on bug 13690. What it does: - Go on the mainpage and process a log in - Create a patron category - Create a patron - Add 3 items - check the 3 items out to the patron - check the 3 items in How to use it? $ wget https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar $ vim /etc/apt/sources.list.d/firefox.list deb http://packages.linuxmint.com debian import $ apt-get update $ apt-get install firefox $ sudo apt-get install xvfb $ SELENIUM_PATH=/home/koha/tools/selenium-server-standalone-2.53.0.jar $ Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null & $ DISPLAY=:1 java -jar $SELENIUM_PATH perl t/db_dependent/selenium/basic_workflow.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13691] Add some selenium scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Jonathan Druart changed: What|Removed |Added Attachment #49592|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart --- Created attachment 49594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49594&action=edit Bug 13691: Add changes for 3.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16140] Only clear L1 cache when needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 --- Comment #13 from Jonathan Druart --- To reinforce these numbers, I have reused the selenium scripts (bug 13691) used on https://wiki.koha-community.org/wiki/Benchmark_for_3.22: v3.22.00 CP main = 3.45 CP add patron category = 4.83 CP add patron = 4.72 CP add items = 15.17 CP checkout = 11.57 CP checkin = 9.53 before 11998 (fc640d2) CP main = 4.04 CP add patron category = 4.86 CP add patron = 4.87 CP add items = 16.38 CP checkout = 10.91 CP checkin = 10.99 master + 16140 + 16088 - intelligent flushing CP main = 3.42 CP add patron category = 4.17 CP add patron = 4.67 CP add items = 12.82 CP checkout = 8.36 CP checkin = 7.56 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13691] Add some selenium scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 --- Comment #15 from Jonathan Druart --- Created attachment 49592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49592&action=edit Bug 13691: Add changes for 3.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 --- Comment #1 from Owen Leonard --- Created attachment 49591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49591&action=edit Bug 16148 - Revised layout and behavior of marc modification template management This patch makes changes to the layout and behavior of the marc modification template management page to make it adhere better to common interaction patterns in Koha. - The initial view shows a list of templates rather than pre-selecting the first available template for editing. - A toolbar has been added with a "New template" button. - The initial view of existing templates has an actions menu containing menu items for 'Edit actions,' 'Duplicate,' and 'Delete.' It doesn't appear to be possible to edit an existing template's name. - The "Create template" form is no longer shown all the time. - Clicking the "New template" toolbar button triggers a modal with the form for creating a template. An existing template can be chosen to duplicate. - Choosing "Duplicate" from one of the template menus triggers the "New template" modal and preselects the corresponding template in the "duplicate" . - When editing actions for a template: - The breadcrumbs menu now reflects that a template is being modified. - The template name has been added as a heading. - A "New action" button appears in the toolbar - The "Edit" and "Delete" links now have a Bootstrap button style. - The add/edit form is now hidden by default. - Clicking "New action" or "edit" shows the add or edit form. - Clicking "Cancel" in the add/edit form hides the form. To test, apply the patch and clear your cache if necessary. - Got to Tools -> MARC modification templates - Test the "New template" button. - Confirm that new template creation works. - Confirm that duplicating a template works. - Test the menu items in the "Actions" menu: - "Duplicate" should trigger the new template modal and preselect the template you chose to duplicate. Confirm that the template is successfully duplicated. - "Delete" should prompt you to confirm the deletion. Test both cancelling and confirming this operation. - "Edit actions" should load the page for adding or editing actions to a template. Test the operations on this page: New action, edit, delete, changing action order. Note that this patch does not fix Bug 15814, so action descriptions must still not contain single quotes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088 --- Comment #8 from Jonathan Druart --- See benchmarks on bug 16140 for more details on this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16140] Only clear L1 cache when needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 --- Comment #12 from Jonathan Druart --- If I remove the intelligent caching: -Koha::Cache->get_instance->flush_L1_if_needed(); +Koha::Cache->flush_L1_cache(); I get: 58.30 (6.379+5.665+5.752+6.237+5.676+5.763+5.654+5.622+5.749+5.804) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16140] Only clear L1 cache when needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 --- Comment #11 from Jonathan Druart --- Now let's try to compare the idea of this first patch (Bug 16140: Only clear L1 cache when needed) and the one on bug 16088 (avoid excessive L1 flush): # 16044 + Bug 16140: Only clear L1 cache when needed 89.07 (9.606+8.805+8.416+9.685+8.629+9.392+8.956+8.631+8.281+8.670) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16140 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16140] Only clear L1 cache when needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16088 --- Comment #10 from Jonathan Druart --- No let's try to compare the idea of this first patch (Bug 16140: Only clear L1 cache when needed) and the one on bug 16088 (avoid excessive L1 flush): # 16044 + Bug 16140: Only clear L1 cache when needed 92.83 (11.043+8.967+8.916+9.276+9.709+8.686+9.119+9.055+8.850+9.205) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15009] Planning dropdown button in aqbudget can have empty line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 Charles Farmer changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16140] Only clear L1 cache when needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 --- Comment #9 from Jonathan Druart --- (In reply to Jonathan Druart from comment #8) > For the record, just retry the same on fc640d2 # just before bug 11998: > > 134.578 > (13.868+12.963+13.374+13.732+13.039+13.538+12.972+13.200+14.647+13.245) For 20! so to compare with comment 5 :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16140] Only clear L1 cache when needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 --- Comment #8 from Jonathan Druart --- For the record, just retry the same on fc640d2 # just before bug 11998: 134.578 (13.868+12.963+13.374+13.732+13.039+13.538+12.972+13.200+14.647+13.245) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16148] New: Revised layout and behavior of marc modification template management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Bug ID: 16148 Summary: Revised layout and behavior of marc modification template management Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/marc_modification_templates.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org The marc modification template management page is a sort of all-in-one interface with lots of different kinds of actions appearing at the same time. The screen is more complicated and (in my opinion) harder to approach initially than other pages which are divided into the same categories of interactions (list, add, edit). I propose a revision which shows and hides sections of the page so that each task can be given better focus. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12754] Add XSLT action to MARC modification templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 --- Comment #17 from Owen Leonard --- This will require rebasing since Bug 15867 was pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15814] Templates for MARC modification: Edit action does not work when Description contains '
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814 Owen Leonard changed: What|Removed |Added Assignee|gmcha...@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16140] Only clear L1 cache when needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 --- Comment #7 from Jonathan Druart --- Comment 5 was for 20 results. Here the time for 100 results: # Before 16044 262.99 (28.134+32.617+24.995+26.349+25.525+24.629+25.725+24.349+26.063+24.601) # After 16044 255.346 (24.791+25.713+24.151+25.569+26.977+23.780+25.005+23.722+30.042+25.596) # With 16140 219.02 (20.512+21.213+22.303+25.897+20.029+19.469+20.842+19.974+26.847+21.936) # With 16088 293.16 (28.449+28.928+27.206+28.886+28.276+29.433+32.831+30.136+28.632+30.329) # With 16140 and 16088 218.33 (21.278+23.491+20.935+21.529+21.854+19.016+21.408+23.760+21.577+23.485) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15441] columns_settings.pl: Circulation issues-table - cannot toggle checkin column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15441 --- Comment #2 from Nick Clemens --- Just poking around here, making the columns configurable is easily done, but the 'Renew or check in selected items' needs to be altered too if you can hide checkin. I am wondering if this would be better done as a syspref or as a staff permission? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16140] Only clear L1 cache when needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 --- Comment #6 from Jonathan Druart --- Created attachment 49590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49590&action=edit file used for benchmarking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16140] Only clear L1 cache when needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 --- Comment #5 from Jonathan Druart --- Quick benchmarks: % more /dev/null > /tmp/time; % export KOHA_INTRANET_URL=http://pro.koha-qa.vm % for i in {1..10}; do {time perl test.t > /dev/null} 2>> /tmp/time;done; echo $((`perl -pe 's/.*cpu ([^s]*) total/$1/' /tmp/time| tr '\n' '+'|sed 's/+$//'`)) # Before 16044 git reset --hard ffb17a2914c43e536155856a86fed374b7f26e9c # just before 16044 71.23 (7.389+6.932+6.966+6.937+6.941+6.663+7.827+7.237+7.075+7.259) # After 16044 git reset --hard origin/master # + last patch on 16044 72.09 6.881+7.236+8.261+7.005+7.975+6.909+6.816+6.860+7.043+7.100+% # With 16140 git bz apply 16140 63.60 (6.952+7.158+6.481+6.424+6.428+6.338+6.003+6.034+6.004+5.782) # With 16088 git reset --hard origin/master # + last patch on 16044 git bz apply 16088 73.43 (9.092+7.246+7.020+7.053+6.859+7.081+7.045+6.932+7.068+8.037) # With 16140 and 16088 git bz apply 16140 61.21 (7.403+6.036+6.127+5.881+5.674+5.971+5.779+5.901+5.643+6.794) The standard deviation is very high and it seems that my laptop is not stable enough to get correct values. Could someone confirm/contradict them? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16140] Only clear L1 cache when needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 --- Comment #4 from Jonathan Druart --- Created attachment 49589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49589&action=edit Bug 16140: ->flush_if_needed should be called on an instanciate Koha::Cache object -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088 Jonathan Druart changed: What|Removed |Added Attachment #49489|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 49588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49588&action=edit Bug 16088: [POC] Koha::CGI - Do no create a new CGI object to access the language -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088 --- Comment #7 from Jonathan Druart --- Just a rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 Owen Leonard changed: What|Removed |Added Attachment #49400|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 49587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49587&action=edit Bug 16111 [Revised] RSS feed for OPAC search results has wrong content type This patch fixing handling of OPAC search results feeds by correcting parameters passed to the script and making format checks consistent in the script. This patch also removes altogether references to a separate "atom" formatted feed, because the template for that feed displays no content (and never has). To test, apply the patch and perform a search in the OPAC. - Click the RSS link and confirm that the browser displays a feed with no errors. In Chrome the feed should display a "document tree" view. - Using the browser's developer console, verify that the content-type of the document is defined as "text/xml." - Validate the resulting feed at https://validator.w3.org/feed/ and confirm that it is valid. Revision adds suggestion from QA to accept the old 'rss2' parameter and treat it like an 'rss' parameter. Also changed: Corrected another place where 'rss2' was used in the template. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Owen Leonard changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #26 from Owen Leonard --- Rather than resolve the merge errors with Bug 15421, I resolve that my patch is made obsolete by Bug 15421. *** This bug has been marked as a duplicate of bug 15421 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15421] Show all available actions in reports toolbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15421 Owen Leonard changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #5 from Owen Leonard --- *** Bug 16000 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870 --- Comment #6 from Jonathan Druart --- (In reply to Julian Maurice from comment #5) > (In reply to Owen Leonard from comment #4) > > (In reply to Jonathan Druart from comment #3) > > > Julian, there is a "searchable" flag in the additional_fields table, I > > > think > > > you should use it to know if we want to display fields in the search form. > > > > Does this comment change whether this bug is ready for signoff? > > I don't think so, as the patch only display more data in results. It doesn't > change the form. > Jonathan, are you suggesting we *have to* display these searchable fields in > the form ? The current behavior (for subscriptions) is to not display fields which are not searchable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16038] Moving basketgroups actions into dropdown menus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16038 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |BLOCKED Depends on||11708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Owen Leonard changed: What|Removed |Added Blocks||16038 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16038 [Bug 16038] Moving basketgroups actions into dropdown menus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Owen Leonard changed: What|Removed |Added Blocks||13614 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 [Bug 13614] Replace usage of YUI on basket groups page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Status|NEW |ASSIGNED Depends on||11708 --- Comment #1 from Owen Leonard --- I have an idea for this but I'll wait for Bug 11708 and related bugs to go through before I work any more on it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Owen Leonard changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12832] Basketgroup printing doesn't support non-latin characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12832 Owen Leonard changed: What|Removed |Added Summary|Basketgroup printing|Basketgroup printing |doesn't support no latin|doesn't support non-latin |chars |characters -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16004] Replace items.new with items.new_status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 --- Comment #4 from Marcel de Rooy --- Created attachment 49586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49586&action=edit Bug 16004: [QA Follow-up] Tiny change for unit test and help file Unit test: Added a few lines to add the CPL branch the test depends on. Help file: Changed a few occurrences for new to new_status Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16004] Replace items.new with items.new_status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Marcel de Rooy changed: What|Removed |Added Attachment #48778|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy --- Created attachment 49585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49585&action=edit Bug 16004: Replace items.new with items.new_status The items.new column is badly named, the Koha::Item->new accessor will never returns this value, but the constructor will be called instead. This patch renames it with new_status to avoid the ambiguity. Test plan: 0/ Do not apply this patch 1/ Define some rules in the "Automatic item modifications by age" tool with at least one items.new field used 2/ Apply this patch 3/ Execute the update DB entry 4/ Reload the tool page and confirm that the changes have been taken into account Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16004] Replace items.new with items.new_status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16004] Replace items.new with items.new_status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13216] fix koha-shell to work with git/dev installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 --- Comment #4 from Marcel de Rooy --- This is an interesting change. I added an see-also to a blocked bug 13971 from myself. I was not yet satisfied with the solution there. Instead of passing the kohadir on all individual scripts like koha-shell here, koha-rebuild-zebra or even another one in the other see-also, imo we would benefit from a more general approach. The get_perl5lib function in koha-functions.sh would do (from 13971); we should forget the other function is_gitified. Instead of passing the alternative path all the time, why not once record it in koha-conf.xml ? What do you think ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13216] fix koha-shell to work with git/dev installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | Assignee|m...@kohaaloha.com |l...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13971] Adjusted locations in koha-rebuild-zebra for gitified instance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13216 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13216] fix koha-shell to work with git/dev installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13971 CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 Marcel de Rooy changed: What|Removed |Added Attachment #48047|0 |1 is obsolete|| --- Comment #13 from Marcel de Rooy --- Created attachment 49584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49584&action=edit Bug 14076: Do not use CGI->param in list context - opac-authorities-home.pl See bug 15809 for more info on why we should not use CGI->param in list context. Note: I have not found any places where several values for the same params are passed to this script but, just in case, this patch won't change this ability. Test plan: Do an authority search at the OPAC Test with several values of the form. Confirm that the results are always the same before and after this patch. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | Patch complexity|Trivial patch |Small patch Severity|trivial |enhancement CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 Marcel de Rooy changed: What|Removed |Added Attachment #48481|0 |1 is obsolete|| Attachment #48482|0 |1 is obsolete|| --- Comment #18 from Marcel de Rooy --- Created attachment 49583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49583&action=edit Bug 14304: RDA: OPAC display link in XSLT for 264 field to reflect Zebra indexing This patch add display link in XSLT for field 264/bug 14198 and reflect the Zebra index 'Provider' in detail page for OPAC screen. To test: follow previous test plan Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 --- Comment #17 from Marcel de Rooy --- Created attachment 49582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49582&action=edit Bug 14304: RDA: Intranet display link in XSLT for 264 field to reflect Zebra indexing This patch add display link in XSLT for 264 for bug 14198 and reflect the Zebra indexing 'Provider' in detail page for Intranet. Test plan 1) Update zebra index if no Provider: index exist 2) Do a search by Provider: 3) Goto detail page for a record with 264 4) Look that there no display link for 264 field. 5) Apply the patch 6) Reload the page, notice about the link, click the link an confirm the new index Provider works fine 7) Test with multiple records with 260 and 264, if you prefer follow test plan for bug 14734 8) Access an RCAA2 record just with 260 field 9) Notice that 260 has been updated with Provider index too. NOTE: The intention of Provider index -according with documentation- is to collect multiples fields including 260, 264, 270, and 257 Sponsored-by: Universidad de El Salvador Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Mirko Tietgen changed: What|Removed |Added CC||mi...@abunchofthings.net Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 --- Comment #7 from Mirko Tietgen --- Created attachment 49581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49581&action=edit Bug 14257 - Add show_attributes to GetPatronInfo This patch adds the ability to query the extended patron attributes via the ILSDI web service's GetPatronInfo service. Example: ilsdi.pl?service=GetPatronInfo&patron_id=3&show_attributes=1 A new element will be added if there are any attributes available from the database. We need to discuss the security implications of showing the attributes. At present it will allow querying of non-public (OPAC-visible) information. We might want to change this. Sponsored-By: Halland County Library Test plan: * Configure Koha to make use of extended attributes: Under 'Administration' -> 'Global system preferences' -> 'Patrons' tab -> Set 'ExtendedPatronAttributes' to 'Enable', press save and switch to 'Web services' tab. * Enable the ILS-DI service: Under 'Administration' -> 'Global system preferences' -> 'Web services' tab -> 'ILS-DI' section: Set 'ILS-DI' to 'Enable' and save. * Create an attribute to query: Under 'Administration' -> 'Patrons and circulation' -> 'Patron attribute types' press 'New patron attribute type': Enter a type code, like 'DOORCODE', description and assign a category that your test patron is a member of, then save. * Set value for test user: Locate the test patron, the new attribute should be listed under 'Additional attributes and identifiers'. Click 'Edit' and assign a value, like '1337' and save. * Query the ILS-DI service: http://127.0.1.1/cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=1&show_attributes=1 The output XML should have an element named 'attributes' containing the data you entered. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Mirko Tietgen changed: What|Removed |Added Attachment #49579|0 |1 is obsolete|| --- Comment #6 from Mirko Tietgen --- Created attachment 49580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49580&action=edit Bug 14257 - Add show_attributes to GetPatronInfo Added unit tests to for GetBorrowerAttributes and GetPatronInfo. Sponsored-By: Halland County Library Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Mirko Tietgen changed: What|Removed |Added Attachment #44864|0 |1 is obsolete|| Attachment #44865|0 |1 is obsolete|| --- Comment #5 from Mirko Tietgen --- Created attachment 49579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49579&action=edit Bug 14257 - Add show_attributes to GetPatronInfo This patch adds the ability to query the extended patron attributes via the ILSDI web service's GetPatronInfo service. Example: ilsdi.pl?service=GetPatronInfo&patron_id=3&show_attributes=1 A new element will be added if there are any attributes available from the database. We need to discuss the security implications of showing the attributes. At present it will allow querying of non-public (OPAC-visible) information. We might want to change this. Sponsored-By: Halland County Library Test plan: * Configure Koha to make use of extended attributes: Under 'Administration' -> 'Global system preferences' -> 'Patrons' tab -> Set 'ExtendedPatronAttributes' to 'Enable', press save and switch to 'Web services' tab. * Enable the ILS-DI service: Under 'Administration' -> 'Global system preferences' -> 'Web services' tab -> 'ILS-DI' section: Set 'ILS-DI' to 'Enable' and save. * Create an attribute to query: Under 'Administration' -> 'Patrons and circulation' -> 'Patron attribute types' press 'New patron attribute type': Enter a type code, like 'DOORCODE', description and assign a category that your test patron is a member of, then save. * Set value for test user: Locate the test patron, the new attribute should be listed under 'Additional attributes and identifiers'. Click 'Edit' and assign a value, like '1337' and save. * Query the ILS-DI service: http://127.0.1.1/cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=1&show_attributes=1 The output XML should have an element named 'attributes' containing the data you entered. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13216] fix koha-shell to work with git/dev installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 Mirko Tietgen changed: What|Removed |Added Attachment #43446|0 |1 is obsolete|| --- Comment #3 from Mirko Tietgen --- Created attachment 49578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49578&action=edit Bug 13216 - fix koha shell to accept alternative perl5lib paths To test: gitify an install run sudo koha-shell instance run env | grep PERL5LIB it should be set to /usr/share/koha/lib run sudo koha-shell -d /path/to/your/git/install run env | grep PERL5LIB it should be set to /path/to/your/git/install Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13216] fix koha-shell to work with git/dev installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 Mirko Tietgen changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16084] log4perl.conf not properly set on packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16084 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16084] log4perl.conf not properly set on packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16084 --- Comment #4 from Marcel de Rooy --- Created attachment 49577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49577&action=edit Bug 16084: [QA Follow-up] Correct three occurrences of __KOHA_CONF_DIR__ This bug correctly inserts substitutions for this variable. Four occurrences will now be changed. The line for log4perl.conf is now correct, but the three other changes point to a location that does not exist: /etc/koha/sites/$instance/zebradb. That should just be: /etc/koha/zebradb. All three cases concern the explain files. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16084] log4perl.conf not properly set on packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16084 Marcel de Rooy changed: What|Removed |Added Attachment #49302|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy --- Created attachment 49576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49576&action=edit Bug 16084: log4perl.conf not properly set on packages - Run koha-create to create an instance or just fire kohadevbox:ansible => FAIL: Notice the instance's koha-conf.xml points to __KOHA_CONF_DIR__ instead of /etc/koha/sites/kohadev/ on the log4perl entry. => FAIL: the /etc/koha/sites/kohadev/log4perl.conf contains __LOG_DIR__ instead of /var/log/koha/kohadev/ - Apply this patch and pick the koha-conf-site.xml.in and koha-create files - Create a new instance => SUCCESS: All placeholders are filled correctly. - Sign off Regards Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16084] log4perl.conf not properly set on packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16084 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Mirko Tietgen changed: What|Removed |Added CC||mi...@abunchofthings.net --- Comment #22 from Mirko Tietgen --- 16044 is in master now. So the first patch of this set is obsolete? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15902] Remove use of recordpayment in process_koc.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 Mirko Tietgen changed: What|Removed |Added CC||mi...@abunchofthings.net Status|Needs Signoff |Failed QA --- Comment #2 from Mirko Tietgen --- Adding the payment to the queue and then processing it works. Applying the payment directly does not work. Firebug shows a call to jquery.js over and over again. > http://192.168.2.11:8080/cgi-bin/koha/tools/background-job-progress.pl?jobID=1f05eb29131838b2ce1466eed03feebc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15903] Remove use of recordpayment in paycollect.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15903 Mirko Tietgen changed: What|Removed |Added Attachment #48340|0 |1 is obsolete|| --- Comment #2 from Mirko Tietgen --- Created attachment 49575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49575&action=edit Bug 15903 - Remove use of recordpayment in paycollect.pl Test Plan: 1) Apply this patch 2) Pay a fine via the "Pay amount" button 3) Payment should succeed. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15903] Remove use of recordpayment in paycollect.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15903 Mirko Tietgen changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14686] New menu option and permission for file uploading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #13 from Marcel de Rooy --- (In reply to Jesse Weaver from comment #12) > I strongly believe that for consistency with the rest of Koha (and due to > frustrations that changing the autogenerated schema files causes), that the > sub allows_add_by should be moved to a Koha:: module. The code has no tie to > the uploaded_files table anyway. Hi Jesse, I am all for consistency. But I moved this sub here instead of Upload.pm because it does not really fit into Upload's object design. Felt like polluting.. Not sure what frustrations you exactly mean, but imo they should not be a reason to block this patch. The custom section of the Results modules should be regenerated each update. The tie to the table is indirect but clear: the sub functionally determines if you have permission to add to the table. > Koha::UploadedFiles might be a good name, as that could later easily become > a Koha::Objects subclass, but that's just a suggestion. I referred to the Object[s] in the commit message, but doing the whole exercise was out of scope here. And just adding it for one sub did not attract me. So I am not convinced that we should move it. But if you really insist, I'd rather move it to Upload.pm or so? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/