[Koha-bugs] [Bug 16165] Include link to ILS-DI documentation page in ILS-DI system preference

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16165

--- Comment #1 from Katrin Fischer  ---
/cgi-bin/koha/ilsdi.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16165] New: Include link to ILS-DI documentation page in ILS-DI system preference

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16165

Bug ID: 16165
   Summary: Include link to ILS-DI documentation page in ILS-DI
system preference
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

There is no clue in the system preference about the nice ILS-DI documentation
once you turn it on. We should include a note and the link, similar to how we
do it for the web self checkout.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #49373|0   |1
is obsolete||

--- Comment #26 from Srdjan Jankovic  ---
Created attachment 49667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49667=edit
bug_15562: Removed Koha::Cache->get_instance()

There should be no cache singleton, full stop. If Koha is to move away
from .pl scripts that is.
As an interim measure Koha::Cache->get_instance() is replaced with
C4::Context->cache, in the vein of C4::Context->memcached. In that
respect it will continue to work in the singleton-ish way if context is
used as a singleton, but supports cache-per-context.

Koha::Handler::Plack->app_per_host() cache sysprefs using Context memcached.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #49372|0   |1
is obsolete||

--- Comment #25 from Srdjan Jankovic  ---
Created attachment 49666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49666=edit
bug_15562: Multi-host helper for plack installations

Sort of an apocalypse
* C4::Context->new() must be called with at least config file param.
  If you want current context, call C4::Context->current().
  C4::Context->some_method() will still work as is.
* Koha::Database->new_schema() now takes optional context param.
* C4::Context->set_context() and restore_context() are synched with
  database set_schema() and restore_schema().
  Created run_within_context() that wraps set_context() and
  restore_context() around code.
* Created Koha::Handler::Plack* to facilitate running same code within
  different (database) contexts.
* This initial version does not run with memcached turned on. Next patch
  will correct that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

--- Comment #24 from Srdjan Jankovic  ---
Created attachment 49665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49665=edit
bug_15562: Revert "Bug 13690: use Koha::Schema only when it's needed"

This reverts commit c52bc9756a5fa1e4f6bba7ce5c58124f150c5efc.

I don't see any place where we would use KOha::Database without wanting
Koha::Schema.
require Koha::Schema interferes with some plack setups - for some reason
it calls C4::Context->import() even when C4::Context is already used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #49370|0   |1
is obsolete||
  Attachment #49371|0   |1
is obsolete||

--- Comment #23 from Srdjan Jankovic  ---
Created attachment 49664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49664=edit
bug_15562: Use do() rather than system() to execute updatedatabase.pl from
installer.pl

That way:
* no external process is spawned
* code executes in the same perl process, which is required for plack
  multi-site

I have a dream. A dream that one day all code from .pl's will be in some
.pm's.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #93 from M. Tompsett  ---
This test plan supercedes comment #61. Just one tiny piece missing for 100%
code change testing.

Known failings: MARCXML stuff.
Known failings: LEADER fields.

TEST PLAN
-
 1) Backup your DB
 2) run the following SQL on your DB.
> UPDATE marc_subfield_structure set hidden=-8;
-- this should set EVERYTHING to hidden across the board.
 3) In staff client, set OPACXSLTDetailsDisplay to blank
 4) In OPAC, view any detail.
-- Normal view may mostly leak values still.
-- MARC view may leak values.
-- ISBD view may leak values.
 5) In staff client, set OPACXSLTDetailsDisplay to default
 6) In OPAC, view any detail.
-- same issues as step 4
-- 'View Plain' may leak too.
 7) 'Save record' -> 'Dublin Core'
 8) Apply this patch
 9) run koha qa test tools
-- should be fine
10) prove -v t/db_dependent/Filter_MARC_ViewPolicy.t
-- should pass
-- this proves Koha/Filter/MARC/ViewPolicy.pm tweaks too
11) In OPAC, view any detail.
-- Normal view:
   -- Material type comes from the LEADER field.
   -- Lists this is on will still display
   -- 'Tags from this library' will still display
   -- Item information in table will still display
  (THIS IS BEYOND SCOPE)
-- MARC view:
   -- Record number is leaked
  (THIS IS BEYOND SCOPE)
   -- 'View plain' leaks LEADER field.
-- ISBD view may leak field headings, but not values.
   (THIS IS BEYOND SCOPE)
12) In staff client, set OPACXSLTDetailsDisplay to blank
13) In OPAC, view any detail.
-- same kind of output as step 10
14) 'Save record' -> BIBTEXT
-- Should be next to nothing leaked.
15) 'Save record' -> Dublin Core
-- Should be the same or less leaked between the two versions.
-- (XML FILTERING IS BEYOND SCOPE)
16) Still trying to remember how I triggered the XSLT change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11998] Syspref caching issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Srdjan Jankovic  changed:

   What|Removed |Added

 CC||srd...@catalyst.net.nz

--- Comment #176 from Srdjan Jankovic  ---
Jonathan, I'm having problems with t/db_dependent/Context.t test 35 (line 97)
where you reverted logic. Can you please double check it for me, cause it looks
to me that the previous version was ok.
Much obliged.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16164] Making check expiration actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16164

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16164] Making check expiration actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16164

--- Comment #1 from Aleisha Amohia  ---
Created attachment 49663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49663=edit
Bug 16164: Making check expiration actions buttons

To test:
1) Go to Serials -> Check expiration
2) Put in a date where one or more subscriptions will expire prior to this date
3) Confirm that column heading is now 'Actions'
4) Confirm that Edit and Renew now show as font awesome buttons
5) Confirm that the buttons don't wrap on narrower browsers
6) Confirm the buttons still work as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16164] Making check expiration actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16164

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16164] New: Making check expiration actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16164

Bug ID: 16164
   Summary: Making check expiration actions buttons
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16163] Show message if there are no dictionary definitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16163

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16163] Show message if there are no dictionary definitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16163

--- Comment #1 from Aleisha Amohia  ---
Created attachment 49662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49662=edit
Bug 16163: Show message if there are no dictionary definitions

To test:
1) Go to Reports -> View dictionary
2) Ensure you have no definitions
3) A message should show saying 'There are no saved definitions. Add a
definition to the dictionary.'
4) Click the link to add a definition. Confirm this takes you to the form to
add a new definition.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16163] Show message if there are no dictionary definitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16163

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16163] New: Show message if there are no dictionary definitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16163

Bug ID: 16163
   Summary: Show message if there are no dictionary definitions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16162] Making dictionary 'Delete' a font awesome button

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162

--- Comment #1 from Aleisha Amohia  ---
Created attachment 49661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49661=edit
Bug 16162: Making dictionary 'Delete' a button

To test:
1) Go to Reports -> View dictionary
2) Confirm that the 'Delete definition' button now just says 'Delete' and is
styled as a font awesome button.
3) Confirm that the button does not wrap on narrower browsers.
4) Confirm that column heading is now 'Action'.
5) Confirm that button deletes as expected. (If you're wondering about the
missing confirm message upon delete, see Bug 16161.)

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16162] Making dictionary 'Delete' a font awesome button

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16162] Making dictionary 'Delete' a font awesome button

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16162] New: Making dictionary 'Delete' a font awesome button

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162

Bug ID: 16162
   Summary: Making dictionary 'Delete' a font awesome button
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13132] Adding confirm message for deleting a report from the reports toolbar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16161] Add confirm message when deleting dictionary definition

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16161

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16161] Add confirm message when deleting dictionary definition

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16161

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16161] Add confirm message when deleting dictionary definition

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16161

--- Comment #1 from Aleisha Amohia  ---
Created attachment 49660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49660=edit
Bug 16161: Confirm message when deleting definition

To test:

1) Go to Reports -> View dictionary
2) Attempt to delete definiton. Confirm that a confirm messages comes up and
works as expected.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16161] New: Add confirm message when deleting dictionary definition

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16161

Bug ID: 16161
   Summary: Add confirm message when deleting dictionary
definition
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13132] Adding confirm message for deleting a report from the reports toolbar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132

Aleisha Amohia  changed:

   What|Removed |Added

Summary|Report deletion |Adding confirm message for
   |confirmation doesn't work   |deleting a report from the
   |with DataTables pagination  |reports toolbar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13132] Report deletion confirmation doesn't work with DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13132] Report deletion confirmation doesn't work with DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #33203|0   |1
is obsolete||

--- Comment #8 from Aleisha Amohia  ---
Created attachment 49659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49659=edit
Bug 13132: Add confirm dialog for deleting reports from the reports toolbar

To test:

1) Go to Reports -> Use saved (or build a new one if you have none saved)
2) Click on the Actions drop down and confirm that when you click Delete from
here, a confirm message shows up. Click Cancel.
3) Click Show in the drop down menu
4) Click Delete in the Reports toolbar. Confirm you now get a confirm message.
Clicking Cancel will cancel the delete, and clicking OK deletes the report and
takes you to the saved reports page.

Spponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13132] Report deletion confirmation doesn't work with DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com

--- Comment #7 from Aleisha Amohia  ---
In Version 3.23, I can delete from the drop down menu from my list of guided
reports and a confirmation message will show up. However no confirmation
message shows up when I try to delete from the toolbar.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13628] clicking + on patron does nothing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13628

Aleisha Amohia  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED
 CC||aleishaamo...@hotmail.com

--- Comment #2 from Aleisha Amohia  ---
This is no longer valid on version 3.23. will set to Fixed :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15738] Summary page says item has no fines, but Fines tab says otherwise

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15738

--- Comment #4 from Aleisha Amohia  ---
Created attachment 49658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49658=edit
Problem still valid

Just having another look at this: even when my issue is overdue, fines says
'No'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669

--- Comment #6 from Aleisha Amohia  ---
(In reply to Marc Véron from comment #5)
> Hi Aleisha
> 
> The modal opens now fine from all pages with the members toolbar.
> However, if I add a message and click "Save", I'm not taken back to the page
> where I came from (what I would expect), but to the patron's checkout page.
> 
> This is due to a redirect in in circ/add_message.pl, line 55 that is hard
> coded to circulation.pl
> 
> It could take in account the referrer - what do you think about?

That is a great idea but I'm not really sure how to do it! Any suggestions? Or
does anyone else know how?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

--- Comment #8 from Katrin Fischer  ---
Just 2 notes for now:
- we need to update the documentation
- there is a typo hiding somewhere:
  FAILspelling
  comparision  ==> comparison

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16011] Remove $VERSION from our modules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011

--- Comment #34 from Brendan Gallagher  ---
(In reply to Jonathan Druart from comment #33)
> Created attachment 49633 [details] [review]
> Bug 16011 reintroduced VERSION variable needs declaration
> 
> $VERSION reintroduced into External/BakerTaylor.pm but was
> not declared. Causes tests to fail.
> Readd VERSION to the package vars
> 
> Signed-off-by: Jonathan Druart 

Last patch pushed - Mar 29th 2016

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #15 from Katrin Fischer  ---
I am sorry, conflicting again:

CONFLICT (content): Merge conflict in virtualshelves/sendshelf.pl
Auto-merging opac/opac-sendshelf.pl
CONFLICT (content): Merge conflict in opac/opac-sendshelf.pl
Auto-merging opac/opac-sendbasket.pl
CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl
Auto-merging opac/opac-downloadshelf.pl
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasket.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasket.tt
Auto-merging basket/sendbasket.pl
CONFLICT (content): Merge conflict in basket/sendbasket.pl

Will return to this asap when rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16151] can't place holds from lists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #5 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 Release. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

--- Comment #46 from Brendan Gallagher  ---
(In reply to Katrin Fischer from comment #45)
> I see 2 sign off lines - one from a QA team member. Should we move this PQA?

Last patch pushed (mar 29 - 2016)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13324] [DEPENDS_ON_13321] The fund values must be based on tax included values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #12 from Katrin Fischer  ---
Sadly, blocked as well by Failed QA on dependent bug 13321.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13323] Change the tax rate on receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #19 from Katrin Fischer  ---
Dependent bug 13321 is Failed QA. Please reset status once 13321 is ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663

Katrin Fischer  changed:

   What|Removed |Added

Summary|SCOUserCSS and SCOUserJS|SCOUserCSS and SCOUserJS
   |ignored on selfcheck login  |ignored on selfcheck login
   |page.   |page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #22 from Katrin Fischer  ---
I am not happy about the change of behaviour here. 

By using an if-else-construct where OPACUserCSS and OpacUserJS are in the else
branch this removes all the styling done to the login page per these
preferences. As the SCO login page looks like a normal OPAC page, this doesn't
feel right.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512

Jesse Weaver  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m

--- Comment #10 from Jesse Weaver  ---
Detailed notes:

SIP setup:
  a) Create a Koha patron with 'circulate' permissions and a username/password
matching a  in SIPconfig.xml (in the case of a git install, username/pw
term1/term1 works).
  b) Start the SIP server (adjusting paths as needed):
perl C4/SIP/SIPserver.pm ~/l/koha/etc/SIPconfig.xml

1) Apply this patch
2) Find a patron with outstanding fines
  JW: On my system this was cardnumber 23529000120056.
3) Run a patron information request using misc/sip_cli_emulator.pl using the
new -s option with the value "   Y  "
  JW: $ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1
-l term1 -t CR -m patron_information --patron 23529000120056 -s "   Y  " 
4) Note there is an AV field for each fee containing the description and amount
  JW: Confirmed for multiple fines (in output of above command):
...|AVHold waiting too long 292 5.00|AVPatron sucks 7.00|...
  JW: Note the "AVHold waiting too long 292 5.00" and "AVPatron sucks 7.00"
parts of the response.
5) Edit your sip config, add an av_field_template parameter to the login you
are using such as
av_field_template="TEST [% accountline.description %] [%
accountline.amountoutstanding | format('%.2f') %]"
  JW: The relevant line in SIPconfig.xml now looks like (I used %.3f for the
hell of it):

6) Restart your SIP server
7) Repeat the patron information request
8) Note your custom AV field is being used!^
  JW: Confirmed.
...|AVHold waiting too long 292 5.000|AVPatron sucks 7.000|...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512

Jesse Weaver  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #41238|0   |1
is obsolete||

--- Comment #9 from Jesse Weaver  ---
Created attachment 49657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49657=edit
Bug 14512 - Add support for AV field to Koha's SIP2 Server

Koha's SIP2 server should have support for the AV field ( field items ).
The biggest problem with this field is that its' contents are not really
defined in SIP2 protocol specification. All it says is "this field
should be sent for each fine item". Due to this, I think the contents of
the field need to be configurable at the login level, so that the
contents can be defined based on the SIP2 devices requirements for the
AV field.

Test Plan:
1) Apply this patch
2) Find a patron with outstanding fines
3) Run a patron information request using misc/sip_cli_emulator.pl using the
new -s option with the value "   Y  "
4) Note there is an AV field for each fee containing the description and amount
5) Edit your sip config, add an av_field_template parameter to the login you
are using such as
av_field_template="TEST [% accountline.description %] [%
accountline.amountoutstanding | format('%.2f') %]"
6) Restart your SIP server
7) Repeat the patron information request
8) Note your custom AV field is being used!

Signed-off-by: Chris Davis 

Signed-off-by: Jesse Weaver 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16160] t/db_dependent/www/search_utf8.t fails due to layout change

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160

--- Comment #6 from Tomás Cohen Arazi  ---
(In reply to Chris Cormack from comment #5)
> Hmm, It looks like it hangs if you have the wrong settings still.
> 
> prove t/db_dependent/www/search_utf8.t
> t/db_dependent/www/search_utf8.t .. Error GETing
> http://localhost:5001/cgi-bin/koha/mainpage.pl: Can't connect to
> localhost:5001 (Connection refused) at t/db_dependent/www/search_utf8.t line
> 117
> # Looks like your test exited with 111 before it could output anything.
> 
> 
> It's hung there ... 10 minutes now, that is with the patch applied.

That'd be bug 14158, for which I haven't written a patch! This one is simpler,
just a layout change, reflected on the WWW::Mechanize use.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793

Liz Rea  changed:

   What|Removed |Added

  Attachment #49655|0   |1
is obsolete||

--- Comment #23 from Liz Rea  ---
Created attachment 49656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49656=edit
Bug 15793 - UX of circulation patron search with long lists of returned
borrowers

Okay how about this:
This patch has no floating toolbar or names styled as links. I've removed the
radio buttons. The row is clickable and will redirect you to the user's page.

EDIT: This patch makes the cursor a pointer when hovering over the patrons. The
row will also be highlighted on hover to make it even clearer.
EDIT2: Removes unnecessary 'Select' button

To test:
1) Put in a patron search that will bring back a long list of patrons (ie the
letter 'a')
2) Select a patron by clicking anywhere on the row - confirm you are taken to
the correct patron page

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron 
Signed-off-by: Liz Rea 
Submit button removed, patron selection on this screen much better for long
lists (and short ones as well.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #49611|0   |1
is obsolete||

--- Comment #22 from Aleisha Amohia  ---
Created attachment 49655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49655=edit
Bug 15793 - UX of circulation patron search with long lists of returned
borrowers

Okay how about this:
This patch has no floating toolbar or names styled as links. I've removed the
radio buttons. The row is clickable and will redirect you to the user's page.

EDIT: This patch makes the cursor a pointer when hovering over the patrons. The
row will also be highlighted on hover to make it even clearer.
EDIT2: Removes unnecessary 'Select' button

To test:
1) Put in a patron search that will bring back a long list of patrons (ie the
letter 'a')
2) Select a patron by clicking anywhere on the row - confirm you are taken to
the correct patron page

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #45 from Katrin Fischer  ---
I see 2 sign off lines - one from a QA team member. Should we move this PQA?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15764] KOCT timestamp timezone problem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764

Katrin Fischer  changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #26 from Katrin Fischer  ---
*** Bug 8091 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8091] Firefox offline circ plugin recording wrong date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8091

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||katrin.fisc...@bsz-bw.de
 Status|NEW |RESOLVED

--- Comment #2 from Katrin Fischer  ---
I am hopeful this was fixed by bug 15764

*** This bug has been marked as a duplicate of bug 15764 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7663] batch add barcodes to a list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7663

Katrin Fischer  changed:

   What|Removed |Added

  Component|Tools   |Lists
 CC||katrin.fisc...@bsz-bw.de,
   ||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793

--- Comment #21 from Liz Rea  ---
Hi, 

Overall I like this - one small thing, if you click the "select" button at the
bottom it will say "borrower not found." I feel we should omit it. 

Owen? What do you think?

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14158] t/db_dependent/www/search_utf8.t hangs if error is returned

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14158

--- Comment #1 from Tomás Cohen Arazi  ---
There should be (at least) a reasonable timeout.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277

--- Comment #12 from Tomás Cohen Arazi  ---
I think we should just remove the GRS-1 portion, and set it back to signed-off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16160] t/db_dependent/www/search_utf8.t fails due to layout change

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #5 from Chris Cormack  ---
Hmm, It looks like it hangs if you have the wrong settings still.

prove t/db_dependent/www/search_utf8.t
t/db_dependent/www/search_utf8.t .. Error GETing
http://localhost:5001/cgi-bin/koha/mainpage.pl: Can't connect to localhost:5001
(Connection refused) at t/db_dependent/www/search_utf8.t line 117
# Looks like your test exited with 111 before it could output anything.


It's hung there ... 10 minutes now, that is with the patch applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16160] t/db_dependent/www/search_utf8.t fails due to layout change

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16160] t/db_dependent/www/search_utf8.t fails due to layout change

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160

--- Comment #4 from Tomás Cohen Arazi  ---
For non kohadevbox:ansible users willing to test this, you can run it on a
regular dev setup, provided you already set this environment variables (adjust
values to your setup):

export KOHA_USER=koha_kohadev
export KOHA_PASS=password
export KOHA_INTRANET_URL=http://localhost:8080
export KOHA_OPAC_URL=http://localhost:80

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16160] t/db_dependent/www/search_utf8.t fails due to layout change

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160

--- Comment #3 from Tomás Cohen Arazi  ---
Tests are not failing with the patch, false alarm. But it is worth pushing
ASAP, becasue we have a useless jenkins right now, due to this tests hanging
forever.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16160] t/db_dependent/www/search_utf8.t fails due to layout change

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 49654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49654=edit
Bug 16160: Fix t/../www/search_utf8.t for layout change

Some of the include files in tools/manage-marc-import.tt introduced a new form
object
so the form index for the tests needed to be changed to match the new layout.

While testing this I also found that due to the new record_type input in
stage-marc-import.tt
the tests would fail if run on an instance with already imported stuff (i.e.
the import id
was defaulting to zero). This might have been the cause of some random failures
in jenkins
befire we started to DROP / re-CREATE the DB.

To test:
- Run (on kohadevbox:ansible)
  $ sudo koha-shell kohadev
  $ cd kohaclone
  $ prove t/db_dependent/www/search_utf8.t
=> FAIL: mainsubmitform is not found, and the tests hang
- Apply the patch
- re-run the tests:
 $ prove t/db_dependent/www/search_utf8.t
=> SUCCESS: Tests now pass!
- Sign off

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16160] t/db_dependent/www/search_utf8.t fails due to layout change

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277

Jesse Weaver  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m

--- Comment #11 from Jesse Weaver  ---
Tomás, this looks to be entirely due to the "lex" definition in GRS-1, which I
think is deprecated. We can choose to either ignore the warning or remove the
index, IMO.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #38 from Jesse Weaver  ---
Patches rebased.

Just noticed that "bug" isn't capitalized in some of the commit messages,
whoever commits/pushes should probably fix that. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #44013|0   |1
is obsolete||

--- Comment #36 from Jesse Weaver  ---
Created attachment 49652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49652=edit
Bug 14504: (QA followup) use TestBuilder, remove do_not_commit

Use t::lib::TestBuilder in t/db_dependent/Items_DelItemCheck.t

Remove the option 'do_not_commit' from C4::Items::DelItemCheck.

Whitespace cleanup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #43789|0   |1
is obsolete||

--- Comment #35 from Jesse Weaver  ---
Created attachment 49651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49651=edit
bug 14504: use C4::Items::DelItemCheck in delete_items.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #45789|0   |1
is obsolete||

--- Comment #37 from Jesse Weaver  ---
Created attachment 49653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49653=edit
bug 14504: (QA followup) fixing DelItemCheck arguments

Remove $dbh as argument to C4::Items::DelItemCheck
and C4::Items::ItemSafeToDelete, also change all
calls to these functions throughout the codebase.

Also remove remaining reference to 'do_not_commit' in
t/db_dependent/Items_DelItemCheck.t

Fixed doubled "$$" in C4/ImportBatch.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #43788|0   |1
is obsolete||

--- Comment #34 from Jesse Weaver  ---
Created attachment 49650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49650=edit
bug 14504: split logic from DelItemCheck() into ItemSafeToDelete()

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #43533|0   |1
is obsolete||

--- Comment #33 from Jesse Weaver  ---
Created attachment 49649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49649=edit
Bug 14504: (QA followup)

* Fix POD warning.
* Remove redundant 'use stric' and 'use warnings'
* Remove $VERSION and --version option.
* Remove --dry-run option
* Split test for --help and check for @criteria into two separate pod2usage
calls,
enabling -msg on the latter.
* Fix 'target_tiems' typo.
* Test for holds on items to be deleted.
* Fix whitespace
* Fix test for holds.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #42978|0   |1
is obsolete||

--- Comment #32 from Jesse Weaver  ---
Created attachment 49648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49648=edit
Bug 14504: Add delete_items.pl: a command line batch deletion tool

http://bugs.koha-community.org/show_bug.cgi?id=14504

Signed-off-by: Heather Braum 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Jesse Weaver  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Jesse Weaver  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m

--- Comment #31 from Jesse Weaver  ---
To add my own 2 cents: 

The primary reason that these patches modify 10 different files is that it was
asked, as part of the QA process, that the $dbh parameter be removed from
DelItemCheck. (Which requires that all of the connecting files be modified.)

While the alternate solution is reasonable, it is not an existing coding
pattern in Koha, and is none of this is in the coding guidelines.

Barton and I will be working on rebasing the patches, but please keep the above
in mind.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16160] t/db_dependent/www/search_utf8.t fails due to layout change

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160

--- Comment #1 from Tomás Cohen Arazi  ---
I mark this as major because a POC of the fix made some UTF-8 related tests
fail, and need help debugging it (ran out of time today).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7663] batch add barcodes to a list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7663

--- Comment #1 from Nicole C. Engard  ---
Well, it's only 4 years later but I was just asked for this again :) hehe

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16160] New: t/db_dependent/www/search_utf8.t fails due to layout change

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160

Bug ID: 16160
   Summary: t/db_dependent/www/search_utf8.t fails due to layout
change
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: tomasco...@gmail.com
QA Contact: gmcha...@gmail.com

Aparently, a layout change made the tests fail. To reproduce:

- Run (on kohadevbox:ansible)
  $ sudo koha-shell kohadev
  $ cd kohaclone
  $ prove t/db_dependent/www/search_utf8.t
=> FAIL: mainsubmitform is not found, and the tests hang

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15008] Add custom HTML areas to circulation and reports home pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15008

--- Comment #6 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #4)
> Would not it better to add an admin page to manage these different areas to
> custom?
I would tend to agree but think that's a separate bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #49568|0   |1
is obsolete||

--- Comment #44 from Jacek Ablewicz  ---
Created attachment 49647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49647=edit
Bug 16044: Populate the L1 cache when L2 is fetched

The whole patch set is not very pertinent if the L1 cache is not
populated when L2 is fetched!
This patch fixes this inconsistency.

Signed-off-by: Jesse Weaver 
Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16151] can't place holds from lists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #49623|0   |1
is obsolete||

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 49646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49646=edit
Bug 16151: Restore the ability to place holds from lists at the OPAC

This patch fixes a bug introduced by bug 14544.
Holds can not be placed from lists at the OPAC, the action results in a
crash:
Can't call method "field" on an undefined value at
/home/koha/src/C4/Items.pm line 1504.
 at /home/koha/src/opac/opac-reserve.pl line 601

Before 14544, the checkboxes were named 'ACT-$BIBNUM', something like
REM-4242. Now we can retrieve the biblionumber from the value.

Test plan:
Select a public list
check some titles and click on the 'Place hold' link
you should able to process the reservation

Signed-off-by: Marc Véron 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16151] can't place holds from lists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16159] New: guarantor section missing ID on patron add form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

Bug ID: 16159
   Summary: guarantor section missing ID on patron add form
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 49645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49645=edit
code

See attached. The Guarantor section doesn't have an ID.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16158] GetAuthorisedValues should not be called inside a loop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16158

--- Comment #1 from Jonathan Druart  
---
Created attachment 49644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49644=edit
Bug 16158: Move GetAuthorisedValues outside the loop

In catalogue/detail.pl and catalogue/moredetail.pl, the
GetAuthorisedValues subroutine is called once per item. It's not needed,
only 1 call is enough.

Test plan:
Edit item and view a catalogue record.
The withdrawn, lost and damaged values should be correctly
displayed/saved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16158] GetAuthorisedValues should not be called inside a loop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16158

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #44811|0   |1
is obsolete||

--- Comment #8 from Héctor Eduardo Castro Avalos  ---
Created attachment 49642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49642=edit
Bug 15172: Serial enumchron/sequence not visible when returning/checking in
Items

Displays the items.enumchron-column in returns.pl when checking in Items.

Rewording commit

To test:
-Checkout a barcode for serial with items generated in
Serials >  New subscription or item in DB with items.enumchron-column
-Checkin the same barcode, the table Checked-in items will appear without
information about "Publications details (Vol. 400, No. 32)"
-Apply patch
-Checkout and checkin another item of the same serial title
-Notice about the Vol. 400, No. 32 below the serial title.

Signed-off-by: Hector Castro 
items.enumchron-column display successful in returns.pl (Home>Circulation>
Check in)
NOTE: Patch rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #45334|0   |1
is obsolete||

--- Comment #9 from Héctor Eduardo Castro Avalos  ---
Created attachment 49643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49643=edit
Bug 15172: (follow-up)Serial enumchron/sequence not visible when
returning/checking in Items

Display br and span tag only if the value enumchron exists.

To test
-Apply patches
-Follow the previous test plan
-Checkin whichever material (e.g., book) without sequence or enumchrom
-Open up source code for checkin page, search under title and
verify that b and span tags do not appear

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16157] C4::Koha::GetAuthorisedValues should not handle the selected option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16157

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16158


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16158
[Bug 16158] GetAuthorisedValues should not be called inside a loop
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16158] New: GetAuthorisedValues should not be called inside a loop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16158

Bug ID: 16158
   Summary: GetAuthorisedValues should not be called inside a loop
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 16157

There are no needs to call this subroutine inside a loop (bug 16157 has removed
the selected flag).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16157
[Bug 16157] C4::Koha::GetAuthorisedValues should not handle the selected option
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16157] C4::Koha::GetAuthorisedValues should not handle the selected option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16157

--- Comment #1 from Jonathan Druart  
---
Created attachment 49641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49641=edit
Bug 16157: Move the selected flag from GetAuthorisedValues to the templates

>From C4::Koha::GetAuthorisedValues

# TODO: the "selected" feature should be replaced by a utility function
# somewhere else, it doesn't belong in here. For starters it makes
# caching much more complicated. Or just let the UI logic handle it, it's
# what it's for.

Indeed, it's not a job for a subroutine, the template should take care of that.
Note that a perf gain could be won with this patch \o/

Test plan:
- Edit an itemtype and check the value of the "Search category" dropdown list
- Edit a patron attribute type and check the value of the "Class" dropdown list
- Detail for a catalogue record, the Status column should be correctly
  populated if items are damaged and/or lost
- Item details for a catalogue record, the lost, damaged and withdrawn
  value should be correctly displayed
- Edit a patron, the "street type" should be correctly selected
- Create a patron attribute type linked to an authorised value list.
- Edit a patron, set a value for this attribute, edit it again. The
  correct value should be selected.
- Search for subscriptions. The 'Location' dropdown list should behave
  correctly (select the entry you have choosen before, etc.)
- Edit a subscription, the location dropdown list should select the
  correct value.
- Edit and view a suggestion with a 'reason for suggestion' set (you
  should have at least 1 OPAC_SUG AV defined)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16157] C4::Koha::GetAuthorisedValues should not handle the selected option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16157

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16041] StaffAuthorisedValueImages & AuthorisedValueImages preferences - impact on search performace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16041

--- Comment #2 from Jonathan Druart  
---
I meant, at least for the regression that bug 11842 could have caused.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16041] StaffAuthorisedValueImages & AuthorisedValueImages preferences - impact on search performace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16041

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16044
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
It seems that the use of a three-level cache could have fixed this issue. Could
you confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16041

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16157] New: C4::Koha::GetAuthorisedValues should not handle the selected option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16157

Bug ID: 16157
   Summary: C4::Koha::GetAuthorisedValues should not handle the
selected option
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

>From C4::Koha::GetAuthorisedValues

# TODO: the "selected" feature should be replaced by a utility function
# somewhere else, it doesn't belong in here. For starters it makes
# caching much more complicated. Or just let the UI logic handle it, it's
# what it's for.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16092] Fix error dialog and use Font Awesome Icons when deleting branch group

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #49639|0   |1
is obsolete||

--- Comment #6 from Héctor Eduardo Castro Avalos  ---
Created attachment 49640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49640=edit
Bug 16092: Fix error dialog and introduce the Font Awesome icons when delete a
branch category

Also change admin/branch.pl   type => 'error' to type => 'alert' to fit
with wiki


To test:
1) Go to Admin -> Libraries and groups
2) Try to delete a library with patrons and bib items
3) See the error message in yellow
4) Try to delete a branch category/group without any library attached
   to it
5) Apply patch and repeat steps 1 to 4. Notice about the changes
6) Test buttons Yes, delete and No, do not delete and verify that they
   work as expected

Signed-off-by: Marc Véron 

NOTE: Patch rebased and reword title according with QA comment 4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16092] Fix error dialog and use Font Awesome Icons when deleting branch group

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Depends on|16091   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16091
[Bug 16091] Can not delete branch category not used by any library
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16091] Can not delete branch category not used by any library

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16091

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Blocks|16092   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092
[Bug 16092] Fix error dialog and use Font Awesome Icons when deleting branch
group
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16092] Fix error dialog and use Font Awesome Icons when deleting branch group

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16092] Fix error dialog and use Font Awesome Icons when deleting branch group

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

Summary|Use Font Awesome Icons when |Fix error dialog and use
   |deleting branch group   |Font Awesome Icons when
   ||deleting branch group
 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16092] Use Font Awesome Icons when deleting branch group

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #49281|0   |1
is obsolete||

--- Comment #5 from Héctor Eduardo Castro Avalos  ---
Created attachment 49639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49639=edit
Bug 16092: Fix error dialog and introduce the Font Awesome icons when delete a
branch category

Also change admin/branch.pl   type => 'error' to type => 'alert' to fit
with wiki


To test:
1) Apply on top 16047 and 16091
1) Go to Admin -> Libraries and groups
2) Try to delete a library with patrons and bib items
3) See the error message in yellow
4) Try to delete a branch category/group without any library attached
   to it
5) Apply patch and repeat steps 1 to 4. Notice about the changes
6) Test buttons Yes, delete and No, do not delete and verify that they
   work as expected

Signed-off-by: Marc Véron 

NOTE: Patch rebased and reword title according with QA comment 4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15323] ./t/Prices.t fails without a valid database

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323

Colin Campbell  changed:

   What|Removed |Added

 CC||colin.campbell@ptfs-europe.
   ||com

--- Comment #6 from Colin Campbell  ---
On current master running prove t/Prices.t with the database up or down I get:

~/kohaclone$ prove t/Prices.t
t/Prices.t .. 1/16 DBIx::Class::Storage::DBI::_warn_undetermined_driver(): This
version of DBIC does not yet seem to supply a driver for your particular RDBMS
and/or connection method ('Mock'). While we will attempt to continue anyway,
the results are likely to be underwhelming. Please upgrade DBIC, and if this
message does not go away, file a bugreport including the following info:
{
  DBD => "DBD::Mock",
  DBD_VER => "1.45",
  DBIC_DRIVER => "DBIx::Class::Storage::DBI",
  DBIC_DSN => "DBI:Mock:",
  DBIC_VER => "0.082820",
  DBI_VER => "1.633"
}
DBIx::Class::Storage::DBI::sql_maker(): Your storage class
(DBIx::Class::Storage::DBI) does not set sql_limit_dialect and you have not
supplied an explicit limit_dialect in your connection_info. DBIC will attempt
to use the GenericSubQ dialect, which works on most databases but can be (and
often is) painfully slow. Please file an RT ticket against
'DBIx::Class::Storage::DBI' at /home/cc/kohaclone/Koha/Objects.pm line 150
DBI bind_columns: invalid number of arguments: got handle + 0, expected handle
+ between 1 and -1
Usage: $h->bind_columns(\$var1 [, \$var2, ...]) at
/usr/share/perl5/vendor_perl/DBIx/Class/Storage/DBI/Cursor.pm line 129.
# Child (Configuration 1: 0 0) exited without calling finalize()

#   Failed test 'Configuration 1: 0 0'
#   at /usr/share/perl5/vendor_perl/Test/Builder.pm line 279.
# Looks like you planned 16 tests but ran 5.
# Looks like you failed 1 test of 5 run.
# Looks like your test exited with 255 just after 5.
t/Prices.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 12/16 subtests 

Test Summary Report
---
t/Prices.t (Wstat: 65280 Tests: 5 Failed: 1)
  Failed test:  5
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 16 tests but ran 5.
Files=1, Tests=5,  1 wallclock secs ( 0.02 usr  0.00 sys +  1.15 cusr  0.06
csys =  1.23 CPU)

(Perl version 5.22.1)

However if I remove the line:

my $context_module = t::lib::Mocks::mock_dbh;

all tests pass (if DB up)

looks like the mocking is broken in some versions of the libs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155

--- Comment #3 from Marcel de Rooy  ---
Created attachment 49636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49636=edit
Bug 16155: Remove a second use from Members_Attributes.t

Test plan:
Run t/db_dependent/Members_Attributes.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155

--- Comment #1 from Marcel de Rooy  ---
Created attachment 49634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49634=edit
Bug 16155: [DO_NOT_PUSH] OldBehavior.t

This test just serves to illustrate the points mentioned in the commit
message of the second patch.

Test plan:
Run this test before applying patch 2.
See also commit message of the next patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/