date:20160404

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #34 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #33)
> Is the status here correct? Should it be failed QA?

More or less the same, we need a new patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
Blou, please jump into the discussion on bug 15930. I'd like to provide a
global fix for this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #35883|0   |1
is obsolete||

--- Comment #10 from Bernardo Gonzalez Kriegel  ---
Created attachment 49888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49888=edit
[SIGNED_OFF] Bug 13705: Move indexation subs in C4::ZebraIndex

Move indexation-related subs from rebuild_zebra.pl to new module
C4::ZebraIndex and create two new subs IndexRecord and DeleteRecordIndex

This should allow easier indexation from scripts other than
rebuild_zebra.pl

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #40061|0   |1
is obsolete||

--- Comment #13 from Bernardo Gonzalez Kriegel  ---
Created attachment 49891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49891=edit
[SIGNED-OFF] Bug 13705 - Fix QA comments

Signed-off-by: Bernardo Gonzalez Kriegel 

Tested using options -v -a -b -x -r -w -z --length --offset -nosanitize
No problems found, same results as before.
Output slightly different:

Old)

exporting authority

301
Records exported: 389

REINDEXING zebra


New)

REINDEXING zebra

100
200
300
.
389 records exported to /tmp/PBlyusIn1Z/exported_records

REINDEXING zebra
===

No errors save for those on comment #8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #40060|0   |1
is obsolete||

--- Comment #12 from Bernardo Gonzalez Kriegel  ---
Created attachment 49890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49890=edit
[SIGNED-OFF] Bug 13705 - Update copyright and GPL Licence statement in
C4/ZebraIndex.pm

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #35884|0   |1
is obsolete||

--- Comment #11 from Bernardo Gonzalez Kriegel  ---
Created attachment 49889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49889=edit
[SIGNED_OFF] Bug 13705: Prevent a warning in _fix_unimarc_100

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

M. Tompsett  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #8 from M. Tompsett  ---
There are three patches here. I believe that the second one is the best
solution. The third one is clean up and refactors and is not necessary. All
three can be applied at once. The third requires the second one first. The
first can be applied alone.
Testing is merely a prove t/db_dependent/Auth_with_ldap.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16197

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15252
 Status|Signed Off  |In Discussion

--- Comment #4 from Nick Clemens  ---
I signed off, but am marking to in discussion as I think this is the same issue
as 15930. 

I like this approach, but it causes issues for the patch of 15252.

I think the best solution proposed is to use "quotes" to force phrase searching
for two part names

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16197

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15930

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197

Nick Clemens  changed:

   What|Removed |Added

  Attachment #49877|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 49887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49887=edit
Bug 16197 - Specifying both last and firstname in reserve's patrong search
yields nothing.

The user search in reserve/request.pl got broken by bug 13894.
The search using the "recordset" doesn not care for "lastname, firstname" as
before, instead finding nothing.

Test scenario:

EASY SETUP: database with two borrowers with same last name, and one record
minimu.
1) go to KOHA_SITE/cgi-bin/koha/reserve/request.pl?biblionumber=1
2) enter the last name.  You should get two results in the table
3) same site, enter "lastname, firstname" (comma optional).  You get no result.
4) Apply the patch, same test now return the one matching result.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

--- Comment #7 from M. Tompsett  ---
Created attachment 49886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49886=edit
Bug 14144: Clean ups and refactors

perltidy
old new calls to new call format
attrType -> attr_type (perlcritic friendlier)
double quotes to single quotes
'' combinations to q{} (perlcritic friendlier)
refactored parameters to mock_net_ldap_search into a HASH

This piece is not necessary, but I think it is nicer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

M. Tompsett  changed:

   What|Removed |Added

  Attachment #49883|0   |1
is obsolete||
  Attachment #49884|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 49885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49885=edit
Bug 14144: Silence warnings t/db_dependent/Auth_with_ldap.t

Revisiting this bug, I noticed that C4::Context->config() was mocked
poorly. I expanded the mock function a little and have quieted the
test which seemed to be working in a broken manner before.

TEST PLAN
-
1) prove t/db_dependend/Auth_with_ldap.t
   -- shibboleth noise
2) apply this patch
3) prove t/db_dependend/Auth_with_ldap.t
   -- no noise
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

M. Tompsett  changed:

   What|Removed |Added

  Attachment #49882|0   |1
is obsolete||

--- Comment #4 from M. Tompsett  ---
Created attachment 49883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49883=edit
Bug 14144: Silence warnings t/db_dependent/Auth_with_ldap.t

Revisiting this bug, I noticed that C4::Context->config() was mocked
poorly. I expanded the mock function a little and have quieted the
test which seemed to be working in a broken manner before.

TEST PLAN
-
1) prove t/db_dependend/Auth_with_ldap.t
   -- shibboleth noise
2) apply patch
3) prove t/db_dependend/Auth_with_ldap.t
   -- no noise
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

--- Comment #5 from M. Tompsett  ---
Created attachment 49884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49884=edit
Bug 14144: Silence warnings t/db_dependent/Auth_with_ldap.t

A little perlcritic cleanup and perltidy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

M. Tompsett  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

--- Comment #3 from M. Tompsett  ---
Created attachment 49882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49882=edit
Bug 14144: Silence warnings t/db_dependent/Auth_with_ldap.t

Revisiting this bug, I noticed that C4::Context->config() was mocked
poorly. I expanded the mock function a little and have quieted the
test which seemed to be working in a broken manner before.

TEST PLAN
-
1) prove t/db_dependend/Auth_with_ldap.t
   -- shibboleth noise
2) apply patch
3) prove t/db_dependend/Auth_with_ldap.t
   -- no noise
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #33 from Katrin Fischer  ---
Is the status here correct? Should it be failed QA?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16194] Do not consider xslt as valid theme dir in LangInstaller.pm

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16194

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16194] Do not consider xslt as valid theme dir in LangInstaller.pm

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16194

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #49862|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 49881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49881=edit
[PASSED QA] Bug 16194: Do not consider xslt as valid theme dir in
LangInstaller.pm

Bug 15527 add an xslt dir, LangInstaller.pm must ingnore that dir.

To test:
1) Verify the problem on current master
Update translation for any lang, will see errors

2) Apply the patch

3) Update again, no errors

Signed-off-by: Tomas Cohen Arazi 
Works as expected.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9259] batch delete marc batches

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Needs Signoff   |Failed QA

--- Comment #4 from Katrin Fischer  ---
Yes, a new routine should be unit tested. - Aleisha, can you please take a
look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663

--- Comment #30 from Katrin Fischer  ---
Created attachment 49880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49880=edit
[PASSED QA] Bug 12663: (QA followup)

Insert SCOUserCSS/JS 'after' OPACUserCSS/JS rather than 'instead of'
i.e. Remove IF/ELSE and use 2 IF

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|Medium patch|Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #49864|0   |1
is obsolete||
  Attachment #49865|0   |1
is obsolete||

--- Comment #29 from Katrin Fischer  ---
Created attachment 49879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49879=edit
[PASSED QA] Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login
page

Currently if not logged in when browsing to
http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl
You are redirected to opac-auth.tt and SCOUserCSS and SCOUserJS are not
loaded. This page passes through a parameter to the template to indicate
this is an SCO login and appropriate CSS and JS should be loaded.

Additionally this patch ensure that when loggin in using the form you
are redirected to the sco-main.pl instead of the patron account page for
the user.

To test:
1 - Verify that normal login works on both staff and opac
2 - Verify that SCO link goes to login page if AutoSelfCheckAllowed is
set to "Don't allow"
3 - Enter changes into SCOUserJS and SCOUserCSS and observe these are
present on SCO log in page with AutoSelfCheck disabled
4 - Verify that a logged in opac user without permissions cannot access
the self-checkout module
5 - Verify that AutoSelfCheckAllowed and associated system preferences
function as expected
6 - Verify the AutoSelfCheck user is logged out if they attempt to visit
another page

Followed test plan.
If I go to http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl, CSS and JS trigger
already on
the login form, I suppose that is intended.
Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16198] New: Opac suggestions are broken if user is not logged in

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16198

Bug ID: 16198
   Summary: Opac suggestions are broken if user is not logged in
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

/cgi-bin/koha/opac-suggestions.pl reached from the OPAC navigation will show a
Perl error when the user is not logged into the OPAC:

http://localhost/cgi-bin/koha/opac-suggestions.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16198] Opac suggestions are broken if user is not logged in

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16198

--- Comment #1 from Katrin Fischer  ---
Copy and paste mistake, the error is:

Can't call method "branchname" on an undefined value at
/home/katrin/kohaclone/opac/opac-suggestions.pl line 153.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197

Blou  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16164] Making check expiration actions buttons

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16164

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16164] Making check expiration actions buttons

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16164

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #49831|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 49878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49878=edit
[PASSED QA] Bug 16164: Making check expiration actions buttons

EDIT: Using same font awesome icon for 'Renew' as in other places

To test:
1) Go to Serials -> Check expiration
2) Put in a date where one or more subscriptions will expire prior to this date
3) Confirm that column heading is now 'Actions'
4) Confirm that Edit and Renew now show as font awesome buttons
5) Confirm that the buttons don't wrap on narrower browsers
6) Confirm the buttons still work as expected

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197

--- Comment #2 from Blou  ---
Created attachment 49877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49877=edit
Bug 16197 - Specifying both last and firstname in reserve's patrong search
yields nothing.

The user search in reserve/request.pl got broken by bug 13894.
The search using the "recordset" doesn not care for "lastname, firstname" as
before, instead finding nothing.

Test scenario:

EASY SETUP: database with two borrowers with same last name, and one record
minimu.
1) go to KOHA_SITE/cgi-bin/koha/reserve/request.pl?biblionumber=1
2) enter the last name.  You should get two results in the table
3) same site, enter "lastname, firstname" (comma optional).  You get no result.
4) Apply the patch, same test now return the one matching result.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967

--- Comment #16 from Katrin Fischer  ---
Created attachment 49876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49876=edit
[PASSED QA] Bug 15967: Use the email template if the print template does not
exist

>From commit 581759e985c170db0edb4a895cda641930e5ac11
 Bug 14133: Print notices should be generated with the print
 template

"""
IMPORTANT NOTE: This test plan does not take into account the notices
generated for the staff ("These messages were not sent directly to the
patrons."). However the behavior will also change, the print template
will be used in all cases. Is it what we want?
"""

Yes, it is what we want. But if the print template does not exist, the
notice is not generated, we'd like to get the email template instead.

Test plan:
- Remove the print template for the letter you use for overdues
- Define an overdue rule to send an email
- Remove the email address for the patron which has overdues
- Execute the overdue_notices script
The staff should get an email notice and a print notice (using the
email template) should be generated for the patron

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967

--- Comment #15 from Katrin Fischer  ---
Thx a lot!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #48654|0   |1
is obsolete||
  Attachment #49863|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer  ---
Created attachment 49875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49875=edit
[PASSED QA] Bug 15967: Fix regression from bug 14133 - notify the library if
patron is not

Regression introduced by bug 14133, see but 14133 comment 13.

Test plan:
Without this patch applied, if a patron cannot be notified (no email
address or sms number), the print notice generated for the library was
not.
With this patch applied, the print notice should be generated using the
print template

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #160 from Brendan Gallagher  ---
Last patch Pushed to Master - Should be in the May 2016 release.

Thanks and good eye!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
I think you can continue - this should be fixed by another patch that passed QA
recently.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #7 from Bernardo Gonzalez Kriegel  ---
There is a small conflict

Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
Failed to merge in the changes.

Solving that we got: 
Software error:
Template process failed: file error - searchbox-keep-text.inc: not found at
/home/bgkriegel/kohaclone/C4/Templates.pm line 119

Where is 'searchbox-keep-text.inc'?

BTW, have you an agreement on file names, i.e. jquery-ver vs. old/older?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197

--- Comment #1 from Blou  ---
Actually, problem seems with C4/Utils/DataTables/Members.pm 's search method.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197

Blou  changed:

   What|Removed |Added

 CC||eric.be...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197

Blou  changed:

   What|Removed |Added

   Severity|normal  |major
   Assignee|koha-b...@lists.koha-commun |philippe.blo...@inlibro.com
   |ity.org |
 CC||francois.charbonnier@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search - reserve.pl

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894

Blou  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16197

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197

Blou  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=13894

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16197] New: Searching for user in reserve/request.pl is broken

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197

Bug ID: 16197
   Summary: Searching for user in reserve/request.pl is broken
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: philippe.blo...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The user search in reserve/request.pl got broken by bug 13894.  The search
using the "recordset" doesn not care for "lastname, firstname" as before,
instead finding nothing.

Scenario:

EASY SETUP: database with two borrowers with same last name, and one record
minimu.
1) go to KOHA_SITE/cgi-bin/koha/reserve/request.pl?biblionumber=1
2) enter the last name.  You should get two results in the table
3) same site, enter "lastname, firstname" (comma optional).  You get no result.

This used to work before 13894.  Vile RecordSet broke it...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #16 from Bernardo Gonzalez Kriegel  ---
Applying: Bug 10347 [Follow-up] Scroll down clicking on the "Add multiple
copies" button
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt).
Repository lacks necessary blobs to fall back on 3-way merge.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14764] Add OPAC News branch selector

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
   Assignee|oleon...@myacpl.org |xarra...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705

--- Comment #8 from Bernardo Gonzalez Kriegel  ---
Hi, new errors 

 FAIL   C4/ZebraIndex.pm
   OK critic
   OK forbidden patterns
   OK pod
   OK spelling
0
   FAIL   valid
Name "Cache::RemovalStrategy::FIELDS" used only once: possible
typo
Name "Cache::RemovalStrategy::LRU::FIELDS" used only once:
possible typo
Name "Tie::Hash::FIELDS" used only once: possible typo

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #27 from Owen Leonard  ---
I think based on this bug's history that it should be "Signed off" at this
stage.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979

--- Comment #32 from Owen Leonard  ---
Created attachment 49873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49873=edit
[SIGNED-OFF] Bug 5979: follow to fix spelling

Changed Montains -> Mountains

koha-qa complains!!

Signed-off-by: Bernardo Gonzalez Kriegel 
Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16196] New: Acquisitions Module Not Showing Subtotals

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16196

Bug ID: 16196
   Summary: Acquisitions Module Not Showing Subtotals
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: a...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Partner reports that when receiving books in the Acquisitions module, subtotals
are not identifying which fund they are for.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Owen Leonard  ---
Based on comment 2 and comment 3 I think this should be 'Failed QA'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Owen Leonard  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |xarra...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979

Owen Leonard  changed:

   What|Removed |Added

  Attachment #44211|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979

Owen Leonard  changed:

   What|Removed |Added

  Attachment #48295|0   |1
is obsolete||

--- Comment #33 from Owen Leonard  ---
Created attachment 49874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49874=edit
[SIGNED-OFF] Bug 5979 - Follow up: Change ISBD syspref description and fix
warning in t/Biblio/Isbd.t

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14657] Is Hidden By Default for Price hides Fine

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657

--- Comment #8 from Agnes Rivers-Moore  ---
Oh - I should say that we would like to hide "Price" - the one column that we
are not able to turn off! 
Thanks,
Agnes

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14657] Is Hidden By Default for Price hides Fine

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657

--- Comment #6 from Agnes Rivers-Moore  ---
Created attachment 49871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49871=edit
Admin show/hide settings

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14657] Is Hidden By Default for Price hides Fine

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657

--- Comment #7 from Agnes Rivers-Moore  ---
Created attachment 49872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49872=edit
Show/hide setting in Checkout

Compare with my other attachment & Note the different columns listed, and the
result in the checkout display.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14657] Is Hidden By Default for Price hides Fine

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657

--- Comment #5 from Agnes Rivers-Moore  ---
Hi Jonathan

John Yorio submitted this one on our behalf - we found it when fist upgraded to
3.20.02.000. Might have been fixed along the way since then.
I can confirm it still happens in our live system.
I hope this will clarify the symptoms:

It is a mismatch between the show/hide column names in Administration and those
that appear in circulation.

Koha admin - Columns settings - Circulation
Set Charge and Price to Hidden by default

Expected result:
For checkout display not to show Charge or Price.

This is what ACTUALLY happened:
Checkout still shows Price. 
Fine disappears!
Drop-drown to show/hide that is in the checkout screen - does not list hide
Price at all.
Seems the programmers mixed up the Price and Fine fields.
In the Admin module - hiding Price actually hides Fine, and Fine is not listed
in the Columns Settings table at all. 
In the checkout screen drop-down - the fields seem to be correctly named, and
hide Price is simply not an option.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832

Owen Leonard  changed:

   What|Removed |Added

  Attachment #49682|0   |1
is obsolete||

--- Comment #7 from Owen Leonard  ---
Created attachment 49870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49870=edit
[SIGNED-OFF] Bug 15832 - Fix filter and items split-up in pendingreserves.tt

Test plan:

- Go to circ/pendingreserves.pl (Ensure that there are biblios with many
  items on different branches),
- Check the libraries filter at the bottom of datatable. There should be
  duplicates.
- Apply this patch and return to circ/pendingreserves.pl,
- check that libraries filter should not contain duplicate,
- check that the filter works.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13952] Import and export of authority types

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #12 from Bernardo Gonzalez Kriegel  ---
Sorry, does not apply

CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9259] batch delete marc batches

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259

--- Comment #3 from Owen Leonard  ---
I wish we had a better icon for the "clean" button. One of the problems with
using Font Awesome is that we're kinda stuck if we don't have just the right
thing.

I'm not sure what the rules are... Do the changes to C4/ImportBatch.pm require
a test?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16144] Patron search fails when using Korean (pootle/translate error)

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||bgkrie...@gmail.com
   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com
   |ity.org |

--- Comment #10 from Bernardo Gonzalez Kriegel  ---
My patch remove some of the problematic strings, but not all.
To fix this you need to edit translation file in pootle, I can help
to identify those strings.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16144] Patron search fails when using Korean (pootle/translate error)

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #49868|0   |1
is obsolete||

--- Comment #9 from Bernardo Gonzalez Kriegel  ---
Created attachment 49869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49869=edit
Bug 16144: Remove 'dt_*' from translation strings when possible

This patch removes strings form translation files that have
'dt_*' variables besides puntuation, html constructs, etc.

To test:
1) Update strings for any language
2) Check for strings with 'dt_*', eg. for es-ES
msgcat --no-wrap po/es-ES-staff-prog.po | egrep ^msgid | egrep "dt_"

3) Apply the patch & update again

4) Compare similar strings, there are now a few less strings

This does not remove all occurrences, there's no easy way
to do that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16182] Make phone number clickable to call

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Owen Leonard  ---
Should the SMS number link use 'http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16144] Patron search fails when using Korean (pootle/translate error)

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144

--- Comment #8 from Bernardo Gonzalez Kriegel  ---
Created attachment 49868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49868=edit
Bug 16144: Remove 'dt_*' from translation strings when possible

This patch removes strings form translation files that have
'dt_*' variables besides puntuation, html constructs, etc.

To test:
1) Update strings for any language
2) Check for strings with 'dt_*', eg. for es-ES
msgcat --no-wrap po/es-ES-staff-prog.po | egrep ^msgid | egrep "dt_"

3) Apply the patch & update again

4) Compare similar strings, there are now a few less strings

This does not remove all occurrences, there's no easy way
to do that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

--- Comment #159 from Brendan Gallagher  ---
(In reply to Tomás Cohen Arazi from comment #158)
> Brendan, please push the last followup so xt/tt_valid.t gets fixed.

Cool I'm on it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16183] Add confirm message for deleting patron messages

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16183

Owen Leonard  changed:

   What|Removed |Added

  Attachment #49749|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 49867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49867=edit
[SIGNED-OFF] Bug 16183: Confirm message upon deleting patron messages

To test:
1) Go to a patron circulation page and add a message
2) Click '[Delete]'
3) Confirm that a confirm dialog shows up and 'Cancel' and 'OK' do what
   is expected.

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16183] Add confirm message for deleting patron messages

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16183

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16164] Making check expiration actions buttons

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16164

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16193] Typo in Automatic item modifications by age

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16193

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16193] Typo in Automatic item modifications by age

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16193

Owen Leonard  changed:

   What|Removed |Added

  Attachment #49834|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 49866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49866=edit
[SIGNED-OFF] Bug 16193: Typo in Automatic item modifications by age

To test:
1) Go to Tools -> Automatic item modifications by age
2) Click Edit
3) Add a rule if you have none, otherwise notice button 'Submit theses
   rules' and typo (theses)
4) Apply patch, refresh page
5) Confirm button now says 'Submit these rules' (typo is fixed)

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14657] Is Hidden By Default for Price hides Fine

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |RESOLVED

--- Comment #4 from Jonathan Druart  
---
John, try and restart memcached. It should fix your issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16195] Add Koha::Categories objects

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16195

Alex Sassmannshausen  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669

--- Comment #13 from Owen Leonard  ---
Overall this looks great. I am curious why you created a new include file for
the add message form but put the modal markup in members-toolbar.inc. Why not
just put all the markup in members-toolbar.inc?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967

Nick Clemens  changed:

   What|Removed |Added

  Attachment #49844|0   |1
is obsolete||

--- Comment #13 from Nick Clemens  ---
Created attachment 49863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49863=edit
Bug 15967: Use the email template if the print template does not exist

>From commit 581759e985c170db0edb4a895cda641930e5ac11
 Bug 14133: Print notices should be generated with the print
 template

"""
IMPORTANT NOTE: This test plan does not take into account the notices
generated for the staff ("These messages were not sent directly to the
patrons."). However the behavior will also change, the print template
will be used in all cases. Is it what we want?
"""

Yes, it is what we want. But if the print template does not exist, the
notice is not generated, we'd like to get the email template instead.

Test plan:
- Remove the print template for the letter you use for overdues
- Define an overdue rule to send an email
- Remove the email address for the patron which has overdues
- Execute the overdue_notices script
The staff should get an email notice and a print notice (using the
email template) should be generated for the patron

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663

Nick Clemens  changed:

   What|Removed |Added

  Attachment #49745|0   |1
is obsolete||

--- Comment #28 from Nick Clemens  ---
Created attachment 49865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49865=edit
Bug 12663: (QA followup)

Insert SCOUserCSS/JS 'after' OPACUserCSS/JS rather than 'instead of'
i.e. Remove IF/ELSE and use 2 IF

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663

Nick Clemens  changed:

   What|Removed |Added

  Attachment #49602|0   |1
is obsolete||

--- Comment #27 from Nick Clemens  ---
Created attachment 49864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49864=edit
Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page

Currently if not logged in when browsing to
http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl
You are redirected to opac-auth.tt and SCOUserCSS and SCOUserJS are not
loaded. This page passes through a parameter to the template to indicate
this is an SCO login and appropriate CSS and JS should be loaded.

Additionally this patch ensure that when loggin in using the form you
are redirected to the sco-main.pl instead of the patron account page for
the user.

To test:
1 - Verify that normal login works on both staff and opac
2 - Verify that SCO link goes to login page if AutoSelfCheckAllowed is
set to "Don't allow"
3 - Enter changes into SCOUserJS and SCOUserCSS and observe these are
present on SCO log in page with AutoSelfCheck disabled
4 - Verify that a logged in opac user without permissions cannot access
the self-checkout module
5 - Verify that AutoSelfCheckAllowed and associated system preferences
function as expected
6 - Verify the AutoSelfCheck user is logged out if they attempt to visit
another page

Followed test plan.
If I go to http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl, CSS and JS trigger
already on
the login form, I suppose that is intended.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13780] A patron without cardnumer will break searching for category code

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13780

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #2 from Jonathan Druart  
---
Closing, please reopen if it's not fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2422] Cataloging searches with more than 1 page results show blank pages after page 1

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2422

--- Comment #10 from Jonathan Druart  
---
Nicholas, could you confirm it is fixed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #12 from Nick Clemens  ---
Just adding this from the other bug , I think fallback to email is a fine
option but wanted to mention this in case it seems worthwhile:
Maybe we could fallback to just sending the library a notice saying "No email
for patron XXX - define print notice if you would like to receive printable
notices instead of this message"?  Or something along those lines?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16191] t/Ris.t is noisy

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16191

--- Comment #4 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #3)
> (In reply to M. Tompsett from comment #1)
> > 3) prove t/Ris.t
> >-- just one confusing noise.
> 
> Why did not you remove it?

Because I did not feel comfortable deciding that particular fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16194] Do not consider xslt as valid theme dir in LangInstaller.pm

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16194

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #49860|0   |1
is obsolete||

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 49862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49862=edit
Bug 16194: Do not consider xslt as valid theme dir in LangInstaller.pm

Bug 15527 add an xslt dir, LangInstaller.pm must ingnore that dir.

To test:
1) Verify the problem on current master
Update translation for any lang, will see errors

2) Apply the patch

3) Update again, no errors

Signed-off-by: Tomas Cohen Arazi 
Works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16194] Do not consider xslt as valid theme dir in LangInstaller.pm

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16194

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13718] Paying fines references non-existent function on submit

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13718

Jonathan Druart  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

--- Comment #1 from Jonathan Druart  
---
*** Bug 16135 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13718] Paying fines references non-existent function on submit

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13718

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Version|3.18|unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16135] JavaScript error when paying a fine

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16135

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Jonathan Druart  
---


*** This bug has been marked as a duplicate of bug 13718 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15010] Import patron tool creates 'duplicate' restrictions ( debarments )

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15010

Janet McGowan  changed:

   What|Removed |Added

 CC||janet.mcgowan@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16195] Add Koha::Categories objects

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16195

--- Comment #1 from Alex Sassmannshausen  
---
Created attachment 49861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49861=edit
Koha::Categories objects patch

Add the objects.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16181] Limit number of tags loaded initially for tag cloud

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16181

--- Comment #3 from Jonathan Druart  
---
So you are talking about the table, not the tag cloud, that's it?

With 2000 tags the page is generated in 10sec on my laptop, not so bad

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16195] Add Koha::Categories objects

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16195

Alex Sassmannshausen  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |alex.sassmannshausen@ptfs-e
   ||urope.com
 Status|NEW |ASSIGNED
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16195] New: Add Koha::Categories objects

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16195

Bug ID: 16195
   Summary: Add Koha::Categories objects
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: alex.sassmannshau...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

This bug adds the prospect of Koha::Category and Koha::Categories objects.a

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16194] Do not consider xslt as valid theme dir in LangInstaller.pm

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16194

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com
   |ity.org |
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15527
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

2016-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16194

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 188 matches

Mail list logo