[Koha-bugs] [Bug 16029] Do not show patron toolbar when showing the "patron does not exist" message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16029

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #6 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16020] Remove unused CSS and images following label creator UX changes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16020

Julian Maurice  changed:

   What|Removed |Added

   Severity|minor   |enhancement
 CC||julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16019] Remove unused blue.css

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16019

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
   Severity|minor   |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15984] Correct templates which use the phrase "issuing rules"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15984

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #5 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #15 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #25 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13952] Import and export of authority types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #47364|0   |1
is obsolete||

--- Comment #13 from Aleisha Amohia  ---
Created attachment 50046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50046=edit
Bug 13952: Import and export authority types

This patch amends C4::ImportExportFramework to work for authority types as well
as MARC frameworks.
New file: admin/import_export_authtype.pl
Update: Ensuring we are passing the right column to the right tables.
Update2: Making the error messages the same to be consistent with patch on Bug
15665
Update3: Fixing merge conflicts

To test:
1) Go to Admin -> Authority types
2) Confirm there are two new columns 'Export' and 'Import' in the table
3) Click 'Export' on an existing authority type and choose a file type, click
'Export'
4) Confirm that the authority type is exported as your chosen file type. Save
the file
5) Create a new authority type
6) Click 'Import' into your new authority type (so you don't overwrite any
important existing authority types)
7) Select the file you just exported and click 'Import'
8) Confirm you are taken to auth_tag_structure.pl
9) Go back to Authority types
10) Click 'Import' next to any existing authority type and attempt to import a
file that is not XML, CSV or ODS. Confirm that this fails and you are asked to
import a file of the correct file type
11) Go to Admin -> MARC bibliographic framework
12) Confirm that the 'Export' and 'Import' functions still work here as well

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13952] Import and export of authority types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16182] Make phone number clickable to call

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #49833|0   |1
is obsolete||

--- Comment #15 from Aleisha Amohia  ---
Created attachment 50044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50044=edit
Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron
toolbar

This patch moves all the code into an include which can be accessed from the
'Add a new message' link or the patron toolbar.

EDIT: Ensuring modal opens on all pages
EDIT2: Once the form has been submitted the page will redirect to where you
submitted the form from.
EDIT3: Fixing indentation of member-add-message.inc
   Ensuring messages save on every page
   Fill branch
   Ensure predefined notes appear
   Form redirects to where it was submitted from, or just the circulation
page.
EDIT4: Removing the new include file and moving it all into the modal in the
toolbar

To test:
1) Go to a patron circ page (circ/circulation.pl?borrowernumber=X)
2) Click 'Add a new message' under Messages
3) Confirm this brings up the modal to add a message. Confirm clicking Save
saves your message. If it is an OPAC message (for the user), confirm it shows
as expected on the OPAC.
4) Click Cancel. Confirm this closes the modal.
5) Click 'Add message' button in toolbar. Complete steps 3 and 4.
6) Confirm the modal opens from all other pages with the members toolbar.
Confirm predefined notes shows.
circ/circulation.pl
members/moremember.pl
members/routing-lists.pl
members/statistics.pl
members/boraccount.pl
members/pay.pl
members/maninvoice.pl
members/mancredit.pl
members/readingrec.pl
members/notices.pl
members/member-flags.pl
members/member-password.pl
members/paycollect.pl
members/files.pl
7) Confirm that the page redirects to where you submitted the form from once
you have submitted it.
8) Go to Check Out tab and confirm your message saved (or OPAC, wherever you
saved it)

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #69 from Mirko Tietgen  ---
Hi David,

(In reply to David Cook from comment #68)

> 6) In Koha, create a record matching rule:
> Code = OAI
> Match threshold = 100
> Record type = Bibliographic
> Search index = control-number
> Score = 100
> Tag = 001
> Search index = id-other,st-urx
> Score = 100
> Tag = 024
> Subfields = a
> Normalization rule = raw

does that mean "create two match points with
Match point 1

Search index = control-number
Score = 100
Tag = 001


Match point 2

Search index = id-other,st-urx
Score = 100
Tag = 024
Subfields = a
Normalization rule = raw

"?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder's borrowernumber in AF (screen message) field.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

--- Comment #2 from Nick Clemens  ---
(In reply to Nick Clemens from comment #1)

NVM - error is below, we loop through each reasonforconfirmation, some of these
are borrower fields, when we hit those we print them as the screen message, we
should instead check for the presence of any of these reasons and then log
failed unknown if not equal and output and error to the screen_msg:


  74 foreach my $confirmation (keys %{$needsconfirmation}) {
  75 if ($confirmation eq 'RENEW_ISSUE'){
  76 $self->screen_msg("Item already checked out to you:
renewing item.");
  77 } elsif ($confirmation eq 'RESERVED' or $confirmation eq
'RESERVE_WAITING') {
  78 my $x = $self->{item}->available($patron_barcode);
  79 if ($x) {
  80 $self->screen_msg("Item was reserved for you.");
  81 } else {
  82 $self->screen_msg("Item is reserved for another patron
upon return.");
  83 # $noerror = 0;
  84 }
  85 } elsif ($confirmation eq 'ISSUED_TO_ANOTHER') {
  86 $self->screen_msg("Item already checked out to another
patron.  Please return item for check-in.");
  87 $noerror = 0;
  88 } elsif ($confirmation eq 'DEBT') {
  89 $self->screen_msg('Outstanding Fines block issue');
  90 $noerror = 0;
  91 } elsif ($confirmation eq 'HIGHHOLDS') {
  92 $overridden_duedate =
$needsconfirmation->{$confirmation}->{returndate};
  93 $self->screen_msg('Loan period reduced for high-demand
item');
  94 } elsif ($confirmation eq 'RENTALCHARGE') {
  95 if ($self->{fee_ack} ne 'Y') {
  96 $noerror = 0;
  97 }
  98 } else {
  99 $self->screen_msg($needsconfirmation->{$confirmation});
 100 $noerror = 0;
 101 syslog('LOG_DEBUG', "Blocking checkout
Reason:$confirmation");
 102 }
 103 }
 104 }

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder's borrowernumber in AF (screen message) field.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
   Priority|P5 - low|P3
   Severity|enhancement |major

--- Comment #1 from Nick Clemens  ---
Raising the severity, marking as a bug.

Repeated messages will return any one of:
borrowernumber
firstname
surname
cardnumber
reservedate
reservebranch

I believe in the code below we are just shoving the issuingimpossible hash into
screen_msg and ending with any one of the values:

[koha.git] / C4 / SIP / ILS / Transaction / Checkout.pm
  67 if (scalar keys %$issuingimpossible) {
  68 foreach (keys %$issuingimpossible) {
  69 # do something here so we pass these errors
  70 $self->screen_msg($_ . ': ' . $issuingimpossible->{$_});
  71 $noerror = 0;
  72 }
  73 } else {

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16226] New: Allow Plack workers and requests-before-restart to be configured per-instance

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16226

Bug ID: 16226
   Summary: Allow Plack workers and requests-before-restart to be
configured per-instance
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jwea...@bywatersolutions.com
  Reporter: jwea...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: la...@bywatersolutions.com

This could be a file like /etc/koha/sites/INSTANCE/plack-settings, and would
likely just contain the following:

MAX_REQUESTS=50
WORKERS=2

so it could be sourced by koha-plack.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #13213|0   |1
is obsolete||

--- Comment #17 from Nicole C. Engard  ---
Created attachment 50043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50043=edit
Bug 9004 - Talking Tech doesn't account for holidays when calculating a holds
last pickup date - Add holidays check

Signed-off-by: Chris William 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #13212|0   |1
is obsolete||

--- Comment #16 from Nicole C. Engard  ---
Created attachment 50042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50042=edit
Bug 9004 - Talking Tech doesn't account for holidays when calculating a holds
last pickup date - Perltidy script.

Signed-off-by: Chris William 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a translation problem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16218] printfeercpt.tt (and others) does not include jQuery

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16218

Marc Véron  changed:

   What|Removed |Added

   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16218] printfeercpt.tt (and others) does not include jQuery

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16218

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16218] printfeercpt.tt (and others) does not include jQuery

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16218

Marc Véron  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16218] printfeercpt.tt (and others) does not include jQuery

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16218

--- Comment #2 from Marc Véron  ---
Created attachment 50041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50041=edit
Bug 16218: printfeercpt.tt (and others) does not include jQuery

This patch adds [% INCLUDE 'doc-head-close.inc' %] to the following files
(to make them include jQuery):

koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-receipt.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt

To test:

1) Temporarily include the follwing lines in syspref IntranetSlipPrinterJS:

function printThenClose() {
  if (typeof jQuery != 'undefined') {
// jQuery is loaded => print the version
alert(jQuery.fn.jquery);
  }
  else {
alert('jQuery not available');
  }
}

2) Go to a users page and print slips:
From the Print button in the tool bar:
- Print summary
- Print slip
- Print quick slip
From the "Fines" tab: Account
- 'Print' link in the table with paid transactions

Without patch, a JavaScript message 'jQuery not avaliable' appears.
With patch, the message displays the current jQuery version (1.7.2)

3) Remove IntranetSlipPrinterJS
- Verify that the slips above print as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16218] printfeercpt.tt (and others) does not include jQuery

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16218

--- Comment #1 from Marc Véron  ---
Verified for:

koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-receipt.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16218] printfeercpt.tt (and others) does not include jQuery

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16218

Marc Véron  changed:

   What|Removed |Added

Summary|printfeercpt.tt (and|printfeercpt.tt (and
   |possibly others) does not   |others) does not include
   |include jQuery  |jQuery

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16225] Extra closing quote in circulation home page template.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16225

--- Comment #1 from Owen Leonard  ---
Created attachment 50040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50040=edit
Bug 16225 - Extra closing quote in circulation home page template

This patch removes an extra closing quote left behind by the changes
made in Bug 15640.

This patch also corrects the case of the "Circulation reports"
heading. (See coding guideline HTML4).

To test, apply the patch and go to the circulation home page. Validate
the page's HTML and confirm that there are no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16225] Extra closing quote in circulation home page template.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16225

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16225] New: Extra closing quote in circulation home page template.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16225

Bug ID: 16225
   Summary: Extra closing quote in circulation home page template.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/circ/circulation-home.pl
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Blocks: 15640

The changes made in Bug 15640 left behind an extra closing quote at line 42 of
circulation-home.tt.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640
[Bug 15640] Accessibility - ensure there are no titles on hover over the links
(circ home page)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15640] Accessibility - ensure there are no titles on hover over the links (circ home page)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640

Owen Leonard  changed:

   What|Removed |Added

 Depends on||16225


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16225
[Bug 16225] Extra closing quote in circulation home page template.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277

Jesse Weaver  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #16 from Jesse Weaver  ---
Pushed, will be in the May 2016 release. Thanks for your work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16108] XLST and CSS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16108

--- Comment #1 from Owen Leonard  ---
Can you please provide specific examples of problems you have run into?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16220] The view tabs on opac-detail.pl are not responsive

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16220

--- Comment #2 from Owen Leonard  ---
Created attachment 50039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50039=edit
Bug 16220 [Compiled CSS] The view tabs on opac-detail.pl are not responsive

This patch updates the compiled CSS file with changes made in the
previous patch to the LESS files.

To test, apply both patches and clear your browser cache if necessary.

- View the bibliographic detail page for any record in the OPAC
- Confirm that the style of the "Normal," "MARC," and "ISBD" links looks
  correct.
- Resize your browser to various widths, including very narrow widths.
  Confirm that the links work well at all sizes.
- Repeat the test for each view, normal, MARC, and ISBD.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16220] The view tabs on opac-detail.pl are not responsive

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16220

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16220] The view tabs on opac-detail.pl are not responsive

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16220

--- Comment #1 from Owen Leonard  ---
Created attachment 50038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50038=edit
Bug 16220 - The view tabs on opac-detail.pl are not responsive

When looking at the detail page for a bibliographic record, there are
tabs linking to the "Normal," "MARC," and "ISBD" views. These tabs need
to be styled responsively so that they work well at all browser widths.

This patch makes some slight markup changes to the templates and updates
the LESS files to add responsive styling.

This patch does not include the compiled CSS file, so the follow-up is
required to test the visual changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16220] The view tabs on opac-detail.pl are not responsive

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16220

Owen Leonard  changed:

   What|Removed |Added

Summary|The view tabs on|The view tabs on
   |opac-detail.pl are not  |opac-detail.pl are not
   |responsive via bootstrap|responsive

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #48651|0   |1
is obsolete||

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 50036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50036=edit
Bug 14277: add zebra indexes for lexile that respect 521 indicator 1.

Added the following indexes:

Interest-age-level | 591$a ind1=1
Interest-grade-level | 591$a ind1=2
lexile-number | 591$a ind1=8
Reading-grade-level | 591$a ind1=0

Moved 'lex' from a zebra index to a ccl alias to lexile-number.

Changed the handling of st-numeric in C4/Search.pm to allow for search ranges.

Signed-off-by: Nick Clemens 
Signed-off-by: Hector Castro 
Works as advertised
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #50032|0   |1
is obsolete||

--- Comment #15 from Tomás Cohen Arazi  ---
Created attachment 50037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50037=edit
Bug 14277: (QA followup) Silent GRS-1 tests

changed ocurrences of 'lex' to 'lexile-number' in record.abs

Edits were made to the deprecated file record.abs *solely* to quiet
warnings in tests -- this makes sense until GRS-1 code is removed
from Koha.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16218] printfeercpt.tt (and possibly others) does not include jQuery

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16218

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16211] Missing tag in member.tt line 392

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16211

Marc Véron  changed:

   What|Removed |Added

   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16211] Missing tag in member.tt line 392

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16211

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12787] Unit test files should be better organized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 50034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50034=edit
Bug 12787: (QA followup) small QA fixes

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16211] Missing tag in member.tt line 392

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16211

--- Comment #1 from Marc Véron  ---
Created attachment 50035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50035=edit
Bug 16211: Missing  tag in member.tt line 392

This patch fixes the  tag in member.tt line 392

To test:
- Apply patch
- Verify that closing th tag on line 392 is OK
- Go to /cgi-bin/koha/members/member.pl, do a search and verify that
  results display as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12787] Unit test files should be better organized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16211] Missing tag in member.tt line 392

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16211

Marc Véron  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12787] Unit test files should be better organized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #50027|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 50033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50033=edit
Bug 12787: Reorganise t/db_dependent files

This patch tries to reorganise test files in the db_dependent directory:
- Circulation_Branch.t   has been moved to Circulation/Branch.t
- Circulation_issuingrules.t has been moved to Circulation/CalcDateDue.t
- Circulation_Issuingrule.t  has been moved to Circulation/GetHardDueDate.t
- Circulation_dateexpiry.t   has been moved to Circulation/dateexpiry.t
- Circulation_issue.thas been moved to Circulation/issue.t
- Circulation_transfers.thas been moved to Circulation/transfers.t
- Items_DelItem.thas been moved to Items/DelItem.t
- BiblioObject.t has been moved to Koha/Biblio.t
- Members_Attributes.t   has been moved to Members/Attributes.t
- Members_columns.t  has been moved to Members/columns.t
- Circulation_OfflineOperation.t   has been moved to
Circulation/OfflineOperation.t
- Koha_template_plugin_KohaDates.t has been moved to
Template/Plugin/KohaDates.t
- Koha_template_plugin_Branches.t  has been moved to Template/Plugin/Branches.t
- Reports/Guided.t, ReportsGuided.t and Reports_Guided.t have been
  merged

Test plan:
Confirm that all the modified tests still pass

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277

Barton Chittenden  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277

--- Comment #13 from Barton Chittenden  ---
Created attachment 50032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50032=edit
Bug 14277 - (QA followup)

changed ocurrences of 'lex' to 'lexile-number' in record.abs

Edits were made to the deprecated file record.abs *solely* to quiet
warnings in tests -- this makes sense until GRS-1 code is removed
from Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16210] Bug 15111 breaks the OPAC if JavaScript is disabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16210

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #5 from Mirko Tietgen  ---
(In reply to Jonathan Druart from comment #4)
> If I understand correctly, setting X-Frame-Options to SAMEORIGIN should be
> enough for mordern browsers:
> https://developer.mozilla.org/en-US/docs/Web/HTTP/X-Frame-Options
> 
> The antiClickjack trick could be removed if we decide not to support them
> anymore.

Supported are

Firefox 3.6.9   September 2010
IE 8March 2008
Opera 10.5  March 2010
Safari 4February 2009
Chrome 4.1.…somewhen 2010

If that fixes the problem in general I vote for using it. One thing that needs
to be checked if it works with recent mobile browsers, the website does not
really say that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14096] Licences on About page not consistently linked

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14096

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=7713

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7713] display local license files in about.pl, rather than via external urls

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7713

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=14096

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16210] Bug 15111 breaks the OPAC if JavaScript is disabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16210

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16224] Random failure for t/db_dependent/Reports_Guided.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16224

--- Comment #1 from Julian Maurice  ---
Created attachment 50031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50031=edit
Bug 16224: Fix t/db_dependent/Reports_Guided.t

This test:

is( scalar @{ get_saved_reports( $report_ids[0] ) }, 1,
"filter takes report id" );

can fail when $report_ids[0] is a substring of some saved_sql fields
from other reports (reports that have a different id than
$report_ids[0]).
We can only be sure that get_saved_reports will return at least 1
report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16224] Random failure for t/db_dependent/Reports_Guided.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16224

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16224] New: Random failure for t/db_dependent/Reports_Guided.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16224

Bug ID: 16224
   Summary: Random failure for t/db_dependent/Reports_Guided.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Test Suite
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: gmcha...@gmail.com

This test:

is( scalar @{ get_saved_reports( $report_ids[0] ) }, 1, "filter takes report
id" );

can fail when $report_ids[0] is a substring of some saved_sql fields from other
reports (reports that have a different id than $report_ids[0]).
We can only be sure that get_saved_reports will return at least 1 report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16210] Bug 15111 breaks the OPAC if JavaScript is disabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16210

--- Comment #4 from Jonathan Druart  
---
If I understand correctly, setting X-Frame-Options to SAMEORIGIN should be
enough for mordern browsers:
https://developer.mozilla.org/en-US/docs/Web/HTTP/X-Frame-Options

The antiClickjack trick could be removed if we decide not to support them
anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16179] Clicking Rate me button in OPAC without selecting rating produces error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16179

Owen Leonard  changed:

   What|Removed |Added

  Attachment #49936|0   |1
is obsolete||

--- Comment #8 from Owen Leonard  ---
Created attachment 50030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50030=edit
[SIGNED-OFF] Bug 16179: Do not crash if "rate me" is clicked and not rate
selected

If JS is disabled and a user clicks on the "Rate me" button, Koha will
crashes with:
DBIx::Class::ResultSet::create(): Column 'rating_value' cannot be null
at /usr/share/koha/lib/C4/Ratings.pm line 208

To avoid that, opac-ratings.pl will check if a rate has been selected.

Test plan:
Disable JS
On a record detail page, click on the "Rate me" button

TESTED PLAN:
1) go to /cgi-bin/koha/opac-ratings.pl?biblionumber=1
   -- kaboom as above.
2) apply patch
3) refresh
   -- either login screen (don't know why)
   -- or if already logged in, detail page.
4) koha qa test tool

Signed-off-by: Mark Tompsett 
Signed-off-by: Owen Leonard 

I tested successfully by temporarily removing the modification made by
Bug 16210.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12787] Unit test files should be better organized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16220] The view tabs on opac-detail.pl are not responsive via bootstrap

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16220

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16179] Clicking Rate me button in OPAC without selecting rating produces error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16179

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883

--- Comment #10 from Owen Leonard  ---
I think there is no benefit to having a file called "jquery.js" which is of
unknown (or at least non-obvious) version. History has shown that we are bad at
keeping jQuery updated, so it would not be long before it wasn't the newest
version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757

--- Comment #25 from Jonathan Druart  
---
Please provide follow-ups for what you think useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||12787


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787
[Bug 12787] Unit test files should be better organized
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12787] Unit test files should be better organized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||15757


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757
[Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found
in C4::Circulation::GetLoanLength
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #50014|0   |1
is obsolete||

--- Comment #24 from Jonathan Druart  
---
Created attachment 50029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50029=edit
Bug 15757: Make GetLoanLength defaults to 0 instead of 21

GetLoanLength arbitrary defaulted to 21. The expected behavior seems to
be to default on 0 (loan will be dued today).

IMPORTANT NOTE: This patch will introduce a change in the behaviors for
configuration with a 0 in issuelength. Before this patch, the rule with
a issuelength==0 was skipped, now it's used!

Test plan:
1/ Do not define any rule: the due date will be today (before this patch
was +21 days)
2/ Define some rules which does not match the patron category, itemtype
or branchcode: the due date will be today (before this patch was +21
days).
3/ Modify a rule to match the checkout and set issuelength=0: the due
date will be today (before this patch, the rule was skipped)
4/ Modify this rule and set the issuelength to something > 0: the due
date will be adjusted (same behavior as before this patch)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12267] Allow password option in Patron Attribute non functional

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12267

--- Comment #5 from Owen Leonard  ---
If the feature hasn't been implemented yet...

I say remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757

--- Comment #23 from Jonathan Druart  
---
(In reply to M. Tompsett from comment #22)
> Comment on attachment 50014 [details] [review]
> Bug 15757: Make GetLoanLength defaults to 0 instead of 21
> 
> Review of attachment 50014 [details] [review]:
> -
> 
> ::: t/db_dependent/Circulation_Issuingrule.t
> @@ +113,5 @@
> > +is_deeply(
> > +C4::Circulation::GetLoanLength(),
> > +$default,
> > +"Without parameters, GetLoanLength returns hardcoded values"
> > +);
> 
> This is an added test. If the number of tests to run is set, then you forgot
> to update it.

Don't know where does it come from, it's certainly a c/p issue. The number of
expected tests is 10 and 11 are run.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9387] Feedback message for FAILED check out items are not obvious for visually impaired

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9387

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9387] Feedback message for FAILED check out items are not obvious for visually impaired

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9387

Marc Véron  changed:

   What|Removed |Added

  Attachment #49989|0   |1
is obsolete||

--- Comment #5 from Marc Véron  ---
Created attachment 50028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50028=edit
Bug 9387 - Feedback message for FAILED check out items are not obvious for
visually impaired

This patch adds a heading to the error dialg displayed when a barcode
has been submitted for checkout which doesn't exist. This patch also
modifies the markup of the error dialog in order to make error a little
more clear to sighted users.

To test, apply the patch and submit a barcode for checkout which does
not exist. The resulting error dialog should have a heading, "Barcode
not found."

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12787] Unit test files should be better organized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12787] Unit test files should be better organized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12787] Unit test files should be better organized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787

--- Comment #2 from Jonathan Druart  
---
Created attachment 50027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50027=edit
Bug 12787: Reorganise t/db_dependent files

This patch tries to reorganise test files in the db_dependent directory:
- Circulation_Branch.t   has been moved to Circulation/Branch.t
- Circulation_issuingrules.t has been moved to Circulation/CalcDateDue.t
- Circulation_Issuingrule.t  has been moved to Circulation/GetHardDueDate.t
- Circulation_dateexpiry.t   has been moved to Circulation/dateexpiry.t
- Circulation_issue.thas been moved to Circulation/issue.t
- Circulation_transfers.thas been moved to Circulation/transfers.t
- Items_DelItem.thas been moved to Items/DelItem.t
- BiblioObject.t has been moved to Koha/Biblio.t
- Members_Attributes.t   has been moved to Members/Attributes.t
- Members_columns.t  has been moved to Members/columns.t
- Circulation_OfflineOperation.t   has been moved to
Circulation/OfflineOperation.t
- Koha_template_plugin_KohaDates.t has been moved to
Template/Plugin/KohaDates.t
- Koha_template_plugin_Branches.t  has been moved to Template/Plugin/Branches.t
- Reports/Guided.t, ReportsGuided.t and Reports_Guided.t have been
  merged

Test plan:
Confirm that all the modified tests still pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

--- Comment #10 from Julian Maurice  ---
Patches rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #45799|0   |1
is obsolete||

--- Comment #8 from Julian Maurice  ---
Created attachment 50025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50025=edit
Bug 15395: Example usage of I18N Template::Toolkit plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #45798|0   |1
is obsolete||

--- Comment #7 from Julian Maurice  ---
Created attachment 50024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50024=edit
Bug 15395: Plural translations in templates

Provides a way to handle translation of plural forms in templates

Add Template::Toolkit plugin for Koha::I18N

Use like this:

[%# USE the plugin and define some macros %]
[% PROCESS 'i18n.inc' %]

[%# tn is the equivalent of __n %]
[%# macro names can't start with underscore, t is for "translate" %]
[% tn('item', 'items', num_items) %]

Extraction of strings from templates is a bit complicated and use
Template::Parser and PPI. Template is compiled into Perl code and then
analyzed by PPI. It is slow, but should be correct even with complex
constructions.

Add dependency to PPI

Test plan:
1. Open a template file (.tt or .inc) with your favorite text editor
2. Add the PROCESS directive mentioned above in the beginning of file
3. Use one of the t* macros defined in i18n.inc. They are used like
   their "__" equivalent, with one difference: the 'x' variants take a
   hashref instead of a hash as last parameter
4. cd misc/translator && ./translate update fr-FR
5. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po and translate your
   string(s)
6. ./translate install fr-FR
7. Use your web browser to go to the page that should display the
   translation, change language and verify the translation is
   correct

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #46337|0   |1
is obsolete||

--- Comment #9 from Julian Maurice  ---
Created attachment 50026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50026=edit
Bug 15395: Add plural translation capabilities to JS files

It adds Javascript equivalent of Koha::I18N's exported subroutines, and
they are used the same way.

String extraction is done only on *.js files and require gettext 0.19
(available in Debian stable, and also in wheezy-backports)

It adds Javascript library Gettext.js for handling translation and a
Perl script po2json to transform PO file into JSON.

Gettext.js and po2json both come from Locale::Simple.
There are several tools named po2json. It's simpler to integrate this
one into Koha than to check if the good one is installed on the system.
Locale::Simple is not needed.

To avoid polluting the global namespace too much, this patch also
introduce a global JS object named Koha and add some stuff in Koha.i18n

Test plan:
1. Add a translatable string in a JS file. For example, add this:
 alert(__nx("There is one item", "There are {count} items", 3,
 {count: 3}));
   to staff-global.js
2. cd misc/translator && ./translate update fr-FR
3. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po, verify that your
   string is present, and translate it
4. cd misc/translator && ./translate install fr-FR
5. (Optional) Verify that
   koha-tmpl/intranet-tmpl/prog/fr-FR/js/locale_data.js exists and
   contains your translation
6. Open your browser on the staff main page, change language and verify
   that the message is translated
7. Repeat 1-6 on OPAC side

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #45797|0   |1
is obsolete||

--- Comment #6 from Julian Maurice  ---
Created attachment 50023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50023=edit
Bug 15395: Allow correct handling of plural translation

Locale::Maketext does not allow correct handling of plural translation
for languages that have more than one plural forms.
Locale::Messages does.

So Koha::I18N is now a wrapper around Locale::Messages, just like
Locale::TextDomain, and export the same symbols as Locale::TextDomain.
You can refer to documentation of Locale::TextDomain to know how to use
exported subroutines.

The PO file moves from misc/translator/po/xx-XX-messages.po to
misc/translator/po/xx_XX/LC_MESSAGES/Koha.po and now needs to be
compiled to MO in order to be used by Koha.
Compilation of PO file is done by running:
  ./translate install xx-XX

Remove dependency to Locale::Maketext and Locale::Maketext::Lexicon
Add dependency to Locale::Messages

Test plan:
1. Open a .pl script or .pm module with your favorite text editor
2. Add 'use Koha::I18N;' in the beginning of file
3. Use one of the subroutines exported by Koha::I18N and be sure to have
   a way to visualize the result (pass result to the template for
   example, or simply warn and watch the log file)
4. cd misc/translator && ./translate update fr-FR # try other languages
5. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po and translate your
   string(s)
   You will need to change the "Plural-Forms" header. See
   https://localization-guide.readthedocs.org/en/latest/l10n/pluralforms.html
6. ./translate install fr-FR
7. Use your web browser to go to the page that should display the
   translation, change language and verify the translation is correct

Example usage:
  __("Hi")
  __x("Hi {name}", name => 'Bob')
  __n("item", "items", $num_items)
  __nx("one item", "{count} items", $num_items, count => $num_items)
  __p("Bibliographic record", "item")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Julian Maurice  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #9 from Julian Maurice  ---
No AngularJS/SomethingElseJS proposal so far, so I suggest we move forward with
this. Changing status to Needs signoff to have more opinions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757

--- Comment #22 from M. Tompsett  ---
Comment on attachment 50014
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50014
Bug 15757: Make GetLoanLength defaults to 0 instead of 21

Review of attachment 50014:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15757=50014)
-

::: t/db_dependent/Circulation_Issuingrule.t
@@ +113,5 @@
> +is_deeply(
> +C4::Circulation::GetLoanLength(),
> +$default,
> +"Without parameters, GetLoanLength returns hardcoded values"
> +);

This is an added test. If the number of tests to run is set, then you forgot to
update it.

@@ +360,3 @@
>  is_deeply(
>  C4::Circulation::GetLoanLength(),
> +$default,

Nice clean up!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

--- Comment #8 from Julian Maurice  ---
Created attachment 50022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50022=edit
Bug 14974: Try to make benefit from using the API

Previous patch immediately redirect after each action (add/edit/delete)
so there is no real benefit from using the API.
This patch move the add/edit form into a modal window, and redraw the
table after each action, so the page is never reloaded.
It also adds a messages area to put messages in (after success/error)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757

--- Comment #21 from M. Tompsett  ---
Comment on attachment 50013
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50013
Bug 15757: Add one test for GetLoanLength

Review of attachment 50013:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15757=50013)
-

::: t/db_dependent/Circulation_Issuingrule.t
@@ +113,4 @@
>  maxissueqty=> 5,
>  maxonsiteissueqty  => 4,
>  finedays   => 0,
> +lengthunit => 'days',

Why change to days?

@@ -113,4 @@
>  maxissueqty=> 5,
>  maxonsiteissueqty  => 4,
>  finedays   => 0,
> -lengthunit => 'Null',

I think the point was undef, but Data::Dumper puts out 'Null'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757

--- Comment #20 from M. Tompsett  ---
Comment on attachment 50015
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50015
Bug 15757: Make issuelength default to null instead of 0

Review of attachment 50015:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15757=50015)
-

::: admin/smart-rules.pl
@@ +140,4 @@
>  $maxonsiteissueqty =~ s/\s//g;
>  $maxonsiteissueqty = undef if $maxonsiteissueqty !~ /^\d+/;
>  my $issuelength  = $input->param('issuelength');
> +$issuelength = $issuelength eq q{} ? undef : $issuelength;

Change 142 to:
my $issuelength  = $input->param('issuelength') // q{};
-- to avoid noise triggered when parameter is undef.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16192] Coverage reports missing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16192

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Tomás Cohen Arazi  ---
This has been fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||bgkrie...@gmail.com

--- Comment #5 from Bernardo Gonzalez Kriegel  ---
Applying: Bug 15395: Example usage of I18N Template::Toolkit plugin
Using index info to reconstruct a base tree...
M   C4/Search.pm
M   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Benjamin Rokseth  changed:

   What|Removed |Added

 CC||benjamin.roks...@kul.oslo.k
   ||ommune.no

--- Comment #11 from Benjamin Rokseth  ---
Rebased against #15548 Move Koha::Borrower -> Koha::Patron

Works fine in API, but tests fail:

not ok 23 - 200 OK
#   Failed test '200 OK'
#   at t/db_dependent/api/v1/checkouts.t line 119.
#  got: '500'
# expected: '200'
not ok 24 - exact match for JSON Pointer "/date_due"
#   Failed test 'exact match for JSON Pointer "/date_due"'
#   at t/db_dependent/api/v1/checkouts.t line 119.
#  got: undef
# expected: '2016-04-14 23:59:00'
ok 25 - PUT /api/v1/checkouts/6
not ok 26 - 403 Forbidden
#   Failed test '403 Forbidden'
#   at t/db_dependent/api/v1/checkouts.t line 125.
#  got: '500'
# expected: '403'
not ok 27 - exact match for JSON Pointer ""
#   Failed test 'exact match for JSON Pointer ""'
#   at t/db_dependent/api/v1/checkouts.t line 125.
# Structures begin differing at:
#  $got = undef
# $expected = HASH(0xa7d1648)
# Looks like you failed 4 tests of 27.

Relevant log entry:

No branchcode argument passed to Koha::Calendar->new at
/kohadev/kohaclone/C4/Circulation.pm line 3588

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #45817|0   |1
is obsolete||

--- Comment #10 from Benjamin Rokseth  ---
Created attachment 50021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50021=edit
Bug 13895: Add API routes for checkouts retrieval and renewal

GET /checkouts?borrowernumber={borrowernumber}
GET /checkouts/{checkout_id}
PUT /checkouts/{checkout_id}

+ unit tests in t/db_dependent/api/v1/checkouts.t

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission circulate_remaining_permissions.
2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
   XXX with a borrowernumber that has checkouts) and check you receive
   correct data
3. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
   existing checkout id) and check you receive correct data
4. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until
   the maximum number of renewals is reached (you should have a 403
   error)
5. Run unit tests in t/db_dependent/api/v1/checkouts.t

Depends on bug 15126

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #55 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #54)
> I personally do not like the idea to move the strings to the pl scripts.

Why ? :)
I sometimes feel that extra effort is put into moving strings to template file
(and we do this only because that's the only place where they can be
translated)

> Moreover we have tried to use the KohaDates plugin as much as possible in
> template files, which you are reverting with this patch.

I don't understand why this is an issue, the message is now in .pl script so
the date formatting happens here. It seems logical.

Note that moving message from .tt to .pl is not the main purpose of this bug,
if you have another solution in mind I will gladly hear it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #54 from Jonathan Druart  
---
I personally do not like the idea to move the strings to the pl scripts.
Moreover we have tried to use the KohaDates plugin as much as possible in
template files, which you are reverting with this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16190] Enable the indexer daemon by default

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16190

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #50003|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 50020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50020=edit
Bug 16190: Enable the indexer daemon by default

This patch enables the indexer daemon by default on packages installs.
It does so by setting USE_INDEXER_DAEMON=yes on the /etc/default/koha-common
file. It does remove now irrelevant comments from that file.

This patch is straightforward to review. If is just a matter of choosing
to enable or not to enable by default.

Kind regards

PS: Let end users rejoice this so far hidden feature :-D

Signed-off-by: Hector Castro 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16190] Enable the indexer daemon by default

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16190

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15113] koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15113

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #50004|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 50019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50019=edit
Bug 15113: koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if
enabled

This patch changes the behaviour of the koha-rebuild-zebra script in the
following way:

USE_INDEXER_DAEMON=no
- Keeps the current behaviour

USE_INDEXER_DAEMON=yes
- It skips incremental indexing to avoid races.

Caveats:
- A --force option is introduced for useing in a specific situtation that might
need it
 (i.e. the administrator knows what he's doing).
- If --full is passed, the reindexing is not skipped.

The documentation files and messages are adjusted accordingly.

This patch should help users that want to use the indexing daemon, in which
case they wouldn't need
to change their default 5 min cronjob (it will be just skipped). Ultimately,
koha-common could have
USE_INDEXER_DAEMON = yes by default, but that's subject for another bug report.

To test:
- Play with the different option switches and USE_INDEXER_DAEMON
- Things work as expected
- Sign off

Regards

Signed-off-by: Hector Castro 
Works as expected

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15113] koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15113

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Lari Taskula  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15157

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157

Lari Taskula  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16223

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16223] New: Automatically remove any borrower debarments after a payment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Bug ID: 16223
   Summary: Automatically remove any borrower debarments after a
payment
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: la...@student.uef.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Some libraries debar Borrowers at the end of the year for having unpaid fines,
like in Bug 15157. Currently librarians have to manually remove this type of
debarments after Borrower has paid his/her fines. Add a system preference to
define debarments that should be automatically removed after a payment is made,
and add functionality to actually remove the defined debarments from Borrower.
Also let libraries to define the amount of outstanding fines after payment
after which the debarment will be removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #104 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #102)
> 2/
>   prove t/db_dependent/Items.t t/db_dependent/Circulation/Returns.t
> displays warnings like
>   item-level_itypes set but no itemtype set for item
> (Koha::Schema::Result::Item=HASH(0xce35808)->itemnumber) at
> Koha/Schema/Result/Item.pm line 662.

Fixed in last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #103 from Jonathan Druart  
---
Created attachment 50018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50018=edit
Bug 14598: Fix warning from effective_itemtype

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #102 from Jonathan Druart  
---
(I have squashed the patches for the review)

1/
C4/Circulation.pm
1868 my $biblio   = $item_level_itypes ? undef : GetBiblioData( $item->{
biblionumber } ); # don't get bib data unless we need it

Should not we use GetBiblioItemByBiblioNumber instead to avoid 2 left joins per
return?

2/
  prove t/db_dependent/Items.t t/db_dependent/Circulation/Returns.t
displays warnings like
  item-level_itypes set but no itemtype set for item
(Koha::Schema::Result::Item=HASH(0xce35808)->itemnumber) at
Koha/Schema/Result/Item.pm line 662.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/