[Koha-bugs] [Bug 11422] LIMIT $offset, $limit not compatible with PostgreSQL

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11422

Tom Misilo  changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11390] DBIx::Class schema deployment script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11390

Tom Misilo  changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7806] Illegal dates are used to signal non existing dates.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806

Tom Misilo  changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7365] Koha should support PostgreSQL

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365

Tom Misilo  changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Nick Clemens  changed:

   What|Removed |Added

  Attachment #50246|0   |1
is obsolete||

--- Comment #238 from Nick Clemens  ---
Created attachment 50292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50292=edit
Bug 12478 Increasing test Coverage for
Koha::SearchEngine::Elasticsearch::Search

Before this patch it was 24.6%, after it is 64%

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Nick Clemens  changed:

   What|Removed |Added

  Attachment #50245|0   |1
is obsolete||

--- Comment #237 from Nick Clemens  ---
Created attachment 50291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50291=edit
Bug 12478 Shifting tests and adding copyright headers

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16277] Translations of intranet-tmpl/prog/en/modules/help/tools/letter.tt use RESERVESLIP rather than HOLD_SLIP

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16277

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 CC||katrin.fisc...@bsz-bw.de
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---
The po files are only updated before a release - so this is not a bug, but will
be fixed with the normal translation workflow.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16243] Add reference manager software (Mendeley and EasyBib) to OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
Summary|Add Mendeley reference  |Add reference manager
   |manager to OPAC |software (Mendeley and
   ||EasyBib) to OPAC

--- Comment #10 from Héctor Eduardo Castro Avalos  
---
Hi Owen I have changed the bug according your comment but also I've been added
EasyBib to the options. A new syspref has been introduced
'OpacManagerReference'

This is just for record results. I'll work in basket, detail record and list as
soon as possible, please test

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16243] Add Mendeley reference manager to OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #50208|0   |1
is obsolete||
  Attachment #50208|1   |0
   is patch||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16243] Add Mendeley reference manager to OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243

--- Comment #9 from Héctor Eduardo Castro Avalos  ---
Created attachment 50290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50290=edit
Bug 16243: Add reference manager software (Mendeley and EasyBib) to OPAC

Mendeley provides a mechanism for export bib records to a personal account
in a free reference manager and academic social network (similar to Zotero)

EasyBib Generate citations in MLA, APA & Chicago formats for bibliographies


To test:
- Apply patch
- Run perl installer/data/mysql/updatedatabase.pl
- On master, search for the  syspref OpacReferenceManager
- Enable the two options
- Do a search for books
- Notice about the new option 'Export to Reference Manager' in search results
- Create an account in Mendeley (Is free)
- Click in new option and notice that you can save bib references in Mendeley
- Click in new option Cite on EasyBib, you will see the records selected in
  EasyBib

NOTE: Fixed according with QA comment

Sponsored-by: Universidad de El Salvador

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

R-Bit Technology, s.r.o.  changed:

   What|Removed |Added

 CC||r...@rbit.cz
 Status|Needs Signoff   |In Discussion

--- Comment #27 from R-Bit Technology, s.r.o.  ---
Inspecting the last attachment 50286 I cannot find if periodical biblios are
well processed. This special case concerns a scenario where a borrower is about
to get another item of the same periodical title. In such a situation we need
to check if the same item was already issued and not the same biblio only.
There are borrowers ckecking-out several items if the same title at once. It
seems to me that the current solution would ask for N-1 items to "Checkout
anyway?". We should ask for repeating items of periodicals only.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16221] Use Storable::dclone() instead of Clone::clone() for L1 cache deep-copying mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16221

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #50281|0   |1
is obsolete||

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 50289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50289=edit
Bug 16221: follow-up for changes made by bug 16229

Signed-off-by: Jonathan Druart 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16221] Use Storable::dclone() instead of Clone::clone() for L1 cache deep-copying mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16221

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16221] Use Storable::dclone() instead of Clone::clone() for L1 cache deep-copying mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16221

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #50280|0   |1
is obsolete||

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 50288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50288=edit
Bug 16221: Use Storable::dclone() instead of Clone::clone() for L1 cache
deep-copying mode

Storable dclone() is over 3x faster then Clone::clone() when used for
creating a deep copies of the big, complex data structures like MARC
frameworks. See also Bug 16044 comments #18 & #20.

This is a trivial version of Bug 16166. Performance test
results (see Bug 16140 comment #23 for test setup description):

146.29 (14.64+14.53+14.51+14.57+14.72+14.56+14.53+15.06+14.56+14.61)

96.5 (9.77+9.63+9.77+9.77+9.68+9.05+9.68+9.83+9.63+9.69)

90.7 (9.15+9.10+9.16+8.41+9.19+9.19+9.11+9.19+9.02+9.18)

Bug 16166 is a bit faster and more comprehensive implementation, but
also more complex and harder to test/evaluate.

Test plan:

1) apply patch
2) profile GetMarcStructure() calls before / after patch, e.g. by
running some script which calls it often (like catalogue search
w/ XSLT processing turned on, etc.)

Signed-off-by: Jonathan Druart 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16278] New: Export.pl Tool needs select all/unselect all boxes for Library section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16278

Bug ID: 16278
   Summary: Export.pl Tool needs select all/unselect all boxes for
Library section
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: hbr...@nekls.org
QA Contact: testo...@bugs.koha-community.org

The export.pl tool needs select all and unselect all boxes for the Library
section. 

Right now, if you're only wanting a certain library's records exported, you
have to unchecked lots of boxes (if you're in a multi-branch system). For us,
that's 51 boxes to uncheck.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15938] Use validation plugin when adding or editing classification sources and filing rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15938

--- Comment #3 from Owen Leonard  ---
Bonus: This patch brings classsources.tt into compliance with the new JS9
coding guideline.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

--- Comment #46 from Jonathan Druart  
---
After discussion with Mirko, we have found some others issues with the
--letsencrypt param:

check_letsencrypt should not be called unless the param is passed
If you are a liar and the symlink does not exist, you get a weird error from
adduser (adduser: Please enter a username matching the regular expression
configured)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

Alex Sassmannshausen  changed:

   What|Removed |Added

  Attachment #50243|0   |1
is obsolete||

--- Comment #26 from Alex Sassmannshausen 
 ---
Created attachment 50286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50286=edit
Fixed Post-QA revised patch.

Apologies — during the refactoring for this feature to be implemented as
methods upon Patron, I lost the import of Koha::Patron::Categories.

The unit tests did not catch this as I was importing Categories independently
there.

Both have now been fixed.

Thanks for testing!

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

--- Comment #47 from Mirko Tietgen  ---
Created attachment 50287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50287=edit
Bug 15303 QA-Followup: check_letsencrypt only if --letsencrypt is used

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

--- Comment #48 from Mirko Tietgen  ---
(In reply to Jonathan Druart from comment #46)
> After discussion with Mirko, we have found some others issues with the
> --letsencrypt param:
> 
> check_letsencrypt should not be called unless the param is passed

Patch added.

> If you are a liar and the symlink does not exist, you get a weird error from
> adduser (adduser: Please enter a username matching the regular expression
> configured)

That was actually due to a too short instance name. You get the same if you do
it without --letsencrypt.

> sudo koha-create --create-db LE
> adduser: Bitte geben Sie einen Benutzernamen ein, der die Kriterien des
> regulären Ausdrucks erfüllt, welcher in der Konfigurationsvariablen 
> NAME_REGEX > festgelegt ist. Verwenden Sie die Option »--force-badname«, um
> die Überprüfung weniger strikt durchzuführen, oder ändern Sie NAME_REGEX.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

Alex Sassmannshausen  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16265] Making item types actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16265

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #50267|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 50285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50285=edit
Bug 16265: Making item types actions buttons

To test:
1) Go to Admin -> Item types
2) Confirm Edit and Delete show as font awesome buttons and work as expected
3) Confirm the buttons do not wrap with a narrower browser

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16265] Making item types actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16265

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16266] Making patron types actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16266

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #50268|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 50284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50284=edit
Bug 16266: Making patron types actions buttons

To test:
1) Go to Admin -> Patron types & Categories
2) Confirm the actions Edit and Delete show as font awesome buttons and work as
expected
3) Confirm that the buttons do not wrap on a narrower browser

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16266] Making patron types actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16266

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

--- Comment #45 from Mirko Tietgen  ---
Created attachment 50283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50283=edit
Bug 15303 Followup: Fix apt-cache show breaking koha-create

Temporarely set +e so the test for the LE package does not break
koha-create

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16262] Remove the use of "onclick" from acquisitions basket template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16262

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #50275|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 50282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50282=edit
Bug 16262 - Remove the use of "onclick" from acquisitions basket template

In order to bring the acquisitions basket template into compliance with
coding guideline JS9, this patch changes with way some JavaScript events
are handled by moving JS handling out of the HTML markup.

Also changed: Replaced the use of [% script_name %] (which is
undefined), with the actual script path.

To test, apply the patch and locate an open basket in Acquisitions which
has more than one order in it.

- Test the "Managed by: Add user" button and verify that it triggers a
  popup where you can search for patrons.
  - Select two or more patrons to be managers for the basket.
  - Close the search windows and confirm that your choices appear on the
basket page.
  - Click "Delete user" next to one of the patrons. The patron should be
removed.
  - Click "Save changes" and verify that your choices are correctly
saved.
  - Click "Delete user" next to one of the remaining patrons. The patron
should be removed.
  - Click "Save changes" and verify that the patron stays deleted.
- In the list of orders, click the "Transfer" link and confirm that the
  correct pop-up window is triggered.
- Test the "Delete this basket" button in the toolbar. A modal window
  should be triggered.
  - In a basket with orders:
- The "Delete basket and orders" button should do what it says,
  leaving associated bibliographic records intact.
- The "Delete basket, orders, and records" button should do what it
  says, deleting any bibliographic records associated with orders.
  - In a basket with no orders:
- The "Delete basket" button should work correctly.
- Test the "Create edifact order" button.
  - Click "Send EDI order" on the resulting page.
  - In the resulting dialog, "Are you sure you want to generate an
edifact order," verify that both the "Yes" and "No" options work
correctly.

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16262] Remove the use of "onclick" from acquisitions basket template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16262

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #25 from Owen Leonard  ---
When I go to check something out I get this error:

Can't locate object method "find" via package "Koha::Patron::Categories"
(perhaps you forgot to load "Koha::Patron::Categories"?) at Koha/Patron.pm line
122.

This happens when the preference is either "softyes" or "softno." If the
preferences is "hardyes" or "hardno" it works without an error.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16221] Use Storable::dclone() instead of Clone::clone() for L1 cache deep-copying mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16221

--- Comment #9 from Jonathan Druart  
---
decrease from 134 to 64!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16221] Use Storable::dclone() instead of Clone::clone() for L1 cache deep-copying mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16221

--- Comment #8 from Jonathan Druart  
---
Created attachment 50281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50281=edit
Bug 16221: follow-up for changes made by bug 16229

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16221] Use Storable::dclone() instead of Clone::clone() for L1 cache deep-copying mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16221

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #50011|0   |1
is obsolete||
  Attachment #50077|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 50280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50280=edit
Bug 16221: Use Storable::dclone() instead of Clone::clone() for L1 cache
deep-copying mode

Storable dclone() is over 3x faster then Clone::clone() when used for
creating a deep copies of the big, complex data structures like MARC
frameworks. See also Bug 16044 comments #18 & #20.

This is a trivial version of Bug 16166. Performance test
results (see Bug 16140 comment #23 for test setup description):

146.29 (14.64+14.53+14.51+14.57+14.72+14.56+14.53+15.06+14.56+14.61)

96.5 (9.77+9.63+9.77+9.77+9.68+9.05+9.68+9.83+9.63+9.69)

90.7 (9.15+9.10+9.16+8.41+9.19+9.19+9.11+9.19+9.02+9.18)

Bug 16166 is a bit faster and more comprehensive implementation, but
also more complex and harder to test/evaluate.

Test plan:

1) apply patch
2) profile GetMarcStructure() calls before / after patch, e.g. by
running some script which calls it often (like catalogue search
w/ XSLT processing turned on, etc.)

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16221] Use Storable::dclone() instead of Clone::clone() for L1 cache deep-copying mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16221

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #19 from Owen Leonard  ---
The redirect is failing for me on circulation.pl if I arrive at the page via a
form submission. It works if I come to the page via
circulation.pl?borrowernumber=X or circulation.pl?findborrower=X.

The same is true for the batch checkout page. If I click the batch checkout
link, then try to add a message the redirect works. If I perform a batch
checkout and then try to add a message the redirect fails.

In by cases what I mean by "fails" is that I'm returned to a "blank"
circulation.pl with no patron loaded.

This is true of paycollect.pl too, so I assume it's true for any page which
loads the patron record via a POST operation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15443] Re-code RESERVESLIP as HOLD_SLIP

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15443

Barton Chittenden  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16277

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16277] Translations of intranet-tmpl/prog/en/modules/help/tools/letter.tt use RESERVESLIP rather than HOLD_SLIP

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16277

Barton Chittenden  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15443

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16277] New: Translations of intranet-tmpl/prog/en/modules/help/tools/letter.tt use RESERVESLIP rather than HOLD_SLIP

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16277

Bug ID: 16277
   Summary: Translations of
intranet-tmpl/prog/en/modules/help/tools/letter.tt use
RESERVESLIP rather than HOLD_SLIP
 Change sponsored?: ---
   Product: Koha
   Version: 3.18
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

bug 15443 changed the notice 'RESERVESLIP' to 'HOLD_SLIP', but all of the
translations under misc/translator/po/ still point to "RESERVESLIP " ... e.g.

misc/translator/po/de-DE-staff-help.po

14046 #: intranet-tmpl/prog/en/modules/help/tools/letter.tt:281
14047 #, c-format
14048 msgid "RESERVESLIP "
14049 msgstr "RESERVESLIP "
14050

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16259] More: Replace CGI->param with CGI->multi_param in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16259

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16259] More: Replace CGI->param with CGI->multi_param in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16259

Owen Leonard  changed:

   What|Removed |Added

  Attachment #50256|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 50279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50279=edit
[SIGNED-OFF] Bug 16259: Replace CGI->param with CGI->multi_param in list
context - part 2

This patch is a follow-up of bug 16154.

It removes the warning "CGI::param called in list context" in the
following scripts:
admin/branches.pl
admin/categories.pl
admin/patron-attr-types.pl
admin/preferences.pl
catalogue/image.pl
circ/circulation.pl
patroncards/add_user_search.pl
serials/add_user_search.pl
tools/marc_modification_templates.pl
virtualshelves/shelves.pl

Note that the warning from catalogue/itemsearch.pl still exists (the
call to CGI->param is done from the template).

Test plan:
- Add/modify a library, patron category, patron attr type
- Update a syspref
- Set localcoverimage and call catalogue/image.pl?biblionumber=XXX
- Search for patrons in the patron cards or serials module
- Add a marc modification templates
- Add a list (shelves)

You should not get the warning in the log after all these actions.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #44 from Jonathan Druart  
---
Using Jessie without backport enabled:

sudo koha-create --create-db --letsencrypt LE
Does not return anything but errno 100

Because
% apt-cache show letsencrypt
  N: Unable to locate package letsencrypt
  E: No packages found
% echo $?
  100

The line
+apt-cache show letsencrypt &>/dev/null
is wrong

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16270] Typo authentification vs authentication in 404

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16270

Marc Véron  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #5 from Marc Véron  ---
Switching back to NSO for the followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16270] Typo authentification vs authentication in 404

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16270

--- Comment #4 from Marc Véron  ---
Created attachment 50278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50278=edit
Bug 16270 (followup) Typo authentification vs authentication

Additionally fix typo in following files:
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt

To test: Apply patch, verify in files that authentification is
 replaced by authentication

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #77 from Julian Maurice  ---
(In reply to Katrin Fischer from comment #74)
> For the CSV:
> 1) the solution you propose will require a new po file to be set up on
> pootle - so I would not mix this change in here to avoid further discussion.
> We should resolve the question of using Koha:I18N separately. I'd like to
> see this bug resolved after more than 4 years! :)
> 2) there is an existing solution to make this work in other places - so that
> would be an easy solution for now. We could also move this to a separate bug
> report if totally necessary.

I'm wondering why Koha::I18N was accepted in the first place if nobody want to
use it :)
But you are right about the pootle thing, so I used a .tt file for
translatability

Resetting status to Signed off as these patches are minor changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16262] Remove the use of "onclick" from acquisitions basket template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16262

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=7736|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16167] Remove prefs to drive authorised value images

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167

Owen Leonard  changed:

   What|Removed |Added

  Attachment #50262|0   |1
is obsolete||

--- Comment #10 from Owen Leonard  ---
Created attachment 50277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50277=edit
[SIGNED-OFF] Bug 16167: Remove Authorised value images prefs

There are 2 prefs to drive this feature: StaffAuthorisedValueImages and
AuthorisedValueImages. AuthorisedValueImages is not added by
sysprefs.sql and does not appear in updatedatabase.pl, we could easily
imagine that nobody uses it.

With XSLT enabled, the feature is only visible on a record detail page
at the OPAC, if AuthorisedValueImages is set. Otherwise you need to turn
the XSLT off. In this case you will see the images on the result list
(OPAC+Staff interfaces) and OPAC detail page, but not the Staff detail
page.

This patch suggests to remove completely this feature as it does not
work correctly.

The ability to assign an image to an authorised value is now always
displayed, but the image will only be displayed on the advanced search
if defined.

Test plan:
Confirm that the authorised value images are no longer visible at the
opac and the staff interfaces.
The prefs should have been removed too.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16167] Remove prefs to drive authorised value images

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16167] Remove prefs to drive authorised value images

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167

Owen Leonard  changed:

   What|Removed |Added

  Attachment #49838|0   |1
is obsolete||

--- Comment #9 from Owen Leonard  ---
Created attachment 50276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50276=edit
[SIGNED-OFF] Bug 16167: Atomic update

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Marc Véron  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=16262   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16262] Remove the use of "onclick" from acquisitions basket template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16262

Marc Véron  changed:

   What|Removed |Added

  Attachment #50244|0   |1
is obsolete||

--- Comment #3 from Marc Véron  ---
Created attachment 50275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50275=edit
Bug 16262 - Remove the use of "onclick" from acquisitions basket template

In order to bring the acquisitions basket template into compliance with
coding guideline JS9, this patch changes with way some JavaScript events
are handled by moving JS handling out of the HTML markup.

Also changed: Replaced the use of [% script_name %] (which is
undefined), with the actual script path.

To test, apply the patch and locate an open basket in Acquisitions which
has more than one order in it.

- Test the "Managed by: Add user" button and verify that it triggers a
  popup where you can search for patrons.
  - Select two or more patrons to be managers for the basket.
  - Close the search windows and confirm that your choices appear on the
basket page.
  - Click "Delete user" next to one of the patrons. The patron should be
removed.
  - Click "Save changes" and verify that your choices are correctly
saved.
  - Click "Delete user" next to one of the remaining patrons. The patron
should be removed.
  - Click "Save changes" and verify that the patron stays deleted.
- In the list of orders, click the "Transfer" link and confirm that the
  correct pop-up window is triggered.
- Test the "Delete this basket" button in the toolbar. A modal window
  should be triggered.
  - In a basket with orders:
- The "Delete basket and orders" button should do what it says,
  leaving associated bibliographic records intact.
- The "Delete basket, orders, and records" button should do what it
  says, deleting any bibliographic records associated with orders.
  - In a basket with no orders:
- The "Delete basket" button should work correctly.
- Test the "Create edifact order" button.
  - Click "Send EDI order" on the resulting page.
  - In the resulting dialog, "Are you sure you want to generate an
edifact order," verify that both the "Yes" and "No" options work
correctly.

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263

--- Comment #2 from Owen Leonard  ---
Created attachment 50274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50274=edit
Menu gets cut off if browser window isn't very wide

Could you switch

http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
  Component|MARC Authority data support |System Administration
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact|jonathan.dru...@bugs.koha-c |testo...@bugs.koha-communit
   |ommunity.org|y.org

--- Comment #43 from Jonathan Druart  
---
I am getting crazy with my setup, I have not managed to test this patch
entirely to pass QA on it: cannot package it, cannot install the .deb Mirko
gave me (kohadevbox:ansible raises lot of updatedatabase warnings, on a lxc
koha-common stuck on random step (configure apache-mpm-itk or cron or at, etc.)
Reading the code, everything looks good.
Hope to see someone QA it before the feature freeze.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

--- Comment #169 from Katrin Fischer  ---

> > Can't call method "GetPlugins" on an undefined value at
> > /home/katrin/kohaclone/admin/edi_accounts.pl line 56.
> 
> Same problem here.

Bug 16237 fixed it for me - it's PQA now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

--- Comment #76 from Julian Maurice  ---
Created attachment 50273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50273=edit
Bug 7957: Make CSV header translatable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16268] Add confirm message when deleting circ and fines rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16268

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Owen Leonard  ---
This patch violates the newly approved and newly added to the wiki (as of
yesterday) coding guideline JS9: "Avoid the use of event attributes like
"onclick" to attach events."

https://wiki.koha-community.org/wiki/Coding_Guidelines#JS9:_Avoid_the_use_of_event_attributes_like_.22onclick.22_to_attach_events

There is a simple function in staff-global.js which seems to be seldom used,
but it could be in this case:

function confirmDelete(message) {
return (confirm(message) ? true : false);
}

---

$(document).ready(function(){
$(".delete_rule").on("click",function(){
return confirmDelete(MSG_CONFIRM_DELETE);
});
});

I have started the process of tracking down and cleaning up use of "onclick"
(See Bug 16262) but there are many templates to fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16276] New: When automatically suppressing expired borrowers, make sure they didn't log them selves recently

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Bug ID: 16276
   Summary: When automatically suppressing expired borrowers, make
sure they didn't log them selves recently
 Change sponsored?: Sponsored
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: nicolas.legr...@bulac.fr
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

We would like to automate the delation of expired patrons to comply to french
laws regarding privacy. But we don't want to delate an expired patron which is
still using the OPAC for bibliographical purpose, like managing lists. We would
like to be able to say when the patron logged himself for the last time to
permit this.

Whith this parameter we would like to be able to use it from
misc/cronjobs/delete_patrons.pl and also with the "Clean Patron Records"
intranet page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16271] Allow more filters on /api/v1/reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271

Benjamin Rokseth  changed:

   What|Removed |Added

 CC||benjamin.roks...@kul.oslo.k
   ||ommune.no
 Status|Needs Signoff   |Signed Off

--- Comment #3 from Benjamin Rokseth  ---
Brilliant work Julian! Works perfectly! Let the new API rule

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16271] Allow more filters on /api/v1/reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #50263|0   |1
is obsolete||

--- Comment #2 from Benjamin Rokseth  ---
Created attachment 50272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50272=edit
Bug 16271: Allow more filters on /api/v1/reserves

borrowernumber parameter is no longer required and you can filter on
every column of reserves table

Some example requests
- GET /api/v1/reserves
- GET /api/v1/reserves?biblionumber=123
- GET /api/v1/reserves?borrowernumber=456
- GET /api/v1/reserves?priority=0=W

Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

--- Comment #42 from Mirko Tietgen  ---
Created attachment 50271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50271=edit
Bug 15303 Followup for koha-remove

This patch makes koha-remove take care of

/etc/letsencrypt/renewal/$opacdomain.conf
/var/lib/koha/$site/letsencrypt.enabled

It also adds a few helper functions.

To test
- create a koha instance with LE
- observe you got both files mentioned above
- remove that instance
- verify the files are gone

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16262

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16262] Remove the use of "onclick" from acquisitions basket template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16262

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=7736

--- Comment #2 from Marc Véron  ---
Followed testplan, works OK, but EDIFACT part of test plan not tested.
See comments on Bug 7736.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #1 from Marc Véron  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16257

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16257] EDIfact messages link on tools page results error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16257

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=7736

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

--- Comment #168 from Marc Véron  ---
(In reply to Katrin Fischer from comment #167)
> I have an error when trying to add a new EDI account:
> Software error:
> 
> Can't call method "GetPlugins" on an undefined value at
> /home/katrin/kohaclone/admin/edi_accounts.pl line 56.

Same problem here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16275] New: Prevent patron creation if the email already filled in borrowers.email

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275

Bug ID: 16275
   Summary: Prevent patron creation if the email already filled in
borrowers.email
 Change sponsored?: Sponsored
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: nicolas.legr...@bulac.fr
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Some of our patrons are not sure they succeed their self registration and self
register multiple times. We would like to prevent this by blocking the
selfregistration if the field borrowers.email is already filled by the same
email address.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

--- Comment #75 from Julian Maurice  ---
Created attachment 50270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50270=edit
Bug 7957: Make routing list title editable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16257] EDIfact messages link on tools page results error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16257

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #1 from Marc Véron  ---
Confirmed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16270] Typo authentification vs authentication in 404

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16270

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16270] Typo authentification vs authentication in 404

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16270

Owen Leonard  changed:

   What|Removed |Added

  Attachment #50255|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 50269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50269=edit
[SIGNED-OFF] Bug 16270: Typo authentification/authentication

Test plan;
Trigger /cgi-bin/koha/errors/404.pl
Confirm the typo without the patch and that it's fixed with this patch
applied.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16274] New: Make the selfregistration branchcode selection configurable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16274

Bug ID: 16274
   Summary: Make the selfregistration branchcode selection
configurable
 Change sponsored?: Sponsored
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: nicolas.legr...@bulac.fr
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

We would like to set the list of branchcodes available for selfregistration and
not having all of them.

A syspref containing a string with branchcode separated by a pipe should be
fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16273] New: Prevent selfregistration from printing the borrower password and filling the logging form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16273

Bug ID: 16273
   Summary: Prevent selfregistration from printing the borrower
password and filling the logging form
 Change sponsored?: Sponsored
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: nicolas.legr...@bulac.fr
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

At the BULAC Library, we use selfregistration on dedicated computer and we
would like to prevent the validation display from printing the patron password
and from filling the logging form. Some other person queuing for
selfregistration may see the password or log the the other patron account if
the later doesn't close the page.

A new syspref should be set to keep the old behaviour or choose this new one.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16272] New: Transform checkout from on-site checkout to regular checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Bug ID: 16272
   Summary: Transform checkout from on-site checkout to regular
checkout
 Change sponsored?: Sponsored
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: nicolas.legr...@bulac.fr
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

At the BULAC library, patrons may ask more one-site checkouts than regular
checkouts. Often they request a bunch of books from the stacks, get them
checked out as on-site checkouts, consult them. Eventually they come back to
the desk asking to check in books they are not interested in and transform
their on-site checkout to regular checkouts on books they wish to bring home.

We would like to have a quick way to do this on the intranet: by checkin out an
item which is on-site checked out for the same borrower, we would like the loan
to become a regular check out.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16235] Making borrower account actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||ve...@veron.ch

--- Comment #6 from Marc Véron  ---
Sorry, QA tools complain:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
   FAIL   forbidden patterns
forbidden pattern: tab char (line 114)
forbidden pattern: tab char (line 112)
forbidden pattern: tab char (line 122)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16266] Making patron types actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16266

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16266] Making patron types actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16266

Marc Véron  changed:

   What|Removed |Added

  Attachment #50250|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 50268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50268=edit
Bug 16266: Making patron types actions buttons

To test:
1) Go to Admin -> Patron types & Categories
2) Confirm the actions Edit and Delete show as font awesome buttons and work as
expected
3) Confirm that the buttons do not wrap on a narrower browser

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16265] Making item types actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16265

Marc Véron  changed:

   What|Removed |Added

  Attachment #50249|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 50267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50267=edit
Bug 16265: Making item types actions buttons

To test:
1) Go to Admin -> Item types
2) Confirm Edit and Delete show as font awesome buttons and work as expected
3) Confirm the buttons do not wrap with a narrower browser

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16265] Making item types actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16265

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16270] Typo authentification vs authentication in 404

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16270

--- Comment #2 from Marc Véron  ---
There seem to be more occurences of authentification instead of authentication:

Visible in user interface:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt

Other places:

C4/Auth.pm
C4/Auth_with_ldap.pm
C4/InstallAuth.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16270] Typo authentification vs authentication in 404

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16270

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
Summary|Typo anthentification vs|Typo authentification vs
   |authentication in 404   |authentication in 404

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

--- Comment #74 from Katrin Fischer  ---
Hi Julian,

the Cache::RemovalStrategy::LRU::FIELDS is a general problem right now and will
be fixed with another patch (it's somewhere in the PQA queue).

I am pretty sure 4) was my problem - I will verify that with a new database.

By description I meant the field you fill out when creating a new routing list
- the one that is set to "import" (would be nice to find something better) for
routing lists you had before. I think it should absolutely be possible to edit
that. You pick the routing list by that name from the list if you have more
than one and libraries will want to use that to store information - fix typos,
etc. - or just change the 'import' to something more meaningful.

Otherwise I thought this looked good so far - but I still have some things to
test like the routing list holds (will be happy to see bug 2894 resolved!)

For the CSV:
1) the solution you propose will require a new po file to be set up on pootle -
so I would not mix this change in here to avoid further discussion. We should
resolve the question of using Koha:I18N separately. I'd like to see this bug
resolved after more than 4 years! :)
2) there is an existing solution to make this work in other places - so that
would be an easy solution for now. We could also move this to a separate bug
report if totally necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

--- Comment #73 from Julian Maurice  ---
(In reply to Katrin Fischer from comment #69)
> there are a couple of problems here noted by he QA script:
> - tabs
> - license
> - Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo
> (can be ignored)
tabs and license fixed, but git grep 'Cache::RemovalStrategy::LRU::FIELDS'
returns nothing. I don't know what this error is about.

> 
> From looking at the code:
> 
> 1) This is a translation issue - please take a look at how other CSV exports
> solve the problem.
> +my @headers = ("Subscription title", "Routing list", qw(Surname
> Firstname Notes));
I have seen different ways of doing CSV export, but I assume you are talking
about the one which use a .tt file.
Is this really necessary ? We could just wrap the strings into calls to
Koha::I18N::gettext().
I didn't see much enthusiasm about having translatable strings in .pl/.pm (cf.
bug 11904) but I think it's one of the cases that could greatly benefit from
Koha::I18N.

> 3) How can you edit a routing list description? I tried to change the
> routing lists created by the update - but failed to find a link.
By 'description' do you mean the 'title' field ? If so, it's not editable at
the time, but it's not really intended. It could be changed.

> 4) I can add patrons to the subscription list, but the borrowers don't save.
> Could you please check?
You mean you can add them in the interface, but when you click on 'Save' the
list of borrowers is lost ? It works for me. Could you check the logs to see if
you have any SQL error ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

--- Comment #72 from Julian Maurice  ---
Created attachment 50266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50266=edit
Bug 7957: Fix typo "There {is -> are} no borrowers"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

--- Comment #71 from Julian Maurice  ---
Created attachment 50265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50265=edit
Bug 7957: QA fixes (tabs, POD, GPL version)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

--- Comment #41 from Mirko Tietgen  ---
It's actually

letsencrypt renew --dry-run

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

--- Comment #40 from Mirko Tietgen  ---
About renewal, the Debian LE package can do that automatically now. letsencrypt
--renew renews all certs that are valid for < 30 days I think. You can test
that with

> letsencrypt --renew --dry-run

LE puts the conf files in /etc/letsencrypt/renewal/$opacdomain.conf

I will provide a followup to remove that with koha-remove to avoid problems. I
will also remove $instance/letsencrypt.enabled to prevent errors. The folder is
not deleted automatically by koha-remove.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2658] Issues Made with Offline Circulation Cannot be Renewed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2658

Atif  changed:

   What|Removed |Added

 CC||matif2...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #11 from Marcel de Rooy  ---
QA Comment:
Thanks for your patch, David.
BTW This is imo not a trivial patch or something to signoff for an academy
user, new to Koha.
[1] Although your changes in SimpleSearch are very small, it would probably
help if you would add a test case in t/db_dependent/Search.t. (It seems to fail
some tests currently, separate from your patch.)
[2] The source_normalizer or norms just lead me to two FIXMEs:
# FIXME normalize, substr
# FIXME - default normalizer
You introduce none and raw in the regex while this field actually does nothing
(and should not have been there in this stage). Your patch starts using this
field, while the only thing you want is not running _normalize for (mainly?)
URLs. If we do not really solve the problem of this unused field, I think we
should not touch it. BTW What would be the difference between raw and none? The
regex suggests more than what we offer.
[3] I have some doubts about this new condition:
if ($QParser && $matchpoint->{'index'} !~ m/\w,\w/) {
Somehow you managed to bump in another unfinished area here too :) 
I would rather leave the condition as it was. In the QParser branch you could
choose to ignore/remove the second specifier word with a similar regex.

Changing status for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

--- Comment #10 from Marcel de Rooy  ---
Created attachment 50264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50264=edit
Bug 15541: [QA Follow-up] Add new SimpleSearch argument to POD

Also moved one line conform the order of arguments.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/