[Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #49406|0   |1
is obsolete||
  Attachment #50326|0   |1
is obsolete||

--- Comment #26 from Jonathan Druart  
---
Created attachment 50389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50389&action=edit
Bug 15534 - Add the ability to prevent a patron from placing a hold on a record
with available items

Some libraries would like to prevent patrons from placing holds on
items where there are other items available for the patron to
check out.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Browse to the circulation rules
4) Note the new option for "On shelf holds allowed"
5) Set the rule to "If all unavailable", set "item level holds" to allow
6) Find a patron/branch/itemtype applicable to this rule
7) Ensure at least one item on the record is available for the
   patron to check out
   8) Attempt to place a hold for the item
   9) Note you cannot place the hold
   10) Check the available item out to another patron
   11) Note you can now place a hold for the first patron

Signed-off-by: Andreas Hedström Mace 

Works as intended!

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534

--- Comment #25 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #24)
> (In reply to Jonathan Druart from comment #23)
> > (In reply to Jonathan Druart from comment #19)
> > > Should not we check the "Reserved" status?
> > 
> > And what about the "Reserved" status?
> 
> The code already checks to see if the item is a waiting hold. Is this not
> what you are referring to?

I was thinking about the "Reserved" status returned by GetReserveStatus, but
after a night's sleep, I don't think it's needed actually.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #36 from Jonathan Druart  
---
I don't need anything else (for bug 15705) apart from the patches from this bug
report. But I think it would be good to agree on the next steps.
For instance, my note on comment 31 is still valid:
> We cannot update the notices with the TT syntax and set the pref off by 
> default.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16217] Notice' names may have diverged

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16217

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #49997|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 50388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50388&action=edit
Bug 16217: Resync names of notices

Bug 12752 has fixed a bug for installations upgrading from 3.14, but has
not fixed the problem for new installations.
Because of some wrong data manipulations, the names for a given letter
code may diverge.

In particular OVERDUE and PREDUE names of phone notices have been
wrongly modify by bug 11867: they have been set to the name of the first HOLD
notice.

Trying to be back on our feet, this update DB entry will try to guess
and set back up the correct name.

To know if your install is affected by this bug, the following SQL query
can help you:
  SELECT code, name, message_transport_type
  FROM letter
  WHERE code="PREDUE" OR code="OVERDUE";

If the names are different for the same code, something went wrong.
Executing this update DB entry should fix the divergence.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16217] Notice' names may have diverged

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16217

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #67 from Jonathan Druart  
---
(In reply to Florent Mara from comment #66)
> As part of an effort to improve performance when importing borrowers, I have
> started working on top of the current patches. 
> Steps proposed are as follows:
> 
> (1) Resolve merge conflicts from pre-existing patches. (Completed)
> (2) Add regression tests to new Koha::Patrons::Import. (Completed)
> (3) Refactor Koha::Patrons::Import + further regression testing. ( In
> progress )
> (4) Review import_borrowers.pl and Koha::Patrons::Import for further
> improvements. (To do)
> 
> Any feedback welcomed.

Good to heard that :)
Don't forget to share your patches ASAP

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #12 from Marc Véron  ---
Works great now,
However QA tools complain:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
   FAIL   forbidden patterns
forbidden pattern: tab char (line 277)
forbidden pattern: tab char (line 840)
forbidden pattern: tab char (line 272)
forbidden pattern: tab char (line 831)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12267] Allow password option in Patron Attribute non functional

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12267

--- Comment #10 from Katrin Fischer  ---
I am a bit worried about removing those - could we bring this up on the mailing
list?

Would it be possible that people used it as a hook to store login information
other applications? When testing I noticed it stores the password in the
database as cleartext, while hiding it  in the GUI.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15682] Merging records from cataloguing search only allows to merge 2 records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15682] Merging records from cataloguing search only allows to merge 2 records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682

--- Comment #8 from Katrin Fischer  ---
Created attachment 50387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50387&action=edit
[PASSED QA] Bug 15682 - Only allow merging of 2 or more records form lsits (for
consistency)

Test as above but on shelves.pl

Signed-off-by: Chris Cormack 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15682] Merging records from cataloguing search only allows to merge 2 records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #50371|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15682] Merging records from cataloguing search only allows to merge 2 records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #50372|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15682] Merging records from cataloguing search only allows to merge 2 records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682

--- Comment #7 from Katrin Fischer  ---
Created attachment 50386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50386&action=edit
[PASSED QA] Bug 15682 - Merging records from cataloguing search only allows to
merge 2 records

To test:
1 - Perform a cataloging search
2 - Attempt to merge 0 results - should fail
3 - Attempt to merge 1 resutls - should fail
4 - Attempt to merge 2 results - should succeed
5 - Attempt to merge 3 results - should succeed
6 - Test any other amount of records and if more than 1 it should
succeed

**Note: On shelves.pl you can merge a single record.  I think that is
incorrect so made this only work for 2. Will add a followup to fix
shelves.pl

Signed-off-by: Chris Cormack 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16285] write_age() function throws error for patron categories that don't include dateofbirth in form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16285

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #50370|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 50385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50385&action=edit
[PASSED QA] Bug 16285 - write_age() function throws error for patron categories
that don't include dateofbirth in form

To test:
1 Add a patron in category Library or School
2 Note the js error in the console
3 Apply patch
4 Repeat and note the error is gone

Signed-off-by: Chris Cormack 

Made it an explicit if, and fixed the author of the commit

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16285] write_age() function throws error for patron categories that don't include dateofbirth in form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16285

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9393] Add note to circulation.pl if borrower has pending modifications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #14 from Katrin Fischer  ---
Not a blocker, but a thing that could be improved: The link to "View all
pending patron modifications" brings you to the modifications page - it would
be nice if the patron you came from would be uncollapsed ready for you to edit.

But something else: You might also not be able to see the entry for the patron
because of IndependentBranchesPatronModifications - not sure how to handle
this. Maybe we should only show the link of logged in branch and staff branch
match?

Sorry... maybe not the best morning for QA (first passing then putting back to
Failed...) - but could you take another look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9393] Add note to circulation.pl if borrower has pending modifications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9393] Add note to circulation.pl if borrower has pending modifications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #50339|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 50384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50384&action=edit
[PASSED QA] Bug 9393 - Add note to circulation.pl if borrower has pending
modifications

Signed-off-by: Jonathan Druart 
New link "patron modifications" (if there are) on the checkout page.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16222] Add REST API folder to Makefile.PL

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #50374|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 50383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50383&action=edit
[PASSED QA] Bug 16222 - Add REST API folder to Makefile.PL

Add `api` folder to INTRANET_CGI_FOLDER in Makefile.PL so that the new
RESTFul API introduced in bug #13799 works also when installing with make.

Test plan:

- apply patch and do a `perl Makefile.PL` install
- observe that INSTALL_DIR/intranet/cgi-bin now has a folder `api`
  containing the swagger files and the api cgi mount, app.pl.

Signed-off-by: Chris Cormack 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16222] Add REST API folder to Makefile.PL

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16270] Typo authentification vs authentication in 404

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16270

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #50377|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16270] Typo authentification vs authentication in 404

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16270

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #50376|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16270] Typo authentification vs authentication in 404

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16270

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16270] Typo authentification vs authentication in 404

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16270

--- Comment #10 from Katrin Fischer  ---
Created attachment 50382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50382&action=edit
[PASSED QA] Bug 16270 (followup) Typo authentification vs authentication

Additionally fix typo in following files:
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt

To test: Apply patch, verify in files that authentification is
 replaced by authentication

Signed-off-by: Chris Cormack 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16270] Typo authentification vs authentication in 404

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16270

--- Comment #9 from Katrin Fischer  ---
Created attachment 50381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50381&action=edit
[PASSED QA] Bug 16270: Typo authentification/authentication

Test plan;
Trigger /cgi-bin/koha/errors/404.pl
Confirm the typo without the patch and that it's fixed with this patch
applied.

Signed-off-by: Owen Leonard 
Signed-off-by: Chris Cormack 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16256] Can't edit library EAN if you leave EAN empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16256

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #5 from Katrin Fischer  ---
Hm, I hae applied 16206, 16208 and then this patch. I have problems with 16208,
although the id is now used in the links and the same here - the problem
remains even tho the edit screen is called with the id in the URL. The
description is empty, even when one was set on creating the library ean and it
will save as a new line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16208] Can't delete a library EAN if the EAN value is empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208

--- Comment #7 from Katrin Fischer  ---
Looking at the form for confirming deletion shows the hidden value for ean to
be still empty:


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16208] Can't delete a library EAN if the EAN value is empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
I am sorry... but I just noticed: it didn't delete!
When confirming yes, nothing happens.

>From the logs:
[Tue Apr 19 07:49:37.687937 2016] [cgi:error] [pid 17497] [client
127.0.0.1:37847] AH01215: [Tue Apr 19 07:49:37 2016] edi_ean_accounts.pl:
DBIx::Class::ResultSet::_build_unique_cond(): NULL/undef values supplied for
requested unique constraint 'primary' (NULL values in column(s): 'ee_id'). This
is almost certainly not what you wanted, though you can set
DBIC_NULLABLE_KEY_NOWARN to disable this warning. at
/home/katrin/kohaclone/admin/edi_ean_accounts.pl line 140, referer:
http://localhost:8080/cgi-bin/koha/admin/edi_ean_accounts.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16208] Can't delete a library EAN if the EAN value is empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #50367|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 50380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50380&action=edit
[PASSED QA] Bug 16208 - Can't delete a library EAN if the EAN value is empty

Test Plan:
1) Create an empty EAN
2) Attempt to delete it, you should get an error
3) Apply this patch
4) Attempt to delete the EAN, you should now be able to

Signed-off-by: Chris Cormack 

This depends on bug 16206 being pushed, or you need to apply that patch
first

Signed-off-by: Katrin Fischer 

https://bugs.koha-community.org/show_bug.cgi?id=16256

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16208] Can't delete a library EAN if the EAN value is empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16291] koha-remove --purge should also delete '/etc/koha/sites/$instance' dir

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291

Mason James  changed:

   What|Removed |Added

Summary|koha-remove --purge should  |koha-remove --purge should
   |also delete |also delete
   |/etc/koha/sites/instance|'/etc/koha/sites/$instance'
   ||dir

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16291] New: koha-remove --purge should also delete /etc/koha/sites/instance

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291

Bug ID: 16291
   Summary: koha-remove --purge should also delete
/etc/koha/sites/instance
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: m...@kohaaloha.com
QA Contact: testo...@bugs.koha-community.org

It would be useful if 'koha-remove --purge' also deleted a
/etc/koha/sites/instance dir

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16291] koha-remove --purge should also delete /etc/koha/sites/instance

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291

Mason James  changed:

   What|Removed |Added

 Depends on||9754


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754
[Bug 9754] koha-remove optionally includes var/lib and var/spool
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9754] koha-remove optionally includes var/lib and var/spool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754

Mason James  changed:

   What|Removed |Added

 Blocks||16291


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291
[Bug 16291] koha-remove --purge should also delete /etc/koha/sites/instance
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9754] koha-remove optionally includes var/lib and var/spool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13902] Add --force option to koha-create and koha-remove commands

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13902

--- Comment #1 from Mason James  ---
(In reply to Mason James from comment #0)
> Add --force option to koha-create and koha-remove commands

hmm, i had an interesting experience related to this BZ...


a koha-remove failed to delete a /etc/koha/sites/aaa1 dir, as the dir contained
an unexpected foo.backup file

on a reboot, the /etc/init.d/koha-common script then failed to run
koha-create-dirs on all other koha instances alphabetically after 'aaa1'

this caused zebrasrv to fail on all following instances?!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16243] Add reference manager software (Mendeley and EasyBib) to OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org,
   ||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16243] Add reference manager software (Mendeley and EasyBib) to OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243

--- Comment #13 from Héctor Eduardo Castro Avalos  
---
Hi All

I finished up and bug is ready to be tested.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16243] Add reference manager software (Mendeley and EasyBib) to OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243

--- Comment #12 from Héctor Eduardo Castro Avalos  
---
Created attachment 50379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50379&action=edit
Bug 16243: Changes LESS opac.less > to opac.css

Add changes LESS opac.less > to opac.css for Reference Manager Software
(Mendeley and EasyBib)

Sponsored-by: Universidad de El Salvador

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16243] Add reference manager software (Mendeley and EasyBib) to OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #50290|0   |1
is obsolete||

--- Comment #11 from Héctor Eduardo Castro Avalos  
---
Created attachment 50378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50378&action=edit
Bug 16243: Add reference manager software (Mendeley and EasyBib) to OPAC

Mendeley provides a mechanism for export bib records to a personal account
in a free reference manager and academic social network (similar to Zotero)

EasyBib Generate citations in MLA, APA & Chicago formats for bibliographies


To test:
- Apply patches
- Run perl installer/data/mysql/updatedatabase.pl
- On master, search for the  syspref OpacReferenceManager
- Enable the two options
- Do a search for books
- Notice about the new option 'Export to Reference Manager' in search results
- Create an account in Mendeley (Is free)
- Click in new option and notice that you can save bib references in Mendeley
- Click in new option Cite on EasyBib, you will see the records selected in
  EasyBib
- Repeat for items saved in cart and patron list.
- Go to record detail page test in Normal view, Marc view and ISBD view

NOTE: Fixed according with QA comment

Sponsored-by: Universidad de El Salvador

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16270] Typo authentification vs authentication in 404

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16270

Chris Cormack  changed:

   What|Removed |Added

  Attachment #50269|0   |1
is obsolete||

--- Comment #7 from Chris Cormack  ---
Created attachment 50376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50376&action=edit
Bug 16270: Typo authentification/authentication

Test plan;
Trigger /cgi-bin/koha/errors/404.pl
Confirm the typo without the patch and that it's fixed with this patch
applied.

Signed-off-by: Owen Leonard 
Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16270] Typo authentification vs authentication in 404

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16270

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16270] Typo authentification vs authentication in 404

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16270

Chris Cormack  changed:

   What|Removed |Added

  Attachment #50375|0   |1
is obsolete||

--- Comment #8 from Chris Cormack  ---
Created attachment 50377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50377&action=edit
Bug 16270 (followup) Typo authentification vs authentication

Additionally fix typo in following files:
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt

To test: Apply patch, verify in files that authentification is
 replaced by authentication

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16270] Typo authentification vs authentication in 404

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16270

Chris Cormack  changed:

   What|Removed |Added

  Attachment #50278|0   |1
is obsolete||

--- Comment #6 from Chris Cormack  ---
Created attachment 50375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50375&action=edit
Bug 16270 (followup) Typo authentification vs authentication

Additionally fix typo in following files:
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt

To test: Apply patch, verify in files that authentification is
 replaced by authentication

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16222] Add REST API folder to Makefile.PL

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222

Chris Cormack  changed:

   What|Removed |Added

  Attachment #50012|0   |1
is obsolete||

--- Comment #2 from Chris Cormack  ---
Created attachment 50374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50374&action=edit
Bug 16222 - Add REST API folder to Makefile.PL

Add `api` folder to INTRANET_CGI_FOLDER in Makefile.PL so that the new
RESTFul API introduced in bug #13799 works also when installing with make.

Test plan:

- apply patch and do a `perl Makefile.PL` install
- observe that INSTALL_DIR/intranet/cgi-bin now has a folder `api`
  containing the swagger files and the api cgi mount, app.pl.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16222] Add REST API folder to Makefile.PL

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13877] seasonal predictions showing wrong in test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13877

Chris Cormack  changed:

   What|Removed |Added

  Attachment #49178|0   |1
is obsolete||

--- Comment #6 from Chris Cormack  ---
Created attachment 50373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50373&action=edit
Bug 13877 - Make serialseq season name translatable regardless its position in
a string

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13877] seasonal predictions showing wrong in test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13877

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15682] Merging records from cataloguing search only allows to merge 2 records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682

Chris Cormack  changed:

   What|Removed |Added

  Attachment #49605|0   |1
is obsolete||

--- Comment #5 from Chris Cormack  ---
Created attachment 50371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50371&action=edit
Bug 15682 - Merging records from cataloguing search only allows to merge 2
records

To test:
1 - Perform a cataloging search
2 - Attempt to merge 0 results - should fail
3 - Attempt to merge 1 resutls - should fail
4 - Attempt to merge 2 results - should succeed
5 - Attempt to merge 3 results - should succeed
6 - Test any other amount of records and if more than 1 it should
succeed

**Note: On shelves.pl you can merge a single record.  I think that is
incorrect so made this only work for 2. Will add a followup to fix
shelves.pl

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15682] Merging records from cataloguing search only allows to merge 2 records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15682] Merging records from cataloguing search only allows to merge 2 records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682

Chris Cormack  changed:

   What|Removed |Added

  Attachment #49606|0   |1
is obsolete||

--- Comment #6 from Chris Cormack  ---
Created attachment 50372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50372&action=edit
Bug 15682 - Only allow merging of 2 or more records form lsits (for
consistency)

Test as above but on shelves.pl

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16285] write_age() function throws error for patron categories that don't include dateofbirth in form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16285

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16285] write_age() function throws error for patron categories that don't include dateofbirth in form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16285

Chris Cormack  changed:

   What|Removed |Added

  Attachment #50359|0   |1
is obsolete||

--- Comment #2 from Chris Cormack  ---
Created attachment 50370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50370&action=edit
Bug 16285 - write_age() function throws error for patron categories that don't
include dateofbirth in form

To test:
1 Add a patron in category Library or School
2 Note the js error in the console
3 Apply patch
4 Repeat and note the error is gone

Signed-off-by: Chris Cormack 

Made it an explicit if, and fixed the author of the commit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #97 from Srdjan Jankovic  ---
(In reply to Katrin Fischer from comment #96)
> 
> There was someone on IRC reporting this issue not so long ago - we were not
> trying to identify the cause. He had 2 system himself, one where it was
> happening and one where everything was fine.

Yes, I have that happening in both master and with the patch, so I'm not
worried too mush about it.

Katrin, since you jumped in, can I please ask you to check whether you have any
problems on the Opac search results screen with these patches, as in comment
95.

Much obliged

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16217] Notice' names may have diverged

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16217

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12752] OVERDUE notice mis-labeled as "Hold Available for Pickup"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752

Chris Cormack  changed:

   What|Removed |Added

  Attachment #49990|0   |1
is obsolete||

--- Comment #11 from Chris Cormack  ---
Created attachment 50369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50369&action=edit
Bug 12752: FIX letter names in 3.15.00.041

3.15.00.041 was wrong, the name of the letter should not always been the
name of the first HOLD notice.
PREDUE_PHONE should be updated with the first name of the PREDUE notice,
same for OVERDUE_PHONE and OVERDUE

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12752] OVERDUE notice mis-labeled as "Hold Available for Pickup"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16256] Can't edit library EAN if you leave EAN empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16256

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16256] Can't edit library EAN if you leave EAN empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16256

Chris Cormack  changed:

   What|Removed |Added

  Attachment #50357|0   |1
is obsolete||

--- Comment #4 from Chris Cormack  ---
Created attachment 50368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50368&action=edit
Bug 16256 - Can't edit library EAN if you leave EAN empty

Test Plan:
1) Create an empty EAN
2) Edit it and save
3) Note you get a new EAN row
4) Apply this patch
5) Edit the empty EAN again
6) Note you now get an updated EAN and not a new row

Signed-off-by: Chris Cormack 

Depends on bug 16208 (which depends on 16206)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16208] Can't delete a library EAN if the EAN value is empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208

Chris Cormack  changed:

   What|Removed |Added

  Attachment #50356|0   |1
is obsolete||

--- Comment #4 from Chris Cormack  ---
Created attachment 50367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50367&action=edit
Bug 16208 - Can't delete a library EAN if the EAN value is empty

Test Plan:
1) Create an empty EAN
2) Attempt to delete it, you should get an error
3) Apply this patch
4) Attempt to delete the EAN, you should now be able to

Signed-off-by: Chris Cormack 

This depends on bug 16206 being pushed, or you need to apply that patch
first

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16208] Can't delete a library EAN if the EAN value is empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16206] Corrections to templates related new EDI feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206

Chris Cormack  changed:

   What|Removed |Added

 Blocks||16208


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208
[Bug 16208] Can't delete a library EAN if the EAN value is empty
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16208] Can't delete a library EAN if the EAN value is empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208

Chris Cormack  changed:

   What|Removed |Added

 Depends on||16206
 CC||ch...@bigballofwax.co.nz


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206
[Bug 16206] Corrections to templates related new EDI feature
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara  changed:

   What|Removed |Added

 CC||florent.m...@gmail.com

--- Comment #66 from Florent Mara  ---
As part of an effort to improve performance when importing borrowers, I have
started working on top of the current patches. 
Steps proposed are as follows:

(1) Resolve merge conflicts from pre-existing patches. (Completed)
(2) Add regression tests to new Koha::Patrons::Import. (Completed)
(3) Refactor Koha::Patrons::Import + further regression testing. ( In progress
)
(4) Review import_borrowers.pl and Koha::Patrons::Import for further
improvements. (To do)

Any feedback welcomed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15531] Add support for standing orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #47569|0   |1
is obsolete||

--- Comment #9 from Jesse Weaver  ---
Created attachment 50366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50366&action=edit
Bug 15531: (followup) Use a quantity of 1, not null, for standing orders

This seems to cause fewer problems with the existing acquisitions code.


Rebased, please test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15531] Add support for standing orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #47367|0   |1
is obsolete||

--- Comment #8 from Jesse Weaver  ---
Created attachment 50365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50365&action=edit
Bug 15531: Add support for standing orders

This allows creation of special baskets that include standing orders.
These orders do not have a known quantity (and may not have a known
price in advance). Upon receipt, the received items are split into a new
completed order.

Test plan:
  1) Run updatedatabase.pl.
  2) Run prove t/db_dependent/Acquisition/StandingOrders.t . (and the
 other Acquisition tests).
  3) Create a new basket, mark it as a standing order basket.
  4) Add an order to this basket, and notice that the quantity field is
 missing (and thus not required).
  5) Receive items for this order, and notice that the original order is
 unchanged. The new child order line should have the correct price
 and quantity information.

(Note: the QA tools output what seems to be a spurious spelling error
for Test::More's "isnt" in StandingOrders.t.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15531] Add support for standing orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531

Jesse Weaver  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456

Jesse Weaver  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #46453|0   |1
is obsolete||

--- Comment #7 from Jesse Weaver  ---
Created attachment 50364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50364&action=edit
Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt

To verify patch, run `git diff -w HEAD^' and note that the only changes
shown are where [% IF %] statements are expanded/unexpanded onto
multiple lines to match the prevailing style.

Signed-off-by: Bernardo Gonzalez Kriegel 
Looks like refactoring :)
No regressions, no koha-qa errors

Signed-off-by: Kyle M Hall 


Putting back to Needs Signoff purely because the underlying template had moved
a bit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #96 from Katrin Fischer  ---
(In reply to Owen Leonard from comment #94)
> (In reply to Srdjan Jankovic from comment #93)
> 
> > On kc/master I get the list, with all entries "No title ". 
> 
> I don't have the problem of entries appearing with "No title" in master.

There was someone on IRC reporting this issue not so long ago - we were not
trying to identify the cause. He had 2 system himself, one where it was
happening and one where everything was fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16290] New: "Name of Season" description in numbering pattern erases everything ahead of it in numbering formula

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16290

Bug ID: 16290
   Summary: "Name of Season" description in numbering pattern
erases everything ahead of it in numbering formula
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: khol...@switchinc.org
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

When the "Name of Season" formatting is used, any text put in front of the
season is erased from the numbering pattern. This does not seem to affect the
"Name of Day" or "Name of Month" formatting options.

To test:
1) Go into Serials > Manage Numbering Patterns. 
2) Select edit for the "Seasonal" numbering pattern included in the default
installation of Koha. 
3) Type 'TEST' in front of the numbering formula, so that it reads 'TEST {X}
{Y}'. 
4) Make sure the X value uses the "Name of Season" formatting. 
5) Create a test prediction pattern.
6) Notice that the string "TEST" is erased from the front of the prediction
pattern. You will see that anything put in front of the season is erased. If
you put a variable like X, Y or Z in front of the pattern, that variable will
be erased as well.
7) Change the numbering formula to '{X} TEST {Y}"
8) Create a test prediction pattern.
9) Notice that so long as data is behind the "Name of Season" formatting, it
will still display.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #63 from Katrin Fischer  ---
Winona, you are right, this bug didn't cause it. Best would be to file a new
bug and link it 'depend on' with bug 15100 - because both this and the other
bug have already been pushed. While causing the problem, I am not sure yet
about how to fix it properly. It will probably take me a while - any help would
be much appreciated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #62 from Winona Salesky  ---
It looks like the problem with the subfield order was introduced in bug #15100,
not this bug. Perhaps, the comments should move to that thread? I think a
better solution then the one in place would be to use xsl:apply templates to
specify special handling for dates. This would retain subfield order and also
allow for manipulation of specific subfields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16289] Abbreviated formatting for numbering patterns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289

--- Comment #1 from Karl Holten  ---
Created attachment 50363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50363&action=edit
Bug 16289) Abbreviated formatting for numbering patterns

This is my first attempt to do some development for Koha, so please take care
to make sure I didn't mess anything up :)

To test:

1) Go to Serials -> Manage numbering patterns
2) Create ‘New Numbering Pattern’
3) Type in a name of “Day, Month, Season” and a numbering formula of “{X} {Y}
{Z}”.
4) Set up the X field as following: add 1, every 1, set back to 1, when more
than 30. 
5) Select the formatting for X. There should be six options available instead
of the original three. Use the formatting “Name of Day (abbreviated)”.
5) Set up the Y field to add 1 every 30 reset back to 1 when more than 12. Use
the formatting “Name of month (abbreviated)”
6) Set up the Z field to add 1 every 90 reset back to 1 when more than 4. Use
the formatting “Name of season (abbreviated)”.
8) Select a frequency of “1/day”.
9) Select a first issue publication date of Jan 1, 2016.
10) Set X to begin with 5 and have an inner counter of 5. Set Z to begin with 3
and have an inner counter of 10.
11) Click the “Test Pattern” button.
12) Abbreviated versions of the day, month and season should appear in the test
pattern.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287

--- Comment #27 from Katrin Fischer  ---
Just a note here - please think if systems with multiple instances. I have run
into several problems with other cronjobs lately :( It would be nice if a move
to sysprefs allows you to schedule it for all instances, while it will only be
active for ones with the pref set. Not sure if it's doable without behaviour
change... but you can make wishes, right? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16289] Abbreviated formatting for numbering patterns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289

Karl Holten  changed:

   What|Removed |Added

 CC||khol...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16289] New: Abbreviated formatting for numbering patterns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289

Bug ID: 16289
   Summary: Abbreviated formatting for numbering patterns
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: khol...@switchinc.org
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

Our consortium uses abbreviations for our serials formatting. Existing
formatting options for numbering patterns use the full month, day and season.
Staff would like additional options for abbreviations.

This development would create the option to select three letter abbreviations
for:
Day (Mon, Tue, Wed, Thu, Fri, Sat, Sun)
Month (Jan, Feb, Mar, Apr, May, Jun, Jul, Aug, Sep, Oct, Nov, Dec)
Season (Spr, Sum, Fal, Win)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||16288


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288
[Bug 16288] Edifact sysprefs EDIfactEAN and EDIInvoicesShippingBudget problems
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16288] Edifact sysprefs EDIfactEAN and EDIInvoicesShippingBudget problems

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||7736
   Severity|normal  |major


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736
[Bug 7736] Edifact QUOTE and ORDER functionality
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16288] New: Edifact sysprefs EDIfactEAN and EDIInvoicesShippingBudget problems

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288

Bug ID: 16288
   Summary: Edifact sysprefs EDIfactEAN and
EDIInvoicesShippingBudget problems
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Bug 7736 introduced this two problematic sysprefs:

EDIInvoicesShippingBudget:

* sysprefs.sql: YAY!
* updatedatabase.pl: YAY!
* acquisitions.pref: BO, missing
* The syspref is not actually used:
To reproduce:
- Run
  $ git grep EDIInvoicesShippingBudget
=> FAIL: Only shows in sysprefs.sql and updatedatabase.pl

EDIfactEAN:

* sysprefs.sql: BO, missing
* updatedatabase.pl: BO, missing
* acquisitions.pref: BO, missing
* The syspref is actually used:
To reproduce:
- Run
  $ git grep EDIfactEAN
=> FAIL: The not-introduced syspref is actually used:
Koha/EDI.pm:$ean ||= C4::Context->preference('EDIfactEAN');

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #11 from Nick Clemens  ---
(In reply to Marc Véron from comment #9)
> Great feature! 
> But I have a problem when toggling between Quick add and Full form:

Fields should now populate when toggling between forms, quick add is now a
choice from patron toolbar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #50093|0   |1
is obsolete||

--- Comment #10 from Nick Clemens  ---
Created attachment 50362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50362&action=edit
Bug 3534 - Patron quick add form

This patch adds a new system preference:
PatronQuickAddFields

When either this pref or BorrowerMandatoryField is populated this will add a
new dropdown to the bew patron toolbar.
When a category is chosen from this dropdown the fields in PatronQuickAddFields
and BorrowerMandatoryField will be displayed.
There will be a button allowing a user to switch from the quickadd to the full
form and fields will be copied between the forms when toggling.

The Quick add will only be displayed on add of a new patron, future edits
should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields
 and note the new button for adding a patron
 5 - Click the Quick add and choose a type
 6 - Only required or quick add fields should be displayed
 7 - Verify toggling forms copies information
 8 - Ensure you cannot save patron without filling required fields
 (quick add fields should be optional)
 9 - Ensure you can save patron with fields filled out
10 - Ensure that a duplicate patron brings up the duplicate/add new
buttons with full form displayed
11 - Verify that subsequent edits use only full form
12 - Verify that data on form submitted is the data saved to patron
13 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16287] New: Can't accept list share invitation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16287

Bug ID: 16287
   Summary: Can't accept list share invitation
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Lists
  Assignee: gmcha...@gmail.com
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Steps to reproduce:

1. Create a private list.
2. Enable the OpacAllowSharingPrivateLists system preference.
3. Log into the OPAC and share your private list with an email address which
corresponds to a patron in Koha.
4. Process your message queue if necessary.
5. Check the email account you shared the list with. Copy the the link in the
message.
6. Log into the OPAC using the account corresponding to that email address.
7. Paste the link you copied from the email. An error will be triggered:

DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'sharedate desc' in
'order clause' at Koha/Objects.pm line 150

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

Patricia Brauer  changed:

   What|Removed |Added

 CC||tric...@roundrocktexas.gov

--- Comment #61 from Patricia Brauer  ---
Comment 56 asked for an example. We have a title Women crime writers where
several of the 700 fields have inverted the author's date subfield with the
title field. See
http://catalog.roundrocktexas.gov/cgi-bin/koha/opac-detail.pl?biblionumber=189060.
Specifically: ex.1) Caspary, Vera, Laura 1899-1987. should be: Caspary, Vera,
1899-1987. Laura. -- ex.2) Hughes, Dorothy B. In a lonely place 1904-1993.
should be: Hughes, Dorothy B.,1904-1993. In a lonely place. -- ex. 3) Holding,
Elisabeth Sanxay, The blank wall 1889-1955. should be: Holding, Elisabeth
Sanxay, 1889-1955. The blank wall. There are 3 more examples in this record
alone.  Another example is Dancing home. See:
http://catalog.roundrocktexas.gov/cgi-bin/koha/opac-search.pl?idx=ti&q=dancing+home.
Darío, Rubén, A Margarita 1867-1916. should be Darío, Rubén, 1867-1916. A
Margarita.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16208] Can't delete a library EAN if the EAN value is empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208

--- Comment #3 from Owen Leonard  ---
Bug 16206, "Corrections to templates related new EDI feature" is Passed QA.
Could this patch be rebased on top of that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #50360|0   |1
is obsolete||

--- Comment #45 from Kyle M Hall  ---
Created attachment 50361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50361&action=edit
Bug 14377 - Don't replace 942$n with authorised value except when using UNIMARC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #49719|0   |1
is obsolete||
  Attachment #49720|0   |1
is obsolete||
  Attachment #49721|0   |1
is obsolete||
  Attachment #49722|0   |1
is obsolete||

--- Comment #44 from Kyle M Hall  ---
Created attachment 50360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50360&action=edit
Bug 14377 - Don't replace 942$n with authorised value except when using UNIMARC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16285] write_age() function throws error for patron categories that don't include dateofbirth in form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16285

--- Comment #1 from Nick Clemens  ---
Created attachment 50359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50359&action=edit
Bug 16285 - write_age() function throws error for patron categories that don't
include dateofbirth in form

To test:
1 Add a patron in category Library or School
2 Note the js error in the console
3 Apply patch
4 Repeat and note the error is gone

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16285] write_age() function throws error for patron categories that don't include dateofbirth in form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16285

Nick Clemens  changed:

   What|Removed |Added

   Severity|enhancement |normal
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16285] write_age() function throws error for patron categories that don't include dateofbirth in form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16285

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

--- Comment #16 from Kyle M Hall  ---
(In reply to Brendan Gallagher from comment #15)
> Didn't apply cleanly

Odd, it seems to apply cleanly now!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #35 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #31)
> Kyle,
> Could you detail the plan for the dependent bugs please?
> You are adding a new pref and a new DB column (letter.is_tt) in this patch
> but they are not used in other patches.
> We cannot update the notices with the TT syntax and set the pref off by
> default.

The other patches will need to be updated. Are there any changes to this patch
set specifically that you need, or shall I go ahead and update all the
dependent patches?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532

--- Comment #5 from Kyle M Hall  ---
Created attachment 50358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50358&action=edit
Bug 15532 [QA Followup] - Remove unecessary lines from unit test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16256] Can't edit library EAN if you leave EAN empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16256

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/