[Koha-bugs] [Bug 12027] Shibboleth authentication for staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 --- Comment #12 from Martin Renvoize --- Sorry I missed this a while back. There are some instructions on the wiki for configuring shibboleth on your server, and there are now a couple of public identity providers one can use to test against I believe.. Just Google shibboleth test IdP to find one for your locality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12027] Shibboleth authentication for staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 --- Comment #13 from Martin Renvoize --- https://wiki.koha-community.org/wiki/Shibboleth_Configuration -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #27 from Marcel de Rooy --- The unit test BiblioFrameworks.t does not have a transaction! This is corrected with a patch under report 16155. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155 Marcel de Rooy changed: What|Removed |Added Attachment #49637|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 50492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50492&action=edit Bug 16155: Adjust TestBuilder.t The changes in TestBuilder.pm require some changes in this test. [1] Tests have been organized under subtests. A few superfluous tests have been removed. (There is still some overlap between the sections of overduerules_transport_type and userpermission.) [2] The results in the build all sources-test are checked one step further. [3] Tests are added for field length, null values and delete method. [4] The former defaults from TestBuilder are incorporated in the tests for userpermission. Test plan: Run t/db_dependent/TestBuilder.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155
Marcel de Rooy changed:
What|Removed |Added
Attachment #49638|0 |1
is obsolete||
--- Comment #11 from Marcel de Rooy ---
Created attachment 50493
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50493&action=edit
Bug 16155: Adjust a few other tests
Accounts.t: Only added a line that ensures the MPL branch exists.
AnonymiseIssueHistory.t: Only add a branch to work with.
Barcodes.t: Replaced clear with delete_all.
CalcFine.t: Remove default issuing rule and add one instead of updating.
Holds.t: Add category S in case it would not exist.
Members.t: Replaced clear with delete_all.
MoveItemFromBiblio.t: Replace last _fk construction.
Test plan:
Run these tests. (See note).
Git grep for only_fk, {_fk} and TestBuilder::default_value.
Note: Holds.t does not pass. Tests 9 and 39 fail, but they did already.
not ok 9 - GetReservesFromItemnumber should return a valid borrowernumber
not ok 39 - Test AlterPriority(), move to bottom
So this test needs attention, but on another report please :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155 --- Comment #12 from Marcel de Rooy --- Created attachment 50494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50494&action=edit Bug 16155: [QA Follow-up] Add transaction to BiblioFrameworks.t This unit test does not have a transaction. It does not need TestBuilder. Test plan: [1] Optionally remove records with mfw1, mfw2 from biblio_framework table. If you ran this test before and it failed, you may have them. [2] Run the test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155 Marcel de Rooy changed: What|Removed |Added Attachment #49636|0 |1 is obsolete|| --- Comment #9 from Marcel de Rooy --- Created attachment 50491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50491&action=edit Bug 16155: Remove a second use from Members_Attributes.t Test plan: Run t/db_dependent/Members_Attributes.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155
Marcel de Rooy changed:
What|Removed |Added
Attachment #49635|0 |1
is obsolete||
--- Comment #8 from Marcel de Rooy ---
Created attachment 50490
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50490&action=edit
Bug 16155: Composite keys in TestBuilder and more
The number of tests using TestBuilder is gradually growing. Once you
are familiar with its use, you will appreciate it and find yourself
using it when writing new tests. Although it works quite well, some details
still needs some polishing.
While looking at the handling of composite keys in TestBuilder, a number
of related points came up too. This patch finally ended up in setting
the following design goals:
[1] TB should not only look at the first column of a composite FK.
[2] TB should optionally create records for fixed FK values.
[3] TB should create a new record, never change an existing record.
[4] TB should respect auto_increment columns.
[5] Passing a hash for a foreign key should always imply a new record.
[6] Explicitly passing undef for a column should mean NULL.
[7] Add a delete method; it will replace the clear method.
[8] Simplify by removing $default_values, hash key _fk and param only_fk.
The comments below further clarify these points. Note that they refer to
the old behavior (before this patch) unless stated otherwise.
Comments for point 1
Look at:
$builder->build({
source => 'UserPermission',
value => {
borrowernumber => $borrowerno,
module_bit => { flag => 'my flag' },
code => 'will_be_ignored',
},
});
Module_bit and code here are a composite FK to permissions.
TB ignores the value for the code column here and creates a record with a
randomized code.
But if we would pass the hash in the second column of this compound key like:
borrowernumber => $borrowerno,
module_bit => 10,
code => { code => 'new_code' },
TB would now crash when passing the hash for code thru to DBIx.
Comments for point 2
Look at:
$builder->build({
source => 'UserPermission',
value => {
borrowernumber => $borrowerno,
module_bit => 99,
code => 'new_super_tool',
},
});
TB detects a fixed value for the module_bit, continues and will crash on
DBIx if the foreign keys are not found. In this case it would be friendly
to create a missing linked record.
Comments for point 3
Look at:
$builder->build({
source => 'Branch',
value => { branchcode => 'CPL' },
});
If this branch already exists, this call would modify the branch record and
overwrite all columns with randomized values (expected or not). In any case,
it would be safer here to return undef than modifying an existing record.
Comments for point 4
Look at:
$builder->build({
source => 'Borrower',
value => { borrowernumber => '123456789' },
});
If this number would exist, we would update (as earlier). But if this
number does not exist, we would create the record. Although that is
technically possible, I would prefer to have TB respect the auto
increment property of this column.
Comments for point 5
Look at:
$builder->build({
source => 'Item',
value => { homebranch => { branchcode => 'MPL' } },
});
As discussed under point 3, we should actually not pass primary key values
if we expect to build new records. The same also holds for the deeper
(recursive) calls to build when using hashes like here for homebranch.
In this case again an existing record might be overwritten.
Comments for point 6
Look at:
$builder->build({
source => 'Reserve',
value => { itemnumber => undef },
});
As you know, a reserve without an itemnumber is a biblio level hold.
Unfortunately, TB did not care about passing undefs until now. So you would
get an item level hold.
In the new situation TB will respect these explicit undefs, as long as the
corresponding foreign key column is nullable of course.
Comments for point 7
This patch will allow you to delete records created by TB:
my $patron = $builder->build({ source => 'Borrower' });
$builder->delete({ source => 'Borrower', records => $patron });
Or:
$builder->delete({ source => 'Borrower', records => [ $patron, ... ] });
For safety, delete requires you to provide all primary key values in the
passed hashref(s).
Deleting all records in a table via clear is no longer supported and can
still be arranged in one statement.
Comments for point 8
Current use of TestBuilder reveals that $default_va
[Koha-bugs] [Bug 16206] Corrections to templates related new EDI feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 Julian Maurice changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED CC||julian.maur...@biblibre.com --- Comment #7 from Julian Maurice --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16080] Remove unused images from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Bug 16080 depends on bug 16206, which changed state. Bug 16206 Summary: Corrections to templates related new EDI feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16208] Can't delete a library EAN if the EAN value is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Bug 16208 depends on bug 16206, which changed state. Bug 16206 Summary: Corrections to templates related new EDI feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16256] Can't edit library EAN if you leave EAN empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16256 Bug 16256 depends on bug 16208, which changed state. Bug 16208 Summary: Can't delete a library EAN if the EAN value is empty https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16208] Can't delete a library EAN if the EAN value is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Julian Maurice changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED CC||julian.maur...@biblibre.com --- Comment #12 from Julian Maurice --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16262] Remove the use of "onclick" from acquisitions basket template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16262 Bug 16262 depends on bug 16206, which changed state. Bug 16206 Summary: Corrections to templates related new EDI feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16206] Corrections to templates related new EDI feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 Bug 16206 depends on bug 16237, which changed state. Bug 16237 Summary: Adding new EDI account results in Perl error when plugins are not activated https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16237 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16237] Adding new EDI account results in Perl error when plugins are not activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16237 Julian Maurice changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED CC||julian.maur...@biblibre.com --- Comment #7 from Julian Maurice --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16256] Can't edit library EAN if you leave EAN empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16256 Julian Maurice changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED CC||julian.maur...@biblibre.com --- Comment #9 from Julian Maurice --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16222] Add REST API folder to Makefile.PL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Status|Pushed to Master|Pushed to Stable --- Comment #7 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155 --- Comment #13 from Marcel de Rooy --- (In reply to Bernardo Gonzalez Kriegel from comment #6) > patch2) Test plan good, but not all test pass now > Following tests now fail > > prove t/db_dependent/Creators/Lib.t Passes with me. Please run the test again and report which tests failed. > prove t/db_dependent/Koha/BiblioFrameworks.t The last follow-up deals with that. This test had no transaction and does not need TestBuilder actually. > prove t/db_dependent/Members.t Replaced the clear statement. Should pass now with 5th patch. > prove t/db_dependent/Reports_Guided.t This test passes with me. Please run again and report which tests failed. > prove t/db_dependent/Review.t This test passes with me. Please run again and report which tests failed. > patch4) Test fail > prove t/db_dependent/TestBuilder.t > ... ># Failed test 'TestBuilder should be able to create an object for every > source' > # at t/db_dependent/TestBuilder.t line 71. > # got: '1' > # expected: '0' > # The following sources have not been generated correctly: > Deletedborrower This test passes with me. Please run t/db_dependent/db_structure.t in order to check if your deletedborrowers table is in line with borrowers. Finally, I added Barcodes.t to the 5th patch. Replaced a clear there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16227] The currencies of vendor and order do not display correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16227 Julian Maurice changed: What|Removed |Added Status|Pushed to Master|RESOLVED CC||julian.maur...@biblibre.com Resolution|--- |FIXED --- Comment #5 from Julian Maurice --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16312] Koha::Logger overload configuration for command line scripts verbosity levels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16312 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #50472|0 |1 is obsolete|| --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 50495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50495&action=edit Bug 16312 - Koha::Logger overload configuration for command line scripts verbosity levels To be able to set the -v|--verbose flags from the command line and still use Koha::Logger, we must be able to overload/extend default appenders and log levels on a easy case-by-case basis directly from the Perl-code. To deploy verbose mode in a commandline script, add the following code to your cronjob/script: use C4::Context; use Koha::Logger; C4::Context->setCommandlineEnvironment(); Koha::Logger->setConsoleVerbosity( 1 || -3 || 'WARN' || ... ); The module using the Koha::Logger must lazyLoad the module/package-level logger using Koha::Logger->new(), so the overloads can be deployed. See attached tests and perldoc for more info. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16229] Koha::Cache should be on the safe side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16229 Julian Maurice changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED CC||julian.maur...@biblibre.com --- Comment #13 from Julian Maurice --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16221] Use Storable::dclone() instead of Clone::clone() for L1 cache deep-copying mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16221 Bug 16221 depends on bug 16229, which changed state. Bug 16229 Summary: Koha::Cache should be on the safe side https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16229 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16240] Regression: Bug 16082 causes message to be displayed even when no borrowernumber is passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16240 Julian Maurice changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Julian Maurice changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #10 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15113] koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15113 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Status|Pushed to Master|Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15682] Merging records from cataloguing search only allows to merge 2 records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #10 from Julian Maurice --- These patches introduce strings changes, so they won't be in 3.22.6 (string freeze) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Status|Pushed to Master|Pushed to Stable --- Comment #11 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Julian Maurice changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16055] Deleting a basket group containing baskets fails silently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16055 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Status|Pushed to Master|Pushed to Stable --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16179] Clicking Rate me button in OPAC without selecting rating produces error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16179 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Status|Pushed to Master|Pushed to Stable --- Comment #11 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16224] Random failure for t/db_dependent/Reports_Guided.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16224 Julian Maurice changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16285] write_age() function throws error for patron categories that don't include dateofbirth in form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16285 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Status|Pushed to Master|RESOLVED Resolution|--- |FIXED Depends on||15206 --- Comment #5 from Julian Maurice --- Not needed in stable versions, status changed to RESOLVED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 [Bug 15206] Show patron's age when filling date of birth in memberentry.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Julian Maurice changed: What|Removed |Added Blocks||16285 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16285 [Bug 16285] write_age() function throws error for patron categories that don't include dateofbirth in form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16286] Use validation plugin when adding or editing patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16286 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16286] Use validation plugin when adding or editing patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16286 Marc Véron changed: What|Removed |Added Attachment #50463|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 50496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50496&action=edit Bug 16286 - Use validation plugin when adding or editing patron category This patch updates the patron category entry form so that it is validated using the staff client's globally-included form validation plugin. This patch also moves the page's JavaScript into a separate file. To test, apply the patch and go to Administration -> Patron categories. - Create a new category. Try to submit the form with the following fields empty: - Category code - Description - Both enrollment period fields - Category type - Try to enter data in the category code field which contains characters other than letters, numbers, hyphens, or underscores. - Try to enter non-numeric data in the following fields: - Enrollment period in months - Age required - Upper age limit - Enrollment fee - Hold fee - Try to submit the form with both enrollment period fields filled. Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16306] C4::Context->setCommandlineEnvironment() convenience function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16306 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10459] borrowers should have a timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Marcel de Rooy changed: What|Removed |Added Patch complexity|Trivial patch |Small patch --- Comment #28 from Marcel de Rooy --- Moving complexity higher in view of former comment -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13597] Amazon 'no image' element needs a 'no-image' class, in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597
Marc Véron changed:
What|Removed |Added
Attachment #50487|0 |1
is obsolete||
--- Comment #3 from Marc Véron ---
Created attachment 50497
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50497&action=edit
Bug 13597 - Amazon 'no image' element needs a 'no-image' class, in the staff
client
to test patch...
1/ go to staff client
2/ add following CSS to 'IntranetUserCSS' syspref, to hide images...
span.no-image {
display: none;
}
3/ do a search that returns 'no image' results...
observe that 'no image' images are still displaying :(
4/ apply patch
5/ repeat step 2/
observe that 'no image' images are not displaying :)
Works as advertised.
Signed-off-by: Marc Véron
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13597] Amazon 'no image' element needs a 'no-image' class, in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15263] XSLT display fetches sysprefs for every result processed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15263] XSLT display fetches sysprefs for every result processed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Marcel de Rooy changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15895] Add Koha::Account module, use Koha::Account::pay internally for recordpayment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15126] REST API: Use newer version of Swagger2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15263] XSLT display fetches sysprefs for every result processed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Mirko Tietgen changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #18 from Mirko Tietgen --- The last followup uses OPACXSLTResultsDisplay for the details page, that should probably be OPACXSLTDetailsDisplay? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16309] opac-image.pl makes cpu 100%
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16309 --- Comment #2 from Hugo Agud --- You're right is a small server, but is not a production one, just for testing purpouses.. it has only 4 covers in biblioimages. And after one search cpu load aveage increase up to 4 .. it has just one moder cpu 3,3 ghz. We have other servers with older versions of koha with thousands of images and has not problem with opac-image.pl, we have just seen in 3.22, as we just wished to point it, just in case othe koha installations suffer the same problem. thanks for the answer and the links to the related bugs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16016] Integrate sitemap.pl into the packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016
Frédéric Demians changed:
What|Removed |Added
Attachment #48859|0 |1
is obsolete||
Attachment #48860|0 |1
is obsolete||
Attachment #49194|0 |1
is obsolete||
--- Comment #4 from Frédéric Demians ---
Created attachment 50498
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50498&action=edit
Bug 16016: Sitemap handling scripts for packages
This patch introduces the koha-sitemap script. This script wraps calls to
the misc/cronjobs/sitemap.pl script so it can be done easily instance-wise.
It sets /var/lib/koha/${instance}/sitemap as the destination directory for
the sitemap files. A followup will make them available through an Apache
configuration entry.
koha-functions.sh is provided with a handy is_sitemap_enabled function so
we can later add filters to other commands (koha-list, koha-foreach, etc).
Exposes sitemap files to apache. This is suitable for including the sitemap in
the robots.txt file as proposed in
http://www.sitemaps.org/protocol.html#submit_robots
Note: it depends on Apache 2.4+ so we can patch the file as needed. Older
Apache users will be warned that they need to tweak the apache files on their
own.
To test:
- You can build a package out of this patchset, or do the following on a
kohadevbox
cp debian/scripts/koha-functions.sh /usr/share/koha/bin
- Run
$ debian/scripts/koha-sitemap --help
- Go through all the options (--enable, --disable, generate).
(a) --enable:
- debian/scripts/koha-sitemap --enable kohadev
=> SUCCESS: /var/lib/koha/kohadev/sitemap.enabled is created
- call it again, a suitable warning is raised and the file is still there
(b) debian/scripts/koha-sitemap --disable kohadev
=> SUCCESS: /var/lib/koha/kohadev/sitemap.enabled is deleted
- call it again, a suitable warning is raised and the file does not exist
(c) --generate:
- debian/scripts/koha-sitemap --generate kohadev
=> SUCCESS: sitemapindex.xml and sitemap000X.xml files are generated in
/var/lib/koha/kohadev/sitemap/
- Sign off :-D
Sponsored-by: Orex Digital
Signed-off-by: Frédéric Demians
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16016] Integrate sitemap.pl into the packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 Frédéric Demians changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16299] Use validation plugin when creating a patron attribute type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16299 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16299] Use validation plugin when creating a patron attribute type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16299 Marc Véron changed: What|Removed |Added Attachment #50434|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 50499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50499&action=edit Bug 16299 - Use validation plugin when creating a patron attribute type This patch replaces custom client-side form validation with use of the jQuery validation plugin. Besides reducing the amount of code in the template, this allows us to eliminate use of "onclick." This patch also makes a correction for HTML validity: is not accepted. I have also added an id attribute to a which lacked it. To test, apply the patch and go to Administration -> Patron attribute types. - Test creating a new patron attribute type. Try to submit the form without a code, description, or both. You should be prevented from doing so. - Test editing an existing patron attribute type. You should not be able to remove the description and have it save successfully. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16315] New: OPAC Shelfbrowser doesn't display the full title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16315 Bug ID: 16315 Summary: OPAC Shelfbrowser doesn't display the full title Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: david.robe...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org The OPAC shelf browser function uses the title from biblio.title database field, which means it only displays the 245$a. The remainder of the title (in the 245$b and $c) doesn't display. An example of this can be seen here: https://sthlibraries.koha-ptfs.co.uk/cgi-bin/koha/opac-detail.pl?biblionumber=128424&shelfbrowse_itemnumber=267348#holdings It would be better if the whole title could be displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15938] Use validation plugin when adding or editing classification sources and filing rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15938 Marc Véron changed: What|Removed |Added Attachment #48475|0 |1 is obsolete|| --- Comment #4 from Marc Véron --- Created attachment 50500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50500&action=edit Bug 15938 - Use validation plugin when adding or editing classification sources and filing rules In Administration -> Classification sources there is some embedded JavaScript which checks for empty form values. This patch removes that JS and adds validation using the globally-included validation plugin instead. To test, apply the patch and go to Administration -> Classification sources. - Click to add a new classification source and confirm that you cannot submit the form with empty required values. - Edit an existing classification source and confirm that you cannot empty a required field and submit the form. - Repeat the previous two steps with filing rules. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15938] Use validation plugin when adding or editing classification sources and filing rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15938 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10459] borrowers should have a timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #29 from M. Tompsett ---
(In reply to Marcel de Rooy from comment #27)
> Thanks for reviving this.
> The reason I left this pending however, is probably as valid as then.
> If you call the field timestamp, we will have clashes in SQL joins here and
> there in the codebase where another table also has the same field timestamp.
> Especially think about the SELECT * statements with timestamp in another
> clause as well. So to prevent the ambiguous column name errors, we need to
> track these cases, test.. and hope we found them all.
> An older alternative to add bortimestamp, introducing a new name, did not
> meet much approval.
The problem is there are so many already with timestamp, I was thinking a
"rename the timestamp fields" bug would be a reasonable next step. I don't see
an immediate need to push this through right now. If there is a this bug blocks
that renaming bug, that would be a good next step.
Part of the discussion needs to be how to name timestamps.
Because while thinking about that very problem, I found:
DROP TABLE IF EXISTS `borrower_debarments`;
CREATE TABLE borrower_debarments ( -- tracks restrictions on the patron's
record
borrower_debarment_id int(11) NOT NULL AUTO_INCREMENT, -- unique key for the
restriction
borrowernumber int(11) NOT NULL, -- foreign key for borrowers.borrowernumber
for patron who is restricted
expiration date DEFAULT NULL, -- expiration date of the restriction
`type` enum('SUSPENSION','OVERDUES','MANUAL','DISCHARGE') NOT NULL DEFAULT
'MANUAL', -- type of restriction
`comment` text, -- comments about the restriction
manager_id int(11) DEFAULT NULL, -- foreign key for borrowers.borrowernumber
for the librarian managing the restriction
created timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE
CURRENT_TIMESTAMP, -- date the restriction was added
updated timestamp NULL DEFAULT NULL, -- date the restriction was updated
PRIMARY KEY (borrower_debarment_id),
KEY borrowernumber (borrowernumber),
CONSTRAINT `borrower_debarments_ibfk_1` FOREIGN KEY (`borrowernumber`)
REFERENCES `borrowers` (`borrowernumber`)
ON DELETE CASCADE ON UPDATE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
I think there is a logic error on the created timestamp. That is, I think the
ON UPDATE clause should be on the updated timestamp.
In short, timestamps that do exist in Koha are messy.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16306] C4::Context->setCommandlineEnvironment() convenience function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16306
Olli-Antti Kivilahti changed:
What|Removed |Added
Attachment #50454|0 |1
is obsolete||
--- Comment #2 from Olli-Antti Kivilahti ---
Created attachment 50501
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50501&action=edit
Bug 16306 - C4::Context->setCommandlineEnvironment() convenience function
There is no unified way to set the environment for commandline scripts,
even if the C4::Context->interface('commandline') explicitly allows setting
the cli interface.
This function wraps the complexity of environment setting in the command line.
Also a default user environment must be set.
To set the default user environment we need a default user. This patch
also makes sure that a default 'commandlineadmin' always exists in DB.
Usage:
use C4::Context;
BEGIN {
C4::Context->setCommandlineEnvironment();
}
... #Load other dependencies that might depend on the environment
or just:
...
use C4::Context;
C4::Context->setCommandlineEnvironment();
...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16316] New: Make it possible to limit patron search to surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 Bug ID: 16316 Summary: Make it possible to limit patron search to surname Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: mag...@libriotech.no Reporter: mag...@libriotech.no QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com I have a customer that wants to be able to limit a patron search to just searching for surnames. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16268] Add confirm message when deleting circ and fines rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16268 Marc Véron changed: What|Removed |Added Attachment #50301|0 |1 is obsolete|| --- Comment #5 from Marc Véron --- Created attachment 50502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50502&action=edit Bug 16268: Add confirm message for deleting circ and fines rules To test: 1) Apply 16267 2) Go to Admin -> Circ and fines rules 3) Try clicking on Delete and Unset buttons 4) Confirm a confirm message pops up and works as expected Sponsored-by: Catalyst IT Works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16268] Add confirm message when deleting circ and fines rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16268 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16317] New: Attempt to share private list results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16317 Bug ID: 16317 Summary: Attempt to share private list results in error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When sharing a private list, the the receiver of the share link will get the following error when they are logged in and try to click the link: DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'sharedate desc' in 'order clause' at /home/koha/kohaclone/Koha/Objects.pm line 150 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10459] borrowers should have a timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #30 from Marcel de Rooy ---
(In reply to M. Tompsett from comment #29)
> Because while thinking about that very problem, I found:
> DROP TABLE IF EXISTS `borrower_debarments`;
> CREATE TABLE borrower_debarments ( -- tracks restrictions on the patron's
> record
> borrower_debarment_id int(11) NOT NULL AUTO_INCREMENT, -- unique key for
> the restriction
> borrowernumber int(11) NOT NULL, -- foreign key for
> borrowers.borrowernumber for patron who is restricted
> expiration date DEFAULT NULL, -- expiration date of the restriction
> `type` enum('SUSPENSION','OVERDUES','MANUAL','DISCHARGE') NOT NULL DEFAULT
> 'MANUAL', -- type of restriction
> `comment` text, -- comments about the restriction
> manager_id int(11) DEFAULT NULL, -- foreign key for
> borrowers.borrowernumber for the librarian managing the restriction
> created timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE
> CURRENT_TIMESTAMP, -- date the restriction was added
> updated timestamp NULL DEFAULT NULL, -- date the restriction was updated
> PRIMARY KEY (borrower_debarment_id),
> KEY borrowernumber (borrowernumber),
> CONSTRAINT `borrower_debarments_ibfk_1` FOREIGN KEY (`borrowernumber`)
> REFERENCES `borrowers` (`borrowernumber`)
> ON DELETE CASCADE ON UPDATE CASCADE
> ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
>
> I think there is a logic error on the created timestamp. That is, I think
> the ON UPDATE clause should be on the updated timestamp.
Good catch. Proving at the same time that we did not adhere to just timestamp
everywhere in Koha :)
And I am not saying that we should, but others did..
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16317] Attempt to share private list results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16317 Kyle M Hall changed: What|Removed |Added Assignee|oleon...@myacpl.org |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16317] Attempt to share private list results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16317 --- Comment #1 from Kyle M Hall --- Created attachment 50503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50503&action=edit Bug 16317 - Attempt to share private list results in error When sharing a private list, the the receiver of the share link will get the following error when they are logged in and try to click the link: DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'sharedate desc' in 'order clause' at /home/koha/kohaclone/Koha/Objects.pm line 150 Test Plan: 1) Create a private list 2) Share that list to another account 3) Log in as the other account 4) Click the link in the email you recieved 5) Note the error 6) Apply this patch 7) Click the link again 8) You should see no error and be able to view the list! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16317] Attempt to share private list results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16317 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16317] Attempt to share private list results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16317 Owen Leonard changed: What|Removed |Added CC||oleon...@myacpl.org --- Comment #2 from Owen Leonard --- *** Bug 16287 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16287] Can't accept list share invitation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16287 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 16317 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16316] Make it possible to limit patron search to surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 Magnus Enger changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16316] Make it possible to limit patron search to surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 --- Comment #1 from Magnus Enger --- Created attachment 50504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50504&action=edit Bug 16316 - Limit patron search to surname This patch makes it possible to limit a patron search to search just for surnames. To test: - Apply the patch - Add two patrons, called e.g. "John Doe" and "Doe John" - Go to Patrons in the Intranet - Make sure you have selected "Search fields" = Standard - Search for "john" and verify both patrons show up - Search for "doe" and verify both patrons show up - Set "Search fields" = Surname and search for "john". "Doe John" should show up, but not "John Doe" - Set "Search fields" = Surname and search for "doe". Neither "Doe John" nor "John Doe" should show up. Sponsored-by: Alingsås Public Library, Sweden -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16317] Attempt to share private list results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16317 Owen Leonard changed: What|Removed |Added Attachment #50503|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 50505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50505&action=edit [SIGNED-OFF] Bug 16317 - Attempt to share private list results in error When sharing a private list, the the receiver of the share link will get the following error when they are logged in and try to click the link: DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'sharedate desc' in 'order clause' at /home/koha/kohaclone/Koha/Objects.pm line 150 Test Plan: 1) Create a private list 2) Share that list to another account 3) Log in as the other account 4) Click the link in the email you recieved 5) Note the error 6) Apply this patch 7) Click the link again 8) You should see no error and be able to view the list! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16317] Attempt to share private list results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16317 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15263] XSLT display fetches sysprefs for every result processed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15263] XSLT display fetches sysprefs for every result processed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Tomás Cohen Arazi changed: What|Removed |Added Attachment #50474|0 |1 is obsolete|| --- Comment #19 from Tomás Cohen Arazi --- Created attachment 50506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50506&action=edit Bug 15263: (QA followup) Use the new XSLTParse4Display everywhere Edit: fixed catalogue/detail.pl and opac/opac-detail.pl so they use the right XSLT syspref. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #49 from Owen Leonard --- Sorry, this does not apply anymore! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16316] Make it possible to limit patron search to surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16316 --- Comment #2 from Owen Leonard --- > - Set "Search fields" = Surname and search for "doe". > Neither "Doe John" nor "John Doe" should show up. Is this part of the test plan correct? Why should neither show up? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15263] XSLT display fetches sysprefs for every result processed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 --- Comment #24 from Kyle M Hall --- Created attachment 50511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50511&action=edit Bug 15263: (QA followup) Use the new XSLTParse4Display everywhere Edit: fixed catalogue/detail.pl and opac/opac-detail.pl so they use the right XSLT syspref. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15263] XSLT display fetches sysprefs for every result processed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 --- Comment #23 from Kyle M Hall --- Created attachment 50510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50510&action=edit Bug 15263: (QA followup) Make *shelves.pl use the new API This patch makes the lists work as the search results for rendering on XSLT-driven context. No behaviour change is expected. To test: - Apply the patch - Navigate lists (OPAC and intranet) => SUCCESS: the only difference is speed (faster) - Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15263] XSLT display fetches sysprefs for every result processed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 --- Comment #21 from Kyle M Hall --- Created attachment 50508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50508&action=edit Bug 15263: (follow-up) XSLT display fetches sysprefs for every result processed Set variables ($sysxml, $xslfilename, $lang) if they are not passed to the subroutine. This happens from catalogue/detail.pl, opac/opac-shelves.pl, opac/opac-tags.pl and virtualshelves/shelves.pl. Signed-off-by: Mirko Tietgen Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15263] XSLT display fetches sysprefs for every result processed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Kyle M Hall changed: What|Removed |Added Attachment #49502|0 |1 is obsolete|| Attachment #49503|0 |1 is obsolete|| Attachment #49504|0 |1 is obsolete|| Attachment #49505|0 |1 is obsolete|| Attachment #50506|0 |1 is obsolete|| --- Comment #20 from Kyle M Hall --- Created attachment 50507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50507&action=edit Bug 15263: XSLT display fetches sysprefs for every result processed On search, every single result goes through some XSLT processing. This includes fetching the relevant sysprefs every single time. We should do it only once per search. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15263] XSLT display fetches sysprefs for every result processed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 --- Comment #22 from Kyle M Hall --- Created attachment 50509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50509&action=edit Bug 15263: Bug 15263: (follow-up 2) XSLT display fetches sysprefs for every result processed Don't retrieve prefs if we won't need them Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15263] XSLT display fetches sysprefs for every result processed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #14 from Tomás Cohen Arazi --- Marcel and Bernardo, I ran the following in kohadevbox:ansible: $ sudo koha-shell kohadev ; cd kohaclone $ git grep -l "use t::lib::TestBuilder" | grep -v -e 'pm$' -e Old | xargs prove The results are: * Current master => SUCCESS: All tests pass in current master * master + 16155 => FAIL: - t/db_dependent/ILSDI_Services.t fails: # Failed test 'Test GetPatronInfo - show_attributes parameter' # at t/db_dependent/ILSDI_Services.t line 197. # Structures begin differing at: # $got = undef # $expected = ARRAY(0x8d3b150) # Looks like you failed 1 test of 16. - I see some new warnings, which I assume are related to the original tests being buggy, so this is a good one for this patchset: t/db_dependent/ILSDI_Services.t => Violation of unique constraint in Branch => Null value for borrowernumber in BorrowerAttribute not allowed t/db_dependent/Holds.t => Violation of unique constraint in Category t/db_dependent/Accounts.t => Violation of unique constraint in Branch That's what I found on a fresh environment (kohadevbox:ansible / jessie) I fail it because of the failing tests. This patchset is not responsible for the warnings. Will try to provide a followup and retest. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16228] Move some patron entry form JavaScript into members.js again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16228 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Marc Véron --- Sorry, does not apply: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16238] Upgrade jQuery in staff client: use .prop() instead of .attr()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #14 from Marc Véron --- Sorry, does not apply: Applying: Bug 16238: Use .prop() instead of .attr() for 'checked' Applying: Bug 16238: QA fix: remove tab characters Applying: Bug 16238: Use .prop() instead of .attr() for 'disabled' Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16297] Remove the use of "onclick" from OAI sets configuration template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16297 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16297] Remove the use of "onclick" from OAI sets configuration template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16297 Marc Véron changed: What|Removed |Added Attachment #50430|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 50512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50512&action=edit Bug 16297 - Remove the use of "onclick" from OAI sets configuration template In order to bring the OAI sets configuration template into compliance with coding guideline JS9, this patch changes with way some JavaScript events are handled by moving JS handling out of the HTML markup. To test, apply the patch and go to Administration -> OAI sets configuration. - Create or edit a set. - Test the "Add description" link. Clicking it should add a description textarea. - Test the "Remove" link associated with multiple description lines. Click them should remove the corresponding textarea. - Test that additions and removals are saved correctly. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #29 from Marc Véron --- Sorry, does not apply: Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14188] branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14188 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Kyle M Hall changed: What|Removed |Added Attachment #50131|0 |1 is obsolete|| Attachment #50132|0 |1 is obsolete|| Attachment #50133|0 |1 is obsolete|| --- Comment #29 from Kyle M Hall --- Created attachment 50513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50513&action=edit Bug 15757: Add one test for GetLoanLength The usual call (3 params) of this subroutine was not tested. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #30 from Kyle M Hall --- Created attachment 50514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50514&action=edit Bug 15757: Make issuelength default to null instead of 0 When editing circ rules, if the Loan period "issuelength" is not defined (empty string), the default value was 0, not it's inserted in the DB as NULL. Test plan: 1/ Create or edit a circ rule 2/ Do not fill the Loan period column 3/ Save => Without this patch, the value was 0 => With this patch it's now an empty string (in the DB it's set to NULL) Signed-off-by: Bernardo Gonzalez Kriegel Works as described. No errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #32 from Kyle M Hall --- Created attachment 50516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50516&action=edit Bug 15757 [QA Followup] - Having EDI configured will make unit tests fail Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #31 from Kyle M Hall --- Created attachment 50515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50515&action=edit Bug 15757: Make GetLoanLength defaults to 0 instead of 21 GetLoanLength arbitrary defaulted to 21. The expected behavior seems to be to default on 0 (loan will be dued today). IMPORTANT NOTE: This patch will introduce a change in the behaviors for configuration with a 0 in issuelength. Before this patch, the rule with a issuelength==0 was skipped, now it's used! Test plan: 1/ Do not define any rule: the due date will be today (before this patch was +21 days) 2/ Define some rules which does not match the patron category, itemtype or branchcode: the due date will be today (before this patch was +21 days). 3/ Modify a rule to match the checkout and set issuelength=0: the due date will be today (before this patch, the rule was skipped) 4/ Modify this rule and set the issuelength to something > 0: the due date will be adjusted (same behavior as before this patch) Signed-off-by: Bernardo Gonzalez Kriegel Works ok, checked 1-4 All test pass No koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marc Véron changed: What|Removed |Added Attachment #41872|0 |1 is obsolete|| --- Comment #11 from Marc Véron --- Created attachment 50517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50517&action=edit Bug 13961: Option to include patron's total amount of fines in notices Possibility to show patrons's total amount of fines in notices. Test plan: 1. Apply patch 2. Modify some notice in Tools -> notices & slips 3. See that in the left side of where one can edit message's body is now also a new attribute that one can include to the text: borrowers.totalfine 4. Include that to the text and see it showing the patron's total amount of fines. Sponsored-by: Vaara-kirjastot Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155 --- Comment #15 from Bernardo Gonzalez Kriegel --- Same result on standard clean install -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 50518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50518&action=edit Bug 16155: (QA followup) fix small bug in t/db_dependent/ILSDI_Services.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marc Véron changed: What|Removed |Added Attachment #42089|0 |1 is obsolete|| --- Comment #12 from Marc Véron --- Comment on attachment 42089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42089 [Follow-up] Remove whitespace from line 648 in C4/Letters.pm QA tools no longer complain regarding first patch. Obsoleting this follow-up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12752] OVERDUE notice mis-labeled as "Hold Available for Pickup"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 Kyle M Hall changed: What|Removed |Added Attachment #50369|0 |1 is obsolete|| --- Comment #12 from Kyle M Hall --- Created attachment 50520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50520&action=edit Bug 12752: FIX letter names in 3.15.00.041 3.15.00.041 was wrong, the name of the letter should not always been the name of the first HOLD notice. PREDUE_PHONE should be updated with the first name of the PREDUE notice, same for OVERDUE_PHONE and OVERDUE Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12752] OVERDUE notice mis-labeled as "Hold Available for Pickup"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12752] OVERDUE notice mis-labeled as "Hold Available for Pickup"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
