[Koha-bugs] [Bug 12267] Allow password option in Patron Attribute non functional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12267 --- Comment #20 from Marcel de Rooy --- t/db_dependent/Members/Attributes.t adjusted on bug 16377 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16377] Fix t/db_dependent/Members/Attributes.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16377 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12267 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12267] Allow password option in Patron Attribute non functional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12267 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16377 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16377] Fix t/db_dependent/Members/Attributes.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16377 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16377] Fix t/db_dependent/Members/Attributes.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16377 --- Comment #1 from Marcel de Rooy --- Created attachment 50872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50872&action=edit Bug 16377: Fix t/db_dependent/Members/Attributes.t This is a follow-up for bug 12267 fixing the test, still referring to password fields. Test plan: Run the test. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16377] New: Fix t/db_dependent/Members/Attributes.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16377 Bug ID: 16377 Summary: Fix t/db_dependent/Members/Attributes.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: m.de.r...@rijksmuseum.nl QA Contact: gmcha...@gmail.com t/db_dependent/Members/Attributes.t(Wstat: 1024 Tests: 57 Failed: 4) Failed tests: 19, 23, 36, 56 Non-zero exit status: 4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 --- Comment #3 from David Cook --- Ahh, I bet it's truncating it to compare it to "single_holidays" and "exception_holidays"... right... that makes sense. In that case, before truncating it, I think you have to turn it into a "floating" DateTime. Except that we're using the Timezone in single_holidays() and exception_holidays()... that's great... I think we might need to re-think Koha::Calendar in light of https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 David Cook changed: What|Removed |Added CC||la...@opengeek.cl --- Comment #2 from David Cook --- This problem was brought to me by Larry Letelier who found that he couldn't use overdue_notices.pl because of this error. You can replicate it by creating a Koha::Calendar, and then running the following: use DateTime; use Koha::DateUtils; use Koha::Calendar; my $dt = DateTime->new( month => 9, year => 2015, day => 6, hour => 12, minute => 00, second => 00, time_zone => 'America/Santiago', ); my $now = DateTime->now(); my $calendar = Koha::Calendar->new(branchcode => "MAIN"); $calendar->days_between($dt, $now); Run that using the America/Santiago TZ environmental variable: TZ=America/Santiago perl issues.pl -- You should get the "Invalid local time for date in time zone: America/Santiago" message and the script should die. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16376] New: Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376
Bug ID: 16376
Summary: Koha::Calendar->is_holiday date truncation creates
fatal errors for TZ America/Santiago
Change sponsored?: ---
Product: Koha
Version: 3.20
Hardware: All
OS: All
Status: NEW
Severity: critical
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs@lists.koha-community.org
Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Koha::Calendar->is_holiday calls the following DateTime truncate method:
$localdt->truncate( to => 'day' );
This will truncate 2015-09-06 12:00:00 down to 2015-09-06 00:00:00.
This causes major problems in Santiago, Chile, because 2015-09-06 is an invalid
local time due to DST.
I can't explain why it's a problem in 2015 because DST is weird in Chile in
2015, but it's obviously a problem for every other year as well:
http://www.timeanddate.com/time/change/chile/santiago?year=2015
Consider 2014:
2014Sunday, 27 April, 12:00 MidnightSunday, 7 September, 12:00
Midnight
You shouldn't have a problem on 27 April, because when 27 April 12:00 midnight
hits (relative to UTC), local time is changed to 27 April 11:00pm. While UTC
marches on, local time has been magically moved back an hour.
You will have a problem on 7 September 12:00 midnight though, because that time
doesn't exist. As soon as we roll over from 6 September 11:59pm to the next
minute... we're actually on to 7 September 01:00:00am. Midnight doesn't exist
on that day, which creates the following error in DateTime.pm:
"Invalid local time for date in time zone: America/Santiago"
This is a problem that the DateTime writer predicted. You can see their
comments here:
http://cpansearch.perl.org/src/DROLSKY/DateTime-1.26/lib/DateTime.pm
https://rt.cpan.org/Public/Bug/Display.html?id=93347
We should probably do something like:
eval {
$dt->truncate(to => 'day');
} || warn "Eval failed with '$@'\n";
Why are we even doing this day truncation?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 --- Comment #1 from David Cook --- You can easily verify this with the following Perl code: use DateTime; my $dt = DateTime->new( month => 9, year => 2015, day => 6, hour => 12, minute => 00, second => 00, time_zone => 'America/Santiago', ); print "DateTime:\n"; print $dt."\n"; print "Timezone:\n"; print $dt->time_zone()->name."\n"; print "Let's truncate...\n"; $dt->truncate( to => 'day'); TZ=America/Santiago perl issues.pl DateTime: 2015-09-06T12:00:00 Timezone: America/Santiago Let's truncate... Invalid local time for date in time zone: America/Santiago -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16373] merge.pl reports success but files are not merged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16373 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16375] Add arg to 'koha-upgrade-schema' to run on a specific 'updatedb.pl' file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16375 Mason James changed: What|Removed |Added Assignee|gmcha...@gmail.com |m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16375] New: Add arg to 'koha-upgrade-schema' to run on a specific 'updatedb.pl' file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16375 Bug ID: 16375 Summary: Add arg to 'koha-upgrade-schema' to run on a specific 'updatedb.pl' file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcha...@gmail.com Reporter: m...@kohaaloha.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Add arg to 'koha-upgrade-schema' to run on a specific 'updatedb.pl' file more info to come... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16369] Clean up and improve plugins template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369 Arslan Farooq changed: What|Removed |Added CC||arslan...@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Arslan Farooq --- Hi Owen, when applying the patch, it says: -- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 16369 - Clean up and improve plugins template Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc Failed to merge in the changes. Patch failed at 0001 Bug 16369 - Clean up and improve plugins template When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16372] Replace the use of "onclick" for deletion confirmation in some templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 --- Comment #3 from Arslan Farooq --- Did QA tools as well, and it passed. However, there was that Plugins.pm message again "Compilation failed in require at /usr/local/lib/perl/5.14.2/Template/Plugins.pm line 206." - FAILkoha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt OK forbidden patterns SKIP spelling OK tt_valid FAIL valid_template Attempt to reload Koha/Template/Plugin/Koha.pm aborted. Compilation failed in require at /usr/local/lib/perl/5.14.2/Template/Plugins.pm line 206. OK koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt OK forbidden patterns SKIP spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt OK forbidden patterns SKIP spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt OK forbidden patterns SKIP spelling OK tt_valid OK valid_template - -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16372] Replace the use of "onclick" for deletion confirmation in some templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 Arslan Farooq changed: What|Removed |Added Attachment #50832|0 |1 is obsolete|| Assignee|oleon...@myacpl.org |arslan...@gmail.com Status|Needs Signoff |Signed Off CC||arslan...@gmail.com --- Comment #2 from Arslan Farooq --- Created attachment 50871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50871&action=edit Bug 16372 - Replace the use of "onclick" for deletion confirmation in some templates This patch removes the use of event attributes from several templates where the attributes were used to handle deletion operations. I've grouped these changes in one patch because each template had only small changes to be made. Unrelated change: Reformatted the "no news items" message which is displayed if there are no news items. To test, apply the patch and test deletion operations on the following pages. Clicking "delete" should prompty you to confirm. Test both the confirm and cancel actions. - On the staff client home page, test deletion of a news item. - On the patron lists page, test deletion of a patron list. - In the patron card creator, choose Manage -> Images. Test the "Delete" button for a single image. - On the news page, test deletion of a single news item. - On the news page, test deletion of multiple items. - All things were tested and everything worked OK. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #39 from Srdjan Jankovic --- (In reply to Kyle M Hall from comment #36) > On the OPAC side I'm getting: > > Could not compile /home/vagrant/kohaclone/opac/opac-tags.pl: Attempt to > reload C4/Auth.pm aborted. > Compilation failed in require at /home/vagrant/kohaclone/opac/opac-tags.pl > line 38. > BEGIN failed--compilation aborted at > /home/vagrant/kohaclone/opac/opac-tags.pl line 38. I'm not getting that now with the amended patch. Please let me know if it persists in your env. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #38 from Srdjan Jankovic --- (In reply to Kyle M Hall from comment #34) > Getting errors now when using a fresh install of kohadevbox with plack: > > Could not compile /home/vagrant/kohaclone/mainpage.pl: Can't call method > "get_from_cache" on an undefined value at > /home/vagrant/kohaclone/C4/Context.pm line 593. > BEGIN failed--compilation aborted at /home/vagrant/kohaclone/C4/Auth.pm line > 91. > Compilation failed in require at /home/vagrant/kohaclone/mainpage.pl line 25. > BEGIN failed--compilation aborted at /home/vagrant/kohaclone/mainpage.pl > line 25. That will teach me to test with both memcached on and off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic changed: What|Removed |Added Attachment #50716|0 |1 is obsolete|| --- Comment #37 from Srdjan Jankovic --- Created attachment 50870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50870&action=edit bug_15562: Removed Koha::Cache->get_instance() There should be no cache singleton, full stop. If Koha is to move away from .pl scripts that is. As an interim measure Koha::Cache->get_instance() is replaced with C4::Context->cache, in the vein of C4::Context->memcached. In that respect it will continue to work in the singleton-ish way if context is used as a singleton, but supports cache-per-context. Koha::Handler::Plack->app_per_host() cache sysprefs using Context memcached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #29 from David Cook --- (In reply to Pedro Ferreira from comment #28) > I did not test the new koha version 3.22 > But i followed all the steps and in version 3.20 did not work.. Can you list here the exact steps that you took? That'll help us with troubleshooting. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16105] Cache::Memory is loaded even if memcache is used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16105 Chris Cormack changed: What|Removed |Added Attachment #49315|0 |1 is obsolete|| --- Comment #5 from Chris Cormack --- Created attachment 50869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50869&action=edit Bug 16105: Do not initialize the memory cache if not needed Cache::Memory is loaded and Koha::Cache::_initialize_memory is called even if a memcached cache has been correctly initialize, it does not make sense. It should only be initialize if needed. Test plan: Correctly configure a memcache server and confirm that the memory cache is not initialize. Do not configure correctly a memcache server and confirm that the cache system default on Cache::Memory Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16105] Cache::Memory is loaded even if memcache is used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16105 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #34 from Bernardo Gonzalez Kriegel --- Hi Jonathan, all is signed but I found a little problem, added a possible solution. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #33 from Bernardo Gonzalez Kriegel --- Created attachment 50868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50868&action=edit Bug 15451: (followup) fix filename extension for csv file This patch does the same as basket/downloadcart.pl to set '.csv' as filename extension for downloadshelf.pl To test: 1) Define a CSV MARC profile 2) On staff download a list, extension is '.NN' with 'NN' the CSV profile id. 3) Apply the patch 4) Download again, check extension is now '.csv' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #50185|0 |1 is obsolete|| --- Comment #32 from Bernardo Gonzalez Kriegel --- Created attachment 50867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50867&action=edit [SIGNED-OFF] Bug 15451: Do not considered a Resultset as a Result The previous calls were wrong, but there is something bad with the DB structure: export_format.profile should be a unique key. This patch fixes the previous calls and add a FIXME not to forget to fix the DB structure. Signed-off-by: Bernardo Gonzalez Kriegel Previous test where done with all patches applied, including this one, and all worked. No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #50180|0 |1 is obsolete|| --- Comment #27 from Bernardo Gonzalez Kriegel --- Created attachment 50862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50862&action=edit [SIGNED-OFF] Bug 15451: Koha::CsvProfiles - Remove GetCsvProfilesLoop This subroutine returned the csv profiles for a given type. This could be done easily with the new Koha::CsvProfiles->search method. Test plan: To do at the OPAC and staff interface! 1/ Export a list using a CSV profile 2/ Export your CART using a CSV profile Note that only MARC profiles should be available. Signed-off-by: Bernardo Gonzalez Kriegel Tested on staff/opac & cart/list Small problem on filename extension fixed in followup. No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #50184|0 |1 is obsolete|| --- Comment #31 from Bernardo Gonzalez Kriegel --- Created attachment 50866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50866&action=edit [SIGNED-OFF] Bug 15451: Koha::CsvProfiles - Remove the residue This patch erase all traces of C4::Csv since it's not used anymore. All occurrences have been replaced by previous patches to use Koha::CsvProfiles. Note that GetMarcFieldsForCsv was not used prior this patch set. Test plan: git grep 'C4::Csv' should not return any result. Signed-off-by: Bernardo Gonzalez Kriegel No more traces of the file. This produces a koha-qa fail, due to the missing file. No other errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #50179|0 |1 is obsolete|| --- Comment #26 from Bernardo Gonzalez Kriegel --- Created attachment 50861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50861&action=edit [SIGNED-OFF] Bug 15451: Rewrite the csv profile tool script This page was inconsistent with the other admin and tool pages. The 2 tabs 'New profile' and 'Edit existing profile' were useless, the ergonomic needs to be revisited. This patch applies the same script/page structure as others: by default a table containing all csv profiles is displayed with 2 action links: edit and delete. Test plan: 1/ Create 1+ CSV profiles, with different types (marc and sql) 2/ Update some values using the Edit link 3/ Delete a CSV profile Note: When deleting a CSV profile, it would be great to warn the user if it is used. Signed-off-by: Bernardo Gonzalez Kriegel No problems on create, update and delete. No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #50183|0 |1 is obsolete|| --- Comment #30 from Bernardo Gonzalez Kriegel --- Created attachment 50865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50865&action=edit [SIGNED-OFF] Bug 15451: Koha::CsvProfiles - Remove GetCsvProfile This subroutine just returned a csv profile for a given id. It is replaced in this patch by a call to Koha::CsvProfiles->find. There is nothing to test here, these changes have been tested in previous patches. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #50181|0 |1 is obsolete|| --- Comment #28 from Bernardo Gonzalez Kriegel --- Created attachment 50863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50863&action=edit [SIGNED-OFF] Bug 15451: Koha::CsvProfiles - Remove GetCsvProfiles This subroutine did the same job as GetCsvProfilesLoop, so this patch applies the same changes as the previous patch. Test plan: 1/ Claim some serials, sql profiles should be listed 2/ Export records using the export tool. MARC profiles should be listed. Signed-off-by: Bernardo Gonzalez Kriegel Listed sql & marc profiles No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #50182|0 |1 is obsolete|| --- Comment #29 from Bernardo Gonzalez Kriegel --- Created attachment 50864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50864&action=edit [SIGNED-OFF] Bug 15451: Koha::CsvProfiles - Remove GetCsvProfileId This subroutine returned the export_format_id for a given profile name. This can be done easily with the Koha::CsvProfiles->search method. Test plan: Export records using the misc/export_records.pl script and the export tool. If you are exporting using the MARC format, the profile filled in the pref ExportWithCsvProfile will be used (or the one passed in parameter of misc/export_records.pl). If you are exporting using the CSV format, you can choose a profile in the dropdown list. Signed-off-by: Bernardo Gonzalez Kriegel Exported using tool & cmd, marc & csv. Pref is used. No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #50178|0 |1 is obsolete|| --- Comment #25 from Bernardo Gonzalez Kriegel --- Created attachment 50860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50860&action=edit [SIGNED-OFF] Bug 15451: Add the 2 new modules Koha::CsvProfile[s] There are based on Koha::Objets. Tests provided. Signed-off-by: Bernardo Gonzalez Kriegel Test pass, no errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10171] Add a header in Advanced Search (staff interface)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171 --- Comment #5 from Owen Leonard --- Created attachment 50859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50859&action=edit Bug 10171 [Follow-up] Add a header in Advanced Search (staff interface) This patch re-indents the new include file because it's not often you get to help a new file come into the world, it should be indented nicely. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10171] Add a header in Advanced Search (staff interface)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171 Owen Leonard changed: What|Removed |Added Attachment #50783|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 50858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50858&action=edit [SIGNED-OFF] Bug 10171: Add a search box include on advanced search and item search pages This patch creates a new file: adv-search.inc. This search include has no catalog search (as it makes no sense to have the catalog search tab on the advanced search page). The item search page uses home-search.inc (with catalog search) as the catalog search is different to the item search. To test: 1) Go to Search (advanced search) 2) Confirm search header is there with no catalog search tab and works as expected 3) Go to item search 4) Confirm search header is there with catalog search tab and works as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10171] Add a header in Advanced Search (staff interface)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16374] Support cataloging fanzines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16374 --- Comment #2 from Owen Leonard --- Koha supports cataloging books, DVDs, magazines, comic books, video games, laptops, tablets, bicycles, infrared thermometers, pocket digital projectors, and anything else you can think of. This sounds like a cataloging question rather than a question of Koha functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16364] Cleaning up appearance of advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16364 --- Comment #8 from Aleisha Amohia --- (In reply to Owen Leonard from comment #7) > Aleisha if you're looking to make two 50% width columns, the built-in grid > can do that: > > https://wiki.koha-community.org/wiki/Interface_patterns#Grids_within_pages I think this may have been exactly what I was needing ... thanks, will have a look at a new patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16364] Cleaning up appearance of advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16364 --- Comment #7 from Owen Leonard --- Aleisha if you're looking to make two 50% width columns, the built-in grid can do that: https://wiki.koha-community.org/wiki/Interface_patterns#Grids_within_pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16363] Use floating toolbar on advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Owen Leonard changed: What|Removed |Added Attachment #50849|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 50857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50857&action=edit [SIGNED-OFF] Bug 16363: Add floating toolbar to advanced search EDIT: Ah yes I was so sure it wasn't mini but couldn't remember what to use! Thanks for that Owen To test: 1) Go to advanced search 2) Confirm Save, More Options and Clear fields (notice change from New search to Clear fields) are in toolbar and work as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16363] Use floating toolbar on advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16360] Buttons wrap in Actions column for reviewing tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Owen Leonard changed: What|Removed |Added Attachment #50850|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16360] Buttons wrap in Actions column for reviewing tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16360] Buttons wrap in Actions column for reviewing tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 --- Comment #5 from Owen Leonard --- Created attachment 50856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50856&action=edit [SIGNED-OFF] Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap EDIT: Comment 3 Note: the wrapping only happens when all tags have been approved (or all rejected), i.e. column has a certain width. When testing, ensure all tags have been approved or rejected and click the opposite action to see the effect of the bug and the patch. To test: 1) Go to Tools -> Tags 2) Click Reject for a tag 3) Notice buttons do not wrap Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 Chris Cormack changed: What|Removed |Added Attachment #50792|0 |1 is obsolete|| --- Comment #20 from Chris Cormack --- Created attachment 50855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50855&action=edit Bug 12721: (followup) Replace mysqlism by DBIx::Class This patch removes the mysqlism (see comment #18) Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16374] Support cataloging fanzines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16374 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- What do you suggest to make this easier? It's up to you how much information you catalog - none of the fields have to be mandatory - although I'd recommend to have 245$a :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16374] New: Support cataloging fanzines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16374 Bug ID: 16374 Summary: Support cataloging fanzines Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: nicolasm...@tutanota.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Fanzines can generally be difficult to catalog, since many lack basic info such as authorship, year and place of production or contact address. Koha should probably do something in the sense of making zines more easily catalogued. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Katrin Fischer changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16253] Acq: Change "Delete order" to "Cancel order line" on basket summary and receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16253 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16253] Acq: Change "Delete order" to "Cancel order line" on basket summary and receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16253 Katrin Fischer changed: What|Removed |Added Attachment #50851|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 50854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50854&action=edit [PASSED QA] Bug 16253: Changing 'delete order' to 'cancel order' To test: 1) Go to Acqui -> do a vendor search and view an open basket 2) Confirm last column heading says cancel instead of delete 3) Confirm link to cancel order says cancel instead of delete 4) If can't delete record, confirm reasons say cancel order instead of delete 5) Click the vendor name, then Baskets tab, then Receive Shipment 6) Fill vendor invoice field and click next 7) If there are any pending orders, confirm that all instances of 'delete order' now say cancel Sponsored-by: Catalyst IT Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16373] merge.pl reports success but files are not merged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16373 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Severity|normal |blocker --- Comment #1 from Katrin Fischer --- Can confirm this is broken again on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16373] New: merge.pl reports success but files are not merged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16373 Bug ID: 16373 Summary: merge.pl reports success but files are not merged Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Testing on master and 3.22.5 showed this issue, 3.20.x everything works fine To recreate: Select two biblios to merge Merge them Sucess reported but list of bibs contains only the reference record. View the 'new' record, it won't have any additional items View the 'merged' record, it is still there with its items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16373] merge.pl reports success but files are not merged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16373 Nick Clemens changed: What|Removed |Added Severity|enhancement |normal Priority|P5 - low|P3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- Please avoid the use of Switch and use if...elsif instead! Switch was first released with perl v5.7.3, deprecated (will be CPAN-only) in v5.11.0 and removed from v5.13.1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15126] REST API: Use newer version of Swagger2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Jesse Weaver changed: What|Removed |Added CC||jwea...@bywatersolutions.co ||m --- Comment #41 from Jesse Weaver --- I verified that most of these changes work correctly in the process of testing bug 13903, so I'd be happy to put my Passed QA stamp on this, but I'm just now coming into this discussion and not sure where things stand. If Galen has a packages for the new Swagger today or tomorrow, are the other concerns on this bug resolved? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Katrin Fischer changed: What|Removed |Added Summary|Add API routes to list, |Add API routes to list, |create, update, delete |create, update, delete |reserves|holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Jesse Weaver changed: What|Removed |Added Status|NEW |Needs Signoff CC||jwea...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15531] Add support for standing orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #14 from Katrin Fischer --- 1) Database update: can you please include an AFTER there to ensure that the column always ends up in the same spot? 2)Add order: "Orders are standing:" basket summary: "Is standing order basket" Non-native speaker :), but wondering if 'Standing order:' would work too? Might cause less confusion in translation. 3) When ordering from a staged file using the checkboxes, it seems that an item is generated, while this doesn't happen when using one of the other order options. This might be something to look into - what's the intended behaviour when AcqCreateItem is set to 'placing an order'? I think to not overcomplicate things for now I think it would be ok to say items for standing orders have to be created separately. Later on, optionally creating items on order/receive would be nice. 4) If you edit the order after creating it - the checkbox is unchecked even if your basket 'is_standing'. 5) The order status of the order lines will remain 'new' (usually means: not send to the vendor, unfinished) as the basket is never closed, which would set it to 'ordered'. Should we use a new order status here? I think it would be good for searching and to help avoid confusion. Maybe 'standing'? Otherwise this seems to work pretty well - with serial subscription orders too! Please take a look asap! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903
--- Comment #19 from Jesse Weaver ---
Created attachment 50853
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50853&action=edit
Bug 13903: (QA followup) change routes to /holds
GET/holds?borrowernumber=X (list)
POST /holds (create)
PUT/holds/{reserve_id} (update)
DELETE /holds/{reserve_id} (delete)
Unit tests in t/db_dependent/api/v1/holds.t
Signed-off-by: Jesse Weaver
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903
Jesse Weaver changed:
What|Removed |Added
Attachment #49843|0 |1
is obsolete||
--- Comment #18 from Jesse Weaver ---
Created attachment 50852
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50852&action=edit
Bug 13903: Add API routes to list, create, update, delete reserves
GET/reserves?borrowernumber=X (list)
POST /reserves (create)
PUT/reserves/{reserve_id} (update)
DELETE /reserves/{reserve_id} (delete)
Unit tests in t/db_dependent/api/v1/reserves.t
Test plan:
1. Apply patch
2. Run unit tests
3. Play with the API with your favorite REST client, using documentation
in the swagger.json file
4. Try to make reserves until the maximum number of reserves for a user
is reached (you should have a 403 error)
Depends on bug 15126
Signed-off-by: Benjamin Rokseth
Signed-off-by: Jesse Weaver
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Jesse Weaver changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16253] Acq: Change "Delete order" to "Cancel order line" on basket summary and receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16253 Mirko Tietgen changed: What|Removed |Added Attachment #50691|0 |1 is obsolete|| --- Comment #2 from Mirko Tietgen --- Created attachment 50851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50851&action=edit Bug 16253: Changing 'delete order' to 'cancel order' To test: 1) Go to Acqui -> do a vendor search and view an open basket 2) Confirm last column heading says cancel instead of delete 3) Confirm link to cancel order says cancel instead of delete 4) If can't delete record, confirm reasons say cancel order instead of delete 5) Click the vendor name, then Baskets tab, then Receive Shipment 6) Fill vendor invoice field and click next 7) If there are any pending orders, confirm that all instances of 'delete order' now say cancel Sponsored-by: Catalyst IT Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16253] Acq: Change "Delete order" to "Cancel order line" on basket summary and receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16253 Mirko Tietgen changed: What|Removed |Added CC||mi...@abunchofthings.net Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16360] Buttons wrap in Actions column for reviewing tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16360] Buttons wrap in Actions column for reviewing tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Aleisha Amohia changed: What|Removed |Added Attachment #50778|0 |1 is obsolete|| --- Comment #4 from Aleisha Amohia --- Created attachment 50850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50850&action=edit Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap EDIT: Comment 3 Note: the wrapping only happens when all tags have been approved (or all rejected), i.e. column has a certain width. When testing, ensure all tags have been approved or rejected and click the opposite action to see the effect of the bug and the patch. To test: 1) Go to Tools -> Tags 2) Click Reject for a tag 3) Notice buttons do not wrap Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16363] Use floating toolbar on advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Aleisha Amohia changed: What|Removed |Added Attachment #50784|0 |1 is obsolete|| --- Comment #5 from Aleisha Amohia --- Created attachment 50849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50849&action=edit Bug 16363: Add floating toolbar to advanced search EDIT: Ah yes I was so sure it wasn't mini but couldn't remember what to use! Thanks for that Owen To test: 1) Go to advanced search 2) Confirm Save, More Options and Clear fields (notice change from New search to Clear fields) are in toolbar and work as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16363] Use floating toolbar on advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16364] Cleaning up appearance of advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16364 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16364] Cleaning up appearance of advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16364 --- Comment #6 from Katrin Fischer --- Hm ok, scratch that - seems to only apply to the OPAC! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16364] Cleaning up appearance of advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16364 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- Hi Aleisha, did you see the more/fewer options are configurable with system preferences? Maybe that's one of the differences between yours and Owen's view. (OpacAdvSearchMoreOptions, OpacAdvSearchOptions) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16364] Cleaning up appearance of advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16364 --- Comment #4 from Aleisha Amohia --- However, when I click More options on my computer at work the layout looks the way it should but it breaks on my personal laptop. I will keep working on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16364] Cleaning up appearance of advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16364 --- Comment #3 from Aleisha Amohia --- Created attachment 50848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50848&action=edit This is how it should look showing fewer options -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16363] Use floating toolbar on advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Aleisha Amohia changed: What|Removed |Added Attachment #50847|0 |1 is obsolete|| --- Comment #4 from Aleisha Amohia --- Comment on attachment 50847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50847 This is how it should look showing fewer options Sorry, wrong bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16363] Use floating toolbar on advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 --- Comment #3 from Aleisha Amohia --- Created attachment 50847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50847&action=edit This is how it should look showing fewer options -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16362] Software error when adding an item to a list in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16362 Aleisha Amohia changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Aleisha Amohia --- (In reply to Bernardo Gonzalez Kriegel from comment #1) > Works for me, adding from a search or by barcode. > > Steps to reproduce? This is a problem with my own configuration. Never mind! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16016] Integrate sitemap.pl into the packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 --- Comment #7 from Tomás Cohen Arazi --- (In reply to Mirko Tietgen from comment #6) > Kyle beat me to it. One thing i saw: > > > if /usr/sbin/apache2ctl -v | grep -q -v "Server version: Apache/2.4"; then > > I guess that will break it for Apache > 2.4? I'll fix it once new Apaches are born. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16080] Remove unused images from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #50837|0 |1 is obsolete|| --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 50846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50846&action=edit [SIGNED-OFF] Bug 16080 [Revised] Remove unused images from the staff client This patch removes images from the staff client templates which are no longer used. To test you must (as of 2016-04-22) apply the patch for Bug 16241. Apply the patch and search for references in the Koha code to the removed images. You should find none. The staff client CSS file has been updated to remove obsolete references to image files. These old styles were made obsolete by the switch to Font Awesome icons. Revision removes reference to glyphicons-halflings-koha.png from circ/offline-mf.tt Signed-off-by: Bernardo Gonzalez Kriegel On top of Bug 16241 No reference of deleted files (only on PO files but that will be fixed later) No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16080] Remove unused images from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13877] seasonal predictions showing wrong in test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13877 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13877] seasonal predictions showing wrong in test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13877 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #50572|0 |1 is obsolete|| --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 50845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50845&action=edit [SIGNED-OFF] Bug 13877 - Fix QA issues Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16362] Software error when adding an item to a list in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16362 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #1 from Bernardo Gonzalez Kriegel --- Works for me, adding from a search or by barcode. Steps to reproduce? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Kyle M Hall changed: What|Removed |Added Attachment #50843|0 |1 is obsolete|| --- Comment #55 from Kyle M Hall --- Created attachment 50844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50844&action=edit Bug 14377 [QA Followup] - Fix conditional -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Kyle M Hall changed: What|Removed |Added Attachment #50842|0 |1 is obsolete|| --- Comment #54 from Kyle M Hall --- Created attachment 50843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50843&action=edit Bug 14377 [QA Followup] - Fix conditional -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall changed: What|Removed |Added Attachment #50841|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #53 from Kyle M Hall --- Created attachment 50842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50842&action=edit Bug 14377 [QA Followup] - Fix conditional -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall changed: What|Removed |Added Attachment #50840|0 |1 is obsolete|| --- Comment #27 from Kyle M Hall --- Created attachment 50841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50841&action=edit Bug 14337 [QA Followup] - Fix conditional -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #26 from Kyle M Hall --- Created attachment 50840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50840&action=edit Bug 14337 [QA Followup] - Fix conditional -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #52 from Kyle M Hall --- Created attachment 50839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50839&action=edit Bug 14377 [QA Followup] - Remove biblionumber from messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 --- Comment #7 from Kyle M Hall --- Created attachment 50838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50838&action=edit Bug 15532 [QA Followup] - Remove unused variable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- Small problem noted by the QA script: FAIL t/db_dependent/Holds/HoldFulfillmentPolicy.t FAIL critic "$holds_queue" is declared but not used at line 79, column 1. Unused variables clutter code and make it harder to read. OK forbidden patterns OK pod OK spelling 0 OK valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16351] Error when trying to receive a new shipment without specifying invoice number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16351] Error when trying to receive a new shipment without specifying invoice number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Passed QA |Signed Off --- Comment #6 from Katrin Fischer --- Note: Error is only shown when AcqWarnOnDuplicateInvoice is not in use. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16080] Remove unused images from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Owen Leonard changed: What|Removed |Added Attachment #50590|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 50837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50837&action=edit Bug 16080 [Revised] Remove unused images from the staff client This patch removes images from the staff client templates which are no longer used. To test you must (as of 2016-04-22) apply the patch for Bug 16241. Apply the patch and search for references in the Koha code to the removed images. You should find none. The staff client CSS file has been updated to remove obsolete references to image files. These old styles were made obsolete by the switch to Font Awesome icons. Revision removes reference to glyphicons-halflings-koha.png from circ/offline-mf.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16351] Error when trying to receive a new shipment without specifying invoice number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16351] Error when trying to receive a new shipment without specifying invoice number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Katrin Fischer changed: What|Removed |Added Attachment #50816|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 50836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50836&action=edit [PASSED QA] Bug 16351: Making invoice number a required field EDIT: Added 'validated' class to form and removed 'Required' span (became unnecessary) To test: 1) Go to Acqui -> Do a vendor search 2) Receive a shipment 3) Attempt to click 'Next' without specifying invoice number. Notice error. 4) Go back to vendor search then apply patch. Click Receive shipment 5) Notice you cannot click 'Next' until you put something in invoice number. Sponsored-by: Catalyst IT Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Depends on||14577 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Kyle M Hall changed: What|Removed |Added Blocks||14570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 [Bug 14570] Make it possible to add multiple guarantors to a record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 --- Comment #18 from Kyle M Hall --- Created attachment 50835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50835&action=edit Bug 14577 [QA Followup] Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
