[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log them selves recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Katrin Fischer changed: What|Removed |Added Summary|When automatically |When automatically deleting |suppressing expired |expired borrowers, make |borrowers, make sure they |sure they didn't log them |didn't log them selves |selves recently |recently| CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16393] mysql error 1171 in Web installer Step 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16393 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16402 --- Comment #5 from Katrin Fischer --- Please take a look at bug 16402 for a possible fix! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing the Database Structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16393 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID Status|Patch doesn't apply |RESOLVED --- Comment #16 from Katrin Fischer --- AuthorisedValueImages has been removed from the code recently - which makes this bug invalid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing the Database Structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- If one of you could tell that Jonathan's patch works (sign off on it), this would help to get the fix into Koha :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13041] Can't add user as manager of basket if name includes a single quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16386] Replace the use of "onclick" from patron card creator templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15823] Can still access patron discharge slip without having the syspref on - Permissions breach
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #22 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15919] Batch checkout should show due date in list of checked-out items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15919 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16414] aqorders.budgetgroup_id has never been used and can be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16414 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16451] Fix missing body id in orders_by_budget.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #4 from Brendan Gallagher --- Pushed To Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if configuration entry missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher --- Pushed To Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16426] Import borrowers tool warns for blank and/or existing userids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #12 from Brendan Gallagher --- Pushed To Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16426] Import borrowers tool warns for blank and/or existing userids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16426] Import borrowers tool warns for blank and/or existing userids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426 Katrin Fischer changed: What|Removed |Added Attachment #51147|0 |1 is obsolete|| Attachment #51148|0 |1 is obsolete|| Attachment #51274|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 51275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51275&action=edit [PASSED QA] Bug 16426: Add tests for ModMember - do not update userid Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16426] Import borrowers tool warns for blank and/or existing userids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426
--- Comment #11 from Katrin Fischer ---
Created attachment 51276
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51276&action=edit
[PASSED QA] Bug 16426: follow-up of bug 15840 - correctly manage userid while
inserting patrons
Bug 15840 tried to fix a bug but makes things more complicated than it
was before.
If an userid is not provided for 1 or more rows of the csv file, it
should not be updated. However, if a userid is provided and it already
used by an other patron, the import should fail for this row (but not
crash!).
Test plan:
0/ Create a patron with a userid=your_userid
1/ Use the import patron tool to update this userid
=> userid should have been updated
2/ Update another data and do not provide the userid
=> data should have been updated and not the userid
3/ Update another data and provide the userid, but set it to an empty
string, or '0'
=> data should have been updated and not the userid
4/ Update another patron, and set userid=your_userid
=> Update should fail and an error whouls be displayed ("already used by
another patron")
Signed-off-by: Nick Clemens
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16426] Import borrowers tool warns for blank and/or existing userids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426 --- Comment #9 from Katrin Fischer --- Created attachment 51274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51274&action=edit k -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if configuration entry missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453 Jesse Weaver changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if configuration entry missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453 Jesse Weaver changed: What|Removed |Added Attachment #51263|0 |1 is obsolete|| --- Comment #4 from Jesse Weaver --- Created attachment 51273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51273&action=edit Bug 16453: Make Elasticsearch tests be skipped if configuration entry missing The current tests fail to run if the configuration entry is missing. This is problematic on jenkins and should be fixed. To test: - On master, having koha-conf.xml without (or commented) an entry - Run: $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \ t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v => FAIL: Tests fail due to missing configuration entry - Apply the patch - Run: $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \ t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v => SUCCESS: Tests pass, and the ES-configuration-dependent tests are skipped - Have elasticsearch running and the koha-conf.xml entry - Run: $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \ t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v => SUCCESS: Same results as without the patch - Sign off Signed-off-by: Chris Cormack Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15919] Batch checkout should show due date in list of checked-out items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15919 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15919] Batch checkout should show due date in list of checked-out items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15919 Katrin Fischer changed: What|Removed |Added Attachment #51115|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 51272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51272&action=edit [PASSED QA] Bug 15919: Batch checkout - Display the due date When an item has been checked out in a batch, the due date will now be displayed in the information column. Test plan: Use the batch checkout to check some items out Confirm that the due date is displayed if the items have been checked out. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16414] aqorders.budgetgroup_id has never been used and can be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16414 --- Comment #4 from Katrin Fischer --- Created attachment 51271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51271&action=edit Bug 16414: Follow-up - change to kohastructure.sql Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16414] aqorders.budgetgroup_id has never been used and can be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16414 Katrin Fischer changed: What|Removed |Added Attachment #51120|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 51270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51270&action=edit [PASSED QA] Bug 16414: Drop aqorders.budgetgroup_id This column has never been used and can be removed. Test plan: 1/ update the schema 2/ prove t/db_dependent/Acquisition.t should return green Signed-off-by: Bernardo Gonzalez Kriegel Test green pre & post patch No errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16414] aqorders.budgetgroup_id has never been used and can be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16414 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15823] Can still access patron discharge slip without having the syspref on - Permissions breach
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823 --- Comment #21 from Katrin Fischer --- Created attachment 51269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51269&action=edit [PASSED QA] Bug 15823: Redirect opac-discharge.pl to 404 page See comment #17: Redirect to 404 in opac-discharge.pl and remove message in template because with the redirect it will never be reached. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15823] Can still access patron discharge slip without having the syspref on - Permissions breach
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823 Katrin Fischer changed: What|Removed |Added Attachment #51133|0 |1 is obsolete|| Attachment #51229|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 51268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51268&action=edit [PASSED QA] Bug 15823: Can still access patron discharge slip without having the syspref on EDIT: Fix for OPAC side EDIT: Comment 10 EDIT: Merge conflicts To test: 1) Ensure syspref useDischarge is disabled 2) Go to /cgi-bin/koha/members/discharge.pl?borrowernumber=X&discharge=1 3) Validate that you are still able to generate a discharge slip for this patron 4) Apply patch and refresh page 5) Confirm that you are redirected to the circulation.pl page for the user and that an error message is there. OPAC SIDE 6) Go to the OPAC 7) Go to /cgi-bin/koha/opac-discharge.pl 8) Confirm you get a message saying discharges are disabled 9) Go to /cgi-bin/koha/opac-discharge.pl?op=request 10) Confirm you see same message Sponsored-by: Catalyst IT Followed test plan, works as expected (both staff client and OPAC). Re-tested, works OK. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15823] Can still access patron discharge slip without having the syspref on - Permissions breach
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16451] Fix missing body id in orders_by_budget.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451 Katrin Fischer changed: What|Removed |Added Attachment #51242|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 51267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51267&action=edit [PASSED QA] Bug 16451: Fix missisng body id in orders_by_budget.tt Bug 11371 introduced a new template, which fails the xt/tt_valid.t tests. To test: - On master, run: $ prove xt/tt_valid.t => FAIL: Tests fail on orders_by_budget.tt - Apply the patch - Run $ prove xt/tt_valid.t => SUCCESS: Tests don't fail on orders_by_budget.tt - Sign off Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16451] Fix missing body id in orders_by_budget.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13041] Can't add user as manager of basket if name includes a single quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Katrin Fischer changed: What|Removed |Added Attachment #51234|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 51266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51266&action=edit [PASSED QA] Bug 13041 - Can't add user as manager of basket if name includes a single quote If you are trying to add a user as a manager of a basket in acquisitions, a JavaScript error will be triggered if that user has a single quote in their name (e.g. "O'Neil"). This patch corrects the issue by removing the "onclick" attribute and using the JS change made in Bug 16386. Also changed by this patch: Increased the size of the patron search popup and made a correction to some invalid HTML. To test you should have a patron whose name contains a single quote who is also a user with permission to manage acquisitions. - Apply the patch and go to Acquisitions. - Locate an open basket and view the details for that basket. - In the "Managed by" section, click the "Add user" button to trigger the patron search popup. - Search for the patron described above and click the "Add" button. - In the parent window, the patron you chose should have been added to the "Managed by" section. Tested on top of Bug 16383, behaves as expected. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16386] Replace the use of "onclick" from patron card creator templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386 Katrin Fischer changed: What|Removed |Added Attachment #51189|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 51265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51265&action=edit [PASSED QA] Bug 16386 - Replace the use of "onclick" from patron card creator templates This patch removes the use of "onclick" from several patron card creator templates. Events are defined instead in JavaScript. Also changed: - Patron search pop-up window is now slightly larger because I found it never quite large enough to prevent horizontal scrolling. - Replaced "Borrower" with "Patron" in a couple of places. - "Add" link in patron search pop-up is now styled as a Bootstrap button. - Removed Bootstrap styles from some submit buttons. - Some Font Awesome icons were made using the invalid element instead of . These are corrected. - Fixed some other HTML validation errors. To test, apply the patch and go to Tools -> Patron card creator. - Choose New -> Card batch. - Click "Add patrons" and perform a search for patrons in the pop-up window. - Click the "Add" button. The corresponding borrowernumber should be added to the textarea in the parent window, and a message should appear at the top of the pop-up window confirming that the patron has been added. (Note: This patch fixes a version of Bug 13041 which prevented the "add" button from working on patrons whose name include an apostrophe). - In the parent page, in the list of patrons you added to the batch, confirm that clicking the "Delete" link triggers a confirmation dialog. Test both confirming and canceling. - Confirm that clicking the "Export" button next to an individual patron triggers a modal window. - In the export window, confirm that the "Cancel" link works to close the modal. - Click the "Export" button again and then the "Export" button in the modal. - Test that the "Done" button works to close the modal. - Choose Manage -> Card batches. - Test the "Delete" and "Export" buttons as described above. Signed-off-by: Bernardo Gonzalez Kriegel All works, no errors. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13041] Can't add user as manager of basket if name includes a single quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Katrin Fischer changed: What|Removed |Added Attachment #51264|0 |1 is obsolete|| Attachment #51264|0 |1 is patch|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13041] Can't add user as manager of basket if name includes a single quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Katrin Fischer changed: What|Removed |Added Attachment #51234|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16386] Replace the use of "onclick" from patron card creator templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13041] Can't add user as manager of basket if name includes a single quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Attachment #51264|1 |0 is patch|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if configuration entry missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- I have problems testing this because I am missing ES dependencies (old Ubuntu still). Can someone else take a look at this please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13041] Can't add user as manager of basket if name includes a single quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13041] Can't add user as manager of basket if name includes a single quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Katrin Fischer changed: What|Removed |Added Attachment #51234|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 51264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51264&action=edit [PASSED QA] Bug 16386 - Replace the use of "onclick" from patron card creator templates This patch removes the use of "onclick" from several patron card creator templates. Events are defined instead in JavaScript. Also changed: - Patron search pop-up window is now slightly larger because I found it never quite large enough to prevent horizontal scrolling. - Replaced "Borrower" with "Patron" in a couple of places. - "Add" link in patron search pop-up is now styled as a Bootstrap button. - Removed Bootstrap styles from some submit buttons. - Some Font Awesome icons were made using the invalid element instead of . These are corrected. - Fixed some other HTML validation errors. To test, apply the patch and go to Tools -> Patron card creator. - Choose New -> Card batch. - Click "Add patrons" and perform a search for patrons in the pop-up window. - Click the "Add" button. The corresponding borrowernumber should be added to the textarea in the parent window, and a message should appear at the top of the pop-up window confirming that the patron has been added. (Note: This patch fixes a version of Bug 13041 which prevented the "add" button from working on patrons whose name include an apostrophe). - In the parent page, in the list of patrons you added to the batch, confirm that clicking the "Delete" link triggers a confirmation dialog. Test both confirming and canceling. - Confirm that clicking the "Export" button next to an individual patron triggers a modal window. - In the export window, confirm that the "Cancel" link works to close the modal. - Click the "Export" button again and then the "Export" button in the modal. - Test that the "Done" button works to close the modal. - Choose Manage -> Card batches. - Test the "Delete" and "Export" buttons as described above. Signed-off-by: Bernardo Gonzalez Kriegel All works, no errors. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16459] New: Adding patrons to a patron card label batch requires 'routing' permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459 Bug ID: 16459 Summary: Adding patrons to a patron card label batch requires 'routing' permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org When adding patrons to a patron card batch using the search for patrons feature, the required permission is 'routing'... which makes no sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16459] Adding patrons to a patron card label batch requires 'routing' permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if configuration entry missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453 Chris Cormack changed: What|Removed |Added Attachment #51248|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 51263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51263&action=edit Bug 16453: Make Elasticsearch tests be skipped if configuration entry missing The current tests fail to run if the configuration entry is missing. This is problematic on jenkins and should be fixed. To test: - On master, having koha-conf.xml without (or commented) an entry - Run: $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \ t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v => FAIL: Tests fail due to missing configuration entry - Apply the patch - Run: $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \ t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v => SUCCESS: Tests pass, and the ES-configuration-dependent tests are skipped - Have elasticsearch running and the koha-conf.xml entry - Run: $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \ t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v => SUCCESS: Same results as without the patch - Sign off Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if configuration entry missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16447] "Borrow Permission" should not be used anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher --- Pushed to master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16448] Perlcritic errors introduced by 12478
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16447] "Borrow Permission" should not be used anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Katrin Fischer changed: What|Removed |Added Attachment #51253|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 51262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51262&action=edit [PASSED QA] Bug 16447: Remove occurrence of the borrow permission which does no longer exist Bug 7976 has removed this permission, but other patches re-added it... Note that the occurrences in sendbasket.pl, edithelp.pl, opac/svc/login should have been removed by bug 7976. Test plan: git grep 'borrow.*=> 1' should not return any results. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16447] "Borrow Permission" should not be used anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16448] Perlcritic errors introduced by 12478
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448 Katrin Fischer changed: What|Removed |Added Attachment #51254|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 51261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51261&action=edit [PASSED QA] Bug 16448: Fix perlcritic errors introduced by 12478 Bug 12478 introduced two perlcritic errors. This patch fixes them. To test: - On master, run: $ prove t/00-testcritic.t => FAIL: catalogue/search.pl and Koha/Authority.pm fail the critic tests. - Apply the patch - Run: $ prove t/00-testcritic.t => SUCCESS: All happy - Sign off :-D Signed-off-by: Hector Castro All test successful. Needs $ export TEST_QA=1 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16448] Perlcritic errors introduced by 12478
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing the Database Structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402 Richard Gardner changed: What|Removed |Added CC||rtgardne...@gmail.com --- Comment #4 from Richard Gardner --- Hey there, Was having this same problem. Just wanted to give you all a shout-out for the fix. Was having trouble locating the file but eventually got it all worked out. Still ended up getting:: mysql: [Warning] Using a password on the command line interface can be insecure. but I found a workaround for that and now i've created and access the staff interface via command line. I am still having some trouble connecting via web-browser, but I suspect it's because I just set my nameservers up earlier today and they haven't had time to propagate. I hope that is the "problem" at least. Otherwise I may need to figure out my host files, .conf files, or the proper settings for my server's DNS manager. Anyway, thanks again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16325] Suggestions: Tab "Status unknown" contains all suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16452] PatronLists.t raises a warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16452 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16325] Suggestions: Tab "Status unknown" contains all suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 Katrin Fischer changed: What|Removed |Added Attachment #51159|0 |1 is obsolete|| Attachment #51160|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 51259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51259&action=edit [PASSED QA] Bug 16325: Add a test for SearchSuggestions when searching for STATUS='' Test fails as expected without second patch and passes OK with second patch. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16325] Suggestions: Tab "Status unknown" contains all suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 --- Comment #6 from Katrin Fischer --- Created attachment 51260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51260&action=edit [PASSED QA] Bug 16325: Do not return all suggestions if search for STATUS='' This is a quick and dirty way to fix a bad bug in a messy area. The "unknown status" tab in the suggestions table display all the suggestions. It should only display suggestions with a STATUS='' Test plan: - Create some suggestions - Go to Home > Acquisitions > Suggestions management - Edit some suggestions and give them different status, e.g. accepted, rejected, pending. - Verify that they appear in the tabs as appropriate - Edit one suggestion, set "Mark selected as" to --Choose a status-- => Without this patch: New tab "Status unknown" containing all suggestions => With this patch: tab contains only suggestions with "Unknown status" Works as expected. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16325] Suggestions: Tab "Status unknown" contains all suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #51249|0 |1 is obsolete|| --- Comment #4 from Héctor Eduardo Castro Avalos --- Created attachment 51258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51258&action=edit Bug 16456: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation Add Font Awesome Icons to section Patrons and circulation in Tools module (Save, Upload, Filter, Import) To test goto: -Patron lists -> New patron List -> Save -Patron list -> my_list_saved -> Add patrons -> Remove selected patrons, Clear all, Select all -Comments -> Approve, delete and, unapprove -Import patrons -> Import -Overdue notice/status triggers -> Save changes -Batch patron modification -> Save, Select all and Clear all -Upload patron images -> Upload -Tags -> Apply filter(s), Test, Approved, Reject, Select all, Clear all, Select all pending. Set TagsModeration to Require. -Verify that all tools work as expected NOTE: The Tag and Comments tools has been revised to fit with others interfaces in Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 --- Comment #17 from Danielle Elder --- Status is signed off. Do you mean in giz bz? (I am a novice here, so let me know). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16452] PatronLists.t raises a warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16452 Katrin Fischer changed: What|Removed |Added Attachment #51245|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 51257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51257&action=edit [PASSED QA] Bug 16452: Remove the warnings raised by PatronLists.t We need to define a userenv to get rid of the warnings Test plan: prove t/db_dependent/PatronLists.t should not return any warnings Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16452] PatronLists.t raises a warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16452 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16439] Allow styling to button for upload local cover images (Font Awesome Icons)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - should be in the May 2016 Release. thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16445] Bug 12478 has added an unnecessary line to Koha/Database.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - should be in the May 2016 Release. thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #15 from Brendan Gallagher --- Pushed to Master - should be in the May 2016 Release. thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16439] Allow styling to button for upload local cover images (Font Awesome Icons)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439 Katrin Fischer changed: What|Removed |Added Attachment #51236|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 51256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51256&action=edit [PASSED QA] Bug 16439: Allow styling to button for upload local cover images (Font Awesome Icons) Improve button for upload local cover image with Font Awesome Icon To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Notice about the button upload. -Apply the patch and reload the page. -The button is changed for class=btn btn-mini like the button "edit" used in items in the tab Holdings -Also added the Font Awesome icon upload "fa fa-upload" class. Button is styled as expected. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16439] Allow styling to button for upload local cover images (Font Awesome Icons)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16445] Bug 12478 has added an unnecessary line to Koha/Database.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16445] Bug 12478 has added an unnecessary line to Koha/Database.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445 Katrin Fischer changed: What|Removed |Added Attachment #51227|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 51255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51255&action=edit [PASSED QA] Bug 16445: Revert changes made by bug 12478 to Koha/Database.pm These changes were a mistake, let's revert them. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #16 from Héctor Eduardo Castro Avalos --- Hi Danielle, you forgot to change the bug status -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14005] Fix wording of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14005 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16159] guarantor section missing ID on patron add form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #8 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron entry form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16448] Perlcritic errors introduced by 12478
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #51237|0 |1 is obsolete|| --- Comment #2 from Héctor Eduardo Castro Avalos --- Created attachment 51254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51254&action=edit [SIGNED-OFF]Bug 16448: Fix perlcritic errors introduced by 12478 Bug 12478 introduced two perlcritic errors. This patch fixes them. To test: - On master, run: $ prove t/00-testcritic.t => FAIL: catalogue/search.pl and Koha/Authority.pm fail the critic tests. - Apply the patch - Run: $ prove t/00-testcritic.t => SUCCESS: All happy - Sign off :-D Signed-off-by: Hector Castro All test successful. Needs $ export TEST_QA=1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16448] Perlcritic errors introduced by 12478
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||hector.hecax...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16447] "Borrow Permission" should not be used anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Marc Véron changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16447] "Borrow Permission" should not be used anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Marc Véron changed: What|Removed |Added Attachment #51246|0 |1 is obsolete|| --- Comment #5 from Marc Véron --- Created attachment 51253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51253&action=edit Bug 16447: Remove occurrence of the borrow permission which does no longer exist Bug 7976 has removed this permission, but other patches re-added it... Note that the occurrences in sendbasket.pl, edithelp.pl, opac/svc/login should have been removed by bug 7976. Test plan: git grep 'borrow.*=> 1' should not return any results. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16458] Setting to guarantor: JavaScript error form.branchcode is undefined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458 Marc Véron changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16450 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor search template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16458 Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor search template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450 Marc Véron changed: What|Removed |Added Attachment #51241|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 51252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51252&action=edit Bug 16450 - Remove the use of "onclick" from guarantor search template This patch updates the guarantor search template so that event definition is done in the script rather than in an onclick attribute. This patch also increases the size of the popup window to help prevent the need for horizontal scrolling and adds Bootstrap style to the "select" button. To test, apply the patch and clear your browser cache if necessary. - Go to Patrons and add a patron with a "child" category type. - In the "Guarantor information" section, click the "Set to patron" button. - In the pop-up window, search for a patron. - Click the "Select" button next to a patron. - The window should close, and the patron you selected should now appear as the guarantor. The guarantor's address information should be added to the "Main address" section. Tested on top of Bug 13041 and Bug 16386, works as expected, however see Bug 16458 Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16458] New: Setting to guarantor: JavaScript error form.branchcode is undefined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458 Bug ID: 16458 Summary: Setting to guarantor: JavaScript error form.branchcode is undefined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: ve...@veron.ch QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com To reproduce: - Go to a child parton's detail page - Edit it using the toolbar item "Edit" - Edit "Guarantor information", "Set to patron" or "Change patron" - Select a patron =>Result OK (patron search window closes, guarantor information is set, e.g. Library changes to Guarantor's library if it is different) - Go back to child patron's detail page - This time do not use toolbar "Edit" but the "Edit" link below "Date of birth" / "Guarantor" - Edit "Guarantor information", "Set to patron" or "Change patron" - Select a patron =>Result NOT OK (patron search window does not close, JavaScript console says: TypeError: form.branchcode is undefined (...)/intranet-tmpl/prog/js/members.js Line: 213 Some of the Guarantor's information is not set, e.g. library if it is different. I found this while testing Bug 16450, this error appears without and with 16450 applied. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Héctor Eduardo Castro Avalos changed: What|Removed |Added Assignee|oleon...@myacpl.org |hector.hecax...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if configuration entry missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|gmcha...@gmail.com |jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor search template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450 Owen Leonard changed: What|Removed |Added Blocks||16457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457 [Bug 16457] Remove the use of "onclick" from the patron entry form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16386] Replace the use of "onclick" from patron card creator templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386 Owen Leonard changed: What|Removed |Added Blocks||16457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457 [Bug 16457] Remove the use of "onclick" from the patron entry form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16457] New: Remove the use of "onclick" from the patron entry form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457 Bug ID: 16457 Summary: Remove the use of "onclick" from the patron entry form Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/memberentry.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 13041, 16386, 16450 There are several instances of "onclick" in memberentrygen.tt. It should be rewritten so that JS functionality can be separate from the markup. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 [Bug 13041] Can't add user as manager of basket if name includes a single quote https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386 [Bug 16386] Replace the use of "onclick" from patron card creator templates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450 [Bug 16450] Remove the use of "onclick" from guarantor search template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13041] Can't add user as manager of basket if name includes a single quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Owen Leonard changed: What|Removed |Added Blocks||16457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457 [Bug 16457] Remove the use of "onclick" from the patron entry form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16451] Fix missing body id in orders_by_budget.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451 Marc Véron changed: What|Removed |Added Summary|Fix missisng body id in |Fix missing body id in |orders_by_budget.tt |orders_by_budget.tt CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16415] Layout problem on staff client detail page if local cover images are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in 'Saved reports' page with language bottom bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #15 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16315] OPAC Shelfbrowser doesn't display the full title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16315 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16411] Make Hold.t not depend on two existing branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16411 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #3 from Héctor Eduardo Castro Avalos --- Created attachment 51251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51251&action=edit New look for tags tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #2 from Héctor Eduardo Castro Avalos --- Created attachment 51250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51250&action=edit New look for comments tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #1 from Héctor Eduardo Castro Avalos --- Created attachment 51249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51249&action=edit Bug 16456: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation Add Font Awesome Icons to section Patrons and circulation in Tools module (Save, Upload, Filter, Import) To test goto: -Patron lists -> New patron List -> Save -Patron list -> my_list_saved -> Add patrons -> Remove selected patrons, Clear all, Select all -Comments -> Approve, delete and, unapprove -Import patrons -> Import -Overdue notice/status triggers -> Save changes -Batch patron modification -> Save, Select all and Clear all -Upload patron images -> Upload -Tags -> Apply filter(s), Test, Approved, Reject, Select all, Clear all, Select all pending. Set TagsModeration to Require. -Verify that all tools work as expected NOTE: The Tag and Comments tools has been revised to fit with others interfaces in Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16439] Allow styling to button for upload local cover images (Font Awesome Icons)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439 Héctor Eduardo Castro Avalos changed: What|Removed |Added Blocks||16456 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16456] New: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Bug ID: 16456 Summary: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: hector.hecax...@gmail.com QA Contact: testo...@bugs.koha-community.org Depends on: 16438, 16439 Add Font Awesome Icons to section Patrons and circulation in Tools module (Save, Upload, Filter, Import) Also the Tag and Comments tools has been revised to fit with others interfaces in Koha. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 [Bug 16438] Use Font Awesome icons in batch templates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439 [Bug 16439] Allow styling to button for upload local cover images (Font Awesome Icons) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Héctor Eduardo Castro Avalos changed: What|Removed |Added Blocks||16456 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if configuration entry missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453 Tomás Cohen Arazi changed: What|Removed |Added Summary|Elasticsearch tests should |Elasticsearch tests should |use koha-conf.xml |be skipped if configuration |information and skip if |entry missing |absent | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16453] Elasticsearch tests should use koha-conf.xml information and skip if absent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16453] Elasticsearch tests should use koha-conf.xml information and skip if absent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 51248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51248&action=edit Bug 16453: Make Elasticsearch tests be skipped if configuration entry missing The current tests fail to run if the configuration entry is missing. This is problematic on jenkins and should be fixed. To test: - On master, having koha-conf.xml without (or commented) an entry - Run: $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \ t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v => FAIL: Tests fail due to missing configuration entry - Apply the patch - Run: $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \ t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v => SUCCESS: Tests pass, and the ES-configuration-dependent tests are skipped - Have elasticsearch running and the koha-conf.xml entry - Run: $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \ t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v => SUCCESS: Same results as without the patch - Sign off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16453] Elasticsearch tests should use koha-conf.xml information and skip if absent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
