[Koha-bugs] [Bug 16595] New: Concurrent search between ISBN-10 and ISBN-13 in staff client and OPAC

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16595

Bug ID: 16595
   Summary: Concurrent search between ISBN-10 and ISBN-13 in staff
client and OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: imingc...@yahoo.com.au
QA Contact: testo...@bugs.koha-community.org

Ability to concurrent search between ISBN-10 and ISBN-13.  This will eliminate
the need to conduct separate searches between ISBN-10 and ISBN-13.

When a catalogue record only has ISBN-10, it can be found using an ISBN-13
search.  On the other hand, a catalogue record only has ISBN-13 can be found
using an ISBN-10 search.

For example: ISBN 174336704X stored in the catalogue record can be found by
using ISBN search of 9781743367049, or vice versa.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16589] Quote of the day: Can not upload csv file

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589

--- Comment #2 from Marc VĂ©ron  ---
(In reply to Owen Leonard from comment #1)
> I've tried my own CSV file and those on Bug 15684 and I get no errors.

I think the issue is related to the fact that on my computer .csv files are
associated with LibreOffice (Calc): application/vnd.sun.xml.calc

See koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt line 241:

if (!fileType.match(/comma-separated-values|csv|excel/i)) {
alert(_("Uploads limited to csv. Incorrect filetype:
%s").format(fileType));

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

--- Comment #11 from Jonathan Druart  
---
(In reply to David Cook from comment #9)
> Using a floating zone allows us to use the same day, month, year
> for comparison purposes without running into the possibility of
> creating an invalid local time and thus a fatal software error.

Ok you will remove the software error, but I am not sure it's the way to go.

Currently the dates are stored in local time (so with the tz), if we want to
switch to floating time zones (what we should do at some point!) I think we
should recalculate all dates present in DB.
An easy workaround would be to use Koha::DateUtils, which deals (at least try
to) with invalid dates due du DST.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

Jonathan Druart  changed:

   What|Removed |Added

Version|3.20|unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

--- Comment #12 from Jonathan Druart  
---
Moreover `grep time_zone Koha/Calendar.pm` will return another occurrence where
the fix should be applied too.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16569] Message box for "too many checked out" is empty if AllowTooManyOverride is not enabled

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569

Nicolas Legrand  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16336] UX of holds patron search with long lists of results

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16596

--- Comment #7 from Jonathan Druart  
---
(In reply to Owen Leonard from comment #6)
> (In reply to Jonathan Druart from comment #5)
> 
> > I am wondering why branchcode and categorycode are displayed, instead of
> > their description, on these 2 tables. Any valid reasons?
> 
> It is probably simply a remnant of the old version which displayed the list
> in a  and required a more compact display.

A patch is going to be submitted on bug 16336.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596
[Bug 16596] branchcode and categorycode are displayed instead of their
description on patron search result
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16569] Message box for "too many checked out" is empty if AllowTooManyOverride is not enabled

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #51720|0   |1
is obsolete||

--- Comment #2 from Nicolas Legrand  ---
Created attachment 51816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51816&action=edit
Bug 16569 - Message box for "too many checked out" is empty if
AllowTooManyOverride is not enabled

If the limit for number of items checked out is reached, the message box
shows up but is empty.

Test Plan:
1) Disable AllowTooManyOverride
2) Check out items to a patron until the patron has reached the limit
   of checkouts he or she can have
3) Try to check out one more item
4) Note the empty message box
5) Apply this patch
6) Try to check out one more item again
7) Note the message is now visible

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16596] branchcode and categorycode are displayed instead of their description on patron search result

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||16336


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336
[Bug 16336] UX of holds patron search with long lists of results
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16596] New: branchcode and categorycode are displayed instead of their description on patron search result

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596

Bug ID: 16596
   Summary: branchcode and categorycode are displayed instead of
their description on patron search result
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16596] branchcode and categorycode are displayed instead of their description on patron search result

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596

--- Comment #1 from Jonathan Druart  
---
Created attachment 51817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51817&action=edit
Bug 16596: Display library and patron category descriptions instead of their
code

Test plan:
On circ/circulation-home.pl and reserve/request.pl, search for patrons
The descriptions for the libraries and patron categories should be
displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16596] branchcode and categorycode are displayed instead of their description on patron search result

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16569] Message box for "too many checked out" is empty if AllowTooManyOverride is not enabled

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16569] Message box for "too many checked out" is empty if AllowTooManyOverride is not enabled

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #51816|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 51821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51821&action=edit
Bug 16569 - Message box for "too many checked out" is empty if
AllowTooManyOverride is not enabled

If the limit for number of items checked out is reached, the message box
shows up but is empty.

Test Plan:
1) Disable AllowTooManyOverride
2) Check out items to a patron until the patron has reached the limit
   of checkouts he or she can have
3) Try to check out one more item
4) Note the empty message box
5) Apply this patch
6) Try to check out one more item again
7) Note the message is now visible

Signed-off-by: Nicolas Legrand 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16564] New Patron Category cannot be created. Bounces with error: 'The Category might already exist'.

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16564

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
Cannot recreate on master and 3.22.06 (I do not have MySql 5.7)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11430] Search history: Delete selected lines

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16593

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export Data screen

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

Owen Leonard  changed:

   What|Removed |Added

  Attachment #51651|0   |1
is obsolete||

--- Comment #8 from Owen Leonard  ---
Created attachment 51829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51829&action=edit
Bug 16548 - All libraries selected on Tools -> Export Data screen

This patch adds "select all" and "select none" links to the display of
libraries in the export bibliographic records form.

Also modified: call number range and accession date fields have been
grouped in their own fieldsets in the hopes that this is more readable.
Page title and breadcrumbs have been corrected to read "Export data"
instead of "MARC export," matching menu items.

To test, apply the patch and go to Tools -> Export data.

- Test the select all/select none links and confirm that they work as
  expected.
- Confirm that the structural changes to the form look okay.

Signed-off-by: Nick Clemens 

Post sign-off revision: Use the standard "Clear all" instead of "Select
none."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export Data screen

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #51829|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart  
---
Created attachment 51830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51830&action=edit
Bug 16548 - All libraries selected on Tools -> Export Data screen

This patch adds "select all" and "select none" links to the display of
libraries in the export bibliographic records form.

Also modified: call number range and accession date fields have been
grouped in their own fieldsets in the hopes that this is more readable.
Page title and breadcrumbs have been corrected to read "Export data"
instead of "MARC export," matching menu items.

To test, apply the patch and go to Tools -> Export data.

- Test the select all/select none links and confirm that they work as
  expected.
- Confirm that the structural changes to the form look okay.

Signed-off-by: Nick Clemens 

Post sign-off revision: Use the standard "Clear all" instead of "Select
none."

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export Data screen

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #49085|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #49084|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #49086|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16590] error log recording

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16590

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |INVALID
   Severity|critical|normal
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |RESOLVED

--- Comment #1 from Jonathan Druart  
---
Maria, this error is raised when the Zebra index is not up-to-date, try to
reindex your records.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #12 from Marcel de Rooy  ---
Created attachment 51832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51832&action=edit
Koha Plugin: Rijks_HoldNoteRequired_Extent and _Leader

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #14 from Marcel de Rooy  ---
Created attachment 51834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51834&action=edit
Bug 15545: Use IsHoldNoteRequired in opac-reserve.pl

This patch implements use of the new Reserves routine IsHoldNoteRequired,
making it possible to require a note when placing a hold.
Only a very small change in opac-reserve.pl is needed. As well as
corresponding changes in the template. I am removing some unused template
code related to a former approach.

Test plan:
[1] Disable UseKohaPlugins, enable OpacHoldNotes.
[2] Place a hold on a serial record (leader pos 7 == s). Verify that
the hold note is not required.
[3] Enable UseKohaPlugins. Install the Rijks_HoldNoteRequired plugins.
(Go to plugins/plugins-home.pl and upload Rijks_HoldNoteRequired.kpz.
This file can be found as an attachment to this BZ report.)
[4] Again place a hold on a serial record. The hold note should be required.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #13 from Marcel de Rooy  ---
Created attachment 51833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51833&action=edit
Bug 15545: Add routine IsHoldNoteRequired to Reserves module

This routine will be used to determine if a hold note is required.
In the current approach this is implemented by use of Koha plugins.
A former approach included a syspref. This is no longer needed. This
approach is even more flexible.

The routine will use all plugins it finds with metadata tag
'implements' set to 'IsHoldNoteRequired'. If one of these plugins has a
check method that returns true, the hold note should be regarded as
required.

The plugins Rijks_HoldNoteRequired_Extent and _Leader offer an
implementation where the value of the leader or MARC21 300$a determines
if the hold note is required. Similarly, any other field of the
bibliographic record could be used in a new plugin.

Test plan:
Run unit test t/db_dependent/Reserves/IsHoldNoteRequired.t.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold (via Koha::Plugin)

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Optionally require notes|Optionally make hold notes
   |when placing a hold |required when placing a
   ||hold (via Koha::Plugin)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold (via Koha::Plugin)

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16592] Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16585] Update Italian installer sample files for 16.05

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

--- Comment #2 from Zeno Tajoli  ---
Created attachment 51836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51836&action=edit
Update Italian installer sample files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16585] Update Italian installer sample files for 16.05

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

Zeno Tajoli  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16585] Update Italian installer sample files for 16.05

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

Zeno Tajoli  changed:

   What|Removed |Added

  Text to go in the|With this patch all |With this patch all
  release notes|sample/defintions .sql  |sample/defintions .sql
   |files are translated into   |files are translated into
   |Italina (if you select  |Italian (if you select
   |italian during web  |italian during web
   |installation).  |installation).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16592] Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592

--- Comment #1 from Owen Leonard  ---
Created attachment 51835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51835&action=edit
Bug 16592 - Use Bootstrap modal for MARC and Card preview on acquisitions
receipt summary page

This patch replaces Greybox modals on the acquisitions receipt summary
page with Bootstrap modals.

To test, apply the patch and go to Acquisitions -> Invoices -> View an
invoice ->  Go to receipt page.

- In the list of pending orders, test the "MARC" and "Card" links for
  various titles. Each should trigger a Bootstrap modal with the correct
  content.
- Repeat the same tests in the list of already received orders.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16585] Update Italian installer sample files for 16.05

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

--- Comment #3 from Zeno Tajoli  ---
Created attachment 51837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51837&action=edit
Followup of the patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16600] New: Remove some obsolete references to Greybox in some templates

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600

Bug ID: 16600
   Summary: Remove some obsolete references to Greybox in some
templates
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

In identifying what templates still use Greybox for Bug 8290 I found two
templates which contain obsolete references to Greybox code:

authorities/merge.tt
cataloguing/z3950_auth_search.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16601] New: Update MARC21 it-IT frameworks to Update 22 (April 2016)

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

Bug ID: 16601
   Summary: Update MARC21 it-IT frameworks to Update 22 (April
2016)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: z.taj...@cineca.it
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

The updte of marc21 .sql files based on
http://translate.koha-community.org/files/it/mandatory/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16601] Update MARC21 it-IT frameworks to Update 22 (April 2016)

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

Zeno Tajoli  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Patch complexity|--- |Small patch
   Assignee|koha-b...@lists.koha-commun |z.taj...@cineca.it
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16601] Update MARC21 it-IT frameworks to Update 22 (April 2016)

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

Zeno Tajoli  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16601] Update MARC21 it-IT frameworks to Update 22 (April 2016)

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

--- Comment #2 from Zeno Tajoli  ---
To test:
1) Start with a fresh database
2) Check mandatory bibliographic and authority files
   load without problem using the German web installer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16600] Remove some obsolete references to Greybox in some templates

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290

Owen Leonard  changed:

   What|Removed |Added

 Depends on||16600


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600
[Bug 16600] Remove some obsolete references to Greybox in some templates
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16600] Remove some obsolete references to Greybox in some templates

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600

--- Comment #1 from Owen Leonard  ---
Created attachment 51839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51839&action=edit
Bug 16600 - Remove some obsolete references to Greybox in some templates

This patch removes unused Greybox markup from two templates.

To test, apply the patch and go to Authorities.

- Perform an authority search which will return multiple results.
- Select two records to merge.
- On the "merging records" page, an earlier version used Greybox to show
  a preview of the selected authority records. Confirm that authority
  number link for the two records triggers a pop-up window instead.

- From the authorities home page, choose 'New from Z39.50'
- Perform a search which will return multiple results.
- Confirm that there is only a 'MARC' preview link. A
  forever-commented-out 'Card' link has been removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16600] Remove some obsolete references to Greybox in some templates

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600

Owen Leonard  changed:

   What|Removed |Added

 Blocks||8290


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290
[Bug 8290] Replace usage of Greybox modals with Bootstrap modals
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16601] Update MARC21 it-IT frameworks to Update 22 (April 2016)

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

Zeno Tajoli  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16601] Update MARC21 it-IT frameworks to Update 22 (April 2016)

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

--- Comment #1 from Zeno Tajoli  ---
Created attachment 51838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51838&action=edit
Update Italian MARC21

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290

--- Comment #3 from Owen Leonard  ---
The simplest Greybox uses have been taken care of. The remaining cases will all
require more complex AJAX handling because of the kind of in-modal operations
used:

Localization:

admin/itemtypes.tt
admin/localization.tt

Label and card export:

labels/label-edit-batch.tt
labels/label-manage.tt
patron_lists/lists.tt
patroncards/edit-batch.tt
patroncards/manage.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #12 from Jonathan Druart  
---
Created attachment 51840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51840&action=edit
Bug 16554: DO NOT PUSH - test for all sample files

You will need to create a koha_test_installer DB before

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #13 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #12)
> Created attachment 51840 [details] [review]
> Bug 16554: DO NOT PUSH - test for all sample files
> 
> You will need to create a koha_test_installer DB before

I did not finish the execution of this script but it should permit to test all
sample files without inserting it manually.
Could someone test it on MySQL 5.7 and all patches from this bug report (and
from bug 16573 as well).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16602] New: Remove the use of "onclick" from several templates

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602

Bug ID: 16602
   Summary: Remove the use of "onclick" from several templates
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

I am working on a patch which will remove the use of "onclick" from the
following templates:

offline_circ/process_koc.tt
patron_lists/lists.tt
tools/batchMod-edit.tt
tools/batchMod-del.tt
tools/holidays.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #14 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #13)
> Could someone test it on MySQL 5.7 and all patches from this bug report (and
> from bug 16573 as well).

And make sure it raises warnings/errors without!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css and other issues

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

HĂ©ctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css and other issues

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

--- Comment #1 from HĂ©ctor Eduardo Castro Avalos  ---
Created attachment 51841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51841&action=edit
Bug 16594: Orders by fund report has wrong link to css and other issues

Orders by fund has wrong link to css and other issues
-> The example in the wiki is wrong:


  [% INCLUDE 'datatables.inc' %]
-> Must be:

-> Missing  in  tag
-> Wrong word used "Date deceived" should be "Date received"

NOTE: Wiki needs to be updated

To test:
-Look the code and notice about if else cluase without curly brackets
-Go to Reports > Orders by fund
-Play with: in filters 'All fund' Output: 'to screen into the browser'
-You will see a DataTable displayed in screen clutter
-Notice about 'Date deceived' and the foot of table
-Apply patch
-Refresh or execute again the report

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css and other issues

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

HĂ©ctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||oleon...@myacpl.org,
   ||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10459] borrowers should have a timestamp

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

Joy Nelson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10459] borrowers should have a timestamp

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

Joy Nelson  changed:

   What|Removed |Added

  Attachment #51809|0   |1
is obsolete||

--- Comment #46 from Joy Nelson  ---
Created attachment 51843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51843&action=edit
Bug 10459: Follow up to update to atomic update methodology

Signed-off-by: Bernardo Gonzalez Kriegel 
New column created, no errors.

Signed-off-by: Mark Tompsett 

Signed-off-by: Joy Nelson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10459] borrowers should have a timestamp

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

Joy Nelson  changed:

   What|Removed |Added

  Attachment #51810|0   |1
is obsolete||

--- Comment #47 from Joy Nelson  ---
Created attachment 51844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51844&action=edit
Bug 10459 renamed timestamp to updated_on

Signed-off-by: Joy Nelson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10459] borrowers should have a timestamp

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

Joy Nelson  changed:

   What|Removed |Added

  Attachment #51808|0   |1
is obsolete||

--- Comment #45 from Joy Nelson  ---
Created attachment 51842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51842&action=edit
Bug 10459: Borrowers should have a timestamp

This patch adds a timestamp column to the borrowers table in kohastructure
and updatedatabase. (And also to the deletedborrowers table.)
A timestamp may be useful in synchronizing with external systems (among other
reasons).

Test plan:
Run updatestructure on an existing database, or install a new one.
Verify that the borrowers table has a timestamp now.

Signed-off-by: Marcel de Rooy 
Tested updatestructure and running kohastructure.sql.
Passed t/db_dependent/Members.t.

updatedatabase.pl did not apply. I edited and then run it. Columns were added
as expected.
Signed-off-by: Marc Veron 

Signed-off-by: Bernardo Gonzalez Kriegel 

Signed-off-by: Mark Tompsett 

Signed-off-by: Joy Nelson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10459] borrowers should have a timestamp

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #48 from Joy Nelson  ---
Signed off!  Thanks!!!
joy

(In reply to M. Tompsett from comment #44)
> Okay, Joy, go sign off crazy. ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16603] New: When processing uploaded offline circulation file, "apply directly" option fails

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603

Bug ID: 16603
   Summary: When processing uploaded offline circulation file,
"apply directly" option fails
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/offline_circ/process_koc.pl
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

I have an offline circulation file which was generated by the Windows offline
circulation program. If I upload this file and choose "Add to offline
circulation queue" it works as expected.

If I upload the same file and choose "Apply directly," the process never
completes. Firebug shows a seemingly never-ending series of calls to
/cgi-bin/koha/tools/background-job-progress.pl?jobID=8c20822320e5fbd7579aa1f61411ba00
but nothing happens.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16602] Remove the use of "onclick" from several templates

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602

--- Comment #1 from Owen Leonard  ---
Created attachment 51845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51845&action=edit
Bug 16602 - Remove the use of "onclick" from several templates

This patch removes the use of "onclick" from several templates, instead
defining click events in JavaScript.

Also changed: Some markup corrections.

To test, apply the patch and:

- Go to Circulation -> Upload offline circulation file
  - Browse for an offline circulation file.
  - Clicking the 'Upload file' button should work correctly.
- After uploading a file, both the 'Add to offline circulation
  queue' and 'Apply directly' buttons should work to trigger their
  corresponding processes (keeping Bug 16603 in mind).

- Go to Patrons -> Patron lists.
  - For any patron list containing patrons, click the 'Print patron
cards' menu item. This should trigger a modal window which exports
the correct list.

- Go to Tools -> Batch item modification.
  - Submit a batch of items for modification.
  - Clicking the 'Save' button should trigger the background job and the
items should be successfully modified.

- Go to Tools -> Batch item deletion.
  - Submit a batch of items for deletion.
  - Clicking the 'Delete' button should trigger the background job and
the items should be successfully deleted.

- Go to Tools -> Calendar.
  - Trigger the 'Add new holiday' panel by clicking a day on the
calendar which has no holiday defined.
  - Clicking the 'Cancel' link should hide the panel.
  - Trigger the 'Edit this holiday' panel by clicking a day which has a
holiday defined.
  - Clicking the 'Cancel' link should hide the panel.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16602] Remove the use of "onclick" from several templates

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css and other issues

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

--- Comment #2 from Owen Leonard  ---
(In reply to HĂ©ctor Eduardo Castro Avalos from comment #1)

> NOTE: Wiki needs to be updated

I have updated the wiki.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16555] Managing patron self edits -- non superlibrarians can see patrons for other branches

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16555

Christopher Brannon  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||cbran...@cdalibrary.org
 Resolution|--- |FIXED

--- Comment #2 from Christopher Brannon  ---
I have confirmed that this setting was the culprit.  I believe Barton submitted
this ticket on our behalf.  We did not know about the setting.  I am going to
go ahead and mark this as resolved.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16604] New: Break down patron modification requests for approval/give reasons for denials/allow corrections

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16604

Bug ID: 16604
   Summary: Break down patron modification requests for
approval/give reasons for denials/allow corrections
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

It would be helpful to have the ability to select what changes to approve, and
give reasons for denial that would show up somewhere on the patron account or
in an e-mail to the patron.  It would also be helpful if the changes were
editable if mistakes are found (misspellings, no caps, hyphenations, etc.)

I would imagine check boxes next to each line of change, and a text box next to
each line for "Reason".  The reason "could" be saved for both approvals and
denials.  However, if a reason is given, it would be appropriate to send the
reason to the patron.  Perhaps the information is incorrect.  The patron should
be notified.  The changes should also be editable.  I would imagine an edit
button next to the change, which would simply change the text from a label to a
text box, with a save and cancel button.  I don't think it would be good to
have it always editable without a button or link, in case someone accidently
changes something.

Whether or not staff provide reasons, the approval or denial should be shown to
the patron either in their account, or in an e-mail, if they have one, and show
any modifications (i.e. Approved or denied, what was on the account before,
what the patron requested, what it was actually changed to, reasons if they
exist.)

Christopher

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16605] New: All notices should give the ability to unsubscribe or flag account

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16605

Bug ID: 16605
   Summary: All notices should give the ability to unsubscribe or
flag account
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

There should be a way to unsubscribe to notifications within the e-mail.  This
could be a link to the patron's notification settings, or simply turn the
switch off for that notification.

There should also be a way to indicate that the e-mail has gone to the wrong
person.  A link that says "Not my account", or something to that effect.  It
could either put a restriction on the account indicating the e-mail address has
been flagged as wrong, or just be a note on the account that it is wrong.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10459] borrowers should have a timestamp

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #49 from M. Tompsett  ---
I went with an updated_on, as created_on is static, and the point was for
diagnosis to know when something was last done with the borrower record. And I
couldn't figure out how to get two time stamps using MySQL to auto-fill (a
created_on and an updated_on) in the same table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16606] New: Checkout settings dropdown should have a preference to stay open all the time

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16606

Bug ID: 16606
   Summary: Checkout settings dropdown should have a preference to
stay open all the time
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Not everyone is concerned with the additional space taken up with the new
Checkout settings.  It would be helpful if these options could be set to always
show.

For now I will use a jQuery to force it open, but a preference would be
preferable.  No pun intended.

Christopher

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15676] Actions in pending offline circulation actions are not translatable

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15676

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15676] Actions in pending offline circulation actions are not translatable

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15676

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15676] Actions in pending offline circulation actions are not translatable

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15676

--- Comment #1 from Owen Leonard  ---
Created attachment 51846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51846&action=edit
Bug 15676 - Actions in pending offline circulation actions are not translatable

This patch modifies the offline circulation transaction processing page
so that English strings describing actions are processed in the template
rather than being output directly from the script.

To test, apply the patch and create an offline circulation file
containing at least one checkout, one check-in, and one payment.

- Upload the file and choose 'Add to offline circulation queue.'
- View pending offline circulation actions
- In the list of pending actions, the actions column should show "Check
  out" instead of "issue," "Check in" instead of "return," and "Payment"
  instead of "payment."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12509] Untranslatable "Restriction added by overdues process"

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509

--- Comment #1 from Owen Leonard  ---
Would it be correct to say that the problem is not necessarily the comment in
the database but the output of that comment in the interface?

That is, the goal should be to put a check in the templates which would display
a translatable string?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11375] Patron permission names are untranslatable

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375

--- Comment #5 from Owen Leonard  ---
Created attachment 51847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51847&action=edit
Idea for a patron permissions interface redesign

I wonder if we should deemphasize the permission code? As a developer I look
for the code because I usually know what I'm looking for. Perhaps it would be
friendlier to put the focus on the translatable text?

(also I want to get rid of jstree)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16596] branchcode and categorycode are displayed instead of their description on patron search result

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16596] branchcode and categorycode are displayed instead of their description on patron search result

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #51817|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 51848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51848&action=edit
[SIGNED-OFF] Bug 16596: Display library and patron category descriptions
instead of their code

Test plan:
On circ/circulation-home.pl and reserve/request.pl, search for patrons
The descriptions for the libraries and patron categories should be
displayed.

Signed-off-by: Bernardo Gonzalez Kriegel 

On top of Bug 13336
Works as described, now descriptions instead of codes.
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

--- Comment #4 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #3)
> I get 3 without the patch and 1 remains with the patch applied, is it
> expected?
> 
> t/db_dependent/TestBuilder.t .. 1/9 Violation of unique constraint in Branch
> at t/lib/TestBuilder.pm line 201.

Thanks.

$ prove t/db_dependent/TestBuilder.t
t/db_dependent/TestBuilder.t .. ok
All tests successful.
Files=1, Tests=9,  7 wallclock secs ( 0.06 usr  0.00 sys +  6.48 cusr  0.13
csys =  6.67 CPU)
Result: PASS

I had no warnings, because I had no MPL branch. And the patch only catches the
second build on line 57. If you do have one, the warning comes from line 56.
Will send a small follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt (separated word 'item')

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #51716|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 51849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51849&action=edit
[SIGNED-OFF] Bug 16562: Translatability: Issue in opac-user.tt (separated word
'item')

This patch fixes translatoion difficulties (syntax) with a tag-separated word
'item'

Signed-off-by: Bernardo Gonzalez Kriegel 
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt (separated word 'item')

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16563] Translatability: Issues in opac-account.tt (sentence splitting)

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16563

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16563] Translatability: Issues in opac-account.tt (sentence splitting)

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16563

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #51715|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 51850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51850&action=edit
[SIGNED-OFF] Bug 16563: Translatability: Issues in opac-account.tt (sentence
splitting)

This patch removes splitting by -tags from 2 sentences.

Signed-off-by: Bernardo Gonzalez Kriegel 
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16607] New: Add verbose flag to builder sub in TestBuilder

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607

Bug ID: 16607
   Summary: Add verbose flag to builder sub in TestBuilder
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16607

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16607] Add verbose flag to builder sub in TestBuilder

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16500

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

--- Comment #5 from Marcel de Rooy  ---
Created attachment 51851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51851&action=edit
Bug 16500: [QA Follow-up] Catch warning if branch MPL already exists

The current test had no warnings, when you have no MPL branch, and only
catches the warn from the second build on line 57. If you do have MPL,
a warning comes from line 56.

This patch quickly fixes it. Report 16607 will propose a general
solution.

Test plan:
Do not yet apply the patch.
Add MPL branch.
Run the test. Notice the warning about Branch.
Apply the patch.
Run the test. Warning gone?

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16601] Update MARC21 it-IT frameworks to Update 22 (April 2016)

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16601] Update MARC21 it-IT frameworks to Update 22 (April 2016)

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #51838|0   |1
is obsolete||

--- Comment #3 from Bernardo Gonzalez Kriegel  ---
Created attachment 51852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51852&action=edit
[SIGNED-OFF] Bug 16601: Update of italian MARC21 files

This is the update for April 2016 changes of Library of Congress
The basic creation of the files is done in
http://translate.koha-community.org/files/it/mandatory/

https://bugs.koha-community.org/show_bug.cgi?id=16601
Signed-off-by: Bernardo Gonzalez Kriegel 
Both files load without problems.
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

--- Comment #13 from Nick Clemens  ---
Would it be reasonable to fix the RSS here and then move the atom
discussion/fix/removal to another bug report so this one can get through?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #4 from Martin Renvoize  ---
+1. No reason not to

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #14 from Christopher Brannon  ---
(In reply to Nick Clemens from comment #13)
> Would it be reasonable to fix the RSS here and then move the atom
> discussion/fix/removal to another bug report so this one can get through?

Yes!  Sounds like the Atom feed is something that should be addressed in
another bug.  I'm all for moving this along.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12682] Shibboleth attribute manipulation

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12682

--- Comment #2 from Martin Renvoize  ---
I'm afraid I never got to this one,  I had too many other outstanding
shibboleth via awaiting signoff and qa to devote time to this.

In another ago I wrote shibboleth interactions for however,  we use perl config
files.  It was very easy there to just replace the simple mapping with more
complex control statements anonymous subroutine references..  That's likely how
I would attempt to impliment such a piece these days

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12648] Link patrons to an order

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #79 from Christopher Brannon  ---
I'm not finding any reference to this feature in the manual.  Is it there?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance Improvement

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107

--- Comment #9 from Martin Renvoize  ---
Shame, this one seems to have lost its head of steam :-(

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

--- Comment #11 from Srdjan Jankovic  ---
Apologies, my mistake, did not adjust for the additional patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #27 from M. Tompsett  ---
Comment on attachment 51377
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51377
Rebase on master

Review of attachment 51377:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5670&attachment=51377)
-

::: C4/Auth.pm
@@ +435,4 @@
>  );
>  if ( $in->{'type'} eq "intranet" ) {
>  $template->param(
> +useHouseboundModule  
>   => C4::Context->preference("useHouseboundModule"),

There is no need to do this. The preferences are accessible in the template,
see other templates which grab preferences already.

::: koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
@@ +105,4 @@
>  [% IF CAN_user_borrowers && useDischarge %]
>  [% IF dischargeview %][% ELSE %][% END %] href="/cgi-bin/koha/members/discharge.pl?borrowernumber=[% borrowernumber 
> %]">Discharge
>  [% END %]
> +[% IF Koha.Preference('HouseboundModule') %]

See, like here.

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt
@@ +110,5 @@
> +  Friday
> +  Saturday
> +  Sunday
> +[% END %]
> +  

Couldn't all this select logic be simplified with a loop?

@@ +122,5 @@
> + selected="selected">[% frequency.label %]
> +  [% ELSE %]
> +[% 
> frequency.label %]
> +  [% END %]
> +[% END %]

Like this.

@@ +335,5 @@
> +[% ELSIF hpd == 'saturday' %]
> +  Saturday
> +[% ELSIF hpd == 'sunday' %]
> +  Sunday
> +[% END %]

http://template-toolkit.org/docs/manual/VMethods.html#section_ucfirst

::: members/housebound.pl
@@ +82,5 @@
> +fav_itemtypes  => $input->param('fav_itemtypes'),
> +fav_subjects   => $input->param('fav_subjects'),
> +fav_authors=> $input->param('fav_authors'),
> +referral   => $input->param('referral'),
> +notes  => $input->param('notes'),

Perhaps // q{} or something similar might be nice, just in case there's
undefined parameters.

::: t/db_dependent/Patron/Housebound.t
@@ +64,5 @@
> +foreach my $cho ( @{$found_choosers} ) {
> +$cho_counter ++
> +if ( $cho->borrowernumber eq $patron_chooser->{borrowernumber} );
> +};
> +is(1, 1, "Return our patron_chooser!");

What is the point of this test?

@@ +73,5 @@
> +foreach my $del ( @{$found_deliverers} ) {
> +$del_counter ++
> +if ( $del->borrowernumber eq $patron_deliverer->{borrowernumber} );
> +};
> +is(1,1,"Return our patron_deliverer!");

What is the point of this test?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5620] Capture Mode of payment

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

--- Comment #6 from M. Tompsett  ---
Comment on attachment 51290
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51290
bug 5620 - Capture Mode of payment, receipt number and notes in pay fines.

Review of attachment 51290:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5620&attachment=51290)
-

::: C4/Accounts.pm
@@ +89,4 @@
>  sub recordpayment {
>  
>  #here we update the account lines
> +my ( $borrowernumber, $data, $sip_paytype, $payment_note, $paymentmode ) 
> = @_;

"PERL16: Hashrefs should be used as arguments"
Perhaps refactor is in order? There are already too many parameters.

::: installer/data/mysql/atomicupdate/bug5620_Add_Mode_Of_Payment.perl
@@ +10,5 @@
> +$dbh->do("alter table accountlines add column paymentmode text not null");
> +$dbh->do("insert into authorised_values (category, authorised_value, lib, 
> lib_opac) values('PAYMODE','CASH','Cash', 'Cash')");
> +$dbh->do("insert into authorised_values (category, authorised_value, lib, 
> lib_opac) values('PAYMODE','CC','Credit Card', 'Credit Card')");
> +$dbh->do("insert into authorised_values (category, authorised_value, lib, 
> lib_opac) values('PAYMODE','DEBIG','Debit', 'Debit')");
> +print "bug5620 - add mode of payment";

Why not do this as a sql file?
Also, missing kohastructure.sql patch.

::: members/paycollect.pl
@@ +50,5 @@
> +my $sth = $dbh->prepare('SELECT * FROM authorised_values WHERE category = 
> "PAYMODE"');
> +$sth->execute();
> +while ( my $row = $sth->fetchrow_hashref() ) {
> +push @paymentmodes, $row;
> +}

This should probably be some nice function in some authorised value library
somewhere.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #51544|0   |1
is obsolete||

--- Comment #12 from Marcel de Rooy  ---
Created attachment 51853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51853&action=edit
Bug 16502: Table koha_plugin_com_bywatersolutions_kitchensink_mytable not
always dropped after running Plugin.t

If you run Plugin.t, the above table will still be present (when you
did not enable UseKohaPlugins). This would trigger a warning when
running the test a second time.

Why? The uninstall call does its work not completely due to a small
inconsistency in Koha::Plugins::Handler::delete when calling run
without the enable_plugins parameter.

This patch resolves that inconsistency and also removes an unneeded skip
in Plugin.t in case the KitchenSink module already exists.
Note: This is a small fix. But I wonder if the Handler routines run and
delete should not have been implemented in Koha::Plugins::Base.
Also note that plugins/plugins-uninstall.pl will not be affacted by this
change, since it checks whether the pref is enabled before calling the
delete method.

Test plan:
[1] Do not yet install this patch.
[2] Verify that plugins are enabled in koha-conf.xml.
[3] Disable UseKohaPlugins in System Preferences!
[4] Run t/db_dependent/Plugins.t.
[5] Verify that table koha_plugin_com_bywatersolutions_kitchensink_mytable
still exists. (It should have been deleted.) Remove it manually.
[6] Apply this patch.
[7] Run the test again.
[8] Verify that the table does not exist.
[9] Run the test again (without warnings).

Signed-off-by: Marcel de Rooy 
Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

--- Comment #14 from Marcel de Rooy  ---
Created attachment 51855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51855&action=edit
Bug 16502: Adjust test for GetPlugins

The current test assumes that GetPlugins will return the test plugin
as the first one in the array. This is not correct.
This patch adjusts the test to a grep.

Test plan:
Run the test.
Bonus: Add additional plugins. Run the test again.

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

--- Comment #15 from Marcel de Rooy  ---
Created attachment 51856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51856&action=edit
Bug 16502: Replace a few other ok-calls by is-calls

Trivial changes that speak for themselves..

Signed-off-by: Marcel de Rooy 
Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t

2016-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #51804|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >