[Koha-bugs] [Bug 16455] TagsExternalDictionary does not work under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
   Patch complexity|--- |Small patch
 CC||m.de.r...@rijksmuseum.nl

--- Comment #5 from Marcel de Rooy  ---
QA: Claiming this one too now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16529] Clean up and improve upload template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #6 from Brendan Gallagher  ---
Pushed to Master - Should be in the November 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16444] C4::Tags is not plack safe

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444

--- Comment #4 from Marcel de Rooy  ---
Mine now, qa guys :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16444] C4::Tags is not plack safe

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16458] Setting to guarantor: JavaScript error form.branchcode is undefined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

--- Comment #8 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #6)
> (In reply to Marcel de Rooy from comment #5)
> > I still see: TypeError: document.form.password is undefined (members.js line
> > 107)
> 
> Hi Marcel,
> It's another bug, without this patch you are not able to set a guarantor.
> It seems that you get the error when saving the patron form.

Well, ok. I am passing qa on this one.
@RM: There may be little bit more to fix in this area?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16458] Setting to guarantor: JavaScript error form.branchcode is undefined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|Trivial patch   |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16458] Setting to guarantor: JavaScript error form.branchcode is undefined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #51447|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy  ---
Created attachment 52025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52025&action=edit
Bug 16458: Update library when a guarantor is set

If you edit a patron from the Edit link of the patron information block
(step 1 of the memberentry script), the branchcode is not displayed. If
you set a guarantor to a child from this form, a JavaScript error will
be raised:
  JavaScript error form.branchcode is undefined

It happens because there is the branchcode is not displayed and there is
no element with a branchcode name.

To avoid this issue, a branchcode hidden input is added to the form and
it will be updated when a guarantor is selected (same behavior as when
you edit a patron using the complete form).

Test plan:
Edit a patron using the Edit link of the patron info block (not the Edit
button in the toolbar)
Set a guarantor
=> Notice that the branchcode of the patron has been updated with the
branchcode of the guarantor

Signed-off-by: Owen Leonard 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16656] New: Patron category option for batch patron modification

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16656

Bug ID: 16656
   Summary: Patron category option for batch patron modification
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: sfa...@roseman.edu
QA Contact: testo...@bugs.koha-community.org

I’d like to see the addition of an option in the batch patron modification tool
that would allow me to pull up patrons by patron category instead of having to
rely only on using cardnumbers or files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16655] ERROR ON HOLIDAYS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16655

Humberto Blanco  changed:

   What|Removed |Added

 CC||hblanc...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16655] New: ERROR ON HOLIDAYS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16655

Bug ID: 16655
   Summary: ERROR ON HOLIDAYS
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: hblanc...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

Hi, 
I created holidays for vacation period, if i borrow a book on staff inferface
have no problems,but if so the same over SIP2 protocol do no take the holidays
defined.

For example:
humberto blanco can borrow book for 8 days. If checkout from staff interface in
2016-06-03 has no problem and the date_due take all my holidays (2016-07-25);
but if I do the same process over 3m selfcheck machine the date_due  is
(2016-06-11)

Really appreciate your help to solve this issue

Humberto,

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16654] The output from reports/cat_issues_top.pl is not proper CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16654

Barton Chittenden  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653

Barton Chittenden  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16654] New: The output from reports/cat_issues_top.pl is not proper CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16654

Bug ID: 16654
   Summary: The output from reports/cat_issues_top.pl is not
proper CSV
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The output from reports/cat_issues_top.pl is *NOT* csv; it is DSV (delimiter
separated values) with the option of using commas as delimiters... and the
delimiters aren't properly escaped.

To illustrate the point

1/ Check out an item whose title contains a comma.
2/ Go to Home [34m~@� Reports [34m~@� Most-circulated items
3/ Select a date range containing today's date
4/ Select the "To a file" radio button, and use comma (,) as the delimiter.
5/ Click Submit

Open the file in the spreadsheet program of your choice. Note that the title
containing the comma spans two columns, because it was not properly quoted.

If the report is going to use CSV as a file extension, it should be exported
using Text::CSV_XS, which properly handles CSV export.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16653] New: reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653

Bug ID: 16653
   Summary: reports/cat_issues_top.pl does not export "Count of
checkouts" column as CSV
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV

To replicate:

1/ Make sure that test instance has circulation in a given date range
2/ Go to Home › Reports › Most-circulated items
3/ Select a date range
4/ Select 'To screen into the browser' radio button, click submit.
5/ Note that Columns 'Rank/Biblioitemnumbers', 'Global' and 'Count of
checkouts' appear in screen output.
6/ Click the browser's back button
7/ Change output to 'To a file', click submit.
8/ Note that the columns "100/", "Global" and "Total" are exported to the CSV
file. "100/" contains the rank, "Global" is still global, and the "Total"
column is empty.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16652] RestfulAPI supporting services for Vufind and for xnciptoolkit drivers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

Josef Moravec  changed:

   What|Removed |Added

 Depends on||13903, 13927, 13895, 16497,
   ||15165


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895
[Bug 13895] Add API routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903
[Bug 13903] Add API routes to list, create, update, delete holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13927
[Bug 13927] Add API route to check hold capabilities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165
[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497
[Bug 16497] REST API: add routes to list libraries
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Josef Moravec  changed:

   What|Removed |Added

 Blocks||16652


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652
[Bug 16652] RestfulAPI supporting services for Vufind and for xnciptoolkit
drivers
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16497] REST API: add routes to list libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Josef Moravec  changed:

   What|Removed |Added

 Blocks||16652


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652
[Bug 16652] RestfulAPI supporting services for Vufind and for xnciptoolkit
drivers
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

Josef Moravec  changed:

   What|Removed |Added

 Blocks||16652


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652
[Bug 16652] RestfulAPI supporting services for Vufind and for xnciptoolkit
drivers
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13927] Add API route to check hold capabilities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13927

Josef Moravec  changed:

   What|Removed |Added

 Blocks||16652


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652
[Bug 16652] RestfulAPI supporting services for Vufind and for xnciptoolkit
drivers
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

Josef Moravec  changed:

   What|Removed |Added

 Blocks||16652


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652
[Bug 16652] RestfulAPI supporting services for Vufind and for xnciptoolkit
drivers
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Suzanne Fayle  changed:

   What|Removed |Added

 CC||sfa...@roseman.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16652] RestfulAPI supporting services for Vufind and for xnciptoolkit drivers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

Mike  changed:

   What|Removed |Added

   Deadline||2016-08-31

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16652] RestfulAPI supporting services for Vufind and for xnciptoolkit drivers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

Mike  changed:

   What|Removed |Added

Summary|RestfulAPI supporting   |RestfulAPI supporting
   |services for Vufind and |services for Vufind and for
   |NCIP for xnciptoolkit   |xnciptoolkit drivers
   |drivers |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16652] RestfulAPI supporting services for Vufind and NCIP for xnciptoolkit drivers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

Mike  changed:

   What|Removed |Added

  Component|Websites, Mailing Lists,|Web services
   |etc |
Version|16.05   |16.11
Summary|RestfulAPI supportindg  |RestfulAPI supporting
   |services for Vufind and |services for Vufind and
   |NCIP for xnciptoolkit   |NCIP for xnciptoolkit
   |drivers |drivers
   Assignee|wizzy...@gmail.com  |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16652] RestfulAPI supportindg services for Vufind and NCIP for xnciptoolkit drivers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

Mike  changed:

   What|Removed |Added

Summary|RestfulAPI supportind   |RestfulAPI supportindg
   |services for Vufind and |services for Vufind and
   |NCIP for xnciptoolkit   |NCIP for xnciptoolkit
   |drivers |drivers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16652] RestfulAPI supportind services for Vufind and NCIP for xnciptoolkit drivers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com,
   ||josef.mora...@gmail.com,
   ||m...@jkozlovsky.cz
Summary|RestfulAPI supportind   |RestfulAPI supportind
   |serivec for Vufind and NCIP |services for Vufind and
   |for xnciptoolkit driver |NCIP for xnciptoolkit
   ||drivers
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11606] Novelist Select in Staff Client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606

Nicole C. Engard  changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16652] New: RestfulAPI supportind serivec for Vufind and NCIP for xnciptoolkit driver

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

Bug ID: 16652
   Summary: RestfulAPI supportind serivec for Vufind and NCIP for
xnciptoolkit driver
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P1 - high
 Component: Websites, Mailing Lists, etc
  Assignee: wizzy...@gmail.com
  Reporter: blac...@gmail.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16651] Notes field blank for 952$z in opac-course-details.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16651

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16651] Notes field blank for 952$z in opac-course-details.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16651

Karl Holten  changed:

   What|Removed |Added

 CC||khol...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16651] New: Notes field blank for 952$z in opac-course-details.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16651

Bug ID: 16651
   Summary: Notes field blank for 952$z in opac-course-details.pl
 Change sponsored?: ---
   Product: Koha
   Version: 3.20
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: khol...@switchinc.org
QA Contact: testo...@bugs.koha-community.org

Created attachment 52024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52024&action=edit
Screenshot of area where notes should display

The notes field in the opac-course-details.pl page does not display a 952$z if
there is no note in the course reserve. It should fail over and display the
952$z if no notes are present.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15853] Add author and link columns to opac course reserves table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15853

--- Comment #1 from Nick Clemens  ---
Created attachment 52023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52023&action=edit
Bug 15853 - Add author and link columns to opac course reserves table

To test:
1 - Add some course reserves
2 - View the table in staff and opac, there is no column for author or
link
3 - Apply patch
4 - You shoudl see these columns
5 - Link should contain item uri if present, fallback to title 856$u,
  then be blank if niether

Sponsored by:
Southeastern Wisconsin Information Technology Exchange, Inc (SWITCH)
(http://caspian.switchinc.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15853] Add author and link columns to opac course reserves table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15853

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16650] Add script to clear report caches manually

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16650

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2389] overdue_notices.pl needs a test mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2389

Nicole C. Engard  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 CC||neng...@gmail.com,
   ||nic...@bywatersolutions.com
 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |tomasco...@gmail.com

--- Comment #8 from Nicole C. Engard  ---
ByWater is going to sponsor this development

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16650] Add script to clear report caches manually

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16650

--- Comment #1 from Kyle M Hall  ---
Created attachment 52022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52022&action=edit
Bug 16650 - Add script to clear report caches manually

It would be nice if there was an easy way to clear a report cache before
it's expiration time.

Test Plan:
1) Apply this patch
2) Read the help for misc/cronjobs/clear_report_cache.pl
3) Make a public report
4) Load that public report via svc/report
5) Change the report so it will give different results
6) Reload svc/report, you should get the same results
7) Clear the cache with this script
8) Reload svc/report again, you should now get updated results!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16650] Add script to clear report caches manually

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16650

Kyle M Hall  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16650] Add script to clear report caches manually

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16650

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16650] New: Add script to clear report caches manually

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16650

Bug ID: 16650
   Summary: Add script to clear report caches manually
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

It would be nice if there was an easy way to clear a report cache before it's
expiration time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #22 from Nick Clemens  ---
(In reply to Koha Team Lyon 3 from comment #21)
> When you empty the field "UniqueItemFields" but that you have
> AcqCreateItem="Create an item when placing an order", you should have the
> items part present when you're placing an order ... but this is not the case.
> You have only "Catalog details" and "Accounting details" on neworderempty.pl
> and you can't change manualy the quantity in Quantity field.
> So it's a real problem !!

I don't see this in my testing - I matched my settings and still have the form
to add items, can you recheck?

> But, we have UniqueItemFields=barcode, because, I thought that there's a
> check at any moment of the process of the acquisition (even on reception).
> It's not really clear.

You should still be able to add the items without barcodes when barcode is
listed in UniqueitemFields, it should only trigger if you try to add two of the
same barcode and should only be a block when saving the order


> If UniqueItemFields is checked not only when you place an order but also
> after, i think that it's a pity to add a message that blocks the user when
> barcode is empty when you place an order.

The messages I add shuold not block a user from ordering multiples with no
barcode, it should only warn when creating multiple that, if inetered, a
barcode will not be copied to each item.

I can easily convert the message to be a static alert on the page instead of a
popup when creating multiple, I just wanted to be super clear about why some
fields wouldn't be copied

> Last comment, as an user, I would prefer to be abble to add the number of
> items, without to click on a button before.
> For exemple,could we have a button "Place item(s)" and then a box where you
> can type the number with 1 as a default value ?
> It will be really much easier for people that enter orders all the day :)
T
his is more to prevent accidentally adding multiples and mimics the setup on
adding items while cataloguing. I would like to hear a QA opinion on this one

Moving back to needs sign-off to get more comments, but let me know your
thoughts on the above.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16641] Update Novelist in opac to use updated call to fetch content

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com,
   ||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11606] Novelist Select in Staff Client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606

Nick Clemens  changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14902] Add qualifier menu to staff side "Search the Catalog"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14902

Nick Clemens  changed:

   What|Removed |Added

Version|3.18|master
 CC||n...@bywatersolutions.com,
   ||nic...@bywatersolutions.com
  Change sponsored?|--- |Sponsored
   Assignee|gmcha...@gmail.com  |n...@bywatersolutions.com
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14902] Add qualifier menu to staff side "Search the Catalog"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14902

--- Comment #2 from Nick Clemens  ---
Created attachment 52021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52021&action=edit
Bug 14902 - Add qualifier menu to staff side "Search the Catalog"

To test:
1 - Apply patch and update dabase
2 - Check that Search the Catalog links throughout the staff interface
have not changed
3 - Set "IntranetCatalogSearchPulldown" to 'Show'
4 - Verify that 'Search the catalog' links through staff client now have
a dropdwon to  select search index

I think viewing one file each that includes updated header should be
sufficient, but please check as many as you can:

cgi-bin/koha/admin/aqbudgetperiods.pl
cgi-bin/koha/admin/admin-home.pl
cgi-bin/koha/cataloguing/addbooks.pl
cgi-bin/koha/circ/returns.pl
cgi-bin/koha/circ/circulation-home.pl
cgi-bin/koha/admin/cities.pl
cgi-bin/koha/admin/aqcontract.pl
cgi-bin/koha/admin/currency.pl
cgi-bin/koha/mainpage.pl
cgi-bin/koha/tools/letter.pl
cgi-bin/koha/members/members-home.pl
cgi-bin/koha/admin/categories.pl
cgi-bin/koha/admin/preferences.pl
cgi-bin/koha/admin/printers.pl
cgi-bin/koha/serials/serials-home.pl
cgi-bin/koha/acqui/newordersuggestion.pl
cgi-bin/koha/admin/z3950servers.pl

Sponsored by:
  Northeast Kansas Library System (http://nekls.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14902] Add qualifier menu to staff side "Search the Catalog"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14902

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441

--- Comment #5 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #4)
> Because I have not found anywhere it's called many times. As I wrote
> previously, I am not sure it'd be interesting to cache it, but I may be
> wrong.
> If we decide to cache it, we need to make sure the values in cache are
> deleted when letters are updated/deleted.
> Anyway it will be a much bigger patch and more an enhancement than a bugfix.

Yes, it would be more work. But this patch affects performance.
Note that I am not sure if this is actually a bugfix.
The comment about regularly restarting plack is probably outdated. If we let
each worker process only handle 50 requests, you do not need to restart plack
very often.
Since a new worker starts with an empty 'cache', you will not long see the old
letter contents anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #12 from Tomás Cohen Arazi  ---
I picked what was discussed here and implemented the feature using ideas from
Jonathan, Kyle and Sheila.

I added a table for configuring rules for each branch, and/or globally. This is
done in the 'Circulation and fines rules' page.

I also added the RefundLostOnReturnControl syspref Sheila and Kyle proposed
giving the libraries more granularity on how the rules are processed.

The introduced code is fully tested by new unit tests.

Please test, and I'll be waiting for your feedback!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|jwea...@bywatersolutions.co |tomasco...@gmail.com
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion
 CC||katrin.fisc...@bsz-bw.de

--- Comment #13 from Héctor Eduardo Castro Avalos  
---
(In reply to Aliki Pavlidou from comment #12)

Hi Aliki thank your for testing

> Regarding Patrons list the "Select all" and "Clear all" icons are not the
> same as the "Remove selected patrons" or "Remove selected".
That was intentionally did it since comment 5 about that I can cite "There is
currently some confusion in how we indicate remove or cancel (See Bug 16005). I
think the "trash" icon should be the standard for delete or remove." So I can't
use the same trash icon for clear button.

> Regarding comments "delete and" icon is not there (of course there are no
> comments in the test page and this may be the reason).
Perhaps I did not write well the test plan "delete and" icon really does not
exist, I was refering only to three buttons: "Approve", "Delete", "Unapprove",
those buttons shown in two tabs "Approved comments" and "Comments awaiting
moderation".

> regarding "Tags", "Test" and "Apply filter(s)" have the same shiny icon!
> There are no "Clear all" and "Set TagsModeration to Require", buttons.
In this point the interface was little changed to reflect the same look as
other parts in Koha. If you see before apply patch the leyend for this is
"Select: All Pending None" and after is shown like in attach

Respect to "Set TagsModeration to Require" again I did not explain well, I was
refering to set the syspref "TagsModeration" to "Require"

> The "The Approved", "Rejected", "Pending, and "Total" buttons in the right
> box are not icons.
Citing again the comment 5 "The links under "Terms summary" should not have
icons. Icons are attached to controls which trigger actions. These links are
for different views of the data." So I did not put icons in this right box.
Look an obsolete image attached


At this point I would like to know the opinion of Owen or another QA like
Katrin.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Depends on|15522   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
[Bug 15522] New interface for revamped circulation rules
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 52020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52020&action=edit
Bug 14048: Hook new rules into C4::Circulation

This patch makes AddIssue and AddReturn use the new implementation

The behaviour should respect the specification.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks|14048   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 52018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52018&action=edit
Bug 14048: Add syspref and atomic update

This patch introduces the changes to the sysprefs and the atomic update
that creates the new table.

It picks the syspref value for RefundLostItemFeeOnReturn and uses it to
create a default (branchcode='*') rule on the new table.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 52017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52017&action=edit
Bug 14048: Unit tests

This patch introduces unit tests for the feature.
To test:
- Have all patches from this bug applied
- Run:
  $ prove -v t/db_dependent/RefundLostItemFeeRule.t
=> SUCCESS: All tests pass!

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 52019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52019&action=edit
Bug 14048: Add a refund rules setting form in smart-rules

This patch introduces the CRUD UI for managing the refund lost item fee
rules on the general 'Circulation and fines rules' page.

Verify that rules can be added and changed (by adding a new one for
the same branch). The default rule is locked so it cannot be deleted.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 52016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52016&action=edit
Bug 14048: Add RefundLostItemFeeRule table and classes

This patch introduces new classes for handling refund lost item fee
rules. It introduces a new table for storing this rules.

It is designed so it is possible to define a global rule, and then
branch-specific ones. The specific is prefered if available.

This behaviour is fully tested by unit tests introduced by the following
patches.

This cannot be tested on its own.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16649] New: OpenLibrarySearch.t fails when building packages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16649

Bug ID: 16649
   Summary: OpenLibrarySearch.t fails when building packages
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mi...@abunchofthings.net
QA Contact: gmcha...@gmail.com

Use of uninitialized value $_[0] in string eq at /usr/share/perl5/JSON.pm line
159.
malformed JSON string, neither array, object, number, string or atom, at
character offset 0 (before "(end of string)") at t/OpenLibrarySearch.t line 25
# Looks like your test exited with 22 before it could output anything.
t/OpenLibrarySearch.t ... 
Dubious, test returned 22 (wstat 5632, 0x1600)
Failed 1/1 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16649] OpenLibrarySearch.t fails when building packages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16649

Mirko Tietgen  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=6624

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624

Mirko Tietgen  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16649

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #50173|0   |1
is obsolete||

--- Comment #38 from Jonathan Druart  
---
Created attachment 52014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52014&action=edit
Bug 15407: Koha::Patron::Categories - replace GetBorrowercategoryList

C4::Members::GetBorrowercategoryList returned all the patron categories,
ordered by description.
This can be done using the search method of the Koha::Patron::Categories
module.

Test plan:
- Same prerequisite as before
For the following pages, you should not see patron categories limited to other
libraries. They should be ordered as before this patch, by description.
- On the "patron attribute types" admin page (admin/patron-attr-types.pl).
- On the "Batch patron deletion/anonymization"
  (tools/cleanborrowers.pl), the dropdown list should be filled
  correctly.
- On the import patron tool
- On the following report:
reports/reserves_stats.pl
Confirm that the patron categories are displayed and that the report
still works as before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #50172|0   |1
is obsolete||

--- Comment #37 from Jonathan Druart  
---
Created attachment 52013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52013&action=edit
Bug 15407: Koha::Patron::Categories - replace GetBorrowercategory

The purpose of C4::Members::GetBorrowercategory was to return the patron
category for a given categorycode. This can be done easily with the
Koha::Patron::Categories->find method.

Test plan:
- Same prerequisite as before
- Edit a guarantor and confirm the information will be updated for his/her
  guarantee(s).
- Update a child to adult patron (Note: Should not we hide the patron
  categories limited to others libraries? If yes, it must be done on another
  bug report).
  There is a special behavior if there is only 1 adult category, the
  user does not need to select a category. So the same as before with
  only 1 adult patron category.
- Import a patron with a category_code which does not exist. You should
  be warned.
- Modify some patron using the batch patron modification tool. The
  patron category descriptions should correctly be displayed.

Note that the overduerules page has already been tested in a previous
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #50174|0   |1
is obsolete||

--- Comment #39 from Jonathan Druart  
---
Created attachment 52015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52015&action=edit
Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType

This unnecessary complicated subroutine returned an arrayref and an
hashref of the patron categories available for the logged in user, for a given
category_type, ordered by categorycode.
This can now be done with the search_limited method.

Test plan:
- Same prerequisite as before
For the following pages, you should not see patron categories limited to other
libraries. They should be ordered as before this patch, by categorycode.
- Add/edit a patron, change his/her patron category value.
- On the 3 following reports:
reports/bor_issues_top.pl
reports/borrowers_out.pl
reports/cat_issues_top.pl
The display for these 3 reports are different than the 2 from the first
patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by
categorycode and the ones limited to other libraries are not displayed
(should certainly be fixed).

Note that the big part of this patch has already been tested before
(update child related: CATCODE_MULTI).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16468] Remove last "onclick" from the stage MARC records template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16468] Remove last "onclick" from the stage MARC records template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468

Claire Gravely  changed:

   What|Removed |Added

  Attachment #51296|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 52012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52012&action=edit
Bug 16468 - Remove last "onclick" from the stage MARC records template

This patch reviseds the stage MARC records template, removing
one more "onclick" attribute from the markup and defining that event in
the script.

This patch also corrects a missing quotation mark in the HTML. I have
done some reindentation to that section.

To test, apply the patch and go to Tools -> Stage MARC records for
import.

- Select a MARC file for import.
- Click the "Upload file" button.
- Click the "Stage for import" button. Your import should be correctly
  staged.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16529] Clean up and improve upload template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16529] Clean up and improve upload template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #52002|0   |1
is obsolete||

--- Comment #5 from Marcel de Rooy  ---
Created attachment 52011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52011&action=edit
Bug 16529 - Clean up and improve upload template

This patch makes some fixes and improvements to the template for Tools
-> Upload, including markup corrections, removal of 'onclick,' and
conversion of some links to styled buttons.

To test, apply the patch and go to Tools -> Upload.

- Confirm that uploading a file works correctly.
- Confirm that clicking 'Cancel' during a file upload works correctly.
- Search existing uploads.
  - Confirm that the 'Download' and 'Delete' buttons look correct and
work correctly.
- In Administration -> MARC bibliographic framework, choose a
  framework and configure a tag subfield to use the upload plugin.
- Create or edit a bibliographic record using the framework you
  modified.
- Click the tag editor icon next to your modified subfield to trigger
  the pop-up window with the upload form.
  - Confirm that this window has a layout which is adjusted for the size
of the window.
  - Confirm that uploading and selecting files from this window works
correctly.

Signed-off-by: Rocio Dressler 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #87 from Matthias Meusburger  ---
Created attachment 52010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52010&action=edit
Bug 7677 [QA Followup] - Replace GetItemnumberFromSerialId with use of
Koha::Serial::Item(s)

- use _type instead of type (see
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #51418|0   |1
is obsolete||

--- Comment #34 from Jesse Weaver  ---
Created attachment 52008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52008&action=edit
Bug 16088: Introduce Koha::Cache::Memory::Lite to cache the language

The goal of this patch is to avoid unecessary flush of the L1 cache on
creating a new CGI object each time C4::Languages::getlanguage is called
without a CGI object.

The new class Koha::Cache::Memory::Lite must be flushed by the CGI
constructor overide done in the psgi file. This new class will ease
caching of specific stuffs used by running script.

Test plan:
At the OPAC and the intranet interfaces:
Open 2 different browser session to simulate several users
- Clear the cookies of the browsers
- User 1 (U1) an User 2 (U2) should be set to the default language
  (depending on the browser settings)
- U1 chooses another language
- U2 refreshes and the language used must be the default one
- U2 chooses a third language
- U1 refreshes and must be still using the one he has choosen.

Try to use a language which is not defined:
Add &language=es-ES (if es-ES is not translated) to the url, you should
not see the Spanish interface.

Signed-off-by: Jacek Ablewicz 

Signed-off-by: Jesse Weaver 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #51429|0   |1
is obsolete||

--- Comment #35 from Jesse Weaver  ---
Created attachment 52009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52009&action=edit
Bug 16088: Fix the number of tests to skip

Signed-off-by: Jacek Ablewicz 

Signed-off-by: Jesse Weaver 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

Jesse Weaver  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16633] Translatability: Issues in tags/review.tt (sentence splitting)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16633

Rocio Dressler  changed:

   What|Removed |Added

  Attachment #51952|0   |1
is obsolete||

--- Comment #2 from Rocio Dressler  ---
Created attachment 52007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52007&action=edit
Bug 16633: Translatability: Issues in tags/review.tt (sentence splitting)

This patch fixes translatability issues in
koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
(isolated words by sentence splitting).

To test:
- Review code and verify that changes make sense.

Signed-off-by: Rocio Dressler 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16633] Translatability: Issues in tags/review.tt (sentence splitting)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16633

Rocio Dressler  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16442] C4::Ris is not plack safe

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #5 from Brendan Gallagher  ---
Pushed to Master - Should be in the November 2016 release. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16529] Clean up and improve upload template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

--- Comment #4 from Marcel de Rooy  ---
QA: Looking at this one now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16634] Translatability: Fix issue in memberentrygen.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16634

Rocio Dressler  changed:

   What|Removed |Added

  Attachment #51953|0   |1
is obsolete||

--- Comment #2 from Rocio Dressler  ---
Created attachment 52006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52006&action=edit
Bug 16634: Translatability: Fix issue in memberentrygen.tt

This patch fixes a small translatability issue in
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
The sentence following sentence was splitted by HTML tags:
"Attribute value x is already in use by another patron record."

To test:
- Review code
- Apply patch
- In Admin, create a unique patron attribute type and try to give
  two patrons the same value for this attribute type.

Signed-off-by: Rocio Dressler 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16634] Translatability: Fix issue in memberentrygen.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16634

Rocio Dressler  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16442] C4::Ris is not plack safe

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16442] C4::Ris is not plack safe

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #51773|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 52005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52005&action=edit
Bug 16442: Make C4::Ris plack safe

C4::Ris incorrectly uses 4 package variables:
- $utf: not used, can be removed
- $intype: set to marcflavour once, but later it assumes that it is
  usmarc if not defined
- $marcprint: always 0, so set it to 0
- $protoyear: only used in 1 subroutine, let's define it at this
  level

Test plan:
Just make sure the RIS export works as before this patch

Signed-off-by: Chris Cormack 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16442] C4::Ris is not plack safe

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15087] hardduedate should not be inserted as 0000-00-00 but NULL

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
  Attachment #52003|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088

Chris Cormack  changed:

   What|Removed |Added

  Attachment #48187|0   |1
is obsolete||

--- Comment #11 from Chris Cormack  ---
Created attachment 52004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52004&action=edit
Bug 15088 - Follow for koha-create

Logic in the koha-create was requiring a DEFAULTSQL to trigger.
This patch moves it, such that --create-db will be registered
all the time.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15087] hardduedate should not be inserted as 0000-00-00 but NULL

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087

--- Comment #17 from Chris Cormack  ---
Created attachment 52003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52003&action=edit
Bug 15087 - Follow for koha-create

Logic in the koha-create was requiring a DEFAULTSQL to trigger.
This patch moves it, such that --create-db will be registered
all the time.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16529] Clean up and improve upload template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529

Rocio Dressler  changed:

   What|Removed |Added

  Attachment #51539|0   |1
is obsolete||

--- Comment #3 from Rocio Dressler  ---
Created attachment 52002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52002&action=edit
Bug 16529 - Clean up and improve upload template

This patch makes some fixes and improvements to the template for Tools
-> Upload, including markup corrections, removal of 'onclick,' and
conversion of some links to styled buttons.

To test, apply the patch and go to Tools -> Upload.

- Confirm that uploading a file works correctly.
- Confirm that clicking 'Cancel' during a file upload works correctly.
- Search existing uploads.
  - Confirm that the 'Download' and 'Delete' buttons look correct and
work correctly.
- In Administration -> MARC bibliographic framework, choose a
  framework and configure a tag subfield to use the upload plugin.
- Create or edit a bibliographic record using the framework you
  modified.
- Click the tag editor icon next to your modified subfield to trigger
  the pop-up window with the upload form.
  - Confirm that this window has a layout which is adjusted for the size
of the window.
  - Confirm that uploading and selecting files from this window works
correctly.

Signed-off-by: Rocio Dressler 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16529] Clean up and improve upload template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529

Rocio Dressler  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11490] MaxItemsForBatch should be split into two new prefs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

--- Comment #10 from sandbo...@biblibre.com  ---
Created attachment 52000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52000&action=edit
Bug 11490: Add prefs MaxItemsToProcessForBatchMod and
MaxItemsToDisplayForBatchDel

Signed-off-by: Laurence Rault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11490] MaxItemsForBatch should be split into two new prefs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #51424|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11490] MaxItemsForBatch should be split into two new prefs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #51425|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11490] MaxItemsForBatch should be split into two new prefs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

--- Comment #11 from sandbo...@biblibre.com  ---
Created attachment 52001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52001&action=edit
Bug 11490: Split MaxItemsForBatch into 2 prefs to clarify things

Prior to this patch, a single pref (MaxItemsForBatch) was used to
restrict the use of the batch item modification and deletion.

On the batch modification tool, the pref is used to limit the number of
items a librarian is allowed to modify in a batch, but on the batch
deletion tool the pref is used to limit the number of items to display.

To clarify things, this patch split the pref into 2 new prefs:
MaxItemsToDisplayForBatchDel and MaxItemsToProcessForBatchMod.

Later we could add a MaxItemsToProcessForBatchDel if needed.
Note that this patch should not introduce any changes in the current behaviors.

Test plan:
0/ Do not execute the update DB entry
1/ Set a value != 1000 for MaxItemsForBatch
2/ Execute the update DB entry and confirm that the 2 new prefs are
initially set with the value of MaxItemsForBatch and that
MaxItemsForBatch has been deleted
3/ Set different values for these 2 prefs (2 and 3 for instance to ease
the next steps)
4/ Try to delete less than MaxItemsToDisplayForBatchDel items
=> You must see the items details
5/ Try to delete more than MaxItemsToDisplayForBatchDel items
=> You must not see the items details but are allowed to delete them
6/ Try to modify less than MaxItemsToProcessForBatchMod items
=> You must see the items details
7/ Try to modify more than MaxItemsToProcessForBatchMod items
=> You must be restricted and not allowed to process

Signed-off-by: Laurence Rault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11490] MaxItemsForBatch should be split into two new prefs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #9 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Laurence Rault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11490] MaxItemsForBatch should be split into two new prefs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

Laurence Rault  changed:

   What|Removed |Added

 CC||laurence.ra...@biblibre.com

--- Comment #8 from Laurence Rault  ---

Tested on sandbox, so the updatedatabase is made automatically
Both sysprefs are set to 1000 by default

0/ Do not execute the update DB entry
1/ Set a value != 1000 for MaxItemsForBatch
2/ Execute the update DB entry and confirm that the 2 new prefs are
initially set with the value of MaxItemsForBatch and that
MaxItemsForBatch has been deleted

Tested on sandbox, so the updatedatabase is made automatically
Both sysprefs are set to 1000 by default
MaxItemsForBatch has been deleted


3/ Set different values for these 2 prefs (2 and 3 for instance to ease
the next steps)
4/ Try to delete less than MaxItemsToDisplayForBatchDel items
=> You must see the items details
OK

5/ Try to delete more than MaxItemsToDisplayForBatchDel items
=> You must not see the items details but are allowed to delete them
OK

6/ Try to modify less than MaxItemsToProcessForBatchMod items
=> You must see the items details
OK

7/ Try to modify more than MaxItemsToProcessForBatchMod items
=> You must be restricted and not allowed to process
OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2280] authorized value option for indicators doesn't work

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2280

joachim.ganse...@ehb.be changed:

   What|Removed |Added

 CC||joachim.ganse...@ehb.be

--- Comment #9 from joachim.ganse...@ehb.be ---
Setting default values for indicators is filed as bug #9701.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED

--- Comment #8 from Chris Cormack  ---
This is dependent on 13995 which is currently failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16648] Add Content system preferences for all CSS and XSLT sysprefs that accept a URL.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16648

Barton Chittenden  changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #1 from Barton Chittenden  ---
*** Bug 11884 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11884] SlipCSS and NoticeCSS should be CSS not a file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11884

Barton Chittenden  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from Barton Chittenden  ---


*** This bug has been marked as a duplicate of bug 16648 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16648] New: Add Content system preferences for all CSS and XSLT sysprefs that accept a URL.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16648

Bug ID: 16648
   Summary: Add Content system preferences for all CSS and XSLT
sysprefs that accept a URL.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The following system preferences allow paths to be specified for CSS or XSLT
files:

NoticeCSS
opaclayoutstylesheet
OpacAdditionalStylesheet
intranetcolorstylesheet
intranetstylesheet
SlipCSS

OPACXSLTDetailsDisplay
OPACXSLTResultsDisplay
XSLTDetailsDisplay
XSLTResultsDisplay

This causes administrative headaches, because the CSS or XSLT cannot be stored
in the database -- for instance adding 'NoticeCSS' means that a css file must
be created and hosted somewhere, and these assets risk being lost on server
moves if hosted locally, or are an external point of failure if hosted
remotely.

I suggest that for each CSS or XSLT path syspref, there should be a
corresponding 'Content' variable:

-+-+--
Path Syspref | Content Syspref | Content Path
-+-+--
CSS
-+-+--
NoticeCSS| NoticeCSSContent|
cgi-bin/koha/css/NoticeCSS.css
opaclayoutstylesheet | opaclayoutstylesheetContent |
cgi-bin/koha/css/opaclayoutstylesheet.css
OpacAdditionalStylesheet | OpacAdditionalStylesheetContent |
cgi-bin/koha/css/OpacAdditionalStylesheet.css
intranetcolorstylesheet  | intranetcolorstylesheetContent  |
cgi-bin/koha/css/intranetcolorstylesheet.css
intranetstylesheet   | intranetstylesheetContent   |
cgi-bin/koha/css/intranetstylesheet.css
SlipCSS  | SlipCSSContent  |
cgi-bin/koha/css/SlipCSS.css
-+-+--
XSLT
-+-+--
OPACXSLTDetailsDisplay   | OPACXSLTDetailsDisplayContent   |
cgi-bin/koha/xslt/OPACXSLTDetailsDisplay.xslt
OPACXSLTResultsDisplay   | OPACXSLTResultsDisplayContent   |
cgi-bin/koha/xslt/OPACXSLTResultsDisplay.xslt
XSLTDetailsDisplay   | XSLTDetailsDisplayContent   |
cgi-bin/koha/xslt/XSLTDetailsDisplay.xslt
XSLTResultsDisplay   | XSLTResultsDisplayContent   |
cgi-bin/koha/xslt/XSLTResultsDisplay.xslt
-+-+--

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752

Koha Team Lyon 3  changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr
 Status|Needs Signoff   |Failed QA

--- Comment #21 from Koha Team Lyon 3  ---
When you empty the field "UniqueItemFields" but that you have
AcqCreateItem="Create an item when placing an order", you should have the items
part present when you're placing an order ... but this is not the case.
You have only "Catalog details" and "Accounting details" on neworderempty.pl
and you can't change manualy the quantity in Quantity field.
So it's a real problem !!

In fact, in my libreary, we're creating items when placing an order but without
barcode. Barcode are sticked on physical items at the reception. But, we have
UniqueItemFields=barcode, because, I thought that there's a check at any moment
of the process of the acquisition (even on reception). It's not really clear.
If this is not the case, we can left UniqueItemFields empty. (but we need to be
able to add items informations in the order ;-) )
If UniqueItemFields is checked not only when you place an order but also after,
i think that it's a pity to add a message that blocks the user when barcode is
empty when you place an order.

Last comment, as an user, I would prefer to be abble to add the number of
items, without to click on a button before.
For exemple,could we have a button "Place item(s)" and then a box where you can
type the number with 1 as a default value ?
It will be really much easier for people that enter orders all the day :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15364] fines and invoices in letter templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15364

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||ch...@bigballofwax.co.nz

--- Comment #6 from Chris Cormack  ---
CONFLICT (content): Merge conflict in misc/cronjobs/overdue_notices.pl

I think it is a simple conflict, but not sure, if you could take a look I'll
try to sign off again tomorrow

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/