[Koha-bugs] [Bug 13807] SIPServer Input loop not checking for closed connections reliably

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #36715|0   |1
is obsolete||

--- Comment #2 from Srdjan Jankovic  ---
Created attachment 52111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52111=edit
[SIGNED-OFF] Bug 13807 Rework main input loop in SIPServer

Debugging various problems in SIPServer and control of it, found it
could loop on unread buffers (e.g. the LF of a CRLF if it was only
expecting CR) making it unresponsive to signals.
Reworked the input loop with an eye to removing unnecessary whiles
and replacing the while(1) by a while( connection valid)
Enhanced the timeout code by wapping in an eval.
Moved the logic from SIP_read_packet into the server itself
Hopefully this makes the already baroque code easier to navigate
and it did seem the server was the logical place for this
Removed no longer iused SIP_read_packet from Sip.pm

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13807] SIPServer Input loop not checking for closed connections reliably

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15857] Add test mode to process_message_queue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857

Srdjan Jankovic  changed:

   What|Removed |Added

 CC||srd...@catalyst.net.nz

--- Comment #6 from Srdjan Jankovic  ---
_send_message_by_email( $message, $params ) and _send_message_by_sms( $message,
$params ) rather than exploding individual params.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16671] Wrong itemtype picked in HoldsQueue.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16671

Srdjan Jankovic  changed:

   What|Removed |Added

 Blocks||14514


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514
[Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Srdjan Jankovic  changed:

   What|Removed |Added

 Depends on||16671


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16671
[Bug 16671] Wrong itemtype picked in HoldsQueue.t
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #6 from Eugene Espinoza  ---
I'm testing this in the sandbox and I'm getting this error when I go to the
MARC structure: Software error:

Can't use an undefined value as an ARRAY reference at
/usr/local/lib/perl/5.14.2/DBI.pm line 2064.
Even the email I received, I got the following:

The sandbox you've requested is now ready.
The patches attached to bugzilla 9701 have been applied, and the result is:

Updatedatabase:
Upgrade to 16.05.00.000 done (Koha 16.05)
Upgrade to 16.06.00.000 done (Koha 16.06 - starting a new dev line at KohaCon16
in Thessaloniki, Greece! Koha is great!)
Upgrade to 16.06.00.001 done (Bug 16200 - 'Hold waiting too long' fee has a
translation problem)
DEV atomic update: bug_9701-add_default_indicators.sql
C4::Installer::load_sql returned the following errors while attempting to load
/home/koha/src/installer/data/mysql/atomicupdate/bug_9701-add_default_indicators.sql:

So with this, I can't proceed further.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10459] borrowers should have a timestamp

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #60 from David Cook  ---
(In reply to M. Tompsett from comment #58)
> Hence the third patch which makes it updated_on, David Cook.
> Still ready for QA, like comment #56 says.

Yes, I was just adding the link for the sake of the conversation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16676] advance default version in build-git-snapshot

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16676

--- Comment #1 from Galen Charlton  ---
Created attachment 52110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52110=edit
Bug 16676: advance version in build-git-snapshot

This patch updates the default version for git package guilds
to '16.06~git'.

To test
---
[1] Verify that when building master packages using debian/build-git-snapshot,
the version stamp defaults to starting with "16.06~git".

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16676] advance default version in build-git-snapshot

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16676

Galen Charlton  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16668] Move t/Ris.t to t/db_dependent/Ris.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16668

Galen Charlton  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16674
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16674] remove two broken test from t/Ris.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16674

Galen Charlton  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16668

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16676] New: advance default version in build-git-snapshot

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16676

Bug ID: 16676
   Summary: advance default version in build-git-snapshot
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: gmcha...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: mi...@abunchofthings.net

16.06 is the number of the day (i.e., the base version for master packages), so
it's time to update debian/build-git-snapshot.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16675] fix breakage of t/Languages.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16675

Galen Charlton  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16674] remove two broken test from t/Ris.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16674

--- Comment #1 from Galen Charlton  ---
Created attachment 52108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52108=edit
Bug 16674: remove two tests from t/Ris.t

This patch removes two tests that were broken by the patch for
bug 16442, thus preventing packages from being build in master.

Ordinarily, one would either fix the tests or
change the code that broke the tests... but as the tests in
question check the return value of routines that do not
actually advertise a return value, I've elected to simply
remove them.

To test
---
[1] Verify that t/Ris.t passes.

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16675] fix breakage of t/Languages.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16675

--- Comment #1 from Galen Charlton  ---
Created attachment 52109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52109=edit
Bug 16675: fix breakage of t/Languages.t

This patch fixes test breakage introduced by the patch for bug 16088,
which added caching of getlanguages().  Upon inspection, it looks like
the patch for 16088 does not introduce a regression on bug 10560,
so this patch adds a couple cache-clearings.

To test
---
[1] Verify that t/Languages.t passes.

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16674] remove two broken test from t/Ris.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16674

Galen Charlton  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16675] New: fix breakage of t/Languages.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16675

Bug ID: 16675
   Summary: fix breakage of t/Languages.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: gmcha...@gmail.com
QA Contact: gmcha...@gmail.com

The patch for bug 16088 introduces caching that breaks two tests in
t/Languages.t. Upon inspection, it appears that the best resolution is to make
the test cases explicitly clear the cache when needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16674] New: remove two broken test from t/Ris.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16674

Bug ID: 16674
   Summary: remove two broken test from t/Ris.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: gmcha...@gmail.com
QA Contact: gmcha...@gmail.com

The patch for bug 16442 happened to change the implicit return values for
C4::Ris::print_title() and C4::Ris::print_stitle(), thereby breaking two tests
t/Ris.t.

However... on reflection those two tests are not very useful, as they test the
return value of two routines that neither advertise nor supply any return
value: their sole purpose is to calculate some values and print them to STDOUT.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16649] OpenLibrarySearch.t fails when building packages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16649

Galen Charlton  changed:

   What|Removed |Added

  Attachment #52071|0   |1
is obsolete||

--- Comment #4 from Galen Charlton  ---
Created attachment 52107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52107=edit
Bug 16649: Make OpenLibrarySearch test pass even if launches offline

Test plan:
  prove t/OpenLibrarySearch.t
should return green even if you are offline

Signed-off-by: Srdjan 
Signed-off-by: Mirko Tietgen 
Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16672] Add ability to remove expired holidays from special_holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16672

Florent Mara  changed:

   What|Removed |Added

 CC||florent.m...@gmail.com
 Status|Needs Signoff   |Signed Off

--- Comment #2 from Florent Mara  ---
Inserted 3 entries using the following on June 7th 2016:
INSERT INTO special_holidays(branchcode, day, month, year, isexception,
description) VALUES
('FFL', 1, 6, 2016, 1, 'description1'), 
('FFL', 2, 6, 2016, 1, 'description2'), 
('FFL', 3, 6, 2016, 1, 'description3');

Ran cleanup_database using the new switch:
# perl misc/cronjobs/cleanup_database.pl --unique-holidays 5

Only 2 entries were remaining in table `special_holidays`.

Then ran the same switch with the verbose flag
# perl misc/cronjobs/cleanup_database.pl --unique-holidays 4 --verbose
Removed 1 unqiue holidays

One entry was left in table `special_holidays`.
This patch works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16618] 00-load.t prematurely stops all testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618

--- Comment #5 from Galen Charlton  ---
Created attachment 52106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52106=edit
Bug 16618: 00-load.t prematurely stops all testing

Rather than add/remove regular expressions to skip modules (like bug 9054),
encapsulate the decision logic into a separate function.

Currently there are three libraries which trigger halts:
Koha::NorwegianDB (which was already there)
Koha::ElasticSearch::Indexer
Koha::SearchEngine::Elasticsearch::Search

TEST PLAN
-
1) prove t/00-load.t
   -- should barf horribly on Catmandu stuff
  if not: sudo apt-get remove libcatmandu-marc-perl
  then repeat step.
2) apply patch
3) prove t/00-load.t
   -- should not barf horribly
4) run koha qa test tools

NOTE: The four optional modules for Koha::NorwegianDB are
  listed in the PerlDependencies.pm, while there is
  no mention of Catmandu libraries at all there.
  This may be another bug which needs fixing.

TECH NOTES (for ideas of how to tinker around):
These three things should trigger the three module cases:
sudo apt-get remove libcatmandu-marc-perl
sudo apt-get remove libcatmandu-store-elasticsearch-perl
sudo apt-get remove libconvert-basen-perl

You probably had koha-perldeps installed before, so the following wil mostly
fix:
sudo apt-get install koha-perldeps libcatmandu-marc-perl

And in case you didn't have elastic search stuff installed:
echo deb http://packages.elastic.co/elasticsearch/1.7/debian stable main | sudo
tee /etc/apt/sources.list.d/elasticsearch.list
wget -O- https://packages.elastic.co/GPG-KEY-elasticsearch | sudo apt-key add -
sudo apt-get update

cd ~
wget
http://debian.koha-community.org/koha/otherthings/elasticsearch_deps.tar.gz
tar xvf elasticsearch_deps.tar.gz
cd es_deps
sudo dpkg i lib*
sudo apt-get install -f

Signed-off-by: Srdjan 

Signed-off-by: Jonathan Druart 
Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16647] Update debian/control for 16.*

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16647

--- Comment #3 from Galen Charlton  ---
I've attached a version of the patch that reflects what I actually used when
packaging 16.05.00. This should be applied to both master and 16.05.x; note
that when applying it to 16.05.x, the patch for bug 16617 is needed as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16647] Update debian/control for 16.*

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16647

Galen Charlton  changed:

   What|Removed |Added

  Attachment #51994|0   |1
is obsolete||

--- Comment #2 from Galen Charlton  ---
Created attachment 52105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52105=edit
Bug 16647: update debian/control for 16.*

This patch updates debian/control* to match what
was used for building the 16.05.00 packages, and includes
changes to:

- specify a floor for the Swagger2 version
- add dep on libio-socket-ip-perl, which is needed
  for the package to work on Debian Wheezy
- suggest libwww-youtube-download-perl

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16647] Update debian/control for 16.*

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16647

Galen Charlton  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16617] debian/control is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Galen Charlton  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16647

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16617] debian/control is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Galen Charlton  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=16647   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16617] debian/control is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Galen Charlton  changed:

   What|Removed |Added

 Blocks||16647


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16647
[Bug 16647] Update debian/control for 16.*
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16647] Update debian/control for 16.*

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16647

Galen Charlton  changed:

   What|Removed |Added

 Depends on||16617


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617
[Bug 16617] debian/control is broken
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16647] Update debian/control for 16.*

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16647

Galen Charlton  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=16617   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16647] Update debian/control for 16.*

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16647

Galen Charlton  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16617
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16617] debian/control is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Galen Charlton  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #7 from Galen Charlton  ---
Noting that this needs to be pushed to 16.05.x as well. My patch for bug 16647
deals with the second "EEK".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16636] t/00-load.t warning from C4/External/BakerTaylor.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636

M. Tompsett  changed:

   What|Removed |Added

  Attachment #52069|0   |1
is obsolete||

--- Comment #7 from M. Tompsett  ---
Created attachment 52104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52104=edit
[SIGNED-OFF] Bug 16636: t/00-load.t warning from C4/External/BakerTaylor.pm

Since the tests are expecting an initialize function, the
initialize call was just moved outside of the INIT block.

TEST PLAN
-
1) prove t/00-load.t
   -- warnings about INIT for BakerTaylor
2) prove `git grep -l BakerTaylor | grep [.]t$`
   -- should all run okay
3) apply patch
4) repeat steps 1 and 2
   -- warning should be gone, and everything else run okay
5) run koha qa test tools

Signed-off-by: Srdjan 

Signed-off-by: Florent Mara 

NOTE: Tweaked test plan based on comment #4,
  Added sign off based on comment #6.


Current status: Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16636] t/00-load.t warning from C4/External/BakerTaylor.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636

Florent Mara  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #6 from Florent Mara  ---
Then it is good for me. :-)

The patch behaves as described in the test plan and fixes the warning from
BakerTaylor.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16636] t/00-load.t warning from C4/External/BakerTaylor.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636

--- Comment #5 from M. Tompsett  ---
(In reply to Florent Mara from comment #4)
> I followed the test plan and got the following. 
> 
> Before applying the patch, prove t/00-load.t would output the following
> t/00-load.t .. 1/? Too late to run INIT block at
> /var/koha/Koha/C4/Barcodes/hbyymmincr.pm line 41.
> Too late to run INIT block at /var/koha/Koha/C4/External/BakerTaylor.pm line
> 42.
> 
> After applying the patch, it would still output 1 warning while the comment
> appears to indicate there should be no warnings. 
> t/00-load.t .. 7/? Too late to run INIT block at
> /var/koha/Koha/C4/Barcodes/hbyymmincr.pm line 41.
> t/00-load.t .. ok 
> All tests successful.
> 
> Since the patch focuses on warning from BakerTaylor.pm, I assume it achieves
> its goal, maybe then the test plan needs to be updated.

Yes, the test plan was a cut-and-paste mistake by me. It should be 

TEST PLAN
-
1) prove t/00-load.t
   -- warnings about INIT for BakerTaylor
2) prove `git grep -l BakerTaylor | grep [.]t$`
   -- should all run okay
3) apply patch
4) repeat steps 1 and 2
   -- warning should be gone, and everything else run okay
5) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16636] t/00-load.t warning from C4/External/BakerTaylor.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636

Florent Mara  changed:

   What|Removed |Added

 CC||florent.m...@gmail.com

--- Comment #4 from Florent Mara  ---
I followed the test plan and got the following. 

Before applying the patch, prove t/00-load.t would output the following
t/00-load.t .. 1/? Too late to run INIT block at
/var/koha/Koha/C4/Barcodes/hbyymmincr.pm line 41.
Too late to run INIT block at /var/koha/Koha/C4/External/BakerTaylor.pm line
42.

After applying the patch, it would still output 1 warning while the comment
appears to indicate there should be no warnings. 
t/00-load.t .. 7/? Too late to run INIT block at
/var/koha/Koha/C4/Barcodes/hbyymmincr.pm line 41.
t/00-load.t .. ok 
All tests successful.

Since the patch focuses on warning from BakerTaylor.pm, I assume it achieves
its goal, maybe then the test plan needs to be updated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16335] Refactor OpacHiddenItems

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16335

M. Tompsett  changed:

   What|Removed |Added

  Attachment #52102|0   |1
is obsolete||

--- Comment #3 from M. Tompsett  ---
Created attachment 52103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52103=edit
Bug 16335: Refactor OpacHiddenItems

This creates a filter and adds a test file for that filter.

TEST PLAN
-
1) apply patch
2) prove t/db_dependent/Filter_MARC_OpacHiddenItems.t
3) run koha qa test tools

NOTE: I'd ignore the only once warnings.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104#c18

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16335] Refactor OpacHiddenItems

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16335

M. Tompsett  changed:

   What|Removed |Added

  Attachment #52094|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 52102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52102=edit
Bug 16335: Refactor OpacHiddenItems

This creates a filter and adds a test file for that filter.

TEST PLAN
-
1) apply patch
2) prove t/db_dependent/Filter_MARC_OpacHiddenItems.t
3) run koha qa test tools

NOTE: I'd ignore the only once warnings.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104#c18

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #51501|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

--- Comment #22 from Héctor Eduardo Castro Avalos  
---
(In reply to Aliki Pavlidou from comment #21)
> Sorry guys for the confusion, which status do do you recommend to choose?

Hi Aliki, the status you used before is the right one.

More info about it is at


If you are using one of the Sandboxes, you need to read the step 4 of wiki page
at 

If you are using git you need to read
, notice that this
bug has more than one patch attached to it


Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16243] Add reference manager software (Mendeley and EasyBib) to OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243

--- Comment #24 from Héctor Eduardo Castro Avalos  
---
(In reply to Jonathan Druart from comment #23)
> (In reply to Héctor Eduardo Castro Avalos from comment #22)
> > Still applies...
> 
> No need to CC QAers, the bug report is in the Signed Off queue, it's where
> we are looking at.

Sorry for my mistake, Jonathan. I didn't know.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

--- Comment #21 from Aliki Pavlidou  ---
Sorry guys for the confusion, which status do do you recommend to choose?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16618] 00-load.t prematurely stops all testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16618] 00-load.t prematurely stops all testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52066|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 52101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52101=edit
Bug 16618: 00-load.t prematurely stops all testing

Rather than add/remove regular expressions to skip modules (like bug 9054),
encapsulate the decision logic into a separate function.

Currently there are three libraries which trigger halts:
Koha::NorwegianDB (which was already there)
Koha::ElasticSearch::Indexer
Koha::SearchEngine::Elasticsearch::Search

TEST PLAN
-
1) prove t/00-load.t
   -- should barf horribly on Catmandu stuff
  if not: sudo apt-get remove libcatmandu-marc-perl
  then repeat step.
2) apply patch
3) prove t/00-load.t
   -- should not barf horribly
4) run koha qa test tools

NOTE: The four optional modules for Koha::NorwegianDB are
  listed in the PerlDependencies.pm, while there is
  no mention of Catmandu libraries at all there.
  This may be another bug which needs fixing.

TECH NOTES (for ideas of how to tinker around):
These three things should trigger the three module cases:
sudo apt-get remove libcatmandu-marc-perl
sudo apt-get remove libcatmandu-store-elasticsearch-perl
sudo apt-get remove libconvert-basen-perl

You probably had koha-perldeps installed before, so the following wil mostly
fix:
sudo apt-get install koha-perldeps libcatmandu-marc-perl

And in case you didn't have elastic search stuff installed:
echo deb http://packages.elastic.co/elasticsearch/1.7/debian stable main | sudo
tee /etc/apt/sources.list.d/elasticsearch.list
wget -O- https://packages.elastic.co/GPG-KEY-elasticsearch | sudo apt-key add -
sudo apt-get update

cd ~
wget
http://debian.koha-community.org/koha/otherthings/elasticsearch_deps.tar.gz
tar xvf elasticsearch_deps.tar.gz
cd es_deps
sudo dpkg i lib*
sudo apt-get install -f

Signed-off-by: Srdjan 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16637] Dependency for C4::Tags not listed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16637

Jonathan Druart  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=16455   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16455] TagsExternalDictionary does not work under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455

Jonathan Druart  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=16637   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16618] 00-load.t prematurely stops all testing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618

Jonathan Druart  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #3 from Jonathan Druart  
---
*** Bug 16657 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16657] Add exceptions to t/00-load.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16657

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #4 from Jonathan Druart  
---


*** This bug has been marked as a duplicate of bug 16618 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16637] Dependency for C4::Tags not listed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16637

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||16455


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455
[Bug 16455] TagsExternalDictionary does not work under Plack
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16455] TagsExternalDictionary does not work under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16637


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16637
[Bug 16637] Dependency for C4::Tags not listed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16637] Dependency for C4::Tags not listed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16637

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52061|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 52100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52100=edit
Bug 16637: Dependency for C4::Tags not listed

Added optional dependency, so as to explain why testing
explodes when the Enhanced Content system preference
TagsExternalDictionary is set. It is optional, because not only
does TagsExternalDictionary have to be set, but TagsEnabled
must be 'Allow'.

Also tweaked C4/Tags.pm to ignore TagsExternalDictionary,
if Lingua::Ispell is not installed. A warning is given.

TEST PLAN
-
 1) Set the Enhanced Content system preference
TagsExternalDictionary to /usr/bin/ispell

 2) sudo apt-get install liblingua-ispell-perl
-- should be a new install

 3) prove t/db_dependent/Tags.t
-- should work fine

 4) sudo apt-get remove liblingua-ispell-perl

 5) prove t/db_dependent/Tags.t
-- should explode

 6) Clear the Enhanced Content system preference
TagsExternalDictionary

 7) prove t/db_dependent/Tags.t
-- should work fine

 8) apply patch

 9) prove t/db_dependent/Tags.t
-- should work fine

10) Set the Enhanced Content system preference
TagsExternalDictionary to /usr/bin/ispell

11) prove t/db_dependent/Tags.t
-- should work, with warning.

12) sudo apt-get install liblingua-ispell-perl

13) prove t/db_dependent/Tags.t
-- should work fine

14) run koha qa test tools.

Signed-off-by: Marcel de Rooy 
Post-hackfest hotel Olympia lobby signoff. Kalimera!
Works as expected.
At this moment the Tags.t test does not need the database btw,
but the module should have much more test coverage.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16637] Dependency for C4::Tags not listed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16637

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16243] Add reference manager software (Mendeley and EasyBib) to OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243

--- Comment #23 from Jonathan Druart  
---
(In reply to Héctor Eduardo Castro Avalos from comment #22)
> Still applies...

No need to CC QAers, the bug report is in the Signed Off queue, it's where we
are looking at.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16289] Abbreviated formatting for numbering patterns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52058|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 52098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52098=edit
Bug 16289: Abbreviated formatting for numbering patterns

To test:

1) Go to Serials -> Manage numbering patterns
2) Create .New Numbering Pattern.
3) Type in a name of 'Day, Month, Season' and a numbering formula of '{X} {Y}
{Z}'.
4) Set up the X field as following: add 1, every 1, set back to 1, when more
than 30.
5) Select the formatting for X. There should be six options available instead
of the original three. Use the formatting 'Name of Day (abbreviated)'.
5) Set up the Y field to add 1 every 30 reset back to 1 when more than 12. Use
the formatting option 'Name of month (abbreviated)'.
6) Set up the Z field to add 1 every 90 reset back to 1 when more than 4. Use
the formatting option 'Name of season (abbreviated)'.
8) Select a frequency of 1/day.
9) Select a first issue publication date of Jan 1, 2016.
10) Set X to begin with 5 and have an inner counter of 5. Set Z to begin with 3
and have an inner counter of 10.
11) Click the 'Test Pattern' button.
12) Abbreviated versions of the day, month and season should appear in the test
pattern.

Signed-off-by: sonia bouis 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16289] Abbreviated formatting for numbering patterns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16289] Abbreviated formatting for numbering patterns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289

--- Comment #6 from Jonathan Druart  
---
Created attachment 52099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52099=edit
Bug 16289: Refactore code and add tests

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16651] Notes field blank for 952$z in opac-course-details.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16651

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #52088|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 52097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52097=edit
[SIGNED-OFF]Bug 16651: Notes field blank for 952$z in opac-course-details.pl

This patch changes course reserves to check for item notes form the
course reserve and fallback to itemlevel notes if they are empty

To test:
1 - Enable course reserves
2 - Add some items
3 - Make sure the items have notes at the item level and not at course
reserves
4 - Notes don't display in staff or opac
5 - Apply patch
6 - Notes display in staff and opac
7 - Add notes at course reserves level
8 - These override the item level notes

Signed-off-by: Hector Castro 
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16651] Notes field blank for 952$z in opac-course-details.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16651

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16636] t/00-load.t warning from C4/External/BakerTaylor.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com

--- Comment #3 from Héctor Eduardo Castro Avalos  ---
Srdjan, do you forget to change bug status?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16671] Wrong itemtype picked in HoldsQueue.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16671

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16671] Wrong itemtype picked in HoldsQueue.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16671

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
  Attachment #52078|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16671] Wrong itemtype picked in HoldsQueue.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16671

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 52096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52096=edit
[SIGNED-OFF]Bug 16671: (bug 14828 follow-up) Pick the right itemtypes

Looking at commit aafe73eefb5151454fa8957bf188768324d23955
  Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used
-my @item_types = C4::ItemType->all;
-my @for_loan = grep { $_->{notforloan} == 0 } @item_types
-  or BAIL_OUT("No adequate itemtype");
-my $itemtype = $for_loan[0]->{itemtype};
+my $itemtype = Koha::ItemTypes->search({ notforloan => 1 })->next;
+$itemtype or BAIL_OUT("No adequate itemtype"); #FIXME Should be $itemtype =
$itemtype->itemtype

It seems that the tests expect itemtypes for loan.

Test plan:
  prove t/db_dependent/HoldsQueue.t
should still return green

Signed-off-by: Hector Castro 
Works as advertised. No qa test tool errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14897] Header name mismatch in ./modules/catalogue/detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14897

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14897] Header name mismatch in ./modules/catalogue/detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14897

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52056|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 52095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52095=edit
Bug 14897 - Header name mismatch in ./modules/catalogue/detail.tt

We changed the detail.tt file for staff interface from Publication details to
"Serial enumeration / chronology" to match the cataloguing editor.

Signed-off-by: Joy Nelson 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16670] CGI->param used in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16670

--- Comment #10 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #7)
> I can't recreate the issue on v16.05.00

Because the param 'nopermission' is the last one passed through
$template->param, but the problem might appear later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #5 from M. Tompsett  ---
Also consider the refactor I'm doing on bug 16335. I just put up my filter
work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css and other issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

--- Comment #4 from Héctor Eduardo Castro Avalos  ---
Still applies...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16335] Refactor OpacHiddenItems

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16335

--- Comment #1 from M. Tompsett  ---
Created attachment 52094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52094=edit
Bug 16335: Refactor OpacHiddenItems

This creates a filter and adds a test file for that filter.

TEST PLAN
-
1) apply patch
2) prove t/db_dependent/Filter_MARC_OpacHiddenItems.t
3) run koha qa test tools

NOTE: I'd ignore the only once warnings.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104#c18

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

--- Comment #20 from Jonathan Druart  
---
(In reply to Héctor Eduardo Castro Avalos from comment #19)
> I don't know if I can keep the signed-off, Jonathan?

Depends whether the signoff was intentional or not :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16243] Add reference manager software (Mendeley and EasyBib) to OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||katrin.fisc...@bsz-bw.de

--- Comment #22 from Héctor Eduardo Castro Avalos  
---
Still applies...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16670] CGI->param used in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16670

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16670] CGI->param used in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16670

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16670] CGI->param used in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16670

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #52090|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 52093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52093=edit
Bug 16670: (bug 15823 follow-up) CGI->param should not be called in list
context

Signed-off-by: Jacek Ablewicz 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

--- Comment #19 from Héctor Eduardo Castro Avalos  
---
(In reply to Héctor Eduardo Castro Avalos from comment #18)
> Hi Aliki and Jonathan
> 
> Bug rebased because commit ed449a5b5be4da03443d214de5806f4a0273227b in bug
> 16005

I don't know if I can keep the signed-off, Jonathan?

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16005] Standardize use of icons for delete and cancel operations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16005

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Blocks||16456


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456
[Bug 16456] Add Font Awesome icons to some buttons in Tools module, section
Patrons and circulation
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
 Depends on||16005

--- Comment #18 from Héctor Eduardo Castro Avalos  
---
Hi Aliki and Jonathan

Bug rebased because commit ed449a5b5be4da03443d214de5806f4a0273227b in bug
16005


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16005
[Bug 16005] Standardize use of icons for delete and cancel operations
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

--- Comment #17 from Héctor Eduardo Castro Avalos  
---
Created attachment 52092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52092=edit
Bug 16456: Add Font Awesome icons to tag result

To test goto:
-Tags -> and click in a tag with multiple titles
-A table with titles tagged with the term is presented
-See the new button 'Remove'
-Verify if you can remove tag from a selected title.

Bug rebased because bug 16005

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #51500|0   |1
is obsolete||

--- Comment #16 from Héctor Eduardo Castro Avalos  
---
Created attachment 52091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52091=edit
Bug 16456: Add Font Awesome icons to some buttons in Tools module, section
Patrons and circulation

Add Font Awesome Icons to section Patrons and circulation in Tools module

To test goto:
-Patron list -> my_list_saved -> Add patrons -> Remove selected patrons,
 Clear all, Select all
-Comments -> Approve, Delete, Unapprove
-Tags -> Apply filter(s), Test, Approved, Reject, Select all, Clear all,
 Select all pending. Set syspref TagsModeration to Require.
-Verify that all tools work as expected

NOTE: The Tag and Comments tools has been revised to fit with others
interfaces in Koha.
Bug ammended according with QA comment 5
Bug rebased because bug 16005

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16455] TagsExternalDictionary does not work under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #10 from Brendan Gallagher  ---
Pushed to Master - Should be in the November 2016 Release.  Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16508] User permission "parameters_remaining_permissions Remaining system parameters permissions" does not allow saving systempreferences.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16508

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Brendan Gallagher  ---
Pushed to Master - Should be in the November 2016 Release.  Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16518] opac-addbybiblionumber is not plack safe

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16518

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #4 from Brendan Gallagher  ---
Pushed to Master - Should be in the November 2016 Release.  Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16670] CGI->param used in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16670

Jacek Ablewicz  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16670] CGI->param used in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16670

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #52076|0   |1
is obsolete||

--- Comment #8 from Jacek Ablewicz  ---
Created attachment 52090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52090=edit
Bug 16670: (bug 15823 follow-up) CGI->param should not be called in list
context

Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16670] CGI->param used in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16670

--- Comment #7 from Nick Clemens  ---
I can't recreate the issue on v16.05.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16670] CGI->param used in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16670

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52077|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 52089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52089=edit
[3.22.x] Bug 16670: (bug 15823 follow-up) CGI->param should not be called in
list context

This patch will remove the following warning "Staff members
are not allowed to discharge borrowers, nor borrowers to request a
discharge." in 3.22.x branches

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16651] Notes field blank for 952$z in opac-course-details.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16651

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
Version|3.20|master
   Assignee|oleon...@myacpl.org |n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16651] Notes field blank for 952$z in opac-course-details.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16651

--- Comment #1 from Nick Clemens  ---
Created attachment 52088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52088=edit
Bug 16651 - Notes field blank for 952$z in opac-course-details.pl

This patch changes course reserves to check for item notes form the
course reserve and fallback to itemlevel notes if they are empty

To test:
1 - Enabvle course reserves
2 - Add some items
3 - Make sure the items have notes at the item level and not at course
reserves
4 - Notes don't display in staff or opac
5 - Apply patch
6 - Notes display in staff and opac
7 - Add notes at course reserves level
8 - These override the item level notes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16651] Notes field blank for 952$z in opac-course-details.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16651

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16670] CGI->param used in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16670

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16673] Discharge message appearing incorrectly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16673

Jacek Ablewicz  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED
 CC||a...@biblos.pk.edu.pl

--- Comment #1 from Jacek Ablewicz  ---


*** This bug has been marked as a duplicate of bug 16670 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16670] CGI->param used in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16670

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #5 from Jacek Ablewicz  ---
*** Bug 16673 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16673] New: Discharge message appearing incorrectly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16673

Bug ID: 16673
   Summary: Discharge message appearing incorrectly
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

I don't know how to trigger this, but on a partner's site we are seeing the
message "Staff members are not allowed to discharge borrowers, nor borrowers to
request a discharge." appear whenever the staff are trying to checkout.

I suspect the problem is here:
[% IF ( nopermission ) %]
Staff members are not allowed to discharge
borrowers, nor borrowers to request a discharge.
[% END %]

No permission just checks the page params, but 'nopermission' is only set from
trying to access discharge.pl with the 'useDischarge' syspref set to 'Don't
allow'

It appears as if the 'nopermission' is getting incorrect values from somewhere

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16165] Include link to ILS-DI documentation page in ILS-DI system preference

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16165

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #6 from Jonathan Druart  
---
As there is no easy way to display a link to the opac page, this patch is
acceptable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16165] Include link to ILS-DI documentation page in ILS-DI system preference

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16165

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16165] Include link to ILS-DI documentation page in ILS-DI system preference

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16165

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52050|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 52087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52087=edit
Bug 16165 - Include link to ILS-DI documentation page in ILS-DI system
preference

There is no clue in the system preference about the nice ILS-DI documentation
once you turn it on. We should include a note and the link, similar to how we
do it for the web self checkout.

Test plan:
Syspreference ILS-DI should now include URL in description.

Signed-off-by: Mirko Tietgen 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12509] Untranslatable "Restriction added by overdues process"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509

alonso morgane  changed:

   What|Removed |Added

 CC||morgane.alo...@biblibre.com
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16662] Letsencrypt II: Return of the cryptosaurus. (make it work for existing instances)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16662

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

--- Comment #15 from Jonathan Druart  
---
Aliki, could you confirm that you signed off the patches on purpose?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #14 from Jonathan Druart  
---
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16633] Translatability: Issues in tags/review.tt (sentence splitting)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16633

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52007|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 52086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52086=edit
Bug 16633: Translatability: Issues in tags/review.tt (sentence splitting)

This patch fixes translatability issues in
koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
(isolated words by sentence splitting).

To test:
- Review code and verify that changes make sense.

Signed-off-by: Rocio Dressler 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16657] Add exceptions to t/00-load.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16657

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
I am not sure it's a good idea to remove all those files from this test.
Which are the non-mandatory modules?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/