[Koha-bugs] [Bug 16795] Patron categories: Accept integers only for enrolment period and age limits

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795

--- Comment #1 from Marc Véron  ---
Created attachment 52677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52677&action=edit
Bug 16795 - Patron categories: Accept integers only for enrolment period and
age limits

To test:
- Apply patch
- Clear browser cache
- Go to Home > Administration > Patron categories
- Create or edit a category
- Verify that field 'In months', 'Age required' and
  'Upperage limit' accept digits only

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16795] Patron categories: Accept integers only for enrolment period and age limits

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16795] Patron categories: Accept integers only for enrolment period and age limits

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16797] errors in UNIMARC complet sample authorities

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797

Fridolin SOMERS  changed:

   What|Removed |Added

 Depends on||11586


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586
[Bug 11586] Better default framework for UNIMARC
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16797] errors in UNIMARC complet sample authorities

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797

Fridolin SOMERS  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16797] New: errors in UNIMARC complet sample authorities

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797

Bug ID: 16797
   Summary: errors in UNIMARC complet sample authorities
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The SQL UNIMARC complet sample authorities fails :
installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql

Some lines of auth_subfield_structure use an authtypecode not existing in lines
of authtypecode : AUTTIT and FA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11586] Better default framework for UNIMARC

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||16797


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797
[Bug 16797] errors in UNIMARC complet sample authorities
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14060] Remove readonly on date inputs

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

--- Comment #23 from Marc Véron  ---
For the records: jQuery Validation Plugin's date method is no option, it would
consider 30/30/2008 as a valid date.
"Use dateISO instead or one of the locale specific methods (in localizations/
and additional-methods.js)." See: https://jqueryvalidation.org/date-method

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

--- Comment #24 from Marc Véron  ---
For the records:

koha-tmpl/intranet-tmpl/prog/js/members.js
(...)
// this function checks id date is like DD/MM/
function CheckDate(field)
(...)

Used in:

koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
for fields dateenrolled and dateexpiry
(only if dateformat == "metric" )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16770] Remove wrong uses of Memoize::Memcached

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #52640|0   |1
is obsolete||

--- Comment #10 from Jacek Ablewicz  ---
Created attachment 52678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52678&action=edit
Bug 16770: Remove 2 other occurrences of libmemoize-memcached-perl

Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16798] New: automatic_renewals.pl should run before overdues and fines are generated

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16798

Bug ID: 16798
   Summary: automatic_renewals.pl should run before overdues and
fines are generated
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Unless an auto_renew item's circ rule has a "no renewal before" line set, it
will only auto-renew at the point where the item is technically overdue.
However, automatic_renewal.pl in etc/cron.daily/koha-common is set to run
*after* all those cronjobs!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16798] automatic_renewals.pl should run before overdues and fines are generated

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16798

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16798] automatic_renewals.pl should run before overdues and fines are generated

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16798

Kyle M Hall  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16798] automatic_renewals.pl should run before overdues and fines are generated

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16798

--- Comment #1 from Kyle M Hall  ---
Created attachment 52679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52679&action=edit
Bug 16798 - automatic_renewals.pl should run before overdues and fines are
generated

Unless an auto_renew item's circ rule has a "no renewal before" line
set, it will only auto-renew at the point where the item is technically
overdue. However, automatic_renewal.pl in etc/cron.daily/koha-common is
set to run *after* all those cronjobs!

Test Plan:
1) On a package installation, set up an item to auto_renew with no
   "no renewal before" rule.
2) On the morning it is autorenewed it should also have a fine
3) Change the cronjob order to that of this patch
4) Repeat step 1
5) On the morning it is autorenewed it should not have a fine

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16797] errors in UNIMARC complet sample authorities

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16797] errors in UNIMARC complet sample authorities

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 52680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52680&action=edit
Bug 16797 - errors in UNIMARC complet sample authorities

The SQL UNIMARC complet sample authorities fails :
installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql

Some lines of auth_subfield_structure use an authtypecode not existing in lines
of authtypecode : AUTTIT, SAUT, SCO and STU.
Also, I have merged lines refering to authtypecode FA and FAM.

Test plan :
- On a UNIMARC database :
- clear auth tables :
mysql> delete from auth_subfield_structure;
mysql> delete from auth_tag_structure;
mysql> delete from auth_types;
- import sql file :
mysql <
installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql
=> Without patch you get error :
ERROR 1452 (23000) at line 1132: Cannot add or update a child row: a foreign
key constraint fails (`koha`.`auth_subfield_structure`, CONSTRAINT
`auth_subfield_structure_ibfk_1` FOREIGN KEY (`authtypecode`) REFERENCES
`auth_types` (`authtypecode`) ON DELETE CASCADE ON UPDATE CASCADE)
=> With patch no errors :
> select distinct(authtypecode) from auth_subfield_structure;
+--+
| authtypecode |
+--+
|  |
| CO   |
| CO_UNI_TI|
| FAM  |
| GENRE/FORM   |
| NAME_COL |
| NP   |
| PA   |
| SAUTTIT  |
| SNC  |
| SNG  |
| TM   |
| TU   |
+--+
13 rows in set (0.00 sec)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

Lari Taskula  changed:

   What|Removed |Added

 CC||la...@student.uef.fi

--- Comment #11 from Lari Taskula  ---
Patch apply failed because of Bug 13903 has been pushed to master and changed
specification files. Rebasing on master. Also fixing the following things in
patches:
- "Bug 15165 - Add API route to edit accoulines" title typo:
  accoulines->accountlines
- definitions/amountpayed.json => definitions/amountpaid.json
  (also payed => paid where ever it existed)
- set amountpaid-object type from integer to number in order to make
  amountpayment with decimal value as well.
- Test plans missing. Adding them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

Lari Taskula  changed:

   What|Removed |Added

  Attachment #50189|0   |1
is obsolete||

--- Comment #12 from Lari Taskula  ---
Created attachment 52681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52681&action=edit
Bug 15165 - Add API route to list accountlines

GET /accountlines  (list)
GET /accountlines?borrowernumber=X (list)

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission updatecharges.
2. Go to http://yourlibrary/api/v1/accountlines?borrowernumber=XXX (replace
   XXX with a borrowernumber that has accountlines) and check you receive
   correct data
3. Go to http://yourlibrary/api/v1/accountlines and check that you receive
   all accountlines
4. Run unit tests in t/db_dependent/api/v1/accountlines.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

--- Comment #13 from Lari Taskula  ---
Created attachment 52682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52682&action=edit
Bug 15165 - Add API route to edit accountlines

PUT /accountlines/{accountlines_id} (edit)

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission updatecharges.
2. Send PUT request to http://yourlibrary/api/v1/accountlines/YYY
   where YYY is one of your accountlines_id. See the body definition
   in definitions/editAccountlineBody.json and use this in your PUT request.
3. Run unit tests in t/db_dependent/api/v1/accountlines.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

Lari Taskula  changed:

   What|Removed |Added

  Attachment #50790|0   |1
is obsolete||

--- Comment #14 from Lari Taskula  ---
Created attachment 52683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52683&action=edit
Bug 15165 - Add API routes to pay accountlines

PUT /accountlines/(:accountlines_id)/payment (pay towards accountline)
PUT /accountlines/(:borrowernumber)/amountpayment(pay towards borrower)
PUT /accountlines/(:accountlines_id)/partialpayment  (pay accountline
partially)

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission updatecharges.
2. Create a fine to any patron and get the accountlines_id.
3. Send PUT request to http://yourlibrary/api/v1/accountlines/YYY/payment
   without body where YYY is the accountlines_id you created in step 2.
4. Check that the accountline that you created in step 2 is paid.
5. Create two payments with amount 5.00 (with no other outstanding
payments)
6. Send PUT request to
   http://yourlibrary/api/v1/accountlines/ZZZ/amountpayment with body
   defined in definitions/partialpayAccountlineBody.json. Replace ZZZ with
   the borrowernumber that you created two fines to. Set amount to 10.
7. Check that the two accountlines are paid.
8. Repeat step 2.
9. Send PUT request to
   http://yourlibrary/api/v1/accountlines/YYY/partialpayment with body
   defined in definitions/partialpayAccountlineBody.json. Replace YYY with
   the accountlines_id you created in step 8. Set amount to half of the
   amount of fine you created in step 8.
10. Check that the fine is still outstanding with half of the original
amount.
11. Run unit tests at t/db_dependent/api/v1/accountlines.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

Lari Taskula  changed:

   What|Removed |Added

  Attachment #50190|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

Lari Taskula  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #15 from Lari Taskula  ---
(In reply to Andreas Hedström Mace from comment #10)
> Created attachment 50790 [details] [review]
> It is not possible to pay specified/partial amounts (for one or more
> accountlines).
Maybe I misunderstood the problem, but doesn't this do it:
  PUT /accountlines/123/partialpayment
  {"amount": 5.00, "description": "payment description"} 
Or pay payment with specific amount to borrower:
  PUT /accountlines/:borrowernumber/amountpayment
  { "amount": 5, "description": "payment description" }

Anyway, comments to this bug. I think some fixes are needed.

- Payments should be POST instead of PUT (PUT is idempotent, but
  making multiple payments has different effect than sending just one)
- If patron has amountoustanding 0, payment is still possible. 
  Should we return an error instead? Also the same should be considered
  when making a payment bigger than current amountoutstanding.
- /accountlines/:borrowernumber/amountpayment is confusing because of
  :borrowernumber. How about /accountlines/amountpayment?borrowernumber=X
- Do you think it would be useful to return total and currency? e.g.
  GET /accountlines?borrowernumber=1
  {
"total": 100.00,
"currency": "USD",
"rows": [
  {
// accountline-object with amountoutstanding 25,
// accountline-object with amountoutstanding 60,
// accountline-object with amountoutstanding 15
  }
]
  }

I will switch this back to "In Discussion".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

--- Comment #48 from Jacek Ablewicz  ---
(In reply to Julian Maurice from comment #47)
> Patches pushed to 3.22.x, will be in 3.22.8

Hi Julian,

With Bug 16044 pushed for 3.22.8, some follow-ups of this report may be needed
in 3.22.x branch too (Bug 16229, Bug 16412, Bug 16221).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

--- Comment #16 from Lari Taskula  ---
(In reply to Lari Taskula from comment #15)
>   "rows": [
> {
>   // accountline-object with amountoutstanding 25,
>   // accountline-object with amountoutstanding 60,
>   // accountline-object with amountoutstanding 15
> }
>   ]
...should be of course array of accountline-objects, sorry for the typo!
"rows": [
 // accountline-object with amountoutstanding 25,
 // accountline-object with amountoutstanding 60,
 // accountline-object with amountoutstanding 15
]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16794] Revise layout for Admistration > Categories

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

--- Comment #3 from Owen Leonard  ---
I disagree that the links should be in a menu. I think in all other cases if
there are only two actions we display actions as buttons. It's when there are
three or more actions that we use a menu.

I think one could argue that this page should be an exception because of the
size of the table, but I would counter that perhaps we should trim down the
number of columns displayed instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16795] Patron categories: Accept integers only for enrolment period and age limits

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16795] Patron categories: Accept integers only for enrolment period and age limits

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795

Owen Leonard  changed:

   What|Removed |Added

  Attachment #52677|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 52684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52684&action=edit
[SIGNED-OFF] Bug 16795 - Patron categories: Accept integers only for enrolment
period and age limits

To test:
- Apply patch
- Clear browser cache
- Go to Home > Administration > Patron categories
- Create or edit a category
- Verify that field 'In months', 'Age required' and 'Upperage limit'
  accept digits only

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15762] Fields editable in PatronSelfRegistrationBorrowerUnwantedField may be hidden by BorrowerUnwantedField

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15762

--- Comment #5 from Barton Chittenden  ---
(In reply to Owen Leonard from comment #4)
> I think a good solution would be to move the configuration of
> BorrowerUnwantedField and PatronSelfRegistrationBorrowerUnwantedField out of
> system preferences and into its own interface where a table of borrower
> table columns is shown and a checkbox can be selected for both "Show in
> OPAC" and "Show in staff client." Then JavaScript logic could be applied to
> prevent incorrect combinations.
> 
> This interface could save the selected data to the system preferences
> automatically. This would be a better user experience all around.

I really like this idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

--- Comment #17 from Lari Taskula  ---
(In reply to Lari Taskula from comment #15)
> Anyway, comments to this bug. I think some fixes are needed.
One thing that I forgot to mention. I think it's a must to have just one
endpoint for making a payment towards an accountline, otherwise it would be
very confusing. I know this probably stems from C4::Accounts having multiple
subroutines for making a payment, but Bug 15894 is working on unifying them as
one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12509] Untranslatable "Restriction added by overdues process"

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12509] Untranslatable "Restriction added by overdues process"

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509

Owen Leonard  changed:

   What|Removed |Added

  Attachment #52634|0   |1
is obsolete||

--- Comment #7 from Owen Leonard  ---
Created attachment 52685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52685&action=edit
[SIGNED-OFF] Bug 12509 - Fix Untranslatable Restriction added by overdues
process

Changes the value of the "comment" column in "borrower_debarments" table
from "Restriction added by overdues process -mm-dd hh:mm:ss" to
"OVERDUE_PROCESS -mm-dd hh:mm:ss" in the overdue_notices.pl. Then in
the templates "moremember.tt", "circulation.tt", "memberentrygen.tt",
"opac-reserve.tt" and "opac-user.tt" the value of "comment" is
check, if it's an automatical comment due to overdue process it'll
write "Restriction added by overdues process -mm-dd hh:mm:ss",
then if there is a customizable comment it will be written without
modification. Like this, the comment "Restriction added by overdues
process" is written in the po files and can be translated later.

To test:
1) create a patron with automatical restriction due to overdue process;
2) apply patch;
3) run misc/cronjobs/overdue_notices.pl;
4) verify if the comment "Restriction added by overdues process" is well
   written and translatable on the following page :
- opac patron home page (opac-user.tt);
- opac item reservation page (opac-reserve.tt);
- pro patron page (moremember.tt);
- reservation item for a patron (circulation.tt, memberentrygen.tt);
5) try to translate the comment in po files;
6) sign off.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

--- Comment #49 from Julian Maurice  ---
(In reply to Jacek Ablewicz from comment #48)
> (In reply to Julian Maurice from comment #47)
> > Patches pushed to 3.22.x, will be in 3.22.8
> 
> Hi Julian,
> 
> With Bug 16044 pushed for 3.22.8, some follow-ups of this report may be
> needed in 3.22.x branch too (Bug 16229, Bug 16412, Bug 16221).

Thanks, I will push them ASAP

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12509] Untranslatable "Restriction added by overdues process"

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509

--- Comment #8 from Owen Leonard  ---
Your patch still didn't have accurate author information, but I revised it
(correctly, I hope) when I signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12509] Untranslatable "Restriction added by overdues process"

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509

--- Comment #9 from alonso morgane  ---
Thank you so much! The author informations are correct.
I didn't know why the author informations weren't the good ones because I
configured my git and I changed it when I squashed my two patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16799] New: header_search is too wide when IntranetCatalogSearchPulldown is enabled.

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16799

Bug ID: 16799
   Summary: header_search is too wide when
IntranetCatalogSearchPulldown is enabled.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To re-create:

Apply patches in bug Bug 14902.

1/ Set the system preference IntranetCatalogSearchPulldown to 'Show'.
2/ Resize the browser to less than 1000px
3/ Navigate to Koha main page
4/ Click 'Search the catalog', notice that the search bar wraps below the koha
logo.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16799] header_search is too wide when IntranetCatalogSearchPulldown is enabled.

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16799

--- Comment #1 from Barton Chittenden  ---
Created attachment 52686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52686&action=edit
Checkout bar -- wrapped correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16799] header_search is too wide when IntranetCatalogSearchPulldown is enabled.

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16799

--- Comment #2 from Barton Chittenden  ---
Created attachment 52687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52687&action=edit
Search bar -- wrapped below koha logo.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16799] header_search is too wide when IntranetCatalogSearchPulldown is enabled.

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16799

Owen Leonard  changed:

   What|Removed |Added

 Depends on||14902


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14902
[Bug 14902] Add qualifier menu to staff side "Search the Catalog"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14902] Add qualifier menu to staff side "Search the Catalog"

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14902

Owen Leonard  changed:

   What|Removed |Added

 Blocks||16799


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16799
[Bug 16799] header_search is too wide when IntranetCatalogSearchPulldown is
enabled.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #51778|0   |1
is obsolete||
  Attachment #51779|0   |1
is obsolete||
  Attachment #51780|0   |1
is obsolete||
  Attachment #51781|0   |1
is obsolete||
  Attachment #51782|0   |1
is obsolete||
  Attachment #51783|0   |1
is obsolete||

--- Comment #184 from Kyle M Hall  ---
Created attachment 52688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52688&action=edit
Bug 14610 - Add ability to place article requests in Koha - Update database

Article Requests are somewhat similar to holds, but are not requests for
an item to check out. Instead, article requests are requests for a
photocopy of a particular section of a book ( most often ). This is very
common in academic libraries where researchers may request a copy of a
single article found in a journal.

This patch set adds the ability to place article requests in Koha. It
allows the control of what can be requested via the circulation rules.
Since article requests of electronic resources are not outside the realm
of possibility, the feature will check not only the items for
requstability, but the record itself as well ( i.e. both items.itype and
biblio.itemtype ).

Article requests can be placed for patrons from the opac and staff
intranet and can be viewed in most areas where holds are viewed ( e.g.
patron details, record details, etc ).

There is a script to view article requests in progress within the
circulation module. Article requests can be Open ( i.e. new ), In
Processing, Completed, or Canceled. The status of a given request can be
updated from this script.

Test Plan:
1) Apply the patch set
2) Run updatedatabase.pl
3) Enable the system preference ArticleRequests
4) Set up some required fields in:
ArticleRequestsMandatoryFields
ArticleRequestsMandatoryFieldsItemsOnly
ArticleRequestsMandatoryFieldsRecordOnly
5) Edit your circ rules, set article requests to 'yes' for something
6) Test the ability to add an article request from the opac ( required fields
enforced )
7) Test the ability to add an article request from the staff interface (
required fields no enforced )
8) Note you can choose item level or record level requests
9) Change the rule to "record only"
10) Repeat 6 and 7
11) Note you cannot choose items
12) Change the rule to "item only"
13) Repeat 6 and 7
14) Note you must choose an item
15) Note that the 'new request' message is queued for each new request
16) Browse to /cgi-bin/koha/circ/article-requests.pl
17) Note requests are split by pickup branch
18) Test slip printing via the "Print slip" action
19) Process request vai "Process request" action
20) Note an email notice is queued for patron
21) Refresh /cgi-bin/koha/circ/article-requests.pl
22) Note request has moved to "processing" tab.
23) Complete request with "Complete request" action
24) Note message is queued for patron
25) Cancel a request, add cancelation note.
26) Note message is queued for patron

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #185 from Kyle M Hall  ---
Created attachment 52689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52689&action=edit
Bug 14610 - Add and update modules

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #186 from Kyle M Hall  ---
Created attachment 52690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52690&action=edit
Bug 14610 - Add and update scripts

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #187 from Kyle M Hall  ---
Created attachment 52691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52691&action=edit
Bug 14610 - Add unit tests

Signed-off-by: Kyle M Hall 

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #189 from Kyle M Hall  ---
Created attachment 52693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52693&action=edit
Bug 14610 - Update Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #188 from Kyle M Hall  ---
Created attachment 52692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52692&action=edit
Bug 14610 - Update opac.css via less

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a rental charge

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796

--- Comment #3 from Sally Healey  
---
Hi Marc,

This is great, and definitely works - but on the sandbox I used, [%
ISSUE.description %] didn't call anything back, which led to this rather
confusing description on the renewal screen:

Renew Fee for 5.00 (4 of 5 renewals remaining)

Could:

Fee for [% ISSUE.description %] [% ISSUE.renewalfee |
$Price %]

be altered slightly to say something like:

NOTE:  A charge of [% ISSUE.renewalfee | $Price %]
will be added.

which would generate:

Renew NOTE:  A charge of 5.00 will be added.

I'm not sure what others think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete holds

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

Lari Taskula  changed:

   What|Removed |Added

 CC||la...@student.uef.fi

--- Comment #22 from Lari Taskula  ---
There seems to be no requirement for permissions to use these routes?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566

Owen Leonard  changed:

   What|Removed |Added

  Attachment #51902|0   |1
is obsolete||

--- Comment #7 from Owen Leonard  ---
Created attachment 52694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52694&action=edit
Bug 16566 [Revised] 'Print slip' button formatting inconsistent

This patch modifies the style of some "print slip" links on the checkin
page to make them consistent with other buttons shown in dialogs.

This patch also removes the use of "onclick" in some places in favor of
defining events in the JavaScript.

To test apply the patch and go to Circulation -> Check in.

- Check in an item which belongs at another branch. You should see a
  dialog which asks the user to transfer the item. Confirm that the
  "Print slip" button looks correct and works correctly.

- Check in the same item again. You should see a different dialog which
  has both a "Print transfer slip" and "Cancel transfer" button. The
  "Print transfer slip" button should look correct and work correctly.

- Check in an item which is part of a rotating collection. (Or, if Bug
  16570 is still open, check in any item) You should see a dialog which
  notifies you that the item is part of a rotating collection. The
  "Print slip" button in this dialog should look correct and work
  correctly.

Followed test plan. Buttons appear as expected.
Signed-off-by: Marc Véron 

Revision following QA: Removed redundant class attribute from the print
button tested in step 1.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16708] ElasticSearch - Fix authority reindexing

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16708

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16708] ElasticSearch - Fix authority reindexing

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16708

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52226|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 52695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52695&action=edit
Bug 16708: Fix authority reindex for ElasticSearch

The changes made to Koha::Authority has not been correctly fixed.
The code of Koha::Authority has been moved bo
Koha::MetadataRecord::Authority by bug 15380.

Test plan:
  perl misc/search_tools/rebuild_elastic_search.pl -a -v
should success

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16708] ElasticSearch - Fix authority reindexing

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16708

--- Comment #4 from Nick Clemens  ---
Created attachment 52696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52696&action=edit
Bug 16708 - (QA followup) Fix pod copy/paste error

Change Koha::Authority to Koha::MetadataRecord::Authority

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16794] Revise layout for Admistration > Categories

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Categories

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #52674|0   |1
is obsolete||
  Attachment #52676|0   |1
is obsolete||

--- Comment #4 from Héctor Eduardo Castro Avalos  ---
Created attachment 52697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52697&action=edit
Bug 16794: Revise layout for Admistration > Patron categories

Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links

To test
- Go to Administration -> Patron categories
 - Confirm that two button appear instead of links for "Edit" and "Delete"
 - Edit an existing category and confirm that works as expected
 - Delete a category and confirm that works properly.

Patch fix it according with QA comment 3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Categories

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

Summary|Revise layout for   |Revise layout for
   |Admistration > Categories   |Admistration > Patron
   ||categories

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16612] Cannot set "Until date" for "Enrollment period" for Patron Categories

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16612

Eric Phetteplace  changed:

   What|Removed |Added

 CC||ephettepl...@cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6069] Multiple level budget list on suggestions

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6069

Owen Leonard  changed:

   What|Removed |Added

   Severity|normal  |enhancement
Version|3.4 |master
   Priority|PATCH-Sent (DO NOT USE) |P5 - low

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9626] can't pay FU fines without messing things up

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9626

--- Comment #2 from Owen Leonard  ---
Is this bug still valid in master? If so, please update the version
information.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13048] Serial Error when NULL date encountered

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13048

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #4 from Owen Leonard  ---
I'm going to assume this is no longer an issue since no follow-up information
has been provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16801] Include Font Awesome Incons to check/unchek all in Administration > Library transfer limits

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16801

--- Comment #1 from Héctor Eduardo Castro Avalos  ---
Created attachment 52698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52698&action=edit
16801: Include Font Awesome Incons to check/unchek all in Administration >
Library transfer limits

For purpose to uniformity and leave just one entry in .po files,
this patch change: Check all/Uncheck all -> to -> Select all/Clear all.
Also added Font Awesome icons.

To test:
-Go to Administration > Library transfer limits
-Notice about Check all/Uncheck all for "For all items types" and
 "Policy for:"
-Apply patch and refresh the screen
-Notice about the new Select all/Clear all links with their icons
-Confirm that all links work as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16801] Include Font Awesome Incons to check/unchek all in Administration > Library transfer limits

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16801

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16801] New: Include Font Awesome Incons to check/unchek all in Administration > Library transfer limits

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16801

Bug ID: 16801
   Summary: Include Font Awesome Incons to check/unchek all in
Administration > Library transfer limits
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: hector.hecax...@gmail.com
  Reporter: hector.hecax...@gmail.com
QA Contact: testo...@bugs.koha-community.org

For purpose to uniformity and leave just one entry in .po files, this patch
change: Check all/Uncheck all -> to -> Select all/Clear all. Also added Font
Awesome icons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||hector.hecax...@gmail.com

--- Comment #16 from Héctor Eduardo Castro Avalos  
---
Applying: Bug 15758: Koha::Libraries - Remove GetBranchName
fatal: sha1 information is lacking or useless (C4/Circulation.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 15758: Koha::Libraries - Remove GetBranchName

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16801] Include Font Awesome Incons to check/unchek all in Administration > Library transfer limits

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16801

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org,
   ||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15485] Allow choosing different XSLTs for lists

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 52701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52701&action=edit
Bug 15485: (QA followup) Simplify logic and use *ResultsDisplay value during
upgrade

This patch makes the new sysprefs work as the previously defined. Instead of
falling back
to what *ResultsDisplay is set, it now has its own 'default' (that still
defaults to the
*Results*.xslt).

The default values are set to 'default' as the rest of XSLT-related sysprefs,
and the upgrade
picks whatever is set in OPACXSLTResultsDisplay and XSLTResultsDisplay so
current behaviour
is preserved.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16801] Include Font Awesome Incons to check/unchek all in Administration > Library transfer limits

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16801

Marc Véron  changed:

   What|Removed |Added

  Attachment #52698|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 52702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52702&action=edit
16801: Include Font Awesome Incons to check/unchek all in Administration >
Library transfer limits

For purpose to uniformity and leave just one entry in .po files,
this patch change: Check all/Uncheck all -> to -> Select all/Clear all.
Also added Font Awesome icons.

To test:
-Go to Administration > Library transfer limits
-Notice about Check all/Uncheck all for "For all items types" and
 "Policy for:"
-Apply patch and refresh the screen
-Notice about the new Select all/Clear all links with their icons
-Confirm that all links work as expected

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16801] Include Font Awesome Incons to check/unchek all in Administration > Library transfer limits

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16801

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9227] items in transit can be checked out without warning

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9227

Owen Leonard  changed:

   What|Removed |Added

Version|3.8 |master
   Severity|major   |normal

--- Comment #3 from Owen Leonard  ---
I suspect that this is not a high priority bug for a lot of folks. My library,
for instance, give priority to the patron checking out the item. If the an
in-transit item made it to the shelf by mistake that's not the patron's fault.

(In reply to Rendi from comment #2)

> In addition, once the item is checked
> out rather than sent in transit, it becomes almost like an item specific
> hold

This I agree is a problem, and should probably be addressed as a separate bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13191] Null borrowernumber in reserves table

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13191

--- Comment #1 from Owen Leonard  ---
I don't see any instances in the reserves table, but I see many in old_reserves
(v3.18.x). I wonder if that is the same problem.

What is the effect of having holds with no borrowernumber?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a rental charge

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796

--- Comment #4 from Marc Véron  ---
Hi Sally,

Thank you for testing and your comments.

I tested again with a item type BK "Books" with a charge of 5.01, checked out
an item of this type to a patron, and I get the following in OPAC (Renew is a
link in blue):

 Renew Fee for Books 5.01 (10 of 10 renewals remaining)

Hmm, why does it work here and not in your system? - What do you have as item
type?

Regarding the text changes:

I think it makes sense to say something about the item type, since the charge
can be different for each item type.

So maybe something like:
NOTE: A charge of 5.00 for Books will be added.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13693] On order items in course reserves show incorrect status in the OPAC

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13693

Owen Leonard  changed:

   What|Removed |Added

Summary|course reserve status isn't |On order items in course
   |correct |reserves show incorrect
   ||status in the OPAC
Version|3.16|master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Marc Véron  changed:

   What|Removed |Added

  Attachment #52697|0   |1
is obsolete||

--- Comment #5 from Marc Véron  ---
Created attachment 52703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52703&action=edit
Bug 16794: Revise layout for Admistration > Patron categories

Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links

To test
- Go to Administration -> Patron categories
 - Confirm that two button appear instead of links for "Edit" and "Delete"
 - Edit an existing category and confirm that works as expected
 - Delete a category and confirm that works properly.

Patch fix it according with QA comment 3

Buttons appear now as requested in comment #3 (2 buttons, no action menu)
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16799] header_search is too wide when IntranetCatalogSearchPulldown is enabled.

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16799

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16798] automatic_renewals.pl should run before overdues and fines are generated

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16798

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Resolution|--- |DUPLICATE
 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 11144 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

Katrin Fischer  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #33 from Katrin Fischer  ---
*** Bug 16798 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7627] Editing of invoice number

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7627

Eric Phetteplace  changed:

   What|Removed |Added

 CC||ephettepl...@cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15259] Formatting spine labels

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15259

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3679] Specify "from" address when emailing a list or cart from opac

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3679

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5471] Quotes in tags cause moderation approval/rejection to fail

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5471

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=9814

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9814] KohaAdminEmailAddress syspref webpage field doesn't handle double quotes

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9814

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=5471
 CC||ve...@veron.ch

--- Comment #1 from Marc Véron  ---
Still valid on current master. 

After entering something like "The Library" , saving
and refreshing the page, I get an empty field for KohaAdminEmailAddress,
followed by some html snippet:

Use [ ] " autocomplete="off" /> as the email address for the administrator
of Koha.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16775] install.pl error: BLOB, TEXT, GEOMETRY or JSON column 'defaultvalue' can't have a default value

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16775

--- Comment #9 from Pallavi Tomar  ---
mysql server version is 5.7.12

(In reply to Katrin Fischer from comment #8)
> Thx for updating the bug! 
> 
> Which version of MySQL are you using? I assume that is the problem since the
> newest Koha is known not to work with new versions of MySQL as included in
> Ubuntu 16.04 yet.
> 
> There is a work done to resolve this problem, see:
> bug 16573, bug 16554, bug 16664

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7

2016-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Pallavi Tomar  changed:

   What|Removed |Added

 CC||pallavi.to...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/