[Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a potential security issue when running from git

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16922

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16922] Add RewriteRule to apache-shared-intranet for dev package installs

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16922

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=9949

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16922] Add RewriteRule to apache-shared-intranet for dev package installs

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16922

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16922] Add RewriteRule to apache-shared-intranet for dev package installs

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16922

--- Comment #1 from Marcel de Rooy  ---
Created attachment 53410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53410&action=edit
Bug 16922: Add RewriteRule to apache-shared-intranet for dev package installs

As a simple alternative to the solution in bug 9949 or just as an
additional measure, this patch adds a rewrite rule for intranet
in order to intercept potential misuse of perl scripts that could be
reached on a dev package install via the cgi-bin/koha scriptalias.

It simply rewrites them to the nonexistent "notfound", resulting in a
regular 404 error.

The rewrite rule does not harm regular installs and is just a little extra
step in securing a dev install. You should have more security measures in
place to secure your staff client.

QA Note: Although a rewrite rule may not be our first choice, this one
rule is more elegant and easier to maintain than e.g. a whole bunch of
aliases.

Note: This patch should have a regular and a dev install signoff.

Test plan:
[1] Make sure that this rewrite rule is inserted in your actual apache
config via /etc/koha/apache-shared-intranet.conf. Restart Apache.
[2] For regular package installs:
Try one of the URLs in step 3.
Verify that your staff client still operates as usual. Test a few
URLs inside some modules.
[3] For dev installs:
Try some URLs like below.
Expect 404 errors only, not 500s. If you do not see a 404, go back!
/misc/stage_file.pl
/t/db_dependent/default_search_class.pl
/installer/data/mysql/updatedatabase.pl
/Makefile.PL
[4] Do you see an additional directory to add to the regex? Please report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16856] unimarc plugin 4xx template noise

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16856

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16856] unimarc plugin 4xx template noise

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16856

Marc Véron  changed:

   What|Removed |Added

  Attachment #53121|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 53409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53409&action=edit
Bug 16856 - unimarc plugin 4xx template noise

While fixing 10148, prove t/db_dependent/FrameworkPlugin.t was
run. This triggers UNIMARC 4xx plugin noise.

The issue is that itypeloo.selected is not a property that
exists in the hash parameter to the template.

git grep cataloguing/value_builder/unimarc_field_4XX.tt | grep -v [.]po:
The above was used to confirm that there is only one file which
affects that template: cataloguing/value_builder/unimarc_field_4XX.pl

There is only one way for the Search value to evaluate to true:
the else case of the $op check (right at the bottom of the file).

The value passed to the itypeloop parameter is a full search from
Koha::ItemTypes->search, which has no parameters passed to it, and
does not return a 'selected' key as part of the array of hashes.

The logic to try to set "selected" in the template makes no sense,
as a result, since it is only called with a value that never has
"selected" set. The fix is easy: cut the useless code.

TEST PLAN
-
1) prove t/db_dependent/FrameworkPlugin.t
   -- see unimarc 4xx related noise.
2) apply patch
3) prove t/db_dependent/FrameworkPlugin.t
   -- no more unimarc 4xx related noise.
4) run koha qa test tools

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16579] Use separate memcached namespace for caching koha-conf.xml

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16744] new records not indexed if using a customize Koha Framework

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16744

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16579] Use separate memcached namespace for caching koha-conf.xml

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Srdjan Jankovic  changed:

   What|Removed |Added

 CC||srd...@catalyst.net.nz

--- Comment #25 from Srdjan Jankovic  ---
(In reply to Jacek Ablewicz from comment #24)
> By the look of it, in regards of cache architectural changes, there will be
> some overlap with Bug 15562, which in parts does somehow similar things with
> the cache (and a lot of other interesting things as well, but it's huge and
> I don't really understand ~half of it). Are there any chances of coordinated
> effort of some sort, so they both don't clash too badly with each other?

That's terrible. Next time I rebase I'll try to make it more readable.
Apologies.

Changes presented here are almost identical to the changes 15562, except that
they are a bit better:
* I fell short of introducing Koha::Config which I should have (I chickened
out)
* Koha::Caches - maybe we need to mandate the namespace when instantiating
Koha::Cache in order for this to be more robust?

At any rate, I did my patch in order to make plack multi-host going, and to be
brutally honest I was expecting things in the Cache/Context land to change a
lot by the time my patch gets some love. The issue is very complex, so it is
probably good to have independent efforts at early stages. Helps with
discovering unforeseen situations.

One thing that might be worth thinking about is that the very same problem
exists with the database connections. So maybe some über class, Koha::Storage
or something that would have a slot for everything we use, and then
Koha::Storages collection keyed by the namespace?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s)

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #53376|0   |1
is obsolete||

--- Comment #10 from Srdjan Jankovic  ---
Created attachment 53408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53408&action=edit
[SIGNED-OFF] Bug 16870 - Update Koha::Patron use of the class

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Patron/Borrower_PrevCheckout.t
3) prove t/db_dependent/Koha/Checkouts.t

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s)

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s)

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #53375|0   |1
is obsolete||

--- Comment #9 from Srdjan Jankovic  ---
Created attachment 53407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53407&action=edit
[SIGNED-OFF] Bug 16870 - Move and rename class files and unit tests

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #14 from Srdjan Jankovic  ---
Owen, I'm not sure why you are getting the delay. In my case once page has
loaded form comes up instantaneously. Admittedly, my database is not a large
one. Nevertheless, the only overhead introduced here is a http
request/response, so if the connection is decent (and it should be for the
librarian interface) everything should be fine.
The change moved one database query from the main handler to a service. As a
matter of fact it replaced two calls to the same function with only one, which
should only be faster. So when comparing, a fair comparison would be full time
from the circulation.pl request inception to the point where the checkout form
is shown.
Can you please give it another go with timing pre and post patch from the point
patron card number is entered to the appearance of the item checkout form. In
my env I can detect no difference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #52474|0   |1
is obsolete||

--- Comment #13 from Srdjan Jankovic  ---
Created attachment 53406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53406&action=edit
bug 14803: KOHA.Checkouts js object

* Use javascript to:
- update fines/checkouts info
- show/hide checkouts form and messages
* Created svc/patron/fines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

M. Tompsett  changed:

   What|Removed |Added

  Attachment #53378|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 53405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53405&action=edit
Bug 16917 - Error when importing patrons, Column 'checkprevcheckout' cannot be
null

Error:
DBIx::Class::Storage::DBI::_dbh_execute(): Column 'checkprevcheckout'
cannot be null at C4/Members.pm line 697

Test Plan:
1) Attempt to import a patron via csv
2) Note the error
3) Apply this patch
4) Repeat the import
5) No error!

NOTE: Given that all the other tests ran (comment #2), except
  those in comment #3, I resorted to following the test plan
  above using the attachment provided in comment #5. I
  believe the issues in comment #3 constitute other bugs
  which need fixing and are unrelated this bug. Applying the
  patch does resolve the error triggered, and the code is
  good.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15895] Add Koha::Account module, use Koha::Account:: pay internally for recordpayment

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895

--- Comment #14 from Srdjan Jankovic  ---
I suggested Koha::Patron for the reason that you never pay for multiple
patrons' fees. Patron->accountlines() makes sure of that.

Koha::AccountLines is better than Koha::Account because there's only one method
call.

I still think Patron->pay() is superior. The only argument against is you may
not need the borrowers record at that stage, but that's not very likely, and
can be made irrelevant with loading Patron with account lines preloaded or
something.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9701] Configure default indicator

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #18 from Katrin Fischer  ---
Created attachment 53404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53404&action=edit
Bug 9701: QA follow-up - Fix indentation and some strings

- Fixes tabs pointed out by the QA script.
- Changes table headings Indic1 and Indic2 to Ind. 1 and Ind. 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9701] Configure default indicator

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #52171|0   |1
is obsolete||
  Attachment #52172|0   |1
is obsolete||
  Attachment #52173|0   |1
is obsolete||

--- Comment #17 from Katrin Fischer  ---
Created attachment 53403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53403&action=edit
Bug 9701 - Configure default indicator

This patch adds the possibility to define default indicators in
the MARC frameworks. It adds 2 columns in the marc_tag_structure table in
the database in order to accomplish this. All files that reference this
table have also been updated to reflect these added fields.

Test: Add or edit a MARC framework. In the Field list should be 2 extra
columns. It should be possible to add default indicators (1 character)
in these fields. Nothing else should have changed in the meantime.
The default indicator values are not yet visible in the cataloguing module.

The default values are also loaded in the cataloguing form.

Test: Define default values in some MARC framework. Go to cataloguing
and create a new record using this framework. Verify that the defined
defaults are visible when set. Verify the default is empty (as before)
if no default was set. Verify that if the default is changed, the
record is saved with the manually changed value. Verify that upon
changing such a new record, the manually set indicator value is used
and not the default one from the framework.

Signed-off-by: Eugene Jose Espinoza 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9701] Configure default indicator

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #16 from Katrin Fischer  ---
Hi Joachim,

I have squashed your 3 original patches to avoid conflicts caused by adding and
removing the change to updatedatabase.pl in the first 2 patches. Also fixes the
problem that only the last patch was signed off by the sandbox script.

I also added a follow-up fixing tabs pointed out by the QA script - please keep
in mind that we are using 4 spaces instead of tabs!

The patches work really nicely. We are close to getting this through QA, but
please add tests for your change to GetMarcStructure. For changes in the core
modules, unit tests are mandatory. Please let us know if you need any help with
that!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #88 from Katrin Fischer  ---
I've run the database update and created the schema files, but sadly, I am
still seeing an error:

DBIx::Class::ResultSource::unique_constraint_columns(): Unknown unique
constraint primary on 'serialitems' at /home/katrin/kohaclone/Koha/Objects.pm
line 83

It happens when I try to receive 2 serial issues at once. To reproduce this:
- Search for a subscription
- Go to it's serial collection page
- Create a next issue
- Try to receive both the now late issue and the expected one at once

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15975] Add Owning Library Column to Checkouts

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Hi Nick, I think this should be 'home library' to fit with our usual
terminology, what do you think? It's what we use on the detail page for
example.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14668] Show serial enumeration in the patron's opac checkout summary

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668

--- Comment #9 from Charles Farmer  ---
There's a lot that's already been done from what I see; bugs #13430 and #13611
have already taken care of /svc, returns.pl and opac-user.pl. Everything that
François wrote in his first post was corrected by somebody else.

Something can still be done inside the RELATIVES loop of opac-user.pl, and the
'Check Out' section of circulation.pl. I'll submit a patch prompty to fix
those.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9259] Delete marc batches from staged marc management

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com

--- Comment #17 from Héctor Eduardo Castro Avalos  
---
+1 Aleisha this is very, very great

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16527] Sticky due date calendar unexpected behaviour

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

Kirsten  changed:

   What|Removed |Added

 CC||direc...@sandownlibrary.us

--- Comment #10 from Kirsten  ---
Can we have this fix backported to 3.22?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16926] New: Display acquisitions notes in more areas

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16926

Bug ID: 16926
   Summary: Display acquisitions notes in more areas
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

It would be nice to see order_internal notes on the invoice details page and
possibly some other area as well

aqbasket.order_internalnote and order_vendornote would be helpful to see in
basket searches and maybe spent.pl as well

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16780] Specify due date always sets time as AM when using 12 hour time format

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780

Eric Phetteplace  changed:

   What|Removed |Added

 CC||ephettepl...@cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16925] Shelving location search in OPAC nests search term in single quotes for every level of search results.

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16925

Barton Chittenden  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16925] New: Shelving location search in OPAC nests search term in single quotes for every level of search results.

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16925

Bug ID: 16925
   Summary: Shelving location search in OPAC nests search term in
single quotes for every level of search results.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

NOTE: This bug does *NOT* occur in Chrome.

Prerequisites: 

1) Enough bibs loaded in the database having the same shelving location such
that several pages of results will display. 
2) AdvancedSearchTypes must include

loc

Steps to reproduce:
1/ Navigate to OPAC advanced search page in firefox or IE
2/ Click on ShelvingLocation tab
3/ Select one of the available locations and click search.
   (examples below are using the location CDB)
4/ Note that the breadcrumb is in the form
   Results of search  with limit(s): 'mc-loc:'CDB'',
   The URL contains limit=mc-loc%3ACDB
5/ Click Next
6/ Breadcrumb shows Results of search  with limit(s): 'mc-loc:''CDB'''
   URL contains limit=mc-loc%3A%27CDB%27

Every time you click Next, another layer of quotes is added around the shelving
location in the breadcrumbs:

'mc-loc:'CDB''
'mc-loc:''CDB'''
'mc-loc:'''CDB

And the shelving location is nested a layer deeper in %27:

limit=mc-loc%3ACDB
limit=mc-loc%3A%27CDB%27
limit=mc-loc%3A%27%27CDB%27%27

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14876] Show number of holds per record on the search results

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

Nick Clemens  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 CC||a...@bywatersolutions.com,
   ||n...@bywatersolutions.com,
   ||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14876] Show number of holds per record on the search results

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14876] Show number of holds per record on the search results

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

--- Comment #2 from Nick Clemens  ---
Created attachment 53402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53402&action=edit
Bug 14876 - Show number of holds on the staff side next to 'holds' link

This patch adds a a Holds plugin for the templates to count existing
holds on a record.

We then use this in
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
to display the current number of holds on a record.

To test:
1 - Search in staff
2 - Note holds link has no extra information
3 - Apply patch
4 - prove -v t/db_dependent/Template/Plugin/Holds.t
5 - Do search in staff that returns records with some holds (i.e. place
some holds)
6 - Note the number of holds now displays next to the text of the link:
Holds (#)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16924] New: Add Search by Accelerated Reading Level Range

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16924

Bug ID: 16924
   Summary: Add Search by Accelerated Reading Level Range
 Change sponsored?: Seeking cosponsors
   Product: Koha
   Version: master
  Hardware: All
   URL: http://devs.bywatersolutions.com/projects/add-search-a
ccelerated-reading-level-range/
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Work to be done:

Create an index for the 526 MARC fields
Add range searching to advanced search in OPAC and Staff on new index

Seeking Cosponsors here:
http://devs.bywatersolutions.com/projects/add-search-accelerated-reading-level-range/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15759] Allow Koha::Object derived objects to be used as hashrefs

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16538] Improve the style of progress bars

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #7 from Héctor Eduardo Castro Avalos  ---
Just a comment: Would be great if Koha uses just one style of progress bar,
right now I could see three styles

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16538] Improve the style of progress bars

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #53389|0   |1
is obsolete||

--- Comment #6 from Héctor Eduardo Castro Avalos  ---
Created attachment 53401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53401&action=edit
[SIGNED-OFF]Bug 16538: Improve the style of progress bars

This patch updates the style of progress bars to make them a little
nicer. Progress bars in the staff client are not built in a consisten
way. Some have been updated to use the  element and some have
not. This patch improves some styling common to both kinds.

Other changes:

- Redundant in-page CSS has been removed from many pages.
- An invalid "min" attribute has been removed from several instances of
  .
- Corrected capitalization.
- Fixed incorrectly quoted attributes.
- Added missing form "action" attributes.

To test, clear your browser cache if necessary. Apply the patch and
test uploads on the following pages:

- Circulation -> Offline circulation file upload
- Tools -> Batch item modification
- Tools -> Batch record modification
- Tools -> Stage MARC records for import
- Tools -> Manage staged MARC records
- Tools -> Upload local cover image
- Tools -> Upload

In all cases, progress bars should look improved and work correctly.

Test Tools -> Batch item deletion. Unused background job handling markup
has been removed. Deletion processing should work correctly.

Signed-off-by: Hector Castro 
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16681] Allow update of opacnote via batch patron modification tool

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16681

Nick Clemens  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16681] Allow update of opacnote via batch patron modification tool

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16681

--- Comment #1 from Nick Clemens  ---
Created attachment 53400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53400&action=edit
Bug 16681 - Allow update of opacnote via batch patron modification tool

To test:
1 - Select a batch of patrons (via list, saved file, and cardnumber
entry)
2 - Verify you cannot edit 'opacnotes' field, nor can you see
'borrowernotes' field in table, though you can edit it
3 - Verify editing works as expected
4 - Apply patch
5 - Select a batch via each method as above
6 - Note both note columns display in table
7 - Note that you can edit or clear the opacnotes field as expected
8 - Verify other feautres work as previously

Sponsored by:
   Lancaster Theological Seminary (https://lancasterseminary.edu/)

https://bugs.koha-community.org/show_bug.cgi?id=15975

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16681] Allow update of opacnote via batch patron modification tool

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16681

Nick Clemens  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15975] Add Owning Library Column to Checkouts

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975

--- Comment #1 from Nick Clemens  ---
Created attachment 53399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53399&action=edit
Bug 15975 - Add Owning Library Column to Checkouts

To test:
1 - Checkout some items to a patron
2 - Note there is no 'Owning library' column
3 - Apply patch
4 - Note there IS an 'Owning library' column
5 - Use the columns configuration and ensure you can hide/display column at
will

Sponsored by:
Coeur d'Alene Public Library (http://www.cdalibrary.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15975] Add Owning Library Column to Checkouts

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975

Nick Clemens  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #26 from Kyle M Hall  ---
I would also recommend using Flipster. It's even touch aware and has multiple
layout options.

Honestly, I'd recommend you take a good look at the cover flow plugin (
https://github.com/bywatersolutions/koha-plugin-coverflow ) 
and steal heavily from it ; )

It provides a very efficient and flexible way to define the results you want,
and allows for as many coverflows as you'd like. The results are based on
reports, which are cached, and the javascript it generates is also cached.

The only thing it's really lacking is a nice graphical editor. Right now all
the setting are defined as a piece of hand written JSON.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

--- Comment #5 from Kyle M Hall  ---
Created attachment 53398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53398&action=edit
Test CSV File

This file caused the error for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16923] New: System Preference Missing from Manual -- IndependentBranchesPatronModifications

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16923

Bug ID: 16923
   Summary: System Preference Missing from Manual --
IndependentBranchesPatronModifications
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: neng...@gmail.com
  Reporter: misi...@fit.edu
QA Contact: testo...@bugs.koha-community.org

The system preference "IndependentBranchesPatronModifications" which was added
in 3.22 is missing from the 3.22 manual and the 16.05 manual.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16921] Authority Linking doesn't match to proper record

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16921

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #3 from Joy Nelson  ---
I also am not seeing any oddities in my search results of authorities, nor any
mismatches in the linker script.  Normally the oddities with the linker script
are due to setting in the system preferences.   I have heard of other sites
with issues with the linker that appeared to be a result of their zebra config. 
-joy


> Hi,
> attribute combo (phrase, no trucation, complete field) used in yaz-client
> test, from the 1st mail in koha-devel list back in June 23:
> 
> @attr 1=Match-heading @attr 4=1 @attr 5=100 @attr 6=3 "Bentley, Peter,
> Ed."
> 
> looks fine to me, and in my test setup it returns a proper result (only one,
> exact authority record matched). Most likely, problem is not in the Koha
> authority matching code, but in Zebra itself (it's config, or maybe the
> particular version you are using is buggy). BTW, do you have ICU tokenizer
> enabled? If yes, there were some known problems with it (completeness and
> position attributes not working at all, or not working properly) especially
> in not up-to-date zebra versions (see Bug 13751 and Bug 16581).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9938] batch patron deletion based on cardnumber or borrowernumber

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9938

Felicia Beaudry  changed:

   What|Removed |Added

   Priority|P5 - low|P4
 CC||felicia.beau...@newberry.ed
   ||u

--- Comment #1 from Felicia Beaudry  ---
I second the request.  For our academic library, we need to do a batch deletion
of patrons each semester to purge those who have graduated or withdrawn.  An
expiry date for patrons isn't helpful for this because students and faculty
come and go at irregular intervals. I'm sure we wouldn't be the only ones to
benefit from this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

Jacek Ablewicz  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16579

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16579] Use separate memcached namespace for caching koha-conf.xml

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jacek Ablewicz  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15562

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16579] Use separate memcached namespace for caching koha-conf.xml

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

--- Comment #24 from Jacek Ablewicz  ---
(In reply to Jonathan Druart from comment #21)
> Could someone take a look at these patches?

Overall they look (mostly) fine to me, or at least a move in the right
direction[s]. They are a bit hard to digest though, lots of collateral fixes
included - if some of them could be (?) moved to the separate reports, signing
off and Q&A will probably have a much better chance to occur in foreseeable
future ;).

Not sure if I fully understand a concept of namespaces / sub-namespaces
introduced with this patch set (and what are they needed for exactly,
especially in such particular form). E.g. L1 storage hash still remains a
shared singleton (sort of) - moving L1 storage to the cache objects instead
(and ideally tying those objects to the Koha contexts in 1:1 relationship)
seems to be much less headache-prone long term solution IMO.

By the look of it, in regards of cache architectural changes, there will be
some overlap with Bug 15562, which in parts does somehow similar things with
the cache (and a lot of other interesting things as well, but it's huge and I
don't really understand ~half of it). Are there any chances of coordinated
effort of some sort, so they both don't clash too badly with each other?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #22 from Marc Véron  ---
Found in sysprefs.sql
('SelfCheckAllowByIPRanges','',NULL,('Leave blank if not used. Use ranges or
simple ip addresses separated by spaces, like 192.168.1.1
192.168.0.0/24.)','Short'),

NULL,('Leave blank...
should be
NULL,'(Leave blank...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16922] New: Add RewriteRule to apache-shared-intranet for dev package installs

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16922

Bug ID: 16922
   Summary: Add RewriteRule to apache-shared-intranet for dev
package installs
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15975] Add Owning Library Column to Checkouts

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975

Nick Clemens  changed:

   What|Removed |Added

   Assignee|jwea...@bywatersolutions.co |n...@bywatersolutions.com
   |m   |
 CC||a...@bywatersolutions.com,
   ||n...@bywatersolutions.com,
   ||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187

Nick Clemens  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com,
   ||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187

--- Comment #1 from Nick Clemens  ---
Created attachment 53397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53397&action=edit
Bug 16187 - Add a script to cancel unfilled holds after a specified number of
days

This script takes parameters:
days - how many days waiting to concal an unfilled hold on or after
library - (repeatable) branches to consider
holidays - whether or not to count holidays (default is no)

To test:
1 - Place some holds with varying reservedates
2 - Run script with different parameters to verify options are respected
(-v for verbosity will assist here)
3 - verify that script does nothing without days parameter

Sponsored by:
Siskiyou County Library (http://www.siskiyoulibrary.info/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU indexing

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751

Jacek Ablewicz  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16921

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16921] Authority Linking doesn't match to proper record

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16921

Jacek Ablewicz  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=13751

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581

Jacek Ablewicz  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16921

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16921] Authority Linking doesn't match to proper record

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16921

Jacek Ablewicz  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16581

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16921] Authority Linking doesn't match to proper record

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16921

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

--- Comment #2 from Jacek Ablewicz  ---
(In reply to Nicholas van Oudtshoorn from comment #0)

> Copied from an email to the devel list:
> Investigating, it seems like zebra isn't giving the right search results
> back.
> 
> I can confirm this in yaz-client using the query that is created by koha.
> Searching for "Bentley, Peter, Ed." returns 4 results, only two of which are
> close. Actually, the record I'm trying to match is "Bentley, Peter, (Ed.)" -
> the last option.
> 
> Interestingly enough, if I search for "Bentley,
> 3432531531532513985735981" it will also show me 
> the same four results.So does searching for "Bentley 513513531513515151".But
> searching for "Bentleyr435435151551251" shows no results, as I would expect.

Hi,
attribute combo (phrase, no trucation, complete field) used in yaz-client test,
from the 1st mail in koha-devel list back in June 23:

@attr 1=Match-heading @attr 4=1 @attr 5=100 @attr 6=3 "Bentley, Peter, Ed."

looks fine to me, and in my test setup it returns a proper result (only one,
exact authority record matched). Most likely, problem is not in the Koha
authority matching code, but in Zebra itself (it's config, or maybe the
particular version you are using is buggy). BTW, do you have ICU tokenizer
enabled? If yes, there were some known problems with it (completeness and
position attributes not working at all, or not working properly) especially in
not up-to-date zebra versions (see Bug 13751 and Bug 16581).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Marc Véron  changed:

   What|Removed |Added

 Depends on||16920

--- Comment #21 from Marc Véron  ---

> 2) In your mysql client use your Koha database and execute:
> > DELETE FROM systempreferences;
> > SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql;
> -- Should be no errors.

SOURCE: 
- First I had an error related to Bug 16920.
- With this patch applied on top of 16920, I get following error:
  ERROR 1064 (42000): You have an error in your SQL syntax; check the manual
that corresponds to your MySQL server version for the right syntax to use near
'' at line 546


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920
[Bug 16920] sysprefs.sql - missing comma for MaxOpenSuggestions
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16920] sysprefs.sql - missing comma for MaxOpenSuggestions

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920

Marc Véron  changed:

   What|Removed |Added

 Blocks||14407


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
[Bug 14407] Limit web-based self-checkout to specific IP addresses
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16921] Authority Linking doesn't match to proper record

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16921

Nicholas van Oudtshoorn  changed:

   What|Removed |Added

  Attachment #53394|0   |1
is obsolete||

--- Comment #1 from Nicholas van Oudtshoorn  ---
Created attachment 53396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53396&action=edit
New version of BestMatch linker, that includes using the cache

A slight tweak to the BestMatch linker, to use the cache - hopefully giving a
slight speed bump!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16488] UNIMARC to MARC21 xslt to be used in z39.50 import sources

2016-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488

Theodoros Theodoropoulos  changed:

   What|Removed |Added

  Attachment #53377|0   |1
is obsolete||

--- Comment #11 from Theodoros Theodoropoulos  ---
Created attachment 53395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53395&action=edit
XSL for Unimarc -> MARC21 (partial) translation

v2.1 Minor fix in Unimarc 100/MARC 008 field handling

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/