[Koha-bugs] [Bug 17105] New: Do not see checkouts in the table of circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17105 Bug ID: 17105 Summary: Do not see checkouts in the table of circulation.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Saw this problem under 3.22 (but could probably have been master too): Circulation page lists a number of checkouts. But clicking Show checkouts does not list them in the table. What happened? This javascript error occurred: Sunday not defined. Comes from includes/calendar.inc. And should be a zero. (As value for the preference CalendarFirstDayOfWeek.) After toggling this preference a few times, I could not reproduce the problem anymore under 3.22 (Plack+memcache). Probably a cache problem somehow. Note that dbrev 3.21.00.015 moved the old value of Sunday to 0. Just leaving this note here some time for future troubleshooting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14622] Add fr-CA data folder in the web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622 Jonathan Druart changed: What|Removed |Added Blocks||17064 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17064 [Bug 17064] Delete backup marc21_framework_DEFAULT.sql~ file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17064] Delete backup marc21_framework_DEFAULT.sql~ file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17064 Jonathan Druart changed: What|Removed |Added Depends on||14622 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622 [Bug 14622] Add fr-CA data folder in the web installer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks the session out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050 --- Comment #5 from Benjamin Rokseth --- I tested this patch in our deployment setup (using docker containers), and experienced the following: Every second request invalidated/deleted the session. Seemingly the syspref cache was emptied also. Enabling/disabling the SessionRestrictedByIp had no effect, as it seemed the Context was gone. Really weird. I will have to see if I can reproduce this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7397] Patron search from Checkout tab does 'contains' instead of ' starts_with' search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7397 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin SOMERS --- Obsolete since Bug 15930 ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17106] New: DataTables patron search defaulting to 'starts_with' - doc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106 Bug ID: 17106 Summary: DataTables patron search defaulting to 'starts_with' - doc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Bug 15930 modified default value for DataTables patron search. The doc text should also be modified : "Can be 'contain' or 'start_with' (default value). Used for the searchmember parameter." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17106] DataTables patron search defaulting to 'starts_with' - doc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106 Fridolin SOMERS changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17106] DataTables patron search defaulting to 'starts_with' - doc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106 Fridolin SOMERS changed: What|Removed |Added Depends on||15930 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 Fridolin SOMERS changed: What|Removed |Added Blocks||17106 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106 [Bug 17106] DataTables patron search defaulting to 'starts_with' - doc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16741] Remove dead code "sub itemissues" from C4/Circulation.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 Claire Gravely changed: What|Removed |Added Attachment #54259|0 |1 is obsolete|| --- Comment #2 from Claire Gravely --- Created attachment 54284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54284&action=edit Bug 16741 - Remove dead code "sub itemissues" from C4/Circulation.pm To verify: - git grep itemissues Result: Appears in C4/Circulation.pm only To test: - apply patch - git grep itemissues Expected result: No occurences - prove t/db_dependent/Circulation.t Expected result: Pass OK Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16741] Remove dead code "sub itemissues" from C4/Circulation.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 Claire Gravely changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17106] DataTables patron search defaulting to 'starts_with' - doc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106 --- Comment #1 from Fridolin SOMERS --- Created attachment 54285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54285&action=edit Bug 17106 - DataTables patron search defaulting to 'starts_with' - doc Bug 15930 modified default value for DataTables patron search. The doc text should also be modified : "Can be 'contain' or 'start_with' (default value). Used for the searchmember parameter." Test plan : - install Koha with patch - look at man page man/man3/C4::Utils::DataTables::Members.3pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17106] DataTables patron search defaulting to 'starts_with' - doc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |String patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16212] Swagger specification separation and minification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 --- Comment #33 from Benjamin Rokseth --- Created attachment 54286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54286&action=edit Bug 16212: Add script minifySwagger.pl Signed-off-by: Olli-Antti Kivilahti My name is Olli-Antti Kivilahti and I approve this commit. We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now in production and I am certain we have a pretty good idea on how to work with the limitations of Swagger2.0 Signed-off-by: Johanna Raisa My name is Johanna Räisä and I approve this commit. We have been using Swagger2.0-driven REST API in production successfully. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16212] Swagger specification separation and minification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 --- Comment #34 from Benjamin Rokseth --- Created attachment 54287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54287&action=edit Bug 16212: Move from misc/devel to api/v1 Move minifySwagger.pl from misc/devel to api/v1 since it is directly related to swagger.json and the usage is simplified when it is in the same location with swagger.json. Signed-off-by: Olli-Antti Kivilahti My name is Olli-Antti Kivilahti and I approve this commit. We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now in production and I am certain we have a pretty good idea on how to work with the limitations of Swagger2.0 Signed-off-by: Johanna Raisa My name is Johanna Räisä and I approve this commit. We have been using Swagger2.0-driven REST API in production successfully. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16212] Swagger specification separation and minification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 --- Comment #35 from Benjamin Rokseth --- Created attachment 54288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54288&action=edit Bug 16212: Use swagger.min.json insted of swagger.json Our current approach with splitting the Swagger specification brings problems. For example, in swagger.json, if we split the whole "definitions" object with $ref, validations will fail with online.swagger.io validator. (See http://online.swagger.io/validator/debug?url=url_to_your_swagger_json) The problem also occurs with "paths" (Paths Object), because simply $ref to all paths for example in /paths/index.json does not meet the Swagger2 specification. The problem is solved by using the minification script and the minified version of swagger.json after which the swagger.min.json is valid Swagger2 specification, because the minifier resolves the problematic $refs of swagger.json file in the minified version. Signed-off-by: Olli-Antti Kivilahti My name is Olli-Antti Kivilahti and I approve this commit. We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now in production and I am certain we have a pretty good idea on how to work with the limitations of Swagger2.0 Signed-off-by: Johanna Raisa My name is Johanna Räisä and I approve this commit. We have been using Swagger2.0-driven REST API in production successfully. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16212] Swagger specification separation and minification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 Benjamin Rokseth changed: What|Removed |Added Attachment #52983|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16212] Swagger specification separation and minification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 Benjamin Rokseth changed: What|Removed |Added Attachment #52982|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16212] Swagger specification separation and minification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 Benjamin Rokseth changed: What|Removed |Added Attachment #52984|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16212] Swagger specification separation and minification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212
--- Comment #36 from Benjamin Rokseth ---
Tests:
swagger.json:
curl -X POST -H "accept:application/json" -d @swagger.json
http://online.swagger.io/validator/debug
{"messages":["attribute definitions.$ref is not of type
`object`"],"schemaValidationMessages":[{"level":"error","domain":"validation","keyword":"type","message":"instance
type (string) does not match any allowed primitive type (allowed:
[\"object\"])","schema":{"loadingURI":"http://swagger.io/v2/schema.json#","pointer":"/definitions/schema"},"instance":{"pointer":"/definitions/$ref"}}]}
swagger.min.json
curl -X POST -H "accept:application/json" -d @swagger.min.json
http://online.swagger.io/validator/debug
{}
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks the session out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050 --- Comment #6 from Jonathan Druart --- (In reply to Benjamin Rokseth from comment #5) > I tested this patch in our deployment setup (using docker containers), and > experienced the following: > > Every second request invalidated/deleted the session. Seemingly the syspref > cache was emptied also. Enabling/disabling the SessionRestrictedByIp had no > effect, as it seemed the Context was gone. Really weird. > > I will have to see if I can reproduce this. What's the value of SessionStorage? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17101] Confirm a question before check in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks the session out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050 --- Comment #7 from Benjamin Rokseth --- I believe it was 'mysql' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks the session out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050 --- Comment #8 from Jonathan Druart --- (In reply to Benjamin Rokseth from comment #7) > I believe it was 'mysql' So should be ok. Let me know if you have steps to recreate the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 Mirko Tietgen changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17084 --- Comment #31 from Mirko Tietgen --- The corresponding control file update is at bug 17084: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084#c1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Nightly build bot bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mirko Tietgen changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16929 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16741] Remove dead code "sub itemissues" from C4/Circulation.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 Jonathan Druart changed: What|Removed |Added Attachment #54284|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 54289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54289&action=edit Bug 16741 - Remove dead code "sub itemissues" from C4/Circulation.pm To verify: - git grep itemissues Result: Appears in C4/Circulation.pm only To test: - apply patch - git grep itemissues Expected result: No occurences - prove t/db_dependent/Circulation.t Expected result: Pass OK Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16741] Remove dead code "sub itemissues" from C4/Circulation.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Nightly build bot bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mirko Tietgen changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107 Fridolin SOMERS changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|gmcha...@gmail.com |fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17107] New: Add ident and Identifier-standard to known indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107 Bug ID: 17107 Summary: Add ident and Identifier-standard to known indexes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org Add ident and Identifier-standard to known indexes in C4::Search::getIndexes(). Those indexes can be very useful, for example for IdRef feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107 Fridolin SOMERS changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107 --- Comment #1 from Fridolin SOMERS --- Created attachment 54290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54290&action=edit Bug 17107 - Add ident and Identifier-standard to known indexes Add ident and Identifier-standard to known indexes in C4::Search::getIndexes(). Those indexes can be very useful, for example for IdRef feature. Test plan : - Make sure some records have a field indexed with Identifier-standard, ISBN=1234 for example - Perform a search /cgi-bin/koha/opac-search.pl?idx=ident,phr&q=1234 => you find the record - Perform a search /cgi-bin/koha/opac-search.pl?q=ident:1234 => Without patch : you get no results => With patch: you find the record Idem for 'Identifier-standard' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Nightly build bot bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Jonathan Druart changed: What|Removed |Added Attachment #54283|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 54293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54293&action=edit Bug 17084 - Automatic debian/control updates (master) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15200] t/Creators.t fails when using build-git-snapshot
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200 Jonathan Druart changed: What|Removed |Added Attachment #54192|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 54291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54291&action=edit Bug 15200 - t/Creators.t fails when using build-git-snapshot ttf-dejavu was missing from the build dependencies. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107 Fridolin SOMERS changed: What|Removed |Added Attachment #54290|0 |1 is obsolete|| --- Comment #2 from Fridolin SOMERS --- Created attachment 54292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54292&action=edit Bug 17107 - Add ident and Identifier-standard to known indexes Add ident and Identifier-standard to known indexes in C4::Search::getIndexes(). Those indexes can be very useful, for example for IdRef feature. Test plan : - Make sure some records have a field indexed with Identifier-standard, ISBN=1234 for example - Perform a search /cgi-bin/koha/opac-search.pl?idx=ident,phr&q=1234 => you find the record - Perform a search /cgi-bin/koha/opac-search.pl?q=ident:1234 => Without patch : you get no results => With patch: you find the record Idem for 'Identifier-standard' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Nightly build bot bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15200] t/Creators.t fails when using build-git-snapshot
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15200] t/Creators.t fails when using build-git-snapshot
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #15 from Jonathan Druart --- Skipping QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Nightly build bot bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #3 from Jonathan Druart --- Skipping QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Jonathan Druart changed: What|Removed |Added Keywords||nowheezy --- Comment #14 from Jonathan Druart --- libbusiness-issn-perl is only packaged for jessie, adding keyword nowheezy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Jonathan Druart changed: What|Removed |Added Keywords|nowheezy| --- Comment #15 from Jonathan Druart --- (In reply to Jonathan Druart from comment #14) > libbusiness-issn-perl is only packaged for jessie, adding keyword nowheezy. Forget that, it is also packaged for wheezy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 --- Comment #16 from Jonathan Druart --- (In reply to Nicole C. Engard from comment #11) > Created attachment 51029 [details] [review] > Bug 14629 - [QA Followup] Pass invalid ISSN through GetVariationsOfISSN Should not we do that for GetVariationsOfISBN as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16829] action_logs should have an 'interface' column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Jonathan Druart changed: What|Removed |Added Attachment #53200|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Created attachment 54295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54295&action=edit Bug 16829: make logaction and GetLogs aware of the interface column This patch changes the logaction API so it accepts a new 'interface' param. Current code calling logaction is not changed, and this parameter can be ommited in most contexts, and it will correctly fall-back to C4::Context->interface. Unit tests are provided on a different patch. GetLogs gets patched as well, so it can be required to filter by 'interface' param. Sponsored-by: NEKLS Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16829] action_logs should have an 'interface' column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Jonathan Druart changed: What|Removed |Added Attachment #53199|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 54294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54294&action=edit Bug 16829: Add 'interface' column to action_logs This patch introduces a new column for the action_logs table. It is called 'interface' and it is intended to store the interface in which the action was performed. Sponsored-by: NEKLS Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16829] action_logs should have an 'interface' column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Jonathan Druart changed: What|Removed |Added Attachment #53201|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart --- Created attachment 54296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54296&action=edit Bug 16829: Add 'interface' to the log viewer This patch introduces the 'interface' filter to the log viewer. To test: - Apply the patch - Open the log viewer => SUCCESS: As default, 'All' interfaces are chosen. OPAC, Intranet and SIP are presented - Do a lot of log searches, verify that the interface column shows what is expected. => SUCCESS: The chosen 'interfaces' are kept when rendering results. Sponsored-by: NEKLS Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16829] action_logs should have an 'interface' column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Jonathan Druart changed: What|Removed |Added Attachment #53203|0 |1 is obsolete|| --- Comment #18 from Jonathan Druart --- Created attachment 54298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54298&action=edit Bug 16829: Unit tests for logaction's 'interface parameter' This patch introduces tests for the new 'interface' parameter for the C4::Log::logaction and C4::Log::GetLogs functions. In logaction, it falls back to C4::Context->interface if ommited. To test: - Run $ prove t/db_dependent/Log.t => SUCCESS: Tests pass - Sign off Sponsored-by: NEKLS Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16829] action_logs should have an 'interface' column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16829] action_logs should have an 'interface' column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Jonathan Druart changed: What|Removed |Added Attachment #53202|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart --- Created attachment 54297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54297&action=edit Bug 16829: DBIx update Sponsored-by: NEKLS Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14328] sendbasket: Sent cart does not contain a name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14328 --- Comment #2 from Marcel de Rooy --- (In reply to Owen Leonard from comment #1) > I can't reproduce this problem in master. Can this report be closed? Not yet. I will still follow this under 3.22. It is quite hard to reproduce if you completely do not understand how it is possible at all.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Benjamin Rokseth changed: What|Removed |Added Attachment #52987|0 |1 is obsolete|| --- Comment #34 from Benjamin Rokseth --- Created attachment 54300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54300&action=edit [SIGNED-OFF] Bug 16699: Add borrowernumberQueryParam for reusability The borrowernumber as a query parameter should be defined in parameters.json in order to allow its reusability. To test: 1. Apply patch 2. Run minifySwagger.pl 3. Validate swagger.min.json in online.swagger.io/validator/debug?url=url_to+ _your_swagger_min_json or your local swagger-api/validator-badge validator 4. Observe that validation passes Signed-off-by: Olli-Antti Kivilahti My name is Olli-Antti Kivilahti and I approve this commit. We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now in production and I am certain we have a pretty good idea on how to work with the limitations of Swagger2.0 We participated in the development of the Mojolicious::Plugin::Swagger and know it well. We have made an extension to the plugin to provide full CORS support and have been building all our in-house features on the new REST API. Signed-off-by: Johanna Raisa My name is Johanna Räisä and I approve this commit. We have been using Swagger2.0-driven REST API in production successfully. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699
Benjamin Rokseth changed:
What|Removed |Added
Attachment #52986|0 |1
is obsolete||
--- Comment #33 from Benjamin Rokseth ---
Created attachment 54299
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54299&action=edit
[SIGNED-OFF] Bug 16699: Split parameters and paths in Swagger
Parameters and paths should be split in our Swagger specification, because
otherwise swagger.json would become messy with all the paths and their
further specification in the same file. Also parameters should be split
for the same reason.
Instead of using index.json for definitions, parameters and paths, we define
new files "definitions.json", "parameters.json" and "paths.json" in order to
simplify the references. If we kept using index.json and try to reference
"/definitions/error.json" from "/paths/holds.json", reference would be
"../definitions/index.json#/error" instead of now simplified version,
"../definitions.json#/error".
Here is the proposed structure:
.
├── swagger.json
├── definitions.json
├── paths.json
├── parameters.json
├── definitions
│ └── error.json
│ └── patron.json
├── parameters
│ └── patron.json
├── paths
│ └── patrons.json
├── minifySwagger.pl
└── swagger.min.js
The swagger.json paths, definitions and parameters will look as follows:
...
"paths": {
"$ref": "paths.json"
},
"definitions": {
"$ref": "definitions.json"
},
"parameters": {
"$ref": "parameters.json"
}
...
A problem with splitting specification into multiple files directly from
swagger.json (e.g. "paths": { "$ref": "paths.json" }) is that it is not
following the Swagger specification and an error will be thrown by the
Swagger-UI default validator (online.swagger.io/validator).
To overcome this problem, we use the minifySwagger.pl script from Buug 16212.
This allows the developers to work with the structure introduced in this patch
thus allowing developers to split the specification nicely, and still have a
valid Swagger specification in the minified swagger.min.json.
To test:
-2: Apply the minifier-patch in Buug 16212.
-1: Make sure you can validate your specification with Swagger2 validator at
online.swagger.io/validator/debug?url=url_to_swaggerjson, or install it
locally from https://github.com/swagger-api/validator-badge.
1. Don't apply this patch yet, but first validate swagger.json
with swagger.io-validator (or your local version, if you installed it)
2. Observe that validation errors are given
3. Run minifySwagger.pl
4. Validate swagger.min.json with the validator you used in step 1
5. Observe that validation passes and we overcame the invalid specification
problem in swagger.min.json
6. Apply this patch
7. Run minifySwagger.pl
8. Repeat step 4
9. Observe that validation passes with new structure
10. Run REST tests at t/db_dependents/api/v1
(11. Study the new structure of our Swagger specifications :))
Signed-off-by: Olli-Antti Kivilahti
My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0
We participated in the development of the Mojolicious::Plugin::Swagger and know
it well. We have made an extension to the plugin to provide full CORS support
and have been building all our in-house features on the new REST API.
Signed-off-by: Johanna Raisa
My name is Johanna Räisä and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Benjamin Rokseth changed: What|Removed |Added Attachment #52988|0 |1 is obsolete|| --- Comment #35 from Benjamin Rokseth --- Created attachment 54301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54301&action=edit [SIGNED-OFF] Bug 16699: Fix mixed-up indentation from 2-4 spaces to 2 spaces These definitions had indentation of 4 spaces, while rest of the specification uses 2 spaces. This patch simply maintains the consistency in indentations and provides no other modifications to code. Signed-off-by: Olli-Antti Kivilahti My name is Olli-Antti Kivilahti and I approve this commit. We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now in production and I am certain we have a pretty good idea on how to work with the limitations of Swagger2.0 We participated in the development of the Mojolicious::Plugin::Swagger and know it well. We have made an extension to the plugin to provide full CORS support and have been building all our in-house features on the new REST API. Signed-off-by: Johanna Raisa My name is Johanna Räisä and I approve this commit. We have been using Swagger2.0-driven REST API in production successfully. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Benjamin Rokseth changed: What|Removed |Added Attachment #52990|0 |1 is obsolete|| --- Comment #37 from Benjamin Rokseth --- Created attachment 54303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54303&action=edit [SIGNED-OFF] Bug 16699: Reference new x-primitives in currently defined objects Since we have defined some basic x-primitives in x-primitives.json, we can now start to reuse them in our currently defined objects. To test: 1. Apply patch 2. Run minifySwagger.pl 3. Validate your Swagger specifications 4. Observe that validation passes Signed-off-by: Olli-Antti Kivilahti My name is Olli-Antti Kivilahti and I approve this commit. We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now in production and I am certain we have a pretty good idea on how to work with the limitations of Swagger2.0 We participated in the development of the Mojolicious::Plugin::Swagger and know it well. We have made an extension to the plugin to provide full CORS support and have been building all our in-house features on the new REST API. Signed-off-by: Johanna Raisa My name is Johanna Räisä and I approve this commit. We have been using Swagger2.0-driven REST API in production successfully. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Benjamin Rokseth changed: What|Removed |Added Attachment #52991|0 |1 is obsolete|| --- Comment #38 from Benjamin Rokseth --- Created attachment 54304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54304&action=edit [SIGNED-OFF] Bug 16699: Move Swagger-related files to api/v1/swagger This patch separates Swagger-specifications and the minifySwagger.pl from other api-files by moving specifications & minifier into api/v1/swagger. Signed-off-by: Olli-Antti Kivilahti My name is Olli-Antti Kivilahti and I approve this commit. We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now in production and I am certain we have a pretty good idea on how to work with the limitations of Swagger2.0 We participated in the development of the Mojolicious::Plugin::Swagger and know it well. We have made an extension to the plugin to provide full CORS support and have been building all our in-house features on the new REST API. Signed-off-by: Johanna Raisa My name is Johanna Räisä and I approve this commit. We have been using Swagger2.0-driven REST API in production successfully. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699
Benjamin Rokseth changed:
What|Removed |Added
Attachment #52989|0 |1
is obsolete||
--- Comment #36 from Benjamin Rokseth ---
Created attachment 54302
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54302&action=edit
[SIGNED-OFF] Bug 16699: Support multiple types in primitive definitions
Currently it is not possible to define multiple types for primitive definitions
in /definitions/*. If you try to use the following
"firstname": {
"type": ["string", "null"],
"description": "patron's first name"
}
in definitions.json, online.swagger.io validator will not validate it:
{"messages":["attribute definitions.firstname.type is not of type `string`"]}
One way to get around this issue is to extend definitions with custom
"x-primitives" object, where we will define all reusable primitive definitions.
To test:
1. Add the "firstname" example above to definitions.json
2. Run minifySwagger.pl
3. Validate your specification
4. Observe that error with description mentioned above is given
5. Apply patch
6. Repeat step 2 and 3
7. Observe that validation passes
Signed-off-by: Olli-Antti Kivilahti
My name is Olli-Antti Kivilahti and I approve this commit.
We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now
in production and I am certain we have a pretty good idea on how to work with
the limitations of Swagger2.0
We participated in the development of the Mojolicious::Plugin::Swagger and know
it well. We have made an extension to the plugin to provide full CORS support
and have been building all our in-house features on the new REST API.
Signed-off-by: Johanna Raisa
My name is Johanna Räisä and I approve this commit.
We have been using Swagger2.0-driven REST API in production successfully.
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #39 from Benjamin Rokseth --- Rebased against 16271 which is now in master. Removed patched t/api/v1/minifier.t which should be moved to bug #17102 Please test and get this moved further, as it is a pain to rebase swagger definitions as is today ... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17108] New: Automatic debian/control updates (stable)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Bug ID: 17108 Summary: Automatic debian/control updates (stable) Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mi...@abunchofthings.net QA Contact: testo...@bugs.koha-community.org CC: mi...@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17108] Automatic debian/control updates (stable)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |mi...@abunchofthings.net |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Nightly build bot bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 --- Comment #4 from Nightly Build Bot --- Created attachment 54305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54305&action=edit Bug 17108 - Automatic debian/control updates (stable) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] New: sendbasket (working title)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 Bug ID: 17109 Summary: sendbasket (working title) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Nightly build bot bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mirko Tietgen changed: What|Removed |Added Attachment #54305|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15799] Move authorised values related code into Koha:: AuthorisedValues - part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 --- Comment #4 from Jonathan Druart --- We have already started to move the authorised values related code to the Koha namespace, but some are still missing. To continue and move C4::Koha::*AuthorisedValues* subroutines to Koha::AuthorisedValues, we will need to join on marc_subfield_structure(.authorised_value which is actually an authorised value category). To do so we need to define a relationship (fk) between the two tables. But we have "special AV" like Asort1 (and friends) , LOST, DAMAGED, etc.) Which could not be in the authorised_values table [yet]. And 3 other "special special AV) like itemtypes, branches and cn_source. Others (undetermined so far) are linked to a marc_subfield_structure from installer/**/marcflavour/**/*framework*.sql, like STACK. My idea would be to move all the AV categories to a new table authorised_value_categories. It will contain only 1 column category_name refered by 1. authorised_values.category, 2. additional_fields.authorised_value_category (others authorised_value field should be renamed like that when they refer AV categories) and 3. iitems_search_fields.authorised_value_category. And, maybe later, auth_subfield_structure, auth_tag_structure, borrower_attribute_types, marc_tag_structure (some are varchar(10) et 20 when they should be 32!) We could imagine more attributes to this table, but don't ask me to add a authorised_value_categories.id as pk please :) We will have to use temporary tables to deal with the DB constraints, to add more fun. Finally the .sql will have to be updated to reflect these changes. I have just started but before to enter in this tunnel I'd like to know if there are a couple of volunteers to test? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] sendbasket (working title)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 Marcel de Rooy changed: What|Removed |Added Blocks||17096 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 Owen Leonard changed: What|Removed |Added Attachment #54282|0 |1 is obsolete|| --- Comment #9 from Owen Leonard --- Created attachment 54307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54307&action=edit [SIGNED-OFF] Bug 13134: Fix template file to make category appear This is a followup to rescue the bug. To test: Follow test plan from comment #1 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 Owen Leonard changed: What|Removed |Added Attachment #32642|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 54306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54306&action=edit [SIGNED-OFF] Bug 13134 - Add patron category to returns confirmation dialogs Some librarians find it useful to know what category a patron is before confirming a reserve or transfer from the checkin screen. This patch adds the patron category to the hold and transfer popups to the patron information already displayed. The li tags that contain the patron category have the class "patron-category" to allow this data to be easily hidden. Test Plan: 1) Apply this patch 2) Trap a hold for a patron, note the patron category is now displayed 3) Trap a hold for pickup at another loation, note the patron category is now displayed Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17106] DataTables patron search defaulting to 'starts_with' - doc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106 Owen Leonard changed: What|Removed |Added Attachment #54285|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 54308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54308&action=edit [SIGNED-OFF] Bug 17106 - DataTables patron search defaulting to 'starts_with' - doc Bug 15930 modified default value for DataTables patron search. The doc text should also be modified : "Can be 'contain' or 'start_with' (default value). Used for the searchmember parameter." Test plan : - install Koha with patch - look at man page man/man3/C4::Utils::DataTables::Members.3pm Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17106] DataTables patron search defaulting to 'starts_with' - doc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14328] sendbasket: Sent cart does not contain a name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14328 Owen Leonard changed: What|Removed |Added Version|3.14|3.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] sendbasket: Remove second authentication, add CSRF token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 Marcel de Rooy changed: What|Removed |Added Assignee|oleon...@myacpl.org |m.de.r...@rijksmuseum.nl Patch complexity|--- |Small patch Summary|sendbasket (working title) |sendbasket: Remove second ||authentication, add CSRF ||token -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] sendbasket: Remove second authentication, add CSRF token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] sendbasket: Remove second authentication, add CSRF token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 --- Comment #1 from Marcel de Rooy --- Created attachment 54309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54309&action=edit Bug 17109: Remove second authentication from (opac-)sendbasket Patch deals with opac and intranet variant. If we authenticated the first time, it is not necessary to do it a second time rightaway. Replaces a call to get_template_and_user (including checkauth) by gettemplate. Also removes duplicate use C4::Biblio statements. Test plan: [1] Put a few books in the cart. [2] Send the cart from OPAC. [3] Send the cart from intranet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] sendbasket: Remove second authentication, add CSRF token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 --- Comment #2 from Marcel de Rooy --- Created attachment 54310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54310&action=edit Bug 17109: Add CSRF token to [opac-]sendbasket If you have no (valid) token, you will not be able to send the message. Test plan: [1] Verify if you can still send the cart from opac and intranet. [2] While still being logged in, try to send the cart from opac by using the following URL: /cgi-bin/koha/opac-sendbasket.pl?email_add=y...@somedomain.com&comment=csrf_test&bib_list=doesnotmatter&csrf_token=justsomeguess12345 This should now result in a csrf error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4030] Patron attribute types cannot be made mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4030 Janet McGowan changed: What|Removed |Added CC||janet.mcgowan@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] sendbasket: Remove second authentication, add CSRF token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 Marcel de Rooy changed: What|Removed |Added Depends on||16929 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 [Bug 16929] Prevent opac-memberentry waiting for random chars -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 Marcel de Rooy changed: What|Removed |Added Blocks||17109 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 [Bug 17109] sendbasket: Remove second authentication, add CSRF token -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16271] Allow more filters on /api/v1/holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Lari Taskula changed: What|Removed |Added Blocks||16699 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15126] REST API: Use newer version of Swagger2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Lari Taskula changed: What|Removed |Added Blocks|16699 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Lari Taskula changed: What|Removed |Added Status|Signed Off |Needs Signoff Depends on|15126, 16212|16271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 [Bug 15126] REST API: Use newer version of Swagger2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 [Bug 16212] Swagger specification separation and minification https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 [Bug 16271] Allow more filters on /api/v1/holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16212] Swagger specification separation and minification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 Lari Taskula changed: What|Removed |Added Blocks|16699 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14328] sendbasket: Sent cart does not contain a name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14328 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17109 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] sendbasket: Remove second authentication, add CSRF token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=14328 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #40 from Lari Taskula --- Created attachment 54311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54311&action=edit Bug 16699: Remove requirement from borrowernumberQueryParam borrowernumberQueryParam shouldn't be required as also changed in Bug 16271. To test: 1. Don't apply the patch yet, but first minify Swagger and run t/db_dependent/api/v1/holds.t 2. Observe that some tests fail with response code 400 when expecting 200. 3. Apply patch and minify Swagger 4. Run t/db_dependent/api/v1/holds.t 5. Observe that tests pass. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16212] Swagger specification separation and minification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 Lari Taskula changed: What|Removed |Added Blocks||16699 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Lari Taskula changed: What|Removed |Added Depends on||16212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 [Bug 16212] Swagger specification separation and minification -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14328] sendbasket: Sent cart does not contain a name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14328 --- Comment #3 from Marcel de Rooy --- I still hope to get some more light on this with bug 17109 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17100] On summary print, "Account fines and payments" is displayed even if there is nothing to pay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17100] On summary print, "Account fines and payments" is displayed even if there is nothing to pay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100 Owen Leonard changed: What|Removed |Added Attachment #54270|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 54312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54312&action=edit [SIGNED-OFF] Bug 17100: [Alternative patch] Fix issues for on summary print This alternative patch moves logic and formatting to the template file. To test: - Follow test plan in comment #2 - Additionally, verify that formatting follows syspref 'CurrencyFormat' - Verify that amount column is right-aligned Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #41 from Lari Taskula --- (In reply to Benjamin Rokseth from comment #39) > Rebased against 16271 which is now in master. > > Removed patched t/api/v1/minifier.t which should be moved to bug #17102 > > Please test and get this moved further, as it is a pain to rebase swagger > definitions as is today ... Thanks Benjamin! And I agree, it can be surprisingly time consuming! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17110] New: Lower CSRF expiry in Koha::Token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110 Bug ID: 17110 Summary: Lower CSRF expiry in Koha::Token Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110 --- Comment #1 from Marcel de Rooy --- Created attachment 54313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54313&action=edit Bug 17110: Lower CSRF expiry in Koha::Token Default expiry in WWW:CSRF is one week. This patch sets it to 8 hours by default in Koha, and allows to change the expiry period individually by passing MaxAge. Test plan: [1] Put items in your cart. [2] Apply the example patch too. [3] Send the cart from opac within the allotted 10 seconds. [4] Send again, but wait some 10 seconds before submitting. Too late! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110 Marcel de Rooy changed: What|Removed |Added Depends on||17109 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 [Bug 17109] sendbasket: Remove second authentication, add CSRF token -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] sendbasket: Remove second authentication, add CSRF token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 Marcel de Rooy changed: What|Removed |Added Blocks||17110 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110 [Bug 17110] Lower CSRF expiry in Koha::Token -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110 Marcel de Rooy changed: What|Removed |Added Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- Example patch and adjusted test still coming.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110 Marcel de Rooy changed: What|Removed |Added Blocks||17096 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17001] filtering overdue report by due date can fail if TimeFormat is 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001 Galen Charlton changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #7 from Galen Charlton --- (In reply to Kyle M Hall from comment #6) > Would it not be simpler to pass the parameter timeformat => '24hr' to > output_pref instead of using an external lib? I note that output_pref(), if we were to take its name literally, is for formatting date and time *output*. DateTime::Format::MySQL is already used in other places and its name makes it clear that a DateTime passed through is meant to be fed to an SQL query. I think it better that we keep the concerns of formatting timestamps for human display separate from formatting them for computer consumption. I am reseting the status of this bug back to "Passed QA". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of stopping zebrasrv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
