[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Nicholas van Oudtshoorn  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Nicholas van Oudtshoorn  changed:

   What|Removed |Added

  Attachment #53760|0   |1
is obsolete||

--- Comment #25 from Nicholas van Oudtshoorn  ---
Created attachment 54560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54560&action=edit
Latest version of patch, with silly typo fixed

Hi Marc,

Thanks for that. Can't believe I didn't put the fix for that into the patch
here - we've been running with it for ages! :-) 

This version of the patch should have fixed it (and also rebased to master so
that it will apply!)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15032] (Plack) Stage MARC records for import breaks in Plack

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #19 from Fridolin SOMERS  ---
Script are running so faster with Plack, we may disable the background mode
when using Plack.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17142] Don' t show library group selection in advanced search if groups are not defined

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16942] Confirm hold results in ugly error

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

--- Comment #11 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #10)
> (In reply to Jonathan Druart from comment #8)
> > (In reply to Jonathan Druart from comment #4)
> > > Kyle, the following test should fail without this patch:
> > >   is( $prepared_letter->{content}, $hold->id(), 'Hold object used 
> > > correctly'
> > > );
> > > 
> > > Could you please adapt it?
> > 
> > The test still passes.
> 
> They unit tests fail for me without the initial patch applied.

% git fetch origin
% git reset --hard origin/master
% git clean -f -d
%  prove t/db_dependent/Letters/TemplateToolkit.t
t/db_dependent/Letters/TemplateToolkit.t .. ok 
All tests successful.
Files=1, Tests=13,  4 wallclock secs ( 0.06 usr  0.00 sys +  2.78 cusr  0.10
csys =  2.94 CPU)
Result: PASS

What I meant is that the test 'Hold object used correctly' successes when we
are expecting it to fail.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records even when there is no need

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9834] Should reverting a waiting hold keep the item number?

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

--- Comment #4 from Sally Healey  
---
Still valid.

Being able to revert an item level hold to a global hold would be excellent.

We only allow patrons to make global holds, so patrons waiting for specific
items (which are now on loan) when they could've had one of the other copies is
not ideal.

It also impacts the patron who checked out the item, as they have to return it
after one circ period, and cannot renew.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

--- Comment #10 from Sally Healey  
---
This would be a nice feature to add to Koha.

As it's an enhancement, I think it's worth asking:  could we also consider a
system preference to have a different circ period if the item is required by
another patron?

For instance, standard circ period is 21 days.  
Item is on hold - renewal only gives a new circ period of 7 days.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

--- Comment #26 from Marc Véron  ---
Hi Nicholas,

I tested and acces was restricted as expected (except printslip.pl, see below)

QA-Tools complain:

 FAIL   opac/sco/help.pl
   FAIL   forbidden patterns
forbidden pattern: tab char (line 34)
forbidden pattern: tab char (line 35)

 FAIL   opac/sco/printslip.pl
   FAIL   forbidden patterns
forbidden pattern: tab char (line 39)
forbidden pattern: tab char (line 40)

   FAIL   valid
Global symbol "$query" requires explicit package name 
opac/sco/printslip.pl had compilation errors.

 FAIL   opac/sco/sco-main.pl
   FAIL   forbidden patterns
forbidden pattern: tab char (line 60)
forbidden pattern: tab char (line 61)
forbidden pattern: tab char (line 62)

 FAIL   opac/sco/sco-patron-image.pl
   FAIL   forbidden patterns
forbidden pattern: tab char (line 40)
forbidden pattern: tab char (line 39)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15032] (Plack) Stage MARC records for import breaks in Plack

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #38 from Mirko Tietgen  ---
Can this go to Passed QA then?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16370] Set the record encoding to UTF8 when TransformHtmlToMarc

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16370

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #8 from Marcel de Rooy  ---
> Create a framework that doesn't include the 000 in the editor (set to ignore)
> alternatively, import the attached framework.

Hmm. Isn't this kind of a strange use case?

I have doubts on correcting the problem in TransformHtmlToMarc.
Currently, the marc21 leader plugin forces the leader position to Unicode. But
what if you edit the leader manually? (Just as strange as ignoring the leader.)

And what are the implications for UNIMARC? Note that the encoding for that is
not in the leader but in field 100.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

Lari Taskula  changed:

   What|Removed |Added

  Attachment #54508|0   |1
is obsolete||

--- Comment #6 from Lari Taskula  ---
Created attachment 54561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54561&action=edit
Bug 17008: Add "swaggerize" for Koha::Object and Koha::Objects

This patch adds new subroutine "swaggerize" for Koha::Object and Koha::Objects.

By matching column data types with corresponding Swagger data type, we can e.g.
numify values in order to be able to return borrowernumber:123 instead of
borrowernumber:"123".

Before this patch, we usually returned an unblessed representation of the
Koha-object in controller by calling e.g.
  $c->$cb($patron->unblessed, 200);

This would cause the returned JSON to have { "borrowernumber": "123" ... }, or
in other words everything as strings (apart from undefs, which would be null).

Now, we also return an unblessed representation of the Koha-object, but where
numbers are actually numified simply by calling e.g.
  $c->$cb($patron->swaggerize, 200);

Here our returned JSON will have { "borrowernumber": 123 ... } in "integer"
data
type of Swagger, as well as every other column that is defined to be an
integer.
Decimals, doubles and floats should have "number" data type and will also be
numified for the returned JSON.

To test:
1. Apply this patch and run t/db_dependent/Koha/Util/Swagger.t
2. Apply REST of the patches and follow their test plan for seeing how this
   works in practice

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

Lari Taskula  changed:

   What|Removed |Added

  Attachment #54510|0   |1
is obsolete||

--- Comment #7 from Lari Taskula  ---
Created attachment 54562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54562&action=edit
Bug 17008: Fix current data types

This patch changes current Swagger definitions for patrons and holds to have
data types corresponding to column data types in their database tables.

To test:
1. GET http://yourlibrary/api/v1/patrons/YYY where YYY is existing
borrowernumber
2. Observe that numbers / integers are in string data type.
3. Apply this patch.
4. Repeat step 1.
5. Observe that numbers / integers are now actually numbers / integers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

Lari Taskula  changed:

   What|Removed |Added

  Attachment #54509|0   |1
is obsolete||

--- Comment #8 from Lari Taskula  ---
Created attachment 54563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54563&action=edit
Bug 17008: Test to compare Swagger property types against column data types

This patch adds a test that iterates through each definition-object in Swagger
and compares their properties' data types to corresponding Koha-object's
column's
data type by using Koha::Util::Swagger::column_type_to_swagger_type().

This test will also check if the column is nullable and will complain
unless property has also "null" defined in its type.

To test:
1. Run t/db_dependent/api/v1/swagger/definitions.t
2. Observe that tests pass (if not, open a Bug to fix issues)
3. Modify api/v1/definitions/patron.json cardnumber to be type "integer".
4. Run the test again.
5. Observe that test fails and will complain about incorrect data type.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17144] New: Can't call method "param" on an undefined value at /home/ marc/koha/admin/edi_accounts.pl line 157

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144

Bug ID: 17144
   Summary: Can't call method "param" on an undefined value at
/home/marc/koha/admin/edi_accounts.pl line 157
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

To reproduce:
- In Staff client, go to Administration > EDI accounts
- Click "+ New account"
Result: Internal Server Error
Plack error log says: 
Can't call method "param" on an undefined value at
/home/marc/koha/admin/edi_accounts.pl line 157

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17144] Can't call method "param" on an undefined value at /home/marc/ koha/admin/edi_accounts.pl line 157

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144

Marc Véron  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17144] Can't call method "param" on an undefined value at /home/marc/ koha/admin/edi_accounts.pl line 157

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144

--- Comment #1 from Marc Véron  ---
Created attachment 54564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54564&action=edit
Bug 17144: Fix variable scope issues in edi_account.pl

To reproduce:
- In Staff client, go to Administration > EDI accounts
- Click "+ New account"
Result: Internal Server Error
Plack error log says:
Can't call method "param" on an undefined value at
/home/marc/koha/admin/edi_accounts.pl line 157

To test:
-Apply patch
- Add an EDI account
- Edit an EDI account
- Delete an EDI account

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17144] Fix variable scope issue in edi_accounts.pl

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff
Summary|Can't call method "param"   |Fix variable scope issue in
   |on an undefined value at|edi_accounts.pl
   |/home/marc/koha/admin/edi_a |
   |ccounts.pl line 157 |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #2 from Lari Taskula  ---
Created attachment 54565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54565&action=edit
Bug 17140: Fix rounding in total fines calculations, part 2

This patch fixes still occuring issue with total fines calculations.

To test:
1. Go to patron's fines tab, make sure there are no outstanding payments.
2. Via "Create manual invoice" tab, create one fine of 1.14
3. Go to Pay fines tab
4. Click "Pay amount" and confirm.
5. Observe error message "You must pay a value less than or equal to 1.14."
6. Run t/db_dependent/Members.t
7. Observe failure in a test case
8. Apply patch.
7. Repeat step 3 and 4
8. Observe that payment goes through
9. Run t/db_dependent/Members.t
10. Observe test passing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Lari Taskula  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Lari Taskula  changed:

   What|Removed |Added

  Attachment #54565|0   |1
is obsolete||

--- Comment #3 from Lari Taskula  ---
Created attachment 54566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54566&action=edit
Bug 17140: Fix rounding in total fines calculations, part 2

This patch fixes still occuring issue with total fines calculations.

To test:
1. Go to patron's fines tab, make sure there are no outstanding payments.
2. Via "Create manual invoice" tab, create one fine of 1.14
3. Go to Pay fines tab
4. Click "Pay amount" and confirm.
5. Observe error message "You must pay a value less than or equal to 1.14."
6. Run t/db_dependent/Members.t
7. Observe failure in a test case
8. Apply patch.
9. Repeat step 3 and 4
10. Observe that payment goes through
11. Run t/db_dependent/Members.t
12. Observe test passing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Lari Taskula  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

Tom Misilo  changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17145] New: Cannot upload .mrc file for staging Marc records

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17145

Bug ID: 17145
   Summary: Cannot upload .mrc file for staging Marc records
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic record staging/import
  Assignee: gmcha...@gmail.com
  Reporter: vermeir_b...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

Today I upgraded the koha installation from 3.20.05 to 16.05.02
All seems to work just fine, except for the uploading of a mrc file for
staging.

Errormessage:
Upload failed -- unable to store file on server

I checked the Koha logs and found this
script not found or unable to stat:
/usr/share/koha/intranet/cgi-bin/tools/upload-file-progress.pl

I checked the location and indeed the upload-file-progress.pl file is missing.
I downloaded the file and uploaded it to the correct folder

Next errormessage:
AH01215: (2)No such file or directory: exec of
'/usr/share/koha/intranet/cgi-bin/tools/upload-file-progress.pl

The uploads directory has the correct rights and is located in
/var/lib/koha/biblio/uploads


can someone please help me out?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258

--- Comment #10 from Marc Véron  ---
Created attachment 54567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54567&action=edit
Button Create EDIFACT order still appears

If syspref "Edifact" is disabled but the vendor has an Edifact account, the
button "Create EDIFACT order" still displays.
I would expect that it does no longer appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined value at /usr/share /koha/intranet/cgi-bin/cataloguing/additem.pl

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #8 from Marc Véron  ---
I can reproduce the error with a tweaked URL:

http://192.168.1.29:8080/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=50123&itemnumber=22&searchid=#edititem

...where biblionumber 50123 does not exist

Result:
Can't call method "fields" on an undefined value at
/usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl line 742

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks the session out

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #11 from Jonathan Druart  
---
(In reply to Tomás Cohen Arazi from comment #10)
> so HTTP_X_FORWARDED_FOR and REMOTE_ADDR have the right values. Are you
> implying that Mojo is messing with ENV?

ENV is correctly set if you hit mainpage, but not /api/*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17037] 952 Field/Record Items not being accessed

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17037

--- Comment #4 from Jonathan Druart  
---
You should use the mailing list for this kind of questions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17037] 952 Field/Record Items not being accessed

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17037

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
I think we should remove the * 1000 / 1000

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |la...@student.uef.fi
   |ity.org |
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15164] Allow editing of the invoice number after initial saving

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

Marc Véron  changed:

   What|Removed |Added

  Attachment #54537|0   |1
is obsolete||

--- Comment #4 from Marc Véron  ---
Created attachment 54568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54568&action=edit
Bug 15164 - Allow editing of the invoice number after initial saving

When you notice a typo in your invoice number after finishing with the
receiving process, the only way to correct it right now is in the
database - or by undoing all the steps and starting over.

It would be nice if the invoice number could be edited.

Test Plan:
1) Apply this patch
2) Browse to acqui/invoice.pl for an invoice
3) Note the new "Invoice number" field contains the existing invoice
4) Alter the invoice number
5) Save the invoice
6) Note the invoice number has been updated
7) Edit the invoice again
8) Attempt to save the invoice with an empty invoice number field
9) Note that you cannot save the invoice without having an invoice number

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15164] Allow editing of the invoice number after initial saving

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16942] Confirm hold results in ugly error

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

Jesse Maseto  changed:

   What|Removed |Added

  Attachment #53737|0   |1
is obsolete||
  Attachment #53738|0   |1
is obsolete||

--- Comment #12 from Jesse Maseto  ---
Created attachment 54569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54569&action=edit
Bug 16942 - Confirm hold results in ugly error

Confirming a hold to set it to waiting will result in an DBIC error in
master.

Test Plan:
1) Attempt to check in an item on hold and confirm the hold
2) Note the error
3) Apply this patch
4) Repeat step 1
5) Note there is no error!

Signed-off-by: Mirko Tietgen 

https://bugs.koha-community.org/show_bug.cgi?id=14942

Signed-off-by: Katrin Fischer 

Signed-off-by: Jesse Maseto 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16942] Confirm hold results in ugly error

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

--- Comment #13 from Jesse Maseto  ---
Created attachment 54570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54570&action=edit
Bug 16942 [QA Followup] - Add unit test

Signed-off-by: Katrin Fischer 

Signed-off-by: Jesse Maseto 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14251] style discharge letter

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17143] Popup Notification for decreaseloanhighholds preference

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17143

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #1 from Christopher Brannon  ---
This is an annoyance and is confusing to staff.  We may even be seeing some
shorter period loans getting hit by this message, but I have yet to get my
hands on examples.  Just word of mouth right now.  But we are definitely seeing
the popup with equal loan periods.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17143] Popup Notification for decreaseloanhighholds preference

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17143

Christopher Brannon  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17147] New: Streamline messages following batch record modification

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147

Bug ID: 17147
   Summary: Streamline messages following batch record
modification
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

After completing a batch record modification, a separate message dialog is
displayed for each record which was modified. If you modify 500 records at a
time this can result in a very long page. I think it would be better to display
messages in a more compact way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17147] Streamline messages following batch record modification

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147

--- Comment #1 from Owen Leonard  ---
Created attachment 54572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54572&action=edit
Bug 17147 - Streamline messages following batch record modification

This patch changes the display of informational messages during and
after the batch record modification process. Instead of showing a
separate dialog for each record modified, messages are now grouped into
one dialog.

To test, apply the patch and clear your browser cache if necessary. You
must have at least one MARC modification template defined.

- Go to Tools -> Batch record modification.
- Submit a list of biblionumbers which contains at least one number
  which doesn't exist in your database.
- Confirm that warning and success messages are grouped instead of
  showing in separate dialogs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17147] Streamline messages following batch record modification

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13949] Item search should have holding library

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17148] New: Add floating toolbar for tabs on cataloging interface

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17148

Bug ID: 17148
   Summary: Add floating toolbar for tabs on cataloging interface
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Created attachment 54573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54573&action=edit
add floating toolbar for tabs

Hi,

It would be nice if tabs are add in floating toolbar like buttons.

Regards,

Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13949] Item search should have holding library

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13949] Item search should have holding library

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949

--- Comment #4 from Owen Leonard  ---
Created attachment 54574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54574&action=edit
Bug 13949 - Item search should have holding library

This patch adds holding library ("current location") to the list of
fields available in the item search form.

To test, apply the patch and go to Search -> Item search.

- Perform a search using the "current location" option and verify that
  it returns the correct results.
- Try other searches to confirm that they work as before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16942] Confirm hold results in ugly error

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

--- Comment #14 from Kyle M Hall  ---
> % git fetch origin
> % git reset --hard origin/master
> % git clean -f -d
> %  prove t/db_dependent/Letters/TemplateToolkit.t
> t/db_dependent/Letters/TemplateToolkit.t .. ok 
> All tests successful.
> Files=1, Tests=13,  4 wallclock secs ( 0.06 usr  0.00 sys +  2.78 cusr  0.10
> csys =  2.94 CPU)
> Result: PASS
> 
> What I meant is that the test 'Hold object used correctly' successes when we
> are expecting it to fail.

Are you applying the "Bug 16942 [QA Followup] - Add unit test" patch to master
before running the tests? If you apply that patch, the test should fail. Then,
if you apply "Bug 16942 - Confirm hold results in ugly error" the test should
pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17137] Omnibus: Always use SSL when referencing external sources

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137

Kyle M Hall  changed:

   What|Removed |Added

 Blocks|16615   |
 Depends on||16615


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615
[Bug 16615] OpenLibrary: always use SSL when referencing external resources
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16615] OpenLibrary: always use SSL when referencing external resources

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||17137
 CC||k...@bywatersolutions.com
 Depends on|17137   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137
[Bug 17137] Omnibus: Always use SSL when referencing external sources
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16615] OpenLibrary: always use SSL when referencing external resources

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

--- Comment #24 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Oliver, Mark and Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16615] OpenLibrary: always use SSL when referencing external resources

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16996] Template process failed: undef error - Can't call method " description"

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #11 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17006] REST API: add route to change patron's password

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Lari Taskula  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17006] REST API: add route to change patron's password

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

--- Comment #1 from Lari Taskula  ---
Created attachment 54575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54575&action=edit
Bug 17006: Add API route for changing patron's password

PATCH /patrons/{borrowernumber}/password (change password)

Required body params:
- current_password
- new_password

To test:
1. Apply patch
2. Run t/db_dependent/api/v1/patrons.t
3. Send PATCH request to http://library/api/v1/patrons/YYY/password
   where YYY is existing borrowernumber (borrowers flag required)
4. Make sure that password was changed.
5. Try also too short password, and wrong current password and observe
   that errors are displayed appropriately.

You may find this useful for testing:

curl -X PATCH http://library/api/v1/patrons/123/password
 --data '{"current_password":"123456", "new_password":"1234"}'
 --cookie 'CGISESSID=055ca5a9a3ad3fb5052143bd015c1c10'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11019] Adding new category in authorized values

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11019] Adding new category in authorized values

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Owen Leonard  changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #33 from Kyle M Hall  ---
Items.t fails if SearchEngine is set to Elastic:

prove t/db_dependent/Koha/Items.t
t/db_dependent/Koha/Items.t .. 1/5  problem with :564 : :1: parser error :
Start tag expected, '<' not found
tAw
^

tAw at /home/vagrant/kohaclone/C4/Biblio.pm line 1339.
# Looks like you planned 3 tests but ran 1.
Can't call method "field" on an undefined value at
/home/vagrant/kohaclone/Koha/ElasticSearch/Indexer.pm line 180.
# Looks like your test exited with 255 just after 4.
t/db_dependent/Koha/Items.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/5 subtests

Test Summary Report
---
t/db_dependent/Koha/Items.t (Wstat: 65280 Tests: 4 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 5 tests but ran 4.
Files=1, Tests=4,  1 wallclock secs ( 0.02 usr  0.00 sys +  1.30 cusr  0.13
csys =  1.45 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16955] Internal Server Error while populating new framework

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #12 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17124] DecreaseLoanHighHolds.t does not pass

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17124

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

--- Comment #8 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #7)
> Yes it does

Confirmed!

So I found what is the problem, but no idea how to fix it:
inventory.pl calls ModItem and update datelastseen (l.210), but a call to
ModDateLastSeen is done later (l.332). ModDateLastSeen does not accept any
parameters and update datelastseen with the today's date.

My supposition is that bug 14001 introduced this bug by trying to fix something
else.
Maybe we could just remove the call to ModDateLastSeen and handle $moddatecount
somewhere else.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17117] Patron personal details not displayed unless branch update request is enabled

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17117

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Jacek!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11019] Require some fields when adding authorized value category

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Owen Leonard  changed:

   What|Removed |Added

Summary|Adding new category in  |Require some fields when
   |authorized values   |adding authorized value
   ||category

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17006] REST API: add route to change patron's password

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

--- Comment #2 from Lari Taskula  ---
Created attachment 54576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54576&action=edit
Bug 17006: Respect system preference "OpacPasswordChange"

Allow patron to change their own password without borrowers-flag only
if OpacPasswordChange system preference is enabled.

To test:
1. Apply patch
2. Run t/db_dependent/api/v1/patrons.t
3. Set OpacPasswordChange system preference to "Don't allow".
4. Send PATCH request to http://library/api/v1/patrons/YYY/password
   where YYY is existing borrowernumber for a borrower that does not
   have any permissions
5. Observe permission error.
6. Set OpacPasswordChange system preference to "Allow".
7. Repeat step 4 and make sure that password was changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17009] Duplicating frameworks is unnecessary slow

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17009

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16942] Confirm hold results in ugly error

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

--- Comment #15 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #14)
> > % git fetch origin
> > % git reset --hard origin/master
> > % git clean -f -d
> > %  prove t/db_dependent/Letters/TemplateToolkit.t
> > t/db_dependent/Letters/TemplateToolkit.t .. ok 
> > All tests successful.
> > Files=1, Tests=13,  4 wallclock secs ( 0.06 usr  0.00 sys +  2.78 cusr  0.10
> > csys =  2.94 CPU)
> > Result: PASS
> > 
> > What I meant is that the test 'Hold object used correctly' successes when we
> > are expecting it to fail.
> 
> Are you applying the "Bug 16942 [QA Followup] - Add unit test" patch to
> master before running the tests? If you apply that patch, the test should
> fail. Then, if you apply "Bug 16942 - Confirm hold results in ugly error"
> the test should pass.

I completely understood that.

So maybe you should explain me why the following test pass:

180 $prepared_letter = GetPreparedLetter(
181 (
182 module  => 'test',
183 letter_code => 'TEST_HOLD',
184 tables  => { 
185 reserves => [ $patron->{borrowernumber}, $biblio->id() ]
186 },
187 )
188 );
189 is( $prepared_letter->{content}, $hold->id(), 'Hold object used correctly'
)

What does reserves => { $borrowernumber, $biblionumber } mean?
How do you know that $borrowernumber is a borrowernumber?
It looks like something magic and to me it should not work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17095] Regression: Error when checking out to non-existent patron

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17095

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known indexes

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Frido!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16991] Add subtitle to holds to pull report

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16991

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||k...@bywatersolutions.com

--- Comment #4 from Kyle M Hall  ---
I'm sorry to ask this, but could you update your patch to use
Koha::Biblio->subtitles to get this list of subtitles? That way we aren't
duplicating logic.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11019] Require some fields when adding authorized value category

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11019] Require some fields when adding authorized value category

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Owen Leonard  changed:

   What|Removed |Added

  Attachment #22110|0   |1
is obsolete||

--- Comment #11 from Owen Leonard  ---
Created attachment 54577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54577&action=edit
Bug 11019 - Require some fields when adding authorized value category

This patch modifies the form for adding an authorized value so that
category, authorized value, and description are required fields.
Previously a new authorized value category could be saved with no data.

To test, apply the patch and go to Administration -> Authorized values.

- Click the "New category" button.
- Click the save button without filling in category, authorized value,
  or description. You should be prevented from submitting the form.
- Verify that filling in the required fields allows the form to be
  submitted.
- Perform the same test when editing an existing authorized value.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11019] Require some fields when adding authorized value category

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Owen Leonard  changed:

   What|Removed |Added

   Assignee|amitddng...@gmail.com   |oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17001] filtering overdue report by due date can fail if TimeFormat is 12hr

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001

--- Comment #8 from Kyle M Hall  ---
That is sufficient to me! Pushed to master for 16.11!

(In reply to Galen Charlton from comment #7)
> (In reply to Kyle M Hall from comment #6)
> > Would it not be simpler to pass the parameter timeformat => '24hr' to
> > output_pref instead of using an external lib?
> 
> I note that output_pref(), if we were to take its name literally, is for
> formatting date and time *output*. DateTime::Format::MySQL is already used
> in other places and its name makes it clear that a DateTime passed through
> is meant to be fed to an SQL query.
> 
> I think it better that we keep the concerns of formatting timestamps for
> human display separate from formatting them for computer consumption.
> 
> I am reseting the status of this bug back to "Passed QA".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17001] filtering overdue report by due date can fail if TimeFormat is 12hr

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14876] Show number of holds per record on the search results

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14876] Show number of holds per record on the search results

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

--- Comment #5 from Nick Clemens  ---
Created attachment 54578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54578&action=edit
Bug 14876 - (QA Followup) Fix pod

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17100] On summary print, "Account fines and payments" is displayed even if there is nothing to pay

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #12 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Marc, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16741] Remove dead code "sub itemissues" from C4/Circulation.pm

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17106] DataTables patron search defaulting to 'starts_with' - doc

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Frido!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14876] Show number of holds per record on the search results

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

--- Comment #6 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #4)
> 2/ Since this plugin is only used once, why did you choose to use a TT
> plugin?

If we don't use this we'd have to iterate through the search results and counts
the holds for each before display, this way we only check for those that are
being currently shown.

We could also alter detail.tt to use this function

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #34 from Kyle M Hall  ---
Found the bug, unrelated. Fixed on followup to bug 16272.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15268] Patron search differs between 'Check out' search and 'Patron' search on two-word surnames like 'St. Claire'

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15268

--- Comment #1 from Owen Leonard  ---
This appears to be fixed in master. Barton could you re-test?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to regular checkout

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

--- Comment #18 from Kyle M Hall  ---
Created attachment 54579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54579&action=edit
Bug 16272 [QA Followup] - Indexer fails on indexing temparary testing records

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to regular checkout

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #54579|0   |1
is obsolete||

--- Comment #19 from Kyle M Hall  ---
Created attachment 54580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54580&action=edit
Bug 16272 [QA Followup] - Indexer fails on indexing temparary testing records

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253

--- Comment #10 from Kyle M Hall  ---
(In reply to Kyle M Hall from comment #9)
> Thanks Olli! That is most excellent info! Would you be willing to write a
> proof of concept? If you can put that up, I'd be more than happy to do the
> grunt work of handling all the SIP server logging calls.

Ping! Olli ^

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14612] Overdue notice triggers should show branchname instead of branchcode

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14612

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14876] Show number of holds per record on the search results

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876

--- Comment #7 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #6)
> (In reply to Jonathan Druart from comment #4)
> > 2/ Since this plugin is only used once, why did you choose to use a TT
> > plugin?
> 
> If we don't use this we'd have to iterate through the search results and
> counts the holds for each before display, this way we only check for those
> that are being currently shown.

I am not sure I am following you, the results returned by searchResults are
always displayed, isn't?

Since we already iterate in catalogue/search.pl it's not a big deal to do this
job over there. I don't think it's the job of a plugin to calculate the number
of holds for a given record.

Feel free to ask for another QA point of view ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14612] Overdue notice triggers should show branchname instead of branchcode

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14612

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14612] Overdue notice triggers should show branchname instead of branchcode

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14612

--- Comment #1 from Owen Leonard  ---
Created attachment 54581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54581&action=edit
Bug 14612 - Overdue notice triggers should show branchname instead of
branchcode

This patch adds the Branches template plugin to the overdue notice
triggers template so that the library name can be shown instead of the
branchcode.

Also changed: Updated page title to match the name used in tools menus.

To test, apply the patch and go to Tools -> Overdue notice/status
triggers.

- Select a library.
- When the page reloads, the 'Defining overdue actions for...' and
  'Rules for overdue actions: ' headings should show the library name
  instead of the branchcode.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15268] Patron search differs between 'Check out' search and 'Patron' search on two-word surnames like 'St. Claire'

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15268

Barton Chittenden  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #2 from Barton Chittenden  ---
This was caused by the "Starts With" vs. "Contains" user search -- Bug 15930.
That bug is closed, and I'm marking this one as a duplicate.

*** This bug has been marked as a duplicate of bug 15930 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930

Barton Chittenden  changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com

--- Comment #18 from Barton Chittenden  ---
*** Bug 15268 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14612] Overdue notice triggers should show branchname instead of branchcode

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14612

Marc Véron  changed:

   What|Removed |Added

  Attachment #54581|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 54582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54582&action=edit
Bug 14612 - Overdue notice triggers should show branchname instead of
branchcode

This patch adds the Branches template plugin to the overdue notice
triggers template so that the library name can be shown instead of the
branchcode.

Also changed: Updated page title to match the name used in tools menus.

To test, apply the patch and go to Tools -> Overdue notice/status
triggers.

- Select a library.
- When the page reloads, the 'Defining overdue actions for...' and
  'Rules for overdue actions: ' headings should show the library name
  instead of the branchcode.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14612] Overdue notice triggers should show branchname instead of branchcode

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14612

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17149] EDI accounts: Add missing '>' to breadcrumb

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17149

Marc Véron  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17149] New: EDI accounts: Add missing '>' to breadcrumb

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17149

Bug ID: 17149
   Summary: EDI accounts: Add missing '>' to breadcrumb
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Breadcrumb on "EDI accounts" pages reads 
Home > Administration EDI accounts > Modify account
instead of:
Home > Administration > EDI accounts > Modify account

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17149] EDI accounts: Add missing '>' to breadcrumb

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17149

--- Comment #1 from Marc Véron  ---
Created attachment 54583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54583&action=edit
Bug 17149 - EDI accounts: Add missing '>' to breadcrumb

To verify:
Breadcrumb on "EDI accounts" pages reads
Home > Administration EDI accounts > Modify account
instead of:
Home > Administration > EDI accounts > Modify account

To test:
- Apply patch
- Add, edit and delete an EDI account
- Verify that breadcrumb displays properly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17149] EDI accounts: Add missing '>' to breadcrumb

2016-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17149

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

  1   2   >