[Koha-bugs] [Bug 17163] Making MARC subfields structure actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163 Marc Véron changed: What|Removed |Added Attachment #54734|0 |1 is obsolete|| --- Comment #3 from Marc Véron --- Created attachment 54745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54745&action=edit Bug 17163: Making MARC subfields structure actions buttons To test: 1) Go to Admin -> MARC bibliographic framework 2) Go to Actions -> MARC structure for any framework 3) Click Subfields 4) Confirm Edit and Delete links show as buttons with appropriate icons in one column called 'Actions' 5) Confirm buttons do not wrap on narrower browser 6) Confirm buttons behave as expected Sponsored-by: Catalyst IT Patch behaves as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17162] Moving MARC tags structure actions into a drop down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17162 Marc Véron changed: What|Removed |Added Attachment #54732|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 54744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54744&action=edit Bug 17162: Moving MARC tags structure actions into a drop down menu To test: 1) Go to Admin -> MARC bibliographic framework 2) Go to Actions -> MARC structure for any framework 3) Confirm that three links, Subfields, Edit and Delete, now show in drop-down menu with appropriate font awesome icons 4) Confirm that Subfields takes you to the right page and Edit and Delete work as expected Sponsored-by: Catalyst IT Patch behaves as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17162] Moving MARC tags structure actions into a drop down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17162 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17163] Making MARC subfields structure actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163 Marc Véron changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17163] Making MARC subfields structure actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17165] Improve heading on vendor search when searching for all vendors in Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17165 Marc Véron changed: What|Removed |Added Patch complexity|--- |Trivial patch CC||ve...@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17165] Improve heading on vendor search when searching for all vendors in Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17165 Marc Véron changed: What|Removed |Added Attachment #54740|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 54743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54743&action=edit Bug 17165: Improve heading on vendor search when searching for all vendors in Serials To test: 1) Go to Serials 2) Click New subscription or edit an existing one 3) Click Search for a vendor 4) Make a search that will return no results (i.e. has a typo etc.) 5) Confirm there is an appropriate message 6) Go back and make a search that will return results (i.e. putting in one letter 'a' etc.) 7) Confirm that heading is worded better and search term is displayed 8) Go back and make search without entering any search terms 9) Confirm that heading is worded better, no search term is displayed Sponsored-by: Catalyst IT Patch behaves as dexcribed. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15900] Remove use of recordpayment in ProcessOfflinePayment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15900] Remove use of recordpayment in ProcessOfflinePayment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 Josef Moravec changed: What|Removed |Added Attachment #52142|0 |1 is obsolete|| --- Comment #4 from Josef Moravec --- Created attachment 54742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54742&action=edit Bug 15900 - Remove use of recordpayment in ProcessOfflinePayment Test plan: 1) Apply this patch 2) prove t/db_dependent/Circulation.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6778] Display suggestor's name in catalog detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6778 Katrin Fischer changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|shino...@osslabs.biz|koha-b...@lists.koha-commun ||ity.org --- Comment #4 from Katrin Fischer --- No activity since 2011 - removing assignee. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15899] Remove the use of recordpayment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Katrin Fischer changed: What|Removed |Added Severity|normal |major Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390
--- Comment #50 from Katrin Fischer ---
I think Jacek is right - we need the F fines for the total amount calculation
in order to not break the MaxFine behaviour:
if (my $maxfine = C4::Context->preference('MaxFine')) {
if ($total_amount_other + $amount > $maxfine) { ...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17144] Fix variable scope issue in edi_accounts.pl ( Internal server error with plack)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144 Katrin Fischer changed: What|Removed |Added Summary|Fix variable scope issue in |Fix variable scope issue in |edi_accounts.pl (Internal |edi_accounts.pl (Internal |server error) |server error with plack) CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17166] OPAC suggestion form: making Title a required field to remove onclick Check function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17166 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Aleisha, I tested bug 10848 some days ago, it's currently waiting to get pushed. Haven't tested, but it might make this patch obsolete. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17144] Fix variable scope issue in edi_accounts.pl ( Internal server error)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144 Marc Véron changed: What|Removed |Added Summary|Fix variable scope issue in |Fix variable scope issue in |edi_accounts.pl |edi_accounts.pl (Internal ||server error) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17144] Fix variable scope issue in edi_accounts.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144 --- Comment #3 from Marc Véron --- (In reply to Aleisha Amohia from comment #2) > I am not able to reproduce the bug. Can you please check? It is still an issue. Clicking on "New account" results in "Internal server error" plack-error.log: Variable "$schema" is not available at /home/marc/koha/admin/edi_accounts.pl line 147. Variable "$input" is not available at /home/marc/koha/admin/edi_accounts.pl line 157. Variable "$schema" is not available at /home/marc/koha/admin/edi_accounts.pl line 159. Variable "$template" is not available at /home/marc/koha/admin/edi_accounts.pl line 161. Can't call method "param" on an undefined value at /home/marc/koha/admin/edi_accounts.pl line 157. Does not happen with patch (after re-starting plack). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #54 from M. Tompsett --- (In reply to Jonathan Druart from comment #51) > Still fails, even with gzip files: > # 21/26: > /home/koha/src/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/ > Obligatoire/autorite_default.sql > C4::Installer::load_sql returned the following errors while attempting to > load /home/koha/src/installer/data/mysql/fr-FR/marcflavour/un > imarc_complet/Obligatoire/autorites_norme_unimarc.sql: > not ok 1 - > /home/koha/src/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/ > Obligatoire/autorites_norme_unimarc.sql: DBD::mysql::s > t execute failed: Cannot add or update a child row: a foreign key constraint > fails (`koha_test_installer`.`auth_subfield_structure`, CO > NSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY (`authtypecode`) > REFERENCES `auth_types` (`authtypecode`) ON DELETE CASCADE ON UP > DATE C) at /usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 254. > # > # Failed test > '/home/koha/src/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/ > Obligatoire/autorites_norme_unimarc.sql: DBD::my > sql::st execute failed: Cannot add or update a child row: a foreign key > constraint fails (`koha_test_installer`.`auth_subfield_structur > e`, CONSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY (`authtypecode`) > REFERENCES `auth_types` (`authtypecode`) ON DELETE CASCADE ON UPDATE C) at > /usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 254. > # ' > # at t/db_dependent/Test_installer.t line 48. OH! I think I have it. If you recall ALTER IGNORE doesn't work in MySQL 5.7.4, so if you upgraded through 3.19.00.042, you may find the upgrade had issues. I have a massive head cold. If no one posts a "make all the ALTER IGNORE into ALTER only" patch later, I will. I'm going to bed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17166] OPAC suggestion form: making Title a required field to remove onclick Check function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17166 --- Comment #1 from Aleisha Amohia --- Created attachment 54741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54741&action=edit Bug 17166: OPAC suggestion form: Make Title a required field To test: 1) Log in to OPAC 2) Go to your suggestions 3) New suggestion 4) Attempt to submit a suggestion without the title 5) Notice pop-up error box 6) Apply patch and refresh page 7) Attempt to submit a suggestion without the title 8) Notice error bubble and form cannot submit Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17166] OPAC suggestion form: making Title a required field to remove onclick Check function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17166 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17166] OPAC suggestion form: making Title a required field to remove onclick Check function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17166 Aleisha Amohia changed: What|Removed |Added Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17166] New: OPAC suggestion form: making Title a required field to remove onclick Check function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17166 Bug ID: 17166 Summary: OPAC suggestion form: making Title a required field to remove onclick Check function Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: aleishaamo...@hotmail.com QA Contact: testo...@bugs.koha-community.org Currently we have an onclick function that checks if anything has been entered in Title before submitting. Using the built-in required attribute makes this unnecessary -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17165] Improve heading on vendor search when searching for all vendors in Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17165 --- Comment #1 from Aleisha Amohia --- Created attachment 54740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54740&action=edit Bug 17165: Improve heading on vendor search when searching for all vendors in Serials To test: 1) Go to Serials 2) Click New subscription or edit an existing one 3) Click Search for a vendor 4) Make a search that will return no results (i.e. has a typo etc.) 5) Confirm there is an appropriate message 6) Go back and make a search that will return results (i.e. putting in one letter 'a' etc.) 7) Confirm that heading is worded better and search term is displayed 8) Go back and make search without entering any search terms 9) Confirm that heading is worded better, no search term is displayed Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17165] Improve heading on vendor search when searching for all vendors in Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17165 Aleisha Amohia changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17165] Improve heading on vendor search when searching for all vendors in Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17165 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17165] New: Improve heading on vendor search when searching for all vendors in Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17165 Bug ID: 17165 Summary: Improve heading on vendor search when searching for all vendors in Serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamo...@hotmail.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Same fix from Bug 13238 needs to be applied to the vendor search in Serials when adding or modifying a subscription -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16752] Remove the use of event attributes from some acquisitions templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 Aleisha Amohia changed: What|Removed |Added Attachment #53569|0 |1 is obsolete|| --- Comment #9 from Aleisha Amohia --- Created attachment 54739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54739&action=edit [SIGNED-OFF] Bug 16752 - Remove the use of event attributes from some acquisitions templates - Transfer order This patch removes the use of 'onclick' from the acquisitions transfer order process. The patch also modifies the style of some links and buttons to conform with current guidelines. - Locate an open basket with items in it - Click the 'Transfer' link for a title in the basket - In the pop-up window: - Confirm that the 'Cancel' button at the bottom of the window is a Bootstrap-style button. - Search for a vendor; Confirm that the 'Choose' link is a Bootstrap-style button. - Choose a vendor; Confirm that the 'Choose' link on the following page is a Bootstrap-style button. - Confirm that clicking the 'Choose' button transfers the item to the correct basket. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16752] Remove the use of event attributes from some acquisitions templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 Aleisha Amohia changed: What|Removed |Added Attachment #52460|0 |1 is obsolete|| --- Comment #8 from Aleisha Amohia --- Created attachment 54738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54738&action=edit [SIGNED-OFF] Bug 16752 - Remove the use of event attributes from some acquisitions templates - Funds This patch modifies the funds administration page and other files related to the process of searching for and selecting fund owners and users in order to remove the use of event attributes like 'onclick.' Also changed in this patch: I have revised the way the "select owner" and "select user" controls look. They are now links with Font Awesome icons. - Go to Administration -> Funds and open a fund for editing. - Test the process of adding and updating an owner: - Click the 'Select owner' link. - Search for and select an owner in the pop-up window. - Save the fund and verify that the owner was saved correctly. - Perform the same test with the 'Remove owner' link. - Use the same process to test the addition and removal of users. - Confirm that the 'Remove' link works correctly before and after submitting the form to save changes to the fund. This patch changes a file which is used by both the funds template and the template used when setting a guarantor on a patron. To test the changes in that context: - Open a 'child' type patron record. - Under 'Guarantor information,' test the process of setting and removing a guarantor to confirm that data is saved correctly. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16752] Remove the use of event attributes from some acquisitions templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 Aleisha Amohia changed: What|Removed |Added Attachment #52459|0 |1 is obsolete|| --- Comment #7 from Aleisha Amohia --- Created attachment 54737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54737&action=edit [SIGNED-OFF] Bug 16752 - Remove the use of event attributes from some acquisitions templates - Uncertain prices This patch modifies the acquisitions uncertain prices template to remove event attributes onclick and onchange. Also changed on the uncertain prices page: Added a label to the orders filter, removed redundant form submit function. - Locate a vendor which has orders with uncertain prices - Click the 'Uncertain prices' tab in the left-hand sidebar - Enter invalid data in the "price" field for any order. Confirm that an error is triggered when the field loses focus. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16752] Remove the use of event attributes from some acquisitions templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||aleishaamo...@hotmail.com --- Comment #16 from Aleisha Amohia --- fatal: sha1 information is lacking or useless (C4/Accounts.pm) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16963] Remove the use of "onclick" from subscription add template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16963 Aleisha Amohia changed: What|Removed |Added Attachment #53662|0 |1 is obsolete|| --- Comment #2 from Aleisha Amohia --- Created attachment 54736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54736&action=edit [SIGNED-OFF] Bug 16963 - Remove the use of "onclick" from subscription add template This patch removes the use of event attributes from the subscription add template and the template for testing prediction patterns. Events are now defined in the JavaScript. To test, go to Serials -> New subscription. - Test that the "Search for vendor," "Search for record," and "Create record" links work correctly. - Test the "Next" button without entering a vendor or a biblionumber. You should be warned about selecting a vendor and biblionumber. - After selecting a bibliographic record to link to the subscription, click the "Next" button. The second section of the subscription add form should be displayed. - Under frequency, choose "1/day." - Confirm that the "Show advanced pattern" link correctly toggles display of the advanced pattern form. - Under the advanced pattern form, test the "Modify pattern" button. It should enable editing in the form. - Test the "Cancel modifications" and "Save as new pattern" buttons. - Test the "Test prediction pattern" button. - In the "Prediction pattern" box, test that the checkboxes next to each day of the week, when checked, trigger the corresponding issue number to be marked as "not published." - Finally, confirm that your subscription is saved correctly. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16963] Remove the use of "onclick" from subscription add template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16963 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16912] Koha:: Patrons - Move AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||aleishaamo...@hotmail.com --- Comment #7 from Aleisha Amohia --- fatal: sha1 information is lacking or useless (t/db_dependent/Koha/Patrons.t) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17164] New: Software error when enrolment fee or reserve fee are too high ( Patron categories)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17164 Bug ID: 17164 Summary: Software error when enrolment fee or reserve fee are too high (Patron categories) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamo...@hotmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com For some reason I had ridiculously high enrolment fee and reserve fee data causing a software error when trying to access Patron Categories Software error: Template process failed: undef error - round() overflow. Try smaller precision or use Math::BigFloat at /home/vagrant/kohaclone/Koha/Number/Price.pm line 44. My enrolment fee was set at 886660996297397000.00 and my reserve fee was set at 386269492352888000.00 Obviously it's very unlikely for a librarian to set the enrolment fee or reserve fee to be this high but if it happens accidentally, it breaks the system and causes this error. Perhaps there should be some kind of constraint when entering this, like a maximum reserve fee constraint etc.? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #53 from M. Tompsett --- (In reply to Jonathan Druart from comment #51) > Still fails, even with gzip files: Could you ls -la the offending files? $ ls -la /home/mtompset/kohaclone/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql -rw-rw-r-- 1 mtompset mtompset 323371 Aug 22 21:28 /home/mtompset/kohaclone/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql I just retested on Debian, which is still <5.7, and Ubuntu 16.04 LTS. Perhaps your files are older? Try reloading them from scratch? mkdir ~/16554 cd ~/16554 wget -O fr-FR.gz https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51898 wget -O ru-RU.gz https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51899 wget -O uk-UA.gz https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51900 gunzip fr-FR.gz gunzip ru-RU.gz gunzip uk-UA.gz cd ~/kohaclone git checkout -b bug_16554 origin/master git pull git am < ~/16554/fr-FR git am < ~/16554/ru-RU git am < ~/16554/uk-UA git bz apply 16554 ... Because I'm just as confused as BGK as to why you might have those issues, JD. Though, I really hate those white space issues with the patches, but that isn't causing me any failures. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17056] Remove event attributes from various templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17056 Aleisha Amohia changed: What|Removed |Added Attachment #54051|0 |1 is obsolete|| --- Comment #3 from Aleisha Amohia --- Created attachment 54735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54735&action=edit [SIGNED-OFF] Bug 17056 - Remove event attributes from various templates This patch removes event attributes from several templates, moving event definitions into the JavaScript instead. To test, apply the patch and: - View the MARC detail page for any bibliographic record. Changing the framework selection should reload the display using the selected framework. - Perform the same test on the labeled MARC view. (Set the viewLabeledMARC system preference to "Allow" if necessary). - To test the changes to Reports you should have at least one report group and at least one report subgroup. - Create a new saved SQL report. - Select a report group. Doing so should trigger the display of report subgroups. Deselecting the report group should hide the subgroups. - In Acquisitions -> Suggestions, create a new suggestion. - In the 'Acquisition information' section, changing values for copies, currency, and price should change the value in the total field. - In Circulation -> Upload offline circulation file: - My patch for Bug 16602 added the required code but forgot to remove the corresponding onclick attributes. - Browse for an offline circulation file. - Clicking the 'Upload file' button should work correctly. - After uploading a file, both the 'Add to offline circulation queue' and 'Apply directly' buttons should work to trigger their corresponding processes (keeping Bug 16603 in mind). Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17056] Remove event attributes from various templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17056 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17094] Methods of Koha::Object[s] -based classed should not return DBIx::Class objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||aleishaamo...@hotmail.com --- Comment #3 from Aleisha Amohia --- fatal: sha1 information is lacking or useless (Koha/Objects.pm). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17163] Making MARC subfields structure actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163 Aleisha Amohia changed: What|Removed |Added Attachment #54733|0 |1 is obsolete|| --- Comment #2 from Aleisha Amohia --- Created attachment 54734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54734&action=edit Bug 17163: Making MARC subfields structure actions buttons To test: 1) Go to Admin -> MARC bibliographic framework 2) Go to Actions -> MARC structure for any framework 3) Click Subfields 4) Confirm Edit and Delete links show as buttons with appropriate icons in one column called 'Actions' 5) Confirm buttons do not wrap on narrower browser 6) Confirm buttons behave as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17163] Making MARC subfields structure actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163 --- Comment #1 from Aleisha Amohia --- Created attachment 54733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54733&action=edit Bug 17163: Making MARC subfirlds structure actions buttons To test: 1) Go to Admin -> MARC bibliographic framework 2) Go to Actions -> MARC structure for any framework 3) Click Subfields 4) Confirm Edit and Delete links show as buttons with appropriate icons in one column called 'Actions' 5) Confirm buttons do not wrap on narrower browser 6) Confirm buttons behave as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17163] Making MARC subfields structure actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17163] Making MARC subfields structure actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163 Aleisha Amohia changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17163] New: Making MARC subfields structure actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17163 Bug ID: 17163 Summary: Making MARC subfields structure actions buttons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamo...@hotmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17162] Moving MARC tags structure actions into a drop down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17162 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17162] Moving MARC tags structure actions into a drop down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17162 --- Comment #1 from Aleisha Amohia --- Created attachment 54732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54732&action=edit Bug 17162: Moving MARC tags structure actions into a drop down menu To test: 1) Go to Admin -> MARC bibliographic framework 2) Go to Actions -> MARC structure for any framework 3) Confirm that three links, Subfields, Edit and Delete, now show in drop-down menu with appropriate font awesome icons 4) Confirm that Subfields takes you to the right page and Edit and Delete work as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17162] Moving MARC tags structure actions into a drop down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17162 Aleisha Amohia changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17162] New: Moving MARC tags structure actions into a drop down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17162 Bug ID: 17162 Summary: Moving MARC tags structure actions into a drop down menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamo...@hotmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16593] Access Control - Malicious user can delete the search history of another user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16593 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15803] Koha::AuthorisedValues - Remove GetAuthorisedValueCategories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15803 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15803] Koha::AuthorisedValues - Remove GetAuthorisedValueCategories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15803 Aleisha Amohia changed: What|Removed |Added Attachment #54257|0 |1 is obsolete|| --- Comment #5 from Aleisha Amohia --- Created attachment 54731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54731&action=edit [SIGNED-OFF] Bug 15803: Koha::AuthorisedValues - Remove C4::Koha::GetAuthorisedValueCategories The subroutine C4::Koha::GetAuthorisedValueCategories just retrieves all the authorised value categories. We already have a method in the Koha::AuthorisedValues module to do this job, let's use it! Technical explanations: The new subroutine of the AuthorisedValues TT plugin will allow to get the authorised value categories from the templates. The new html_helpers include file will get rid of the if selected else end statements. Bug 15758 already uses this file, see the commit description for more informations. Test plan: 1/ Create or edit a new fund (aqbudgets.pl), the fields "statistic 1" and "statistic 2" should be correctly filled with the list of authorised value categories 2/ Edit subfields for a biblio and authority framework. The "Authorized value" dropdown list should be correctly filled on both pages 3/ Create new items search fields (from the administration area), same as previously, the authorised value category dropdown list should be correctly filled 4/ Add and edit patron attribute types, check the authorised value category list. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685 Aleisha Amohia changed: What|Removed |Added Attachment #52901|0 |1 is obsolete|| --- Comment #9 from Aleisha Amohia --- Created attachment 54729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54729&action=edit [SIGNED-OFF] Bug 16685 - Use eval instead of do for .perl atomicupdates If we use eval instead of do for our .perl atomic update files, it will allow developers to put in the exact code that should go into updatedatabase.pl. The problem with do is that none of the variables defined in updatadatabase.pl are available, whereas with eval they are. Test Plan: 1) Apply this patch 2) Create a .perl file in atomicupdates with the following in it: say "DBversion: $DBversion"; 3) Run updatadatabase.pl 4) Note the output 5) Add a syntax error to your atomic update 6) Run updatedatabase.pl 7) Note the error is displayed Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685 Aleisha Amohia changed: What|Removed |Added Attachment #54541|0 |1 is obsolete|| --- Comment #10 from Aleisha Amohia --- Created attachment 54730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54730&action=edit [SIGNED-OFF] Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp File::Slurp is considered better to use than File::Slurp. RM Note: The package version in wheezy is too old, the package version in jessie is just fine and should be added to the community repo if wheezy will be supported for the coming release. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17141] Incorrect method called in edi_cron to get logdir
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17141 Aleisha Amohia changed: What|Removed |Added Attachment #54544|0 |1 is obsolete|| --- Comment #2 from Aleisha Amohia --- Created attachment 54728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54728&action=edit [SIGNED-OFF] Bug 17141: Call config method to retrieve logdir Incorrect method call is causing runtime error and not retrieving the correct logdir value Change retrieves the value correctly To test: 1) Run edi_cron.pl, notice error 2) Apply patch and run edi_cron.pl again, should work as expected Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17141] Incorrect method called in edi_cron to get logdir
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17141 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17142] Don' t show library group selection in advanced search if groups are not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17142] Don' t show library group selection in advanced search if groups are not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142 Aleisha Amohia changed: What|Removed |Added Attachment #54545|0 |1 is obsolete|| --- Comment #2 from Aleisha Amohia --- Created attachment 54727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54727&action=edit [SIGNED-OF] Bug 17142 - Don't show library group selection in advanced search if groups are not defined Even if library groups/search domains are not defined in the system, (empty) select for "Groups of libraries" under "Location and availability" section in OPAC advanced search is still visible; it shouldn't. Side effect of Bug 15295 - 'searchdomainloop' variable in the template is now an object, it needs a different kind of statement (.count) for checking if it's empty or not. To test: 1) apply patch 2) when there are no groups of libraries defined in Administration -> Libraries and Groups, "Groups of libraries" selection should be no longer visible in OPAC adavanced search page 3) add library group or two: "Groups of libraries" selection should reappear. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com Status|Needs Signoff |Failed QA --- Comment #11 from Aleisha Amohia --- This patch works well, however there are some things that should be considered and improved before signing off on this: 1) With Edifact disabled, the EDI links still appear in the Admin sidebar navigation 2) With Edifact disabled, I can still directly navigate to edi_accounts.pl etc., either through the sidebar nav or going straight to the URL. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17161] Making 'preview MARC' links show as buttons in batch record mod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|gmcha...@gmail.com |aleishaamo...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17161] Making 'preview MARC' links show as buttons in batch record mod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161 --- Comment #1 from Aleisha Amohia --- Created attachment 54726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54726&action=edit Bug 17161: Making 'Preview MARC' links show as buttons in batch record modification This patch removes the column heading and makes all links show as font awesome buttons. I have also changed the wording from Preview MARC to Show MARC to shorten the button and be consistent with other places in Koha To test: 1) Go to Tools -> Batch record modification 2) Put in some record numbers and click Continue 3) Ensure column heading 'Preview' no longer shows, and buttons are showing with an appropriate icon. Confirm button still works as expected. 4) Confirm button does not wrap on narrower browser Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17161] Making 'preview MARC' links show as buttons in batch record mod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161 Aleisha Amohia changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17161] New: Making 'preview MARC' links show as buttons in batch record mod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161 Bug ID: 17161 Summary: Making 'preview MARC' links show as buttons in batch record mod Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: aleishaamo...@hotmail.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17147] Streamline messages following batch record modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17147] Streamline messages following batch record modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Aleisha Amohia changed: What|Removed |Added Attachment #54572|0 |1 is obsolete|| --- Comment #2 from Aleisha Amohia --- Created attachment 54725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54725&action=edit [SIGNED-OFF] Bug 17147 - Streamline messages following batch record modification This patch changes the display of informational messages during and after the batch record modification process. Instead of showing a separate dialog for each record modified, messages are now grouped into one dialog. To test, apply the patch and clear your browser cache if necessary. You must have at least one MARC modification template defined. - Go to Tools -> Batch record modification. - Submit a list of biblionumbers which contains at least one number which doesn't exist in your database. - Confirm that warning and success messages are grouped instead of showing in separate dialogs. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13949] Item search should have holding library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949
Aleisha Amohia changed:
What|Removed |Added
Attachment #54574|0 |1
is obsolete||
--- Comment #5 from Aleisha Amohia ---
Created attachment 54724
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54724&action=edit
[SIGNED-OFF] Bug 13949 - Item search should have holding library
This patch adds holding library ("current location") to the list of
fields available in the item search form.
To test, apply the patch and go to Search -> Item search.
- Perform a search using the "current location" option and verify that
it returns the correct results.
- Try other searches to confirm that they work as before.
Signed-off-by: Aleisha Amohia
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13949] Item search should have holding library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11019] Require some fields when adding authorized value category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019 Aleisha Amohia changed: What|Removed |Added Attachment #54577|0 |1 is obsolete|| --- Comment #12 from Aleisha Amohia --- Created attachment 54723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54723&action=edit [SIGNED-OFF] Bug 11019 - Require some fields when adding authorized value category This patch modifies the form for adding an authorized value so that category, authorized value, and description are required fields. Previously a new authorized value category could be saved with no data. To test, apply the patch and go to Administration -> Authorized values. - Click the "New category" button. - Click the save button without filling in category, authorized value, or description. You should be prevented from submitting the form. - Verify that filling in the required fields allows the form to be submitted. - Perform the same test when editing an existing authorized value. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11019] Require some fields when adding authorized value category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17149] EDI accounts: Add missing '>' to breadcrumb
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17149 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17149] EDI accounts: Add missing '>' to breadcrumb
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17149 Aleisha Amohia changed: What|Removed |Added Attachment #54583|0 |1 is obsolete|| --- Comment #3 from Aleisha Amohia --- Created attachment 54722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54722&action=edit [SIGNED-OFF] Bug 17149 - EDI accounts: Add missing '>' to breadcrumb To verify: Breadcrumb on "EDI accounts" pages reads Home > Administration EDI accounts > Modify account instead of: Home > Administration > EDI accounts > Modify account To test: - Apply patch - Add, edit and delete an EDI account - Verify that breadcrumb displays properly Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17144] Fix variable scope issue in edi_accounts.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17144 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com --- Comment #2 from Aleisha Amohia --- I am not able to reproduce the bug. Can you please check? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16990] Show branch name instead of branch code when managing patron modification requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16990 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16990] Show branch name instead of branch code when managing patron modification requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16990 Aleisha Amohia changed: What|Removed |Added Attachment #54627|0 |1 is obsolete|| --- Comment #2 from Aleisha Amohia --- Created attachment 54721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54721&action=edit [SIGNED-OFF] Bug 16990: Display branch names instead of code in patron mod requests To test: - change your homebranch in the OPAC, submit - change patron modification request in the staff client - Verify that it shows the old and new branch name instead of the code Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13921] XSLT Literary Formats Not Showing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921 Aleisha Amohia changed: What|Removed |Added Attachment #54640|0 |1 is obsolete|| --- Comment #3 from Aleisha Amohia --- Created attachment 54720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54720&action=edit [SIGNED-OFF] Bug 13921 - XSLT Literary Formats Not Showing This patch adds some missing literary formats to the staff client and OPAC's search results XSLT display. To test you must have DisplayOPACiconsXSLT and DisplayIconsXSLT system preferences enabled. XSLTResultsDisplay and OPACXSLTResultsDisplay should be set to 'default.' Perform searches in the staff client and the OPAC and confirm that the following literary forms (defined in 008 position 33) display correctly: Not fiction; Fiction; Dramas; Essays; Novels; Humor, satires, etc.; Letters; Short stories; Mixed forms; Poetry; Speeches. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13921] XSLT Literary Formats Not Showing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #52 from Bernardo Gonzalez Kriegel --- With all patches applied, all test succeed with Marc fix :) git log --oneline | head -16 c1bfb24 Bug 16554: More i18n changes - uk-UA files 23001ea Bug 16554: More i18n changes - ru-RU files ca09bf0 Bug 16554: More i18n changes - fr-FR files 72ca21d Bug 16554 - DO NOT PUSH - Follow up to testing script 4c32489 Bug 16554: Fix encoding on it-IT file 0644c60 Bug 16554: rewrite mandatory and sample data - de-DE 989c319 Bug 16554: rewrite mandatory and sample data - it-IT 9c6ce1d Bug 16554: More i18n changes - en, es, nb and pl files c85d6e7 Bug 16554: DO NOT PUSH - (followup) - sorted filenames 79c2f1f Bug 16554: DO NOT PUSH - test for all sample files 1442061 Bug 16554: rewrite mandatory and sample data - pl-PL 596721f Bug 16554: rewrite mandatory and sample data - nb-NO 63afd53 Bug 16554: rewrite mandatory and sample data - es-ES 83b2d0d Bug 16554: Fix I18N sample files 1ba4ed1 Bug 16554: Fix fr-FR sample files 3315a88 Bug 17023: Repair "cancel" link ... ok All tests successful. Files=1, Tests=1, 3975 wallclock secs ( 0.24 usr 0.02 sys + 10.02 cusr 1.48 csys = 11.76 CPU) Result: PASS Dropping and re-creating database and running for fr-FR only it's Ok, all success. $ prove -v t/db_dependent/Test_installer.t t/db_dependent/Test_installer.t .. DBD::mysql::db do failed: Table 'koha_test_installer.systempreferences' doesn't exist [for Statement " SELECT * FROM systempreferences WHERE 1 = 0 "] at /home/bgkriegel/kohaclone/Koha/Database.pm line 93. loading kohastructure for fr-FR | not marc21 # 01/26: /home/bgkriegel/kohaclone/installer/data/mysql/audio_alerts.sql ... # 26/26: /home/bgkriegel/kohaclone/installer/data/mysql/fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/framework_DEFAULT.sql loading kohastructure for fr-FR | not unimarc # 01/24: /home/bgkriegel/kohaclone/installer/data/mysql/audio_alerts.sql ... # 24/24: /home/bgkriegel/kohaclone/installer/data/mysql/fr-FR/marcflavour/marc21/Optionnel/marc21_simple_bib_frameworks.sql ok 1 - No failures 1..1 ok All tests successful. Files=1, Tests=1, 327 wallclock secs ( 0.05 usr 0.00 sys + 2.01 cusr 0.22 csys = 2.28 CPU) Result: PASS Don't know what to think :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17153] Logging in during a search navigates to account page instead of back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Aleisha Amohia changed: What|Removed |Added Attachment #54715|0 |1 is obsolete|| --- Comment #5 from Aleisha Amohia --- Created attachment 54719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54719&action=edit [SIGNED-OFF] Bug 17153: Logging in during a search should navigate back to search results Forces redirect to search results after logging in on opac-search.pl To test: - Perform a catalog or EDS search - Login from opac-search.pl - Without the patch, the page should redirect to opac-user.pl - Log out - Apply patch - Perform a search again - Login again from opac-search.pl - The page should redirect back to search results Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17153] Logging in during a search navigates to account page instead of back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17006] REST API: add route to change patron's password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 --- Comment #7 from Aleisha Amohia --- Created attachment 54718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54718&action=edit [SIGNED-OFF] Bug 17006: Respect system preference "OpacPasswordChange" Allow patron to change their own password without borrowers-flag only if OpacPasswordChange system preference is enabled. To test: 1. Apply patch 2. Run t/db_dependent/api/v1/patrons.t 3. Set OpacPasswordChange system preference to "Don't allow". 4. Send PATCH request to http://library/api/v1/patrons/YYY/password where YYY is existing borrowernumber for a borrower that does not have any permissions 5. Observe permission error. 6. Set OpacPasswordChange system preference to "Allow". 7. Repeat step 4 and make sure that password was changed. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17006] REST API: add route to change patron's password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006
Aleisha Amohia changed:
What|Removed |Added
Attachment #54716|0 |1
is obsolete||
--- Comment #6 from Aleisha Amohia ---
Created attachment 54717
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54717&action=edit
[SIGNED-OFF] Bug 17006: Add API route for changing patron's password
PATCH /patrons/{borrowernumber}/password (change password)
Required body params:
- current_password
- new_password
To test:
1. Apply patch
2. Run t/db_dependent/api/v1/patrons.t
3. Send PATCH request to http://library/api/v1/patrons/YYY/password
where YYY is existing borrowernumber (borrowers flag required)
4. Make sure that password was changed.
5. Try also too short password, and wrong current password and observe
that errors are displayed appropriately.
You may find this useful for testing:
curl -X PATCH http://library/api/v1/patrons/123/password
--data '{"current_password":"123456", "new_password":"1234"}'
--cookie 'CGISESSID=055ca5a9a3ad3fb5052143bd015c1c10'
Signed-off-by: Aleisha Amohia
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17006] REST API: add route to change patron's password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006
Aleisha Amohia changed:
What|Removed |Added
Attachment #54629|0 |1
is obsolete||
Attachment #54630|0 |1
is obsolete||
--- Comment #5 from Aleisha Amohia ---
Created attachment 54716
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54716&action=edit
[SIGNED-OFF] Bug 17006: Add API route for changing patron's password
PATCH /patrons/{borrowernumber}/password (change password)
Required body params:
- current_password
- new_password
To test:
1. Apply patch
2. Run t/db_dependent/api/v1/patrons.t
3. Send PATCH request to http://library/api/v1/patrons/YYY/password
where YYY is existing borrowernumber (borrowers flag required)
4. Make sure that password was changed.
5. Try also too short password, and wrong current password and observe
that errors are displayed appropriately.
You may find this useful for testing:
curl -X PATCH http://library/api/v1/patrons/123/password
--data '{"current_password":"123456", "new_password":"1234"}'
--cookie 'CGISESSID=055ca5a9a3ad3fb5052143bd015c1c10'
Signed-off-by: Aleisha Amohia
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17006] REST API: add route to change patron's password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17048] Authority search result list page scrolling not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com --- Comment #6 from Aleisha Amohia --- I cannot reproduce the bug. Can someone check to see if this patch is still necessary? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11895] Keep stats on course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11895 --- Comment #3 from Tom Misilo --- Yes it was in regards to course reserves -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11895] Keep stats on course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11895 Katrin Fischer changed: What|Removed |Added Summary|Keep stats on reserves |Keep stats on course ||reserves CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Rereading this I think Nicole was referring to course reserves - not holds. Changing the title. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10814] Add a link to shelving locations / LOC authorised value for pointing to a map or similar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10814 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|add a link to an authorized |Add a link to shelving |value |locations / LOC authorised ||value for pointing to a map ||or similar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9790] move item specific holds to circ matrix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9790 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Item specific holds are now managed in the circulation conditions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9699] Allow patrons to see notices sent to them in their OPAC account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9699 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|allow patrons to see notice |Allow patrons to see |log |notices sent to them in ||their OPAC account -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17004] REST API: add route to authenticate patron ( Single Sign On - SSO)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004
Benjamin Rokseth changed:
What|Removed |Added
CC||benjamin.roks...@kul.oslo.k
||ommune.no
--- Comment #12 from Benjamin Rokseth ---
wow, amazing work! very much like the code we use in production, but better!
AND with test coverage ;)
Would it be possible to also supply patron permissions in the response? I found
the easiest way was to just iterate against haspermissions thus:
+ my $permissions = haspermission($userid); # defaults to all permissions
+ # delete all empty permissions
+ while ( my ($key, $val) = each %{$permissions} ) {
+ delete $permissions->{$key} unless $val;
+ }
then you could just return $permission as a hash object
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Severity|major |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #3 from Christopher Brannon --- I have just confirmed this issue. I have tested the SIP response and can see the AF field cycling through different responses each time we scan the item. This is pretty messed up. Our self check has been showing the name of the patron the item is on hold for in some instances. Would love to see this fixed ASAP. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #3 from M. Tompsett --- (In reply to David Cook from comment #2) > I don't know if that means that people are using the Indexdata repositories > or if they're just ignoring erroneous behaviour in Zebra when using ICU... Probably the latter. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14535] Late orders doensn't show orders with price = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535 --- Comment #5 from Sandre Cunha --- I don't think it would be a problem if the 0-priced items showed up on the late list. I don't have a suggestion as I don t quite understand the intended purpose of including 129 AND aqorders.rrp <> 0 130 AND aqorders.ecost <> 0 in the selection, and what the ramifications of removing one or both would be. We do not "track" gifts in the manner you described, as ours are either gifts of physical items or monetary donations (from which items are ordered in the usual way, but from a trust fund account.) A larger problem is that we do so much ordering of pre-publication items, and there is no way to adjust the "lateness" according to the scheduled publication date. For example, right now we have a purchase suggestion for an item that will not be published until April 2017. We want to make the order to get the item (by a popular author) into the OPAC so patrons can see it is on order and place holds, but if I do that now, the item would be "late" in 30 days, even though it will not be published for 6 months. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14535] Late orders doensn't show orders with price = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535 --- Comment #4 from Katrin Fischer --- Hi Sandre, what is your suggestion to resolve this? Would it be a problem if those showed up as late orders after the normal period? How are you treating gifts? I think one of the libraries explained that they use 0 for tracking gifts that they expect to receive or have asked for or when they don't know how much an item will cost. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390
--- Comment #49 from Marcel de Rooy ---
(In reply to Kyle M Hall from comment #48)
> (In reply to Katrin Fischer from comment #45)
> > > How to solve this? Can we remove the issue id in accountlines after
> > > switching to F? Or should UpdateFine no longer update a F record although
> > > it
> > > has the right issue id, but add a new record?
> >
> > I think it should add a new line as it's a 'new fine'. If we differentiate
> > between F and FU cleanly, we can keep the issue_id too, I think?
>
> Katrin has is exactly. If the same checkout goes overdue twice, the patron
> should have two separate fines ( and each one will show a different due date
> for the same checkout ).
>
> This new followup will stop UpdateFine from updating closed out fines.
We are coming closer to a solution!
But please note that we need type F (imo) in the totalamount calculation and
the max fine reduction. We should focus on what happens next in UpdateFine.
The test $data->{'amount'} != $amount is not sufficient. Here we should exclude
type F somehow. But take care with $type that you get from CalcFine. It may not
be what you expect it to be ..
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8073] Sound cue when checking in items on hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8073 --- Comment #3 from Cab Vinton --- OK, thank you, Katrin! For anyone else tracking this, ByWater has a helpful tutorial on how to use the AudioAlerts functionality here: http://bywatersolutions.com/2016/04/19/koha-3-22-custom-sound-alerts/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16593] Access Control - Malicious user can delete the search history of another user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16593 Chris Cormack changed: What|Removed |Added Component|Koha|OPAC Group|Koha security | QA Contact||testo...@bugs.koha-communit ||y.org Product|Koha security |Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
