[Koha-bugs] [Bug 10198] Add the ability to import and export authorized values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10198

Felix Hemme  changed:

   What|Removed |Added

 CC||felix.he...@thulb.uni-jena.
   ||de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

David Cook  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #27 from David Cook  ---
Kyle, I just reviewed the code, and it looks good to me.

Thanks for taking the time to test it :).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17193] C4::Search::SearchAcquisitions is not used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17193

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17197] misc/batchupdateISBNs.pl is certainly no longer in use

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17197

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17222] Remove use of onclick from OPAC member entry page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17222

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17222] Remove use of onclick from OPAC member entry page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17222

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17222] Remove use of onclick from OPAC member entry page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17222

--- Comment #1 from Aleisha Amohia  ---
Created attachment 54999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54999=edit
Bug 17222: Remove use of onclick from OPAC member entry page

There is only one instance on onclick here, and that is the clear date
function.

To test, make sure clicking 'Clear date' next to Date of Birth works the
same before and after the patch.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17222] New: Remove use of onclick from OPAC member entry page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17222

Bug ID: 17222
   Summary: Remove use of onclick from OPAC member entry page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17221] orphan comma in shelf browser

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

Eric Phetteplace  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17221] orphan comma in shelf browser

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

--- Comment #1 from Eric Phetteplace  ---
Created attachment 54998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54998=edit
patch

patch anticipates same problem with collection code in list, too

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP Replication not using autoMemberNum if configured

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215

Lee Jamison  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17221] orphan comma in shelf browser

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

Eric Phetteplace  changed:

   What|Removed |Added

 CC||ephettepl...@cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17221] orphan comma in shelf browser

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

Eric Phetteplace  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
  Change sponsored?|--- |Sponsored
   Assignee|oleon...@myacpl.org |ephettepl...@cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17152] Duplicating a subfield should not copy the data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||hector.hecax...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17221] New: orphan comma in shelf browser

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

Bug ID: 17221
   Summary: orphan comma in shelf browser
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: ephettepl...@cca.edu
QA Contact: testo...@bugs.koha-community.org

Created attachment 54997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54997=edit
screenshot of bug

Example screenshot attached, here's the bib record in our catalog:

https://library.cca.edu/cgi-bin/koha/opac-detail.pl?biblionumber=21729_itemnumber=34420#holdings

Basically, since starting_homebranch is null in the template file, nothing is
printed out, but the next IF condition wrongly assumes that the first must have
been true and prints out a comma before it's text string. Steps to recreate:

- in settings, set ShelfBrowserUsesHomeBranch to "Don't Use"
- set ShelfBrowserUsesLocation to "Use"
- visit an item, click the "Browse shelf" link in the Holdings' tab's Call
Number column
- note the extraneous comma in the  tag that appears

Patch coming shortly, it appears that simply adding an additional condition
around the comma itself should resolve this problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17152] Duplicating a subfield should not copy the data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #54784|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 54996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54996=edit
[SIGNED-OFF]Bug 17152: Do not copy value when duplicating a subfield

When cataloguing, if you want to duplicate a subfield that is not
empty, the new subfield is created with a copy of data in it.
This is not the case when you duplicate an whole field. The new one is
created with subfields but without data in it.

Test plan:
Add or edit a bibliographic record
Fill a subfield
Duplicate the subfield
=> Without this patch the value of the input will be copied
=> With this patch the new input will be emptied

Signed-off-by: Hector Castro 
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17220] Improve clarity when placing a hold by changing button text from " Place hold" to "Confirm hold"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17220

Lee Jamison  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #2 from Lee Jamison  ---
(In reply to Lee Jamison from comment #1)
> Created attachment 54995 [details] [review]
> Changes button text of opac-reserve.pl

To test:
1. Login to the OPAC.
2. Place a hold on an item.
3. On the opac-reserve.pl screen make note of the button text "Place hold".
4. Cancel the hold and return to the homepage.
5. Apply the patch.
6. Place a hold on an item.
7. On the opac-reserve.pl screen make note of the button text which should now
be "Confirm hold".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17220] Improve clarity when placing a hold by changing button text from " Place hold" to "Confirm hold"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17220

--- Comment #1 from Lee Jamison  ---
Created attachment 54995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54995=edit
Changes button text of opac-reserve.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17220] New: Improve clarity when placing a hold by changing button text from " Place hold" to "Confirm hold"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17220

Bug ID: 17220
   Summary: Improve clarity when placing a hold by changing button
text from "Place hold" to "Confirm hold"
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: ldjami...@marywood.edu
QA Contact: testo...@bugs.koha-community.org

When placing a hold from the OPAC, patrons may be confused about clicking
"Place hold" twice during the reserve process (once from their search results
list/bib record detail then the second time when confirming the hold(s) to be
placed via the "Place hold" button). To improve clarity, changing the button
text from "Place hold" to "Confirm hold" can reduce patron confusion as it
eliminates duplication of text.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17219] SPAM

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17219

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17219] SPAM

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17219

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
Summary|((US).<><><><><<<.l |SPAM
   |8004452790+++<><><> |
   | CANON PRINTER TECH |
   |support phone number,CANON  |
   |printer helpline number |
   |USA...FLORIDA   |
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #39 from Owen Leonard  ---
- With my date format preference set to US (mm/dd/) it accepts dates like
3/3/2016. Sometimes saving this date triggers an error in Koha, sometimes the
date is ignored (and no date is saved).

- With my date format preference set to dmydot (dd.mm.) it accepts dates
like 1.1.2016 without any warning, but the date which is saved does not match
(in this case, 12.09.2016). The same thing happens with dd/mm/, including
the saved date -- 12/09/2016.

- I'm getting no warnings on the patron edit page when adding invalid data to
the date of birth field. It works correctly with registration date and
expiration date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17218] New: New list add attempt while logged in as dbadmin should be prevented pre-emptively

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218

Bug ID: 17218
   Summary: New list add attempt while logged in as dbadmin should
be prevented pre-emptively
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Lists
  Assignee: gmcha...@gmail.com
  Reporter: indr...@l2c2.co.in
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Right now it allows the Koha db admin login to attempt adding a new list. Only
while trying to save it does it inform that it is not possible to do so. This
is should be made pre-emptive right after the "+ New list" option is clicked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #15 from Owen Leonard  ---
- bug_17216_2_add_fk.sql is still missing a semicolon on the 'UPDATE
marc_subfield_structure' line.
- Shouldn't category be required in the "New category" form?
- In testing the effect of these patches on marc_subfield_structure.pl, what
should we be looking for? Simply that the categories show up correctly?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #14 from Jonathan Druart  
---
Created attachment 54993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54993=edit
Bug 17216: Use Koha::AVC from mss.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #13 from Jonathan Druart  
---
Created attachment 54992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54992=edit
Bug 17216: Add FK on mss.authorised_value

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #11 from Jonathan Druart  
---
Created attachment 54990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54990=edit
Bug 17216: DBIC Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #12 from Jonathan Druart  
---
Created attachment 54991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54991=edit
Bug 17216: Update the admin interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #10 from Jonathan Druart  
---
Created attachment 54989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54989=edit
Bug 17216: Add some other AV categories

Found in
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #9 from Jonathan Druart  
---
Created attachment 54988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54988=edit
Bug 17216: Add new table authorised_value_categories and populate it

This patch set adds a new table authorised_value_categories to store
authori(s|z)ed value categories into a separate table.
The problematic is explained on bug 15799 comment 4:
We need FK to the AV categories but some may not have authorized values
yet.

What does this patch set:
- Add a new authorised_value_categories table
- Populate it with known categories
- Update FK items_search_fields.authorised_values_category
- Create a new FK marc_subfield_structure.authorised_value (FIXME should
  be authorised_value_categories instead)

They are some problems this patch set do not take into account:
- The .sql installer files won't insert correctly (will have to be
  updated when this patch set will be ready to be pushed)
- All the categories (even the ones without authorized values defined)
  are listed when you edit frameworks (marc_subfield_structure.pl)
- There is no way to delete a category (TODO). But to do so it would be
  good to have a authorised_value_categories.is_internal field to mark
  some categories as "cannot be deleted".

Test plan:
0/ Execute the DB entry to create and populate the new table and set the FK
1/ Create a new AV category from the admin module (admin/authorised_values.pl)
2/ Add/edit subfield linked to a AV category
(admin/marc_subfield_structure.pl)
3/ You won't be allowed to add AV for branches, itemtypes or cn_source.
They are used internally.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54979|0   |1
is obsolete||
  Attachment #54980|0   |1
is obsolete||
  Attachment #54981|0   |1
is obsolete||
  Attachment #54982|0   |1
is obsolete||
  Attachment #54983|0   |1
is obsolete||
  Attachment #54984|0   |1
is obsolete||
  Attachment #54985|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 54987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54987=edit
Bug 17216: Add Koha::AuthorisedValueCategory|ies classes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #13 from Benjamin Daeuber  ---
(In reply to Matthias Meusburger from comment #12)
> Benjamin, can you post your MarcItemFieldsToOrder as well, please?

price: 975$p
quantity: 975$q
budget_code: 975$h

We just copied ours from the MarcFieldsToOrder. Note that though the fund code
did exist, we needed to manually select it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #33 from Owen Leonard  ---
The term "reserve group" is inconsistent with our terminology guidelines. I
think it should be "hold group." The word "reserve" is associated only with
course reserves.

https://wiki.koha-community.org/wiki/Terminology

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17072] 006 not filling in with existing values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17072

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
Summary|007 not filling in with |006 not filling in with
   |existing values |existing values

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #4 from Jonathan Druart  
---
Created attachment 54982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54982=edit
Bug 17216: DBIC Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #5 from Jonathan Druart  
---
Created attachment 54983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54983=edit
Bug 17216: Update the admin interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #3 from Jonathan Druart  
---
Created attachment 54981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54981=edit
Bug 17216: Add some other AV categories

Found in
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #7 from Jonathan Druart  
---
Created attachment 54985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54985=edit
Bug 17216: Use Koha::AVC from mss.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17201] Remaining calls to C4::Context->marcfromkohafield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

--- Comment #13 from Jonathan Druart  
---
Fixed commit author name

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17201] Remaining calls to C4::Context->marcfromkohafield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54959|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17201] Remaining calls to C4::Context->marcfromkohafield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17201

--- Comment #12 from Jonathan Druart  
---
Created attachment 54986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54986=edit
[PASSED QA] Bug 17201: (bug 16431 follow-up2) Remove occurrence of
marcfromkohafield

I really don't know how these tests passed before 16431, the mapping was not
complete.

Test plan:
  prove t/db_dependent/Search.t
should return green

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15799] Move authorised values related code into Koha:: AuthorisedValues - part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799

--- Comment #5 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #4)

New table created on bug 17216 - Add a new table to store authorized value
categories.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #6 from Jonathan Druart  
---
Created attachment 54984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54984=edit
Bug 17216: Add FK on mss.authorised_value

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #2 from Jonathan Druart  
---
Created attachment 54980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54980=edit
Bug 17216: Add new table authorised_value_categories and populate it

This patch set adds a new table authorised_value_categories to store
authori(s|z)ed value categories into a separate table.
The problematic is explained on bug 15799 comment 4:
We need FK to the AV categories but some may not have authorized values
yet.

What does this patch set:
- Add a new authorised_value_categories table
- Populate it with known categories
- Update FK items_search_fields.authorised_values_category
- Create a new FK marc_subfield_structure.authorised_value (FIXME should
  be authorised_value_categories instead)

They are some problems this patch set do not take into account:
- The .sql installer files won't insert correctly (will have to be
  updated when this patch set will be ready to be pushed)
- All the categories (even the ones without authorized values defined)
  are listed when you edit frameworks (marc_subfield_structure.pl)
- There is no way to delete a category (TODO). But to do so it would be
  good to have a authorised_value_categories.is_internal field to mark
  some categories as "cannot be deleted".

Test plan:
0/ Execute the DB entry to create and populate the new table and set the FK
1/ Create a new AV category from the admin module (admin/authorised_values.pl)
2/ Add/edit subfield linked to a AV category
(admin/marc_subfield_structure.pl)
3/ You won't be allowed to add AV for branches, itemtypes or cn_source.
They are used internally.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #1 from Jonathan Druart  
---
Created attachment 54979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54979=edit
Bug 17216: Add Koha::AuthorisedValueCategory|ies classes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #12 from Matthias Meusburger  ---
Benjamin, can you post your MarcItemFieldsToOrder as well, please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #11 from Matthias Meusburger  ---
Nick, no items were created using your sample file because it does not contain
any homebranch informations.

Currently, homebranch fields are used to know how many items should be added.
Is there a better option?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17217] Allow to reserve first available item from a group of titles ( OPAC)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17217

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17217] Allow to reserve first available item from a group of titles ( OPAC)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17217

--- Comment #1 from Julian Maurice  ---
Created attachment 54978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54978=edit
Bug 17217: Allow to reserve first available item from a group of titles (OPAC)

Depends on bug 15516

Test plan:
0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl
1. Go to OPAC search, display some results, click on some checkboxes and
   click on 'Place hold' button at the top of the results
2. Check the box with label "Place a hold on the first available..."
3. Check that more options appear (Pickup location, hold dates and
   notes).
4. Click on 'Place hold'
5. Now go to intranet interface and check in an item of one of the
   reserved biblios and confirm the hold
6. The hold status should have been changed to Waiting, and all other
   holds should have been deleted

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17217] New: Allow to reserve first available item from a group of titles (OPAC)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17217

Bug ID: 17217
   Summary: Allow to reserve first available item from a group of
titles (OPAC)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 15516

This bug follows bug 15516.

This is the OPAC part


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
[Bug 15516] Allow to reserve first available item from a group of titles
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Julian Maurice  changed:

   What|Removed |Added

 Blocks||17217


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17217
[Bug 17217] Allow to reserve first available item from a group of titles (OPAC)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #32 from Julian Maurice  ---
Created attachment 54977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54977=edit
Bug 15516: Set reserve-group.pl to be executable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15799] Move authorised values related code into Koha:: AuthorisedValues - part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17216


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216
[Bug 17216] Add a new table to store authorized value categories
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] New: Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Bug ID: 17216
   Summary: Add a new table to store authorized value categories
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Blocks: 15799

The way we manage authorized values is not consistent: Some are present in the
DB, others are not (see bug 15799 comment 4 for more details).
Worse, most of the time the FK does not exist (and datatype is not consistent:
varchar 32 vs 20, 16,...).

To help cleaning up this area, a new table to store authorized value categories
would be helpful.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799
[Bug 15799] Move authorised values related code into Koha::AuthorisedValues -
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17211] Remove use of onclick from OPAC fines page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17211

Owen Leonard  changed:

   What|Removed |Added

  Attachment #54969|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 54976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54976=edit
[SIGNED-OFF] Bug 17211: Remove use of onclick from OPAC fines page

To test:
1) Set the EnablePayPalOpacPayments syspref to Allow and the
   PayPalSandboxMode to the appropriate mode
2) Go to OPAC fines
3) Confirm clicking the PayPal image link works the same before and
   after the patch (opens pop up window)

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17211] Remove use of onclick from OPAC fines page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17211

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17210] Remove use of onclick from biblio detail sidebar in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17210] Remove use of onclick from biblio detail sidebar in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210

Owen Leonard  changed:

   What|Removed |Added

  Attachment #54968|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 54975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54975=edit
[SIGNED-OFF] Bug 17210: Remove use of onclick from biblio detail sidebar in
OPAC

Four instances of onclick here:
1) Print
2) Save to your lists
3) Add to your cart
4) Remove from cart

To test:
Find a biblio detail page in OPAC and confirm all four events above work
as expected before and after the patch.

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17209] Remove use of onclick from masthead

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17209] Remove use of onclick from masthead

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209

Owen Leonard  changed:

   What|Removed |Added

  Attachment #54966|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 54974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54974=edit
[SIGNED-OFF] Bug 17209: Remove use of onclick from masthead

There are two instances which use onclick in the OPAC masthead: clearing
search history, and logging out.

To test:
Confirm that clearing search history using the 'x' in the masthead, and
logging out by clicking 'Log out' in the masthead, work the same before
and after the patch.

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP Replication not using autoMemberNum if configured

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215

--- Comment #1 from Lee Jamison  ---
Created attachment 54973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54973=edit
Assigns numerical cardnumber if autoMemberNum is enabled

This patch modifies Auth_with_ldap.pm to use the autoMemberNum System
Preference if it's enabled.

To test:
1. Set the autoMemberNum System Preference to "Don't".
2. Login to the OPAC with an LDAP account that does not currently exist as a
patron record.
3. Check the patron record's cardnumber.
4. the cardnumber should equal the patron's LDAP username.
5. Delete the patron record.
6. Apply the patch.
7. Set the autoMemberNum System Preference to "Do".
8. Login to the OPAC with an LDAP account that does not currently exist as a
patron record.
9. Check the patron record's cardnumber.
10. The cardnumber should now be the next highest cardnumber based on
autoMemberNum.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17214] Add item in LIST by Record number

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #1 from M. Tompsett  ---
While record number is a bad idea, biblionumber, would be okay.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17215] New: Cardnumbers of patrons created using LDAP Replication not using autoMemberNum if configured

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215

Bug ID: 17215
   Summary: Cardnumbers of patrons created using LDAP Replication
not using autoMemberNum if configured
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ldjami...@marywood.edu
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When using LDAP and leveraging the 'replicate' flag, patrons who are replicated
have their cardnumber assigned equal to their LDAP username. This is an
inconsistency when the 'autoMemberNum' System Preference is set to 'Do'. When
'autoMemberNum' is set to 'Don't' then replicate should act as it currently
does.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17214] New: Add item in LIST by Record number

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214

Bug ID: 17214
   Summary: Add item in LIST by Record number
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Lists
  Assignee: gmcha...@gmail.com
  Reporter: mishrav...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Once the LIST is created in Koha you can add item in that by barcode but is
there any option to add item by record number because if there is no barcode
assigned to the item how it can be added to the list? For example in case of
remotely available resources like e-book/e-journals where library may enter
only bibliographic details.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #24 from Jacek Ablewicz  ---
(In reply to Katrin Fischer from comment #17)
> If we don't do 3) - would the fines still be calculated correctly?

You mean 3.b part (correcting the dates in description)? IMO after Bug 15675
this shouldn't affect further fines calculation (no matter if this date stays
as is or is optionally corrected). Post-Bug 15675, date in the description is
not used in UpdateFine() for anything important any more. It still gets
inserted to the description when new FU fine is created though, and because
it's not modified on the possible overwrite, it may by useful for two goals:

- pre-selecting the accountlines which may be non-accruing and still in a need
of closing,
- recovering the possibly overwritten fines (if any).

If someone is inclined to do so (I'm not - we are not using 16.05 in production
yet), automatic or semi-automatic recovery of the overwritten fines is quite
possible IMO, with some extra time and effort (a lot of it, probably). If
FinesLog is enabled: in ~100% of cases (?), if not - I guess this date can
still be used at least to recreate the most recent overwrite of the given fine. 

The trouble with the optional 3.b part / date corrections is: it may make such
theoretical recovery process more complicated or even (if the logs are absent)
no longer possible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Marcel de Rooy  changed:

   What|Removed |Added

   Severity|blocker |major

--- Comment #23 from Marcel de Rooy  ---
Severity to major ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |a...@biblos.pk.edu.pl
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #22 from Marcel de Rooy  ---
Change title of this report ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #21 from Marcel de Rooy  ---
Jacek, Just a quick glance:
Why Warn ? We always just warn.
Add a dbrev that at least prints a NOTE: <> that tells the
sysadmin to optionally run your script when upgrading.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #20 from Jacek Ablewicz  ---
Created attachment 54972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54972=edit
Bug 17135 - Fine for the previous overdue may get overwritten by the next one

External maintenace script for fixing unclosed (FU), non accruing fine
records which may still need FU -> F correction post-Bug 15675.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Jacek Ablewicz  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17213] Self registration cardnumber is not editable if errors found when form submitted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213

--- Comment #2 from Nick Clemens  ---
Created attachment 54971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54971=edit
Bug 17213 - Add HTML5 validation to cardnumber field on patron self
registration

To test:
Verify that different values in 'CardnumberLength' system preference
display correctly in the self reigstration form

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17213] Self registration cardnumber is not editable if errors found when form submitted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213

--- Comment #1 from Nick Clemens  ---
Created attachment 54970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54970=edit
Bug 17213 -  Self registration cardnumber is not editable if errors found when
form submitted

To test:
Enable self registration
Make sure cardnumber is not in
'PatronSelfRegistrationBorrowerUnwantedField'
Enter an invalid or used cardnumber
Submit form
Note errors appears correctly but cardnumber is not editable
Apply Patch
Enter an invalid or used cardnumber
Submit form
Note errors appears correctly and cardnumber is editable

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17213] Self registration cardnumber is not editable if errors found when form submitted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17213] Self registration cardnumber is not editable if errors found when form submitted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213

Nick Clemens  changed:

   What|Removed |Added

 Depends on||14659


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659
[Bug 14659] Allow patrons to enter card number and patron category on OPAC
registration page
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17213] New: Self registration cardnumber is not editable if errors found when form submitted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213

Bug ID: 17213
   Summary: Self registration cardnumber is not editable if errors
found when form submitted
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To recreate:
Make sure cardnumber is not in 'PatronSelfRegistrationBorrowerUnwantedField' 
Register a new patron using an existing cardnumber
You get a 'card number is in use' error, but you can't edit the field

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659

Nick Clemens  changed:

   What|Removed |Added

 Blocks||17213


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213
[Bug 17213] Self registration cardnumber is not editable if errors found when
form submitted
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #30 from Jonathan Druart  
---
(In reply to Benjamin Rokseth from comment #26)
> (In reply to Jonathan Druart from comment #21)
> > Are you sure we want to raise such specific error like "library does not
> > exist" or "category does not exist"?
> > I'd go for an eval { $patron->store } and return a 500 if something went
> > wrong.
> 
> 
> Well, yes and no. If missing category or branch is not part of error
> response, it is no good. API user must not be expected to know about koha
> internal dependencies, so a generic internal server response is not a good
> option.
> 
> That being said, the Patron object is probably the best place to handle
> exceptions, e.g. Bug 16907. So if patron->store gives the needed feedback,
> it is no point duplicating code/logic in api.
> 
> So yes, I agree, but am a bit unsure about alternatives?

Actually if you call $patron->store and a FK is wrong/missing, DBIx::Class will
raise the relevant DBI error, something like:

DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_ut`.`borrowers`, CONSTRAINT `borrowers_ibfk_1` FOREIGN
KEY (`categorycode`) REFERENCES `categories` (`categorycode`)).

That's why I think we should not handle it somewhere else.

Of course it would be better to get something more readable for the response :)
Did you mean we have to answer "This branchcode XYZ does not exist" or
something like "One of the parameter is wrong/missing" would be enough?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #29 from Jonathan Druart  
---
About tests: 1 subtest per route you test would be better for the readability.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #28 from Benjamin Rokseth  ---
(In reply to Jonathan Druart from comment #25)
> (In reply to Jonathan Druart from comment #24)
> > Comment on attachment 54942 [details] [review] [review]
> > Bug 16330: REST API: add routes to add, update and delete patrons
> > 
> > Review of attachment 54942 [details] [review] [review]:
> > -
> > 
> > ::: Koha/REST/V1/Patron.pm
> > @@ +172,5 @@
> > > +} elsif ($res eq '-1') {
> > > +return $c->$cb({}, 404);
> > > +} else {
> > > +return $c->$cb({}, 400);
> > > +}
> > 
> > It may be better to surround the ->delete with an eval, returns 200 if == 1
> > or log the error and return 500, don't you think?
> 
> Or 400 instead.

yes. Thanks for thorough feedback, btw!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #27 from Benjamin Rokseth  ---
(In reply to Jonathan Druart from comment #22)
> Comment on attachment 54942 [details] [review]
> Bug 16330: REST API: add routes to add, update and delete patrons
> 
> Review of attachment 54942 [details] [review]:
> -
> 
> ::: Koha/REST/V1/Patron.pm
> @@ +31,5 @@
> > +my $patrons;
> > +if (keys %$params) {
> > +my @valid_params = Koha::Patrons->columns;
> > +foreach my $key (keys %$params) {
> > +delete $params->{$key} unless grep { $key eq $_ } 
> > @valid_params;
> 
> Should not we raise an error instead of removing invalid params?

Absolutely right! Actually, it might be better to use formData and let swagger
definitions do the validation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #26 from Benjamin Rokseth  ---
(In reply to Jonathan Druart from comment #21)
> Are you sure we want to raise such specific error like "library does not
> exist" or "category does not exist"?
> I'd go for an eval { $patron->store } and return a 500 if something went
> wrong.


Well, yes and no. If missing category or branch is not part of error response,
it is no good. API user must not be expected to know about koha internal
dependencies, so a generic internal server response is not a good option.

That being said, the Patron object is probably the best place to handle
exceptions, e.g. Bug 16907. So if patron->store gives the needed feedback, it
is no point duplicating code/logic in api.

So yes, I agree, but am a bit unsure about alternatives?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #25 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #24)
> Comment on attachment 54942 [details] [review]
> Bug 16330: REST API: add routes to add, update and delete patrons
> 
> Review of attachment 54942 [details] [review]:
> -
> 
> ::: Koha/REST/V1/Patron.pm
> @@ +172,5 @@
> > +} elsif ($res eq '-1') {
> > +return $c->$cb({}, 404);
> > +} else {
> > +return $c->$cb({}, 400);
> > +}
> 
> It may be better to surround the ->delete with an eval, returns 200 if == 1
> or log the error and return 500, don't you think?

Or 400 instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #24 from Jonathan Druart  
---
Comment on attachment 54942
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54942
Bug 16330: REST API: add routes to add, update and delete patrons

Review of attachment 54942:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=16330=54942)
-

::: Koha/REST/V1/Patron.pm
@@ +172,5 @@
> +} elsif ($res eq '-1') {
> +return $c->$cb({}, 404);
> +} else {
> +return $c->$cb({}, 400);
> +}

It may be better to surround the ->delete with an eval, returns 200 if == 1 or
log the error and return 500, don't you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission checking

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

--- Comment #42 from Jonathan Druart  
---
Comment on attachment 54895
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54895
Bug 14868: Give users possibility to request their own object

Review of attachment 54895:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14868=54895)
-

::: Koha/REST/V1.pm
@@ +203,5 @@
> +
> +sub _object_ownership_by_borrowernumber {
> +my ($c, $user, $borrowernumber) = @_;
> +
> +return $user->borrowernumber == $borrowernumber;

I think it's not that easy. For instance at the OPAC, a patron is not allowed
to update his own details, it will need to be approved by a staff member.
Using the REST API he will be able to bypass the approval.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #23 from Jonathan Druart  
---
Comment on attachment 54942
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54942
Bug 16330: REST API: add routes to add, update and delete patrons

Review of attachment 54942:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=16330=54942)
-

::: Koha/REST/V1/Patron.pm
@@ +85,5 @@
> +Koha::Patron->new($body)->store;
> +};
> +
> +unless ($patron) {
> +return $c->$cb({error => "Something went wrong, check Koha logs for 
> details"}, 500);

You surrounded the store with an eval, so nothing will be logged.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #22 from Jonathan Druart  
---
Comment on attachment 54942
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54942
Bug 16330: REST API: add routes to add, update and delete patrons

Review of attachment 54942:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=16330=54942)
-

::: Koha/REST/V1/Patron.pm
@@ +31,5 @@
> +my $patrons;
> +if (keys %$params) {
> +my @valid_params = Koha::Patrons->columns;
> +foreach my $key (keys %$params) {
> +delete $params->{$key} unless grep { $key eq $_ } @valid_params;

Should not we raise an error instead of removing invalid params?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17212] New: ITEMTYPECAT broken if there is another authorised value with same code

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17212

Bug ID: 17212
   Summary: ITEMTYPECAT broken if there is another authorised
value with same code
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

The grouping of itemtypes on the advanced search doesn't work correctly, if
there is another authorised value in another category with the same code.

To test:
- Add a collection TEST with a description
- Add a ITEMTYPECAT TEST with a different description
- Use TEST to group some itemtypes together
- Take a look at OPAC advanced search - notice itemtypes are grouped, but
description of the collection is shown.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #21 from Jonathan Druart  
---
Are you sure we want to raise such specific error like "library does not exist"
or "category does not exist"?
I'd go for an eval { $patron->store } and return a 500 if something went wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14435] The table saved_reports is never populated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17067] Missing field "sms_provider_id" in database schema

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #6 from Katrin Fischer  ---
Problem solved :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17147] Streamline messages following batch record modification

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147

--- Comment #5 from Jonathan Druart  
---
Comment on attachment 54963
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54963
[SIGNED-OFF] Bug 17147 [Revised] Streamline messages following batch record
modification

Review of attachment 54963:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17147=54963)
-

::: koha-tmpl/intranet-tmpl/prog/css/staff-global.css
@@ +1138,5 @@
>   margin-top : .7em;
>  }
>  
> +div.message ul.fa-ul {
> +padding-left: 1em;

We don't use fa-ul in this template, why do you change its padding-left?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17067] Missing field "sms_provider_id" in database schema

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067

--- Comment #5 from Michael Kuhn  ---
I'm sorry - yes, I can also see it in master and 16_05 in the borrowers table
now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #6 from Jonathan Druart  
---
As bug 15758 is going to pass QA soon, it would be good to rebase this patch on
top of it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14435] The table saved_reports is never populated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435

--- Comment #30 from Jonathan Druart  
---
Hi Katrin,
This patch restore a broken behavior, instead of removing it completely.
If the feature is used and some guys want to improve it, let's them do it :)
I do not plan to improve it by myself, especially because IMO it's out of the
scope of this bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #19 from Marcel de Rooy  ---
What about:

Go thru all FU records.
Look up issue record.

If no issue record or CalcFine==0, consider as old fine. Move FU to F.
If CalcFine < accountlines.amount, new fine: move FU to F too. 
Otherwise: consider fine to be correct. Will be updated next run.

There will be some data loss. Left or right..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/