[Koha-bugs] [Bug 17309] New: Renewing and HomeOrHoldingBranch syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309 Bug ID: 17309 Summary: Renewing and HomeOrHoldingBranch syspref Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: ed.v...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When renewing an item the HomeOrHoldingBranch syspref is not taken into consideration and the issuing branch rules are applied. This can be a problem when the rules differ. Ed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17265] Make koha-create and koha-dump-defaults less greedy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17265 Andreas Roussos changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7 from Andreas Roussos --- Sorry, forgot to set Status to 'Signed Off', setting it now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17308] 'New patron attribute type' button does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 --- Comment #4 from Marc Véron --- Sorry, forgot sign-off line with previous patch... (Comment #2) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17308] 'New patron attribute type' button does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Marc Véron changed: What|Removed |Added Attachment #55628|0 |1 is obsolete|| --- Comment #3 from Marc Véron --- Created attachment 55629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55629&action=edit Bug 17308 - 'New patron attribute type' button does not work In the Staff client, the 'New patron attribute type' button in the Patron attribute types page does not work. This patch fixes that. Test plan: 1) In the Staff client, go to Home > Administration > Patron attribute types, and click on the 'New patron attribute type' button. You cannot create a new patron attribute type and you get the following Software error: Not a HASH reference at [...] 2) Apply the patch. 3) Repeat step 1). The 'New patron attribute type' button now works. Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17308] 'New patron attribute type' button does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17308] 'New patron attribute type' button does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Marc Véron changed: What|Removed |Added Attachment #55627|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 55628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55628&action=edit Bug 17308 - 'New patron attribute type' button does not work In the Staff client, the 'New patron attribute type' button in the Patron attribute types page does not work. This patch fixes that. Test plan: 1) In the Staff client, go to Home > Administration > Patron attribute types, and click on the 'New patron attribute type' button. You cannot create a new patron attribute type and you get the following Software error: Not a HASH reference at [...] 2) Apply the patch. 3) Repeat step 1). The 'New patron attribute type' button now works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17308] 'New patron attribute type' button does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Andreas Roussos changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |arouss1...@gmail.com |ity.org | URL||/cgi-bin/koha/admin/patron- ||attr-types.pl Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17308] 'New patron attribute type' button does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Andreas Roussos changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17308] 'New patron attribute type' button does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 --- Comment #1 from Andreas Roussos --- Created attachment 55627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55627&action=edit Bug 17308 - 'New patron attribute type' button does not work In the Staff client, the 'New patron attribute type' button in the Patron attribute types page does not work. This patch fixes that. Test plan: 1) In the Staff client, go to Home > Administration > Patron attribute types, and click on the 'New patron attribute type' button. You cannot create a new patron attribute type and you get the following Software error: Not a HASH reference at [...] 2) Apply the patch. 3) Repeat step 1). The 'New patron attribute type' button now works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17308] 'New patron attribute type' button does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #1 from J Schmidt --- Additionally, if possible, set up for Koha advanced editor macros should have a built-in shortcut tied to a function key (F1, F2) so that staff may input up to 9 different macros per login. Currently, staff need to mouse click to the field, then mouse click to the macro, then select the macro. The above would make things more efficient. (If you see how CTRL-D is used for inputting a delimiter, it would be like that). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17308] New: 'New patron attribute type' button does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Bug ID: 17308 Summary: 'New patron attribute type' button does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: arouss1...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Description of the problem: In the Staff client, the 'New patron attribute type' button in the Patron attribute types page does not work. Steps to reproduce (in the current master 0254fd7): Go to Home > Administration > Patron attribute types, and click on the 'New patron attribute type' button. You cannot create a new patron attribute type and you get the following Software error in the browser: Not a HASH reference at /home/aroussos/kohaclone/admin/patron-attr-types.pl line 89. I've found a way to fix this and will submit a patch soon. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 J Schmidt changed: What|Removed |Added CC||jschm...@switchinc.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17294] reserves_stats.pl is not plack safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17294 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17294] reserves_stats.pl is not plack safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17294 Marc Véron changed: What|Removed |Added Attachment #55518|0 |1 is obsolete|| --- Comment #3 from Marc Véron --- Created attachment 55626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55626&action=edit Bug 17294: Make reserves_stats.pl plack safe Lot of errors are raised by this script under plack because of var scope issues: Variable "$ccodes" is not available at /home/koha/src/reports/reserves_stats.pl line 337. Variable "$locations" is not available at /home/koha/src/reports/reserves_stats.pl line 338. Variable "$itemtypes" is not available at /home/koha/src/reports/reserves_stats.pl line 339. Variable "$Bsort1" is not available at /home/koha/src/reports/reserves_stats.pl line 344. Variable "$Bsort2" is not available at /home/koha/src/reports/reserves_stats.pl line 350. Variable "@patron_categories" is not available at /home/koha/src/reports/reserves_stats.pl line 356. The lazy way to fix that is that reinit them from the subroutines they are used. Test plan: Execute the report, after this patch applied you won't see the error in the log. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9188] Remove 'debug' information from patron statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9188] Remove 'debug' information from patron statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188
Marc Véron changed:
What|Removed |Added
Attachment #55526|0 |1
is obsolete||
--- Comment #3 from Marc Véron ---
Created attachment 55625
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55625&action=edit
Bug 9188 - Remove 'debug' information from patron statistics
In the staff client, if you submit a report under Reports ->
Statistics wizards -> Patrons you see a lot of debug info
with the heading "Filtered on:".
This patch fixes that by adding an extra template parameter
('filtered_on_debug') in reports/borrowers_stats.pl and setting
it to 0. The relevant template file is also updated to include
a conditional directive which checks for the 'filtered_on_debug'
variable. Debug info will only be shown if the variable is set
to something other than 0. Finally, the associated help file
template is updated to reflect the changes made.
Test plan:
1) In the staff client, submit a report under Reports ->
Statistics wizards -> Patrons. Observe that you see a
lot of debug information.
2) Apply the patch.
3) Repeat step 1. Confirm that the patch works, i.e. you
no longer see the debug information.
Followed test plan, works as expected.
Signed-off-by: Marc Véron
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9896] Show vendor in subscription search when creating an order for a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9896 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9896] Show vendor in subscription search when creating an order for a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9896 Marc Véron changed: What|Removed |Added Attachment #55622|0 |1 is obsolete|| --- Comment #5 from Marc Véron --- Created attachment 55624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55624&action=edit Bug 9896 - Show vendor in subscription search when creating an order for a subscription In the staff client, when creating an order from a subscription the vendor name should be shown in a separate column. This patch adds that feature. The 'Vendor' column is added before the 'Library' column since they appear in that order in Advanced search. Test plan: 0) [PREREQUISITES] In the Staff client, under Acquisitions, create a Vendor and associated Basket if you don't already have them. Then, under Serials, add a new Subscription using the Vendor you've just created. 1) Go to Acquisitions, and under 'Manage orders' search for a vendor, then click on 'Add to basket' and select 'From a subscription'. 2) Click 'Search' on the left hand side to search for all subscriptions. Notice how there is no 'Vendor' column in the results table. 3) Apply the patch. 4) Repeat step 2. Confirm that the patch works, i.e. there is now a 'Vendor' column which displays the vendor name. Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17307] Some edit buttons/ links for patrons do not work without a categorycode in the URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17307 Andreas Roussos changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17307] Some edit buttons/ links for patrons do not work without a categorycode in the URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17307 --- Comment #3 from Andreas Roussos --- Created attachment 55623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55623&action=edit Bug 17307 - Some edit buttons/links for patrons do not work without a categorycode in the URL In the Staff client, the 'Edit' button in the patron search page doesn't work. This is also true for one of the 'Edit' links in the patron Detail page, and the 'Edit' link in the Norwegian national patron database search page. This reason behind this is a missing categorycode parameter in the URL, and this patch fixes that. Test plan: 0) [PREREQUISITES FOR STEP 3] Enable the Norwegian national patron database search by setting the following sysprefs: NorwegianPatronDBEnable-> Enable NorwegianPatronDBEndpoint -> test NorwegianPatronDBSearchNLAfterLocalHit -> Don't NorwegianPatronDBUsername -> username NorwegianPatronDBPassword -> password 1) Go to Home > Patrons, search for a patron, click on the 'Edit' button (last column). You cannot edit the patron, and you get the following Software error in your browser: Can't call method "get_expiry_date" on an undefined value at [...] 2) Go to the patron's Detail page and click on the 'Edit' link under the 'Library use' heading on the right. You'll get the same error. 3) Manually navigate to /cgi-bin/koha/members/nl-search.pl, then search for the card number of one of your patrons. Click 'Edit' under the 'Existing patrons' heading. You'll get the same error. 4) Apply the patch. 5) Repeat steps 1), 2), and 3). This time the 'Edit' button/links work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9896] Show vendor in subscription search when creating an order for a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9896 Marc Véron changed: What|Removed |Added Attachment #55539|0 |1 is obsolete|| --- Comment #4 from Marc Véron --- Created attachment 55622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55622&action=edit Bug 9896 - Show vendor in subscription search when creating an order for a subscription In the staff client, when creating an order from a subscription the vendor name should be shown in a separate column. This patch adds that feature. The 'Vendor' column is added before the 'Library' column since they appear in that order in Advanced search. Test plan: 0) [PREREQUISITES] In the Staff client, under Acquisitions, create a Vendor and associated Basket if you don't already have them. Then, under Serials, add a new Subscription using the Vendor you've just created. 1) Go to Acquisitions, and under 'Manage orders' search for a vendor, then click on 'Add to basket' and select 'From a subscription'. 2) Click 'Search' on the left hand side to search for all subscriptions. Notice how there is no 'Vendor' column in the results table. 3) Apply the patch. 4) Repeat step 2. Confirm that the patch works, i.e. there is now a 'Vendor' column which displays the vendor name. Followed test plan, works as expected. Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15690] Unconstrained CardnumberLength preference conflicts with table column limit of 16
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15690] Unconstrained CardnumberLength preference conflicts with table column limit of 16
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690 Marc Véron changed: What|Removed |Added Attachment #55576|0 |1 is obsolete|| --- Comment #10 from Marc Véron --- Created attachment 55621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55621&action=edit Bug 15690: Hardcoded 16 is uncool Signed-off-by: Mark Tompsett Followed test plan in comment #7, works as expectd. Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15690] Unconstrained CardnumberLength preference conflicts with table column limit of 16
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690
Marc Véron changed:
What|Removed |Added
Attachment #55575|0 |1
is obsolete||
--- Comment #9 from Marc Véron ---
Created attachment 55620
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55620&action=edit
Bug 15690: CardnumberLength should not be bigger than 16
borrowers.cardnumber is a varchar(16), so CardnumberLength should not
have a max > 16
Test plan:
Test different value in CardnumberLength ("20", "20,30", "40,")
Edit a patron a make sure the text display under the cardnumber input is
correct
Signed-off-by: Mark Tompsett
Signed-off-by: Marc
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17209] Remove use of onclick from masthead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Marc Véron --- Sorry, I get a merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15329] Show budget in addition to fund for late orders in acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15329 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15330] Allow to search for late orders by budget and fund
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15330 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14535] Late orders doensn't show orders with price = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17306] Update scripts fail with Mysql 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17306 --- Comment #6 from Zeno Tajoli --- Attention. Koha (at general) doesn't work with MysqL 5.7. See Bug 17258 and connected bugs. Try to upgrade without using 5.7 or try to stop the strict mode. Instructions: http://stackoverflow.com/questions/18762308/how-to-get-rid-of-strict-sql-mode-in-mysql Can you try the update without strict mode ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17306] Update scripts fail with Mysql 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17306 --- Comment #7 from Rodrigo Santellan --- I will create another virtual machine to try that, for Monday I will have the test (low disk space) and post the results. Anyway I don't think it hurts to be a little more strict. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17307] Some edit buttons/ links for patrons do not work without a categorycode in the URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17307 --- Comment #2 from Andreas Roussos --- Edited the bug Summary to reflect that this needs fixing in more than one place. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17307] Some edit buttons/ links for patrons do not work without a categorycode in the URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17307 Andreas Roussos changed: What|Removed |Added Summary|Edit button in patron |Some edit buttons/links for |search page doesn't work|patrons do not work without |without a category code |a categorycode in the URL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Christopher Davis changed: What|Removed |Added CC||cgda...@uintah.utah.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15503] Grab Item Information from Order Files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Christopher Davis changed: What|Removed |Added CC||cgda...@uintah.utah.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15566] Update API to allow to reserve first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15566 claire.hernan...@biblibre.com changed: What|Removed |Added CC||claire.hernandez@biblibre.c ||om Status|BLOCKED |Signed Off --- Comment #7 from claire.hernan...@biblibre.com --- If PNA is like DNA, I think I can unblocked it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17306] Update scripts fail with Mysql 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17306
--- Comment #4 from Rodrigo Santellan ---
Created attachment 55619
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55619&action=edit
Changes of updatadatabase
@@ -76,7 +76,6 @@ local $dbh->{RaiseError} = 0;
# Record the version we are coming from
my $original_version = C4::Context->preference("Version");
-
# Deal with virtualshelves
my $DBversion = "3.00.00.001";
if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
@@ -557,9 +556,11 @@ if (C4::Context->preference("Version") <
TransformToNum($DBversion)) {
$DBversion = "3.00.00.019";
if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
+$dbh->do("SET FOREIGN_KEY_CHECKS=0");
$dbh->do("ALTER TABLE biblio MODIFY biblionumber INT(11) NOT NULL
AUTO_INCREMENT");
$dbh->do("ALTER TABLE biblioitems MODIFY biblioitemnumber INT(11) NOT NULL
AUTO_INCREMENT");
$dbh->do("ALTER TABLE items MODIFY itemnumber INT(11) NOT NULL
AUTO_INCREMENT");
+$dbh->do("SET FOREIGN_KEY_CHECKS=1");
print "Upgrade to $DBversion done (made bib/item PKs auto_increment)\n";
SetVersion ($DBversion);
}
@@ -1036,8 +1037,7 @@ if (C4::Context->preference("Version") <
TransformToNum($DBversion)) {
`creep_vert` float default NULL,
`unit` char(20) NOT NULL default 'POINT',
PRIMARY KEY (`prof_id`),
-UNIQUE KEY `printername` (`printername`,`tmpl_id`,`paper_bin`),
-CONSTRAINT `printers_profile_pnfk_1` FOREIGN KEY (`tmpl_id`)
REFERENCES `labels_templates` (`tmpl_id`) ON DELETE CASCADE ON UPDATE CASCADE
+UNIQUE KEY `printername` (`printername`,`tmpl_id`,`paper_bin`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 ");
$dbh->do("CREATE TABLE `labels_profile` (
`tmpl_id` int(4) NOT NULL,
@@ -1149,7 +1149,7 @@ if (C4::Context->preference("Version") <
TransformToNum($DBversion)) {
}
$DBversion = "3.00.00.061";
-if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
+if (C4::Context->preference("Version") < TransformToNum($DBversion) || 1 == 2)
{
$dbh->do("ALTER TABLE labels_templates ADD COLUMN font char(10) NOT NULL
DEFAULT 'TR';");
print "Upgrade to $DBversion done ( Added font column to
labels_templates )\n";
SetVersion ($DBversion);
@@ -1205,7 +1205,7 @@ if (C4::Context->preference("Version") <
TransformToNum($DBversion)) {
) ENGINE=InnoDB DEFAULT CHARSET=utf8");
# move closed transactions to old_* tables
-$dbh->do("INSERT INTO old_issues SELECT * FROM issues WHERE returndate IS
NOT NULL");
+$dbh->do("INSERT INTO old_issues SELECT i.borrowernumber, i.itemnumber,
i.date_due, i.branchcode, i.issuingbranch, i.returndate, i.lastreneweddate,
i.return, i.renewals, i.timestamp, i.issuedate FROM issues i WHERE i.returndate
IS NO
$dbh->do("DELETE FROM issues WHERE returndate IS NOT NULL");
$dbh->do("INSERT INTO old_reserves SELECT * FROM reserves WHERE
cancellationdate IS NOT NULL OR found = 'F'");
$dbh->do("DELETE FROM reserves WHERE cancellationdate IS NOT NULL OR found
= 'F'");
@@ -1255,9 +1255,8 @@ if (C4::Context->preference("Version") <
TransformToNum($DBversion)) {
$DBversion = "3.00.00.066";
if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
-$dbh->do("ALTER TABLE `virtualshelfcontents` MODIFY `dateadded` timestamp
NOT NULL
-DEFAULT CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP;
-");
+$dbh->do("UPDATE `virtualshelfcontents` SET `dateadded` =
CURRENT_TIMESTAMP WHERE `dateadded` IS NULL;");
+$dbh->do("ALTER TABLE `virtualshelfcontents` MODIFY `dateadded` timestamp
NOT NULL DEFAULT CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP;");
print "Upgrade to $DBversion done (fix for bug 1873: virtualshelfcontents
dateadded column empty. ) \n";
SetVersion ($DBversion);
}
@@ -1273,7 +1272,7 @@ $DBversion = "3.00.00.068";
if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
$dbh->do("CREATE TABLE `permissions` (
`module_bit` int(11) NOT NULL DEFAULT 0,
-`code` varchar(30) DEFAULT NULL,
+`code` varchar(30) NOT NULL DEFAULT '',
`description` varchar(255) DEFAULT NULL,
PRIMARY KEY (`module_bit`, `code`),
CONSTRAINT `permissions_ibfk_1` FOREIGN KEY (`module_bit`)
REFERENCES `userflags` (`bit`)
@@ -1282,7 +1281,7 @@ if (C4::Context->preference("Version") <
TransformToNum($DBversion)) {
$dbh->do("CREATE TABLE `user_permissions` (
`borrowernumber` int(11) NOT NULL DEFAULT 0,
`module_bit` int(11) NOT NULL DEFAULT 0,
-`code` varchar(30) DEFAULT NULL,
+`code` varchar(30) NOT NULL DEFAULT '',
CONSTRAINT `user_permissions_ibfk_1` FOREIGN KEY
(`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`)
ON DELETE CASCADE ON UPD
[Koha-bugs] [Bug 17306] Update scripts fail with Mysql 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17306 --- Comment #5 from Rodrigo Santellan --- I attached the to files. I'm using ubuntu 14.04.02 LTS with MySQL 5.7 that support full text indexes. But my next step is to use Ubuntu 16.04 LTS that comes with MySQL 5.7. I'm still running and old Koha 2 but was highly modified. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17306] Update scripts fail with Mysql 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17306
--- Comment #3 from Rodrigo Santellan ---
Created attachment 55618
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55618&action=edit
Changes of update22to30
diff --git a/installer/data/mysql/update22to30.pl
b/installer/data/mysql/update22to30.pl
index f10ace9..f2010e1 100755
--- a/installer/data/mysql/update22to30.pl
+++ b/installer/data/mysql/update22to30.pl
@@ -53,10 +53,10 @@ my $DBversion = "3.00.00.000";
action_logs => "(
`timestamp` TIMESTAMP NOT NULL ,
`user` INT( 11 ) NOT NULL default '0' ,
-`module` TEXT default '',
-`action` TEXT default '' ,
+`module` TEXT default NULL,
+`action` TEXT default NULL ,
`object` INT(11) NULL ,
-`info` TEXT default '' ,
+`info` TEXT default NULL ,
PRIMARY KEY ( `timestamp` , `user` )
)",
letter=> "(
@@ -132,7 +132,7 @@ my $DBversion = "3.00.00.000";
labelid int(11) NOT NULL auto_increment,
batch_id varchar(10) NOT NULL default '1',
itemnumber varchar(100) NOT NULL default '',
-timestamp timestamp(14) NOT NULL,
+timestamp timestamp NOT NULL,
PRIMARY KEY (labelid)
)",
@@ -214,7 +214,7 @@ my $DBversion = "3.00.00.000";
);
my %requirefields = (
-subscription => { 'letter' => 'varchar(20) NULL', 'distributedto' =>
'text NULL', 'firstacquidate'=>'date default NULL','irregularity'=>'TEXT NULL
default \'\'','numberpattern'=>'TINYINT(3) NULL default 0', 'callnumber'=>'text
NU
+subscription => { 'letter' => 'varchar(20) NULL', 'distributedto' =>
'text NULL', 'firstacquidate'=>'date default NULL','irregularity'=>'TEXT NULL
default NULL','numberpattern'=>'TINYINT(3) NULL default 0', 'callnumber'=>'text
NU
itemtypes => { 'imageurl' => 'varchar(200) NULL'},
aqbookfund => { 'branchcode' => 'varchar(4) NULL'},
aqbudget => { 'branchcode' => 'varchar(4) NULL'},
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15503] Grab Item Information from Order Files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Kyle M Hall changed: What|Removed |Added Attachment #55616|0 |1 is obsolete|| --- Comment #20 from Kyle M Hall --- Created attachment 55617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55617&action=edit Bug 15503 [QA Followup] - Remove the use of GetBranchesLoop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15503] Grab Item Information from Order Files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15503] Grab Item Information from Order Files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #19 from Kyle M Hall --- Created attachment 55616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55616&action=edit Bug 15503 [QA Followup] - Remove the use of GetBranchesLoop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17306] Update scripts fail with Mysql 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17306 --- Comment #2 from Zeno Tajoli --- An other request: are you trying to use last LTS of Ubuntu? You speak about Mysql 5.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17306] Update scripts fail with Mysql 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17306 Zeno Tajoli changed: What|Removed |Added CC||z.taj...@cineca.it --- Comment #1 from Zeno Tajoli --- Hi Rogrigo, could write down the changes you have done on updatedatabase.pl ? Also a .txt file is ok. No problem with update22to30.pl ? Do you still have an installation of Koha 2.x ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17307] Edit button in patron search page doesn' t work without a category code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17307
Andreas Roussos changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|koha-b...@lists.koha-commun |arouss1...@gmail.com
|ity.org |
URL||/cgi-bin/koha/members/membe
||r.pl
--- Comment #1 from Andreas Roussos ---
I'm no Perl expert but here's what I've found so far in my attempt
to debug this.
members/memberentry.pl in the current master (0254fd7):
372 if ( ($op eq 'modify' || $op eq 'insert' || $op eq 'save'|| $op eq
'duplicate') and ($step == 0 or $step == 3 )){
373 unless ($newdata{'dateexpiry'}){
374 my $patron_category = Koha::Patron::Categories->find(
$newdata{categorycode} );
375 $newdata{'dateexpiry'} = $patron_category->get_expiry_date(
$newdata{dateenrolled} );
376 }
377 }
The problem in line 375 is that the value of the $patron_category
variable is undefined, because at line 374 $newdata{categorycode}
comes from $input->param(), as per the comment at line 168. Since
no 'categorycode' value is passed in the URL, the call to
Koha::Patron::Categories->find() fails.
So, it seems that the easy fix is to add the categorycode in the URL.
It's trivial to fix so I'll provide a patch soon.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16899] Add ability to disallow overpayments via SIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16757] Add ability to pay fee by id for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 --- Comment #8 from Kyle M Hall --- Created attachment 55613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55613&action=edit [SIGNED-OFF] Bug 16757 - Add support for Fee Paid to SIP cli emulator for testing Signed-off-by: Rhonda Kuiper -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17307] New: Edit button in patron search page doesn' t work without a category code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17307 Bug ID: 17307 Summary: Edit button in patron search page doesn't work without a category code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: arouss1...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Description of the problem: The 'Edit' button in the patron search page doesn't work without a category code in the URL. [I've searched extensively and couldn't find this bug listed, so I'm submitting it as new. Please note that it's different from: Bug 4508 - can't edit patron attributes using little edit link, and Bug 4427 - Can't edit patron additional attributes and identifiers.] Steps to reproduce (in the current master 0254fd7): Go to Home > Patrons, search for a patron, click on the 'Edit' button (last column). You cannot edit the patron, and you get the following Software error in the browser: Can't call method "get_expiry_date" on an undefined value at /home/aroussos/kohaclone/members/memberentry.pl line 375. Notice how the URL is of the form: cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=52 If you follow a different route and click on the 'Edit' button above the patron name in the patron Details page it works fine because the URL is like this (notice the added '&categorycode=J' at the end): cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=52&categorycode=J -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16899] Add ability to disallow overpayments via SIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall changed: What|Removed |Added Attachment #54203|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 55615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55615&action=edit [SIGNED-OFF] Bug 16899 - Add ability to disallow overpayments Some SIP services ( such as Comprise ) require that an attempt at over-paying a patron's account via SIP2 should fail, rather than create a credit on the account. We should make this a configurable option on a per-login basis in the SIP2 config file. Test Plan: 1) Apply this patch 2) Enable the new parameter disallow_overpayment="1" for the login to be used in this test. 3) Restart your SIP server 4) Create or find a patron with fines 5) Attempt to send a payment via SIP for more than what the patron's balance is 6) Note the response indicates a payment failure 7) Attempt to send a payment via SIP for the account balance or less 8) Note the response indicates the payment has succeeded 9) Verify in Koha that the payment was processed Signed-off-by: Rhonda Kuiper -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16895] Allow writeoffs via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16895] Allow writeoffs via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 Kyle M Hall changed: What|Removed |Added Attachment #53268|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 55614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55614&action=edit [SIGNED-OFF] Bug 16895 - Allow writeoffs via SIP2 Many SIP2 services such as those by Comprise Technologies are able to or require that an ILS be able to accept writeoffs via SIP2. The SIP2 protocol specifies that payment type be a two digit number, but does not specify a code for writeoffs. To this end we should allow the write-off code to be specified in the SIP2 config on a per-account basis so that if different vendors use different fixed codes for write-offs we can handle that gracefully. Test Plan: 1) Apply this patch 2) Modify your SIP2 config to include payment_type_writeoff="06" in the login portion of the account you will be using for the test. 3) Restart your SIP2 server 4) Create a fee for a patron 5) Send a SIP2 fee paid message specifying the payment type code we defined earlier, with a payment amount that is *not* equal to the amount outstanding for the fee. 6) Note the fee paid response indicates the payment failed 7) Repeat step 5, but this time send the amount outstanding as the payment amount 8) Note that the fee paid response indicates a successful payment 9) Note in Koha that the fee has been written off! Signed-off-by: Rhonda Kuiper -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16757] Add ability to pay fee by id for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16757] Add ability to pay fee by id for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Kyle M Hall changed: What|Removed |Added Attachment #53262|0 |1 is obsolete|| Attachment #53263|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 55612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55612&action=edit [SIGNED-OFF] Bug 16757 - Add ability to pay fee by id for SIP2 The SIP protocol allows for a Fee Paid message to specify a fee identifier in the CG field. While this field is read and passed to C4::SIP::ILS::pay_fee, it is not passed along to C4::SIP::ILS::Transaction::FeePayment::pay and is thus not used. We should enable this functionality in Koha now that accountlines each have a unique identifier that can be passed along to the payment requestor via the AV field line items added by bug 14512. Test Plan: 1) Create a fee in Koha 2) Ensure your SIP2 server is running and configured correctly 3) Send a 37 Fee Paid message to Koha's SIP server with the accountlines_id for that fee in the CG fee identifier field, along with the other required fields. 4) Note that specific fee was paid in Koha Signed-off-by: Rhonda Kuiper -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17306] New: Update scripts fail with Mysql 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17306 Bug ID: 17306 Summary: Update scripts fail with Mysql 5.7 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcha...@gmail.com Reporter: rsantel...@gmail.com QA Contact: testo...@bugs.koha-community.org Doing a complete migration from koha 2 to koha 3 with the update22to30.pl and updatedatabase.pl found a few problems with the consistencies of the SQL with the new MySQL 5.7. I have changed the script to be able to run, the only one that is not working properly is 3.09.00.051 that have a bad group by condition but I never have use that module and don't know how to fix it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088 Marcel de Rooy changed: What|Removed |Added Version|unspecified |master Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #6 from Marcel de Rooy --- Kyle: Added follow-up for logging. If you prefer to let them go on their own, feel free to move them. They are quite simple however. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088 --- Comment #4 from Marcel de Rooy --- Created attachment 55610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55610&action=edit Bug 17088: [Follow-up] Adjust POD in Logger.pm Not important enough to go on its own. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088 Marcel de Rooy changed: What|Removed |Added Attachment #54202|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy --- Created attachment 55609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55609&action=edit Bug 17088 - Bad MARC XML can halt export_records.pl If export_records.pl encounters a record that fails to load correctly as a MARC::Record the export process will fail and only the records encountered up to that point will be exported. Test Plan: 1) Pick a record in your database, and replace the biblioitems.marcxml field with some random characters 2) Export your records using the command: misc/export_records.pl --format xml --record-type bibs --filename /tmp/biblios.xml 3) Note you get an error and the script ends prematurely 4) Apply this patch 5) Repeat step 2 6) Note the full record set is exported ( except for your bad record ) 7) Note an error is still generated for your bad record ( useful for tracking down bad records ). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088
--- Comment #5 from Marcel de Rooy ---
Created attachment 55611
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55611&action=edit
Bug 17088: [Follow-up] Use Logger for failed exports
Fixes a TODO for logging unsupported record_type in _get_record_for_export.
Also logs a warning when the record_type parameter is not supplied at all in
sub export.
Replaces a warn by a log message about an invalid record for format iso2709.
Also adds a log message about an invalid record for format xml.
Adds a trivial unit test for passing no record_type to export.
Test plan:
See also first patch.
Run t/db_dependent/Exporter/Record.t.
Signed-off-by: Marcel de Rooy
Also tested the log messages for iso2709 and xml by manipulating
the record_type parameter with:
$params->{record_type}='xx';
before calling _get_record_for_export in Record.pm.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #50 from Kyle M Hall --- Pushed to master for 16.11, thanks Jacek, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16335] Refactor OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16335 --- Comment #4 from M. Tompsett --- Created attachment 55608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55608&action=edit Bug 16335: get_instance was changed to new? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 --- Comment #12 from Julian Maurice --- This bug seems to be a duplicate of bug 16788. When I try to apply it on top of 16788, the only change I get is for the Maintainer field. And this particular change is also introduced by bug 17121. Can you have a look please ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16788] Update Control file for 3.22.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16788 Julian Maurice changed: What|Removed |Added Status|Passed QA |Pushed to Stable --- Comment #5 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17266] Update man page for koha-remove with -p
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17266 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12629] Software error when trying to merge records from different frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12629 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #11 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16556] KohaToMarcMapped columns sharing same field with biblio(item) number are removed.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16556 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #12 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17010] Canceling a hold awaiting pickup no longer alerts librarian about next hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #9 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #76 from Julian Maurice --- All patches but the 3 last ones are pushed to 3.22.x, they will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #75 from Julian Maurice --- @RM @Joubu: I think the last 3 patches have been forgotten because they are wrapped inside a .tar.gz file. Can you have a look ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- Testing this now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17281] Warning when saving subfield structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17281 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16311] Advanced search language limit typo for Romanian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16311 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #7 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6852] Staged import reports wrong success for items with false branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6852 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #11 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Josef Moravec changed: What|Removed |Added Attachment #55588|0 |1 is obsolete|| --- Comment #15 from Josef Moravec --- Created attachment 55607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55607&action=edit Bug 17282 - Ability to exclude the last line in report results This patch add a checkbox (exclude last line). This is useful when this last is the result of a sql rollup which is the sum of each column and make the chart not consistent Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Josef Moravec changed: What|Removed |Added Attachment #55442|0 |1 is obsolete|| --- Comment #12 from Josef Moravec --- Created attachment 55604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55604&action=edit Bug 17282: Ability to create charts for SQL reports Add a form under report's result that allow to configure and draw a chart (pie, bar, line and combination). Pie: Usefull only for a two-column report's result bar: Horizontal: Can be horizontal or vertical (check/uncheck horizontal checkbox), Group: allows to group columns (stacked bar chart), Line: show some columns as line in a bar chart (combination) line: line chart :) This patch adds 2 new js libraries: d3js and c3js: - c3.min.css - c3.min.js - d3.min.js Test plan: - Apply this patch, - make reports, - draw charts, - that's all Signed-off-by: Hector Castro Works as advertised Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Josef Moravec changed: What|Removed |Added Attachment #55586|0 |1 is obsolete|| --- Comment #14 from Josef Moravec --- Created attachment 55606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55606&action=edit Bug 17282 - Fix QA comments: - Don't scroll to the top when deleting a column, - prevents to delete all columns, - better handling of headers/results deleting Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Josef Moravec changed: What|Removed |Added Attachment #55480|0 |1 is obsolete|| --- Comment #13 from Josef Moravec --- Created attachment 55605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55605&action=edit Bug 17282: (follow-up) Use drop-down menu for download chart instead To Test 1) Execute a report 2) Click in drop-down menu "Download" shows only three options 3) Draw a chart 4) Click again in drop-down menu "Download" shows a new option "Download chart" Signed-off-by: Alex Arnaud Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17305] [SPAM]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17305 Zeno Tajoli changed: What|Removed |Added CC||z.taj...@cineca.it Summary|quickbooks phone support|[SPAM] |@1877 778 8714 quickbooks | |help| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16950] Serials subscriptions advanced search shows '0 found' pre-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16950 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17220] Improve clarity when placing a hold by changing button text from " Place hold" to "Confirm hold"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17220 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #11 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16822] koha-common init.d script should run koha-plack without quiet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16822 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17267] Document koha-create --adminuser
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17267 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17152] Duplicating a subfield should not copy the data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #10 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17304] C4::Matcher::_get_match_keys is not tested
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17304 Marcel de Rooy changed: What|Removed |Added Attachment #55574|0 |1 is obsolete|| --- Comment #2 from Marcel de Rooy --- Created attachment 55603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55603&action=edit Bug 17304: Introduce C4::Matcher::_get_match_keys unit tests This function is used in several places, but it's behaviour is not covered by tests, thus trying to patch it can be problematic without introducing regressions. This patch introduces unit tests for it, in the t/Matcher.t file. To test: - Apply the patch - Run: $ prove t/Matcher.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17304] C4::Matcher::_get_match_keys is not tested
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17304 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17072] 006 not filling in with existing values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17072 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #8 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17175] Typo in patron card images error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17175 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17305] New: quickbooks phone support @1877 778 8714 quickbooks help
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17305 Bug ID: 17305 Summary: quickbooks phone support @1877 778 8714 quickbooks help Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: neng...@gmail.com Reporter: ashlieg...@g212dnk5.com QA Contact: testo...@bugs.koha-community.org Created attachment 55602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55602&action=edit Quickbooks customer support contact number, Quickbooks customer service contact number, 1 877 778 8714Quickbooks official number, Quickbooks official contact number, Quickbooks 877 contact number, Qui Quickbooks customer support contact number, Quickbooks customer service contact number, 1 877 778 8714Quickbooks official number, Quickbooks official contact number, Quickbooks 877 contact number, Qui Intuit Quickbooks +++»--A- 1 877 778 8714 Quickbooks Support Phone Number 1877-778-8714 Quickbooks technical phone number, 1 877 778 8714 Quickbooks technical number, 1 877 778 8714 Quickbooks technical support contact number,1 877 778 8714 Quickbooks contact number, 1 877 778 8714Quickbooks contact phone number, 1 877 778 8714Quickbooks contact telephone number, Quickbooks 24 hour contact number, Quickbooks customer support contact number, Quickbooks customer service contact number, 1 877 778 8714Quickbooks official number, Quickbooks official contact number, Quickbooks 877 contact number, Quickbooks toll free number, 877 number for Quickbooks support, Quickbooks 24/7 support phone number Quickbooks support phone number,Quickbooks support phone number,Quickbooks help phone number, Quickbooks technical support number.Quickbooks support number, Quickbooks phone number, Quickbooks HELP DESK number, Quickbooks customer support number, Quickbooks customer support phone number, Quickbooks customer service phone number, Quickbooks customer service phone number, Quickbooks support phone number. Help@Call 1-877-778-8714/.Quickbooks 24/7 support phone number,Quickbooks telephone number for support? call 1877-778-8714@./Quickbooks contact number, Quickbooks contact phone number, Quickbooks contact telephone numbertelephone number for Quickbooks online support,Quickbooks official support number,Quickbooks official number,Quickbooks official phone number,phone number for Quickbooks supportQuickbooks 24/7 support phone numberQuickbooks support number,Quickbooks telephone number for support QB SUPPORT ON ((1-877-778-8714)) Quickbooks PHONE NUMBER AND Quickbooks SUPPORT PHONE NUMBER Online Support For Quickbooks support help intuit customer service number tech support for Quickbooks technical support for Quickbooks technical support for intuit Quickbooks help website Quickbooks support website Quickbooks .com/helpme Quickbooks customer support website intuit Quickbooks head office intuit Quickbooks call center intuit support number (any thing with intuit ) buy Quickbooks enhance buy intuit enhance customer support for Quickbooks customer support for intuit customer support for intuit Quickbooks www.Quickbooks .com/support (((1+877+778+8714)!!! Quickbooks ((Technical)) Support phone number Quickbooks HELP DESK phone number Online Support For (((1+877+778+8714)!!! Quickbooks ((Technical)) Support phone number Quickbooks HELP DESK phone number Helpline TECH ))1-877-778-8714((Quickbooks technical support phone number Quickbooks phone number QB SUPPORT ON ((1-877-778-8714)) Quickbooks PHONE NUMBER AND Quickbooks SUPPORT PHONE NUMBER Quickbooks Toll Free, Intuit@(1-877-778-8714)@ Quickbooks HELP DESK Phone Number vides online solution for all USA/CANADA clients. For any help of query call 1 877 778 8714 to get all Quickbooks account solution. @@Call, 1-877-778-8714 for all type help by Quickbooks HELP DESK phone number, Intuit Quickbooks HELP DESK Phone Number, Quickbooks Help Desk Phone Number, Quickbooks HELP DESK number, Quickbooks technical support phone number,@@@ Quickbooks phone number, Quickbooks technical support number, Quickbooks support phone number, Quickbooks technical support, Quickbooks Customer Service Phone Number, Quickbooks Customer Service Number, Quickbooks Customer Support Phone Number, Quickbooks Customer Support Number, Quickbooks Customer Service Helpline Number, Quickbooks Customer Care Number, Quickbooks support team phone number, @ Quickbooks help number-Quickbooks Helpline Number; Quickbooks help phone number-Quickbooks Helpline Number, Quickbooks HELP DESK Toll free Number, Quickbooks Support Telephone Number, Quickbooks HELP DESK Telephone number, Quickbooks HELP DESK contact number, Quickbooks support contact number, Quickbooks technical support contact number. Call, Quickbooks HELP DESK phone number, Intuit Quickbook
[Koha-bugs] [Bug 17185] Staff client shows "Lists that include this title:" even if item is not in a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17185 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16809] Silence CGI param warnings from C4::Biblio:: TransformHtmlToMarc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #9 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14612] Overdue notice triggers should show branchname instead of branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14612 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17302] Add Koha::Util::Normalize for normalization functions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17302 Marcel de Rooy changed: What|Removed |Added Assignee|gmcha...@gmail.com |tomasco...@gmail.com Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17302] Add Koha::Util::Normalize for normalization functions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17302 --- Comment #7 from Marcel de Rooy --- Created attachment 55601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55601&action=edit Bug 17302: [Follow-up] Make Normalize.pm undef-resistent Trivial changes for passing undef to the norm routines. Added a few dumb tests too. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17302] Add Koha::Util::Normalize for normalization functions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17302 Marcel de Rooy changed: What|Removed |Added Attachment #55591|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 55600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55600&action=edit Bug 17302: Add Koha::Util::Normalize for normalization functions This patch introduces Koha::Util::Normalize, which includes the following normalization routines that need no explanation: - remove_spaces - upper_case - lower_case and it also includes: - legacy_default: which basically does what C4::Matcher::_normalize does. All routines functionality are fully tested with the included in the included tests. To test: - Apply the patch - Run: $ prove t/Koha/Util/Normalize.t => SUCCESS: All tests pass - Sign off :-D Edit: Added Exporter to explicitly export the routines. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17302] Add Koha::Util::Normalize for normalization functions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17302 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16464] If a patron has been discharged, show a message in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #12 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17228] Make two versions of SIPconfig.xml identical
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #10 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
