[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #234 from Kyle M Hall--- Fix has been posted as bug 17327 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17327] Item level holds no longer enforced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 --- Comment #1 from Kyle M Hall--- Created attachment 55744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55744=edit Bug 17327 - Add unit test for regression -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17327] Item level holds no longer enforced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Kyle M Hallchanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17327] Item level holds no longer enforced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Kyle M Hallchanged: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17327] Item level holds no longer enforced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 --- Comment #2 from Kyle M Hall--- Created attachment 55745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55745=edit Bug 17327 - Item level holds no longer enforced Reported by Katrin: Example: - on shelf holds allowed - holds allowed 5 - holds on same record allowed 5 - FORCE item level holds On a record with only one item, you can only place a record level hold in OPAC now - which is against your circulation conditions. Another example: - record with 2 items - circulation rules as above, 1 hold allowed on the record - Item level holds: forced I can only place record level holds in OPAC and staff. At the moment, I am not able to place item level holds in any circumstances in my installation. Test Plan: 1) Apply the unit test patch 2) prove t/db_dependent/Reserves/MultiplePerRecord.t should fail 3) Apply the second patch 4) prove t/db_dependent/Reserves/MultiplePerRecord.t should pass 5) Attempt to replicate one of the examples above, you should be unable to -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17327] Item level holds no longer enforced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Kyle M Hallchanged: What|Removed |Added Depends on||14695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hallchanged: What|Removed |Added Blocks||17327 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 [Bug 17327] Item level holds no longer enforced -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17327] Item level holds no longer enforced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Kyle M Hallchanged: What|Removed |Added Severity|enhancement |major Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17327] New: Item level holds no longer enforced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Bug ID: 17327 Summary: Item level holds no longer enforced Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Reported by Katrin: Example: - on shelf holds allowed - holds allowed 5 - holds on same record allowed 5 - FORCE item level holds On a record with only one item, you can only place a record level hold in OPAC now - which is against your circulation conditions. Another example: - record with 2 items - circulation rules as above, 1 hold allowed on the record - Item level holds: forced I can only place record level holds in OPAC and staff. At the moment, I am not able to place item level holds in any circumstances in my installation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17310] Broken URLs in 'Item renewed' / 'Cannot renew' messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Héctor Eduardo Castro Avaloschanged: What|Removed |Added Attachment #55630|0 |1 is obsolete|| --- Comment #2 from Héctor Eduardo Castro Avalos --- Created attachment 55743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55743=edit [SIGNED-OFF]Bug 17310: Broken URLs in 'Item renewed' / 'Cannot renew' messages In the Staff client, under Circulation > Renew, the message shown after successful renewal of an item contains broken URLs. This is also true for the message shown when you try to renew an item that is not checked out. This patch fixes that. Test plan: 1) Go to Circulation > Renew, and search for the barcode of a checked-out item. In the 'Item renewed:' confirmation message, notice how the URLs for the title and the barcode are broken. 2) Now search for the barcode of an item that is not checked out. In the 'Cannot renew:' message, notice how the URLs are broken here too. 3) Apply the patch. 4) Repeat steps 1) and 2). This time the URLs work fine. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17310] Broken URLs in 'Item renewed' / 'Cannot renew' messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Héctor Eduardo Castro Avaloschanged: What|Removed |Added CC||hector.hecax...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10708] make fine receipt customizable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708 Lisettechanged: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #233 from Kyle M Hall--- (In reply to Katrin Fischer from comment #229) > Another example: > - record with 2 items > - circulation rules as above, 1 hold allowed on the record > - Item level holds: forced > > I can only place record level holds in OPAC and staff. At the moment, I am > not able to place item level holds in any circumstances in my installation. > > Please, can someone investigate this? I will definitely look into this! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #232 from Chris Cormack--- I confirm this regression Katrin has spotted. I realise this a problematic bug, that was pushed before its time, but we really need to fix this issue, or figure out how to revert it back out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 J Schmidtchanged: What|Removed |Added CC||jschm...@switchinc.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Frédéric Demianschanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Frédéric Demianschanged: What|Removed |Added Attachment #55266|0 |1 is obsolete|| --- Comment #7 from Frédéric Demians --- Created attachment 55742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55742=edit Bug 17262: Inject MEMCACHED_* variables into Plack's env This patch adds two functions to koha-functions.sh to read the MEMCACHED_* variables from configured instances' apache files (the only source for that info for now). It then tweaks koha-plack's start_plack() function so it exports the variables to env before launching starman. The patch seems trivial, but it highlights a bigger problem with our Plack integration as the starman server seems to hang if those environment variables are defined! Sponsored-by: ByWater Solutions Signed-off-by: Frédéric Demians -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17318] Make 'Normalization rule' configurable on matchpoint definition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17318 --- Comment #5 from Tomás Cohen Arazi--- Created attachment 55741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55741=edit Bug 17318: Allow chosing fixed normalization routines This patch changes the matching-rules.pl page, so it allows the user to choose from the different hardcoded normalization routines. It is done using TT blocks and the routine descriptions are translatable. To test: - Create some matching rule - Have free text values on the 'Normalization rule' field - Apply the patches - Create a new routine => SUCCESS: You can now only choose between fixed option - Save the rule - Open it for editing => SUCCESS: Chosen rules are preserved - Edit the original free-text including rule => SUCCESS: Rules fall back to 'None' - Sign off :-D TODO: A followup will add a warning about the current value and the fact that saving the matching rule will overwrite those, with 'none'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17318] Make 'Normalization rule' configurable on matchpoint definition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17318 Tomás Cohen Arazichanged: What|Removed |Added Attachment #55721|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 55740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55740=edit Bug 17318: Make C4::Matcher::_get_match_keys handle 'norms' param The current implementation doesn't care about that parameter, and applies a default normalization rule that seems counter-productive (in general) for its aleged purpose. This patch makes it handle the following values for 'norms': - upper_case - lower_case - remove_spaces - legacy_default - none They make it call the relevant Koha::Utils::Normalize routines. 'legacy_default' is used only for backwards compatibility, but could be removed if there's consensus. To test: - Run: $ prove t/Matcher.t => FAIL: most _get_match_keys tests fail - Apply the patch - Run: $ prove t/Matcher.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17318] Make 'Normalization rule' configurable on matchpoint definition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17318 Tomás Cohen Arazichanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17274] Add info about which memcached config is used to about.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 --- Comment #7 from Tomás Cohen Arazi--- (In reply to Frédéric Demians from comment #5) > Where is memcached server extracted from koha-conf.xml? I don't see it in > Koha::Cache.pm. In current master, it reads it from koha-conf.xml BUT it prefers ENV if available. That's why I mentioned it is safe for stable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17274] Add info about which memcached config is used to about.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 --- Comment #6 from Tomás Cohen Arazi--- (In reply to Frédéric Demians from comment #5) > Where is memcached server extracted from koha-conf.xml? I don't see it in > Koha::Cache.pm. koha::Cache.pm (86~93): $self->{'namespace'} ||= $ENV{MEMCACHED_NAMESPACE}; my @servers = split /,/, $ENV{MEMCACHED_SERVERS} || ''; unless ( $self->{namespace} and @servers ) { my $koha_config = Koha::Config->read_from_file( Koha::Config->guess_koha_conf() ); $self->{namespace} ||= $koha_config->{config}{memcached_namespace} || 'koha'; @servers = split /,/, $koha_config->{config}{memcached_servers} // '' unless @servers; } -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17274] Add info about which memcached config is used to about.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 Frédéric Demianschanged: What|Removed |Added CC||frede...@tamil.fr --- Comment #5 from Frédéric Demians --- Where is memcached server extracted from koha-conf.xml? I don't see it in Koha::Cache.pm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method for ILSDI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Arthur Suzukichanged: What|Removed |Added Change sponsored?|Seeking developer |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5670] Housebound Readers Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #53 from Alex Sassmannshausen--- Hi Jonathan, Thank you very much for the quick review! I believe I have now addressed all the issues you raised, with one commit per issue. I hope this looks good to you. Best wishes, Alex -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5670] Housebound Readers Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #49 from Alex Sassmannshausen--- Created attachment 55736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55736=edit Bug 5670: [QA Followup] Avoid CGI::param in list context. * members/housebound.pl: Force `borrowernumber` to scalar context. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5670] Housebound Readers Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #52 from Alex Sassmannshausen--- Created attachment 55739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55739=edit Bug 5670: [QA Followup] Fix `div.patroninfo`. * members/housebound.pl: Provide full patron hash keys, extended patron attributes & picture to template. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Refactor to use new information. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5670] Housebound Readers Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #50 from Alex Sassmannshausen--- Created attachment 55737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55737=edit Bug 5670: [QA Followup] Housebound link from patron edit. * koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc: Add a link to the housebound module view if it is switched on. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5670] Housebound Readers Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #51 from Alex Sassmannshausen--- Created attachment 55738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55738=edit Bug 5670: [QA Followup] Small QA fixes. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Remove `console.log` invocations. * members/housebound.pl ($houseboundvisits, $chooser, $deliverer): Remove unused variables. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5670] Housebound Readers Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #48 from Alex Sassmannshausen--- Created attachment 55735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55735=edit Bug 5670: [QA Followup] Fix category_type ref. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Replace references to `category_type` with `categorycode`. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5670] Housebound Readers Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #47 from Alex Sassmannshausen--- Created attachment 55734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55734=edit Bug 5670: [QA Followup] Don't force ISO dates. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Use ".datepicker" class for date input, use `$KohaDates` to filter our iso dates. * members/housebound.pl: Use DateTime and Koha::DateUtils to parse incoming date to ISO format. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5670] Housebound Readers Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Alex Sassmannshausenchanged: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17326] KOha not asking if the book is to be renewed when max book limit is reached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17326 --- Comment #1 from daltonfur...@gmail.com --- TLDR; If you have reached the maximum number of checkouts, you cannot renew books. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17326] New: KOha not asking if the book is to be renewed when max book limit is reached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17326 Bug ID: 17326 Summary: KOha not asking if the book is to be renewed when max book limit is reached Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: daltonfur...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When I try to check out a book that I have already checked out, koha will ask me if I want to renew the book instead. But this does not work if I have already taken the maximum allowed number of books. In this scenario, I get the "Too many checked out." notification, but I think it is logical to allow renewal as it does not increase the number of books that the patron has taken. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17320] MySQL 5.7 doesn't work well with SQL using '0000-00-00'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 M. Tompsettchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17234 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 M. Tompsettchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17320 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17260] updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260 M. Tompsettchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17320 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17320] MySQL 5.7 doesn't work well with SQL using '0000-00-00'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 M. Tompsettchanged: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com |ity.org | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17260 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5764] not for loan message in staff client repeated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5764 Marjorie Barry-Vilachanged: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17325] New: Circulation needs borrowers permission if patrons got image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17325 Bug ID: 17325 Summary: Circulation needs borrowers permission if patrons got image Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: sophie.meyni...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Log in with an account having circulate_remaining_permissions and staffaccess. Find a patron with image. Try to check out for this patron. Patron image is not loaded and when you give barcode to check out, you are disconnected from Koha. Give borrowers permission to your account. Try to checkout for the same patron as before. Patron image is correctly displaid and check out is done correctly. This is because to display patron info, koha/members/patronimage.pl is called that needs borrowers permission. This is a problem when you want an account only for circulation and not patron modification. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 --- Comment #30 from M. Tompsett--- (In reply to Liz Rea from comment #29) > Just wondering, I don't think the subs where they are are usable by say, > perl atomicupdates. (or, please tell how to use them because even though I > should know or it's obvious, I don't) Good point, Liz. Perhaps those to functions are better suited to Koha::Database? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14642] Add logging of hold modifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Tomás Cohen Arazichanged: What|Removed |Added CC||wizzy...@gmail.com --- Comment #29 from Tomás Cohen Arazi --- *** Bug 6890 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6890] Add reserves to modification logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890 Tomás Cohen Arazichanged: What|Removed |Added CC||tomasco...@gmail.com Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #12 from Tomás Cohen Arazi --- *** This bug has been marked as a duplicate of bug 14642 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17322] Translation breaks opac-ics.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17322 Josef Moravecchanged: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17322] Translation breaks opac-ics.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17322 Josef Moravecchanged: What|Removed |Added Attachment #55718|0 |1 is obsolete|| --- Comment #2 from Josef Moravec --- Created attachment 55733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55733=edit Bug 17322 - Translation breaks opac-ics.tt This patch adds newlines to opac-ics.tt that are preserved by the translating process. To test: - Apply patch - Create a translation (perl translate xy-XY) - With a text editor or poedit, translate misc/translator/po/xy-XY-opac-bootstrap.po (it is enough to translate "%s %s %s %s is overdue %sYour copy of") - Install language xx-XY and select it for OPAC (perl translate install xy-XY) - Make sure you have at least a couple of loans, including one overdue - Go to /cgi-bin/koha/opac-user.pl and click on the link labeled "Download as iCal/.ics file" - Inspect the file in a text editor and/or view the result in a calendar appplication. Make sure the data makes sense. Compare it to the english version. Signed-off-by: Josef Moravec Works as described -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17322] Translation breaks opac-ics.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17322 Josef Moravecchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566 Petter Goksøyr Åsenchanged: What|Removed |Added CC||boutrosboutrosboutros@gmail ||.com --- Comment #11 from Petter Goksøyr Åsen --- This patch creates another bug: When confirming transfer and print slip, the print-slip popup winwod appears, but when it returns, the transfer is not effected. (because of e.preventDefault(), the form event is never processed) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17307] Some edit buttons/ links for patrons do not work without a categorycode in the URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17307 Andreas Roussoschanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17307] Some edit buttons/ links for patrons do not work without a categorycode in the URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17307 Andreas Roussoschanged: What|Removed |Added Attachment #55698|0 |1 is obsolete|| --- Comment #7 from Andreas Roussos --- Created attachment 55732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55732=edit Bug 17307: Smaller counter-patch Given that the issue is trying to call a method on something that isn't an object, because the category code doesn't exist, then why is it even trying to change the expiry date? A simple postfix if fixes it. Signed-off-by: Andreas Roussos Applied counter-patch by M. Tompsett. All three patron 'Edit' links mentioned in previous patch's test plan work fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17307] Some edit buttons/ links for patrons do not work without a categorycode in the URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17307 --- Comment #6 from Andreas Roussos--- (In reply to M. Tompsett from comment #5) [snip] > While this is all true, that's not what the block of code is trying to do. > Patron's should have an expiry date for their account. The problem is not > the lack of category code, the problem is the lack of expiry date. This code > is trying to correct the expiry date based on the category code. However, > given that we don't know what the category code is, the program shouldn't > even be trying to set the dateexpiry at all. So, in the case that there is > no category found, which is also possible by passing a BAD one, we should > not set the dateexpiry. In short, set the dateexpiry to the function call > *IF* there is a patron_category. Hence, my counter patch. Feel free to sign > off on it and obsolete yours, Andreas, if you think it is better. > > I don't think fixing all the templates to pass category code is the correct > way to handle the problem. I agree with your analysis above; the code shouldn't be trying to set an expiry date if no patron_category can be found, so it makes more sense to fix this in members/memberentry.pl rather than in the templates. I've obsoleted my patch and will sign off on yours. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17307] Some edit buttons/ links for patrons do not work without a categorycode in the URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17307 Andreas Roussoschanged: What|Removed |Added Attachment #55623|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #230 from Katrin Fischer--- Created attachment 55730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55730=edit screenshot of my circulation rule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #231 from Katrin Fischer--- Created attachment 55731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55731=edit 'place hold' screen in staff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #229 from Katrin Fischer--- Another example: - record with 2 items - circulation rules as above, 1 hold allowed on the record - Item level holds: forced I can only place record level holds in OPAC and staff. At the moment, I am not able to place item level holds in any circumstances in my installation. Please, can someone investigate this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #228 from Katrin Fischer--- This also breaks the option to enforce item holds! Example: - on shelf holds allowed - holds allowed 5 - holds on same record allowed 5 - FORCE item level holds On a record with only one item, you can only place a record level hold in OPAC now - which is against your circulation conditions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/