[Koha-bugs] [Bug 8387] Hide labels when no links exist under them

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17080] Koha::Object-> new should handle default values for NOT NULL columns

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #20 from Martin Renvoize  ---
Looks reasonably to me. Logic is all sound, we're making sure it only affects
non-nullable columns. I can't see any problems.  I'd also have passed qa if
someone hadn't beaten me to it ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Irma Birchall  changed:

   What|Removed |Added

 CC||i...@calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #41642|0   |1
is obsolete||

--- Comment #5 from Aleisha Amohia  ---
Created attachment 56613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56613=edit
Bug 14367: Add MARC record history

This is a proof-of-concept implementation for adding history
support to MARC records. Every time a change is made a complete
copy of the record is stored along with the date/time and user
identity. The changes are listed under each field in the MARC
record editor and can be reverted with a click.

The changes are stored as a JSON array in a new column named
'history' in the database. The array is re-read from the database
before updating the record to prevent old data lingering in
the session from overwriting newer changes made by other users.

If we decide to implement this feature it might be better to
simply create a new table altogether and link it rather than
the clumsy JSON solution. That would eliminate a lot of bulky
code that transforms MARC-KOHA-JSON and back while ensuring
data integrity.

Also, there are plans to add permissions to the MARC records;
this likely requires more complex interactions that will scale
badly with the current JSON solution.

At present, the history is hardcoded to 10 entries.
This can easily be made into a syspref.

The current implementation should probably be refactored
into a 'BiblioHistory' class before deploying.

Documentation of the functions/methods are also needed.

Icon is ugly and needs to be improved.

Sponsored-By: Halland County Library & Catalyst IT

Test plan:
* Run updatedatabase.pl
* Log into Staff interface, search for a title, choose to edit it's MARC
record.
* Chose a MARC field and modify it, press Save.
* Open the MARC editor again for the same title.
* Next to the edited field a new icon should appear, looking like
  a clock face with a encircling arrow; the history icon.
* Clicking the icon should open a table showing all changes done
  to the record, including value change, date/time and user name.
* Clicking a record in the history log should revert that field to the
  clicked value (a previous value)
* Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

--- Comment #22 from Aleisha Amohia  ---
Patches reattached to fix merge conflicts.

(In reply to Jokin Perez de Viñaspre from comment #18)
> Hi!
> 
> The pagination doesnt work if the result of the search is bigger than the
> results_per_page.

Are you running updatedatabase.pl ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #56577|0   |1
is obsolete||

--- Comment #21 from Aleisha Amohia  ---
Created attachment 56612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56612=edit
Bug 14715: database updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #56576|0   |1
is obsolete||

--- Comment #20 from Aleisha Amohia  ---
Created attachment 56611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56611=edit
Bug 14715: syspref for results per page options

Remove the "all" option.

Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of
results per page including [OPAC]numSearchResults.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #56575|0   |1
is obsolete||

--- Comment #19 from Aleisha Amohia  ---
Created attachment 56610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56610=edit
Bug 14715: results per page setting for catalog search

Add new select field to catalog search results pages which allows user to set
number
of results to be shown per page. Setting saved in cookie "results_per_page".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17367] Showing all items must keep show holdings tab in OPAC details

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17367

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #7 from Brendan Gallagher  ---
Pushed to Master - Should be in the November 16.11 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17423] patronimage.pl permission is too restrictive

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17423

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #8 from Brendan Gallagher  ---
Pushed to Master - Should be in the November 16.11 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16358] Rancor - Deleting records when Rancor is enabled just opens them

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16358

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Brendan Gallagher  ---
Pushed to Master - Should be in the November 16.11 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17430] MarkIssueReturned.t should create its own data

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17430

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #4 from Brendan Gallagher  ---
Pushed to Master - Should be in the November 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10298] t::lib:: Mocks tries to deal with syspref but doesn not manage to

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks|10337   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337
[Bug 10337] Add a script to insert all sample data automatically
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457

Chris Cormack  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457

Chris Cormack  changed:

   What|Removed |Added

  Attachment #55948|0   |1
is obsolete||

--- Comment #30 from Chris Cormack  ---
Created attachment 56609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56609=edit
Bug 14457 - Follow up

Added another syspref for the url of the Libris API
Added sysprefs to syspref.sql

Please test the 2 patches together

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457

--- Comment #29 from Chris Cormack  ---
(In reply to Katrin Fischer from comment #27)
> I tried fixing the typo, but now I get:
> File does not exist: 400 URL must be absolute
>  at /home/vagrant/kohaclone/Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm
> line 35.
> Maybe this is because I am testing this with kohadevbox and the example key
> (no server IP...)?

Hmm nope it will be because the atomic update didn't run.

You need the url set in your sysprefs. You could do it manually, if you don't
want to run the atomicupdate, just set that preference to
http://api.libris.kb.se/bibspell/

(The preference is LibrisUrl)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10337] Add a script to insert all sample data automatically

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on|10273, 10298|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273
[Bug 10273] Unit tests should not be dependent on the Jenkins database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298
[Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15392] Add a script to load default data

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15392

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Tomás Cohen Arazi  ---


*** This bug has been marked as a duplicate of bug 10337 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks|10337   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337
[Bug 10337] Add a script to insert all sample data automatically
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10337] Add a script to insert all sample data automatically

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

--- Comment #9 from Tomás Cohen Arazi  ---
*** Bug 15392 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17105] Do not see checkouts in the table of circulation.pl

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17105

--- Comment #2 from Owen Leonard  ---
(In reply to Marcel de Rooy from comment #0)

> This javascript error occurred: Sunday not defined.

I can reproduce this error in Firefox if I manually update the
CalendarFirstDayOfWeek preference with the value "Sunday." Could it be a data
problem from an upgrade?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17460] New: Staff interface to manage self-registered patrons

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17460

Bug ID: 17460
   Summary: Staff interface to manage self-registered patrons
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: indr...@l2c2.co.in
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When a patron self-registers via the OPAC we need to check them and activate
their account after verification. This interface available in the staff client
is expected to provide the following facilities:

   - List self registered patrons (by date range, alphabetically by name)
   - Account Activation status
   - Email verification status
   - Option to batch patron category change.
   - Option to batch activate verified patrons.

Ref: Based on Mr. Md. Mubassir Ahsan's post
https://lists.katipo.co.nz/pipermail/koha/2016-October/046377.html

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #134 from Alex Sassmannshausen 
 ---
(In reply to Jonathan Druart from comment #133)
> Great work Alex, thanks for your perseverance! :)

Indeed, thanks to you and your perseverance too! :-)

> Marked as Passed QA

Great news!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17459] Add a script to create a superlibrarian user

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17459

Jonathan Druart  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com,
   ||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17459] Add a script to create a superlibrarian user

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17459

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17459] Add a script to create a superlibrarian user

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17459

--- Comment #1 from Jonathan Druart  
---
Created attachment 56608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56608=edit
Bug 17459: Add a script to create a superlibrarian user

This is for developers: it's quite long (many clics) to create a new
superlibrarian user.
This new script creates a new user with superlibrarian permissions with
the easy to remember credential koha/koha

Test plan:
  perl misc/devel/create_superlibrarian.pl
Log in to Koha using koha/koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10337] Add a script to insert all sample data automatically

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17459

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17459] New: Add a script to create a superlibrarian user

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17459

Bug ID: 17459
   Summary: Add a script to create a superlibrarian user
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

As a developer, I'd like to create a superlibrarian user easily, without any
clics

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10337] Add a script to insert all sample data automatically

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Jonathan Druart  changed:

   What|Removed |Added

 CC||ro...@catalyst.net.nz
  Component|Test Suite  |Command-line Utilities

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10337] Add a script to insert all sample data automatically

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10337] Add a script to insert all sample data automatically

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42784|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 56607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56607=edit
Bug 10337: Add a script to populate devs' DBs with sample data

Executing the installer process and inserting all the sample data take a
lot of clics and time.
The idea of this script is to provide a quick way to insert all the
sample data easily to get a working Koha install asap.

Test plan:
- Set your database config to a non-existent DB
- Execute perl misc/devel/populate_db.pl
You will get an error
- Create an empty DB
- Execute perl misc/devel/populate_db.pl
It will insert all the MARC21 sample data
- Execute perl misc/devel/populate_db.pl
You will get an error because the DB is not empty (systempreferences and
borrowers tables)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #133 from Jonathan Druart  
---
Great work Alex, thanks for your perseverance! :)
I have squashed 2 or 3 patches for the readability (add and deletion of the
same files).

Marked as Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #132 from Jonathan Druart  
---
Created attachment 56606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56606=edit
Bug 5670: Add a confirmation message on delete

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #131 from Jonathan Druart  
---
Created attachment 56605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56605=edit
Bug 5670: Use the fa icon for the save button

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #128 from Jonathan Druart  
---
Created attachment 56602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56602=edit
Bug 5670: Update constraint name to match with the one in updatedatabase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10337] Add a script to insert all sample data automatically

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED
Summary|UT: The unit tests cannot   |Add a script to insert all
   |be launched by everyone |sample data automatically

--- Comment #7 from Jonathan Druart  
---
I reworked this patch to create a misc/devel script inserting all the sample
data in the DB.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10337] Add a script to insert all sample data automatically

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Jonathan Druart  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #130 from Jonathan Druart  
---
Created attachment 56604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56604=edit
Bug 5670: Use Koha.Preference to retrieve syspref from templates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #129 from Jonathan Druart  
---
Created attachment 56603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56603=edit
Bug 5670: Does not return 0 in Koha::Patron->housebound_* methods

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56369|0   |1
is obsolete||

--- Comment #127 from Jonathan Druart  
---
Created attachment 56601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56601=edit
Bug 5670: [Followup] Add 'step 4' edit button.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:
  Place housebound role form inside the 'step 4' section.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt:
  Add 'step 4' edit button for housebound role.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56368|0   |1
is obsolete||

--- Comment #126 from Jonathan Druart  
---
Created attachment 56600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56600=edit
Bug 5670: Add auth_val_cat to auth_val_cat.sql.

* installer/data/mysql/atomicupdate/housebound_tables.sql: Insert
  HSBND_FREQ in authorised value categories.
* installer/data/mysql/mandatory/auth_val_cat.sql: Add HSBND_FREQ.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56367|0   |1
is obsolete||

--- Comment #125 from Jonathan Druart  
---
Created attachment 56599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56599=edit
DO NOT PUSH: Moar Housebound Schema files.

* Koha/Schema/Result/Borrower.pm: New method.
* Koha/Schema/Result/HouseboundRole.pm: New file.

https://bugs.koha-community.org/show_bug.cgi?id=5670

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56366|0   |1
is obsolete||

--- Comment #124 from Jonathan Druart  
---
Created attachment 56598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56598=edit
Bug 5670: [QA Followup] HouseboundRole CRUD from UI.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Add
  HouseboundRole form.
* members/memberentry.pl: Handle HouseboundRole CRUD.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56365|0   |1
is obsolete||

--- Comment #123 from Jonathan Druart  
---
Created attachment 56597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56597=edit
Bug 5670: [QA Followup] Display HouseboundRole info.

* Koha/Patron.pm (housebound_role): New method.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: Add
  section for HouseboundRole information
* members/moremember.pl: Pass HouseboundRole info to template.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56359|0   |1
is obsolete||

--- Comment #117 from Jonathan Druart  
---
Created attachment 56591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56591=edit
Bug 5670: remove useless call to ->new when ->search is enought

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56360|0   |1
is obsolete||

--- Comment #118 from Jonathan Druart  
---
Created attachment 56592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56592=edit
Bug 5670: [QA Followup] Improve template style.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Remove
  toggler class from form, improve look and layout of action buttons.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56364|0   |1
is obsolete||

--- Comment #122 from Jonathan Druart  
---
Created attachment 56596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56596=edit
Bug 5670: [QA Followup] Correct housebound role search.

* Koha/Patrons.pm (search_housebound_choosers)
  (search_housebound_deliverers): Use new table.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56357|0   |1
is obsolete||

--- Comment #115 from Jonathan Druart  
---
Created attachment 56589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56589=edit
Bug 5670: Add the 'required' class to required fields

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56358|0   |1
is obsolete||

--- Comment #116 from Jonathan Druart  
---
Created attachment 56590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56590=edit
Bug 5670: mv housebound_* to search_housebound_*

I think it's better to prefix the subroutine names used to search with
'search_'.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56361|0   |1
is obsolete||

--- Comment #119 from Jonathan Druart  
---
Created attachment 56593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56593=edit
Bug 5670: [QA Followup] More "required" messages.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Mark
  houseboundvisit fields as required.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56363|0   |1
is obsolete||

--- Comment #121 from Jonathan Druart  
---
Created attachment 56595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56595=edit
Bug 5670: [QA Followup] Create HouseboundRole objects.

* Koha/Patron/HouseboundRole.pm: New file.
* Koha/Patron/HouseboundRoles.pm: New file.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56362|0   |1
is obsolete||

--- Comment #120 from Jonathan Druart  
---
Created attachment 56594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56594=edit
Bug 5670: [QA Followup] Create housebound roles table.

* installer/data/mysql/atomicupdate/housebound_tables.sql (housebound_role):
  New table.
* installer/data/mysql/kohastructure.sql (housebound_role): New table.
* installer/data/mysql/en/mandatory/auth_values.sql: Remove HSBND_ROLE entries.
* installer/data/mysql/en/mandatory/patron_attributes.sql: Remove
  HSBND_ROLE entry.
* installer/data/mysql/en/mandatory/patron_attributes.txt: Remove
  explanatory text.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56355|0   |1
is obsolete||

--- Comment #113 from Jonathan Druart  
---
Created attachment 56587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56587=edit
Bug 5670: [QA Followup] Small QA fixes.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Remove
  `console.log` invocations.
* members/housebound.pl ($houseboundvisits, $chooser, $deliverer):
  Remove unused variables.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56346|0   |1
is obsolete||

--- Comment #106 from Jonathan Druart  
---
Created attachment 56580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56580=edit
DO NOT PUSH: Add Housebound Schema files.

* Koha/Schema/Result/HouseboundProfile.pm: New file.
* Koha/Schema/Result/HouseboundVisit.pm: New file.

https://bugs.koha-community.org/show_bug.cgi?id=5670

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56353|0   |1
is obsolete||

--- Comment #111 from Jonathan Druart  
---
Created attachment 56585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56585=edit
Bug 5670: [QA Followup] Avoid CGI::param in list context.

* members/housebound.pl: Force `borrowernumber` to scalar context.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56356|0   |1
is obsolete||

--- Comment #114 from Jonathan Druart  
---
Created attachment 56588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56588=edit
Bug 5670: [QA Followup] Fix `div.patroninfo`.

* members/housebound.pl: Provide full patron hash keys, extended patron
  attributes & picture to template.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt:
  Refactor to use new information.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56354|0   |1
is obsolete||

--- Comment #112 from Jonathan Druart  
---
Created attachment 56586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56586=edit
Bug 5670: [QA Followup] Housebound link from patron edit.

* koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc: Add a link
  to the housebound module view if it is switched on.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56350|0   |1
is obsolete||

--- Comment #109 from Jonathan Druart  
---
Created attachment 56583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56583=edit
Bug 5670: [Followup] Refactor .pl; error messages.

* members/housebound.pl: Refactor & store messages for encountered
  errors.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Show
  messages.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56349|0   |1
is obsolete||

--- Comment #108 from Jonathan Druart  
---
Created attachment 56582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56582=edit
Bug 5670: [Followup] Return Koha::Patron objects.

* Koha/Patron/HouseboundVisit.pm (chooser, deliverer): Use
  `_new_from_dbic` to return Koha::Patron objects.
* t/db_dependent/Patron/HouseboundVisits.t: Remove TODO section for this.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56351|0   |1
is obsolete||

--- Comment #110 from Jonathan Druart  
---
Created attachment 56584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56584=edit
Bug 5670: [QA Followup] Don't force ISO dates.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Use
  ".datepicker" class for date input, use `$KohaDates` to filter our iso
  dates.
* members/housebound.pl: Use DateTime and Koha::DateUtils to parse
  incoming date to ISO format.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56347|0   |1
is obsolete||

--- Comment #107 from Jonathan Druart  
---
Created attachment 56581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56581=edit
Bug 5670: Housebound Readers Module

New module to handle management of circulation to Housebound readers.

- Ability to create housebound profiles & scheduled visits for patrons.
- Ability to record users as Deliverers or Choosers (or both), using
  extended patron attributes.
- Ability to link choosers and deliverers to individual delivery runs.
- 'Delivery Frequencies' are customizable through authorised
  values ('HSBND_FREQ').

* koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc: add
  Housebound menu if appropriate.
* Koha/Patron.pm (housebound_profile): New method.
* Koha/Patrons.pm (housebound_choosers, housebound_deliverers): New
  methods.
* Koha/Patron/HouseboundProfile.pm: New File.
* Koha/Patron/HouseboundProfiles.pm: New File.
* Koha/Patron/HouseboundVisits.pm: New File.
* Koha/Patron/HouseboundVisit.pm: New File.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: New file.
* members/housebound.pl: New file.
* installer/data/mysql/kohastructure.sql: Add housebound_* tables.
* installer/data/mysql/sysprefs.sql: Add HouseboundModule syspref.
* koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref:
  Add HouseboundModule syspref.
* installer/data/mysql/atomicupdate/housebound_tables.sql: New file.
* t/db_dependent/Patron/Borrower_Housebound.t: New file.
* t/db_dependent/Patron/Borrower_HouseboundProfiles.t: New file.
* t/db_dependent/Patron/Borrower_HouseboundVisits.t: New file.

Test plan:
- Apply patch.
- Run atomic update script.
- Run Unit Tests (t/db_dependent/Patron/Housebound*)
- Optionally, add additional authorised values to 'HSBND_FREQ'.
- Switch on 'HouseboundModule' syspref.
- Ensure 'ExtendedPatronAttributes syspref is on.
- On patron pages, when editing, add some to the Housebound deliverer
  and chooser groups.
- On a patron page, the Housebound menu should now be present.
  - create housebound profile
+ ensure Frequency values seem pulled from 'HSBND_FREQ'.
  - create 'housebound visits' (deliveries)
+ ensure chooser/deliverer lists are populated with patrons that
  have the Chooser or Deliverer Attribute type.
  - edit visits.
  - delete visits.
- Switch off 'HouseboundModule'
  - the Housebound menu should disappear

Signed-off-by: Chris Cormack 

Signed-off-by: Claire Gravely 

Bug 5670: [Followup] Rename test files.

* t/db_dependent/Patron/Borrower_Housebound.t: Rename to
  t/db_dependent/Patron/Housebound.t.
* t/db_dependent/Patron/Borrower_HouseboundProfiles.t: Rename to
  t/db_dependent/Patron/HouseboundProfiles.t.
* t/db_dependent/Patron/Borrower_HouseboundVisits.t: Rename to
  t/db_dependent/Patron/HouseboundVisits.t.

Signed-off-by: Claire Gravely 

Bug 5670: [QA Followup] Fix category_type ref.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Replace
  references to `category_type` with `categorycode`.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #98 from Owen Leonard  ---
(In reply to Marcel de Rooy from comment #26)

> If you browse the selection, it would imo be good to show that you are doing
> so (Browse selected results vs. Browse results).

I like this suggestion too, but I think it could be handled in a follow-up.

It looks to me like the contents of common.js could be put into global.js and
we could avoid having a separate file. Do you think there is a reason not to?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17458] New: ID of logged user is displayed when just consult an invoice (parcel.pl)

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17458

Bug ID: 17458
   Summary: ID of logged user is displayed when just consult an
invoice (parcel.pl)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org

Hi,

When we just consult receipt summary (parcel.pl), the ID of logged user is
displayed in field "Received by"
But effective receipt were done by someone else.

Id of user who done receipt is logged somewhere?

Regards,
Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method for ILSDI

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317

Pascale Nalon  changed:

   What|Removed |Added

 CC||pascale.na...@ensmp.fr,
   ||pascale.nalon@mines-pariste
   ||ch.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17457] New: Use SearchWithISBNVariations in acquisition advanced search ( histsearch.pl)

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17457

Bug ID: 17457
   Summary: Use SearchWithISBNVariations in acquisition advanced
search (histsearch.pl)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org

Hi,

In acquisition advanced search, it will be great that isbn index use system
preference SearchWithISBNVariations.

Regards,

Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export notices

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

--- Comment #4 from Bouzid  ---
Hi Michael,
sorry, i not write correctly
- Apply patch
- Open intranet or opac interface and submit any search, click title of one
item found.
- Click Save and you found Simple Export.
- Click Simple Export and you have a file.html, it contain informations
returned by the xslt file.
- You can use it in basket and lists.
- The name 'Simple Export' it's extract in the xslt file, curently the name
is MARC21_simple_export.xsl.

Bouzid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694

Magnus Enger  changed:

   What|Removed |Added

  Attachment #56442|0   |1
is obsolete||

--- Comment #7 from Magnus Enger  ---
Created attachment 56579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56579=edit
Bug 16694 - Limit SIP2 auth by patron attribute

The main use case of this bug is to use patron attributes to grant special
privileges, e.g. to open a door to an unmanned library.

This patch adds an extra check against patron attributes if login account
in SIPconfig.xml has a key validate_patron_attribute set to some patron
attribute.

If a patron information request is sent (63), and patron has proper rights in
the
given attribute: (a value of 1/true or some authorised value mapping to 1)
The user will be allowed access (in SIP: charge and/or renewal ok).
Otherwise denied.

Please note that this is specific to the SIP login account, so self checkout
machines can be handled differently than e.g. a door card terminal.

To test:
0) you need to debug using telnet or the koha provided sip_client
1) add validate_patron_attribute="testattribute" to some login account in
SIPconfig.xml
2) add a patron attribute "testattribute"
3) edit some patron and set "testattribute" to "1"
4) do a sip login with the given login account from SIPconfig.xml
5) do a patron information request (63) on the patron
6) observe that no charge or renewal denied is given in the response (64  )
7) try all or any of the following:
 - set patron attribute to anything but "1"
 - delete the patron attribute
 - map the patron attribute to an authorized list, e.g. (YES_NO) and
   set it to a value that doesn't map to "1", e.g. "No".
8) do a patron information request (63) again
9) observe that charge and renewal is now denied in the SIP response (64YY)
10) thank yourself if noone else does and grab a coffee

Signed-off-by: Magnus Enger 
Took me a while to remember I was on a gitified setup and needed to do
sudo cp C4/SIP/Sip/MsgType.pm /usr/share/koha/lib/C4/SIP/Sip/MsgType.pm
before I could test properly. Works as expected. I have a Swedish customer
running a similar hack in production, so looking forward to getting this
into Koha proper.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694

Magnus Enger  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #5 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #3)
> Hi Nick, what's the use case for this? How is it different to
> cancel_expired_holds.pl?

Cancel expired holds is for holds that have been found and are waiting and
expired. This script cancels holds that have never been found, so it can clean
up holds placed on items that were lost or damaged and will never be filled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12714] Export report in PDF

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12714

Josef Moravec  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12714] Export report in PDF

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12714

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965

--- Comment #27 from Martin Renvoize  ---
This is probably a conversation for elsewhere.. I'm going to pass qa on these
for now to prevent a holdup in the queue and in the knowledge that we can fix
the dbic usage later fairly trivially and just clean out this code again when
we have.

For deployment, I actually use DBIC::DeploymentHandler myself in other apps..
it's a great tool, and would happily cope with a move from kohastructure.sql to
a versioned schema scheme I believe.. It is however very dependency heavy so we
may need to brew our own :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17456] Cataloging plugins: change of behaviour at fileds driven by plugins

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17456

--- Comment #1 from Mike  ---
Some gifs that say maybe more
Field 003: http://www.giphy.com/gifs/3o7TKKwK0B0f76eITK
Field 008: http://www.giphy.com/gifs/3o6Zt3d0pXZog3mgw0

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

--- Comment #18 from Jokin Perez de Viñaspre  ---
Hi!

The pagination doesnt work if the result of the search is bigger than the
results_per_page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17456] New: Cataloging plugins: change of behaviour at fileds driven by plugins

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17456

Bug ID: 17456
   Summary: Cataloging plugins: change of behaviour at fileds
driven by plugins
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: blac...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Hello,
I want to report some changes of after upgrade on version 16.05 at cataloging
editor.
Description examples:
field 003
If field isn't empty click don't rewrtite it into MARCOrgCode (as older
versions). It means that imported code must be deleted and after that click add
 MARCOrgCode.

field 008
Similar  on positions 15-17, if I choose code value from autocomplete of
browser, value isn't rewrited after save.

Thanks

Mike

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17456] Cataloging plugins: change of behaviour at fileds driven by plugins

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17456

Mike  changed:

   What|Removed |Added

   Priority|P5 - low|P3
 CC||josef.mora...@gmail.com,
   ||r...@rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17449] Let users choose action in self checkout

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17449

--- Comment #2 from Magnus Enger  ---
Work in progress: https://github.com/Libriotech/kohawork/tree/bug17449-sco-tabs

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17447] Housekeeping: Tidy up misc/batchRebuildItemsTables.pl

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #56516|0   |1
is obsolete||

--- Comment #2 from Marcel de Rooy  ---
Created attachment 56578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56578=edit
Bug 17447: Housekeeping: Tidy up misc/batchRebuildItemsTables.pl

This script contained lots of complete if blocks on one line.
In this patch a lot of whitespace has been moved around.
A line with a call to _build_tag_directory has been removed; the results
were discarded.
Variable $extkey was not used either.
The script now does not only print help if you specify -t.

Test plan:
Run the script. Do not test on production data!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965

--- Comment #26 from Marcel de Rooy  ---
(In reply to Martin Renvoize from comment #25)
> So.. I'm mostly OK with these patches.. but I have a related question:
> 
> What's the history around the continual regeneration of dbic result classes?
> 
> 
> My general understanding of dbic over the past couple of years is that
> 'dbicdump' is really about allowing a migration path from a non-dbic system
> to a system with dbic classes. It's a one time thing, and then you should
> really maintain the classes and instead generate the db changes from them as
> opposed to the other way around.  If we did this, we could happily rename
> our resultset and result classes and remove some of the code here that
> requires mapping from ::Object to ::Result classes.
> 
> Just something to bare in mind.  I could happily write a proof of concept
> for such a trivial dbic ::Result object example should people be interested
> in such.

Yes, I think we should move forward too and obsolete kohastructure.sql etc.
iirc there were problems with deploying (instead of running kohastructure for a
new install), perhaps on some specific systems? Running the sql file probably
was considered safer.
Furthermore we would need to address how to deploy for existing installs in
updatedatabase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4042] Public OPAC search can fall prey to web crawlers

2016-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042

--- Comment #5 from Magnus Enger  ---
(In reply to Katrin Fischer from comment #4)
> Should we include a default/sample robots.txt with Koha?

There is a file called README.robots at the top of the project (with the other
READMEs). Maybe we could include Bob's example there too?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/