date:20161027

[Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href=

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575

--- Comment #8 from David Cook  ---
Can't believe it's almost been 6 months. This is still on my to do list
although I don't think I'll be looking at it until 2017 at the earliest.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14281] text notices include tags

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14281

jdem...@roseville.ca.us  changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

Radek Šiman (R-Bit Technology, s.r.o.)  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #15 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Problem concerning the QA script solved in a cooperation with Katrin. Asking to
sign-off again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

--- Comment #14 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Can anybody help me, what am I doing wrong? Thanks.

../qa-test-tools/koha-qa.pl -v 2 -c 1
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
   OK forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   FAIL   valid_template
Attempt to reload Koha/Template/Plugin/Koha.pm aborted.
Compilation failed in require at
/usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Plugins.pm line 206.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

--- Comment #13 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Created attachment 56933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56933=edit
Fixed forbidden patterns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17516] New: Add CSV export option to item search after displaying output to screen

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17516

Bug ID: 17516
   Summary: Add CSV export option to item search *after*
displaying output to screen
 Change sponsored?: ---
   Product: Koha
   Version: 3.20
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: rhilli...@hotchkiss.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Currently, if you do an item search, you have to select whether to have the
output be "csv" or "screen" on the same page
(/cgi-bin/koha/catalogue/itemsearch.pl) as where you input the search
parameters.

It would be a useful enhancement to add a button or link to download the csv
for folks who choose to output to the screen: then they could check that the
results look appropriate before downloading the data.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17515] New: Advanced Editor - Rancor - Z39 sources not sorted properly

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17515

Bug ID: 17515
   Summary: Advanced Editor - Rancor - Z39 sources not sorted
properly
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

This appears to be a bug, the list of servers is retrieved from the database in
order, however, it is stored in an unordered object, so the lists are posted to
the page in a random order.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17406] Simplify pay.pl interface buttons

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17406

--- Comment #4 from Christopher Brannon  ---
I like it.  It is very similar to my request.  The one thing I have trouble
with is the note.  This does not give the option to place individual notes on
the individual items.  See
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17409 for my
suggestion and let me know your thoughts.

I still think the real estate could be consolidated more by combining the
dropdown and process into an action button that defaults to payment.  What do
you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #28 from Tomás Cohen Arazi  ---
I rebased them, they need some work, tough. Input from people interested is
welcome.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17406] Simplify pay.pl interface buttons

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17406

Kyle M Hall  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17409

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17409] Remove redundant note fields for payments on pay.pl

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17409

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17406

--- Comment #1 from Kyle M Hall  ---
I think my proposal on bug 17406 would also take care of this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17406] Simplify pay.pl interface buttons

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17406

Kyle M Hall  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17408

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17408] paycollect.pl should show more information

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17408

--- Comment #1 from Kyle M Hall  ---
I think my proposal on bug 17406 would solve this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17408] paycollect.pl should show more information

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17408

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17406

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17406] Simplify pay.pl interface buttons

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17406

--- Comment #3 from Kyle M Hall  ---
Christopher, I would propose a bit of an alternative. I've attached a
screenshot of the payment feature from the old accounts rewrite. As you can
see, there are a series of checkboxes and an amount field that is updated based
on what is selected. So you can pay by selected, or pay by amount ( or a
combination of both ). All the pay buttons are replaced with a single button
and a pulldown that lets you select whether the fine is being paid of forgiven
( the rewrite also allows for other arbitrarily defined payment types ).

What do you think of that idea?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17406] Simplify pay.pl interface buttons

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17406

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #2 from Kyle M Hall  ---
Created attachment 56932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56932=edit
Screenshot of Accounts Rewrite payment system

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Nick Clemens  changed:

   What|Removed |Added

  Attachment #56921|0   |1
is obsolete||

--- Comment #2 from Nick Clemens  ---
Created attachment 56931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56931=edit
Bug 17374 - Make use of fields from syspref 'DefaultPatronSearchFields' in
patron search fields dropdown

This patch preserves the current dropdown choices for patron search and adds
fields from
the DefaultPatronSearchFields system preference

To test:
1 - View the regular patron search and note fields in dropdown
2 - Apply patch, ensure dropdown has not changed
3 - Add fields to DefaultPatronSearchFields, note they are available in
dropdown
4 - Ensure existing and new fields search properly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17514] Record details page uses incorrect class "results_summary"

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
I agree with Owen - we are using results_summary in combination with the unique
id from the body which avoids any problems. But we'd probably have to change
the CSS for quite a few libraries if these classes were changed suddenly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17511] Authority linking subfield

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511

--- Comment #5 from Katrin Fischer  ---
Hm, I think I confused this with the $w subfields, $0 is indeed quite old:
$0 - Record control number [NEW, 1997]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17511] Authority linking subfield

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
I think another reason might be that Koha was using $9 when there was no $0
subfield in MARC21 yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

--- Comment #27 from Tomás Cohen Arazi  ---
Created attachment 56929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56929=edit
Bug 13757: DBIC update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17514] New: Record details page uses incorrect class "results_summary "

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514

Bug ID: 17514
   Summary: Record details page uses incorrect class
"results_summary"
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The record details page re-uses the class results_summary which is semantically
incorrect and causes unwanted interactions with the styling of the actual
results page which also uses the results_summary class. We should change the
instances of the results_summary class to details_summary on this page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #48382|0   |1
is obsolete||

--- Comment #25 from Tomás Cohen Arazi  ---
Created attachment 56927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56927=edit
Bug 13757: (QA followup) fix QA issues, add small niceties

Remove debug warns, and hide patron attributes in the OPAC if
PatronSelfRegistrationVerifyByEmail is enabled (as this enhancement
currently does not work with Koha::Borrower::Modifications).

Also, slightly improve appearance of attributes with passwords.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Nick Clemens  changed:

   What|Removed |Added

  Attachment #56909|0   |1
is obsolete||

--- Comment #106 from Nick Clemens  ---
Created attachment 56930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56930=edit
Bug 13321 - (QA Followup) Restore standing order functionality

Some lines deleted during rebase, restored and updated, tests repaired

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17514] Record details page uses incorrect class "results_summary"

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514

--- Comment #3 from Owen Leonard  ---
Also: This patch modifies the staff client template, but the same issue exists
in the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

--- Comment #26 from Tomás Cohen Arazi  ---
Created attachment 56928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56928=edit
Bug 13757: (followup) Rebase against master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17514] Record details page uses incorrect class "results_summary"

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514

Owen Leonard  changed:

   What|Removed |Added

  Component|OPAC|Templates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #48381|0   |1
is obsolete||

--- Comment #24 from Tomás Cohen Arazi  ---
Created attachment 56926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56926=edit
Bug 13757: (followup) fix creation of patron attributes

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #48379|0   |1
is obsolete||

--- Comment #22 from Tomás Cohen Arazi  ---
Created attachment 56924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56924=edit
Bug 13757: Make patron attributes editable in the OPAC (1/2)

This patch adds an opac_editable property of borrower attribute types
that can be set in the interface.

Test plan:
  1. Repeat the following with a new and existing borrower attribute
 type:
  2. Verify that "Editable in OPAC" can only be checked if "Display in
 OPAC" is checked.
  3. Verify that this new property is correctly saved.

Signed-off-by: Aleisha 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17514] Record details page uses incorrect class "results_summary"

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Owen Leonard  ---
I agree about the semantic issue, but is the practical aspect of this that it
creates problems with customizations?

If we have a patch adding details_summary, staff-global.css should be modified
to add style for it so that it doesn't break the existing view. As it is, tags,
MARC preview, and Holds all display on the same line.

This patch must also modify the XSL stylesheet since many of the
"results_summary" instances come from there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #48380|0   |1
is obsolete||

--- Comment #23 from Tomás Cohen Arazi  ---
Created attachment 56925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56925=edit
Bug 13757: Make patron attributes editable in the OPAC (2/2)

This patch makes attributes marked as OPAC-editable editable from the
OPAC.

NOTE: This needs to be extended to work with the modifications system,
and thus only works for new patrons.

Test plan:
 1) Create attributes that cover the spectrum of possible attribute
types; repeatable, unique, dropdown, etc.
 2) Verify that all of these attributes are correctly validated and
saved.

Aleisha's update: Fixed a merge conflict and a warn "Argument "" isn't numeric
in numeric gt (>) at
/usr/share/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
line 336."

Signed-off-by: Aleisha 

Sorry forgot to run updatedatabase.pl!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

--- Comment #12 from Marc Véron  ---
(In reply to Radek Šiman (R-Bit Technology, s.r.o.) from comment #11)
> As I am new to Koha development, could you please tell me what tools and how
> have you run to find this? Maybe the problem is TAB instead of 4 spaces?

Hi Radek

Yes, it's the indentation, see:
https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL6:_Indentation

For the QA tools see:
https://wiki.koha-community.org/wiki/QA_Test_Tools

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17514] Record details page uses incorrect class "results_summary"

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17513] koha-create does not set GRANTS correctly

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513

--- Comment #1 from Jonathan Druart  
---
Created attachment 56922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56922=edit
Bug 17513: Create GRANT for user@localhost in koha-create

See the bug description for the details.

Test plan:
Use this script to create a new koha installation, using MariaDB
You should not display
"user koha_kohadev doesn't have enough privilege on database koha_kohadev "

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17514] Record details page uses incorrect class "results_summary"

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514

--- Comment #1 from Kyle M Hall  ---
Created attachment 56923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56923=edit
Bug 17514 - Record details page uses incorrect class "results_summary"

The record details page re-uses the class results_summary which is
semantically incorrect and causes unwanted interactions with the styling
of the actual results page which also uses the results_summary class. We
should change the instances of the results_summary class to
details_summary on this page.

Test Plan:
1) Apply this patch
2) Browse to the record details for a bib
3) View the html, note that no elements have the class results_summary,
   instead, you should see the class details_summary

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17514] Record details page uses incorrect class "results_summary"

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17513] koha-create does not set GRANTS correctly

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

--- Comment #1 from Nick Clemens  ---
Created attachment 56921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56921=edit
Bug 17374 - Make use of fields from syspref 'DefaultPatronSearchFields' in
patron search fields dropdown

This patch preserves the current dropdown choices for patron search and adds
fields from
the DefaultPatronSearchFields system preference

To test:
1 - View the regular patron search and note fields in dropdown
2 - Apply patch, ensure dropdown has not changed
3 - Add fields to DefaultPatronSearchFields, note they are available in
dropdown
4 - Ensure existing and new fields search properly

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17513] New: koha-create does not set GRANTS correctly

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513

Bug ID: 17513
   Summary: koha-create does not set GRANTS correctly
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

There is a behavior change between MySQL and MariaDB:

With:
 CREATE DATABASE koha_kohadev;
 CREATE USER koha_kohadev@localhost IDENTIFIED BY 'password';
 CREATE USER koha_kohadev@'%' IDENTIFIED BY 'password';
 GRANT ALL PRIVILEGES ON koha_kohadev.* TO koha_kohadev;

Using Mysql, as admin user:
mysql> SHOW GRANTS FOR koha_kohadev@'localhost';
  GRANT USAGE ON *.* TO 'koha_kohadev'@'localhost' IDENTIFIED BY PASSWORD
'*2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19'

mysql> SHOW GRANTS FOR koha_kohadev;
  GRANT USAGE ON *.* TO 'koha_kohadev'@'%' IDENTIFIED BY PASSWORD
'*2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19'
  GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'%'

Using Mysql, as koha_user user:

mysql> SHOW GRANTS FOR koha_kohadev@'localhost';
  GRANT USAGE ON *.* TO 'koha_kohadev'@'localhost' IDENTIFIED BY PASSWORD


mysql> SHOW GRANTS FOR koha_kohadev;
  GRANT USAGE ON *.* TO 'koha_kohadev'@'%' IDENTIFIED BY PASSWORD 
  GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'%'


Using MariaDB, as admin user:
MariaDB [(none)]> SHOW GRANTS FOR kohaçkohadev@localhost;
  GRANT USAGE ON *.* TO 'koha_kohadev'@'%' IDENTIFIED BY PASSWORD
'*'2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19

MariaDB [(none)]> SHOW GRANTS FOR kohaçkohadev;
  GRANT USAGE ON *.* TO 'koha_kohadev'@'%' IDENTIFIED BY PASSWORD
'*'2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19
  GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'%'

So all the same so far :)

But,
Using MariaDB, as koha_user user:
MariaDB [(none)]> SHOW GRANTS FOR kohaçkohadev@localhost;
  GRANT USAGE ON *.* TO 'koha_kohadev'@'%' IDENTIFIED BY PASSWORD
'*'2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19

MariaDB [(none)]> SHOW GRANTS FOR kohaçkohadev;
ERROR 1044 (42000): Access denied for user 'koha_kohadev'@'localhost' to
database 'mysql'

BOOM!
The installer does not parse the expected output and then raise an error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17511] Authority linking subfield

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511

--- Comment #3 from Zeno Tajoli  ---
No problem. It is not so obvious.
The problem is the Zebra config is based on files, very difficult to chage with
system preferences. Elastichsearch conf is written into DB, so is much easier
to change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

--- Comment #11 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
As I am new to Koha development, could you please tell me what tools and how
have you run to find this? Maybe the problem is TAB instead of 4 spaces?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #46 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17511] Authority linking subfield

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511

--- Comment #2 from Stefan Berndtsson  ---
Ok. Thank you.

Just to make it clear to me. Sorry if I'm just repeating the obvious here. The
main reason it would be hard to make it into a Koha Preference is that such a
setting won't be usable in the Zebra files, but it could be used for
ElasticSearch, at least in a possible future?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17512] Improve handling dates in C4::Items

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17511] Authority linking subfield

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it

--- Comment #1 from Zeno Tajoli  ---
The selection of $9 was done in the past to have a common subfield with
UNIMARC.
In Unimarc the equivalent of $0 is $3.

The main problem to develop a similar request is that this selection is
hard-wired into Zebra config files.

So to increase the possibility to develop it, help on Elastichsearch bugs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #12 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17512] Improve handling dates in C4::Items

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512

--- Comment #1 from Marcel de Rooy  ---
Created attachment 56920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56920=edit
Bug 17512: Improve handling dates in C4::Items

This is a follow-up on the internal server error on -00-00 in the items
column onloan. This patch deals with preventing to have such dates at all
in the date fields of items.

It is accomplished by:
[1] Adding a (private) subroutine _mod_item_dates. It takes an item hash
and replaces date values if needed.
[2] AddItem and ModItem call _koha_new_item resp. koha_modify_item. In these
routines a call to the new _mod_item_dates is inserted.
[3] Although the routine is actually private, I have added some unit tests
to Items.t.

Test plan:
[1] Add a new item. Fill a correct date in dateaccessioned and an invalid
date in Price effective from (=replacementpricedate).
[2] Verify that dateaccessioned is saved correctly and replacementpricedate
is still null (does not contain -00-00).
[3] Edit the item again. Fill some text in dateaccessioned and put a correct
date in replacementpricedate. Verify the results.
[4] Run t/db_dependent/Items.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375

Nick Clemens  changed:

   What|Removed |Added

  Attachment #56685|0   |1
is obsolete||

--- Comment #11 from Nick Clemens  ---
Created attachment 56919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56919=edit
Bug 17375: Search by dateofbirth - handle invalid dates

Prevent internal software error when searching patron with invalid birth date

To reproduce:

- Go to Home > Patron
- Expand patron search (click on + at the left of the search button)
- In drop down 'Search fields', select 'Date of birth'
- Enter a valid date (e.g. 11.02.1995 if syspref 'dateformat' is set to dmydot)
Result: Search works OK
- Enter an invalid date, e.g. 11.02 or abcd...
Result: Internal server error

- Do a patron search with many results
- Use filter on results screen, select 'Date of birth' as search field and
  enter an invalid date to search (e.g. 'a')
Result: Endless message 'Processing'

To test:
- Apply patch
- Repeat steps above
- In both cases, you should get "No results"

Signed-off-by: Marc Véron 
Signed-off-by: Lucio Moraes 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375

Nick Clemens  changed:

   What|Removed |Added

  Attachment #56024|0   |1
is obsolete||

--- Comment #10 from Nick Clemens  ---
Created attachment 56918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56918=edit
Bug 17375: Search by dateofbirth - Add tests

Signed-off-by: Marc Véron 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17504] Installer shows PostgreSQL info when wrong DB permissions

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17504

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #45 from Kyle M Hall  ---
(In reply to Kyle M Hall from comment #44)
> Patches appear to need rebasing.

My bad, missed the dependancy. Patches do apply cleanly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17512] Improve handling dates in C4::Items

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17512] Improve handling dates in C4::Items

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl
 Depends on||17502


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502
[Bug 17502] Resolve internal server error on -00-00 (with Plack)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17502] Resolve internal server error on 0000-00-00 (with Plack)

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||17512


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512
[Bug 17512] Improve handling dates in C4::Items
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17512] New: Improve handling dates in C4::Items

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512

Bug ID: 17512
   Summary: Improve handling dates in C4::Items
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

This is a follow-up on the internal server error on -00-00 in the items
column onloan. This patch deals with preventing to have such dates at all in
the date fields of items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17502] Resolve internal server error on 0000-00-00 (with Plack)

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #3 from Marcel de Rooy  ---
I am wondering about the severity of this patch.
Somehow we had a number of items with -00-00 in onloan. (Dating from older
Koha versions.)
You could argue that this would be exceptional. But still Koha should not crash
on such a detail.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17502] Resolve internal server error on 0000-00-00 (with Plack)

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502

Marcel de Rooy  changed:

   What|Removed |Added

   Severity|enhancement |normal
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17502] Resolve internal server error on 0000-00-00 (with Plack)

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #56916|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17502] Problems with 0000-00-00

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502

--- Comment #2 from Marcel de Rooy  ---
Created attachment 56917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56917=edit
Bug 17502: Resolve internal server error on -00-00 (with Plack)

This patch makes the following changes:

[1] In Koha/DateUtils.pm, sub output_pref:

Add a test if $dt is really a DateTime before calling method ymd.
Preventing a crash like:
Can't locate object method "ymd" via package "dateonly"
Change [2] fixes a specific call where this went wrong, but this test
may still catch one or two other occurrences in the code.

[2] In C4/Search.pm, sub searchResults:
Scalarize the return value of dt_from_string as a hash parameter for
output_pref. Like:
{ dt => scalar dt_from_string( $date ), dateonly => 1 }
If the sub would return undef (without adding scalar), the hash would
have an odd number of elements. (A warning is suppressed in C4/Search.)
For a value of -00-00 in item.onloan, this resolves an internal
server error on a search with this item in the results.

[3] Adds a few unit tests in t/DateUtils.t.

Note: I opened up another report to prevent having 000-00-00 in item dates.

Test plan:
[1] Without this patch: Put a -00-00 in items.onloan for one item.
(Make 952 $q visible and just enter some text in it.)
[2] Verify that a search on opac/intranet that includes this item, results
in a crash. (Plack will just say: Internal server error.)
NOTE: With Jessie and Plack, the search crashes. On a Wheezy without
Plack, it did not crash.
[3] Apply this patch. (Restart Plack.)
[4] Verify that the same search now does not fail.
[5] Run the adjusted unit test t/DateUtils.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17502] Resolve internal server error on 0000-00-00 (with Plack)

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Problems with -00-00|Resolve internal server
   ||error on -00-00 (with
   ||Plack)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17502] Problems with 0000-00-00

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502

--- Comment #1 from Marcel de Rooy  ---
Created attachment 56916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56916=edit
Bug 17502: Resolve internal server error on -00-00

This patch makes the following changes:

[1] In Koha/DateUtils.pm, sub output_pref:

Add a test if $dt is really a DateTime before calling method ymd.
Preventing a crash like:
Can't locate object method "ymd" via package "dateonly"
Change [2] fixes a specific call where this went wrong, but this test
may still catch one or two other occurrences in the code.

[2] In C4/Search.pm, sub searchResults:
Scalarize the return value of dt_from_string as a hash parameter for
output_pref. Like:
{ dt => scalar dt_from_string( $date ), dateonly => 1 }
If the sub would return undef (without adding scalar), the hash would
have an odd number of elements. (A warning is suppressed in C4/Search.)
For a value of -00-00 in item.onloan, this resolves an internal
server error on a search with this item in the results.

[3] Adds a few unit tests in t/DateUtils.t.

Note: I opened up another report to prevent having 000-00-00 in item dates.

Test plan:
[1] Without this patch: Put a -00-00 in items.onloan for one item.
(Make 952 $q visible and just enter some text in it.)
[2] Verify that a search on opac/intranet that includes this item, results
in a crash. (Plack will just say: Internal server error.)
[3] Apply this patch. (Restart Plack.)
[4] Verify that the same search now does not fail.
[5] Run the adjusted unit test t/DateUtils.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17511] New: Authority linking subfield

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511

Bug ID: 17511
   Summary: Authority linking subfield
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: stefan.berndts...@ub.gu.se
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Currently Koha links authority records and bibliographic records using subfield
9. What is the reason behind this choice? According to the MARC21
specification, subfield 0 is "Authority record control number or standard
number", which seems more logical.

Usually 9 is a locally defined field, and Libris, the National Union Catalogue
in Sweden, uses subfield 9 for various other things already.

What would it take to make the linking subfield into a configurable option?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17510] New: marc modification templates ignore subfield $0

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510

Bug ID: 17510
   Summary: marc modification templates ignore subfield $0
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: ha...@orex.es
QA Contact: testo...@bugs.koha-community.org

We have realized that Koha MArc modification templates ignore subfield 0, it is
not very common used subfield, it is working with subfields greater than 0

We have create a template for adding 773$0 (host biblionumber in analytics) but
the template doesn't get the subfield and only stores main tag 773.

Checked in:


Koha 3.22 & 16.05.05 Debian 8 and plack enabled

TEST
Go to Tools --> MARC modification templates 

Create one rule.
Add/Update field 773 0 with value 'demo'
save it

you can check that subfield is not appearing in the descrption, if you edit it
appears, but when you try to execute thah template, and try to previwe the marc
you get internal error and get the following log.

This action is not implemented yet at /usr/share/koha/lib/Koha/SimpleMARC.pm
line 169.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17164] Software error when enrolment fee or reserve fee are too high (Patron categories)

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17164

--- Comment #2 from Lari Taskula  ---
Created attachment 56915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56915=edit
Bug 17164: Lower maximum digits of enrolmentfee and reservefee in categories

If the values are too high, Patron Categories page will crash with:

Software error: Template process failed: undef error - round() overflow. Try
smaller precision or use Math::BigFloat at
/home/vagrant/kohaclone/Koha/Number/Price.pm line 44.

This is likely caused by test builder setting random huge numbers when creating
categories.

I found out that 19 digits is the maximum that can be handled. Surely it is
enough for both enrolmentfee and reservefee. This patch lowers the maximum
number of significant digits in order to avoid this crash.

To test:
1. Set category enrolmentfee with a high value, like
386269492352888000.
2. Go to cgi-bin/koha/admin/categories.pl
3. Observe Software error
4. Apply patch and run updatedatabase.pl
5. Reload the page
6. Observe that software error is gone

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17164] Software error when enrolment fee or reserve fee are too high (Patron categories)

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17164

Lari Taskula  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17491] Allow Koha Plugins to inject HTML into arbitrary pages

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17491

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17164] Software error when enrolment fee or reserve fee are too high (Patron categories)

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17164

Lari Taskula  changed:

   What|Removed |Added

 CC||lari.task...@jns.fi

--- Comment #1 from Lari Taskula  ---
I noticed the same issue in my test database. For me the high fees are probably
caused by test builder setting some random huge number. It works after lowering
the fees.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #10 from Marc Véron  ---
Great, links for changing category work now, message appears on Checkout and
Detals tab.

However QA tools complain for first patch:
FAILkoha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
   FAIL   forbidden patterns
forbidden pattern: tab char (line 188)
forbidden pattern: tab char (line 184)
forbidden pattern: tab char (line 185)
forbidden pattern: tab char (line 187)
forbidden pattern: tab char (line 189)

...and for 3rd patch:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/category-out-of-age-limit.inc
   FAIL   forbidden patterns
forbidden pattern: tab char (line 5)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

Radek Šiman (R-Bit Technology, s.r.o.)  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

Radek Šiman (R-Bit Technology, s.r.o.)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

Radek Šiman (R-Bit Technology, s.r.o.)  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |r...@rbit.cz
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17509] New: Notify patrons to return items requested on hold by another person

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

Bug ID: 17509
   Summary: Notify patrons to return items requested on hold by
another person
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: r...@rbit.cz
QA Contact: testo...@bugs.koha-community.org

Create a new notification allowing to ask patrons to return a book which has
just been put on hold by somebody else.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17474] Make possible to create fee after hold is filled and checked out to patron

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17474

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261

--- Comment #20 from Jacek Ablewicz  ---
(In reply to Jonathan Druart from comment #15)

> I think we are cover all the cases and that should work correctly most of
> the time.

+1, if we want to minimize the possibilities of mixed/inconsistent cache
initializations, it would be better to do it differently / in different places,
eg.:

- improve memcache initialization procedures (currently each one of 3 cache
instances has it's own connection to the memcache server = 3 separate inits
when plack worker gets created, each init can have different result)

- at some time, maybe get rid of Cache::Memory entirely? - sooner or later
working memcached setup should IMO became a hard requirement (especially under
plack)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17494] Koha generating duplicate self registration tokens

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17494

--- Comment #3 from Jonathan Druart  
---
Created attachment 56914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56914=edit
Bug 17494: Make sure the same verification token won't be generated twice

Well, this patch does not enforce the unique constraint but mimic what
is already done in C4::ImportExportFramework and Koha::Upload where
md5_hex is used.

Test plan:
Have a look at the code and confirm that it adds more randomness to the
hashed string

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17494] Koha generating duplicate self registration tokens

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17494

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261

--- Comment #19 from Jacek Ablewicz  ---
(In reply to Tomás Cohen Arazi from comment #17)

> I think is ready for QA.

+1

IMO this patchset is fine as it is, and would be a valuable addition even if it
doesn't fully cover some very unusual (and almost purely theoretical)
situations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261

--- Comment #18 from Jacek Ablewicz  ---
(In reply to Tomás Cohen Arazi from comment #17)
> (In reply to Katrin Fischer from comment #16)
> > Not sure about the last comment - is this ready for QA?
> 
> I think is ready for QA. The problem is that it is possible to construct a
> scenario in which each Plack worker has a different memcached situation.

Or the scenario when the single plack worker has one of eight different
hypothetically possible memcached & Cache::Memory combinations / situations ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17397] Show name of librarian who created circulation message

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397

--- Comment #13 from Jonathan Druart  
---
Created attachment 56913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56913=edit
Bug 17397: Do not display parenthesis if the manager has been deleted

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17397] Show name of librarian who created circulation message

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397

--- Comment #12 from Jonathan Druart  
---
Created attachment 56912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56912=edit
Bug 17397: Simplify code passing the Koha::Object to the template

Instead of creating a new array

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17397] Show name of librarian who created circulation message

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17397] Show name of librarian who created circulation message

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56503|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  
---
Created attachment 56911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56911=edit
Bug 17397: Show name of librarian who created circulation message

Test plan:
1) Apply the patch
2) Update DB structure
3) Run update_dbix_class_files.pl
4) Select patron for checking out
5) Try to add some circulation and opac messages
6) Note that now there is creator (you ;) ) shown by every message added (with
link to creator profile)
7) Try to delete messages to confirm that everything works as expected

Signed-off-by: Sonia Bouis 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581

--- Comment #37 from Katrin Fischer  ---
There is a conflict in the Schema changes file. I am regenerating them locally
and obsolete the patch here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #56749|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits

2016-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

Radek Šiman (R-Bit Technology, s.r.o.)  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

90 matches

Mail list logo