[Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC framework don' t work correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527

--- Comment #13 from M. Tompsett  ---
If there is no objection, I would like to test this for the reported problem
245$h and sign off. Granted, there will be further visibility issues as raised
by comment #7, with respect to item information, but this should solve a large
group of visibility issues with XSLT.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC framework don' t work correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527

--- Comment #12 from M. Tompsett  ---
(In reply to Elaine Bradtke from comment #11)
> (In reply to Jonathan Druart from comment #3)
> > (In reply to Elaine Bradtke from comment #0)
> > > This applies to 3.22 and 16.05​ (MARC 21)
> > 
> > Do you mean it worked before 3.22?
> 
> I don't know if it worked before 3.22. I have two different systems, one
> running 3.22 and the other running 16.05 and it doesn't work in either of
> them.

Proper application of the MARC framework visibility settings has been broken
for quite a while.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC framework don' t work correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527

Elaine Bradtke  changed:

   What|Removed |Added

 CC||e...@efdss.org

--- Comment #11 from Elaine Bradtke  ---
(In reply to Jonathan Druart from comment #3)
> (In reply to Elaine Bradtke from comment #0)
> > This applies to 3.22 and 16.05​ (MARC 21)
> 
> Do you mean it worked before 3.22?

I don't know if it worked before 3.22. I have two different systems, one
running 3.22 and the other running 16.05 and it doesn't work in either of them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

Radek Šiman (R-Bit Technology, s.r.o.)  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

--- Comment #8 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Created attachment 57150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57150=edit
Bug 17509: Fixed invalid patterns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

--- Comment #7 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Created attachment 57149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57149=edit
Bug 17509: notify patrons to return an item whenever a hold is placed on it

Test plan:
1) apply patch
2) run database update
3) enable sending an email to the patrons to return an item whenever a
   hold request is placed on it
4) place a hold
5) patrons having checked-out the item on hold are notified by email
   (see HOLDPLACED_CONTACT letter)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

--- Comment #3 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Created attachment 57145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57145=edit
Bug 17509: Improved system preferences for item return notification

Test plan:
1) apply patch
2) go to System preferences / Circulation / Holds Policy
3) change NotifyToReturn* variables as you wish
4) verify your changes in database

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

--- Comment #5 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Created attachment 57147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57147=edit
Bug 17509: Removed old name of atomic update file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

--- Comment #6 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Created attachment 57148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57148=edit
Bug 17509: Added notification letter HOLDPLACED_CONTACT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

--- Comment #4 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Created attachment 57146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57146=edit
Bug 17509: renamed atomic file to suit conventions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

--- Comment #2 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Created attachment 57144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57144=edit
Bug 17509: Added system preference to restrict recipients based on library

Test plan:
1) apply patch
2) go to System preferences / Circulation / Holds Policy
3) change which patrons will be contacted
4) compare your change against database value
NotifyToReturnItemFromLibrary

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

--- Comment #1 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Created attachment 57143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57143=edit
Bug 17509: Added NotifyToReturnItemWhenHoldIsPlaced syspref

This system preference will allow to ask patrons to return items
whenever a new hold is placed on them

Test plan:
1) Open System preferences / Circulation / Holds Policy
2) Change value from Enable to Don't enable and vice versa
3) Check NotifyToReturnItemWhenHoldIsPlaced is changed in database

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17544] populate_db.pl should not require t::lib::Mocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17544

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17544] populate_db.pl should not require t::lib::Mocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17544

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57130|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 57142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57142=edit
Bug 17544 - : Remove t::lib::Mocks dependency from populate_db.pl

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14567] Browse interface for OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

--- Comment #31 from Nick Clemens  ---
Yes, I would suggest checking out kohadevbox:
https://github.com/digibib/kohadevbox

Once you have a developer instance setup you can test any patches, signed off
or needing signoff :-)

(In reply to J Schmidt from comment #30)
> If we get a test instance set up locally is there a way to see signed off
> bugs? Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14567] Browse interface for OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

--- Comment #30 from J Schmidt  ---
If we get a test instance set up locally is there a way to see signed off bugs?
Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14567] Browse interface for OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14567] Browse interface for OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

--- Comment #29 from Nick Clemens  ---
Created attachment 57141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57141=edit
Bug 14567 - Fix paths (rebase from 17372)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17259] Allow batch removal of restrictions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17259

rhilli...@hotchkiss.org changed:

   What|Removed |Added

 CC||rhilli...@hotchkiss.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17379] Add a man page for koha-passwd

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17379

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|k...@bywatersolutions.com   |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15831] Can' t override renew limit by submitting a barcode in checkout with AllowRenewalLimitOverride on

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15831

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16493] acq matching on title and author

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

--- Comment #25 from Kyle M Hall  ---
Good Catch Sonia, there was a bug in my followup that was causing it to not
actually use the Title/Author matching. Please give it another try if you like!

(In reply to Koha Team Lyon 3 from comment #22)
> Hi,
> I've tested it on a bywaters sandbox (they work !)
> But I don't manage to have correct deduplication.
> The default choice for deduplication "author and title" don't actually
> deduplicate by author and title.
> - I have imported a file in a basket
> - I have changed the original file to remove ISBN
> - I have imported this second file with the "title and author" matching
> checked : all the titles have been added to the basket, though title and
> author are exactly the same.
> - I have tried to re-import the first fil with the ISBN with "title and
> author" matching : no record have been imported : the deduplication works.
> 
> I don't know what is exactly behind the matching key "title and author" ? 
> Perhaps should we call it "Title/author/ISBN" ?
> 
> Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16493] acq matching on title and author

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

--- Comment #24 from Kyle M Hall  ---
Created attachment 57140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57140=edit
Bug 16493 [QA Followup] - Restore title and author match as an option, make it
the default

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16493] acq matching on title and author

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16493] acq matching on title and author

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52903|0   |1
is obsolete||
  Attachment #52904|0   |1
is obsolete||

--- Comment #23 from Kyle M Hall  ---
Created attachment 57139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57139=edit
Bug 16493 - acq matching on title and author

When you order from a staged file you're getting duplicate warnings that
are inaccurate.  For example, when you order a file of 50 DVDs for
example and they don't have ISBNs they're matching on the books. And
then you have to order them one by one.

This patch replaces the use of FindDuplicates with Koha's match point
system. This means you can select from the same match points defined
and used in the batch record importer, or you can opt to skip matching
altogether!

Test Plan:
1) Import a record with a title, isbn and author.
2) Delete the from the record and stage it again
3) Attempt to add it to a basket via the staged record
4) You should note the gives you the "No records imported" message
5) Apply this patch
6) Create a matcher for ISBN
7) Create a matcher for Author/Title
8) Attempt to add the record to your basket using the ISBN matcher
8) Koha should find no match and import the record to the basket
9) Stage the record again
10) Attempt to add the record to your basket using the Title/Author matcher
11) You should recieve the "No records imported" message.

Signed-off-by: Barbara Fondren 

Signed-off-by: Nicole C Engard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #22 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #21)
> (In reply to Kyle M Hall from comment #20)
> > (In reply to Jonathan Druart from comment #19)
> > > Kyle, what are you testing on t/db_dependent/Koha/Account.t?
> > > it seems that it is already covered by the tests on 
> > > t/db_dependent/Accounts.t
> > 
> > I did not add that unit test file. I'll just deprecate it since it is not
> > necessary.
> 
> Then now you need to provide tests for these changes :)

Jonathan, I'm not understanding, the additional behaviors are already being
unit tested by the unit tests for makepayment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17547] (MARC21) Chronological term field 648 not indexed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17547] New: (MARC21) Chronological term field 648 not indexed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547

Bug ID: 17547
   Summary: (MARC21) Chronological term field 648 not indexed
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: MARC Bibliographic data support
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Even though the authority search in the OPAC allows searching Chronological
term authority records, the 'usage' column is always 0, because searching for
linked bibliographical records always returns 0. This is because 648$9 is not
being added in the Koha-Auth-Number index

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #57127|0   |1
is obsolete||

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 57134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57134=edit
Bug 17539: Fix Undefined subroutine ::Circulation::GetItem error

perl t/db_dependent/Reserves.t

1..72
ok 1 - use C4::Reserves;
ok 2 - CheckReserves Test 1
ok 3 - CheckReserves() include reserve_id in its response
ok 4 - CheckReserves Test 2
ok 5 - CheckReserves Test 3
ok 6 - GetReservesControlBranch returns item home branch when set to
ItemHomeLibrary
ok 7 - GetReservesControlBranch returns patron home branch when set to
PatronLibrary
ok 8 - Item is correctly waiting
ok 9 - Item is correctly priority 1
ok 10 - Item is correctly priority 2
ok 11 - GetWaiting got only the waiting reserve
ok 12 - GetWaiting got the reserve for the correct borrower
Undefined subroutine ::Circulation::GetItem called at
/home/ubuntu/kohaclone/C4/Circulation.pm line 1853.

This patch fixes this error. The solution was to use C4::Reserves before
C4::Items.
Also due to this edit, change use_ok to require_ok

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17540] auth_values_input_www.t is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17540] auth_values_input_www.t is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #57105|0   |1
is obsolete||

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 57138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57138=edit
Bug 17540: (Bug 7216 followup) Fix tests for auth_values_input_www.t

This is caused by bug 17216 which modified the structure of the AV admin
page

Test plan:
  prove t/db_dependent/www/auth_values_input_www.t
should return green

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

--- Comment #15 from Tomás Cohen Arazi  ---
Created attachment 57137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57137=edit
Bug 17539: (QA followup) Silence warnings

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #57128|0   |1
is obsolete||

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 57135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57135=edit
Bug 17539: Fix Already in a transaction error

perl t/db_dependent/Reserves.t

1..72
ok 1 - use C4::Reserves;
ok 2 - CheckReserves Test 1
...
ok 52 - Reserve in waiting status cant be canceled
ok 53 - Reserving an ageRestricted Biblio without a borrower dateofbirth
succeeds
DBD::mysql::db begin_work failed: Already in a transaction at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489.
DBD::mysql::db begin_work failed: Already in a transaction at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489.
at /usr/share/perl5/DBIx/Class/Schema.pm line 1080.
...
Koha::Object::store('Koha::Patron=HASH(0x9e43b20)') called at
/home/ubuntu/kohaclone/C4/Members.pm line 542
C4::Members::ModMember('borrowernumber', 658535, 'dateofbirth', '2001-11-02')
called at t/db_dependent/Reserves.t line 516

This patch fixes this issue by replacing dbh autocommit=0 with
txn_begin.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #57129|0   |1
is obsolete||

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 57136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57136=edit
Bug 17539: Fix failing Reserves.t tests if category enrolmentfee > 0

To test:
1. Set patron category "S" with enrolmentfee 1
2. perl t/db_dependent/Reserves.t
3. Observe following errors:

not ok 59 - Bug 14464 - No fines at beginning
ok 60 - Bug 14464 - 1st reserve correctly created
ok 61 - Bug 14968 - Keep found column from reserve
not ok 62 - Bug 14464 - No fines after cancelling reserve with no charge
configured
ok 63 - Bug 14464 - 2nd reserve correctly created
not ok 64 - Bug 14464 - No fines after cancelling reserve with no charge
desired
ok 65 - Bug 14464 - 1st reserve correctly created
not ok 66 - Bug 14464 - Fine applied after cancelling reserve with charge
desired and configured

4. Apply patch
5. perl t/db_dependent/Reserves.t
6. Observe test pass

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15480] Number of issues displayed by prediction pattern test and setting of not published issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15480

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13471] When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17546] New: Importing records with a matching rules fails when using Elastic

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17546

Bug ID: 17546
   Summary: Importing records with a matching rules fails when
using Elastic
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

If the system preference SearchEngine is set to Elasticsearch, attempting to
use matching rules fails with the error:

Can't locate object method "fields" via package "MARC::Record=HASH(0x9ce46a8)"
(perhaps you forgot to load "MARC::Record=HASH(0x9ce46a8)"?) at
/home/vagrant/kohaclone/C4/Biblio.pm line 2713.

It appears that the contents of the variable assumed to be a MARC::Record
object are literally a string and not eh object. I was able to narrow down the
issue to something going on in C4::Matcher::get_matches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17538] t/db_dependent/Upload.t is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17538

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17538] t/db_dependent/Upload.t is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17538

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #57097|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 57133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57133=edit
Bug 17538: (Bug 17216 follow-up) Fix t/db_dependent/Upload.t

The insert into authorised_values failed because of the missing FK

Test plan:
  prove t/db_dependent/Upload.t
should return green

Signed-off-by: Marcel de Rooy 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7029] searching : fuzzy et steming

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7029

--- Comment #5 from Marjorie Barry-Vila  ---
(In reply to Fridolin SOMERS from comment #4)
> (In reply to Marjorie Barry-Vila from comment #3)
> > Hi,
> > I have the same problem with 3.22.
> > 
> > an idea of the problem with research in french?
> > 
> > 
> > Regards,
> > 
> > 
> > MArjorie
> 
> There may be a problem with syspref translation.
> Can you test unsing non-translated Koha (english) ?
> 
> Regards,

Hi Fridolin,
I tested with English translation and it is the same problem.
You can try here
http://v322-dev.koha-dev.ccsr.qc.ca/cgi-bin/koha/opac-search.pl?idx=ti=paien_group_limit=
Third result contains word "pain" while search was "paien".

Is this the test you want me to do?

Regards,
Marjorie

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #57103|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 57132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57132=edit
Bug 17537: Fix valid-templates.t for some include files

3 include files do not pass the template validation tests:
 - koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc
 - koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc
 - koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc

This is because they process a block which has not been declared before.
As they are include files, they cannot stand on their own.
We could have added them to the exclude file list of
xt/author/valid-templates.t
but I think it's better to keep them into the validation loop.

Test plan:
  prove xt/author/valid-templates.t
should return green
And the library dropdown list should be correctly populated on the pages these
files are included
(opac-topissues for instance)

Signed-off-by: Claire Gravely 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17545] Make "Add biblio" not hidden by language chooser

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545

--- Comment #1 from Magnus Enger  ---
I should add that I have tested this with Koha 16.05.05 and Chromium
"53.0.2785.143 Built on Ubuntu , running on Ubuntu 16.04 (64-bit)".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17545] New: Make "Add biblio" not hidden by language chooser

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545

Bug ID: 17545
   Summary: Make "Add biblio" not hidden by language chooser
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Created attachment 57131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57131=edit
"Add biblio" hidden behind the language chooser

To reproduce: 

- Make sure more than one language is active for the staff client, so that the
language chooser bar shows at the bottom of each page
- Do one or more Z39.50 searches, to make sure you have some records in the
reservoir
- Go to "Cataloging" and do a "Catalog search", so that the reservoir is
searched. Make sure your search is broad enough that some results from the
reservoir is shown "below the fold"
- Scroll to the last result and click on the "Actions" menu
- Observe that the last choice in the menu, "Add biblio", is hidden behind the
language chooser, and cannot be shown, no matter how hard you try to scroll
further down.

See also attached image.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17544] populate_db.pl should not require t::lib::Mocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17544

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17544] populate_db.pl should not require t::lib::Mocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17544

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 57130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57130=edit
Bug 17544 - : Remove t::lib::Mocks dependency from populate_db.pl

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17544] populate_db.pl should not require t::lib::Mocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17544

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10337] Add a script to insert all sample data automatically

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||17544


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17544
[Bug 17544] populate_db.pl should not require t::lib::Mocks
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17544] populate_db.pl should not require t::lib::Mocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17544

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c
   |y.org   |ommunity.org
   Patch complexity|--- |Trivial patch
   Assignee|gmcha...@gmail.com  |tomasco...@gmail.com
 Depends on||10337


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337
[Bug 10337] Add a script to insert all sample data automatically
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17544] New: populate_db.pl should not require t::lib::Mocks

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17544

Bug ID: 17544
   Summary: populate_db.pl should not require t::lib::Mocks
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

The misc/devel/populate_db.pl script incorrectly requires t::lib::Mocks, and
this makes it fail under kohadevbox.

Steps to reproduce:
- Have a fresh kohadevbox (DB not populated)
- Run
  $ sudo koha-shell kohadev -c
"/home/vagrant/kohaclone/misc/devel/populate_db.pl --marcflavour marc21"
=> FAIL: You get:
Can't locate t/lib/Mocks.pm in @INC (you may need to install the t::lib::Mocks
module) (@INC contains: /usr/share/koha/lib /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2
/usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
/usr/local/lib/site_perl .) at
/home/vagrant/kohaclone/misc/devel/populate_db.pl line 27.
BEGIN failed--compilation aborted at
/home/vagrant/kohaclone/misc/devel/populate_db.pl line 27.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17500] Use Elasticsearch to search for patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17500

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

--- Comment #11 from Marcel de Rooy  ---
(In reply to Lari Taskula from comment #10)
> Strange! For me it seems to be working. 
Did not see that one too yesterday..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

--- Comment #10 from Lari Taskula  ---
(In reply to Jonathan Druart from comment #4)
> Lari, good catch.
> But still fail for me:
> Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 510.
Strange! For me it seems to be working. Just a guess, could it be issue with
caching as warned at lines 57-58, that set the kohafield for line 509:
57: # Somewhat arbitrary field chosen for age restriction unit tests. Must be
added to db before the framework is cached
58: $dbh->do("update marc_subfield_structure set
kohafield='biblioitems.agerestriction' where tagfield='521' and
tagsubfield='a'");
...
509: my ( $ageres_tagid, $ageres_subfieldid ) = GetMarcFromKohaField(
"biblioitems.agerestriction" );
510: $record->append_fields(  MARC::Field->new($ageres_tagid, '', '',
$ageres_subfieldid => 'PEGI 16')  );

(In reply to Marcel de Rooy from comment #5)
> There is already an use_ok in the Reserves test.
> If you add another use, maybe change use_ok to require_ok ?
> Did the same somewhere else..
I squashed this into the first patch. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

Lari Taskula  changed:

   What|Removed |Added

  Attachment #57096|0   |1
is obsolete||

--- Comment #9 from Lari Taskula  ---
Created attachment 57129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57129=edit
Bug 17539: Fix failing Reserves.t tests if category enrolmentfee > 0

To test:
1. Set patron category "S" with enrolmentfee 1
2. perl t/db_dependent/Reserves.t
3. Observe following errors:

not ok 59 - Bug 14464 - No fines at beginning
ok 60 - Bug 14464 - 1st reserve correctly created
ok 61 - Bug 14968 - Keep found column from reserve
not ok 62 - Bug 14464 - No fines after cancelling reserve with no charge
configured
ok 63 - Bug 14464 - 2nd reserve correctly created
not ok 64 - Bug 14464 - No fines after cancelling reserve with no charge
desired
ok 65 - Bug 14464 - 1st reserve correctly created
not ok 66 - Bug 14464 - Fine applied after cancelling reserve with charge
desired and configured

4. Apply patch
5. perl t/db_dependent/Reserves.t
6. Observe test pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

Lari Taskula  changed:

   What|Removed |Added

  Attachment #57095|0   |1
is obsolete||

--- Comment #8 from Lari Taskula  ---
Created attachment 57128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57128=edit
Bug 17539: Fix Already in a transaction error

perl t/db_dependent/Reserves.t

1..72
ok 1 - use C4::Reserves;
ok 2 - CheckReserves Test 1
...
ok 52 - Reserve in waiting status cant be canceled
ok 53 - Reserving an ageRestricted Biblio without a borrower dateofbirth
succeeds
DBD::mysql::db begin_work failed: Already in a transaction at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489.
DBD::mysql::db begin_work failed: Already in a transaction at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489.
at /usr/share/perl5/DBIx/Class/Schema.pm line 1080.
...
Koha::Object::store('Koha::Patron=HASH(0x9e43b20)') called at
/home/ubuntu/kohaclone/C4/Members.pm line 542
C4::Members::ModMember('borrowernumber', 658535, 'dateofbirth', '2001-11-02')
called at t/db_dependent/Reserves.t line 516

This patch fixes this issue by replacing dbh autocommit=0 with
txn_begin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

Lari Taskula  changed:

   What|Removed |Added

  Attachment #57094|0   |1
is obsolete||

--- Comment #7 from Lari Taskula  ---
Created attachment 57127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57127=edit
Bug 17539: Fix Undefined subroutine ::Circulation::GetItem error

perl t/db_dependent/Reserves.t

1..72
ok 1 - use C4::Reserves;
ok 2 - CheckReserves Test 1
ok 3 - CheckReserves() include reserve_id in its response
ok 4 - CheckReserves Test 2
ok 5 - CheckReserves Test 3
ok 6 - GetReservesControlBranch returns item home branch when set to
ItemHomeLibrary
ok 7 - GetReservesControlBranch returns patron home branch when set to
PatronLibrary
ok 8 - Item is correctly waiting
ok 9 - Item is correctly priority 1
ok 10 - Item is correctly priority 2
ok 11 - GetWaiting got only the waiting reserve
ok 12 - GetWaiting got the reserve for the correct borrower
Undefined subroutine ::Circulation::GetItem called at
/home/ubuntu/kohaclone/C4/Circulation.pm line 1853.

This patch fixes this error. The solution was to use C4::Reserves before
C4::Items.
Also due to this edit, change use_ok to require_ok

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726

Josef Moravec  changed:

   What|Removed |Added

 Status|BLOCKED |Patch doesn't apply

--- Comment #8 from Josef Moravec  ---
Bug 13323 is in master, could you rebase now?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17493] Improve OAI Server tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17493

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17493] Improve OAI Server tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17493

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17493] Improve OAI Server tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17493

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56843|0   |1
is obsolete||

--- Comment #5 from Josef Moravec  ---
Created attachment 57126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57126=edit
[SIGNED-OFF] Bug 17493 Improve OAI Server tests

Add several tests for OAI Servers.

TEST PLAN:

- Check that after aplying this patch, this still works:

  prove -v t/db_dependent/OAI/Server.t

- Read the test to see what has been added:

  - Testing process simplification
  - ListIdentifiers verb with resumption token, until the whole catalog
is harvested
  - ListRecords verb with resumption token, until the whole catalog is
harvested
  - Returned metadata returned is tested, marcxml & oai_dc

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #57124|0   |1
is obsolete||

--- Comment #38 from Kyle M Hall  ---
Created attachment 57125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57125=edit
Bug 15503 [QA Followup] - Set itype and ccode properly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #57123|0   |1
is obsolete||

--- Comment #37 from Kyle M Hall  ---
Created attachment 57124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57124=edit
Bug 15503 [QA Followup] - Incoming itype doesn't set pulldown value properly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #36 from Kyle M Hall  ---
Created attachment 57123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57123=edit
Bug 15503 [QA Followup] - Incoming itype doesn't set pulldown value properly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17521] Step 3 of patron modification editor not checking age limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521

--- Comment #4 from Lucio Moraes  ---
Created attachment 57122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57122=edit
Bug 17521: Added missing age limit check

Following patron modification partial editor had no age constraint
checking:
/cgi-bin/koha/members/memberentry.pl?op=modify=3=3

Test plan:
1) Apply the patch
2) Open profile of a patron
3) Click Edit under "Library use": http://prntscr.com/d1ghim
4) Change category to an invalid one (eg. Adult instead of Kid)
5) Error saying "Patron's age is incorrect for their category." should
be displayed.

Signed-off-by: Josef Moravec 
Signed-off-by: Lucio Moraes 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17521] Step 3 of patron modification editor not checking age limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57011|0   |1
is obsolete||

--- Comment #3 from Josef Moravec  ---
Created attachment 57121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57121=edit
[SIGNED-OFF] Bug 17521: Added missing age limit check

Following patron modification partial editor had no age constraint
checking:
/cgi-bin/koha/members/memberentry.pl?op=modify=3=3

Test plan:
1) Apply the patch
2) Open profile of a patron
3) Click Edit under "Library use": http://prntscr.com/d1ghim
4) Change category to an invalid one (eg. Adult instead of Kid)
5) Error saying "Patron's age is incorrect for their category." should
be displayed.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17521] Step 3 of patron modification editor not checking age limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14169] Item Search csv export

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14169

Josef Moravec  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||josef.mora...@gmail.com
 Resolution|--- |INVALID

--- Comment #7 from Josef Moravec  ---
For Excel its's probably better to set the CSV separator to semicolons - set
system preference  delimiter and choose the semicolons also in CSV profiles, if
you are using them...

I am closing as invalid, as it's rather on Excel side than Koha side...

Feel free to reopen it, if you have an idea what we could do on Koha side.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com
   |ity.org |
Version|unspecified |master

--- Comment #2 from Josef Moravec  ---
I 've tried a quick patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

--- Comment #1 from Josef Moravec  ---
Created attachment 57120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57120=edit
Bug 16914: Insert end of line in CSV export of item search in translated
templates

Test plan:
0) Do not apply the patch
1) Install any translation
2) Go to item search and choose Output to be CSV
3) Search for at least 2 items in result set, open CSV in text editor
-> in english, everything is ok
-> in other languages are all data on one line
4) Apply the patch
5) Repeat steps 2 and 3, CSV should look OK either in english and other
languages

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16808] Serial claims: claiming via CSV export doesn't reload the page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #5 from Josef Moravec  ---
We could change the vendor selecting form method from post to get - it should
allow to avoid this message...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7029] searching : fuzzy et steming

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7029

--- Comment #4 from Fridolin SOMERS  ---
(In reply to Marjorie Barry-Vila from comment #3)
> Hi,
> I have the same problem with 3.22.
> 
> an idea of the problem with research in french?
> 
> 
> Regards,
> 
> 
> MArjorie

There may be a problem with syspref translation.
Can you test unsing non-translated Koha (english) ?

Regards,

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7029] searching : fuzzy et steming

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7029

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7029] searching : fuzzy et steming

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7029

Fridolin SOMERS  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7029] searching : fuzzy et steming

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7029

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
   Assignee|adrien.sau...@biblibre.com  |fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #31 from Josef Moravec  ---
It really needed rebasing again. Done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56646|0   |1
is obsolete||

--- Comment #28 from Josef Moravec  ---
Created attachment 57117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57117=edit
Bug 14957: Correct parameters for TransformMarcToKoha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56645|0   |1
is obsolete||

--- Comment #27 from Josef Moravec  ---
Created attachment 57116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57116=edit
Bug 14957: Rule based permission for MARC fields

This patch adds a rule based permission system for MARC field modifications.

Test plan:
1. Apply this patch
2. Apply related database patch
2. Apply related scripts update patch
3. Run updatedatabase.pl
5. Log in to staff client
4. Enable new syspref MARCPermissions
5. You should see a new link "MARC field permissions" in the "Catalog"
   section under "Koha administrtion".
6. Go to the "MARC field permissions" page
7. Next to the page heading ("Manage MARC field permissions") there is a
   button with a question mark, click this for more information about the
   rule system.
8. Add desired rules to the rule table, press the +-button to add.
9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
10. Clicking the x-icon should remove corresponding rule after
confirmation.
11. Selecting one or more rules followed by clicking the trash-icon
should remove all selected rules after confirmation.
12. To test your rules, import or in other way modify a record.
13. Check that the record was modified as defined by your rules.

Sponsored-by: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56647|0   |1
is obsolete||

--- Comment #29 from Josef Moravec  ---
Created attachment 57118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57118=edit
Bug 14957: Key fixes to patch

- Fixing merge conflicts
- adding String::Similariry to list of dependencies
- font-awesome icons and adding consistency to formatting
- removing original use of onclick
- moving help text out of main page and into a new help file

When testing, follow above test plan but:
1) Remember to install String::Similarity before testing (apt-get
install libstring-similarity-perl)
2) Instead of doing step 7, click Help in top-right corner instead.
Confirm this works and shows as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56648|0   |1
is obsolete||

--- Comment #30 from Josef Moravec  ---
Created attachment 57119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57119=edit
Bug 14957: Followup - Pod, import_lexile.pl, template and test fixes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56643|0   |1
is obsolete||

--- Comment #25 from Josef Moravec  ---
Created attachment 57114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57114=edit
Bug 14957: Database changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56644|0   |1
is obsolete||

--- Comment #26 from Josef Moravec  ---
Created attachment 57115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57115=edit
Bug 14957: Add filters to relevant scripts

Add MARCPermissions filters in scripts which modifies MARC records to enable
the
permission system for these scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17543] New: Update German web installer sample files for 16.11

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17543

Bug ID: 17543
   Summary: Update German web installer sample files for 16.11
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr, mi...@abunchofthings.net,
ve...@veron.ch

The same procedure as every year... we have to update SQL sample files with
translations for new notices etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/