[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #6 from Jonathan Druart --- Created attachment 57295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57295&action=edit Bug 17569: Do not limit by branch if option is not passed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #5 from Jonathan Druart --- Created attachment 57294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57294&action=edit Bug 17569: Remove C4::Members::GetUpcomingMembershipExpires -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #7 from Jonathan Druart --- Fixed Josef, thanks for testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn' t work with MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 --- Comment #18 from Fridolin SOMERS --- (In reply to David Cook from comment #16) > (In reply to Fridolin SOMERS from comment #15) > > Wahou, dirty bug. > > In my opinion, its not an enhancement : matching checks are broken. > > Do you mean that it's a bug fix rather than an enhancement? Yes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17576] Add HSBND_FREQ authorised value to translated installer sample files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17576 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |alex.sassmannshausen@ptfs-e |ity.org |urope.com Severity|minor |normal --- Comment #1 from Jonathan Druart --- This need to be fixed before the next release. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Sent notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Matthias Meusburger changed: What|Removed |Added Attachment #45477|0 |1 is obsolete|| --- Comment #54 from Matthias Meusburger --- Created attachment 57296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57296&action=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. The _update_message_to_address becomes useless since the to_address is retrieved previously. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Sent notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Matthias Meusburger changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17431] Fix failing test t/db_dependent/api/v1/holds.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17431
--- Comment #17 from Jonathan Druart
---
(In reply to Lari Taskula from comment #12)
> I'm not completely sure why changing the order of "use" in the test fixes
> some issues like being unable to call GetItem in C4::Reserves. That seemed
> to be the issue for returning 500 in POST /api/v1/holds. I came across with
> similar issue in Reserves.t. Does the fix make sense and can somebody
> explain what's going on?
I really would like to understand what's happening here, there is something
hidden we need to catch.
Just a thought:
diff --git a/Koha/REST/V1/Hold.pm b/Koha/REST/V1/Hold.pm
index 7f0b1ff..ae1cd4d 100644
--- a/Koha/REST/V1/Hold.pm
+++ b/Koha/REST/V1/Hold.pm
@@ -77,6 +77,7 @@ sub add {
my $biblio = C4::Biblio::GetBiblio($biblionumber);
+warn $can_reserve;
my $can_reserve =
$itemnumber
? CanItemBeReserved( $borrowernumber, $itemnumber )
Make the tests fail again.
I also see the following warning (several):
item-level_itypes set but no itemtype set for item (1064) at
/home/vagrant/kohaclone/Koha/Schema/Result/Item.pm line 698.
when the tests pass, but not when they fail.
Could someone else have a look and try to understand what's happened here?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #14 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17376] rebuild_zebra.pl in daemon mode no database access kills the process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17376 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #8 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16935] launch export_records.pl with deleted_barcodes param fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16935 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17417] Correct invalid markup around news on the staff client home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #7 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17434] Moremember displaying primary and secondary phone number twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #7 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17431] Fix failing test t/db_dependent/api/v1/holds.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17431 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #18 from Martin Renvoize --- I'm generally not a big fan of bare 'use' statements for this exact reason. It's generally good practice to state which routines your wanting to import.. an order change like this feels like a sub is getting redefined silently and so it's likely stuff will just start randomly failing again further down the line. Could we work out where the actual issue lies and either specify the imports so we're clear about exactly which routine from where we're testing or rename the routine to be unique across the codebase to remove ambiguity? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] New: Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Bug ID: 17578 Summary: Replace GetMemberDetails with GetMember Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org In order to unify the different subroutine of C4::Members and move them to Koha::Patrons, one of the steps is to remove GetMemberDetails. Here we will replace all occurrences of GetMemberDetails with GetMember. Additional informations will be retrieved when needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17579] New: Add the Koha::Patron->is_expired method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Bug ID: 17579 Summary: Add the Koha::Patron->is_expired method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4880] koha-remove sometimes fails because user is logged in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4880 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #16 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What|Removed |Added Depends on||17578 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 [Bug 17578] Replace GetMemberDetails with GetMember -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17579] Add the Koha::Patron->is_expired method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Jonathan Druart changed: What|Removed |Added Blocks||17578 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 [Bug 17578] Replace GetMemberDetails with GetMember -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart changed: What|Removed |Added Blocks||16846 Depends on||17579 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 [Bug 17579] Add the Koha::Patron->is_expired method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17504] Installer shows PostgreSQL info when wrong DB permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17504 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17518] Displayed language name for Czech is wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17518 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #10 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17579] Add the Koha::Patron->is_expired method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 --- Comment #1 from Jonathan Druart --- Created attachment 57297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57297&action=edit Bug 17579: Add the Koha::Patron->is_expired This new method will be handy for further uses Test plan: prove t/db_dependent/Koha/Patrons.t should return green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17579] Add the Koha::Patron->is_expired method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Koha Team Lyon 3 changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Koha Team Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 --- Created attachment 57298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57298&action=edit Bug 17470 Make overdue notices according to branch item only As a test plan I redirect you to the steps described by Theodoros : 1) do these steps 2) apply the patch 3) redo them. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #2 from Jonathan Druart --- Created attachment 57300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57300&action=edit Bug 17578: GetMemberDetails - Remove BlockExpiredPatronOpacActions The correct way to get the value of BlockExpiredPatronOpacActions from a patron object is to get the patron category then call the effective_BlockExpiredPatronOpacActions: $patron->category->effective_BlockExpiredPatronOpacActions So this patch applies this change and remove this value from the GetMemberDetails subroutine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #3 from Jonathan Druart --- Created attachment 57301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57301&action=edit Bug 17578: GetMemberDetails - Remove authflags - 2 This script is not used from the Koha codebase and does not seem very useful. We could rewrite it if needed later (ie. if someone complains I will rewrite it). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #1 from Jonathan Druart --- Created attachment 57299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57299&action=edit Bug 17578: GetMemberDetails - Add Koha::Patron::Category->effective_BlockExpiredPatronOpacActions This patch simply adds a new method to retrieve the correct value of BlockExpiredPatronOpacActions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #4 from Jonathan Druart --- Created attachment 57302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57302&action=edit Bug 17578: GetMemberDetails - Remove authflags - 1 GetMemberDetails create a authflags key, but this key is only used from 2 different places. One is a very simple script, which does not seem very usefull C4/SIP/interactive_members_dump.pl. I propose to simply remove it. The other one is the member-flags.pl script. What is done in this one is a bit weird since we a doing twice the same query (it was not highlighted before this patch). We will need to fix that later. At the moment the goal it to remove the GetMemberDetails subroutine without introducing any regressions (and so without adding big changes) Test plan: Select/unselect permissions for a patron, save and edit again. The behavior of the permission checkboxes should be ok -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #5 from Jonathan Druart --- Created attachment 57303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57303&action=edit Bug 17578: GetMemberDetails - Remove amountoutstanding The amountoutstanding value set by GetMemberDetails was only used in a few places. In that case it makes sense to only retrieve it when needed. Test plan: 1/ Add fines to a patron, on the OPAC patron info page, you should see a "Fines" tab 2/ Add credit to a patron, you should see the credit displayed 3/ Set the pref maxoutstanding to 3 4/ Add a fine of 4 to a patron 5/ Try to place an hold for this patron => You should get a "too much oweing" message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #8 from Jonathan Druart --- Created attachment 57306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57306&action=edit Bug 17578: GetMemberDetails - Remove reservefee Same as other patches, reservefee is only used in opac-reserve.pl Test plan; Set reserve fee for a patron category Place a hold at the OPAC with one of these patrons. You must get a message about the reserve fee. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #6 from Jonathan Druart --- Created attachment 57304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57304&action=edit Bug 17578: GetMemberDetails - Remove flags Same as authflags, a flags key is set containing all the patron flags. It is only used in a few places and it's better to call C4::Members::patronflags when we need it. Test plan: Look at the diff and confirm that the change make sense Use git grep to confirm we do not use the flags somewhere else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #7 from Jonathan Druart --- Created attachment 57305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57305&action=edit Bug 17578: GetMemberDetails - Remove is_expired The is_expired value is used in 2 places, let's use Koha::Patron->is_expired instead. Test plan: Depending on the different value of BlockExpiredPatronOpacActions for the patron category, a patron must be blocked if he has expired. Confirm that behavior from opac-renew and opac-reserve scripts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #9 from Jonathan Druart --- Created attachment 57307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57307&action=edit Bug 17578: GetMemberDetails - Remove enrolmentperiod This value is not used anywhere Test plan: git grep enrolmentperiod| grep -v installer| grep -v translator|vim - should show you that I am right -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #10 from Jonathan Druart --- Created attachment 57308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57308&action=edit Bug 17578: GetMemberDetails - Remove GetMemberDetails All the values different from the ones GetMember returned has been managed outside of GetMemberDetails. It looks safe to replace all the occurrences of GetMemberDetails with GetMember. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 --- Comment #12 from Josef Moravec --- Thanks for rebasing! I started to test and here are first comments When receiving shipment (script parcel.pl) I got this error: "The method listinct is not covered by tests!" In tests: t/db_dependent/Bookseller.t fails with Can't locate object method "new" via package "Koha::Acquisition::Bookseller::Contact" (perhaps you forgot to load "Koha::Acquisition::Bookseller::Contact"?) at t/db_dependent/Bookseller.t line 686. t/db_dependent/Contract.t fails with Can't locate object method "new" via package "Koha::Acquisition::Bookseller" (perhaps you forgot to load "Koha::Acquisition::Bookseller"?) at t/db_dependent/Contract.t line 42. t/db_dependent/Letters.t fails with "my" variable $bookseller masks earlier declaration in same scope at t/db_dependent/Letters.t line 418. and Can't locate object method "new" via package "Koha::Acquisition::Bookseller::Contact" (perhaps you forgot to load "Koha::Acquisition::Bookseller::Contact"?) at t/db_dependent/Letters.t line 379. All other Acquisition test are passing - I am testing on top of 17562, 17563 and 17564 I tried all related (I hope) tests, and in ui I tested Vendor, Contracts, Baskets adding to order, and so on... I will continue after the error in parcel.pl will be fixed, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17580] New: Add the Koha::Patron->get_overdues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Bug ID: 17580 Summary: Add the Koha::Patron->get_overdues method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 --- Comment #1 from Jonathan Druart --- Created attachment 57309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57309&action=edit Bug 17580: Add the Koha::Patron->get_overdues method This method will be used by several patches later. Test plan: prove t/db_dependent/Koha/Patrons.t should return green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7029] searching : fuzzy et steming
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7029 --- Comment #7 from Marjorie Barry-Vila --- Created attachment 57310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57310&action=edit searchingtab_syspref Hi Fridolin, Here is a screenshot for sys pref. Regards, Marjorie -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 --- Comment #13 from Josef Moravec --- koha-qa comments: FAIL Koha/Acquisition/Bookseller/Contact.pm FAIL forbidden patterns forbidden pattern: Warning: The 'sub type' may be wrong is declared in a Koha::* package (see bug 15446) (line 9) FAIL Koha/Acquisition/Bookseller/Contacts.pm FAIL forbidden patterns forbidden pattern: Warning: The 'sub type' may be wrong is declared in a Koha::* package (see bug 15446) (line 9) FAIL t/db_dependent/Letters.t FAIL valid "my" variable $bookseller masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Jonathan Druart changed: What|Removed |Added Blocks||17580 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 [Bug 17580] Add the Koha::Patron->get_overdues method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Jonathan Druart changed: What|Removed |Added Depends on||16966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 [Bug 16966] Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Jonathan Druart changed: What|Removed |Added Attachment #57309|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 57311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57311&action=edit Bug 17580: Add the Koha::Patron->get_overdues method This method will be used by several patches later. Test plan: prove t/db_dependent/Koha/Patrons.t should return green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17581] New: Have possibility to edit due date to avoid to do a renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17581 Bug ID: 17581 Summary: Have possibility to edit due date to avoid to do a renewal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: marjorie.barry-v...@ccsr.qc.ca QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Hi, It would be fine to have possibility to edit due date for a loan in progress to avoid to do a renewal. Only for staff. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 --- Comment #7 from Jonathan Druart --- Created attachment 57313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57313&action=edit Bug 17553: Remove existing tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 Jonathan Druart changed: What|Removed |Added Attachment #57203|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 57312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57312&action=edit Bug 17553: Koha::Patron->get_overdues This patch is for discussion: As you can see it introduces a weird Koha::Object->unblessed_all_relateds subroutine. The idea is to fix a lack we will have soon: A lot of subroutines retrieves data from several tables and put them into a hashref. It's convenient for the use we have here: Send everything to a subroutine to generate a letter. The problem is that I did not find a good and elegant way to do that using DBIX::Class. This new method loops through all the "related resultsets" which are the prefetched tables. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 Jonathan Druart changed: What|Removed |Added Depends on|16966 |17580 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 [Bug 16966] Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 [Bug 17580] Add the Koha::Patron->get_overdues method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Jonathan Druart changed: What|Removed |Added Blocks|17553 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 [Bug 17553] Move GetOverduesForPatron to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Jonathan Druart changed: What|Removed |Added Blocks||17553 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 [Bug 17553] Move GetOverduesForPatron to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 --- Comment #8 from Jonathan Druart --- (nothing changed here, I have just moved the get_overdues method to its own bug) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Jonathan Druart changed: What|Removed |Added Attachment #57311|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 57314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57314&action=edit Bug 17580: Add the Koha::Patron->get_overdues method This method will be used by several patches later. Test plan: prove t/db_dependent/Koha/Patrons.t should return green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #11 from Josef Moravec --- Created attachment 57318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57318&action=edit [SIGNED-OFF] Bug 17569: Remove C4::Members::GetUpcomingMembershipExpires Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Josef Moravec changed: What|Removed |Added Attachment #57265|0 |1 is obsolete|| Attachment #57266|0 |1 is obsolete|| Attachment #57267|0 |1 is obsolete|| Attachment #57294|0 |1 is obsolete|| Attachment #57295|0 |1 is obsolete|| --- Comment #8 from Josef Moravec --- Created attachment 57315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57315&action=edit [SIGNED-OFF] Bug 17569: Rewrite existing tests to make them reusable and more robust In order not to cheat you, I am rewriting the tests in a separate commit. You can confirm that they pass with the other patches. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #9 from Josef Moravec --- Created attachment 57316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57316&action=edit [SIGNED-OFF] Bug 17569: Move tests to the patron module test file Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #10 from Josef Moravec --- Created attachment 57317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57317&action=edit [SIGNED-OFF] Bug 17569: Koha::Patrons - Move GetUpcomingMembershipExpires to search_upcoming_membership_expires This patchset moves the C4::Members::GetUpcomingMembershipExpires subroutine code to the Koha::Patrons->search_upcoming_membership_expires method. This subroutine was used from only 1 place, so it's an easier to move. Test plan: Use the membership_expiry.pl cronjob script using the different options. The behavior should be the same as prior to this patch. prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #12 from Josef Moravec --- Created attachment 57319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57319&action=edit [SIGNED-OFF] Bug 17569: Do not limit by branch if option is not passed Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17579] Add the Koha::Patron->is_expired method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17579] Add the Koha::Patron->is_expired method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Josef Moravec changed: What|Removed |Added Attachment #57297|0 |1 is obsolete|| --- Comment #2 from Josef Moravec --- Created attachment 57320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57320&action=edit [SIGNED-OFF] Bug 17579: Add the Koha::Patron->is_expired This new method will be handy for further uses Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2619] Turning on XSLTResultsDisplay preference turns off item detail display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2619 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #3 from Tomás Cohen Arazi --- Is this still valid? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578
Josef Moravec changed:
What|Removed |Added
CC||josef.mora...@gmail.com
--- Comment #11 from Josef Moravec ---
When I go to circulation -> checking out, or to permission settings of patron I
get:
Can't use string ("19") as a HASH ref while "strict refs" in use at
/home/vagrant/kohaclone/C4/Members.pm line 194
19 is borrowernumber of my patron
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826
Lari Taskula changed:
What|Removed |Added
Attachment #57271|0 |1
is obsolete||
--- Comment #27 from Lari Taskula ---
Created attachment 57321
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57321&action=edit
Bug 16826: Add API route for getting item availability
GET /availability/items?itemnumber=123
GET /availability/items?itemnumber=123+456+789
GET /availability/items?biblionumber=321
GET /availability/items?biblionumber=321+654+987
This patch adds above routes for checking anonymous item availability. Patron
status is not checked.
The returned data is for example:
{
"checkout": {
"available": false,
"description": ["onloan"],
"expected_available": "2016-07-13"
},
"hold": {
"available": true,
"description": [],
"expected_available": null
},
"local_use": {
"available": false,
"description": ["onloan"],
"expected_available": "2016-07-13"
},
"onsite_checkout": {
"available": false,
"description": ["onsite_checkouts_disabled"],
"expected_available": null
},
"hold_queue_length": 1,
+ some basic item information on locations, bib/bib(item)numbers etc.
}
Possible values in availability description are an empty array and any of:
"onloan", "reserved", "damaged", "withdrawn", "itemlost", "restricted",
"notforloan", "ordered". (+"onsite_checkouts_disabled" for onsite_checkout)
To test:
1. Apply patch
2. Play around with an item. Place a hold on it, checkout, set it damaged etc.
3. Make GET requests to /api/v1/availability/items?itemnumber=YYY, where
YYY is an existing itemnumber. You can also try with biblionumber=XXX
query parameter, where XXX is an existing biblionumber.
4. Check that the availability statuses are correct and that availability
description lists the appropriate status for unavailability.
5. Repeat steps 2-4 until you are confident the route works as expected.
6. Run the following tests:
- t/Koha/Item/Availability.t
- t/db_dependent/Items.t
- t/db_dependent/api/v1/availability.t
Signed-off-by: Jiri Kozlovsky
Fixed a bug in finding existing holds. Added some more tests to cover it.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart changed: What|Removed |Added Attachment #57304|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 57322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57322&action=edit Bug 17578: GetMemberDetails - Remove flags Same as authflags, a flags key is set containing all the patron flags. It is only used in a few places and it's better to call C4::Members::patronflags when we need it. Test plan: Look at the diff and confirm that the change make sense Use git grep to confirm we do not use the flags somewhere else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart changed: What|Removed |Added Attachment #57307|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Created attachment 57325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57325&action=edit Bug 17578: GetMemberDetails - Remove enrolmentperiod This value is not used anywhere Test plan: git grep enrolmentperiod| grep -v installer| grep -v translator|vim - should show you that I am right -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart changed: What|Removed |Added Attachment #57306|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 57324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57324&action=edit Bug 17578: GetMemberDetails - Remove reservefee Same as other patches, reservefee is only used in opac-reserve.pl Test plan; Set reserve fee for a patron category Place a hold at the OPAC with one of these patrons. You must get a message about the reserve fee. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart changed: What|Removed |Added Attachment #57308|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart --- Created attachment 57326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57326&action=edit Bug 17578: GetMemberDetails - Remove GetMemberDetails All the values different from the ones GetMember returned has been managed outside of GetMemberDetails. It looks safe to replace all the occurrences of GetMemberDetails with GetMember. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart changed: What|Removed |Added Attachment #57305|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart --- Created attachment 57323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57323&action=edit Bug 17578: GetMemberDetails - Remove is_expired The is_expired value is used in 2 places, let's use Koha::Patron->is_expired instead. Test plan: Depending on the different value of BlockExpiredPatronOpacActions for the patron category, a patron must be blocked if he has expired. Confirm that behavior from opac-renew and opac-reserve scripts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17576] Add HSBND_FREQ authorised value to translated installer sample files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17576 --- Comment #2 from Alex Sassmannshausen --- Created attachment 57327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57327&action=edit Bug 17576: Add housebound mandatory auth_values. * installer/data/mysql/de-DE/mandatory/auth_values.sql: Add values. * installer/data/mysql/es-ES/mandatory/auth_values.sql: Add values. * installer/data/mysql/fr-CA/obligatoire/auth_values.sql: Add values. * installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql: Add values. * installer/data/mysql/it-IT/necessari/auth_val.sql: Add values. * installer/data/mysql/nb-NO/1-Obligatorisk/auth_values.sql: New file. * installer/data/mysql/pl-PL/mandatory/auth_values.sql: New file. * installer/data/mysql/ru-RU/mandatory/auth_values.sql: New file. * installer/data/mysql/uk-UA/mandatory/auth_values.sql: New file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17576] Add HSBND_FREQ authorised value to translated installer sample files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17576 --- Comment #3 from Alex Sassmannshausen --- The added patch adds HSBND_FREQ to the other mandatory sql folders. I'm not 100% au fait with how the other translations work — so please let me know if you think I made a mistake! Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17576] Add HSBND_FREQ authorised value to translated installer sample files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17576 Alex Sassmannshausen changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #73 from Jonathan Druart --- Katrin, could you have a look, it seems that the tests are failing now -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #14 from Jonathan Druart --- Hi Josef, Yes it seems that the Contact code need a lot of work to be adapted. I give up for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17582] New: Cannot edit an authority framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17582 Bug ID: 17582 Summary: Cannot edit an authority framework Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Template process failed: undef error - The method value is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type [s] - part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 Jonathan Druart changed: What|Removed |Added Blocks||17582 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17582 [Bug 17582] Cannot edit an authority framework -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17582] Cannot edit an authority framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17582 Jonathan Druart changed: What|Removed |Added Depends on||15381 --- Comment #1 from Jonathan Druart --- Seems to be related to bug 15381 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17582] Cannot edit an authority framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17582 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17582] Cannot edit an authority framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17582 --- Comment #2 from Jonathan Druart --- Created attachment 57328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57328&action=edit Bug 17582: Fix authority framework edition Step to recreate: Admin>Authority types > Actions > Marc structure Test plan Confirm that this patch fixes the issue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17582] Cannot edit an authority framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17582 Jonathan Druart changed: What|Removed |Added Component|Architecture, internals,|System Administration |and plumbing| CC||gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17579] Add the Koha::Patron->is_expired method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Jonathan Druart changed: What|Removed |Added Blocks||17583 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 [Bug 17583] Use Koha::Patron->is_expired from circulation.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #74 from Katrin Fischer --- Which tests does it break? t/db_dependent/Letters.t? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17583] New: Use Koha::Patron->is_expired from circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Bug ID: 17583 Summary: Use Koha::Patron->is_expired from circulation.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 17579 Bug 17579 introduces a Koha::Patron->is_expired method. We should use it from the circulation page Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 [Bug 17579] Add the Koha::Patron->is_expired method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #2 from Jonathan Druart --- Created attachment 57330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57330&action=edit Bug 17583: Add the Koha::Patron->is_going_to_expired method In order to be consistent, we need to create this method as well. Test plan: Make sure the pref NotifyBorrowerDeparture works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #1 from Jonathan Druart --- Created attachment 57329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57329&action=edit Bug 17583: Use Koha::Patron->is_expired from the circulation page Bug 17579 introduces a Koha::Patron->is_expired method. Let's use it from this script. Test plan: Confirm that you see the message on the interface from the circulation page for an expired patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17584] New: Add the Koha::Patron->get_issues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Bug ID: 17584 Summary: Add the Koha::Patron->get_issues method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Jonathan Druart changed: What|Removed |Added Depends on||17580 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 [Bug 17580] Add the Koha::Patron->get_overdues method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Jonathan Druart changed: What|Removed |Added Blocks||17584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 [Bug 17584] Add the Koha::Patron->get_issues method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #75 from Jonathan Druart --- (In reply to Katrin Fischer from comment #74) > Which tests does it break? t/db_dependent/Letters.t? Yes. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 --- Comment #1 from Jonathan Druart --- Created attachment 57331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57331&action=edit Bug 17584: Add the Koha::Patron->get_issues method Test plan: prove t/db_dependent/Koha/Patrons.t should return green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #76 from Katrin Fischer --- Ok, I will try... :( -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17585] New: Add the Koha::Patron->get_account_lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Bug ID: 17585 Summary: Add the Koha::Patron->get_account_lines method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17586] New: Add the Koha::Account::Lines->get_balance method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Bug ID: 17586 Summary: Add the Koha::Account::Lines->get_balance method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 --- Comment #2 from Theodoros Theodoropoulos --- Thank you Olivier for the patch! I can verify that the patch works as expected for 3.20 and master. Having said that, I leave it as 'Needs Signoff'. Maybe @Kyle or someone from QA team could/should sign it off? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17587] New: Remove itemtype-related IsItemIssued.t warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17587 Bug ID: 17587 Summary: Remove itemtype-related IsItemIssued.t warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: tomasco...@gmail.com QA Contact: gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17587] Remove itemtype-related IsItemIssued.t warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17587 Tomás Cohen Arazi changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com Depends on||14598 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi changed: What|Removed |Added Blocks||17587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17587 [Bug 17587] Remove itemtype-related IsItemIssued.t warnings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
