[Koha-bugs] [Bug 17686] New: library catalogue titles not appearing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17686

Bug ID: 17686
   Summary: library catalogue titles not appearing
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: PC
OS: Windows
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Websites, Mailing Lists, etc
  Assignee: wizzy...@gmail.com
  Reporter: billiele...@gmail.com
QA Contact: testo...@bugs.koha-community.org

search results show lists of items without any titlesoptions of place a
hold, add to lists, add to cart appear below blank space where title would
appear.

doubt it's my computer as other websites working fine and this is new
development, has always worked in past.

thanks in advance for your help/reply, billie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16639] Split item data from description in Fines tab into separate columns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16639

Jamsheer N P  changed:

   What|Removed |Added

 CC||jamsheer...@gmail.com

--- Comment #1 from Jamsheer N P  ---
It is very difficult to pay fine of a particular book without barcode number.
One have to physically verify the barcode with title of the book, especially
when the titles are entered in multiple languages. As Theodoros Theodoropoulos
adding a separate column for barcode is highly recommended.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13552] Add debar option to batch patron modification

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552

Jamsheer N P  changed:

   What|Removed |Added

 CC||jamsheer...@gmail.com

--- Comment #2 from Jamsheer N P  ---
In academic libraries students patrons discharge together as a batch. The
option to discharge patron in "Batch patrons modification" under tools would
make it easy.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12144] Book drop mode mode erasing fine when CalculateFinesOnReturn is enabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12144

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17685] Allow to receive double issues in serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17685

Radek Šiman (R-Bit Technology, s.r.o.)  changed:

   What|Removed |Added

 CC||blac...@gmail.com,
   ||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17685] New: Allow to receive double issues in serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17685

Bug ID: 17685
   Summary: Allow to receive double issues in serials
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: r...@rbit.cz
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

Sometimes we need to receive double issues of serials. In fact it results in a
changed numbering of the first issue from "10/2016" to "10-11/2016". The other
issue "11/2016" should get "not available" status.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17679] C4::Circulation - Remove unused GetItemIssues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||josef.mora...@gmail.com

--- Comment #2 from Josef Moravec  ---
I totally agree with removing this part of code.

Just few comments:

qa tool is saying this:

 FAIL   catalogue/issuehistory.pl
   FAIL   valid
"my" variable $biblio masks earlier declaration in same scope



also in the copied part of issuhistory.pl, line 53:

my $total  = scalar @$issues;

but $total is not used and the number of issues is passed to template by this
lines:

$template->param(
total=> scalar @$issues,
...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

--- Comment #63 from Josef Moravec  ---
Rebased on master

> > - Split buttons wrapping badly on saved reports page and serials search
> > results
> 
> It's not as easy as it could looks like... I tried solution from here:
> https://github.com/twbs/bootstrap/issues/9939, another possibility is using
> flex, if we decide we can adapt it, see http://caniuse.com/#search=flexbox
> for browser support. 
> 

I added more specifity for the split button style just to affect only the
buttons in tables, not other (like in toolbars for example)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17684] New: add floating table header on acqui-home.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17684

Bug ID: 17684
   Summary: add floating table header on acqui-home.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org

Hi,

When we have a lot of funds displayed on acqui-home, it would be easier if
table header was floating.

Regards,

Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57418|0   |1
is obsolete||

--- Comment #60 from Josef Moravec  ---
Created attachment 57774
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57774=edit
Bug 16239: Update css files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

--- Comment #62 from Josef Moravec  ---
Created attachment 57776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57776=edit
Bug 16239: Use inline-block for split buttons only in tables

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57417|0   |1
is obsolete||

--- Comment #59 from Josef Moravec  ---
Created attachment 57773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57773=edit
Bug 16239: Update templates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57419|0   |1
is obsolete||

--- Comment #61 from Josef Moravec  ---
Created attachment 57775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57775=edit
Bug 16239: Update javascript files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57416|0   |1
is obsolete||

--- Comment #58 from Josef Moravec  ---
Created attachment 57772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57772=edit
Bug 16239: Update Bootstrap to 3.3.7

Customization tool used.

Javascript modules:
alert
button
dropdown
modal
tooltip
popover
transition

CSS modules:
type
code
grid
tables
forms
buttons
responsive-utilities
button-groups
input-groups
navs
navbar
breadcrumbs
pagination
pager
labels
badges
thumbnails
alerts
progress-bars
media
list-group
panels
responsive-embed
close
component-animations
dropdowns
tooltip
popovers
modals

Test plan:
1) Apply the patch
2) Try to go through interface to find problems, inconsistencies, etc.
3) Read the diff

Migration guide for bootstrap: http://getbootstrap.com/migration/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17652] opac-account.pl does not include login branchcode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652

Viktor Sarge  changed:

   What|Removed |Added

 CC||viktor.sarge@regionhalland.
   ||se

--- Comment #1 from Viktor Sarge  ---
Got a fix for this but it's on a kohadevbox that I'm not really friends with
yet :) I'll see if I can get the patch up on monday. It seems to only be an
issue of removing the hardcoded line to get the correct class.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17683] OPAC_SEARCH_LIMIT no longer accepts group codes as limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17683

--- Comment #1 from Martin Renvoize  ---
We should probably make it explicit.. i.e. multibranch:search_group_code
instead of branch:search_group_code/branch_code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17683] New: OPAC_SEARCH_LIMIT no longer accepts group codes as limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17683

Bug ID: 17683
   Summary: OPAC_SEARCH_LIMIT no longer accepts group codes as
limits
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: rel_3_16_candidate
  Severity: trivial
  Priority: P4
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: git...@bugs.koha-community.org, gmcha...@gmail.com,
paul.poul...@biblibre.com
Depends on: 10798

SetEnvIf Host "opac2.your-domain.com"
OPAC_SEARCH_LIMIT=branch:search_group_code 

This worked up until recently :(


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798
[Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search groups
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search groups

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||17683


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17683
[Bug 17683] OPAC_SEARCH_LIMIT no longer accepts group codes as limits
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14396] library groups are allowed to have same codes as branches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14396

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #1 from Martin Renvoize  ---
Is this still true?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17624] Hide (some) not-for-loan items on search results' availability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17624

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #5 from Josef Moravec  ---
(In reply to Marcel de Rooy from comment #4)
> What about hiding Staff collection only?

+1 

It does make more sense to me

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682

Felix Hemme  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17682] New: Change URL for Google Scholar in OPACSearchForTitleIn

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682

Bug ID: 17682
   Summary: Change URL for Google Scholar in OPACSearchForTitleIn
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: felix.he...@thulb.uni-jena.de
QA Contact: testo...@bugs.koha-community.org

Google Scholar is no longer accessible via http://www.scholar.google.com/scholar?q={TITLE}; target="_blank">Google
Scholar. 

It should be changed to the current url https://scholar.google.com/scholar?q={TITLE}; target="_blank">Google
Scholar.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666

--- Comment #10 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #9)
> (In reply to Kyle M Hall from comment #8)
> > Jonathan, does it work for you with this patch?
> 
> Yes of course it works but in that case it's certainly better to use
> File::Slurp::read_file

File::Slurp is packaged on Debian.
It calls sysopen with O_RDONLY. So no flock.
So, it seems to be the best choice here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17624] Hide (some) not-for-loan items on search results' availability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17624

--- Comment #4 from Marcel de Rooy  ---
What about hiding Staff collection only?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17624] Hide (some) not-for-loan items on search results' availability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17624

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Hide not-for-loan items on  |Hide (some) not-for-loan
   |search results' |items on search results'
   |availability|availability

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17681] Some typos

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17681

--- Comment #1 from Marcel de Rooy  ---
Created attachment 57771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57771=edit
Bug 17681: Exiisting typos might thow some feees when recieved

Yes, we are fixing these four typos here.

Test plan:
[1] Read the changes.
[2] Run t/Auth_with_shibboleth.t
[3] Run git grep recieved| grep -v -e 'recievedlist' | grep -v -e
'serials-recieve.tt'

Note: serials-recieve.tt is just history. Bonus points for the one who makes
us get rid of that column recievedlist.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17681] Exiisting typos might thow some feees when recieved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17681

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17681] Exiisting typos might thow some feees when recieved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17681

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Some typos  |Exiisting typos might thow
   ||some feees when recieved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17681] Some typos

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17681

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17681] New: Some typos

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17681

Bug ID: 17681
   Summary: Some typos
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17677] Move C4::Circulation code to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17680

--- Comment #4 from Jonathan Druart  
---
Bug 17680 - C4::Circulation - Replace GetItemIssue with Koha::Issues


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680
[Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Issues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17677


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677
[Bug 17677] Move C4::Circulation code to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17680] New: C4::Circulation - Replace GetItemIssue with Koha::Issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Bug ID: 17680
   Summary: C4::Circulation - Replace GetItemIssue with
Koha::Issues
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #235 from Marcel de Rooy  ---
Messages: If you go over the number of holds per record, the message is: No
items available. Which is/may be untrue. Why not: you reached the max ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470

--- Comment #6 from Koha Team Lyon 3  ---
Test plan 

0/ Have (or create) at least two branches B1 and B2
1/ Make sure you're logged in with an account belonging to B1, or switch to
branch B1
2/ checkout item I1 (belonging to B1) to patron P  while specifying a due date
< today)
3/ switch to branch B2
4/ checkout item I2 (belonging to B2) to patron P  while specifying a due date
< today)
5/ make sure you have defined "Overdue notice/status triggers" for that patron
category, ie with Delay=1 so that "Overdue Notice" is selected and "Email" is
checked.
6/ from cli run 'perl ./misc/cronjobs/overdue_notices.pl' 
7/ two new entries will be generated in message_queue DB table, coming from
different branches that have the SAME list of overdue items
8/ either see the 'content' field in these entries, or run 'perl
./cronjobs/process_message_queue.pl' to receive the actual emails (provided the
email is properly setup)
9) run again overdue_notices.pl with library option for both B1 and B2 (you
must give the branchcode as parameter) like this :
./overdue_notices.pl -t -library B1branchcode -library B2branchcode 
10) see again that the generated messages have the same list of overdue items

11) apply the patch
12) run again the script first without library option and secondly with it : in
both cases, 2 messages will be created. One from B1 claiming the B1 item,
another from B2 claiming the B2 item.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17676] Default COLLATE for marc_subfield_structure is not set

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17676

--- Comment #11 from Marcel de Rooy  ---
QA Comment:
Passed QA. Seems to fix the issue mentioned.
Still some concerns.

> Indeed we want to keep tagsubfield a utf8_bin (to allow lowercase and 
> uppercase of the same letter for subfields).
Could you provide an example where we want to do that? Is that MARC conform?
And if so(!), why would you need utf8_bin to do so? You can still insert them,
only finding the right a or A would be harder.
It seems to me that we should remove this strange exception, and make sure that
all tagsubfields are saved lowercase. Should not be too hard.
Can MARC::Record handle subfields a and A btw?
But this discussion should be on a new report.

> if ( $table[1] !~ /COLLATE=utf8_unicode_ci/ and $table[1] !~ 
> /COLLATE=utf8mb4_unicode_ci/ ) { #catches utf8mb4 collated tables
This is only 99,9% safe (as you are probably aware of).
If you find one column in unicode_ci, the table might still be something else
(theoretically). Perhaps someone added a custom column with collation?
Since you only change the default here, why not always do it? Replacing X with
X will not be a problem..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5549] Hourly Loans

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5549

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17679


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679
[Bug 17679] C4::Circulation - Remove unused GetItemIssues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17679] C4::Circulation - Remove unused GetItemIssues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||5549


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5549
[Bug 5549] Hourly Loans
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17679] C4::Circulation - Remove unused GetItemIssues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679

--- Comment #1 from Jonathan Druart  
---
Created attachment 57770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57770=edit
Bug 17679: C4::Circulation - Remove unused GetItemIssues

Ready for an archaeology course?

C4::Circulation::GetItemIssues is only used once, from
catalogue/issuehistory.pl
This call has been added by
  commit 95d6452462a560ba0c0ac859a2cfb7783c25c925
Adding some more information on issuehistory.
which says "Adding itemnumber to issuehistory.pl API so that one could search
for issuehistory of a specific item."
So it added the ability to see the item issue history but did not
provide a way to access it via the interface.
It's ok so far but this subroutine is broken since
  commit aa114f53499b9cffde0571fe7e08622f9c9a332a
Bug 5549 : Only use DateTime for issues table
because of this change:
-my $today = C4::Dates->today('iso');
+my $today = DateTime->now( time_zome => C4::Context->tz);

I let you catch the typo ;)
And since this commit the subroutine explodes with "The following
parameter was passed in the call to DateTime::from_epoch but was not
listed in the validation options: time_zome"

Since it has never been raised by someone and that the feature is
hidden, I'd recommend to simply remove it.

Note that the "Checked out from" column would have been wrong even if we
fixed all the previous issue.

Test plan:
Just dig into the code and confirm what this commit message tells

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17679] C4::Circulation - Remove unused GetItemIssues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17676] Default COLLATE for marc_subfield_structure is not set

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17676

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #57761|0   |1
is obsolete||

--- Comment #10 from Marcel de Rooy  ---
Created attachment 57769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57769=edit
Bug 17676: Update default COLLATE of marc_subfield_structure

(This issue has been raised on bug 17216 comments 93-103)
On bug 11944 (3.19.00.006) we updated the default COLLATE for all our tables to
utf8_unicode_ci but not the marc_subfield_structure table.
Indeed we want to keep tagsubfield a utf8_bin (to allow lowercase and uppercase
of the same letter for subfields).
We should have set the default collate to utf8_unicode_ci for further changes.

This patch updates the DB entry 3.19.00.006 to set the default COLLATE to this
table (for people upgrading from prior to 3.19.00.006) and set this
default COLLATE on 16.06.00.033 (for people upgrading from after 3.19.00.006).

The error is:
DBD::mysql::db do failed: Can't create table `koha_kohadev`.`#sql-306_9f9`
(errno: 150 "Foreign key constraint is incorrectly formed") [for Statement "
ALTER TABLE marc_subfield_structure
MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL,
ADD CONSTRAINT marc_subfield_structure_ibfk_1 FOREIGN KEY
(authorised_value) REFERENCES authorised_value_categories (category_name) ON
UPDATE CASCADE ON DELETE SET NULL;
"] at installer/data/mysql/updatedatabase.pl line 13175.
Upgrade to 16.06.00.033 done (Bug 17216 - Add a new table to store authorized
value categories)

Test plan:
1/ git checkout v3.18.00
2/ Do an install
3/ git checkout master;
4/ perl installer/data/mysql/updatedatabase.pl
=> Without this patch, you get the error
=> With this patch applied you will not get it and the default COLLATE for
marc_subfield_structure will be correctly set. Make sure tagsubfield is
still utf8_bin

Signed-off-by: Mark Tompsett 

Signed-off-by: Marcel de Rooy 
Will put some notes on the Bugzilla report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17676] Default COLLATE for marc_subfield_structure is not set

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17676

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17677] Move C4::Circulation code to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17679

--- Comment #3 from Jonathan Druart  
---
Bug 17679 - C4::Circulation - Remove unused GetItemIssues


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679
[Bug 17679] C4::Circulation - Remove unused GetItemIssues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17679] C4::Circulation - Remove unused GetItemIssues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17677


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677
[Bug 17677] Move C4::Circulation code to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17677] Move C4::Circulation code to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677

--- Comment #2 from Jonathan Druart  
---
Bug 17599 - Move C4::Circulation::GetIssuingRule to
Koha::IssuingRules->get_effective_issuing_rule

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17679] New: C4::Circulation - Remove unused GetItemIssues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679

Bug ID: 17679
   Summary: C4::Circulation - Remove unused GetItemIssues
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449

Jonathan Druart  changed:

   What|Removed |Added

 Depends on|17599   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17599
[Bug 17599] Move C4::Circulation::GetIssuingRule to
Koha::IssuingRules->get_effective_issuing_rule
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17677] Move C4::Circulation code to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17599


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17599
[Bug 17599] Move C4::Circulation::GetIssuingRule to
Koha::IssuingRules->get_effective_issuing_rule
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17599] Move C4::Circulation::GetIssuingRule to Koha::IssuingRules-> get_effective_issuing_rule

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17599

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|15449   |17677


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449
[Bug 15449] Move stuffs to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677
[Bug 17677] Move C4::Circulation code to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17677] Move C4::Circulation code to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17678

--- Comment #1 from Jonathan Druart  
---
Bug 17678 - C4::Acquisition - Replace GetIssues with Koha::Issues


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678
[Bug 17678] C4::Acquisition - Replace GetIssues with Koha::Issues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17678] C4::Acquisition - Replace GetIssues with Koha::Issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17677


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677
[Bug 17677] Move C4::Circulation code to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17678] C4::Acquisition - Replace GetIssues with Koha::Issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678

--- Comment #1 from Jonathan Druart  
---
Created attachment 57767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57767=edit
Bug 17678: Add tests for CanBookBeIssued + AllowMultipleIssuesOnABiblio

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17678] C4::Acquisition - Replace GetIssues with Koha::Issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17678] C4::Acquisition - Replace GetIssues with Koha::Issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678

--- Comment #2 from Jonathan Druart  
---
Created attachment 57768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57768=edit
Bug 17678: C4::Circulation - Replace GetIssues with Koha::Issues

The C4::Circulation::GetIssues subroutine is only called once and can be
replaced with a call to Koha::Isues->search with a join on items.

Test plan:
- Apply first patch and make sure the tests pass
- Apply second patch and make sure the tests still pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17678] New: C4::Acquisition - Replace GetIssues with Koha::Issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17678

Bug ID: 17678
   Summary: C4::Acquisition - Replace GetIssues with Koha::Issues
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700

--- Comment #69 from Jonathan Druart  
---
(In reply to Jacek Ablewicz from comment #68)
> (In reply to Jonathan Druart from comment #66)
> > All the indentation changes make this patchset really hard to read, but
> > basically it seems that there are only 2 changes:
> 
> > So, why all these changes just for that?
> 
> There are a lot of (conflicting) reports in queue, dealing with various
> issues with authority merge (including some with critical fixes), but they
> don't seem to be going forward for a long long time and will need to be
> rebased / adjusted anyway, maybe indentation fixes and tidying up by itself
> will be a good start for that?

I'd say the opposite, to avoid all of the other patches to conflict for
indentation changes, it would be better to tidy it later :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700

--- Comment #68 from Jacek Ablewicz  ---
(In reply to Jonathan Druart from comment #66)
> All the indentation changes make this patchset really hard to read, but
> basically it seems that there are only 2 changes:

> So, why all these changes just for that?

There are a lot of (conflicting) reports in queue, dealing with various issues
with authority merge (including some with critical fixes), but they don't seem
to be going forward for a long long time and will need to be rebased / adjusted
anyway, maybe indentation fixes and tidying up by itself will be a good start
for that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700

--- Comment #67 from Jacek Ablewicz  ---
(In reply to Jonathan Druart from comment #66)


> 1/
> Add
>   +$MARCfrom ||= GetAuthority($mergefrom);

$MARCfrom (and @record_from) are currently not used in this function for
anything at all

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17677] Move C4::Circulation code to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15449


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449
[Bug 15449] Move stuffs to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17677

--- Comment #16 from Jonathan Druart  
---
Bug 17677 - Move C4::Circulation code to the Koha namespace


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677
[Bug 17677] Move C4::Circulation code to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17677] New: Move C4::Circulation code to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677

Bug ID: 17677
   Summary: Move C4::Circulation code to the Koha namespace
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17676] Default COLLATE for marc_subfield_structure is not set

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17676

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17676] Default COLLATE for marc_subfield_structure is not set

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17676

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #9 from Marcel de Rooy  ---
QA: Looking at this one now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700

--- Comment #66 from Jonathan Druart  
---
All the indentation changes make this patchset really hard to read, but
basically it seems that there are only 2 changes:

1/
Add
  +$MARCfrom ||= GetAuthority($mergefrom);
  +$MARCto ||= GetAuthority($mergeto);
in C4::AuthoritiesMarc::merge
In which cases that could be useful?

2/ Move DelAuthority to C4::AuthoritiesMarc::merge
Sounds ok, but should not change anything in the behavior.

So, why all these changes just for that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13371] Add filters to the supplier list view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

--- Comment #71 from Marcel de Rooy  ---
This is a hard one for QA imo.
We need some feedback from people actually working with acquisitions here, or
interface design experts. Do they view this as an improvement?

Some of the filters for instance basket number or date seem to be handy.
The vendor name is not as prominently visible as it was. Improve?
I did not test with much data. Seems to be no paging? Filter on date will make
it easier.
The distinction between simple and complete view makes not much sense to me. I
read the request for it. But this view is so 'simple' that I am not sure if it
is of real use. Note that you cannot change between both if you found only one
vendor. Would storing the filter values in the cookie be helpful? Not sure..
Should you toggle between "Show active and inactive baskets | Show opened
baskets only" instead of showing both?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Needs Signoff

--- Comment #5 from Jonathan Druart  
---
The patch that has been signoff is not the one that is attached now.
Another signoff is required.
Please provide a complete test plan to make sure the tester will test all the
different cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

--- Comment #15 from Jonathan Druart  
---
Created attachment 57766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57766=edit
Bug 14699: Reword "Select all/Clear all" and change their behaviour

"Select all" -> "Select all visible rows"
"Clear all" -> "Clear selection on visible rows"

+ fix the bug where the Delete link was visually enabled only if you
checked a box in the first page (now every checkbox enable the link)

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

--- Comment #14 from Jonathan Druart  
---
Created attachment 57765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57765=edit
Bug 14699: Show number of selected searches in search history

With the number displayed, it should remove the ambiguity about what
"Select all" and "Clear all" do.
The number is repeated in the "Delete" confirmation dialog.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42330|0   |1
is obsolete||
  Attachment #57684|0   |1
is obsolete||
  Attachment #57685|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 57764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57764=edit
Bug 14699: Fix intranet search history issues due to pagination

DataTables removes hidden rows from the DOM. Because of that, "Select
all", "Clear all" and the form submission don't work correctly
(basically they act only on the currently displayed page).

This patch fixes just that.

Test plan:
1/ Go to your search history page
2/ Make you sure you have at least 21 entries in your search history. If
not, do some searches and come back here.
3/ Click "Select all" and change page. The checkboxes on the new page
should be checked.
4/ Check some checkboxes on this new page and click "Clear all". Go back
to the previous page, checkboxes shouldn't be checked.
5/ Check some checkboxes on at least 2 different pages and click
"Delete". All selected search history entries should be deleted.

Followed test plan. Works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/