[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Hugo Agud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #26 from Hugo Agud  ---
Fixed the previous error (cache error) tested and signed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274

Josef Moravec  changed:

   What|Removed |Added

   Assignee|josef.mora...@gmail.com |oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Hugo Agud  changed:

   What|Removed |Added

 CC||ha...@orex.es

--- Comment #25 from Hugo Agud  ---
I have tried it, but I get the following error:
https://postimg.org/image/wj3mqhszj/

on plack.log
No property note for Koha::IssueNo property notedate for Koha::IssueNo property
notedate for Koha::IssueNo property notedate for Koha::Issue

Tested on KohadevBox debian jessy 8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274

--- Comment #17 from Josef Moravec  ---
Sorry to not been able to test it sooner, I use the Owen's patch and it worked
perfect for me, so I obsoleted mine and signed off the Owen's ;)

(In reply to Mika from comment #15)
> Before patch was applied, notices on first page were fine but records on
> next page were indeed expanded but could be collapsed. The patch did not fix
> this, however when I applied the patch, all the notices appeared on one page
> expanded and there was no option to collapse them and no option to see them
> on multiple pages/go to next page.

There were two alternative patches, maybe if you accidentaly apply both, this
could happen I imagine...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274

Josef Moravec  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57673|0   |1
is obsolete||
  Attachment #57679|0   |1
is obsolete||

--- Comment #16 from Josef Moravec  ---
Created attachment 57854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57854=edit
Bug 11274 Sent Notices Tab Not Working Correctly

This patch implements the notices toggle event using a different method.
Using on() lets us bind the event to a parent element, allowing the
event to attach to elements which may not exist on the page yet.

Test plan the same as original patch:

1) have a patron with more then 20 notices sent
2) go to patron profile -> notices
-> without patch, the showing/hidding of notices content does work
correctly only on first loaded page
-> with patch, it should work correctly everywhere - try to use
paginator, searching, ordering

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3935] Schedule tasks periodically

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935

Mubassir Ahsan  changed:

   What|Removed |Added

 CC||mahsa...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #57802|0   |1
is obsolete||
  Attachment #57829|0   |1
is obsolete||

--- Comment #24 from Aleisha Amohia  ---
Created attachment 57853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57853=edit
Bug 14224: Allow patron notes about item shown at check in

This patch adds a "Note" input field to checked out items in the "your summary"
section. The field allows patrons to write notes about the item checked out,
such as "this DVD is scratched", "the binding was torn", etc. The note will be
emailed to the library and displayed on item check in.

Patch adds two fields to the "issues" table - "note" and "notedate".
Patch adds syspref "AllowIssueNotes" - default off.

Test Plan:
1) Apply this patch
2) Update database - perl installer/data/mysql/updatedatabase.pl
3) (You may have to rebuild schema but I think the patch should apply
the schema changes for you)
4) Turn on 'AllowIssueNote' syspref
5) Check out three different items to a borrower (may be easiest to check
out to yourself)
6) Log in as that borrower (or yourself) on the OPAC side and go to your
summary
7) Confirm text field shows under Note column for all checkouts. Set a
note for each issue, confirm all save.
8) Check the message_queue in mysql for the entries for ALL THREE issue
notes.
9) Disable javascript in your browser
10) Refresh your summary page. Confirm that you can no longer edit the
notes in the text field. Click the 'Create/edit note' button and confirm
you are redirected to a new page.
11) Confirm that the correct title and author show for the note button
you clicked.
12) Set the note and click Submit -> confirm you are redirected
back to summary page and note is saved
13) Confirm there is a new entry in message_queue
14) Enable javascript and go back to the your checkouts page in the
staff client for the borrower you issued the items to
15) Check in TWO items
16) Confirm that the issue notes show under the two items you checked
in, and are accurate to the item (i.e. the right issue note under the
right item)
17) Go to circ/returns.pl and check in the final item using the barcode.
Confirm the issue note shows.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

David Cook  changed:

   What|Removed |Added

 Blocks||10662


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
[Bug 10662] Build OAI-PMH Harvesting Client
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook  changed:

   What|Removed |Added

 Depends on||15541

--- Comment #110 from David Cook  ---
Adding 15541 back as a dependency, since it's required for matching URIs.

OAI-PMH identifiers must be URIs, so it's necessary for matching OAI-PMH
identifiers.

"The format of the unique identifier must correspond to that of the URI
(Uniform Resource Identifier) syntax."
http://www.openarchives.org/OAI/openarchivesprotocol.html#UniqueIdentifier


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541
[Bug 15541] Prevent normalization during matching/import process
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

David Cook  changed:

   What|Removed |Added

  Attachment #50264|0   |1
is obsolete||
  Attachment #50971|0   |1
is obsolete||

--- Comment #33 from David Cook  ---
Created attachment 57852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57852=edit
Bug 15541 - Prevent normalization during matching/import process

This patch allows you to use the "qualifier,qualifier" syntax
in the Record Matching Rules "Search Index" when using the QueryParser.
While QueryParser doesn't support this syntax, it will now fallback
correctly to non-QueryParser functionality. Without the patch, your search
will just fail silently.

This patch also adds a "skip_normalize" option to C4::Search::SimpleSearch(),
and uses the option during C4::Matcher::get_matches. This prevents
the s/:/=/g and s/=/:/g normalization. This normalization is heavy-handed,
and while it is necessary sometimes to generate a valid CCL query or
QueryParser query, C4::Matcher::get_matches() already produces a valid
CCL query, so we don't need to do this normalization.

Additionally, this normalization causes problems when you use a
Zebra register which isn't normalized: namely the "u" register.
Strings are stored "as is", so http://localhost/koha/resource/1 is
stored as is during indexing. When you search, you need to pass
the exact same thing through the query to get a match. Using
http=//localhost/koha/resource/1 in your query will yield zero results.

_TEST PLAN_

0) Apply patch

1) Create a Record Matching Rule in Koha with the following details:
Matching rule code: TEST
Description: Test
Match threshold: 100
Record type: Bibliographic
Match point 1:
Search index: id-other,st-urx
Score: 100
Tag: 024
Subfields: a
Normalization rule: None
2) Create a record in Koha with an indexable URI
2a) Default framework
2b) 024 $a http://koha-community.org/test $2 uri
2c) 040 $c test
2d) 245 $a This is a test record
2e) 942 $c Books
2f) Save (save again if cautioned about missing fields as these should
autofill)
3) Do a full re-index of Zebra
4) Download your record from Koha as a .mrc file (ie isomarc, binary marc, etc)
5) Go to "Stage MARC records for import"
5a) Upload your .marc file.
5b) Change your "Record matching rule" to "Test"
5c) Click Stage for import
9) It should say "1 records with at least one match in catalog per matching
rule "Test".

NOTE: For completeness, you can go through this process on a clean master
branch,
and note that it will say '0 records with at least one match in catalog per
matching rule "TEST"'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

David Cook  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274

Mika  changed:

   What|Removed |Added

 CC||mikasm...@catalyst.net.nz
 Status|Needs Signoff   |Failed QA

--- Comment #15 from Mika  ---
Before patch was applied, notices on first page were fine but records on next
page were indeed expanded but could be collapsed. The patch did not fix this,
however when I applied the patch, all the notices appeared on one page expanded
and there was no option to collapse them and no option to see them on multiple
pages/go to next page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

David Cook  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |---
 Status|RESOLVED|REOPENED

--- Comment #32 from David Cook  ---
While part of this patch is a duplicate of bug 17318, there are some parts
which are not duplicates. I'm re-opening this bug and will upload an updated
patch for the unique changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17649] Create only one message per borrower and overdue level

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649

Mika  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||mikasm...@catalyst.net.nz

--- Comment #2 from Mika  ---
2 identical messages are still created in message_queue when 'perl
./misc/cronjobs/overdue_notices.pl' is run, both containing both I1 and I2.
Both messages are sent from B1 with B1 addresses.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #1 from Aleisha Amohia  ---
Created attachment 57851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57851=edit
[NOT READY FOR TESTING] Bug 17698: Make patron notes show  up on staff
dashboard

Test plan will come when patch is complete

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||alexbuck...@catalyst.net.nz

--- Comment #14 from Alex Buckley  ---
The Library Groups webpage
(http://localhost:8081/cgi-bin/koha/admin/library_groups.pl) where the user
should be able to create a group (in addition to being able to see previously
made groups) results in a Internal Server Error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671

Alex Buckley  changed:

   What|Removed |Added

  Attachment #57726|0   |1
is obsolete||

--- Comment #4 from Alex Buckley  ---
Created attachment 57850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57850=edit
remove unused variables

https://bugs.koha-community.org/show_bug.cgi?id=17671
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15822] STAFF Advanced search error date utils

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822

Alex Buckley  changed:

   What|Removed |Added

  Attachment #48153|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15822] STAFF Advanced search error date utils

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822

Alex Buckley  changed:

   What|Removed |Added

  Attachment #48121|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15822] STAFF Advanced search error date utils

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||alexbuck...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15822] STAFF Advanced search error date utils

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822

Alex Buckley  changed:

   What|Removed |Added

  Attachment #57725|0   |1
is obsolete||

--- Comment #18 from Alex Buckley  ---
Created attachment 57849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57849=edit
Bug 15822: Fix 500 error when searching if items.onloan=-00-00

The calls
  output_pref({ dt => dt_from_string( $date ) })
are wrong and should be replaced with
  output_pref({ str => $date })
For better error handling.

Here we fix the problem of items.onloan when searching

Test plan:
- Set items.onloan=-00-00 (UPDATE items SET onloan='-00-00')
This can come from old data or bad migration
- Execute a search
=> Without this patch you get
Can't locate object method "ymd" via package "dateonly" (perhaps you forgot to
load "dateonly"?) at /home/vagrant/kohaclone/Koha/DateUtils.pm line 225.
=> With this patch you won't get the error

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561

Mika  changed:

   What|Removed |Added

 CC||mikasm...@catalyst.net.nz
 Status|Needs Signoff   |Failed QA

--- Comment #5 from Mika  ---
t/db_dependent/Reserves/ReserveSlip.t ..
DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. 
SQL that returns multiple rows is DEPRECATED for ->find and ->single at
/home/vagrant/kohaclone/Koha/Objects.pm line 83
t/db_dependent/Reserves/ReserveSlip.t .. 1/5
DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. 
SQL that returns multiple rows is DEPRECATED for ->find and ->single at
/home/vagrant/kohaclone/Koha/Objects.pm line 83
Can't use an undefined value as a HASH reference at
t/db_dependent/Reserves/ReserveSlip.t line 112.
# Looks like your test exited with 255 just after 1.
t/db_dependent/Reserves/ReserveSlip.t .. Dubious, test returned 255 (wstat
65280, 0xff00)
Failed 4/5 subtests 

Test Summary Report
---
t/db_dependent/Reserves/ReserveSlip.t (Wstat: 65280 Tests: 1 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 5 tests but ran 1.
Files=1, Tests=1,  2 wallclock secs ( 0.02 usr  0.00 sys +  1.68 cusr  0.07
csys =  1.77 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17512] Improve handling dates in C4::Items

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512

Mika  changed:

   What|Removed |Added

 CC||mikasm...@catalyst.net.nz
 Status|Needs Signoff   |Failed QA

--- Comment #2 from Mika  ---
Passed step 4 of test plan, however invalid dates still show as -00-00
rather than null when saved for both dateaccessioned and replacementpricedate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17379] Add a man page for koha-passwd

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17379

Mika  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17379] Add a man page for koha-passwd

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17379

Mika  changed:

   What|Removed |Added

  Attachment #56848|0   |1
is obsolete||

--- Comment #13 from Mika  ---
Created attachment 57848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57848=edit
Bug 17379 - Add a man page for koha-passwd

Adding a manpage for the koha-passwd utility.

To test:
1) Run these commands and look at the formatted man page:
$xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \
 debian/docs/koha-passwd.xml
2)$man -l koha-passwd.8

3) Make sure this test passes:  $prove -v xt/verify-debian-docbook.t

Signed-off-by: Mika Smith 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17624] Add Staff Collection status for items in C4::XSLT

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17624

Marcel de Rooy  changed:

   What|Removed |Added

  Comment #1 is|1   |0
private||
  Comment #2 is|1   |0
private||
  Comment #3 is|1   |0
private||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Issues

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Alex Buckley  changed:

   What|Removed |Added

  Attachment #57788|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Issues

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Alex Buckley  changed:

   What|Removed |Added

  Attachment #57787|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Issues

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle field to biblio table

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Issues

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Alex Buckley  changed:

   What|Removed |Added

  Attachment #57789|0   |1
is obsolete||

--- Comment #6 from Alex Buckley  ---
Created attachment 57847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57847=edit
Bug 17680: C4::Circulation - Remove GetItemIssue

This patch simply removes the C4::Circulation::GetItemIssue subroutine

Test plan:
At this point, `git grep GetItemIssue` should not return any occurrence
in the codebase

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580

Jonathan Druart  changed:

   What|Removed |Added

 Depends on|17699   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699
[Bug 17699] DateTime durations are not correctly subtracted
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|17580   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580
[Bug 17580] Add the Koha::Patron->get_overdues method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

--- Comment #35 from Josef Moravec  ---
I rebased the patches on master and in followup fixed same small issues - we
need this in our project.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

--- Comment #34 from Josef Moravec  ---
Created attachment 57846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57846=edit
Bug 15165: followup - fix definitions, and passing amount parameter in pay
method

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56696|0   |1
is obsolete||

--- Comment #33 from Josef Moravec  ---
Created attachment 57845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57845=edit
Bug 15165 - Add API routes to pay accountlines

POST /accountlines/(:accountlines_id)/payment  (pay towards accountline)
POST /patrons/(:borrowernumber)/payment(pay towards borrower)

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You must have permission updatecharges.
2. Create a fine to any patron and get the accountlines_id.
3. Send POST request to http://yourlibrary/api/v1/accountlines/YYY/payment
   without body where YYY is the accountlines_id you created in step 2.
4. Check that the accountline that you created in step 2 is paid.
5. Create two payments with amount 5.00 (with no other outstanding payments)
6. Send POST request to
   http://yourlibrary/api/v1/patrons/ZZZ/payment with body
   {"amount": 10}
   Replace ZZZ with the borrowernumber for which you have created two
   fines
7. Check that the two accountlines are paid.
8. Repeat step 2.
9. Send POST request to
   http://yourlibrary/api/v1/accountlines/YYY/payment with body
   {"amount": XXX}
   Replace YYY with the accountlines_id you created in step 8.
   Set amount (XXX) to the half of the amount of the fine you created in
   step 8.
10. Check that the fine is still outstanding with half of the original
amount.
11. Run unit tests at t/db_dependent/api/v1/accountlines.t and
t/db_dependent/api/v1/patrons.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56694|0   |1
is obsolete||

--- Comment #31 from Josef Moravec  ---
Created attachment 57843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57843=edit
Bug 15165 - Add API route to list accountlines

GET /accountlines  (list)
GET /accountlines?borrowernumber=X (list)

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission updatecharges.
2. Go to http://yourlibrary/api/v1/accountlines?borrowernumber=XXX (replace
   XXX with a borrowernumber that has accountlines) and check you receive
   correct data
3. Go to http://yourlibrary/api/v1/accountlines and check that you receive
   all accountlines
4. Run unit tests in t/db_dependent/api/v1/accountlines.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56695|0   |1
is obsolete||

--- Comment #32 from Josef Moravec  ---
Created attachment 57844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57844=edit
Bug 15165 - Add API route to edit accountlines

PUT /accountlines/{accountlines_id} (edit)

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission updatecharges.
2. Send PUT request to http://yourlibrary/api/v1/accountlines/YYY
   where YYY is one of your accountlines_id. See the body definition
   in definitions/editAccountlineBody.json and use this in your PUT request.
3. Run unit tests in t/db_dependent/api/v1/accountlines.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897

Josef Moravec  changed:

   What|Removed |Added

 Blocks||15165


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165
[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

Josef Moravec  changed:

   What|Removed |Added

 Depends on||15897

--- Comment #30 from Josef Moravec  ---
Because of the way the Koha::Account->pay is called in the patch, this report
depends especially on bug 15897.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897
[Bug 15897] Use Koha::Account::pay internally for recordpayment_selectaccts
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #44 from Jonathan Druart  
---
(In reply to Hugo Agud from comment #35)
> sorry, I published the conflict in the wrong bug

But they needed a rebase anyway :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55906|0   |1
is obsolete||

--- Comment #38 from Jonathan Druart  
---
Created attachment 57837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57837=edit
Bug 17196: Update misc/maintenance/sanitize_records.pl

Test plan:
Use the sanitize_records.pl maintenance script with the --auto-search
option

Signed-off-by: Mason James 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55908|0   |1
is obsolete||

--- Comment #40 from Jonathan Druart  
---
Created attachment 57839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57839=edit
Bug 17196: DB Changes

Remove biblioitems.marcxml and deletedbiblioitems.marcxml
and adds 2 table biblio_metadata and deletedbiblio_metadata

Signed-off-by: Mason James 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55907|0   |1
is obsolete||

--- Comment #39 from Jonathan Druart  
---
Created attachment 57838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57838=edit
Bug 17196: Update switch_marc21_series_info.pl

Not sure if this script is still used, could someone confirm?

Test plan:
If you know how to test it, please do

Signed-off-by: Mason James 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55951|0   |1
is obsolete||

--- Comment #42 from Jonathan Druart  
---
Created attachment 57841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57841=edit
Bug 17196: Fix - Update metadata on update

Signed-off-by: Mason James 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55950|0   |1
is obsolete||

--- Comment #41 from Jonathan Druart  
---
Created attachment 57840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57840=edit
Bug 17196: Simplify tests for the different marc flavours

centralize the way MARC field are set.

Signed-off-by: Mason James 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56038|0   |1
is obsolete||

--- Comment #43 from Jonathan Druart  
---
Created attachment 57842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57842=edit
Bug 17196: follow-up for bug 17088

If bug 17088 is pushed first, we will need this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55904|0   |1
is obsolete||

--- Comment #36 from Jonathan Druart  
---
Created attachment 57835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57835=edit
Bug 17196: Move marcxml out of the biblioitems table

Two discussions on koha-devel lead to the same conclusion:
biblioitems.marcxml should be moved out this table
- biblio and biblioitems
http://lists.koha-community.org/pipermail/koha-devel/2013-April/039239.html
- biblioitems.marcxml & biblioitems.marc / HUGE performance issue !
http://lists.koha-community.org/pipermail/koha-devel/2016-July/042821.html

There are several goals to do it:
- Performance
As Paul Poulain wrote, a simple query like
  SELECT publicationyear, count(publicationyear) FROM biblioitems GROUP BY
publicationyear;
takes more than 10min on a DB with more than 1M bibliographic records
but only 3sec (!) on the same DB without the biblioitems.marcxml field
Note that priori to this patch set, the biblioitems.marcxml was not
retrieved systematically, but was, at least, in
C4::Acquisition::GetOrdersByBiblionumber and C4::Acquisition::GetOrders
- Flexibility
Storing the marcxml in a specific table would allow use to store several
kind of metadata (USMARC, MARCXML, MIJ, etc.) and different formats
(marcflavour)
- Clean code
It would be a first step toward Koha::MetadataRecord for bibliographic
records (not done in this patch set).

Test plan:
- Update the DBIC Schema
- Add / Edit / Delete / Import / Export bibliographic records
- Add items
- Reindex records using ES
- Confirm that the following scripts still work:
* misc/cronjobs/delete_records_via_leader.pl
* misc/migration_tools/build_oai_sets.pl
- Look at the reading history at the OPAC (opac-readingrecord.pl)
- At the OPAC, click on a tag, you must see the result

Note: Changes in Koha/OAI/Server/ListRecords.pm is planned on bug 15108.

Signed-off-by: Mason James 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55905|0   |1
is obsolete||

--- Comment #37 from Jonathan Druart  
---
Created attachment 57836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57836=edit
Bug 17196: Fix query builder for item search

The item search needs to join on biblio_metadata to allow search on
marcxml field

Test plan:
Launch complex item searches (using marc fields).

Signed-off-by: Mason James 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Hugo Agud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #35 from Hugo Agud  ---
sorry, I published the conflict in the wrong bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Hugo Agud  changed:

   What|Removed |Added

 CC||ha...@orex.es
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #34 from Hugo Agud  ---
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17624] Add Staff Collection status for items in C4::XSLT

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17624

--- Comment #13 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #12)
> I am no fan of this approach. I think hardcoding behaviour for numeric
> values will break behaviour for libraries. I am still in favor of this being
> a configuration option.

I have spent hours on other options. I will leave it at this point for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17624] Add Staff Collection status for items in C4::XSLT

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17624

--- Comment #12 from Katrin Fischer  ---
I am no fan of this approach. I think hardcoding behaviour for numeric values
will break behaviour for libraries. I am still in favor of this being a
configuration option.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17624] Add Staff Collection status for items in C4::XSLT

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17624

--- Comment #11 from Marcel de Rooy  ---
Apart from consolidating item status code, we also should take into account the
relation between Not-for-loan and Use-restrictions on the item record when
resolving this more globally.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17624] Add Staff Collection status for items in C4::XSLT

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17624

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Hide (some) not-for-loan|Add Staff Collection status
   |items on search results'|for items in C4::XSLT
   |availability|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17624] Hide (some) not-for-loan items on search results' availability

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17624

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #57540|0   |1
is obsolete||
  Attachment #57541|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 57833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57833=edit
Bug 17624: Separate XSLT item status for Staff Collection

In order to differentiate a regular not for loan with a not-for-loan that
has the status "Staff Collection", this patch slightly adjusts the status
in C4::XSLT::buildKohaItemsNamespace. This status is used in the OPAC
results XSLT.

If you do not have items with notforloan>=2, there will be no change in
behavior.

If you use notforloan=2 and did not change its authorised value description,
a count for Staff Collection will be added in the Availability line. The
items with notforloan==2 will no longer be viewed as "for reference".

Higher values for notforloan will no longer be listed too as "for
reference". (Same for a modified notforloan==2.)

Note: I also considered using a plugin here or a specific preference. This
solution is by far the simplest. Currently, we are presenting the item
status in various places on various ways. A better solution would depend
on consolidating the item status code in Koha::Item.

Test plan:
[1] Pick a biblio with three items: one should be for loan, set the other
two to Not for loan and Staff Collection.
[2] Look for this biblio on OPAC search results. Check Availability.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17624] Hide (some) not-for-loan items on search results' availability

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17624

--- Comment #10 from Marcel de Rooy  ---
Created attachment 57834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57834=edit
Bug 17624: [Follow-up] Consistency between Availability and Location

If OpacItemLocation is set to location, the opac results xslt shows
something like:
Availability: Copies available for loan: Library(1).
  Copies available for reference: Library(1).
Location(s):  Location_1 callnumber_1

Note that the reference item is not listed under Location, since the logic
for that section is different. Simply stated: Available is created by two
separate if statements, but Location is one if-else statement.

This patch changes the Location logic to two if statements. In this
process some single choose/when's are replaced by simple if's. Actually,
the change is quite minimal.

NOTE: A conditional  tag is removed from the XSLT between the reference
section and the status counts.

Test plan:
[1] Set OpacItemLocation to Location.
[2] Use a biblio with two items. Put data in callnumber and location.
Mark one item as not for loan.
[3] Verify that you now see both items in the Location line of the
search results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17624] Hide (some) not-for-loan items on search results' availability

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17624

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15822] STAFF Advanced search error date utils

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822

Hugo Agud  changed:

   What|Removed |Added

 CC||ha...@orex.es

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17704] OAI-PMH compatiblity with Ubuntu Xenial and Debian Stretch

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704

--- Comment #1 from Fridolin SOMERS  ---
See https://packages.debian.org/search?searchon=names=libhttp-oai-perl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17704] New: OAI-PMH compatiblity with Ubuntu Xenial and Debian Stretch

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704

Bug ID: 17704
   Summary: OAI-PMH compatiblity with Ubuntu Xenial and Debian
Stretch
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Actually OAI-PMH in Koha uses HTTP::OAI lib from version in Jessie 3.27.
This module is not compatible with version 4.03 which is in Ubuntu Xenial and
Debian Stretch.
You get the error : 
Can't call method start_element on an undefined value at
/usr/share/perl5/HTTP/OAI/Response.pm line 114
This is because the method HTTP::OAI::Response::generate() has changed, it
needs an argument $driver.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17395] exporting checkouts in CSV generates a file with wrong extension

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #16 from Julian Maurice  ---
Pushed to 3.22.x, will be in 3.22.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17391] ReturnpathDefault and ReplyToDefault missing from syspref.sql

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17391

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #15 from Julian Maurice  ---
Pushed to 3.22.x, will be in 3.22.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17660] Any $t subfields not editable in any framework

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17660

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #7 from Julian Maurice  ---
Pushed to 3.22.x, will be in 3.22.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17703] Add ISSN column in serials claims table - fix

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 57832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57832=edit
Bug 17703 - Add ISSN column in serials claims table - fix

Bug 11861 added ISSN column in serials claims table, in a SQL query in
C4::Serials::GetLateOrMissingIssues().
But this SQL query is in a if condition, the same change must be done in the
else case.

Test plan:
1/ Go to serials claims page
2/ Do not choose a vendor and submit
3/ You should see a ISSN column, filled with subscription ISSN

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17419] Fix more confusion between smsalertnumber and mobile

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17419

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #5 from Julian Maurice  ---
Pushed to 3.22.x, will be in 3.22.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17703] Add ISSN column in serials claims table - fix

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703

Fridolin SOMERS  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11861] Add ISSN column in serials claims table

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11861

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||17703


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703
[Bug 17703] Add ISSN column in serials claims table - fix
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17703] Add ISSN column in serials claims table - fix

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17703] Add ISSN column in serials claims table - fix

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703

Fridolin SOMERS  changed:

   What|Removed |Added

 Depends on||11861


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11861
[Bug 11861] Add ISSN column in serials claims table
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17590] Exporting reports as CSV with 'delimiter' SysPref set to ' tabulation' creates files with 't' as separator

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17590

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #8 from Julian Maurice  ---
Pushed to 3.22.x, will be in 3.22.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17703] New: Add ISSN column in serials claims table - fix

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703

Bug ID: 17703
   Summary: Add ISSN column in serials claims table - fix
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

Bug 11861 added ISSN column in serials claims table, in a SQL query in
C4::Serials::GetLateOrMissingIssues().
But this SQL query is in a if condition, the same change must be done in the
else case.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17513] koha-create does not set GRANTS correctly

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #7 from Julian Maurice  ---
Pushed to 3.22.x, will be in 3.22.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14736] AllowRenewalIfOtherItemsAvailable slows circulation down in case of a record with many items and many holds

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14736

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #6 from Julian Maurice  ---
Pushed to 3.22.x, will be in 3.22.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17323] MySQL 5.7 - Column search_history.time cannot be null

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17323

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #7 from Julian Maurice  ---
Pushed to 3.22.x, will be in 3.22.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17484] Searching with date range limit (lower and upper) does not work

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #14 from Julian Maurice  ---
Pushed to 3.22.x, will be in 3.22.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17627] Move C4::Koha::GetItemTypesByCategory to Koha::ItemTypes

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17627

Hugo Agud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ha...@orex.es

--- Comment #2 from Hugo Agud  ---
checked using this test plan and signed off

NORMAL USAGE
2) Group your items under that new category
   a) In Intranet/Koha Admin/Item types, choose (at least) two item types and
for each:
  - Click action/Edit on the right column
  - Third row (below Description) is the Search category list box, select
Hardware
  - click Save changes at the bottom
3) Select at least one item to be hidden in the OPAC search
   a) In Intranet/Koha Admin/Item types (again), choose a different item type:
  -  Click action/Edit
  -  Click the checkbox "Hide in OPAC" below the list of icons.

FINAL TESTING
4) Go test your modifications
   a) Go to OPAC/Adv search.
   b) Validate that all items modified above (hidden or grouped) do not appear
in Item type list
   c) Validate that new item type Hardware does appear instead.
   d) Select item Hardware, start Search.
   e) Validate returned items are the of the two types that were grouped into
the Hardware category in step 4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #133 from Julian Maurice  ---
Pushed to 3.22.x, will be in 3.22.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15690] Unconstrained CardnumberLength preference conflicts with table column limit of 16

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #18 from Julian Maurice  ---
Pushed to 3.22.x, will be in 3.22.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17607] Fix patron definition in Swagger

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17607

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17558] Fix t/db_dependent/Koha/Patron/Messages.t

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17558

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17397] Show name of librarian who created circulation message

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17562] Acquisition.t is broken

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17562

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17563] Acquisition/CancelReceipt.t is broken

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17563

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17521] Step 3 of patron modification editor not checking age limits

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17548] Step 1 of memberentry explodes

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17548

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16792] Add Font Awesome Icon and mini button to Keyword to MARC mapping section

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16792

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17538] t/db_dependent/Upload.t is broken

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17538

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17540] auth_values_input_www.t is broken

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16852] Remove C4::Members::GetBorrowerCategorycode

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17274] Add info about which memcached config is used to about.pl

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11921] Move memcached configuration back to koha-conf.xml

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15581] Add a circ rule to not allow auto-renewals after defined loan period

2016-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581

Mason James  changed:

   What|Removed |Added

 Status|Pushed to Stable|Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >