[Koha-bugs] [Bug 17226] Improve AUTOLOAD of Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17226 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com Depends on||17091 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091 [Bug 17091] Add AUTOLOAD to Koha::Objects -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091 Mason James changed: What|Removed |Added Blocks||17226 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17226 [Bug 17226] Improve AUTOLOAD of Koha::Object -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12769] Notice fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Radek Šiman (R-Bit Technology, s.r.o.) changed: What|Removed |Added CC||r...@rbit.cz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17832] New: arl (accelerated reading level) and ard (? -- Title point value) searches do not return results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17832 Bug ID: 17832 Summary: arl (accelerated reading level) and ard (? -- Title point value) searches do not return results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Prepending "arl:" or "ard:" to search terms should use the "ard" or "arl" indexes. arl should index 526$c, and ard should index 526$d. Here are some values for 526$c, taken from the koha database backing http://catalog.bywatersolutions.com/. select biblionumber, title, ExtractValue( marcxml, '//datafield[@tag=526]/subfield[@code="c"]' ) as 'arl' from biblioitems inner join biblio using (biblionumber) where ExtractValue( marcxml, '//datafield[@tag=526]/subfield[@code="c"]' ) != '' limit 10; +--+---+-+ | biblionumber | title | arl | +--+---+-+ |33556 | Boy, were we wrong about dinosaurs! / | 5.0 | |37781 | Who really discovered America? : | 100 | |39460 | Mummies in the morning / | 2.7 grade level | |45646 | Endymion Spring / | 6.3 | |47364 | The year we disappeared : | 5.7 | |48039 | There was an old lady who swallowed Fly Guy / | 1.6 | |48041 | Ants /| 1.5 1.0 | |48042 | The Arabian horse / | 3.5 4.9 | |48043 | Athena / | 4.4 4.4 | |48044 | Aunts / | 1.3 0.9 | +--+---+-+ 10 rows in set (5.19 sec) ... so a search of "arl: 2.7 grade level" *should* return results for at least "Mummies in the morning /" Instead http://catalog.bywatersolutions.com/cgi-bin/koha/opac-search.pl?idx=&q=arl%3A+2.7+grade+level&branch_group_limit= returns no results. Likewise for ard select biblionumber, title, ExtractValue( marcxml, '//datafield[@tag=526]/subfield[@code="d"]' ) as 'ard' from biblioitems inner join biblio using (biblionumber) where ExtractValue( marcxml, '//datafield[@tag=526]/subfield[@code="d"]' ) != '' limit 10 +--+---+--+ | biblionumber | title | ard | +--+---+--+ |33556 | Boy, were we wrong about dinosaurs! / | 0.5 | |37781 | Who really discovered America? : | 2000 | |39460 | Mummies in the morning / | 1.0 pts. | |45646 | Endymion Spring / | 13. | |47364 | The year we disappeared : | 13 | |48039 | There was an old lady who swallowed Fly Guy / | 0.5 | |48041 | Ants /| 1 0.5| |48042 | The Arabian horse / | 3 0.5| |48043 | Athena / | 3 0.5| |48044 | Aunts / | 1 0.5| +--+---+--+ A search for "ard: 1.0 pts" should return "Mummies in the morning /" But http://catalog.bywatersolutions.com/cgi-bin/koha/opac-search.pl?idx=&q=ard%3A+1.0+pts&branch_group_limit= Does not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17831] Item Search fails on custom subject search field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 --- Comment #2 from Nick Clemens --- No, it appears to be bad data in our sample install files: SELECT * FROM marc_subfield_structure WHERE tagfield=650 AND tagsubfield='a' AND frameworkcode=''\G; The kohafield is set to bibliosubject.subject, I am guessing this is cruft (In reply to Katrin Fischer from comment #1) > We just fixed bug 17743 - could this be it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16643] Make debian/list-deps aware of Jessie folder structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16643 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #5 from M. Tompsett --- ^/usr/((lib|share)/perl5| (lib|share)/perl/[0-9.]+| (lib|share)/.*-linux-gnu.*/perl/[0-9.]+| (lib|share)/.*-linux-gnu.*/perl5/[0-9.]+) ^/usr/((lib|share)/(.*-linux-gnu.*/)?perl5?/?[0-9.]+)? Ah there is the difference, the first one is lacking the "/[0-9.]+" part. The four examples you gave do match. /usr/lib/perl5/5.14.2/POSIX.pm -- would not match the first. But is that even possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 M. Tompsett changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #50 from M. Tompsett --- As per Kyle Hall's request in comment #48, added missing tests. Set to needs sign off. Though really, everything should be good. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 --- Comment #49 from M. Tompsett --- Created attachment 58548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58548&action=edit Bug 17234: Two new functions lack tests This adds two tests to t/db_dependent/Installer.t TEST PLAN - 1) Apply patch 2) prove -v t/db_dependent/Installer.t -- column and constraint tests were added. 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17800] Add admin sidebar menu to marc-subfields-structure.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17800 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17800] Add admin sidebar menu to marc-subfields-structure.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17800 Kyle M Hall changed: What|Removed |Added Attachment #58364|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 58547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58547&action=edit Bug 17800: Add admin sidebar menu to marc-subfields-structure.pl Adding to marc-subfields-structure because auth-subfields-structure has it, so I assume it was just missed when the admin-menu was added. To test: 1) Go to admin -> MARC bibliographic frameworks -> Actions for any framework -> MARC structure -> Actions for any tag -> Subfields 2) Notice no admin-menu on the side 3) Apply patch and refresh page 4) Notice admin-menu now shows Note: the link in the sidebar menu for MARC bibliographic frameworks does not show as active (bold) from this page. This is fixed in Bug 17794 Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17799] MARC bibliographic frameworks breadcrumbs broken for Default framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17799 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17799] MARC bibliographic frameworks breadcrumbs broken for Default framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17799 Kyle M Hall changed: What|Removed |Added Attachment #58363|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 58546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58546&action=edit Bug 17799: MARC bibliographic frameworks breadcrumbs broken for Default framework To test: 1) Go to Admin -> MARC frameworks -> Default framework actions -> MARC structure 2) Click New tag 3) Notice the breadcrumbs say '()' instead of 'Default MARC framework' or something more appropriate 4) Apply patch and refresh page 5) Confirm breadcrumbs are now filled correctly 6) Go back to tag structure and try deleting a tag (Actions -> Delete) 7) Confirm breadcrubs are filled correctly Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Kyle M Hall changed: What|Removed |Added Attachment #58173|0 |1 is obsolete|| --- Comment #15 from Kyle M Hall --- Created attachment 58544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58544&action=edit Bug 6782 - Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions). Currently the card number is generated when the user enters the patron creation form. This creates a problem of concurrency - when two or more simulataneous users are registering members, the error "card no. in use" can occur. This change moves the card number generation to occur after the "Save" button is pressed. Changes: -C4/Members.pm: Added code to fixup_cardnumber,If the cardnumber is blank and "autoMemberNum" ON. -koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Added code to display "leave blank for auto calc during registration" in cardnumber label in patron registration form only if "autoMemberNum" ON. -members/memberentry.pl: Added code to get weather or not "autoMemberNum" is on or off and removed fixup_cardnumber generation. Test cases: -If "autoMemberNum" ON: ->In blank case, must generate auto card number in simulataneous users. ->If user entered, check for unique card number. -If "autoMemberNum" OFF: Must work normal. Followed test plan, works as expected. Note: Syspref PorrowerMandatoryField must not include cardnumber, otherwise you can not save. Maybe that should be mentioned in the comment for syspref autoMemberNum. Signed-off-by: Marc Véron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 --- Comment #16 from Kyle M Hall --- Created attachment 58545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58545&action=edit Bug 6782 [QA Followup] - Remove unused param and limit calls to Koha.Preference Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17466] Show number of outstanding issues when checking in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 --- Comment #8 from Kyle M Hall --- Created attachment 58542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58542&action=edit Bug 17466: Followup, change button to link and fix terminology Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17466] Show number of outstanding issues when checking in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 --- Comment #9 from Kyle M Hall --- Created attachment 58543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58543&action=edit Bug 17466 [QA Followup] - Give the link some style Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17466] Show number of outstanding issues when checking in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17466] Show number of outstanding issues when checking in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Kyle M Hall changed: What|Removed |Added Attachment #57806|0 |1 is obsolete|| Attachment #58191|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 58541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58541&action=edit Bug 17466: Show number of outstanding issues when checking in Test plan: 1) Apply patch 2) Checkout more then one item to a borrower 3) Check one of that items 4) Note, that on in returns table there is a button with number of outstanding issues in patron column. The button should take you to checking out page 5) When the outstanding issues count is 0, there is no button Signed-off-by: Radek Šiman Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17265] Make koha-create and koha-dump-defaults less greedy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17265 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17265] Make koha-create and koha-dump-defaults less greedy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17265 Kyle M Hall changed: What|Removed |Added Attachment #55458|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 58540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58540&action=edit Bug 17265 - Make koha-create-defaults less greedy koha-create-defaults substitutes the instance name with the placeholder __KOHASITE__ in the SQL file that it creates. If the instance name is something common, like "data", this means that way too many substitutions will be made, and when koha-create uses the SQL file as a template, broken data can be the result. The solution in this patch was suggested by drojf on IRC. To test: - Create an instance called "data" - Run "sudo koha-dump-defaults data > test.sql" - Take a look at test.sql and verify there are way too many occurences of __KOHASITE__, like "-- Dumping __KOHASITE__ for table `accountlines`" - Apply the patch - Copy the resulting koha-create and koha-dump-defaults to somewhere running off the packages - Run "sudo koha-dump-defaults data > test.sql" again and verify there are only 4 occurrences of __KOHASITE__, in places that make sense - Create an instance with something like: $ gzip test.sql $ sudo koha-create --create-db --defaultsql test.sql.gz test17265 - Verify that you have a working Koha install Signed-off-by: Andreas Roussos Works as expected. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 --- Comment #17 from Kyle M Hall --- Created attachment 58538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58538&action=edit Bug 17447: Remove unused vars from batchRebuildItemsTables.pl Variables $extkey not used, %opt not used. Variables $tmptest[...] not used, calling _build_tag_directory useless. The script now does not only print help if you specify -t. Sub defnonull tidied. Rearranged modules, removed Dumper. Test plan: [1] Run the script with -t flag. The script should not only print usage statement, but should do a dry run. (Test this on a small database, or pass an additional where clause.) Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 Kyle M Hall changed: What|Removed |Added Attachment #58531|0 |1 is obsolete|| Attachment #58532|0 |1 is obsolete|| Attachment #58534|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall --- Created attachment 58537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58537&action=edit Bug 17447: Run perltidy on batchRebuildItemsTables.pl Test plan: Verify that the output of diff -w between the original and tidied file does not introduce code changes. Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 --- Comment #18 from Kyle M Hall --- Created attachment 58539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58539&action=edit Bug 17447: %opt is unused Deleted the line. perlcritic -4 before and after. Before there are issues. After there is not. Also, changed function to not rely on implicit return value of last line, but explicitly stated a return. And operator changed, due to precedence issues. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 Kyle M Hall changed: What|Removed |Added Attachment #58158|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 58536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58536&action=edit Bug 17766 - Patron notification does not work with multi item holds This patch fixes notification when same biblio has multiple reserves with same borrower, introduced in Bug 14695. C4::Reserves::ModReserveAffect uses internal method _koha_notify_reserve but sends itemnumber and biblionumber instead of record_id. To test: Prerequisites: - One biblio with two items attached - A patron with hold_filled notification activated - A letter for HOLD with <> in it 1) Place two reservations on same biblio 2) checkin item x on pickup branch, observe patron message generated 3) checkin item y on pickup branch, observe patron message generated 4) note that reserve_id is the same on both messages, which is wrong 5) apply this patch and repeat 1-3 6) now observe notifications have correct (different) reserve_id Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15419] Sipserver problem with stale db handles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #9 from Kyle M Hall --- (In reply to Srdjan Jankovic from comment #8) > Yes, that should be the case. So are you saying this bug should be closed, or it is still needed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #48 from Kyle M Hall --- Could we get some basic unit tests for the new subroutines? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17610] Allow the number of plack workers and max connections to be set in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 --- Comment #8 from Tomás Cohen Arazi --- I think we could use this for now, and removed it later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830 Kyle M Hall changed: What|Removed |Added Attachment #58515|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 58535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58535&action=edit Bug 17830: CSRF - Handle unicode characters in userid If the userid of the logged in user contains unicode characters, the token will not be generated correctly and Koha will crash with: Wide character in subroutine entry at /usr/share/perl5/Digest/HMAC.pm line 63. Test plan: - Edit a superlibrarian user and set his/her userid to '❤' or any other strings with unicode characters. - Login using this patron - Search for patrons and click on a result. => Without this patch, you will get a software error (with "Wide character in subroutine entry" in the logs). => With this patch, everything will go fine You can also test the other files modified by this patch. Signed-off-by: Karam Qubsi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17610] Allow the number of plack workers and max connections to be set in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 --- Comment #7 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #5) > Can we better put that info on a specific file? Maybe > /etc/koha/sites//plack.conf Is that the only reason for Failed QA? I agree with Larry that they could be in koha-conf, just like similar stuff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17610] Allow the number of plack workers and max connections to be set in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Larry Baerveldt changed: What|Removed |Added CC||la...@bywatersolutions.com --- Comment #6 from Larry Baerveldt --- I'm curious, but why add a separate config file for what amounts to a couple of lines? Why not just put them on koha-conf.xml? We desperately need this patch. We're running dozens of sites on our clusters, and need to be able to set different numbers of plack workers for different sites. Plus there are the larger sites on stand-alone servers, that need more than 2 workers, but when we change them in koha-plack, it gets overwritten with every upgrade. This is, in my opinion, a very needed patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent in arbitrary SIP2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826 --- Comment #6 from Chris Kirby --- (In reply to Kyle M Hall from comment #5) > I just realized I never added the dependencies! This patch depends on bug > 17792, that's probably why you got that error. > > (In reply to Kyle M Hall from comment #4) > > Chris, do you get that error on master alone? It would be worth checking on > > because I cannot imagine how this patch would cause an error like that! > > > > > At step 3, I added a patron (and added values to CODE1, CODE2, and CODE3). > > > When I subsequently clicked on the cgi-bin/koha/admin/categories.pl, > > > I got the following error: > > > > > > "Software error: > > > > > > Template process failed: undef error - round() overflow. Try smaller > > > precision or use Math::BigFloat at /home/ckirby/koha/Koha/Number/Price.pm > > > line 44. > > > > > > For help, please send mail to the webmaster ([no address given]), giving > > > this error message and the time and date of the error. " Kyle, I am struggling to get bug 17792 to pass the tests (and to run the database update scripts). If you have a chance, look my comments on the bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 Marcel de Rooy changed: What|Removed |Added Attachment #58533|0 |1 is obsolete|| --- Comment #15 from Marcel de Rooy --- Created attachment 58534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58534&action=edit Bug 17447: %opt is unused Deleted the line. perlcritic -4 before and after. Before there are issues. After there is not. Also, changed function to not rely on implicit return value of last line, but explicitly stated a return. And operator changed, due to precedence issues. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 --- Comment #14 from Marcel de Rooy --- (In reply to M. Tompsett from comment #13) > Created attachment 58533 [details] [review] > Bug 17447: %opt is unused > > Deleted the line. > perlcritic -4 before and after. > Before there are issues. After there is not. > > Also, changed function to not rely on implicit return value > of last line, but explicitly stated a return. And operator > changed, due to precedence issues. > > Signed-off-by: Mark Tompsett Thx Mark. I am sure to have deleted the opt line, but pretty sure now too that i did not commit that last change ;) The change in defnonull is fine with me, but the QAer may also remove it completely. We could just say something like pref(merge) || 0. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17468] Remove koha-*-zebra scripts in favor of koha-zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 --- Comment #7 from Tomás Cohen Arazi --- (In reply to M. Tompsett from comment #6) > Comment on attachment 56702 [details] [review] > Bug 17468: Remove koha-*-zebra scripts and its traces > > Review of attachment 56702 [details] [review]: > - > > Where is koha-zebra? > > ::: debian/koha-common.bash-completion > @@ -132,5 @@ > > > > -# koha-*-zebra autocomplete with enabled instances > > -complete -F _koha_enabled_instances koha-start-zebra > > -complete -F _koha_enabled_instances koha-restart-zebra > > -complete -F _koha_enabled_instances koha-stop-zebra > > Shouldn't this be: > complete -F _koha_enabled_instances koha-zebra > ? > > ::: debian/koha-common.install > @@ -30,5 @@ > > debian/scripts/koha-run-backups usr/sbin > > debian/scripts/koha-shell usr/sbin > > debian/scripts/koha-sitemap usr/sbin > > -debian/scripts/koha-start-zebra usr/sbin > > -debian/scripts/koha-stop-zebra usr/sbin > > Shouldn't there be a: > debian/scripts/koha-zebra usr/sbin > ? Look at the dependencies for this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17468] Remove koha-*-zebra scripts in favor of koha-zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 --- Comment #6 from M. Tompsett --- Comment on attachment 56702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56702 Bug 17468: Remove koha-*-zebra scripts and its traces Review of attachment 56702: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17468&attachment=56702) - Where is koha-zebra? ::: debian/koha-common.bash-completion @@ -132,5 @@ > > -# koha-*-zebra autocomplete with enabled instances > -complete -F _koha_enabled_instances koha-start-zebra > -complete -F _koha_enabled_instances koha-restart-zebra > -complete -F _koha_enabled_instances koha-stop-zebra Shouldn't this be: complete -F _koha_enabled_instances koha-zebra ? ::: debian/koha-common.install @@ -30,5 @@ > debian/scripts/koha-run-backups usr/sbin > debian/scripts/koha-shell usr/sbin > debian/scripts/koha-sitemap usr/sbin > -debian/scripts/koha-start-zebra usr/sbin > -debian/scripts/koha-stop-zebra usr/sbin Shouldn't there be a: debian/scripts/koha-zebra usr/sbin ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255 --- Comment #25 from Nick Clemens --- I finally got ES2 to index and return results in kohadevbox, I found I had to do a few things: I used the two .debs attached here and also installed Catmandu from CPAN In Koha/SearchEngine/Elasticsearch.pm I added the line below just before the return: +push @rules, "move_field(_id,my_id)"; In koha-conf I added at the bottom of the elasticsearch stanza: my_ In koha/SearchEngine/Elasticsearch/Indexer.pm - Catmandu::Importer::MARC->new( records => $records, _id => '999c' ); + Catmandu::Importer::MARC->new( records => $records, id => '999c' ); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 M. Tompsett changed: What|Removed |Added Attachment #58530|0 |1 is obsolete|| --- Comment #12 from M. Tompsett --- Created attachment 58532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58532&action=edit Bug 17447: Remove unused vars from batchRebuildItemsTables.pl Variables $extkey not used, %opt not used. Variables $tmptest[...] not used, calling _build_tag_directory useless. The script now does not only print help if you specify -t. Sub defnonull tidied. Rearranged modules, removed Dumper. Test plan: [1] Run the script with -t flag. The script should not only print usage statement, but should do a dry run. (Test this on a small database, or pass an additional where clause.) Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 M. Tompsett changed: What|Removed |Added Attachment #58528|0 |1 is obsolete|| --- Comment #13 from M. Tompsett --- Created attachment 58533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58533&action=edit Bug 17447: %opt is unused Deleted the line. perlcritic -4 before and after. Before there are issues. After there is not. Also, changed function to not rely on implicit return value of last line, but explicitly stated a return. And operator changed, due to precedence issues. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 M. Tompsett changed: What|Removed |Added Attachment #58529|0 |1 is obsolete|| --- Comment #11 from M. Tompsett --- Created attachment 58531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58531&action=edit Bug 17447: Run perltidy on batchRebuildItemsTables.pl Test plan: Verify that the output of diff -w between the original and tidied file does not introduce code changes. Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 M. Tompsett changed: What|Removed |Added Attachment #58524|0 |1 is obsolete|| --- Comment #10 from M. Tompsett --- Created attachment 58530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58530&action=edit Bug 17447: Remove unused vars from batchRebuildItemsTables.pl Variables $extkey not used, %opt not used. Variables $tmptest[...] not used, calling _build_tag_directory useless. The script now does not only print help if you specify -t. Sub defnonull tidied. Rearranged modules, removed Dumper. Test plan: [1] Run the script with -t flag. The script should not only print usage statement, but should do a dry run. (Test this on a small database, or pass an additional where clause.) Signed-off-by: Marcel de Rooy NOTE: Fixed %opt in my followup. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 M. Tompsett changed: What|Removed |Added Attachment #58523|0 |1 is obsolete|| --- Comment #9 from M. Tompsett --- Created attachment 58529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58529&action=edit Bug 17447: Run perltidy on batchRebuildItemsTables.pl Test plan: Verify that the output of diff -w between the original and tidied file does not introduce code changes. Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447
--- Comment #8 from M. Tompsett ---
Comment on attachment 58528
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58528
Bug 17447: %opt is unused
Review of attachment 58528:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17447&attachment=58528)
-
::: misc/batchRebuildItemsTables.pl
@@ +109,4 @@
>
> sub defnonull {
> my $var = shift;
> +return defined $var && $var ne q{};
This was so I could get perlcritic -4. :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792 --- Comment #12 from Chris Kirby --- (In reply to Tomás Cohen Arazi from comment #11) > The unit tests and functionality introduced by the second patch can only be > tested in conjunction with bug 13757, which adds the opac_editable > attribute. Running the unit tests without 13757 will make the > opac_editable() tests fail. I applied the patch for 1357 on top of 17792. And then ran the updatedatabase.pl script, which errors out as follows: DEV atomic update: bug_17813_borrower_attributes_pk.sql C4:::Installer::load_sql returned the following errors while attempting to load /home/ckirby/koha/installer/data/mysql/atomicupdate/bug_17813_borrower_attributes_pk.sql:" Is it necessary to update DBIx schema files? I could not successfully run the misc/devel/update_dbix_class_files.pl script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 --- Comment #7 from M. Tompsett --- Created attachment 58528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58528&action=edit Bug 17447: %opt is unused Deleted the line. perlcritic -4 before and after. patch will have one less difference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Tomás Cohen Arazi changed: What|Removed |Added Attachment #58526|Attachment to Bug 17828 - |Bug 17828: Unit tests for description|Koha::Patron::Attribute->st |Koha::Patron::Attribute->st |ore should raise an |ore |exception if unique_id is | |being broken| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #2 from Magnus Enger --- Should this be "Needs signoff"? Or is it too early yet? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Tomás Cohen Arazi changed: What|Removed |Added Assignee|gmcha...@gmail.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 58527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58527&action=edit Bug 17828: Overload Koha::Patron::Attribute->store to check for unique_id This patch introduces a Koha::Patron::Attribute->store method that does the required check for the corresponding Koha::Patron::Attribute::Type and raises an exception if trying to store more than one unique attribute. This patch introduces an exception definition for that purpose. To test: - Apply the unit tests patches - Run: $ prove t/db_dependent/Koha/Patron/Attributes.t => FAIL: Tests fail - Apply this patch - Run: $ prove t/db_dependent/Koha/Patron/Attributes.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 58526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58526&action=edit Attachment to Bug 17828 - Koha::Patron::Attribute->store should raise an exception if unique_id is being broken Bug 17828: Unit tests for Koha::Patron::Attribute->store Unit tests for an overloaded Koha::Patron::Attribute->store that checks attribute type's uniqueness property and raises an exception conveniently. Test plan on the implementing patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792 Tomás Cohen Arazi changed: What|Removed |Added Blocks||17828 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 [Bug 17828] Koha::Patron::Attribute->store should raise an exception if unique_id is being broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Tomás Cohen Arazi changed: What|Removed |Added Depends on||17792 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792 [Bug 17792] Introduce Koha::Patron::Attribute(s) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792 --- Comment #11 from Tomás Cohen Arazi --- The unit tests and functionality introduced by the second patch can only be tested in conjunction with bug 13757, which adds the opac_editable attribute. Running the unit tests without 13757 will make the opac_editable() tests fail. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 Hugo Agud changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ha...@orex.es --- Comment #2 from Hugo Agud --- checked and working fine! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16836] Document unused parameters of SearchAuthorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836 Marcel de Rooy changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16836] Document unused parameters of SearchAuthorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Marcel de Rooy --- Time goes by -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #32 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #26 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan, Nick! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent in arbitrary SIP2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826 --- Comment #5 from Kyle M Hall --- I just realized I never added the dependencies! This patch depends on bug 17792, that's probably why you got that error. (In reply to Kyle M Hall from comment #4) > Chris, do you get that error on master alone? It would be worth checking on > because I cannot imagine how this patch would cause an error like that! > > > At step 3, I added a patron (and added values to CODE1, CODE2, and CODE3). > > When I subsequently clicked on the cgi-bin/koha/admin/categories.pl, > > I got the following error: > > > > "Software error: > > > > Template process failed: undef error - round() overflow. Try smaller > > precision or use Math::BigFloat at /home/ckirby/koha/Koha/Number/Price.pm > > line 44. > > > > For help, please send mail to the webmaster ([no address given]), giving > > this error message and the time and date of the error. " -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent in arbitrary SIP2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826 Kyle M Hall changed: What|Removed |Added Depends on||17792 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792 [Bug 17792] Introduce Koha::Patron::Attribute(s) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792 Kyle M Hall changed: What|Removed |Added Blocks||17826 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826 [Bug 17826] Allow extended patron attributes to be sent in arbitrary SIP2 fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17820] Do not use search->next when find can be used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17820 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17762] Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Hugo Agud changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #16 from Hugo Agud --- checked and working fine! Thanks Jonathan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent in arbitrary SIP2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826 --- Comment #4 from Kyle M Hall --- Chris, do you get that error on master alone? It would be worth checking on because I cannot imagine how this patch would cause an error like that! > At step 3, I added a patron (and added values to CODE1, CODE2, and CODE3). > When I subsequently clicked on the cgi-bin/koha/admin/categories.pl, > I got the following error: > > "Software error: > > Template process failed: undef error - round() overflow. Try smaller > precision or use Math::BigFloat at /home/ckirby/koha/Koha/Number/Price.pm > line 44. > > For help, please send mail to the webmaster ([no address given]), giving > this error message and the time and date of the error. " -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17762] Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #15 from Jonathan Druart --- Created attachment 58525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58525&action=edit Bug 17762: Fix sql fields insertion The "Insert ->" buttons used to copy the sql field to the textarea was based on the id of the fieldset. This id has to be unique to work as expected. It is now composed of mtt + lang instead of mtt only -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 Marcel de Rooy changed: What|Removed |Added Summary|Housekeeping: Tidy up |Remove unused vars from |misc/batchRebuildItemsTable |batchRebuildItemsTables.pl |s.pl| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Housekeeping: Tidy up misc/batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 --- Comment #6 from Marcel de Rooy --- Created attachment 58524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58524&action=edit Bug 17447: Remove unused vars from batchRebuildItemsTables.pl Variables $extkey not used, %opt not used. Variables $tmptest[...] not used, calling _build_tag_directory useless. The script now does not only print help if you specify -t. Sub defnonull tidied. Rearranged modules, removed Dumper. Test plan: [1] Run the script with -t flag. The script should not only print usage statement, but should do a dry run. (Test this on a small database, or pass an additional where clause.) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Housekeeping: Tidy up misc/batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 Marcel de Rooy changed: What|Removed |Added Attachment #56578|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 58523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58523&action=edit Bug 17447: Run perltidy on batchRebuildItemsTables.pl Test plan: Verify that the output of diff -w between the original and tidied file does not introduce code changes. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Housekeeping: Tidy up misc/batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 Marcel de Rooy changed: What|Removed |Added CC||mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Housekeeping: Tidy up misc/batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 --- Comment #4 from Marcel de Rooy --- (In reply to M. Tompsett from comment #3) > > my $starttime = gettimeofday; > > my @errors; > > my %opt; > > Is this even used? The first two are used, the third is not. Removing it now too. > Tweaks and whitespace changes should be separate commits to make it easier > to check. So true :) Added a perltidy patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830 --- Comment #4 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #3) > Why not move those encodes to sub _gen_csrf in Token.pm? > Since the source of this problem actually is WWW::CSRF, we could have this > workaround closer to the call. I wanted to provide a quick and safe fix. Moving the encode to Koha::Token would have implied to move the existing ones as well (i.e. more changes). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- Why not move those encodes to sub _gen_csrf in Token.pm? Since the source of this problem actually is WWW::CSRF, we could have this workaround closer to the call. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17762] Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #14 from Hugo Agud --- Thanks to you.. I have applied your test plan and then change the language preference for notices and start again Test plan: - Switch on TranslateNotices - Translate the interface in different languages - Edit patron's details => You should see a new "prefered language" entry That language will be used to send notices to this patron - Edit several notice templates - Now the notice generated for this patron should be the one translated in the language picked for him To confirm that, try to generate several notices for this patron. If the notice is not translated, the default one should be used. Once I finished this with success, I decided to change the 'Preferred language for notices' to ca-ES and I have tested in different ways 1. Execute again the cron scripts for advance and overdue, it generate the letter in the firs language I seleted (es-ES) 2. I checked-in and checked-out again the books, and execute again the cron scripts overudue and advance notice and the letters still in (es-ES) instead of the new (ca-ES) I have restarted memcached and plack and the server just in case.. I hope it helps -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17762] Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #13 from Jonathan Druart --- (In reply to Hugo Agud from comment #12) Hi Hugo, thanks for testing! > I am able to receive the letter in the prefered language, BUT if I change > the prefered language it has no effect on the letter language Can you detail the different steps you made? You should not need to restart plack or memcached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
