[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Patch doesn't apply --- Comment #68 from Jonathan Druart --- fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17725] Repeating a field or subfield clones content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #6 from Jonathan Druart --- (In reply to Josef Moravec from comment #3) > Yes there still remains last occurence of this bug - textareas when clonning > whole field - typically 5xx in MARC21 Fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17725] Repeating a field or subfield clones content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 --- Comment #5 from Jonathan Druart --- Created attachment 58914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58914&action=edit Bug 17725: Same for textarea when cloning a field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7654] Add location at opac subscription view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Jonathan Druart changed: What|Removed |Added QA Contact|jonathan.dru...@bugs.koha-c | |ommunity.org| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #98 from Marcel de Rooy --- QA: Working on this one now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17725] Repeating a field or subfield clones content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 --- Comment #4 from Katrin Fischer --- Something that might be good to test: When an input field contains a lot of text, next time you open the record it will be shown as a textarea. The 5xx seem to always display as a textarea. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Claire Gravely changed: What|Removed |Added Attachment #58890|0 |1 is obsolete|| --- Comment #8 from Claire Gravely --- Created attachment 58913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58913&action=edit Bug 17782 - Patron updated_on field should be set to current timestamp when borrower is deleted To test: 01 Find a patron 02 Get the updated_on value from the db in borrowers table 03 Delete the patron 04 Get the update_on value from the db on deletedborrowers table 05 Values from 02 and 04 are the same 06 Apply patch 07 Repeat 01-04 08 Values should now be different Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Claire Gravely changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 --- Comment #11 from Marcel de Rooy --- (In reply to Josef Moravec from comment #10) > Signed-off-by: Josef Moravec Thanks Josef! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17725] Repeating a field or subfield clones content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||josef.mora...@gmail.com --- Comment #3 from Josef Moravec --- Yes there still remains last occurence of this bug - textareas when clonning whole field - typically 5xx in MARC21 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 Josef Moravec changed: What|Removed |Added Attachment #58877|0 |1 is obsolete|| Attachment #58878|0 |1 is obsolete|| --- Comment #9 from Josef Moravec --- Created attachment 58911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58911&action=edit [SIGNED-OFF] Bug 17273: Add records to modify via shelf or search This patch adds two new ways to add records via two new URL parameters: [1] from_shelf allows you to pass a list number, [2] from_search allows you to pass a search expression. They are added now in the same way as bib_list was done earlier. A future report should incorporate them into the interface. Adding a new method to Virtualshelf along the way. Unit test in followup. Note: I copied the sub _extract_biblionumbers from a new report still in progress. I will move the sub to a module on a new report. Test plan: [1] Pick a list number (you should be allowed to see). And try this URL: /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_shelf=XX where XX obviously is your list number. [2] Pick a search expression that does not generate too much records. And similarly try: /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_search=XX Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 --- Comment #10 from Josef Moravec --- Created attachment 58912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58912&action=edit [SIGNED-OFF] Bug 17273: Add tests for Virtualshelf->list_biblionumbers Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17891] typo in housebound.tt div tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17895] Small typo -'re-set'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 Josef Moravec changed: What|Removed |Added Keywords||Academy CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17896] Enabling syspref 'BakerTaylorEnabled' causes software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Josef Moravec changed: What|Removed |Added Keywords||Academy CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 --- Comment #6 from Josef Moravec --- Created attachment 58910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58910&action=edit [SIGNED-OFF] Bug 17894 - Remove and replace WriteOffFee WriteOffFee is the last of the "payment" subroutines that need to be merged into Koha::Account::pay ( as a writeoff is really just type of payment ). Test Plan: 1) Apply this patch 2) Verify the writeoff, and writeoff all buttons still work Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 Josef Moravec changed: What|Removed |Added Attachment #58883|0 |1 is obsolete|| Attachment #58884|0 |1 is obsolete|| Attachment #58885|0 |1 is obsolete|| --- Comment #4 from Josef Moravec --- Created attachment 58908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58908&action=edit [SIGNED-OFF] Bug 17894 - Update pay() and use it internally for WriteOffFee Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 --- Comment #5 from Josef Moravec --- Created attachment 58909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58909&action=edit [SIGNED-OFF] Bug 17894 - Add unit tests Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #24 from M. Tompsett --- (In reply to Jonathan Druart from comment #23) > (In reply to M. Tompsett from comment #22) > > But they could, if they were onboard'd. See bug 17855 for some enhancement > > dreaming. :) > > Bug 17855 is huge and does not seem to be ready to be pushed. > I'd prefer not to wait for it to get this one in. It is ready for QA now. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #67 from Alex Buckley --- I have retested this bug 17855 and it works as I intend it to do so -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #66 from M. Tompsett --- Squashed first two patches to solve koha qa test tool issue. Ran basic/advanced unimarc/marc combinations. Looks great. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #65 from M. Tompsett --- Created attachment 58907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58907&action=edit Bug 17855 - Removed use:C4/Auth from the onboarding.pl Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What|Removed |Added Attachment #58905|0 |1 is obsolete|| --- Comment #64 from M. Tompsett --- Created attachment 58906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58906&action=edit Bug 17855- Sixth update following testing feedback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What|Removed |Added Attachment #58893|0 |1 is obsolete|| --- Comment #63 from M. Tompsett --- Comment on attachment 58893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58893 Bug 17855- Sixth update following testing feedback. Whitespace fixes generate empty patch from my install. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What|Removed |Added Attachment #58894|0 |1 is obsolete|| --- Comment #62 from M. Tompsett --- Created attachment 58905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58905&action=edit Bug 17855 - Removed use:C4/Auth from the onboarding.pl Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What|Removed |Added Attachment #58901|0 |1 is obsolete|| --- Comment #60 from M. Tompsett --- Created attachment 58903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58903&action=edit Bug 17855 -Fifth update following tester feedback. Implemented Javascript password check to determine if the values in the 'password' and 'confirm password' fields are consistent. If passwords are not consistent a message informing the user is displayed and they only have to change the password values rather than re-fill out the whole form. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What|Removed |Added Attachment #58902|0 |1 is obsolete|| --- Comment #61 from M. Tompsett --- Created attachment 58904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58904&action=edit Bug 17855 - Fixed the errors from the koha qa test Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What|Removed |Added Attachment #58846|0 |1 is obsolete|| --- Comment #54 from M. Tompsett --- Created attachment 58897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58897&action=edit Bug 17855 - Removed html regex on patron password fields. Ran perltidy to indent and space code appropriately. Ran git bz configuration commands to remove whitespace. Removed unnecissary uses in the summary.pl script These changes are based on feedback from testing. Test plan: 1. Go through the web installer and onboarding tool as outlined in this guide: https://koha-community.org/manual/installation/html/ Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What|Removed |Added Attachment #58862|0 |1 is obsolete|| --- Comment #57 from M. Tompsett --- Created attachment 58900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58900&action=edit Bug 17855- Fourth update following testing feedback. Changed button and link names in web installer and onboarding tool Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What|Removed |Added Attachment #58892|0 |1 is obsolete|| --- Comment #59 from M. Tompsett --- Created attachment 58902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58902&action=edit Bug 17855 - Fixed the errors from the koha qa test Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What|Removed |Added Attachment #58886|0 |1 is obsolete|| --- Comment #58 from M. Tompsett --- Created attachment 58901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58901&action=edit Bug 17855 -Fifth update following tester feedback. Implemented Javascript password check to determine if the values in the 'password' and 'confirm password' fields are consistent. If passwords are not consistent a message informing the user is displayed and they only have to change the password values rather than re-fill out the whole form. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What|Removed |Added Attachment #58860|0 |1 is obsolete|| --- Comment #55 from M. Tompsett --- Created attachment 58898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58898&action=edit Bug 17855 - Second update following testing feedback Made arrows in onboarding tool pages -> for consistency. Additionally removed the 'OR' Added the use CGI qw ( -utf8 ); Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What|Removed |Added Attachment #58861|0 |1 is obsolete|| --- Comment #56 from M. Tompsett --- Created attachment 58899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58899&action=edit Bug 17855 -Third update follwing testing feedback Removed the second path to creating a library, patron category, patron, item type, and circulation rule. In onboarding .tt files and summary.tt Fixed typo in summary.tt Made consistent single space before and after -> in all onboarding .tt and summary.tt files. Made single tag before path to create library, patron category, item type, and circulation rule in the onboarding .tt files (patron does not need this as its layout is slightly different) Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What|Removed |Added Attachment #58794|0 |1 is obsolete|| --- Comment #53 from M. Tompsett --- Created attachment 58896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58896&action=edit Finished initial web installer and onboarding tool https://bugs.koha-community.org/show_bug.cgi?id=17855 Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What|Removed |Added Attachment #58792|0 |1 is obsolete|| Attachment #58793|0 |1 is obsolete|| --- Comment #52 from M. Tompsett --- Created attachment 58895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58895&action=edit bug 17855 - Updated web installer finished The onboarding tool has been implemented and integrated with the updated web installer. The onboarding tool has the following functionality: * After the user has finished the web installer they are automatically redirected to the onboarding tool with no authentication in between required * Ability to create library, patron category, patron (set with superlibrarian priviliages), item type and circulation rule. * If the uaser installed sample libraries, patron categories and/or item types then the step to create one in the onboarding tool will be skipped and a skipping message will be displayed. *HTML regxes on all text input fields in all forms in the onboarding tool this prevents the user from writing in special characters *Working date picker on the patron category form Have moved all data values from mandatory to default. Now all default data values are displayed with a bulletpoint rather than a selectable checkbox stopping users from unticking neccisary data values Test plan: 1. Go through the web installer and onboarding tool with the same steps as outlined in this below guide and check that the functionality outlined in the guide exists in the patch: https://koha-community.org/manual/installation/html/ This is a combination of 67 commits. Initial 3 HTML screens of the onboarding tool and the perl onboarding.pl script Note: The advanced setup option has not yet been implemented, so what you will see is just the basic setup. Altered web installer Moved files from optional to mandatory. Edited MARC screen so that MARC21 is selected by default. Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt Changed mandatory to default for MARC values Changed a few file name descriptions to reduce spacing in installer step 3 screen. Changed the radiobuttons to bulletpoints for default settings removed = sign:wq Fixed bug in installer where a loop was created if you're database structure needed to be updated. Redirected this to the marcflavour screen instead of logging straight into Koha and skipping over the basic configuration steps. Changed the bulletpoints to disabled checkboxes which are checked by default Backup of step3.tt Successfully working insertion of the default options which are shown as bulletpoints Removed test text Working insertion of default and optional options Correctly selected default marc flavour of marc21 NOTE: Mark Tompsett merged the first two commits Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #51 from Alex Buckley --- Created attachment 58894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58894&action=edit Bug 17855 - Removed use:C4/Auth from the onboarding.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #50 from Alex Buckley --- Created attachment 58893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58893&action=edit Bug 17855- Sixth update following testing feedback. Changes following errors from qa tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #49 from Alex Buckley --- Created attachment 58892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58892&action=edit Bug 17855 - Fixed the errors from the koha qa test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17896] Enabling syspref 'BakerTaylorEnabled' causes software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17896] Enabling syspref 'BakerTaylorEnabled' causes software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 --- Comment #1 from Aleisha Amohia --- Created attachment 58891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58891&action=edit Bug 17896: Rearranging code in opac-readingrecord.pl so BakerTaylorEnabled works To test: 1) Enable BakerTaylorEnabled and attempt to view reading history in OPAC 2) Notice error 3) Apply patch and refresh page 4) Notice error is gone and page works Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17896] Enabling syspref 'BakerTaylorEnabled' causes software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17896] New: Enabling syspref 'BakerTaylorEnabled' causes software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Bug ID: 17896 Summary: Enabling syspref 'BakerTaylorEnabled' causes software error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: aleishaamo...@hotmail.com QA Contact: testo...@bugs.koha-community.org This error: Undefined subroutine &CGI::Compile::ROOT::home_vagrant_kohaclone_opac_opac_2dreadingrecord_2epl::image_url called at /home/vagrant/kohaclone/opac/opac-readingrecord.pl line 125. is triggered when I enable BakerTaylorEnabled and look at my reading history on the OPAC because subroutines it needs aren't imported until after they are called. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782
--- Comment #7 from Nick Clemens ---
I thought it worked the other way, this is better though :-)
Updated patch
(In reply to Jonathan Druart from comment #5)
> Nick, I did not test, but it does not work that way. If you want DBIx::Class
> to use the default value you must not pass the key.
> So:
> delete $patron_infos->{updated_on};
> should work.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Nick Clemens changed: What|Removed |Added Attachment #58203|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 58890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58890&action=edit Bug 17782 - Patron updated_on field should be set to current timestamp when borrower is deleted To test: 01 Find a patron 02 Get the updated_on value from the db in borrowers table 03 Delete the patron 04 Get the update_on value from the db on deletedborrowers table 05 Values from 02 and 04 are the same 06 Apply patch 07 Repeat 01-04 08 Values should now be different -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17895] Small typo -'re-set'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 Aleisha Amohia changed: What|Removed |Added Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17895] Small typo -'re-set'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17895] Small typo -'re-set'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 --- Comment #1 from Aleisha Amohia --- Created attachment 58889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58889&action=edit Bug 17895: 'Re-set' typo fix To test: 1) Log into OPAC and go to change your password 2) Enter current password incorrectly and click Submit changes 3) Observe error message and typo 're-set' 4) Apply patch and refresh page 5) May be asked to resend data - if so, click Resend, if not, repeat step 2 6) Observe error message and corrected spelling of 'reset' Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17895] New: Small typo -'re-set'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 Bug ID: 17895 Summary: Small typo -'re-set' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: aleishaamo...@hotmail.com QA Contact: testo...@bugs.koha-community.org Triggered when resetting password and current password is entered incorrectly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6507] Renew ALL from self checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6507 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6393] ability to edit staged records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6393 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5784] link to acq from budgets & funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 Aleisha Amohia changed: What|Removed |Added Keywords||Academy CC||aleishaamo...@hotmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Aleisha Amohia changed: What|Removed |Added Attachment #58808|0 |1 is obsolete|| --- Comment #4 from Aleisha Amohia --- Created attachment 5 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5&action=edit Bug 17181: Check for duplicate image names when uploading image to patron card creator This patch adds a check for duplicates before uploading the image. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) If you haven't already, upload an image 3) Try to upload another image with the same image name 4) Notice the first image is replaced with the second image, with no warning. 5) Apply patch and refresh page 6) Try to upload an image with the same image name again 7) Notice you are now warned about a duplicate image name. 8) Check that uploading an image with a unique name still works. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #48 from Alex Buckley --- And thankyou for the note about the comments position, would you like me to change that now or just remember it for future commits? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5272] can't import just patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5272 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com --- Comment #1 from Aleisha Amohia --- Is this still valid? I don't see the patron attributes options as shown in the screenshot. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #47 from Alex Buckley --- I removed the userid javascript validation because it is unnecessary, due to the following reasons: *There is already a html required="required" attribute on this input field *And a html regex on this field Therefore javascript validation is not needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #2 from Aleisha Amohia --- Created attachment 58887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58887&action=edit Bug 4461: Add a context-sensitive 'Report a Problem' feature to OPAC This patch adds a 'Report a problem' link to the bottom of every page in the OPAC. The user can choose to submit their report to the library or Koha administrator. The report will store the user's problem message, but also their username and the page they were on when they clicked the 'report a problem' link. The patch adds a table 'problem_reports' to the db. To test: 1) Apply patch, update database, rebuild schema 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that one of your libraries has an branch email address. 5) Confirm that the syspref KohaAdminEmailAddress has been filled out. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) First try submitting a problem to the library. Confirm that the fields for 'Problem found on page' and 'Username' are correct, then fill out the 'Subject' and 'Message' and click Submit. 9) Confirm a message shows at the top of the page to show success. 10) Go into mysql and display records from the message_queue table. Confirm that the borrowernumber and subject are correct. Confirm that content shows the message from the problem report, but also the user's username and the problem page. Confirm that the to_address shows the library's email address and the from_address shows the user's email address. 11) Now try submitting a problem to the Koha Admin. Fill fields and click Submit. Confirm message shows at top to show success again. 12) Check message_queue for new problem report. Confirm that the to_address shows the email address from the syspref KohaAdminEmailAddress. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Patch complexity|--- |Medium patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855
--- Comment #46 from M. Tompsett ---
Comment on attachment 58886
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58886
Bug 17855 -Fifth update following tester feedback.
Review of attachment 58886:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17855&attachment=58886)
-
This is from my quick eyeball check. Now to test.
::: installer/onboarding.pl
@@ -143,4 @@
> $template->param( itemtypes => $itemtypes, );
> }
> elsif ( $step && $step == 1 ) {
> -my $createlibrary = $input->param('createlibrary'); #Store the inputted
> library branch code and name in $createlibrary variable
Not a biggie, but in the future put comments above, so that perl tidy doesn't
put the semi-colon on the next line which is harder to read.
::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt
@@ -40,5 @@
> -},
> -userid: {
> -required: true;
> -letters_numbers: true
> -},
Why is this removed?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #45 from Alex Buckley --- Created attachment 58886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58886&action=edit Bug 17855 -Fifth update following tester feedback. Implemented Javascript password check to determine if the values in the 'password' and 'confirm password' fields are consistent. If passwords are not consistent a message informing the user is displayed and they only have to change the password values rather than re-fill out the whole form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #45 from Nick Clemens --- (In reply to David Cook from comment #44) > Ah, bug 9580 I'm guessing. > > I really need to look into Coce... ByWater has a coce server that anyone is welcome to use (the more users the more images ready for use) https://coce.bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17752] Fast add record & item with populating fields from Z39.50 with prompts for barcode and patron for ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17752 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9594] order item subfields in framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9594 --- Comment #2 from Marjorie Barry-Vila --- +1 Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7654] Add location at opac subscription view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 --- Comment #23 from Katrin Fischer --- (In reply to M. Tompsett from comment #22) > Comment on attachment 58869 [details] [review] > Bug 7654: Add location at opac subscription view > > Review of attachment 58869 [details] [review]: > - > > Here are some untested thoughts. :) > > ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt > @@ +796,4 @@ > > There are [% subscriptionsnumber %] > > subscription(s) associated with this title. > > [% FOREACH subscription IN subscriptions %] > > [% IF ( subscription.branchcode ) %] > > +At library: [% Branches.GetName( > > subscription.branchcode ) %] > > What if it gets a branch, but someone failed to enter a description or it is > blank? Displaying the branchcode in that case would make sense. I do not > think this correction is correct. That's actually not a problem. The branchcode and branchname are both mandatory. It's not possible to have a branch without a branchname in Koha. Using the TT plugin like this is common in Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7654] Add location at opac subscription view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 --- Comment #22 from M. Tompsett --- Comment on attachment 58869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58869 Bug 7654: Add location at opac subscription view Review of attachment 58869: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7654&attachment=58869) - Here are some untested thoughts. :) ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ +796,4 @@ > There are [% subscriptionsnumber %] > subscription(s) associated with this title. > [% FOREACH subscription IN subscriptions %] > [% IF ( subscription.branchcode ) %] > +At library: [% Branches.GetName( > subscription.branchcode ) %] What if it gets a branch, but someone failed to enter a description or it is blank? Displaying the branchcode in that case would make sense. I do not think this correction is correct. [% at_library = Branches.GetName( subscription.branchcode ) %] [% SET at_library = subscription.branchcode IF at_library.length=0 %] [% IF at_library %] At library: [% at_library ) %] [% END %] @@ -799,5 @@ > -At library: [% Branches.GetName( > subscription.branchname ) %] > -[% ELSE %] > -[% IF ( subscription.branchcode ) %] > -At library: [% > subscription.branchcode %] > -[% END %] I'm pretty sure this code was intending to display a branch name if possible, but if not just the branch code. And clearly, it is wrong about that. @@ +813,5 @@ > [% subscription.opacnote FILTER > html_line_break %] > [% END %] > +[% IF subscription.location_description || > subscription.location %] > +Location: [% IF > subscription.location_description %][% subscription.location_description %][% > ELSE %][% subscription.location %][% END %] > +[% END %] [% location_description = subscription.location_description %] [% SET location_description = subscription.location IF ! defined location_description || location_description.length=0 %] [% IF location_description %] Location: [% location_description %] [% END %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17725] Repeating a field or subfield clones content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Claire Gravely changed: What|Removed |Added CC||claire_grav...@hotmail.com --- Comment #2 from Claire Gravely --- I have been unable to fully replicate the issue, but have found one occurance of an "input" field including content when copied. I have successfully replicated the issue with texarea fields (multiple lines). When testing I find the patch has fixed my single "input" field issue. But the "textarea" field still includes content when cloned. Specifically this was 520 $a. Content is still copying across -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 --- Comment #3 from Kyle M Hall --- Created attachment 58885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58885&action=edit Bug 17894 - Remove and replace WriteOffFee WriteOffFee is the last of the "payment" subroutines that need to be merged into Koha::Account::pay ( as a writeoff is really just type of payment ). Test Plan: 1) Apply this patch 2) Verify the writeoff, and writeoff all buttons still work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 --- Comment #2 from Kyle M Hall --- Created attachment 58884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58884&action=edit Bug 17894 - Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 --- Comment #1 from Kyle M Hall --- Created attachment 58883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58883&action=edit Bug 17894 - Update pay() and use it internally for WriteOffFee -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 Kyle M Hall changed: What|Removed |Added Blocks||15894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 [Bug 15894] Unify all account fine payment functions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15894] Unify all account fine payment functions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 Kyle M Hall changed: What|Removed |Added Depends on||17894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 [Bug 17894] Remove and Replace WriteOffFee -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17894] New: Remove and Replace WriteOffFee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 Bug ID: 17894 Summary: Remove and Replace WriteOffFee Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org WriteOffFee is the last of the "payment" subroutines that need to be merged into Koha::Account::pay ( as a writeoff is really just a special case payment ). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5250] Various enhancements to web based checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5250 Agnes Rivers-Moore changed: What|Removed |Added CC||a...@hanover.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16732] Add audio alerts (custom sound notifications) to web based self checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732 Agnes Rivers-Moore changed: What|Removed |Added CC||a...@hanover.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17449] Let users choose action in self checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17449 Agnes Rivers-Moore changed: What|Removed |Added CC||a...@hanover.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17381] Add system preference SCOUserHTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 --- Comment #2 from Agnes Rivers-Moore --- I would love this option! Just setting up SCO and noted the need for a bit more user interface on screen help. It could be Library specific, so an HTML section would be very useful. I have help until end March 2017 - if anyone has time to introduce him to the code used we might be able to contribute, or to test. I would also like to change the text of the Print prompt - Cancel or OK is not very helpful in answer to "Do you want to print?" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17381] Add system preference SCOUserHTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Agnes Rivers-Moore changed: What|Removed |Added CC||a...@hanover.ca --- Comment #1 from Agnes Rivers-Moore --- I would love this - just setting up SCO and noted the need for a bit more on screen help. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13146] Improve GetRecordValue function by caching field mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146
--- Comment #8 from M. Tompsett ---
Comment on attachment 44132
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44132
Bug 13146 UT
Review of attachment 44132:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13146&attachment=44132)
-
Test::DBIx::Class isn't required to run Koha, just the tests, correct? Probably
should skip tests we know we can't run. This will run fine on kohadevbox, but
not necessarily on another users koha git box.
::: t/db_dependent/FieldMapping.t
@@ +21,5 @@
> +use File::Basename;
> +use File::Path;
> +use DateTime;
> +use Test::MockModule;
> +use Test::More tests => 18;
Just use Test::More; because of suggested change below.
@@ +25,5 @@
> +use Test::More tests => 18;
> +use C4::Biblio;
> +use Koha::Schema;
> +
> +
use Module::Load::Conditional qw/check_install/;
BEGIN {
if ( check_install( module => 'Test::DBIx::Class' ) ) {
plan tests => 18; # or is it 19... whatever works.
} else {
plan skip_all => "Need Test::DBIx::Class"
}
}
@@ +43,5 @@
> +_new_schema => sub { return Schema(); }
> +);
> +
> +
> +if (0) {
What is the point of keeping the code, if it isn't run?
@@ +55,5 @@
> +}
> +
> +
> +SetFieldMapping('', 'maintitle', '245', 'a');
> +ok my $fm = Fieldmapping->find( {field => 'maintitle'} )
Multiple side-effects on the same line of code is more difficult to read.
@@ +56,5 @@
> +
> +
> +SetFieldMapping('', 'maintitle', '245', 'a');
> +ok my $fm = Fieldmapping->find( {field => 'maintitle'} )
> + => 'maintitle field mapping properly set for default framework';
While this is valid, given that you did the simpler version of is() below,
could this not be:
my $fm = Fieldmapping->find( {field => 'maintitle'} );
ok( defined $fm, 'maintitle field mapping properly set for default framework');
instead? This is more readable.
@@ +60,5 @@
> + => 'maintitle field mapping properly set for default framework';
> +
> +SetFieldMapping('', 'subtitle', '245', 'b');
> +ok $fm = Fieldmapping->find( {field => 'subtitle'} )
> + => 'subtitle field mapping properly set for default framework';
same here.
@@ +70,5 @@
> +}, 'expected fields are there';
> +
> +SetFieldMapping('BOOK', 'subtitle', '245', 'b');
> +ok $fm = Fieldmapping->find( {frameworkcode => 'BOOK', field => 'subtitle'} )
> + => 'subtitle field mapping properly set for BOOK framework';
same here.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17418] Move staff client home page JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Owen Leonard changed: What|Removed |Added Blocks||17893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 [Bug 17893] Move JavaScript to the footer on staff client catalog pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Owen Leonard changed: What|Removed |Added Blocks||17893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 [Bug 17893] Move JavaScript to the footer on staff client catalog pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17893] New: Move JavaScript to the footer on staff client catalog pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Bug ID: 17893 Summary: Move JavaScript to the footer on staff client catalog pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: claire_grav...@hotmail.com, jonathan.dru...@bugs.koha-community.org, testo...@bugs.koha-community.org Depends on: 17870, 17418 Blocks: 17858 This patch will move JavaScript to the footer on a number of pages in the catalog module of the staff client: basket/basket.tt catalogue/ISBDdetail.tt catalogue/MARCdetail.tt catalogue/advsearch.tt catalogue/detail.tt catalogue/imageviewer.tt catalogue/issuehistory.tt catalogue/itemsearch.tt catalogue/labeledMARCdetail.tt catalogue/moredetail.tt catalogue/results.tt catalogue/search-history.tt In the process I will be consolidating JS from several of those templates into one separate JavaScript file. Other modifications will be required in order for JavaScript to be able to be called from catalog-related include files. Since include files are parsed before jQuery is loaded in the footer, jQuery-specific code will have to be adapted or moved. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 [Bug 17418] Move staff client home page JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 [Bug 17870] Call to include file incorrectly moved into the footer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Owen Leonard changed: What|Removed |Added Depends on||17893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 [Bug 17893] Move JavaScript to the footer on staff client catalog pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Tomás Cohen Arazi changed: What|Removed |Added Depends on|17813 |17234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 [Bug 17813] Table borrower_attributes needs a primary key -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 Tomás Cohen Arazi changed: What|Removed |Added Blocks||14187 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 Tomás Cohen Arazi changed: What|Removed |Added Blocks|14187 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 Tomás Cohen Arazi changed: What|Removed |Added Depends on||17234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 Tomás Cohen Arazi changed: What|Removed |Added Blocks||17813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 [Bug 17813] Table borrower_attributes needs a primary key -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Tomás Cohen Arazi changed: What|Removed |Added Depends on||17813 CC||tomasco...@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 [Bug 17813] Table borrower_attributes needs a primary key -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 Tomás Cohen Arazi changed: What|Removed |Added Blocks||14187 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Tomás Cohen Arazi changed: What|Removed |Added Attachment #58880|0 |1 is obsolete|| --- Comment #19 from Tomás Cohen Arazi --- Created attachment 58882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58882&action=edit Bug 14187: (QA followup) Properly check DB structure before altering it Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Tomás Cohen Arazi changed: What|Removed |Added Attachment #58730|0 |1 is obsolete|| --- Comment #18 from Tomás Cohen Arazi --- Created attachment 58881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58881&action=edit Bug 14187: branchtransfer needs a primary key (id) for DBIx and common sense. * C4/Circulation.pm (GetTransfers, GetTransfersFromTo): Also return branchtransfer_id in return columns. * installer/data/mysql/atomicupdate/14187.perl: New file. * installer/data/mysql/kohastructure.sql: Modify branchtransfers structure. * t/db_dependent/Circulation/transfers.t: Update tests to expect branchtransfer_id. Signed-off-by: Owen Leonard Test plan successful on all steps. Signed-off-by: Jonathan Druart Amended patch: Remove Schema changes from this patch Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 58880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58880&action=edit Bug 14187: (QA followup) Properly check DB structure before altering it Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 --- Comment #7 from Olli-Antti Kivilahti --- I am not sure that separating them to separate bugs is the correct solution here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 --- Comment #6 from Olli-Antti Kivilahti --- Any suggestions for the title of the new refactorings bug? It is all closely related to this if you take a loot at the tests. Refactorings have been done so I can test this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
