[Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Blocks||17897


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897
[Bug 17897] Koha::SearchMappingManager - Simplify search mapping modifications
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Blocks|17897   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897
[Bug 17897] Koha::SearchMappingManager - Simplify search mapping modifications
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17897] Koha:: SearchMappingManager - Simplify search mapping modifications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Depends on|17855   |17885


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855
[Bug 17855] Updated Koha web installer and new onboarding tool feature to guide
users through setting up Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885
[Bug 17885] Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings
throws DBD::mysql Duplicate entry exceptions
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #125 from Marcel de Rooy  ---
Last comments:

> Changes in Koha/OAI/Server/ListRecords.pm is planned on bug 15108.
Failed QA several weeks ago. The author did not respond until now.

[OK] t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
[OK] t/db_dependent/Holds/HoldFulfillmentPolicy.t
[OK] t/db_dependent/Holds/HoldItemtypeLimit.t
[OK} t/db_dependent/HoldsQueue.t
[OK] t/db_dependent/UsageStats.t  
[OK] t/db_dependent/Members/GetAllIssues.t
[OK] t/db_dependent/Items.t
[OK] t/ImportBatch.t
[OK] t/db_dependent/OAI/Server.t
[OK] t/db_dependent/Record/Record.t
[OK] t/db_dependent/Record.t
[OK] t/db_dependent/Search.t
[OK] t/db_dependent/Acquisition/GetOrdersByBiblionumber.t
[OK] t/db_dependent/Acquisition/TransferOrder.t

misc/migration_tools/koha-svc.pl: Did not verify it this still works.
koha-svc.pl http://koha-dev:8080/cgi-bin/koha/svc svc-user svc-password
$biblionumber [bib-42.xml]
Did not check REST API.

Well finally, we know about Reports. Should we still warn somewhere about that
?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #123 from Marcel de Rooy  ---
Created attachment 58946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58946=edit
Bug 17196: [QA Follow-up] Adjust some text on marcxml

No code changes here, just text.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #124 from Marcel de Rooy  ---
Created attachment 58947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58947=edit
Bug 17196: [QA Follow-up] Additional fix on acqui/basketgroup

acqui/basketgroup calls GetOrders and expects marcxml in the results.
Fixing it by an additional call of GetXmlBiblio.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17725] Repeating a field or subfield clones content

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17725] Repeating a field or subfield clones content

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725

Nick Clemens  changed:

   What|Removed |Added

  Attachment #58916|0   |1
is obsolete||

--- Comment #12 from Nick Clemens  ---
Created attachment 58945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58945=edit
Bug 17725: Same for textarea when cloning a field

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17725] Repeating a field or subfield clones content

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725

Nick Clemens  changed:

   What|Removed |Added

  Attachment #58915|0   |1
is obsolete||

--- Comment #11 from Nick Clemens  ---
Created attachment 58944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58944=edit
Bug 17725: Do not copy subfield's content when cloning

To replicate:
- Open an existing record in your catalog
- Create another field or subfield of a field/subfield already used using the
icon to repeat it
- Verify that the content is copied over
- Verify this happens for input (one line) and textare (multiple lines)

I can't make this happen for when creating a new record, but more consistently
on editing existing records.

This is rather annoying when cataloguing in Koha, as the cataloguer has to
empty the field first and that adds an extra step for each repeated field.

Test plan:
Confirm than the content is not copied when you clone a field or a subfield.

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58939|0   |1
is obsolete||

--- Comment #122 from Marcel de Rooy  ---
Created attachment 58943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58943=edit
Bug 17196: Remove occurrence of marcxml in columns.def

Also remove a wrong ref to the marc column

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6710] lists of lists in Alpha order

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6710

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17897] Koha:: SearchMappingManager - Simplify search mapping modifications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #2 from Olli-Antti Kivilahti  ---
Test plan is to run the elasticsearch-dependent tests in t/db_dependent/Koha*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17897] Koha:: SearchMappingManager - Simplify search mapping modifications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Depends on||17855


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855
[Bug 17855] Updated Koha web installer and new onboarding tool feature to guide
users through setting up Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Blocks||17897


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897
[Bug 17897] Koha::SearchMappingManager - Simplify search mapping modifications
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17897] Koha:: SearchMappingManager - Simplify search mapping modifications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897

--- Comment #1 from Olli-Antti Kivilahti  ---
Created attachment 58942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58942=edit
Bug 17897 - Koha::SearchMappingManager - Simplify search mapping modifications

Currently there is a lot of DBIC-magic everywhere where search mappings
(search_fields, search_marc_to_field, search_marc_map -tables) are CRUD:ed.

Encapsulate this hard-to-read DBIC-magic into a Manager class which promotes
code-reusability and thus, simpler test case writing.

Includes tests for Buug 17885

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #58940|0   |1
is obsolete||

--- Comment #9 from Olli-Antti Kivilahti  ---
Created attachment 58941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58941=edit
Bug 17885 - Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings
throws DBD::mysql Duplicate entry exceptions

When executing
Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings()
against populated search engine mappings tables, one gets this exception:

DBD::mysql::st execute failed: Duplicate entry '388-73' for key 'PRIMARY'
[for Statement \"INSERT INTO `search_marc_to_field` ( `facet`,
`search_field_id`,
 `search_marc_map_id`, `sort`, `suggestible`) VALUES ( ?, ?, ?, ?, ? )\" with
ParamValues:
0='', 1='73', 2='388', 3=undef, 4=''] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm
line 1834.\nDBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '388-73'
for key
'PRIMARY' at /home/koha/Koha/Koha/SearchField.pm line 38"

This patch fixes this, by first deleting all entries, then adding the default
ones.

If a subroutine says reset_elasticsearch_mappings(), I expect it to reset the
elasticsearch
mappings without errors.
When writing tests it is better to call that one subroutine
reset_elasticsearch_mappings
instead of the bunch of code in
admin/searchengine/elasticsearch/mappings.pl?op=reset_know_what_i_am_doing=1
Also this promotes code reuse.

TEST PLAN:

a. perl -e 'use Koha::SearchEngine::Elasticsearch;
Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings'
b. Run misc/devel/populate_db.pl on an already populated DB and you eventually
face this problem.

After this patch,
step a. works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #58825|0   |1
is obsolete||

--- Comment #8 from Olli-Antti Kivilahti  ---
Created attachment 58940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58940=edit
Bug 17885 - Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings
throws DBD::mysql Duplicate entry exceptions

When executing
Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings()
against populated search engine mappings tables, one gets this exception:

DBD::mysql::st execute failed: Duplicate entry '388-73' for key 'PRIMARY'
[for Statement \"INSERT INTO `search_marc_to_field` ( `facet`,
`search_field_id`,
 `search_marc_map_id`, `sort`, `suggestible`) VALUES ( ?, ?, ?, ?, ? )\" with
ParamValues:
0='', 1='73', 2='388', 3=undef, 4=''] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm
line 1834.\nDBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '388-73'
for key
'PRIMARY' at /home/koha/Koha/Koha/SearchField.pm line 38"

This patch fixes this, by first deleting all entries, then adding the default
ones.

If a subroutine says reset_elasticsearch_mappings(), I expect it to reset the
elasticsearch
mappings without errors.
When writing tests it is better to call that one subroutine
reset_elasticsearch_mappings
instead of the bunch of code in
admin/searchengine/elasticsearch/mappings.pl?op=reset_know_what_i_am_doing=1
Also this promotes code reuse.

TEST PLAN:

a. perl -e 'use Koha::SearchEngine::Elasticsearch;
Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings'
b. Run misc/devel/populate_db.pl on an already populated DB and you eventually
face this problem.

After this patch,
step a. works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17897] New: Koha:: SearchMappingManager - Simplify search mapping modifications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897

Bug ID: 17897
   Summary: Koha::SearchMappingManager - Simplify search mapping
modifications
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org

Currently there is a lot of DBIC-magic everywhere where search mappings
(search_fields, search_marc_to_field, search_marc_map -tables) are CRUD:ed.

Encapsulate this hard-to-read DBIC-magic into a Manager class which promotes
code-reusability and thus, simpler test case writing.

Includes tests for Bug 17885

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775

Jonathan Druart  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com

--- Comment #3 from Jonathan Druart  
---
Is anybody interested in fixing this bad bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #9 from Jonathan Druart  
---
Please provide tests (t/db_dependent/Koha/Patrons.t -> move_to_deleted).
Note that at one test does not pass on my devbox:

#   Failed test 'Koha::Patron->move_to_deleted should have correctly moved
the patron to the deleted table'
#   at t/db_dependent/Koha/Patrons.t line 331.
# Structures begin differing at:
#  $got->{updated_on} = '2017-01-13 11:42:27'
# $expected->{updated_on} = '2017-01-13 10:42:26'

system date is 2017-01-13 11:42:27
I do not understand what's going on actually.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Hugo Agud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ha...@orex.es

--- Comment #63 from Hugo Agud  ---
I have tested the patch and it works, BUT I am still learning and I do not know
how to create the signed patch, sorry

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #121 from Jonathan Druart  
---
Created attachment 58939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58939=edit
Bug 17196: Remove occurrence of marcxml in columns.def

Also remove a wrong ref to the marc column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty subfield tag [follow-up ]

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17725
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17725] Repeating a field or subfield clones content

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17818

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #120 from Marcel de Rooy  ---
dmin -> admin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #119 from Marcel de Rooy  ---
> C4/Items.pm: changes aimed for catalogue/itemsearch.pl, but I am not sure if
> they are needed. Does item search actually looks into the xml? Seems not.
> New report??

So that is wrong. You can do it via dmin/items_search_fields.pl.
Works fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #118 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #117)
> > C4/Items.pm: changes aimed for catalogue/itemsearch.pl, but I am not sure if
> > they are needed. Does item search actually looks into the xml? Seems not.
> > New report??
> 
> I don't think so, it uses it.

See C4::Items::_SearchItems_build_where_fragment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #117 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #116)
> Some preliminary findings:
> 
> opac/opac-readingrecord.pl: Calling GetXmlBiblio seems useless here.
> Probably should be GetMarcBiblio.

GetMarcBiblio does much more stuffs than GetXmlBiblio. Since we just want the
metadata it's better like that.

> opac-search.pl: map { (C4::Context->config('zebra_bib_index_mode') eq
> 'dom')? $_->{marcxml}: $_->{marc}; }  This marc reference should not have
> been there anymore?

Nope, the column does no longer exist.

> C4/Items.pm: changes aimed for catalogue/itemsearch.pl, but I am not sure if
> they are needed. Does item search actually looks into the xml? Seems not.
> New report??

I don't think so, it uses it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #116 from Marcel de Rooy  ---
Some preliminary findings:

opac/opac-readingrecord.pl: Calling GetXmlBiblio seems useless here. Probably
should be GetMarcBiblio.
opac-search.pl: map { (C4::Context->config('zebra_bib_index_mode') eq 'dom')?
$_->{marcxml}: $_->{marc}; }  This marc reference should not have been there
anymore?
C4/Items.pm: changes aimed for catalogue/itemsearch.pl, but I am not sure if
they are needed. Does item search actually looks into the xml? Seems not. New
report??

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58517|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #115 from Marcel de Rooy  ---
Still working on it little bit, but looks good. Please wait..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #111 from Marcel de Rooy  ---
Created attachment 58935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58935=edit
Bug 17196: [QA Follow-up] Correct POD in ILSDI/Services.pm

QA tools complains about:
Apparent command =cut not preceded by blank line.

Trivial fix.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #112 from Marcel de Rooy  ---
Created attachment 58936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58936=edit
Bug 17196: [QA Follow-up] DBIx schema changes

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58516|0   |1
is obsolete||

--- Comment #109 from Marcel de Rooy  ---
Created attachment 58933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58933=edit
Bug 17196: Fix delete_records_via_leader.pl

Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #113 from Marcel de Rooy  ---
Created attachment 58937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58937=edit
Bug 17196: [QA Follow-up] Wrong module in Record.t

Should be the singular version instead of the plural one.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58514|0   |1
is obsolete||

--- Comment #108 from Marcel de Rooy  ---
Created attachment 58932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58932=edit
Bug 17196: Update POD of sanitise_records.pl

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #114 from Marcel de Rooy  ---
Created attachment 58938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58938=edit
Bug 17196: [QA Follow-up] Missing unique key in kohastructure

See the atomic update.

Signed-off-by: Marcel de Rooy 
Tested on command line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #110 from Marcel de Rooy  ---
Created attachment 58934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58934=edit
Bug 17196 - (QA Followup) Use items from Koha::Biblio

Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 
Amended: Using items from Koha::Biblio seems better :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58513|0   |1
is obsolete||

--- Comment #107 from Marcel de Rooy  ---
Created attachment 58931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58931=edit
Bug 17196: Fix build_oai_sets.pl

The wrong value was retrieved.

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58511|0   |1
is obsolete||

--- Comment #105 from Marcel de Rooy  ---
Created attachment 58929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58929=edit
Bug 17196: Fix - Update metadata on update

Signed-off-by: Mason James 

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58512|0   |1
is obsolete||

--- Comment #106 from Marcel de Rooy  ---
Created attachment 58930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58930=edit
Bug 17196: follow-up for bug 17088

If bug 17088 is pushed first, we will need this patch.

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58510|0   |1
is obsolete||

--- Comment #104 from Marcel de Rooy  ---
Created attachment 58928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58928=edit
Bug 17196: Simplify tests for the different marc flavours

centralize the way MARC field are set.

Signed-off-by: Mason James 

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58507|0   |1
is obsolete||

--- Comment #101 from Marcel de Rooy  ---
Created attachment 58925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58925=edit
Bug 17196: Update misc/maintenance/sanitize_records.pl

Test plan:
Use the sanitize_records.pl maintenance script with the --auto-search
option

Signed-off-by: Mason James 

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58509|0   |1
is obsolete||

--- Comment #103 from Marcel de Rooy  ---
Created attachment 58927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58927=edit
Bug 17196: DB Changes

Remove biblioitems.marcxml and deletedbiblioitems.marcxml
and adds 2 table biblio_metadata and deletedbiblio_metadata

Signed-off-by: Mason James 

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58508|0   |1
is obsolete||

--- Comment #102 from Marcel de Rooy  ---
Created attachment 58926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58926=edit
Bug 17196: Update switch_marc21_series_info.pl

Not sure if this script is still used, could someone confirm?

Test plan:
If you know how to test it, please do

Signed-off-by: Mason James 

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58505|0   |1
is obsolete||

--- Comment #99 from Marcel de Rooy  ---
Created attachment 58923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58923=edit
Bug 17196: Move marcxml out of the biblioitems table

Two discussions on koha-devel lead to the same conclusion:
biblioitems.marcxml should be moved out this table
- biblio and biblioitems
http://lists.koha-community.org/pipermail/koha-devel/2013-April/039239.html
- biblioitems.marcxml & biblioitems.marc / HUGE performance issue !
http://lists.koha-community.org/pipermail/koha-devel/2016-July/042821.html

There are several goals to do it:
- Performance
As Paul Poulain wrote, a simple query like
  SELECT publicationyear, count(publicationyear) FROM biblioitems GROUP BY
publicationyear;
takes more than 10min on a DB with more than 1M bibliographic records
but only 3sec (!) on the same DB without the biblioitems.marcxml field
Note that priori to this patch set, the biblioitems.marcxml was not
retrieved systematically, but was, at least, in
C4::Acquisition::GetOrdersByBiblionumber and C4::Acquisition::GetOrders
- Flexibility
Storing the marcxml in a specific table would allow use to store several
kind of metadata (USMARC, MARCXML, MIJ, etc.) and different formats
(marcflavour)
- Clean code
It would be a first step toward Koha::MetadataRecord for bibliographic
records (not done in this patch set).

Test plan:
- Update the DBIC Schema
- Add / Edit / Delete / Import / Export bibliographic records
- Add items
- Reindex records using ES
- Confirm that the following scripts still work:
* misc/cronjobs/delete_records_via_leader.pl
* misc/migration_tools/build_oai_sets.pl
- Look at the reading history at the OPAC (opac-readingrecord.pl)
- At the OPAC, click on a tag, you must see the result

Note: Changes in Koha/OAI/Server/ListRecords.pm is planned on bug 15108.

Signed-off-by: Mason James 

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 
Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58506|0   |1
is obsolete||

--- Comment #100 from Marcel de Rooy  ---
Created attachment 58924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58924=edit
Bug 17196: Fix query builder for item search

The item search needs to join on biblio_metadata to allow search on
marcxml field

Test plan:
Launch complex item searches (using marc fields).

Signed-off-by: Mason James 

Signed-off-by: Josef Moravec 
Signed-off-by: Zeno Tajoli 

Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181

--- Comment #7 from Jonathan Druart  
---
Created attachment 58922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58922=edit
Bug 17181: Simplify code

- do not prepare statement when used only once
- remove use of Data::Dumper
- remove $duplicate, not needed

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58917|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 58921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58921=edit
Bug 17181: Check for duplicate image names when uploading image to patron card
creator

This patch adds a check for duplicates before uploading the image.

To test:
1) Go to Tools -> Patron card creator -> Manage images
2) If you haven't already, upload an image
3) Try to upload another image with the same image name
4) Notice the first image is replaced with the second image, with no
warning.
5) Apply patch and refresh page
6) Try to upload an image with the same image name again
7) Notice you are now warned about a duplicate image name.
8) Check that uploading an image with a unique name still works.

Sponsored-by: Catalyst IT
Signed-off-by: Claire Gravely 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

--- Comment #14 from Jonathan Druart  
---
Created attachment 58919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58919=edit
Bug 17680: C4::Circulation - Remove GetItemIssue

This patch simply removes the C4::Circulation::GetItemIssue subroutine

Test plan:
At this point, `git grep GetItemIssue` should not return any occurrence
in the codebase

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

--- Comment #15 from Jonathan Druart  
---
Created attachment 58920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58920=edit
Bug 17680: C4::Circulation - Remove GetItemIssue, complex calls

There are a few calls to GetItemIssue where it's not as easy to make
sure everything will be fine just replacing the calls with a
Koha::Issues->find
- In AddReturn the overdue flag is used (that's why this patch depends
on bug 17689)
- In CanBookBeRenewed, as well as the overdue flag the dates converted
to DateTime were used. It's now our job to convert them when we need
them.
- Same in AddRenewal but we also call _CalculateAndUpdateFine, so we
need to update the variables in this subroutine.

Note that, prior to this patch, AddReturn returned the GetItemIssue
hashref in the $iteminformation. Most of the time this variable is not
used, I have found only 1 place where it's used: circ/returns.pl
TODO: In this script we should call ->is_overdue instead of the
DateTime->compare calls

Test plan:
All the circulation tests must pass (it's how I have caught the specific
cases).
Do some checkins/checkouts/renewal and focus on the due date

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58431|0   |1
is obsolete||
  Attachment #58433|0   |1
is obsolete||
  Attachment #58501|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 58918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58918=edit
Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls

C4::Circulation::GetItemIssue returned all the issue and item
informations for a given issue. Moveover it also did some date
manipulations. Most of the time this subroutine was called, there
additional information were useless as the caller usually just needed
the basic issue's infos 'from the issue table).

This first patch updates the simple calls, ie. the ones that just need
the issue's infomations.

Test plan:
The following operations should success:
- transfer a book
- create a rule for on-site checkouts and confirm that a patron cannot
check more items out that it's defined in the rule.
- Renew an issue using ILSDI
- Using SIP confirm that you are able to see your issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org
 Status|Signed Off  |Failed QA

--- Comment #70 from Jonathan Druart  
---
Hi Alex,
This looks great, good job!

In my opinion, this is not ready yet to be pushed.
I have a few questions and remarks:

1/ I have tried the basic and advanced mode, the only difference I noticed is
that checkboxes do not appear on the next screen.
If it is the only difference, I do not see the point of that parameter.

2/ Before your patch, the "Select all options" was a button. It was intended
and is the correct element to use

3/ When all the default data are select, we get pages saying "there is nothing
to do because the data are already inserted". I think it would be better to
skip these screen and not to see them at all.

4/ The forms are not using the usual Koha style

5/ About the circulation rule, how did you pick the value to define?
For instance "Current on-site checkouts allowed" is not configurable and the
default value becomes "unlimited". I do not think it is the desirable behavior.

6/ I would suggest to add an option to skip the onboarding Should be an option,
we need a way to skip it

7/ At the end of the installer, the button "finish" has been replaced with "set
koha version system preference". The wording sounds wrong.

Maybe we need to have 2 choices at that point:
- Set up Koha with the onboarding tool
- Finish (and skip the onboarding tool)

8/ Cardnumber:
>From the template you use "minlength_cardnumber", but it's not pass from the
script (I may missed something).
The behavior of the validation is not correct, a cardnumber can be composed
with alpha chars.

I think it would be good to get Owen point of views about this change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181

Claire Gravely  changed:

   What|Removed |Added

  Attachment #5|0   |1
is obsolete||

--- Comment #5 from Claire Gravely  ---
Created attachment 58917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58917=edit
Bug 17181: Check for duplicate image names when uploading image to patron card
creator

This patch adds a check for duplicates before uploading the image.

To test:
1) Go to Tools -> Patron card creator -> Manage images
2) If you haven't already, upload an image
3) Try to upload another image with the same image name
4) Notice the first image is replaced with the second image, with no
warning.
5) Apply patch and refresh page
6) Try to upload an image with the same image name again
7) Notice you are now warned about a duplicate image name.
8) Check that uploading an image with a unique name still works.

Sponsored-by: Catalyst IT
Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17725] Repeating a field or subfield clones content

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725

--- Comment #10 from Katrin Fischer  ---
(In reply to Josef Moravec from comment #9)
> (In reply to Katrin Fischer from comment #4)
> > Something that might be good to test: When an input field contains a lot of
> > text, next time you open the record it will be shown as a textarea. The 5xx
> > seem to always display as a textarea.
> 
> Tested, and looks fine

Thx, Josef!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #12 from Josef Moravec  ---
could you rebase please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58906|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #69 from Jonathan Druart  
---
Ok, fixed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17725] Repeating a field or subfield clones content

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58867|0   |1
is obsolete||
  Attachment #58914|0   |1
is obsolete||

--- Comment #7 from Josef Moravec  ---
Created attachment 58915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58915=edit
[SIGNED-OFF] Bug 17725: Do not copy subfield's content when cloning

To replicate:
- Open an existing record in your catalog
- Create another field or subfield of a field/subfield already used using the
icon to repeat it
- Verify that the content is copied over
- Verify this happens for input (one line) and textare (multiple lines)

I can't make this happen for when creating a new record, but more consistently
on editing existing records.

This is rather annoying when cataloguing in Koha, as the cataloguer has to
empty the field first and that adds an extra step for each repeated field.

Test plan:
Confirm than the content is not copied when you clone a field or a subfield.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17725] Repeating a field or subfield clones content

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725

--- Comment #9 from Josef Moravec  ---
(In reply to Katrin Fischer from comment #4)
> Something that might be good to test: When an input field contains a lot of
> text, next time you open the record it will be shown as a textarea. The 5xx
> seem to always display as a textarea.

Tested, and looks fine

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17725] Repeating a field or subfield clones content

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725

--- Comment #8 from Josef Moravec  ---
Created attachment 58916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58916=edit
[SIGNED-OFF] Bug 17725: Same for textarea when cloning a field

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17725] Repeating a field or subfield clones content

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/