[Koha-bugs] [Bug 17380] Cannot edit authorities with authtypecode = default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Attachment #55947|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17380] Cannot edit authorities with authtypecode = default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Marcel de Rooy changed: What|Removed |Added Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl Status|NEW |ASSIGNED Version|16.05 |master --- Comment #2 from Marcel de Rooy --- Confirm the problem. Small fix coming -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #57 from Jonathan Druart --- Kyle, I did not write the different failures because most of them are obvious: 1. There are no tests 2. CamelCase instead of snake_case for methods of Koha::Clubs and Koha::Patron 3. GetClubEnrollmentsCount and GetEnrollableClubsCount are not needed, just call ->count 4. You should not need to add GetBranches to the Branches TT plugin. Take a look at options_for_libraries 5. Subroutine added to Koha TT plugin (UserEnv), but not used. 6. Changes to circ/circulation.pl are not needed. A variable 'patron' is already passed to the template. 7. All the labels of the form has the same value for the "for" attribute. 8. Tables on clubs/clubs.pl are ugly (missing datatables.css?) 9. On /clubs/clubs-add-modify.pl?club_template_id=1, there is an empty input at the end of the form. 8. CGI->param must not be called in scalar context 9. When I save a form, I get "Your club was created" with a link to "Return to patron clubs". That sounds weird. Especially because the box is yellow. I'd suggest to behave as everywhere else in Koha: Save and get the list. I guess it's because there are too many small scripts, maybe it would have been easier to have a bigger one and have the different action handled in it (as everywhere else in admin scripts). 10. INSERT statements should have IGNORE in update db process 11. + `branchcode` varchar(10) COLLATE utf8_unicode_ci NULL DEFAULT NULL, you should not need to specify the COLLATE here. 12. QA tests do not pass FAIL Koha/Patron.pm FAIL forbidden patterns forbidden pattern: merge marker (>>>) (line 647) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15108] OAI-PMH provider improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Status|Signed Off |Failed QA --- Comment #82 from Julian Maurice --- The tests fail for me: 1. If I have data in the issues table I get an error : > DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key > constraint fails (`koha`.`issues`, CONSTRAINT `issues_ib fk_2` FOREIGN KEY > (`itemnumber`) REFERENCES `items` (`itemnumber`) ON UPDATE CASCADE) [for > Statement "DELETE FROM biblio"] at t/db_dependent/OAI/Server.t line 62. This can be easily fixed by deleting all issues before deleting all biblios 2. Biblio records are MARC21 (245$a for the title), so, as a UNIMARC user I get nothing in dc:title (tests "ListRecords oai_dc ..."). 3. I don't know if this one is related to MARC21/UNIMARC but I also get nothing in dc:language (hashref expected) (tests "ListRecords oai_dc ...") Result of prove here: http://paste.koha-community.org/325 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17380] Cannot edit authorities with authtypecode = default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 --- Comment #3 from Marcel de Rooy --- Created attachment 60592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60592&action=edit Bug 17380: Merge saves with wrong authtypecode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17380] Cannot edit authorities with authtypecode = default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 --- Comment #4 from Marcel de Rooy --- Still needs some polishing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #58 from Jonathan Druart --- When I hit /circ/circulation.pl?borrowernumber=42, I get a software error: Template process failed: undef error - The method category_type is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. Yes I think another signoff is needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18106] Batch-update bibliographic records when authorities are modified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18106 Marcel de Rooy changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC||m.de.r...@rijksmuseum.nl --- Comment #12 from Marcel de Rooy --- Claudio There are several patches underway in this area. dontmerge will be replaced by authoritymergelimit in bug 9988 (will submit that one this week) a maintenance script will go on bug 18071 see all bugs related here on bug 17908 (omnibus) *** This bug has been marked as a duplicate of bug 17908 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17908] Authority merge omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 Marcel de Rooy changed: What|Removed |Added CC||cost...@gmail.com --- Comment #15 from Marcel de Rooy --- *** Bug 18106 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18106] Batch-update bibliographic records when authorities are modified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18106 Marcel de Rooy changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18161] New: Option to completely disable advance notice on loans with auto renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18161 Bug ID: 18161 Summary: Option to completely disable advance notice on loans with auto renewal Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: stefan.berndts...@ub.gu.se QA Contact: testo...@bugs.koha-community.org Some background. In our current library system, we use long loans (loans with a guaranteed minimum due date, but a much much longer hard due date), with a recall function. This is only in use for parts of the content. Koha does not support this, so we're looking at using auto renewal as a method to give a reasonable resemblance of long loans. We also want advance notices to be sent when the due date is about to arrive, but having an advance notice and then an automatic renewal shortly after will produce a multitude of notices that will be considered as faulty by the end user. The suggested solution to this is an option to simply disable advance notices for loans where auto renewal is active. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18022] Empty barcode causes internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 Koha Team Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr --- Comment #4 from Koha Team Lyon 3 --- Hello, We experiment the same problem on our preprod install (3.22). I'm not sure of this but probably It does not happen when the patron has no permission set (standard case). It could explain why Jonathan was not able to reproduce the error. But from the moment you set whatever permission to the patron, you will get the error systematically. What is very strange is that the error persists even if you remove again the permission. I also try to empty the browser cache and cookies, restart starman service, close the browser and run again : seems that, when the patron has ever had any permissions in the past, he's condamned to cause the error (!!?). Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18162] New: Don't translate JSON keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18162
Bug ID: 18162
Summary: Don't translate JSON keys
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Templates
Assignee: oleon...@myacpl.org
Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org
Symptoms:
When Swedish or Norwegian was selected as the interface language in the staff
client, patron searches that were only returning a single result would redirect
to /cgi-bin/koha/members/moremember.pl?borrowernumber=undefined, which of
course gives the message "This patron does not exist. Find another patron?"
Cause:
In koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt we
have this:
34"dt_action":
35" Edit",
36"borrowernumber":
37"[% data.borrowernumber %]"
38}[% UNLESS loop.last %],[% END %]
borrowernumber here is meant to be a key in some JSON data, but it had been
translated, which means the JS in
koha-tmpl/intranet-tmpl/prog/nb-NO/modules/members/member.tt that redirects
when there is only one result could not find the borrowernumnber:
196// redirect if there is only 1 result.
197if ( json.aaData.length == 1 ) {
198var borrowernumber = json.aaData[0].borrowernumber;
199
document.location.href="/cgi-bin/koha/members/moremember.pl?borrowernumber="+borrowernumber;
200return false;
201}
In Pootle, the string that had been translated looks like this:
", "borrowernumber": "%s" }%s,%s %s ] } %s %s %s%s%s %s%s%s %s%s%s %s %s
Quick fix:
Find the relevant string in *-staff-prog.po and untranslate it.
Permanent fix:
Is there some way to mark a string so it does not get picked up for
translation?
If not, perhaps it would make sense to rename borrowernumber here to something
that is more obviously not meant to be translated? Why are the other keys in
the JSON prefixed with dt_? Is there some special magic to it, or could we do
the same for borrowernumber?
Thanks to oha on #koha for nudging me in the right direction to figure this
out.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12310] Accept different monetary formats as input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Baptiste changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #9 from Katrin Fischer --- Pasi, is this still on your todo list or would it be ok to reset the Assignee? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Baptiste changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com CC||baptiste.wojtkowski@biblibr ||e.com --- Comment #5 from Baptiste --- I take it to add the tests, but I don't understand why there are 3 options for UseDaysModes despite 2 of them have exactly the same behaviour in all function in which they are called, shouldn't we delete the "caleandar", which doesn't have the specified behaviour ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18162] Don't translate JSON keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18162 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #1 from Julian Maurice --- > Is there some way to mark a string so it does not get picked up for > translation? In my opinion, it would be better to do the opposite: mark the strings that have to be translated, that would avoid the "%s" hell we have in some strings like this one and more generally that would prevent the translation to break things. But to be practical, I think the right way to do it is to not return any html in this JSON. The rendering code can be put in DataTables configuration (mRender property). For an example usage of mRender, see bug 15219 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18162] Don't translate JSON keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18162 --- Comment #2 from Magnus Enger --- (In reply to Julian Maurice from comment #1) > But to be practical, I think the right way to do it is to not return any > html in this JSON. Not sure I see how this would stop the string "borrowernumber" from being translated? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18162] Don't translate JSON keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18162 --- Comment #3 from Julian Maurice --- (In reply to Magnus Enger from comment #2) > (In reply to Julian Maurice from comment #1) > > But to be practical, I think the right way to do it is to not return any > > html in this JSON. > > Not sure I see how this would stop the string "borrowernumber" from being > translated? Sorry for not being clear I was just about to write another comment to explain it better :) By "not returning any html in this JSON" I also meant that we should not use Template::Toolkit to generate JSON. This way, its content won't go into PO files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #6 from Katrin Fischer --- Hi Baptiste, I think all three options should have a specific behaviour for calculating due dates when the patron _doesn't_ expire before the calculated due date: - ... the calendar to push the due date to the next open day - ... the calendar to sktip all closed days - ... circulation rules only (ignore the calendar altogether) But when you use ReturnExpiry to shorten the due date and it's before the calculated due date I think you are right that the behaviour of the first 2 will be the same. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18163] New: Elasticsearch itemtype indexing correctly for unimarc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Bug ID: 18163 Summary: Elasticsearch itemtype indexing correctly for unimarc Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: pjamori...@gmail.com QA Contact: testo...@bugs.koha-community.org After installing and indexing Elasticsearch, a search for itemtype is not working correctly. The reason for this I think is that Marc21 uses the index itype whereas Unimarc uses the index itemtype. The index mapped in mappings.yml is itype, and a search for item type in unimarc will search on itemtype index, which has nothing mapped to. Furthermore, trying to change the index from itype to itemtype in the mappings panel for elasticsearch will trigger the following error: Can't call method "label" on an undefined value at /usr/share/koha/intranet/cgi-bin/admin/searchengine/elasticsearch/mappings.pl line 69 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #240 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #235) > Messages: If you go over the number of holds per record, the message is: No > items available. Which is/may be untrue. Why not: you reached the max ? Good thought Marcel. File a bug report for that and ping me about it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #42 from Kyle M Hall --- (In reply to Owen Leonard from comment #39) > Does this feature make it inaccurate to label the "Relatives' checkouts" tab > as such? "Guarantees' checkouts" perhaps? I think we us the term colloquially but I've not problem switching our language to guarantees to be technically correct :) I think we should do that on a separate bug since it affects other parts of Koha not in the purview of this bug patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18097] It is possible to create unusable category codes (ccode) due to field length mismatch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18097 --- Comment #3 from Kyle M Hall --- (In reply to Jonathan Druart from comment #2) > Kyle, do you plan to provide a complete patch? I haven't found the time yet to identify all columns that have the option to be authorised values yet. If you want to add a patch please go ahead! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Olli-Antti Kivilahti changed: What|Removed |Added CC||olli-antti.kivila...@jns.fi --- Comment #47 from Olli-Antti Kivilahti --- Thanks Francois Charbonnier for an excellent summary! It was much needed. Would it be possible to make a small screencast about this feature? I have used Istanbul in linux to do screencasts. It is super easy to use. Screencasts can easily communicate the feature, and the details can be much willingly disseminated after interest has been garnered. I need to be able to set the opening hours for libraries. Mainly self-service opening hours to allow/disallow self-service access by access-control systems. There actually are different "opening hours" for different levels of services in libraries. -We have normal opening hours when staff is present. -We have self-service period when staff is not present. -We might have a period during which checkouts must be returned, or fines start cumulating. This can be bigger or smaller than the real library opening hours, if using for ex. outdoor checkin-automatons. And those periods can interact in interesting ways. This would require an extra layer on top of the calendar rewrite where you could set different types of opening hours. Having something more visual which shows the feature in action, would help us decide if our interests align on this feature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #59 from Kyle M Hall --- Thanks! That helps a lot! (In reply to Jonathan Druart from comment #57) > Kyle, > > I did not write the different failures because most of them are obvious: > > 1. There are no tests > 2. CamelCase instead of snake_case for methods of Koha::Clubs and > Koha::Patron > 3. GetClubEnrollmentsCount and GetEnrollableClubsCount are not needed, just > call ->count > 4. You should not need to add GetBranches to the Branches TT plugin. Take a > look at options_for_libraries > 5. Subroutine added to Koha TT plugin (UserEnv), but not used. > 6. Changes to circ/circulation.pl are not needed. A variable 'patron' is > already passed to the template. > 7. All the labels of the form has the same value for the "for" attribute. > 8. Tables on clubs/clubs.pl are ugly (missing datatables.css?) > 9. On /clubs/clubs-add-modify.pl?club_template_id=1, there is an empty input > at the end of the form. > 8. CGI->param must not be called in scalar context > 9. When I save a form, I get "Your club was created" with a link to "Return > to patron clubs". That sounds weird. Especially because the box is yellow. > I'd suggest to behave as everywhere else in Koha: Save and get the list. > I guess it's because there are too many small scripts, maybe it would have > been easier to have a bigger one and have the different action handled in it > (as everywhere else in admin scripts). > 10. INSERT statements should have IGNORE in update db process > 11. + `branchcode` varchar(10) COLLATE utf8_unicode_ci NULL DEFAULT NULL, > you should not need to specify the COLLATE here. > 12. QA tests do not pass > FAIL Koha/Patron.pm > FAIL forbidden patterns > forbidden pattern: merge marker (>>>) (line 647) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15108] OAI-PMH provider improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #83 from Ere Maijala --- Marcel: Was there a reason for removing the deletion of issues in your patch in Bug 17493? I suppose the issue with UNIMARC is that the OAI-PMH provider does take it into account while the test doesn't. I'll see if I can fix these issues with a follow-up patch to the test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18163] Elasticsearch unimarc advanced search by item type not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Pedro Amorim changed: What|Removed |Added Summary|Elasticsearch itemtype |Elasticsearch unimarc |indexing correctly for |advanced search by item |unimarc |type not working -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18163] Elasticsearch unimarc advanced search by item type not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 --- Comment #1 from Pedro Amorim --- I added the itemtype index in mappings.yaml and reset it. Still not working. The itype is indeed being used in unimarc and working properly but only from the facets. Searching from the advanced search still returns no results and the search is being conducted with "itemtype,phr:TYPE". If I manually change this to "itemtype:TYPE" it's returning the records with item type TYPE correctly. Can the problem be in the phrase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18022] Empty barcode causes internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022
--- Comment #5 from Koha Team Lyon 3 ---
as a temporary workaround, I put this in the intranetuserjs syspref :
$('#mainform').submit(function(event){
if ( ! $('#barcode').val().length ) {
event.preventDefault();
window.location.replace("/cgi-bin/koha/circ/circulation.pl");
}
});
Olivier Crouzet
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Pedro Amorim changed: What|Removed |Added Summary|Elasticsearch unimarc |Elasticsearch advanced |advanced search by item |search by item type not |type not working|working with ||item-level_itypes turned ||off (biblio record) --- Comment #2 from Pedro Amorim --- Turns out the the difference between itype and itemtype is related to the item-level_itypes preference, which i had it set to biblio record instead of item. I changed the preference back to item-level and now the search is working. However, upon indexing, the following message is thrown: "item-level_itypes set but no itemtype set for item (ID) at /usr/share/koha/lib/Koha/Schema/Result/Item.pm line 698. " Which is confusing because the item type info is in biblioitems.itemtype for the items and also the search is apparently working fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What|Removed |Added Attachment #60256|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What|Removed |Added Attachment #60257|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What|Removed |Added Attachment #60258|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What|Removed |Added Attachment #60259|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18161] Option to completely disable advance notice on loans with auto renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18161 --- Comment #1 from Stefan Berndtsson --- Created attachment 60593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60593&action=edit Option for disabling advance notice when auto_renew is set on item that is due soon When SysPref is set to 'Do not send' no advance notice will be sent when item is issued with auto renewal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18070] Support clean removal of authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy changed: What|Removed |Added Attachment #60392|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18070] Support clean removal of authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy changed: What|Removed |Added Attachment #60393|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18070] Support clean removal of authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy changed: What|Removed |Added Attachment #60395|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18070] Support clean removal of authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy changed: What|Removed |Added Attachment #60394|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15108] OAI-PMH provider improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #84 from Marcel de Rooy --- (In reply to Ere Maijala from comment #83) > Marcel: Was there a reason for removing the deletion of issues in your patch > in Bug 17493? > > I suppose the issue with UNIMARC is that the OAI-PMH provider does take it > into account while the test doesn't. > > I'll see if I can fix these issues with a follow-up patch to the test. Not sure anymore (seen too much code in the meantime). Guess it was not needed.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #13 from Marcel de Rooy --- Created attachment 60594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60594&action=edit Bug 9988: Database revision for AuthorityMergeLimit Introduce the new preference and remove dontmerge. If dontmerge was enabled, the new pref will be set to zero and we will print a message about raising this value now. Test plan: Run the database revision or a new install. In case of an upgrade, check the new pref value. Should be 0 when dontmerge was enabled, otherwise 50. Signed-off-by: Marcel de Rooy Also tested sysprefs.sql on a new database. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #15 from Marcel de Rooy --- Created attachment 60596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60596&action=edit Bug 9988: DBIx schema changes for need_merge_authorities As generated by misc/devel/update_dbix_class_files.pl. No test plan. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #17 from Marcel de Rooy --- Created attachment 60598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60598&action=edit Bug 9988: Add extract_biblionumber to Koha/SearchEngine When we will replace the Zebra code in sub merge, we will call SearchEngine to pass records and we need a routine to extract a biblionumber from a search result record. A record from Zebra still must be converted to MARC::Record. This is no longer needed for a ElasticSearch record. Test plan: Run t/db_dependent/Koha/SearchEngine/Search.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #16 from Marcel de Rooy --- Created attachment 60597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60597&action=edit Bug 9988: Add Koha objects for table need_merge_authorities This patch adds two Koha objects: MergeRequest(s). MergeRequest has a new method and an oldmarc method. A class method reporting_tag_xml is added to MergeRequests.pm. All new routines are tested in Authorities.t. Removes a few unneeded modules from Koha::Authority. Test plan: Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #14 from Marcel de Rooy --- Created attachment 60595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60595&action=edit Bug 9988: Table revision for need_merge_authorities In order to let merge do exactly the same when called from the merge cron job, we need three additional fields in the table. The use of these fields will be explained in a follow-up. Test plan: Run the dbrev (updatestructure step in webinstaller). Signed-off-by: Marcel de Rooy Also tested running kohastructure.sql for this table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #22 from Marcel de Rooy --- Created attachment 60603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60603&action=edit Bug 9988: Remove further references to dontmerge [1] The preference was sent to HEA. We can now send both AuthorityMergeMode as well as AuthorityMergeLimit. [2] A comment in authorities/merge.pl is removed. Note that a subsequent patch will modify and test the cron job. [3] Script misc/batchRebuildItemsTables.pl temporarily enabled dontmerge. This is equivalent to setting the mergelimit to zero. The function defnonull is no longer needed. (If the pref was NULL, we restore that value. Sub merge won't mind.) Test plan: [1] Run t/db_dependent/UsageStats.t [2] Run misc/batchRebuildItemsTables.pl -t This just ensures you it still compiles; the changes speak for itself. [3] Now git grep on dontmerge. You should only find hits in atomicupdate and misc/translator/po. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #19 from Marcel de Rooy --- Created attachment 60600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60600&action=edit Bug 9988: Merge should have a parameter hash We will need a few additional parameters for merge later on. This patch puts the original parameters in a parameter hash. Test plan: [1] Run Merge.t [2] Merge two authorities in the Authorities module Note: I also tested script merge_authority.pl with -b parameter. This script will still need further attention. I manually deleted an authority record, inserted a record in need_merge_authorities, and ran the script with -b while adding -f and -t with an existing authority number. This record number is ignored in batch mode. The biblio record with the deleted authority was correctly cleaned up. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #20 from Marcel de Rooy --- Created attachment 60601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60601&action=edit Bug 9988: Remove the Zebra code from sub merge Since we can now call linked_biblionumbers, we can now remove all Zebra related code from merge. We also add a parameter biblionumbers; we use it in the test now, but it may be handy too later in the maintenance script when we want to trigger a merge for specific biblionumber(s). See bug report 18071. All mocks for ZOOM, Context::Zconn, Search::new_record_for_zebra in the merge test can now be replaced by one mock for linked_biblionumbers. Note that we test the biblionumbers parameter in the last subtest without that mock. Remove unused vars $countunmodifiedbiblio, $counterrors from merge. Renamed zebrarecords to linkedrecords in the Merge test. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Modify an authority record. Check the linked biblio records. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #21 from Marcel de Rooy --- Created attachment 60602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60602&action=edit Bug 9988: Check the merge limit in sub merge At this point, we are replacing dontmerge functionality by the new AuthorityMergeLimit logic. Instead of doing this check before calling merge, we just call merge and check it there. In order to let the cron job do the larger (postponed) merges, we add a parameter override_limit. A subtest is added in Merge.t to test the 'postponed merge' feature. Since merge now also calls get_usage_count, an additional mock is added. All references to dontmerge are removed. In merge two lines, initializing $dbh and $counteditbiblios, are moved. The dontmerge test in DelAuthority and ModAuthority is removed. Since this did not leave much in ModAuthority, I fixed the whitespace on the remaining lines rightaway (yes, I know). A minimal set of changes is applied to the cron script; it will get further attention on a next patch. Test plan: [1] Run Merge.t [2] Set AuthorityMergeLimit to 2. Modify an authority with two linked biblios. Check that the merge was done immediately. [3] Now modify an authority with more than 2 linked records. Verify that the merge was postponed; a record must be inserted in the need_merge_authorities table. [4] Testing of the merge cron job is *postponed* to a next patch. Note: I tested a modification, but the script just needs more attention. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #23 from Marcel de Rooy --- Created attachment 60604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60604&action=edit Bug 9988: Refactor the cron script The cron job is moved from migration tools to cronjobs. And renamed to a plural form. The script is now based on Koha objects. It does no longer include the code to merge one record. This can be done via the interface, and will be added to a maintenance script on bug 18071. Should not be part of this cron job. Adding a cron_cleanup method to MergeRequests; this method is called from the cron script to reset older entries still marked in progress and to also remove old processed entries. Tested in a separate unit test. Test plan: [1] Run t/db_dependent/Authorities/MergeRequests.t [2] Set AuthorityMergeLimit to 0. (All merges are postponed.) [3] Modify an authority linked to a few records. [4] Delete an authority linked to a few records with batch delete tool. [5] And select two auth records with linked records. Merge these two records with authority/merge.pl. Note: Do not select Default. See also bug 17380. [6] Check the need_merge_authorities table for inserted records. [7] Run misc/cronjobs/merge_authorities.pl -b and inspect the linked records and the record status in need_merge_authorities. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #26 from Marcel de Rooy --- Created attachment 60607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60607&action=edit Bug 9988: Final polishing [1] DelAuthority: There is actually no need to call GetAuthority in this routine. The subfields of the old record are not relevant when removing all references in the linked biblio records. [2] Added a few POD lines to merge. [3] Removed a trailing space in a comment line in merge. Test plan: [1] Run Merge.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #24 from Marcel de Rooy --- Created attachment 60605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60605&action=edit Bug 9988: Fix a small last minute bug in merge When you postpone an 'authtype crossing' authority merge from A to B, the record for A will be deleted. In that case the condition for tags_new in sub merge does not work well. We should allow an empty authtypefrom here in order to get a new field belonging to authority B. Simply put, if we go from PERSO to CORPO, all linked records should go from X00 to X10 etc. Test plan: [1] Run Merge.t [2] Select two authorities of different type with linked records. [3] Set AuthorityMergeLimit to zero. And merge both auth records. Note: Do not select Default. See also bug 17380. [4] Run the cron job and check the linked records (especially the ones that were linked to the deleted record). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #18 from Marcel de Rooy --- Created attachment 60599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60599&action=edit Bug 9988: Add get_usage_count and linked_biblionumbers to Koha::Authority When replacing the Zebra code in sub merge, we actually need CountUsage as well as the results it gets from SearchEngine. In order to get count and/or results, we now create: [1] instance methods get_usage_count and linked_biblionumbers in Koha::Authority, [2] class methods of the same name in Koha::Authorities. The instance method calls the class method. The class method can be used for deleted authority records, and in 'legacy calls' before refactoring. Note: On BZ 18149 we will replace all CountUsage calls. Test plan: Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #25 from Marcel de Rooy --- Created attachment 60606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60606&action=edit Bug 9988: Add the cronjob and print an upgrade message The Debian cron file and the misc crontab example are updated. A message is printed when upgrading. Note: At this moment the merge cron job is run once a day. This is imo a good starting point. The load for this job greatly depends on the value of pref AuthorityMergeLimit. Of course you can schedule the job more often, and if this need is felt more globally, we can adjust it later. Test plan: [1] Run the dbrev and see the message. [2] Read the changes to the cron files. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 --- Comment #3 from Pedro Amorim --- The reason the search is throwing the warning: "item-level_itypes set but no itemtype set for item (ID) at /usr/share/koha/lib/Koha/Schema/Result/Item.pm line 698. " is because the items.itype are indeed NULL (no info at the time of import). And the reason the search is working is because it falls back to the biblioitems.itemtype after throwing the error: https://github.com/Koha-Community/Koha/blob/4f178fad53fb748bd1ccf67680e02411918c9584/Koha/Schema/Result/Item.pm#L700 With all that, the bug remains, the advanced search by item type will return no results because it's searching as "itemtype, phr". "itemtype" alone will return the results correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15108] OAI-PMH provider improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #85 from Ere Maijala --- I suppose that would have been the case with a clean database. I'll revise the tests a bit to assume it's not clean (delete issues and oai_sets at least). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18162] Don't translate JSON keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18162 --- Comment #4 from Magnus Enger --- (In reply to Julian Maurice from comment #3) > By "not returning any html in this JSON" I also meant that we should not use > Template::Toolkit to generate JSON. This way, its content won't go into PO > files. Yeah, that makes sense! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #27 from Marcel de Rooy --- If you apply all patches, you may want to use this COMBINED test script: Run the three db revs. Run tests: t/db_dependent/Koha/Authorities.t t/db_dependent/Authorities/Merge.t t/db_dependent/Authorities/MergeRequests.t t/db_dependent/Koha/SearchEngine/Search.t t/db_dependent/UsageStats.t Follow test plan: Check the merge limit in sub merge Follow test plan: Refactor the cron script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15108] OAI-PMH provider improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #86 from Ere Maijala --- Created attachment 60608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60608&action=edit Fixed tests to be more robust and also work with UNIMARC. Added a patch to improve the server tests: - delete issues before biblios - delete oai_sets to avoid having them in the response - create UNIMARC test records when UNIMARC is enabled - include language code in the records to avoid failures caused by minor differences in how a missing language code is handled in OAI_DC transformation of different MARC flavors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17908] Authority merge omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 Marcel de Rooy changed: What|Removed |Added Depends on||18149 --- Comment #16 from Marcel de Rooy --- Update: Bug 18070 made its way to PQA (thx Josef and Julian). Submitted bug 9988 now. It is the enhancement that replaces dontmerge by a limit. This sounds easier than it was. The Zebra code in merge is removed. The cron job has been refactored, and is no longer optional. It also supports merges from one authority type to another (with a table revision). Should be the last patch in this omnibus that makes fundamental changes to merge, except for a small expected change of the field indicators. So: Please test ! What should still follow? Housekeeping: Bug 18149 Replace CountUsage calls (finish a refactoring started in 9988) Bug 18071 Maintenance script Bug 14769 Indicators Bug 12722 Bulkmarcimport ?? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149 [Bug 18149] Move CountUsage calls to Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149 Marcel de Rooy changed: What|Removed |Added Blocks||17908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 [Bug 17908] Authority merge omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18071] Add new script update_authorities.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Marcel de Rooy changed: What|Removed |Added CC||jcam...@cpbibliography.com --- Comment #3 from Marcel de Rooy --- *** Bug 8579 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8579] Need script for updating authority 001s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8579 Marcel de Rooy changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17908] Authority merge omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 Bug 17908 depends on bug 8579, which changed state. Bug 8579 Summary: Need script for updating authority 001s https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8579 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8579] Need script for updating authority 001s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8579 Marcel de Rooy changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Marcel de Rooy --- Closed in favor of bug 18071 *** This bug has been marked as a duplicate of bug 18071 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149 Marcel de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What|Removed |Added Text to go in the||This enhancement replaces release notes||dontmerge by a limit. The ||Zebra code in merge is ||removed. The cron job has ||been refactored, and is no ||longer optional; it also ||supports merges from one ||authority type to another ||(with a table revision). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What|Removed |Added Summary|Leave larger authority |Leave larger authority |merges to merge_authority |merges to merge_authorities |cronjob (pref |cronjob (pref |AuthorityMergeLimit)|AuthorityMergeLimit) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- I think we see this happen with single quotes in an author name in facets. The name is: Kum'a N'dumbe. A keyword search for the name works, but when you search au:Kum'a N'dumbe - no results. Same when you click on the facet with this name: /cgi-bin/koha/catalogue/search.pl?idx=kw&q=kamerun&sort_by=relevance_dsc&limit=au:Kum'a N'dumbe, Alexandre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18071] Add new script update_authorities.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 --- Comment #4 from Marcel de Rooy --- chmod 755 misc/maintenance/update_authorities.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18106] Batch-update bibliographic records when authorities are modified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18106 --- Comment #13 from Claudio --- (In reply to Marcel de Rooy from comment #12) > Claudio > There are several patches underway in this area. > dontmerge will be replaced by authoritymergelimit in bug 9988 (will submit > that one this week) > a maintenance script will go on bug 18071 > see all bugs related here on bug 17908 (omnibus) > > *** This bug has been marked as a duplicate of bug 17908 *** Thanks Marcel, I will pay close attention to your comment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17913] Merge three authority merge fixes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #85 from Marcel de Rooy --- (In reply to Mason James from comment #83) > (In reply to Marcel de Rooy from comment #82) > > ping mtj mason > > hi Marcel > > i get a compile error after applying the 16.5.x patch > > -- > $ perl -c C4/AuthoritiesMarc.pm > Global symbol "$authtypecodefrom" requires explicit package name at > C4/AuthoritiesMarc.pm line 1462. > Global symbol "$authtypecodeto" requires explicit package name at > C4/AuthoritiesMarc.pm line 1464. > Global symbol "$authtypecodefrom" requires explicit package name at > C4/AuthoritiesMarc.pm line 1464. > Global symbol "$authtypecodeto" requires explicit package name at > C4/AuthoritiesMarc.pm line 1465. > C4/AuthoritiesMarc.pm had compilation errors. > -- > > any ideas folks? Seems that you indeed miss the patch from Josef here. Will test it tomorrow on a 16.05 tweak install. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14535] Late orders does not show orders with price = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535 --- Comment #11 from Marcel de Rooy --- Katrin: Could you test this one please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14535] Late orders does not show orders with price = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535 --- Comment #12 from Katrin Fischer --- It's on the list, but I don't have much time the next 2 weeks, someone else might be faster. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Claudio changed: What|Removed |Added CC||cost...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18165] New: koha-rebuild-zebra is broken by marcxml move.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18165 Bug ID: 18165 Summary: koha-rebuild-zebra is broken by marcxml move. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Command-line Utilities Assignee: gmcha...@gmail.com Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz running sudo koha-rebuild-zebra -f kohadev throws the following error: DBD::mysql::st fetchrow_hashref failed: fetch() without execute() [for Statement "SELECT biblioitemnumber, marcxml FROM biblioitems WHERE biblionumber=? " with ParamValues: 0='3987'] at /usr/share/koha/lib/C4/Biblio.pm line 1288. error retrieving biblio 3987 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 690. This is caused by Bug 17196 - Move marcxml out of the biblioitems table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18129] Adding staging user to staged batches, for better filtering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18129 Stefan Berndtsson changed: What|Removed |Added Attachment #60543|0 |1 is obsolete|| --- Comment #5 from Stefan Berndtsson --- Created attachment 60609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60609&action=edit Adding staging user to staged batches, for better filtering Minor error in template due to pasting wrong thing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What|Removed |Added Attachment #60519|0 |1 is obsolete|| Attachment #60520|0 |1 is obsolete|| Attachment #60521|0 |1 is obsolete|| --- Comment #60 from Kyle M Hall --- Created attachment 60610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60610&action=edit Bug 12461 - Add patron clubs feature This features would add the ability to create clubs which patrons may be enrolled in. It would be particularly useful for tracking summer reading programs, book clubs and other such clubs. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure your staff user has the new 'Patron clubs' permissions 4) Under the tools menu, click the "Patron clubs" link 5) Create a new club template * Here you can add fields that can be filled out at the time a new club is created based on the template, or a new enrollment is created for a given club based on the template. 6) Create a new club based on that template 7) Attempt to enroll a patron in that club 8) Create a club with email required set 9) Attempt to enroll a patron without an email address in that club 10) Create a club that is enrollable from the OPAC 11) Attempt to enroll a patron in that club 12) Attempt to cancel a club enrollment from the OPAC 13) Attempt to cancel a club enrollment from the staff interface Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #61 from Kyle M Hall --- Created attachment 60611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60611&action=edit Bug 12461 - Use snake case -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #62 from Kyle M Hall --- Created attachment 60612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60612&action=edit Bug 12461 - Revert changes to circulation.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #66 from Kyle M Hall --- Created attachment 60616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60616&action=edit Bug 12461 - Remote collates from branchcode rows, add IGNORE for inserts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #65 from Kyle M Hall --- Created attachment 60615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60615&action=edit Bug 12461 - Return to clubs home after save -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #64 from Kyle M Hall --- Created attachment 60614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60614&action=edit Bug 12461 - Fix 'for=' and param issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #63 from Kyle M Hall --- Created attachment 60613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60613&action=edit Bug 12461 - Template updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What|Removed |Added Attachment #60610|0 |1 is obsolete|| Attachment #60611|0 |1 is obsolete|| Attachment #60612|0 |1 is obsolete|| Attachment #60613|0 |1 is obsolete|| Attachment #60614|0 |1 is obsolete|| Attachment #60615|0 |1 is obsolete|| Attachment #60616|0 |1 is obsolete|| --- Comment #67 from Kyle M Hall --- Created attachment 60617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60617&action=edit Squashed patch set for ease and simplicity. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What|Removed |Added Attachment #60617|Squashed patch set for ease |Bug 12461 - Add patron description|and simplicity. |clubs feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18165] koha-rebuild-zebra is broken by marcxml move.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18165 --- Comment #1 from Barton Chittenden --- This was caused by kohadevbox using old packages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18165] koha-rebuild-zebra is broken by marcxml move.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18165 Barton Chittenden changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #68 from Kyle M Hall --- Still needs unit tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What|Removed |Added Attachment #60617|0 |1 is obsolete|| --- Comment #69 from Kyle M Hall --- Created attachment 60618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60618&action=edit Bug 12461 - Add patron clubs feature This features would add the ability to create clubs which patrons may be enrolled in. It would be particularly useful for tracking summer reading programs, book clubs and other such clubs. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure your staff user has the new 'Patron clubs' permissions 4) Under the tools menu, click the "Patron clubs" link 5) Create a new club template * Here you can add fields that can be filled out at the time a new club is created based on the template, or a new enrollment is created for a given club based on the template. 6) Create a new club based on that template 7) Attempt to enroll a patron in that club 8) Create a club with email required set 9) Attempt to enroll a patron without an email address in that club 10) Create a club that is enrollable from the OPAC 11) Attempt to enroll a patron in that club 12) Attempt to cancel a club enrollment from the OPAC 13) Attempt to cancel a club enrollment from the staff interface Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Mirko Tietgen changed: What|Removed |Added CC|mi...@abunchofthings.net| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #48 from Christopher Brannon --- (In reply to Olli-Antti Kivilahti from comment #47) > I need to be able to set the opening hours for libraries. > Mainly self-service opening hours to allow/disallow self-service access by > access-control systems. > There actually are different "opening hours" for different levels of > services in libraries. > > -We have normal opening hours when staff is present. > -We have self-service period when staff is not present. > -We might have a period during which checkouts must be returned, or fines > start cumulating. This can be bigger or smaller than the real library > opening hours, if using for ex. outdoor checkin-automatons. > > And those periods can interact in interesting ways. > > This would require an extra layer on top of the calendar rewrite where you > could set different types of opening hours. I know the idea here is to keep "branch" schedules together, but would it work to have your different schedules as different branches for the time being? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18162] Don't translate JSON keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18162 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- (In reply to Julian Maurice from comment #3) > By "not returning any html in this JSON" I also meant that we should not use > Template::Toolkit to generate JSON. This way, its content won't go into PO > files. The problem we have is that we want some strings to be translated, things like "Edit", "Delete", "Email", etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18022] Empty barcode causes internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 --- Comment #6 from Jonathan Druart --- (In reply to Koha Team Lyon 3 from comment #4) > Hello, > We experiment the same problem on our preprod install (3.22). Are you able to test against master? Can you recreate in a sandbox? > I'm not sure of this but probably It does not happen when the patron has no > permission set (standard case). It could explain why Jonathan was not able > to reproduce the error. When the blank page is displayed there is no borrowernumber parameter passed to circulation.pl, so it should not depend on the patron's info. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
