date:20170301

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz
 Status|Needs Signoff   |Failed QA

--- Comment #32 from Liz Rea  ---
Hi,

Quick comments, as I have a client interested in this patch:

- the changes to the .sql files are missing comments at the end of the lines,
so they cause the installer to throw a fit, please fix. 
- The stages cannot be reordered, the ajax response says  Saving changes...
Error: Method Not Allowed 
- the button styles in the toolbar need to be consistent with the rest of Koha
please.
- it is a nice to have to eliminate "submit" and swap for the button label
"Save"

I'll add more as I find them and I am sure my client will bring up whatever
they find as well.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #8 from Liz Rea  ---
Hi Nick, 

I think this exists already in the form of j2a.pl, though it may not be as
extensible as this verison.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16034] Integration with OverDrive Patron API

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034

--- Comment #75 from Srdjan Jankovic  ---
Created attachment 60789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60789=edit
Bug 16034 follow-up: better handling of absence of
WebService::ILS::OverDrive::Patron at testing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #17 from Chris Kirby  ---

I don't get the "internal server error" on an old ubuntu system (14.04 LTS) but
I DO get it on kohadevbox with a Windows host and Debian Jessie guest.

On the Kohadevbox, Debian Jessie,
koha-plack-err:
Template process failed: undef error- The method pickup_location is not covered
by tests! at /usr/share/koha/lib/C4/Templates.pm line 121.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18001] LocalHoldsPriority can cause multiple holds queue lines for same hold request

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18001

Joel Sasse  changed:

   What|Removed |Added

 CC||jsa...@plumcreeklibrary.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

Blou  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |philippe.blo...@inlibro.com
 Status|NEW |Needs Signoff

--- Comment #10 from Blou  ---
This is by no mean a great patch.  But our users encountered the problem, and
this fixes it.  When debugging, I found MANY other issues, but I tried to stay
focused on just what was needed for their usage.

A complete overhaul would be needed to make this tool intuitive.  That's not
the goal here.  Just get the users the basics they need.

If more problem encountered (or side effects), we'll fix...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

--- Comment #9 from Blou  ---
Created attachment 60788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60788=edit
Bug 16834 inventory.pl's Set Inventory Date to is ignored

When entering a value in "Set Inventory date to" at the top of the UI, this
value is ignored and the items are always updated with today.
This is (in part) caused by ModDateLastSeen not allowing to set current day.

This patch:
- Makes relevant the date entered at the top (Set Inventory date to).
- Makes relevant the date entered at the bottow (Inventory date).
- Doesn't brake most functionalities.
- Doesn't fix any of the many other bugs and issues with this broken tool.
- remove a warning that was flooding the logs on every call.
- Just makes the UI intuitive for common usage regarding dates.

TEST:
1) find a barcode in your db, write it in a text file
 - set item.datelastseen to some date in the past
2) go to tools/inventory
3) Browse to select the file from 1)
4) Select a date (top) before today, and after the datelastseen entered.
5) Click submit.
6) Validate:
   - Datelastseen specified at the top is the one you entered.
   - Date Last Seen in the table is the old from the DB
   - item.datelastseen is now today
7) Apply the patch.  Validate:
   - item.datelastseen is now the date you entered.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18001] LocalHoldsPriority can cause multiple holds queue lines for same hold request

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18001

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18197] New: Make borrowers-force-messaging-defaults a bit more standard

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18197

Bug ID: 18197
   Summary: Make borrowers-force-messaging-defaults a bit more
standard
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: gmcha...@gmail.com
  Reporter: l...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

Possible tasks to do:

- Make it .pl
- give it better help documentation
- make sure it's presence is noted in the manual
- make it so that optionally, if a borrower has preferences set that don't
match the default, that borrower is skipped for re-setting (as they have likely
set their preferences).

For another time, but just noting it: 
put a function that does this into the web interface for superlibrarians.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18196] New: Holds Queue table should link to Holds table by reserve_id

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18196

Bug ID: 18196
   Summary: Holds Queue table should link to Holds table by
reserve_id
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Now that the 'reserves' table has an id column, it would be nice to link the
tmp_holdsqueue table to it using reserves_id as a foreign key. Furthermore, we
could require the tmp+holdsqueue column to be unique, as we can only have a
single line in tmp_holdsqueue for any given rserve_id.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18195] New: Charge for expired holds per patron category

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18195

Bug ID: 18195
   Summary: Charge for expired holds per patron category
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: sally.hea...@cheshiresharedservices.gov.uk
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

ExpireReservesMaxPickUpDelayCharge allows one charge to be applied to all holds
that expire.

However, each patron category can have a unique hold fee.

It would be preferable if each patron category could also have a unique 'hold
expired' fee, so different patron categories could be charged different amounts
(or not at all) for expired holds.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #16 from Lari Taskula  ---
(In reply to Chris Kirby from comment #15)
> Conflict is now fixed.
> Prior to rebase, I ran perl installer/data/mysql/updatedatabase.pl
> 
> prove t/db_dependent/Template/Plugin/Branches.t results in
> "All tests successful"
> 
> However, Going to cgi-bin/koha/admin/branches.pl
> causes "internal server error".

Thank you for the details. I can't reproduce this issue. Is there a more
detailed description of the error in the log files?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

--- Comment #4 from Matthias Meusburger  ---
With the patch applied, after validating the items informations, I have a "The
method gstrate is not covered by tests!" error message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #15 from Chris Kirby  ---
Conflict is now fixed.
Prior to rebase, I ran perl installer/data/mysql/updatedatabase.pl

prove t/db_dependent/Template/Plugin/Branches.t results in
"All tests successful"

However, Going to cgi-bin/koha/admin/branches.pl
causes "internal server error".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18194] New: Elasticsearch should be able to add new indexes

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18194

Bug ID: 18194
   Summary: Elasticsearch should be able to add new indexes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Bug 14899 added a configuration page for elastic search indexes. It would be
nice to allow for the addition/deletion of indexes as well as their
configuration

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18193] New: Elasticsearch - adding new records from Z39.50 results in ' internal server error'

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18193

Bug ID: 18193
   Summary: Elasticsearch  - adding new records from Z39.50
results in 'internal server error'
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate:
1 - Go to cataloging
2 - Select 'New from Z39/50'
3 - Search, find a record, import
4 - Save the record
5 - Error!

Checking the logs you should see a dump of the record in xml - Koha chokes
trying to access it as a MARC::Record

In C4/Search.pm:
2492 If we are using elasticsearch, it'll already be a MARC::Record and this
2493 function needs a new name.
2494 
2495 =cut
2496 
2497 sub new_record_from_zebra {
2498 
2499 my $server   = shift;
2500 my $raw_data = shift;
2501 # Set the default indexing modes
2502 my $search_engine = C4::Context->preference("SearchEngine");
2503 if ($search_engine eq 'Elasticsearch') {
2504 return $raw_data;
2505 }

However, that doesn't seem to be the case, we are still getting marc XML,
adding "&& 0" to the if and nullifying that section (or removing it) seems to
solve the issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17371] REST API: add CRUD for biblios

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371

Lari Taskula  changed:

   What|Removed |Added

 Blocks||18191


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191
[Bug 18191] REST API: Add endpoint to list valid pickup locations
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

 Blocks||18191


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191
[Bug 18191] REST API: Add endpoint to list valid pickup locations
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16497] REST API: add routes to list libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Lari Taskula  changed:

   What|Removed |Added

 Blocks||18191


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191
[Bug 18191] REST API: Add endpoint to list valid pickup locations
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18191] REST API: Add endpoint to list valid pickup locations

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191

Lari Taskula  changed:

   What|Removed |Added

 Depends on||7614, 17371, 16825, 16497


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614
[Bug 7614] Branch transfer limit and holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497
[Bug 16497] REST API: add routes to list libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825
[Bug 16825] REST API: Add API route for getting an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371
[Bug 17371] REST API: add CRUD for biblios
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7614] Branch transfer limit and holds

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Lari Taskula  changed:

   What|Removed |Added

 Blocks||18191


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191
[Bug 18191] REST API: Add endpoint to list valid pickup locations
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18192] New: Add form for fast changes to tab/ visibility in marc frameworks

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18192

Bug ID: 18192
   Summary: Add form for fast changes to tab/visibility in marc
frameworks
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

It would be nice to have a form where we can quickly change tab/visibility
(especially the last one) for a larger number of fields and subfields in a
particular framework.

Often you want to hide a (sub)field and set tab to -1.
Or unhide a (sub)field by restoring tab and setting hidden to 0 (or possibly
another value).

In order to select fields we could use constructions like:
100|110a|200|300abc etc.
Or regexp based: /^1|^20|300[ab]|500a/ etc.
And all fields selected, perform a hide or unhide operation.

Do you have suggestions about its interface?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18191] New: REST API: Add endpoint to list valid pickup locations

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191

Bug ID: 18191
   Summary: REST API: Add endpoint to list valid pickup locations
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lari.task...@jns.fi
QA Contact: testo...@bugs.koha-community.org

Bug 7534, Bug 7614 and Bug 18072 let us limit the choices of pickup location
when placing a hold. Add a REST API endpoint that uses this functionality.

GET /biblios/{biblionumber}/pickuplocations
GET /item/{itemnumber}/pickuplocations

Returns an array of library-objects that represent a set of libraries that can
be used as pickup locations for hold of the given biblio/item.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18191] REST API: Add endpoint to list valid pickup locations

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191

Lari Taskula  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lari.task...@jns.fi
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14772] Remove or clarify checkbox «flagged» on subfield visibility frameworks

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14772

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl,
   ||mtomp...@hotmail.com

--- Comment #1 from Marcel de Rooy  ---
See also bug 15870/11592.
As far as I can tell, there is no difference between -8 (flagged) and 8 (all
checkboxes are unchecked).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18190] New: the "Delete" action on Home › Reports › Guided reports wizard › Saved reports should hide reports rather than deleting them

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18190

Bug ID: 18190
   Summary: the "Delete" action on Home › Reports › Guided reports
wizard › Saved reports should hide reports rather than
deleting them
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Reports in the 'saved_sql' don't hold sensitive information, and they're not
large. It is entirely possible for staff members to accidentally delete
reports, which then requires the reports to be restored from backups (assuming
that a backup has even been made).

If we could hide the reports rather than deleting them, that would make it
easier to recover in this situation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

--- Comment #10 from Lari Taskula  ---
I would like to point out that I am experiencing an issue with JSON::Validator,
where $refs are sometimes left unresolved in our spec and it causes some error
messages and crashes. This issue is being tracked at
https://github.com/jhthorsen/json-validator/pull/52.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60011|0   |1
is obsolete||

--- Comment #13 from Lari Taskula  ---
Created attachment 60782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60782=edit
Bug 18072: Add Koha::Item->can_be_transferred

This patch adds a new method Koha::Item->can_be_transferred.

Includes unit test.

To test:
1. prove t/db_dependent/Koha/Items.t

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #16 from Lari Taskula  ---
Rebased on top of current master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7614] Branch transfer limit and holds

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60145|0   |1
is obsolete||

--- Comment #12 from Lari Taskula  ---
Created attachment 60787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60787=edit
Bug 7614: Build a list of pickup locations in OPAC considering transfer limits

This patch enables the checks for transfer limits for given biblionumber in
OPAC when patron proceeds to place a hold. In case none of the items of that
biblio can be transferred to a library, that library will not be included in
the list of pickup locations.

To test:
1. Make sure you meet the following requirements:
   1.1: You are able to make holds in OPAC
   1.2: System preference UseBranchTransferLimits set to "Enforce"
   1.3: System preference BranchTransferLimitsType set to "item type"
(for the sake of simplicity of this test plan, but you may also
 set it to "collection code" and deal with ccodes instead)
   1.4: System preference item-level_itypes set to "specific item"
   1.5: You have the default libraries and item types, otherwise replace
the branchcodes and itemtypes in this test plan with your own
2. Make sure 'Fairfield' in cgi-bin/koha/admin/branches.pl has not disabled
   its ability to act as a "Pickup location"
3. Have a biblio with exactly one item of item-level itemtype 'BK'
4. Set item holdingbranch as 'CPL'
5. Go to cgi-bin/koha/admin/branch_transfer_limits.pl (keep this page open in
   a second tab for faster testing)
6. Select library 'Centerville'
7. Uncheck the checkbox 'FFL - Fairfield' and click Save
8. Go to OPAC and find your biblio, and start placing a hold on it
9. Click at the list of "Pick up location"s.
10. Observe that it is missing 'Fairfield'
11. Go back to cgi-bin/koha/admin/branch_transfer_limits.pl
12. Repeat step 6 and this time, check the checkbox 'FFL - Fairfield'
13. Refresh the page you arrived at step 8
14. Observe that it now includes 'Fairfield'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7614] Branch transfer limit and holds

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60144|0   |1
is obsolete||

--- Comment #11 from Lari Taskula  ---
Created attachment 60786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60786=edit
Bug 7614: Consider transfer limits in Koha::Template::Plugin::Branches

Consider transfer limits in Koha::Template::Plugin::Branches->pickup_locations.

This patch modified the mentioned method to consider branch transfer limits and
does not include any library in the returned list of libraries in case a branch
transfer limit applies for a given book or item.

To be tested in following patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7614] Branch transfer limit and holds

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60143|0   |1
is obsolete||

--- Comment #10 from Lari Taskula  ---
Created attachment 60785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60785=edit
Bug 7614: Check branch transfer limits in opac-reserve.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60117|0   |1
is obsolete||

--- Comment #15 from Lari Taskula  ---
Created attachment 60784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60784=edit
Bug 18072: Add Koha::Biblio->can_be_transferred

This patch adds a new method Koha::Biblio->can_be_transferred. The method
checks
if at least one of the item of that biblio can be transferred to desired
location.

This method will be useful for building a smarter pickup location list for
holds,
because we will be able to hide those libraries to which none of the items of
this biblio can be transferred to due to branch transfer limits (see Bug 7614).

To test:
1. prove t/db_dependent/Koha/Biblios.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60116|0   |1
is obsolete||

--- Comment #14 from Lari Taskula  ---
Created attachment 60783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60783=edit
Bug 18072: (QA-follow-up) let Koha::Item->can_be_transferred take HASHref as
param

This patch changes Koha::Item->can_be_transferred to accept a HASHref as
follows:
$item->can_be_transferred({ to => $library, from => $library2 })

To test:
1. prove t/db_dependent/Koha/Items.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #14 from Lari Taskula  ---
(In reply to Chris Kirby from comment #12)
> Applying patches, failed to merge changes for 
> "Bug 7534: Display pickup locations instead of all libraries in
> opac-reserve.pl"
> 
> Failed to merge in changes.

Thanks for reporting! I fixed the conflict as promised yesterday in IRC. Does
it apply now?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18189] Elasticsearch sorting broken

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18189

Nick Clemens  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |n...@bywatersolutions.com

--- Comment #2 from Nick Clemens  ---
Note this won't fix all sorting options unless they are defined as sortable in
the config.

acqdate fails out of the box - set acqdate as sortable - reindex - it should
now work

I suppose we either don't allow altering sortability for some fields, or the
dropdown must populate based on what is defined as sortable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60022|0   |1
is obsolete||

--- Comment #13 from Lari Taskula  ---
Created attachment 60781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60781=edit
Bug 7534: Display pickup locations instead of all libraries in opac-reserve.pl

This patch sets opac-reserve.tt to use the list of pickup libraries instead
of every library in the system.

To test:
1. Go to cgi-bin/koha/admin/branches.pl
2. Configure one of your libraries to "Pickup location" => "No"
3. Go to OPAC and place a hold
4. See the provided Pickup location list
5. Observe the library that you configured is not present in the list

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18189] Elasticsearch sorting broken

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18189

--- Comment #1 from Nick Clemens  ---
Created attachment 60780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60780=edit
Bug 18189 - Elasticsearch sorting broken

To test:
1 - Have ES enabled and biblios and authorities indexed
2 - Perform a catalog search
3 - Try to sort results by author, it will fail
4 - Perform an authority search with sorting enabled, it will fail
5 - Apply patch
6 - Reindex, deleting current indexes
perl /home/vagrant/kohaclone/misc/search_tools/rebuild_elastic_search.pl
-d -v
7 - Repeat 3&4, they should succeed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18189] Elasticsearch sorting broken

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18189

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18189] New: Elasticsearch sorting broken

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18189

Bug ID: 18189
   Summary: Elasticsearch sorting broken
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Current setting in elasticsearch mapping use 'text' type for sort fields, this
seems like extra overhead.

If the fields are only used for sorting we can index them as 'keyword' (exact
phrase) and this has the side effect of fixing sorting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #166 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #146)
> - Empty groups (without libraries) are displayed in the adv search form, I
> do not think they should.

Fixed!

> - If Search groups contain several levels of subgroups, only the first one
> will be used. Not sure it's the expected behaviour.
> 
> Example:
> __SEARCH_GROUP__
>   Group 1
> Library 1
> Subgroup
>   Library 2
> 
> Search on "Group 1" will search in library 1.

That is expected behavior and will be documented in the manual. There is no
additional utility for this particular feature to sub-groups.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #40 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #31)
> (In reply to Jonathan Druart from comment #29)
> > You should also add the btn-default class to the buttons to make them look
> > like other Koha buttons.
> 
> This is still valid.

Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #39 from Kyle M Hall  ---
Created attachment 60779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60779=edit
Bug 16735 - Filter groups without immediate child libraries from group pulldown

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #36 from Kyle M Hall  ---
Created attachment 60776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60776=edit
Bug 16735 - Don't use objects for database update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #38 from Kyle M Hall  ---
Created attachment 60778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60778=edit
Bug 16735 - Filter individual libraries from search group pulldown

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #37 from Kyle M Hall  ---
Created attachment 60777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60777=edit
Bug 16735 - Remove use of get_categories

Feature using it is completely undocumented as far as my research has
shown.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #35 from Kyle M Hall  ---
Created attachment 60775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60775=edit
Bug 16735 - Replace existing library search groups functionality with the new
hierarchical groups system

Test Plan:
1) Apply this patch set
2) Note your existing search groups have been ported over to the new
   __SEARCH_GROUPS__ group if you had any
3) Create the group __SEARCH_GROUPS__ if one does not already exist
4) Add some first level subgroups to this group, add libraries to those groups
5) Search the library group searching in the intranet and opac
6) Note you get the same results as pre-patch

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #33 from Kyle M Hall  ---
Created attachment 60773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60773=edit
Bug 16735 - Remove tables no longer needed

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #34 from Kyle M Hall  ---
Created attachment 60774
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60774=edit
Bug 16735 - Clean up sample data

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60497|0   |1
is obsolete||
  Attachment #60498|0   |1
is obsolete||
  Attachment #60499|0   |1
is obsolete||
  Attachment #60500|0   |1
is obsolete||
  Attachment #60501|0   |1
is obsolete||
  Attachment #60502|0   |1
is obsolete||
  Attachment #60503|0   |1
is obsolete||

--- Comment #32 from Kyle M Hall  ---
Created attachment 60772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60772=edit
Bug 16735 - Remove modules no longer needed

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #162 from Kyle M Hall  ---
Created attachment 60768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60768=edit
Bug 15707 - Switch datetimes to timestamps

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #161 from Kyle M Hall  ---
Created attachment 60767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60767=edit
Bug 15707: Followup - use cat-search instead of cities-search in header

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #163 from Kyle M Hall  ---
Created attachment 60769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60769=edit
Bug 15707 - Add UNIQUE constraint to library groups table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #159 from Kyle M Hall  ---
Created attachment 60765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60765=edit
Bug 15707 [QA Followup] - Allow object names to be styled without impeding
translation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #160 from Kyle M Hall  ---
Created attachment 60766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60766=edit
Bug 15707 - Update Schema Files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #165 from Kyle M Hall  ---
Created attachment 60771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60771=edit
Bug 15707 - Display error if group title is already used

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #164 from Kyle M Hall  ---
Created attachment 60770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60770=edit
Bug 15707 - Updates for Bootstrap 3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #157 from Kyle M Hall  ---
Created attachment 60763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60763=edit
Bug 15707 [QA Followup] - Fix UI issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #158 from Kyle M Hall  ---
Created attachment 60764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60764=edit
Bug 15707 [QA Followup] - Remove class for treegrid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #155 from Kyle M Hall  ---
Created attachment 60761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60761=edit
Bug 15707 [QA Followup] - Switch to treetable which Koha already uses

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #156 from Kyle M Hall  ---
Created attachment 60762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60762=edit
Bug 15707: QA follow-up - Drop table if exists

1/ DROP table if exists
2/ FAIL   spelling
decendents  ==> descendants

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #154 from Kyle M Hall  ---
Created attachment 60760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60760=edit
Bug 15707: Fix conflict with bug 15446 (type vs _type)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #153 from Kyle M Hall  ---
Created attachment 60759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60759=edit
Bug 15707 - Unit Tests

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #152 from Kyle M Hall  ---
Created attachment 60758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60758=edit
Bug 15707 - Add editor

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60755|0   |1
is obsolete||

--- Comment #150 from Kyle M Hall  ---
Created attachment 60756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60756=edit
Bug 15707 - Update DB

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #151 from Kyle M Hall  ---
Created attachment 60757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60757=edit
Bug 15707 - Add new modules

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60573|0   |1
is obsolete||
  Attachment #60574|0   |1
is obsolete||
  Attachment #60575|0   |1
is obsolete||
  Attachment #60576|0   |1
is obsolete||
  Attachment #60577|0   |1
is obsolete||
  Attachment #60578|0   |1
is obsolete||
  Attachment #60579|0   |1
is obsolete||
  Attachment #60580|0   |1
is obsolete||
  Attachment #60581|0   |1
is obsolete||
  Attachment #60582|0   |1
is obsolete||
  Attachment #60583|0   |1
is obsolete||
  Attachment #60584|0   |1
is obsolete||
  Attachment #60585|0   |1
is obsolete||
  Attachment #60586|0   |1
is obsolete||
  Attachment #60587|0   |1
is obsolete||

--- Comment #149 from Kyle M Hall  ---
Created attachment 60755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60755=edit
Bug 15707 - Update DB

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18068] Elasticsearch (ES): Location and (home|holding) branch facets mixed

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068

Nick Clemens  changed:

   What|Removed |Added

Summary|ES: Location and|Elasticsearch (ES):
   |(home|holding)branch facets |Location and
   |mixed   |(home|holding)branch facets
   ||mixed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18188] Should we rename items.booksellerid to items.acqsource ?

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18188

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||18187


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187
[Bug 18187] finishreceive.pl: Save bookseller name into items acquisition
source field
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18187] finishreceive.pl: Save bookseller name into items acquisition source field

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||18188


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18188
[Bug 18188] Should we rename items.booksellerid to items.acqsource ?
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18188] Should we rename items.booksellerid to items.acqsource ?

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18188

--- Comment #1 from Marcel de Rooy  ---
See also bug 18187.
This field in items is labeled as Source of acquisition. Since it is a free
text field, we can imagine that any information may be entered into this field.
You could e.g. also enter a name of someone who donated a book.
Unfortunately its literal name is booksellerid. Originally, it may have been
the intention to really save the booksellerid; but making it an editable text
field was a bad choice.

Note: MARC21 maps 952$e to booksellerid, French UNIMARC maps 995a to it.

Would you agree with renaming the field to acqsource?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18188] Should we rename items.booksellerid to items.acqsource ?

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18188

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Working title   |Should we rename
   ||items.booksellerid to
   ||items.acqsource ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18187] finishreceive.pl: Save bookseller name into items acquisition source field

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18187] finishreceive.pl: Save bookseller name into items acquisition source field

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18187] finishreceive.pl: Save bookseller name into items acquisition source field

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187

--- Comment #1 from Marcel de Rooy  ---
Created attachment 60754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60754=edit
Bug 18187: finishreceive.pl: Save bookseller name into items acquisition source
field

Currently, finishreceive saves the literal booksellerid (a number) into
the item text field labeled as "Source of acquisition", unfortunately
called booksellerid. (This is the case for AcqCreateItem == receiving.)

I opened up another report for renaming this item field (18188).
On this report we make finishreceive.pl save the name of the bookseller
into the item field. This is more informative.

But I could imagine that we need a broader solution:
[1] Do we really always want that information in an item?
[2] Should orderreceive not put this information in the item field? Now we
postpone that to finishreceive; finishreceive just overwrites these
fields, completely ignoring what was there.

Any feedback is welcome.

Test plan:
[1] Set AcqCreateItem to receiving.
[2] Receive an order. Check 952$e in the resulting item.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18188] New: Working title

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18188

Bug ID: 18188
   Summary: Working title
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18187] New: finishreceive.pl: Save bookseller name into items acquisition source field

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187

Bug ID: 18187
   Summary: finishreceive.pl: Save bookseller name into items
acquisition source field
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17992] REST api: Cities controller should not use ->unblessed

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17992] REST api: Cities controller should not use ->unblessed

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17992] REST api: Cities controller should not use ->unblessed

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60750|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 60753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60753=edit
Bug 17992: REST api: Remove the use of ->unblessed from Cities controller

As bug 17932 adds TO_JSON to Koha::Object(s), there's no need for using
it. Also, as this is a reference implementation for developers to copy
and paste it is sensible to make this change even when this is not
causing any bug.

To test:
- Apply the patch
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/db_dependent/api/v1/cities.t
=> SUCCESS: Tests still pass!
- Sign off :-D

Signed-off-by: Matthias Meusburger 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18144] Removal of persona broke openidconnect

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18144

M. Tompsett  changed:

   What|Removed |Added

   Severity|normal  |critical

--- Comment #2 from M. Tompsett  ---
Increasing priority, as a broken authentication method is kind of important to
fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14365] SQL Reports Last Edit Date column

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14365

--- Comment #5 from Kyle M Hall  ---
Created attachment 60752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60752=edit
Bug 14365 - Change 'Last modified' to 'Last edit' for terseness

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18186] Amounts with decimal comma instead of decimal dot breaking payments

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18186] New: Amounts with decimal comma instead of decimal dot breaking payments

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186

Bug ID: 18186
   Summary: Amounts with decimal comma instead of decimal dot
breaking payments
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

In our current installations running under Plack, the amounts on the pay and
paycollect pages suddenly started showing with a decimal comma instead of a
decimal point. This causes quite a bit of trouble, as Koha expects a . and
amounts entered didn't result in the expected payments. We got several reports
about payments being broken in Koha.

Test plan:
- Add manual invoice
- View the "fines" tag
- Verify that individual fees and totals display with , instead of .
- Pay selected or any amount
- Verify that the input field for the amount is also showing the ,
- Verify that paying something like 1,10 doesn't work as expected.

The problem with the test plan is, that you might not see the ,. This appears
only on our productions servers, but not in my development environment. 

We tested:
- different language settings in Koha
- different language settings in the browser
- verified that CurrencyFormat isn't used in the code on those page
- verified that all the formatting done was using the TT filter format('%.2f')

In the end the problem turned out to be related to Plack.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13920] API authentication system - proposal

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920

--- Comment #30 from Olli-Antti Kivilahti  ---
tcohen and ashimema are cooking something as we speak.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

--- Comment #51 from Nick Clemens  ---
Created attachment 60751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60751=edit
Bug 14576 - (QA Followup) Fix Returns.t

Two warnings, not one

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17992] REST api: Cities controller should not use ->unblessed

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992

Matthias Meusburger  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||matthias.meusburger@biblibr
   ||e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17992] REST api: Cities controller should not use ->unblessed

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992

Matthias Meusburger  changed:

   What|Removed |Added

  Attachment #59548|0   |1
is obsolete||

--- Comment #2 from Matthias Meusburger  ---
Created attachment 60750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60750=edit
Bug 17992: REST api: Remove the use of ->unblessed from Cities controller

As bug 17932 adds TO_JSON to Koha::Object(s), there's no need for using
it. Also, as this is a reference implementation for developers to copy
and paste it is sensible to make this change even when this is not
causing any bug.

To test:
- Apply the patch
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/db_dependent/api/v1/cities.t
=> SUCCESS: Tests still pass!
- Sign off :-D

Signed-off-by: Matthias Meusburger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

--- Comment #107 from Zeno Tajoli  ---
Hi to all,

I have same update.

1)With new bugfix of bug 17871 now you can install PazPar2 and Zebra on the
same server.

2) I have update my howto on the topic:
https://wiki.koha-community.org/wiki/PazPar_to_search_external_Z39_50_on_OPAC

3)In the last year we have many discusion inside my firm in what is proprietary
and what not, but now a news: they said me that I will have a definitve answer
for 06-March-2017.

Bye
Zeno Tajoli

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18185] Clears loan history

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
Something in the logs?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16034] Integration with OverDrive Patron API

2017-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034

--- Comment #74 from Jonathan Druart  
---
(In reply to Srdjan Jankovic from comment #73)
> Is there a standard way we skip that kind of tests?

We already kind of the same thing in C4::Members for the Norvegian specific ft.
I guess thing like:

  use Module::Load::Conditional qw( can_load );
  if ( ! can_load( modules => { 'WebService::ILS::OverDrive::Patron' => undef }
) ) {
 warn "Unable to load WebService::ILS::OverDrive::Patron";
  }

in place of the use statement would do the trick.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

94 matches

Mail list logo