[Koha-bugs] [Bug 18132] Confirming a hold/transfer clears checkin history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18132 --- Comment #2 from Nick Clemens --- Ah, yes, confirming a hold doesn't trigger it seems But cancelling a transfer still triggers this issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into a C4 perl module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #5 from Alex Buckley --- Test plan: 1. Restart memcached: sudo service memcached restart 2. Drop and recreate the Koha instance database 3. Go through the web installer, selecting all data to be installed in step 3 4. After the web installer is finished log in with the Koha database administrator credentials 5. Create yourself a patron account 6. Set the patron account to have superlibrarian privileges 7. Log out and back in as your newly created patron 8. Navigate to the Acquisitions interface 9. Create a budget named 'testbudget' 10. Create a fund named 'testfund' 11. Navigate to the 'Administrator' interface 12. Write in the URL 'cgi-bin/koha/admin/aqplan.pl' 13. There should be no records showing 14. If you click on Planning->Plan by Months testfund will be displayed 15. Repeat step 14 but click on Planning->Plan by libraries and Planning->Plan by Itemtypes, Both of these pages should also show 'testfund' 16. In your terminal navigate from your Koha instance root directory to t/db_dependent 17. Enter koha shell: sudo koha-shell 18. Run AuthorisedValues unit tests: prove -v AuthorisedValues.t 19. The tests should run successful 20. Exit the koha shell 21. cd into the 'koha' directory from where you are 22. Enter the koha shell and run the ItemTypes.t and Libraries.t unit tests by writing in: prove -v filename.t (both of which should be successful) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into a C4 perl module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212 --- Comment #4 from Alex Buckley --- Created attachment 61009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61009&action=edit Bug 18212 - Four successfully transferred sql queries to Koha::AuthorisedValue, Koha::ItemType, Koha::Libraries from aqplan.pl administrative script All these queries have been placed inside subroutines in the perl modules outlined above, each subroutine has POD, and a successful unit test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into a C4 perl module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212 --- Comment #3 from Alex Buckley --- Created attachment 61008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61008&action=edit Bug 18212 - Added a successful unit test for GetAuthValues() function -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into a C4 perl module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212 --- Comment #2 from Alex Buckley --- Created attachment 61007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61007&action=edit Bug 18212 - Moved all sql queries out aqplan.pl into Koha::Libraries.pm, Koha::ItemType.pm, Koha::AuthorisedValue.pm files The new subroutines in the perl modules contain POD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into a C4 perl module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212 --- Comment #1 from Alex Buckley --- Created attachment 61006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61006&action=edit Bug 18212 - Created a subroutine GetAuthValuesForCategory() in C4/Acqusition.pm perl module. I've removed one sql select query from aqplan.pl and rewritten it in DBIx query format in the new GetAuthValuesForCategory subroutine. aqplan.pl is successfully calling and running this DBIx query -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18185] Clears loan history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 Jonathan Druart changed: What|Removed |Added Attachment #60968|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18185] Clears loan history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 Jonathan Druart changed: What|Removed |Added Attachment #60967|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18185] Clears loan history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 Jonathan Druart changed: What|Removed |Added Attachment #60966|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18185] Clears loan history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 --- Comment #16 from Jonathan Druart --- (In reply to J Schmidt from comment #15) > Can I ask what is the starting Koha version that's impacted by this bug? > 16.05 or earlier? 16.11? thank you. This bug impacts all Koha versions, but only in very specific cases. Basically it happens if you restart the DBMS and that the last item that has been checked out is checked in. In that case the auto increment value of the issue table become lower than the max value of old_issues.issue_id After the restart, the next issue will get an issue_id that already exists in the old_issues table. When this issue will be checked in and moved to the old_issue table, the copy of the data to the old_issues table will fail and the row will be deleted from the issues table => data are lost! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18003 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18242 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18185] Clears loan history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 J Schmidt changed: What|Removed |Added CC||jschm...@switchinc.org --- Comment #15 from J Schmidt --- Can I ask what is the starting Koha version that's impacted by this bug? 16.05 or earlier? 16.11? thank you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #58 from Mehdi Hamidi --- Hello everyone, here's a link to our screencast : https://www.youtube.com/watch?v=QLxE9ToRJgE Feel free to leave us feedback! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 --- Comment #9 from M. Tompsett --- Created attachment 61005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61005&action=edit Bug 18215: Third case which was missed. Git install old-school style a pre-tls koha Drop the DB Create the DB change branch to master Run a web install. NOTE: found with git grep "['\"]tls['\"]" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15427] Allow db connections using TLS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 M. Tompsett changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18245 --- Comment #18 from M. Tompsett --- (In reply to Marcel de Rooy from comment #17) > Note: tls is not found in debian/templates/koha-conf-site.xml.in See bug 18245. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17346] Enable the check in option in Columns settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org Status|NEW |Needs Signoff --- Comment #3 from Christopher Brannon --- Hope you don't mind. I took the liberty to write the patch. To test: 1) Go to columns_settings.pl --> Circulation --> issues-table and note that you cannot change the settings for checkin. 2) Go to columns_settings.pl --> Patrons --> issues-table and note that you cannot change the settings for checkin. 3) Apply the patch. 4) Go to both tables again and note that you can now change the settings. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18245] debian/templates/koha-conf-site.xml.in missing tls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18245 M. Tompsett changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15427 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18245] debian/templates/koha-conf-site.xml.in missing tls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18245 M. Tompsett changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18245] debian/templates/koha-conf-site.xml.in missing tls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18245 --- Comment #1 from M. Tompsett --- Created attachment 61004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61004&action=edit Bug 18245: Add missing TLS to debian/templates/koha-conf-site.xml.in This was found as a result of testing another bug. Added missing line. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17346] Enable the check in option in Columns settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 --- Comment #2 from Christopher Brannon --- Created attachment 61003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61003&action=edit Bug 17346: Make checkin column hidable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18245] New: debian/templates/koha-conf-site.xml.in missing tls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18245 Bug ID: 18245 Summary: debian/templates/koha-conf-site.xml.in missing tls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: mtomp...@hotmail.com QA Contact: testo...@bugs.koha-community.org As noted by Marcel in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427#c17 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #8 from M. Tompsett --- The problem is that kohastructures.sql is LACKING a TLS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16116] Change of issue publication date doesn' t reflect on the next issue generated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 --- Comment #7 from Bouzid --- Hi All, I deteted patch unit test because it test a local sub. Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16116] Change of issue publication date doesn' t reflect on the next issue generated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Bouzid changed: What|Removed |Added Attachment #58265|0 |1 is obsolete|| Attachment #58266|0 |1 is obsolete|| --- Comment #6 from Bouzid --- Created attachment 61002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61002&action=edit Bug 16116 - Fix problem change of issue publication date doesn't reflect on the next issue generated Test plan : 1. In Cataloging > New with Z39.50, look for issn = 1536-6596 (National Geographic) into the LCC z39.60 server. Add the record. 2. Add a new subscription for National Geographic. Fill-in the form. - use the default values of the first page - for the second page : First issue publication date = 10/01/2016 Frequency = 1/month Subscription lenght = 12 issues Subscription start date = 01/01/2016 Numbering pattern = Number Begins with = 1 - Save 3. Receive the first issue. Change the status to "received". Note that the "Published on" date = 10/01/2016. This date goes to the "Date published" column in the serial collection page. 4. The second issue is generated. Edit serial to receive the issue. 5. Change the "Published on" date to 14/02/2016. Change the status to "received". Save. 6. "Date published" for the next issue generated is : 14/03/2016. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #19 from M. Tompsett --- Comment on attachment 60979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60979 Bug 10382 - Course reserves: handle empty values Review of attachment 60979: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10382&attachment=60979) - ::: installer/data/mysql/atomicupdate/bug_10382-changes-on-courseitems-table.sql @@ +1,4 @@ > +ALTER TABLE course_items DROP FOREIGN KEY course_items_ibfk_2; > +ALTER TABLE course_items MODIFY itype VARCHAR(20); > +ALTER TABLE course_items MODIFY ccode VARCHAR(20); > +ALTER TABLE course_items MODIFY holdingbranch VARCHAR(20); \ No newline at end of file Why drop the foreign key completely? Shouldn't the key be recreated? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 --- Comment #24 from Kyle M Hall --- Created attachment 61001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61001&action=edit Bug 17755: (followup) Override ->search to allow filtering by branchcode Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Kyle M Hall changed: What|Removed |Added Attachment #60992|0 |1 is obsolete|| Attachment #60995|0 |1 is obsolete|| --- Comment #23 from Kyle M Hall --- Created attachment 61000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61000&action=edit Bug 17755: (QA followup) Return $self when appropriate As failure situations raise exceptions that should be handled outside the object class, methods should return $self so successive calls can be chained nicely. This patch makes methods return $self and adjusts the tests to reflect this change. Make sure tests pass: - Run: $ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests return green - Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18144] Removal of persona broke Google OAuth2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18144 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #14 from Bouzid --- Hi all, I rebase all patches and squash all in one good patch. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Bouzid changed: What|Removed |Added Attachment #56542|0 |1 is obsolete|| Attachment #56543|0 |1 is obsolete|| --- Comment #13 from Bouzid --- Created attachment 60999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60999&action=edit Bug 11300 - Add a new authority linker which searches for authority links on a Z39.50 server. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #32 from Bouzid --- Hi all, I rebase all patches and squash all in one good patch. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid changed: What|Removed |Added Attachment #56440|0 |1 is obsolete|| Attachment #56509|0 |1 is obsolete|| Attachment #58307|0 |1 is obsolete|| --- Comment #31 from Bouzid --- Created attachment 60998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60998&action=edit Bug 11299 - Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio shouldbe in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16895] Allow writeoffs via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 --- Comment #5 from Colin Campbell --- Yes pay type is just recorded. We are finding it useful though in reconciling when cashing up units that handle rental fees. Hopefully this will be included in a future submission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18211] Circulation.pl / Moremember.pl has errors in table row id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18211 --- Comment #1 from Christopher Brannon --- Created attachment 60997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60997&action=edit Bug 18211: Corrected intended id's in jquery. To test: 1) Checkout items - if you can, have items checked out from previous day too, but not necessary. 2) Review source code and see that the ids on the and for cells containing "Today's checkouts" and "Previous checkouts" labels have some crazy ids with partial html tags (strong) and other unnecessary elements. 3) Apply patch. 4) Examine source code again and see a better and smaller id. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18211] Circulation.pl / Moremember.pl has errors in table row id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18211 Christopher Brannon changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5620] Capture Mode of payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Bouzid changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5620] Capture Mode of payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Bouzid changed: What|Removed |Added Attachment #56037|0 |1 is obsolete|| Attachment #56080|0 |1 is obsolete|| Attachment #60994|0 |1 is obsolete|| --- Comment #16 from Bouzid --- Created attachment 60996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60996&action=edit bug 5620 - Capture Mode of payment, receipt number and notes in pay fines. - Replace all sub deleted - Using Koha::Template::Plugin::AuthorisedValues - Delete unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 60995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60995&action=edit Bug 17755: (followup) Override ->search to allow filtering by branchcode Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5620] Capture Mode of payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 --- Comment #15 from Bouzid --- Created attachment 60994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60994&action=edit bug 5620 - Capture Mode of payment, receipt number and notes in pay fines. Using sql file in atomiqueupdate using function GetKohaAuthorisedValues -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18220] OPAC login appears to be linked to staff login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18220 --- Comment #2 from Christopher Brannon --- Thanks for the clarification. I was hoping it was something simple. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18144] Removal of persona broke Google OAuth2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18144 M. Tompsett changed: What|Removed |Added Alias||persona, removal, broke, ||openidconnect -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #18 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #15) > BTW Why not just call GetReserveFee here instead? You do not need to check > holds and account_lines anymore. And additionally you can pass the exact > amount in the message. I tried to display the amount, but since we do not handle the display of price yet, I do not think it is ready. Without the currency symbol, the number alone looks weird, and with the currency symbol the display will be wrong half of the time... > Please rename bug_X.sql. I do not think this is necessary, I will have to rewrite the original patches and reupload all of them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #17 from Jonathan Druart --- Created attachment 60993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60993&action=edit Bug 17560: Improve strenght of hold existence test This patch is a QA follow-up to fix several issues: - 1 call to GetReserveFee was wrong in ModReserveFill - Update DB entry was wrong and insufficient - Add robustness to the tests in sco-main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tomás Cohen Arazi changed: What|Removed |Added Attachment #59354|0 |1 is obsolete|| --- Comment #21 from Tomás Cohen Arazi --- Created attachment 60992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60992&action=edit Bug 17755: (QA followup) Return $self when appropriate As failure situations raise exceptions that should be handled outside the object class, methods should return $self so successive calls can be chained nicely. This patch makes methods return $self and adjusts the tests to reflect this change. Make sure tests pass: - Run: $ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests return green - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tomás Cohen Arazi changed: What|Removed |Added Attachment #58495|0 |1 is obsolete|| Attachment #58498|0 |1 is obsolete|| --- Comment #18 from Tomás Cohen Arazi --- Created attachment 60989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60989&action=edit Bug 17755: Introduce Koha::Object::Limit::Library This patch introduces a new class for extending Koha::Object using multiple inheritance. It cannot be used standalone, it needs to be used in Koha::Object implementations like this: use base qw( Koha::Object Koha::Object::Limit::Library ); Its goal is to provide a single way and place to deal with this common pattern in Koha's codebase. As it happened with Koha::Object, that needed to be tested in a real object class, this work was done on top of Koha::Patron::Attribute::Type implementation and it is fully covered by the tests that are introduced for it. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tomás Cohen Arazi changed: What|Removed |Added Attachment #58497|0 |1 is obsolete|| --- Comment #20 from Tomás Cohen Arazi --- Created attachment 60991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60991&action=edit Bug 17755: Introduce Koha::Patron::Attribute::Type(s) This patch introduces the Koha::Object-based classes for handling patron attribute types. It also adds branch limitation handling to the Koha::Patron::Attribute::Type class. It is built on top of the new Koha::Object::Library::Limit class that extends Koha::Object so it handles library limits. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tomás Cohen Arazi changed: What|Removed |Added Attachment #58496|0 |1 is obsolete|| --- Comment #19 from Tomás Cohen Arazi --- Created attachment 60990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60990&action=edit Bug 17755: Unit tests This patch introduces unit tests for Koha::Object::Library::Limit. It is done this way because it needs to be instantiated to be usable. To test: - Run: $ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18144] Removal of persona broke Google OAuth2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18144 M. Tompsett changed: What|Removed |Added Summary|Removal of persona broke|Removal of persona broke |openidconnect |Google OAuth2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 --- Comment #15 from Radek Šiman (R-Bit Technology, s.r.o.) --- One preference is a good idea, I will change it. I understand the security reasons about cross-site inclusion of javascripts. The problem is, this a 3rd party service we really like and we trust it, because it's widely used in our country including a leader of IT market. Not a good reason, I know. Currently they offer direct linkage only. I am not sure if they will ever allow to download the sources as a package. It is connected to their database structure and so they have a good control over compatibility issues, I think. However, I'll try to ask them for the sources. For your information, please look at http://www.smartform.cz/index.html and you will see how the service grows on the graph in the right bottom corner of the page. The only reason to ask for the current form is a growing community of this service users in the Czech Republic. Originally we had an idea similar to the Norwegian patron database and we planned this feature for our country only. On the other hand, you are right that kind of general plugin or driver would be useful, but it highly exceeds the original limits. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #16 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #15) > QA Comment > Code looks good to me. Note some wording issues and one blocker in the db > revision. Did not yet test the interface. > > not_always is kind of a vague name for an option ;) > There is a charge of [% RESERVE_CHARGE %] for collecting this hold > There is a charge of [% RESERVE_CHARGE %] for placing this hold > Shouldn't it be better to say WHEN collecting this hold or WHEN placing this > hold ? > You have been charged for collecting this item. > Why did they charge me? Shouldn't you mention the the term "hold fee" here > too? Can we get a native English speaker confirm the wordings? > sco-main.pl > You check if a hold exists before issuing. Shouldn't you check for the > borrowernumber too? Indeed. > BTW Why not just call GetReserveFee here instead? You do not need to check > holds and account_lines anymore. And additionally you can pass the exact > amount in the message. The idea was to make sure the patron has been charged. From the circulation and reserves modules we are never really sure that what we want to happen will happen > If you would still check account_lines, why not search for "Reserve Charge - > $title" too? To avoid to depend on a string that could change, but I can add it if you think it's safer. > Please rename bug_X.sql. > Additionally, if the pref is set to 'always', you should now change the > value to any_time_is_placed. Since you remove always !! Indeed, will fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16895] Allow writeoffs via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 --- Comment #4 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #3) > Any chance to include some kind of unit testing? We have some tests for > MsgType.. > Can you further explain the use of the pay_type? Yes, it is a legacy parameter that simply declares this payment was made via SIP. > If I follow the chain, it > gets written to the accounts table with a sip prefix? But is that the only > thing it does, or do I overlook any specific behavior for sip payment type? Nope, that is literally all it does, it is existing behavior that we are continuing to use. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17605] EDI should set currency in order record on creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #6 from Marcel de Rooy --- (In reply to Colin Campbell from comment #5) > (In reply to Marcel de Rooy from comment #4) > > Note that we have a Koha::Object for Bookseller(s) > > By not using the Koha::Object this patch will apply to the stable banches > 16.5 and 16.11 Booksellers.pm and hence the find method only present in > master Agreed. Sounds reasonable for the stable branches. Since the patch only deals with two lines, you could also supply two versions? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #38 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #37) > Please move the countries somewhere else :) I do not know what you mean, it's how it is done in admin/preferences/admin.pref I know it is not ideal to have that list in 2 places, but it will not be easy to centralise it. I would prefer to deal with that on another bug report, unless you have something easy to suggest? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17605] EDI should set currency in order record on creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #5 from Colin Campbell --- (In reply to Marcel de Rooy from comment #4) > Note that we have a Koha::Object for Bookseller(s) By not using the Koha::Object this patch will apply to the stable banches 16.5 and 16.11 Booksellers.pm and hence the find method only present in master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16895] Allow writeoffs via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- Any chance to include some kind of unit testing? We have some tests for MsgType.. Can you further explain the use of the pay_type? If I follow the chain, it gets written to the accounts table with a sip prefix? But is that the only thing it does, or do I overlook any specific behavior for sip payment type? Please clarify. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 --- Comment #7 from Jonathan Druart --- Created attachment 60988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60988&action=edit Bug 17971: Add support for objects represented by fk For instance an issue is not fetch from its fk but using the fk itemnumber. We need to support them. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971
Jonathan Druart changed:
What|Removed |Added
Attachment #59529|0 |1
is obsolete||
Attachment #59530|0 |1
is obsolete||
--- Comment #6 from Jonathan Druart
---
Created attachment 60987
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60987&action=edit
Bug 17971: TT syntax for notices - Add support for plurals
On of the awesome things we will be able to do with the TT syntax is the
support of plurals.
For instance we will be able to send a list of items, checkouts, etc. to the
notice template.
That way we will get rid of our custom syntax like <> or
for instance.
The existing code already has the playground for that but it is not used.
Basically the idea is to add a "loops" key which can contain a list of
object to retrieve from the DB and send to the template.
For instance:
loops => { overdues => [ $itemnumber_1, .., $itemnumber_N ] }
will send a variable "overdues" to the template. It will contain the
Koha::Checkout objects relative to the id passed.
There is one quite big inconvenient to this approach so far: since we
are still supporting the historical syntax, the objects can be fetch by
a script, then the script will send the id to GetPreparedLetter which
will refetch them.
This must be improved, but I suggest to do that later.
Test plan:
prove t/db_dependent/Letters/TemplateToolkit.t
should return green
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16034] Integration with OverDrive Patron API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16034] Integration with OverDrive Patron API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #84 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #82) > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 > > Should we close this one then? At least "pushed to master", not sure resolved is appropriate when there are known bugs. Did you also fix comment 80? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16034] Integration with OverDrive Patron API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16034] Integration with OverDrive Patron API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16034] Integration with OverDrive Patron API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart changed: What|Removed |Added Depends on||16034 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 [Bug 16034] Integration with OverDrive Patron API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16034] Integration with OverDrive Patron API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart changed: What|Removed |Added Blocks||18243 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What|Removed |Added Attachment #60902|0 |1 is obsolete|| --- Comment #57 from Mehdi Hamidi --- Created attachment 60986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60986&action=edit Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208
--- Comment #4 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #3)
> my $items = Koha::Items->search({ biblionumber => $biblionumber });
> +
> +while ( my $item = $items->next ) {
> +$not_onloan_items++
> +if not $item->onloan;
> +}
> Can't you combine that in one statement?
>
> In general: Do I understand correctly that this is not an optional filter?
> We will always save the not onloan count to 999$x?
> Can you also add some explanation on this report why we definitely need it?
> At this point we are not using it in the codebase. But if we should do after
> some time, would it feel good to rely on a field in the search engine when
> we can generate the count in one Koha::Items call ?
> No blockers, just convince me..
The record will always inject that. And is going to be used on indexing only.
See bug 18098.
When it comes to filtering search results (records with available items this
time) we need the index for being able to build the filtering query. We already
do that but the query is not working, and this way writing the query seems
straightfowrad. Just check if the index has a value higher than 0. Period.
RecordProcessor filters should be used for lots of things (specially stuff done
in C4::Biblios) like embedding items...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17479] REST API: Save information on owner access
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479 --- Comment #7 from Marcel de Rooy --- (In reply to Lari Taskula from comment #6) > In Mojolicious, the stash, which we use for this flag, is a non-persistent > storage only for the current request. So it will be cleared for the > following requests and then set again. OK I suspected that. Altough clearing it in the else still seems safe.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17479] REST API: Save information on owner access
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479 --- Comment #6 from Lari Taskula --- In Mojolicious, the stash, which we use for this flag, is a non-persistent storage only for the current request. So it will be cleared for the following requests and then set again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Marcel de Rooy --- This does not seem to work. I tested table virtualshelves (added a column). The results between running with table only and on the whole db are different. If you run only on one table, you loose has_many and belongs_to etc. Seems quite dangerous.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #37 from Marcel de Rooy --- Please move the countries somewhere else :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
--- Comment #3 from Marcel de Rooy ---
my $items = Koha::Items->search({ biblionumber => $biblionumber });
+
+while ( my $item = $items->next ) {
+$not_onloan_items++
+if not $item->onloan;
+}
Can't you combine that in one statement?
In general: Do I understand correctly that this is not an optional filter? We
will always save the not onloan count to 999$x?
Can you also add some explanation on this report why we definitely need it?
At this point we are not using it in the codebase. But if we should do after
some time, would it feel good to rely on a field in the search engine when we
can generate the count in one Koha::Items call ?
No blockers, just convince me..
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18058] 'borrowers-force-messaging-defaults --doit --truncate ' gives DBI error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18058 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #4 from Marcel de Rooy --- Delete instead of truncate indeed seems to be a better idea here.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18058] 'borrowers-force-messaging-defaults --doit --truncate ' gives DBI error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18058 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18058] 'borrowers-force-messaging-defaults --doit --truncate ' gives DBI error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18058 Marcel de Rooy changed: What|Removed |Added Attachment #60479|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18058] 'borrowers-force-messaging-defaults --doit --truncate ' gives DBI error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18058 --- Comment #3 from Marcel de Rooy --- Created attachment 60985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60985&action=edit Bug 18058: Allow borrower_message_preferences to be truncated borrower_message_preferences cannot be truncated because of the foreign. DBMS fails with "Cannot truncate a table referenced in a foreign key constraint" To avoid that we should remove the FK check and truncate the other table as well. I am wondering if we really need a truncate here DELETE FROM borrower_message_preferences; should do the job, but leave it as it because of the param name. Test plan perl misc/maintenance/borrowers-force-messaging-defaults --doit --truncate Should no longer raise the error message Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18058] 'borrowers-force-messaging-defaults --doit --truncate ' gives DBI error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18058 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Marc Véron changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #1 from Marc Véron --- Created attachment 60984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60984&action=edit Bug 18244: Patron card creator does not take in account fields with underscore (B_address etc.) Fields with underscore like B_address do not print on patron cards. To reproduce: - Create patron card layout using fields with underscore in their name (e.g. ) - Print (export) patron card - Verify that fields without underscore are replaced by their value, but fields with underscore do not replace but show the field name To test: - Apply patch - Try to reproduce and verify that fields with underscore are replace as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch --- Comment #7 from Marcel de Rooy --- acqui/ajax-getauthvaluedropbox.pl We should actually use a html template here and move the html stuff outside the script. Yes, it was already there, but this is/was an opportunity? Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Marc Véron changed: What|Removed |Added Assignee|cnighswon...@foundations.ed |ve...@veron.ch |u | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 Marcel de Rooy changed: What|Removed |Added Attachment #60020|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 60983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60983&action=edit Bug 17847: Remove C4::Koha::GetAuthvalueDropbox Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 Marcel de Rooy changed: What|Removed |Added Attachment #60019|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 60982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60982&action=edit Bug 17847: Replace C4::Koha::GetAuthvalueDropbox with Koha::AuthorisedValues The C4::Koha::GetAuthvalueDropbox subroutine does the same job as Koha::AuthorisedValues->search We should then replace the different calls to this subroutine to finally remove it. There were 2 calls to this subroutine: - from the AuthorisedValues TT plugin (called from av-build-dropbox.inc and members/housebound.tt) - from the acqui/ajax-getauthvaluedropbox.pl ajax script To make sure that this patchset does not introduce regressions, we will have to test that the TT plugin and the ajax script still behave as before. Test plan: 1/ Test acqui/ajax-getauthvaluedropbox.pl - Link a fund to an authorised value category - Create a new order => When you select a fund linked to AV category, the sort1 (and/or sort2, depending on what you set) should be replaced with a dropdown list populated with the authorised values 2/ Test av-build-dropbox.inc - Create some authorised values for Bsort1 - Edit a patron => The sort1 should be a dropdown list populated with the Bsort1 AV 3/ Test members/housebound.tt - Enable the housebound module (pref HouseboundModule) - On the patron detail page, click on the "Housebound" tab => The frequency dropdown list should be populated with the different HSBND_FREQ AV Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18244] New: Patron card creator does not take in account fields with underscore ( B_address etc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Bug ID: 18244 Summary: Patron card creator does not take in account fields with underscore (B_address etc.) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: ve...@veron.ch QA Contact: testo...@bugs.koha-community.org Fields with underscore like B_address do not print on patron cards. To reproduce: - Create patron card layout using fields with underscore in their name (e.g. ) - Print (export) patron card - Verify that fields without underscore are replaced by their value, but fields with underscore do not replace but show the field name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Marcel de Rooy changed: What|Removed |Added Attachment #60013|0 |1 is obsolete|| --- Comment #9 from Marcel de Rooy --- Created attachment 60981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60981&action=edit Bug 17844: Replace C4::Koha::get_notforloan_label_of with Koha::AuthorisedValues This patch is more a bugfix than a refactoring. Indeed the C4::Koha::get_notforloan_label_of behaviors were buggy: 1/ It does not display the opac description at the OPAC, but always the staff description 2/ It does not care of the framework of the biblio, but retrieve the first row of the marc_subfield_structure mapped with items.notforloan These 2 bugs can easily be fixed using the Koha::AuthorisedValues->search_by_koha_field Steps to recreate the issues: - Create 2 authorised value categories for not for loan (NFL1 and NFL2) with the same values. Define a different description for the OPAC. - Define link 952$7 to NFL1 for the default framework and to NFL2 for the BK framework - Create 2 bibliographic records (B1 using NFL1 and B2 using NFL2) with 2 items each (1 item should have a not for loan value) - Go to the "Place a hold" view for this record. - In the item list, you should see the not for loan value => The staff description of NFL1 will always be used, even for the OPAC Test plan: - Recreate the issues without this patchset - Apply this patchset - Recreate the steps to recreate the issues => The staff description of NFL2 should be displayed for the B2 item => The opac description of NFL2 should be displayed for the B2 item at the OPAC Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Marcel de Rooy changed: What|Removed |Added Attachment #60012|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 60980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60980&action=edit Bug 17844: Remove C4::Koha::get_notforloan_label_of Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13371] Add filters to the supplier list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #76 from Marcel de Rooy --- Jonathan or Julian: Could you try to get some more feedback on this bug in view of earlier comments (for example 71 and 72) ? Mailing list, IRC, etc. ? Without some more positive feedback, this patch gets stuck here.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||m.de.r...@rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- Applying on top of 17970: Applying: Bug 17971: TT syntax for notices - Add support for plurals fatal: sha1 information is lacking or useless (C4/Letters.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #14 from Marcel de Rooy --- Few questions: Why not only have one preference? If the client id is empty, the pref is obviously not enabled. We already have so much preferences ;) >From a security perspective, I do not really like to include code like this: http://smartform.cz/api/v1/smartform.js";> Can we do it some other way? Add it to a local lib directory, and have more control? In general: Can you convince me why we should push it in this current form? I could imagine that we could have a more general 'plugin' that operates on address fields and allows access to selected web services, or so? Anyway, thanks for your work ! Your answers or adjustments may bring this further. Changing status to reflect need for feedback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Alex Arnaud changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #18 from Alex Arnaud --- Created attachment 60979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60979&action=edit Bug 10382 - Course reserves: handle empty values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
