[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #33 from Marcel de Rooy --- (In reply to Christopher Brannon from comment #32) > I think this patch needs to focus on this topic as a whole and not as a > piece. I think we can't solve all issues on one report. So we have to agree on the goal we want to reach, but do it step by step. > Perhaps what can be done is to setup a button on the list to transfer > ownership. Would be a nice feature. > I think a superlibrarian should also have the ability to transfer, with the > same options, but they get the ability to chose any patron to send the > request to. Why exactly? The privacy discussion comes up here.. > Another approach for patrons being deleted with shared lists is to have the > disowned list be listed in a group of unowned shared lists. > Another question arises...does a shared list have to be owned? > If a list is shared or public, couldn't it remain unowned? The lists module has not really been designed that way. The option that I mentioned already a few times, is a compromize in this direction: create a fake staff user that owns all these lists; could be a pref. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18110] Adds FR to the syspref AddressFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #25 from Baptiste --- Created attachment 61639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61639&action=edit BUG 18810: Removed unwanted spaces -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #34 from Katrin Fischer --- I think there is a different understanding in shared and shared with public - shared means shared with selected other users by invitation. For those privacy applies. For the public/shared with public, I think the idea of having a general inheriting user is fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #35 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #34) > For the public/shared with public, I think the idea of > having a general inheriting user is fine. If we would have consensus about that, we could perhaps apply the following algorithm to public lists now ? Would this provide sufficient flexibility? When deleting a public list, if pref GeneralPublicListOwner[?] is a specific userid then move ownership to that user elsif pref == current user then move to current staff member else delete list endif And open another report to handle shared lists. And another one for transferring ownership? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #36 from Katrin Fischer --- +1 for moving shared lists and transfer to another bug report. We could use the Anonymous patron - not sure if that would make sense. Otherwise for me that sounds fine - my only worries are only about the shared ones. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Benjamin Rokseth changed: What|Removed |Added Attachment #61200|0 |1 is obsolete|| --- Comment #16 from Benjamin Rokseth --- Created attachment 61640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61640&action=edit Bug 12021 - SIP2 checkin should alert on transfer and use CT for return branch This small patch corrects the SIP2 checkin response if branch transfer is needed. It depends on bug 7981 and also removes an obsolete alert check in SIP2. Test plan: - apply bug 7981 - make sure syspref AutomaticItemReturn is false - check 'Return policy' in 'Default checkout, hold and return policy' - make a SIP2 checkout and checkin from a branch different than item's home branch. - verify that SIP2 response gives alert CV04 (=send to different branch) - also verify that response field CT gives correct branch according to 'Return policy' Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #23 from Paul Poulain --- Hi David, I think that we use the "reports" word on the code, the term "statistic" is used only on the RFC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #33 from Alex Sassmannshausen --- (In reply to Marcel de Rooy from comment #22) > (In reply to Alex Sassmannshausen from comment #20) > > Claire and I have deliberated for a bit at the hackfest, and we think the > > following would be minor improvements (though it kind of works as it is). > > Great. Thanks. > > > > There is a charge of [% RESERVE_CHARGE %] for collecting this hold > > You will be charged a hold fee of [% _ %] for collecting this item > > Although I am not a native speaker, maybe we can still improve here :) Note > that opac-reserve tells this to the user. So the time is placing the hold, > but collecting it is still in the future. We do not charge for collecting > btw, we just charge when you collect.. Shouldn't it be better to say You > will be charged WHEN collecting? (Very strictly, we can't say THIS item; > could be a biblio level hold. Maybe: book, material, or just 'it'.) > So I would opt for: You will be charged WHEN collecting THE item. > No blocker btw. Fwiw, I agree with this reasoning you, Marcel (though I think the tense 'collecting' is not quite right): You will be charged a hold fee of [% RESERVE_CHARGE %] when you collect the item. Jonathan, would you be happy for me to add a patch for this? Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18337] New: No results found when advanced searching branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18337 Bug ID: 18337 Summary: No results found when advanced searching branches Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: martin.stas...@teamlibrary.cz QA Contact: testo...@bugs.koha-community.org Hello, I have a problem with advanced searching for specific branch without (or with - doesn't matter) another limit. I always get message: "No results found" in spite of there are a tons of books in the selected branch. Here is my searching url: search.pl?idx=kw&idx=kw&idx=kw&limit=branch%3APKK&sort_by=relevance By some research I found that if I delete "branch%3A" I get some results. We use a multi-instance Koha and the other instances have correct search. Can you help me, please. Kind regards, Martin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15690] Unconstrained CardnumberLength preference conflicts with table column limit of 16
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690 Martin Renvoize changed: What|Removed |Added Blocks||18338 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18338 [Bug 18338] Replace varchar(16) with varchar(32) for cardnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18338] New: Replace varchar(16) with varchar(32) for cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18338 Bug ID: 18338 Summary: Replace varchar(16) with varchar(32) for cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: hector.hecax...@gmail.com, indr...@l2c2.co.in, jonathan.dru...@bugs.koha-community.org, julian.maur...@biblibre.com, k...@bywatersolutions.com, m.de.r...@rijksmuseum.nl, m...@kohaaloha.com, oleon...@myacpl.org, testo...@bugs.koha-community.org, tomasco...@gmail.com, ve...@veron.ch Depends on: 15690 Bug #15690 makes it more explicit that cardnumber is limited at the database level to 16 characters, but it does not go any way towards increasing that field length for those using cardnumbers of greater lengths. I think we should increase the database field size from 16 characters to 32, giving us ample growing space for longer cardnumbers. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690 [Bug 15690] Unconstrained CardnumberLength preference conflicts with table column limit of 16 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #34 from Colin Campbell --- (In reply to Marcel de Rooy from comment #32) > Just for completeness: > Colin: See comment 24. The currently applied hold fee at the time of placing > a hold is not shown in SIP. I guess that placing a hold via SIP is not that > common as checking out. I suspect the hold messages are not used in practice. Hence the code only returns failure messages in its current skeletal state. If any are used it would be the cancel and possibly alter functions, I dont think self checks have the interface to let you search for an item to hold in order to place it, whereas it could possible retrieve a user's holds to allow them to cancel them. I would imagine that items are not checked out to the holder via self check as they have to collect the item from a staffed hold shelf. I may be wrong but I think if we are going to change the sip code I'd like to have a user's scenario of what the workflow is rather than concocting it from possibly mistaken abstractions. So I suggest any sip implications be dealt with in a separate call -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #35 from Marcel de Rooy --- (In reply to Colin Campbell from comment #34) > (In reply to Marcel de Rooy from comment #32) > > Just for completeness: > > Colin: See comment 24. The currently applied hold fee at the time of placing > > a hold is not shown in SIP. I guess that placing a hold via SIP is not that > > common as checking out. > > I suspect the hold messages are not used in practice. Hence the code only > returns failure messages in its current skeletal state. If any are used it > would be the cancel and possibly alter functions, I dont think self checks > have the interface to let you search for an item to hold in order to place > it, whereas it could possible retrieve a user's holds to allow them to > cancel them. > > I would imagine that items are not checked out to the holder via self check > as they have to collect the item from a staffed hold shelf. > > I may be wrong but I think if we are going to change the sip code I'd like > to have a user's scenario of what the workflow is rather than concocting it > from possibly mistaken abstractions. So I suggest any sip implications be > dealt with in a separate call Well, at least I learned a new word :) Concoct. My message stated more or less the same: placing a hold in SIP is probably useless. If we put the SIP change in another report, you may have the effect that this patch is pushed into 17.05 and the sip followup is not.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Johan Larsson changed:
What|Removed |Added
Attachment #61065|0 |1
is obsolete||
--- Comment #52 from Johan Larsson ---
Created attachment 61641
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61641&action=edit
Bug 14957 - Rule based permission for MARC fields
Add a rule based permission system for MARC field modifications.
Test plan:
1. Apply this patch
2. Run updatedatabase.pl
3. Log in to staff client
4. Enable new syspref MARCPermissions
5. You should see a new link "MARC field permissions" in the "Catalog"
section under "Koha administration".
6. Go to the "MARC field permissions" page
7. Next to the page heading ("Manage MARC field permissions") there is a
button with a question mark, click this for more information about the
rule system.
8. Add desired rules to the rule table, press the +-button to add.
9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
10. Clicking the x-icon should remove corresponding rule after
confirmation.
11. Selecting one or more rules followed by clicking the trash-icon
should remove all selected rules after confirmation.
12. To test your rules, import or in other way modify a record.
13. Check that the record was modified as defined by your rules.
Sponsored-by: Halland County Library
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Johan Larsson changed: What|Removed |Added CC||johan.lars...@ub.gu.se --- Comment #53 from Johan Larsson --- corrected spelling error in commit message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18110] Adds FR to the syspref AddressFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #26 from Marc Véron --- (In reply to Marc Véron from comment #22) > Hi Babtiste, > > Changes work fine, but please have a look at Alternate address as well, > streetnumber is on a separate line and street type is after address. > > See: member-display-alt-address-style-fr.inc > > Marc Hi Babtiste, With Alternate address, I get: Alternate address 777 Royale rue 75002 Paris France I would expect 777 rue Royale -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17993] Do not use modal authentication with CAS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 --- Comment #6 from Fridolin SOMERS --- (In reply to M. Tompsett from comment #5) > Missed a spot: opac-tags.pl > Is that fixed elsewhere, or should it be fixed here? Indeed, I'll fix this -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18314] Account lockout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18315] authentication and authorization refactoring
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18315 --- Comment #3 from Francesco Rivetti --- added few more fixes: - honor cgi->redirect() - trap exit() and instead returns what has been sent so far - added session->remote_addr() - added branchname in session and LoginBranchName in templates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12913] wrong inventory results when notforloan filter is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14399] "missingitem" code from inventory.pl doesn't work properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17993] Do not use modal authentication with CAS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 --- Comment #7 from Fridolin SOMERS --- Created attachment 61642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61642&action=edit Bug 17993 - Do not use modal authentication with CAS - tags bis Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link for tags in detail tags page : "Log in to see your own saved tags." Test plan : - Enable syspref casAuthentication - Go to OPAC, not authenticated - Click on "Tag cloud" - Click on "Log in to see your own saved tags" => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17993] Do not use modal authentication with CAS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Fridolin SOMERS changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #8 from Fridolin SOMERS --- "tags bis" needs sign off. Mark, thanks a lot for your help. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #59 from Jonathan Druart --- (In reply to Jonathan Druart from comment #58) > (In reply to Katrin Fischer from comment #57) > > This won't get ported back to 16.11.x as it is an enhancement. > > That will need to be backported into stable releases, otherwise we will have > to wait too long to get enough people using it. This is especially true for bug 18066. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18329] Batch record deletion broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 --- Comment #4 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #3) > Just wrote exactly the same patch, did not see yours! awsome ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18329 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18329] Batch record deletion broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=8970 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #14 from Jonathan Druart --- For 16.11.x you just need to replace Koha::Old::Checkout with Koha::OldIssue (bug 17796). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #58 from Jonathan Druart --- (In reply to Katrin Fischer from comment #57) > This won't get ported back to 16.11.x as it is an enhancement. That will need to be backported into stable releases, otherwise we will have to wait too long to get enough people using it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #43 from Francesco Rivetti --- (In reply to Jonathan Druart from comment #41) > (In reply to Katrin Fischer from comment #40) > > This seems to use some new constructs, is this safe for backporting to > > 16.11.x? > > That would need to be tested, I only tested against master. Agreed. I don't see why it shouldn't work, but that should be tested before. F -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #36 from Jonathan Druart --- Marcel, by chance could you rephrase with what you want on QAing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17995] HOLDPLACED notice should have access to the reserves table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17995 --- Comment #6 from Jonathan Druart --- I think this is a bug fix, users can select data from the reserves table, but it will not work if they do. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18222] Fix tests broken by Bug 18026
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18222] Fix tests broken by Bug 18026
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 Jonathan Druart changed: What|Removed |Added Status|Pushed to Master|ASSIGNED --- Comment #8 from Jonathan Druart --- No, it's not pushed yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18222] Fix tests broken by Bug 18026
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 Jonathan Druart changed: What|Removed |Added Resolution|--- |FIXED Status|Needs Signoff |RESOLVED --- Comment #9 from Jonathan Druart --- Yes it is!! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Jonathan Druart changed: What|Removed |Added Summary|HEA : add possibility of|HEA : add possibility of |sharing usage statistics in |sharing usage statistics in |Administration page and Web |Administration page |installer | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18321] One more checkouts possible than allowed by rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- Would it be possible to get a screencast, or a sandbox set up with your settings? I still do not recreate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 --- Comment #12 from Martin Renvoize --- Created attachment 61643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61643&action=edit Add configuration for zebra based faceting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 Martin Renvoize changed: What|Removed |Added CC||mag...@libriotech.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 --- Comment #13 from Martin Renvoize --- Thanks for that pointer Tomas.. zebra facets vs non-zebra facets.. We had all our test systems set to non-zebra -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 --- Comment #14 from Martin Renvoize --- Magnus, I wanted to check whether you also wanted this in the NORMARC configs? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 61644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61644&action=edit Bug 17828: (QA followup) Add ->type and reuse it Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18339] New: Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339 Bug ID: 18339 Summary: Koha::Patron::Attribute ->opac_editable and ->opac_display should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Now that bug 17828 introduces the ->type method, returning the related Koha::Patron::Attribute::Type object, there's no need for such specific method. It should be called $patron->type->opac_editable instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|gmcha...@gmail.com |tomasco...@gmail.com Depends on||17828 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 [Bug 17828] Koha::Patron::Attribute->store should raise an exception if unique_id is being broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Tomás Cohen Arazi changed: What|Removed |Added Blocks||18339 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339 [Bug 18339] Koha::Patron::Attribute ->opac_editable and ->opac_display should be removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 61645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61645&action=edit Bug 18339: Remove ->opac_editable ->opac_display from Koha::Patron::Attribute Trying to simplify the implementation of 13757, I replaced some legacy code in favour of a Koha::Object-based implementation for the OPAC controller scripts. On doing so I went too far with this methods, as what was needed was a way to retrieve the type of the attribute and ask it about such properties. This patch removes those methods, its tests, and replaces its uses in the codebase like this: $attribute->opac_editable for $attribute->type->opac_editable To test: - Run $ prove t/db_dependent/Koha/Patron/Attributes.t => SUCCESS: Tests still pass - Try changing the opac_editable and opac_display properties and play in the OPAC with those attributes. Verify that everything works as expected. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18321] One more checkouts possible than allowed by rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 --- Comment #6 from Marc Véron --- Created attachment 61646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61646&action=edit Screenshots to reproduce error Re-testing: - Set ConsiderOnSiteCheckoutsAsNormalCheckouts to 'Consider' - Delete all rules in 'Circulation rules and fines'. - Set a Default limit by patron category, e.g. Student with 2 current checkouts, 2 on-site-chekouts. - Normal (not On-Site) checkout to a student until the limit is reached (in this case: 2) - Try a 3rd checkout; it is possible (should not) - Try a 4th checkout: No longer possible. Message says: "Too many checked out. 3 checked out, only 2 are allowed." - Switch ConsiderOnSiteCheckoutsAsNormalCheckouts to 'Do not consider' - Check all items in - Repeat steps to reproduce - Checkout is blocked when trying to do 3rd checkout (as expected) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18321] One more checkouts possible than allowed by rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 Marc Véron changed: What|Removed |Added Attachment #61588|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12936] Road type value doesn't appear in OPAC borrower account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12936 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #2 from Marc Véron --- Tests pass fine, but if I make an attribute editable and try to edit /submit changes in OPAC, I get an Internal server error. Plack log says: The method opac_editable is not covered by tests! Without 17828 and 18339 applied, I can edit and submit the attribute from OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339
--- Comment #3 from Marc Véron ---
Maybe the following, with the change below I can save without getting an
Internal Server error:
diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl
index 9f2a607..bc54508 100755
--- a/opac/opac-memberentry.pl
+++ b/opac/opac-memberentry.pl
@@ -535,7 +535,7 @@ sub GeneratePatronAttributesForm {
my ( $borrowernumber, $entered_attributes ) = @_;
# Get all attribute types and the values for this patron (if applicable)
-my @types = grep { $_->opac_editable() or $_->opac_display }
+my @types = grep { $_->opac_editable or $_->opac_display }
Koha::Patron::Attribute::Types->search()->as_list();
if ( scalar(@types) == 0 ) {
return [];
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339 --- Comment #4 from Tomás Cohen Arazi --- Are you sure you restarted plack? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15149] Serials: Test prediction pattern does not consider Subscription start and end date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15149 J Schmidt changed: What|Removed |Added CC||jschm...@switchinc.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18340] New: Progress bar length is wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18340 Bug ID: 18340 Summary: Progress bar length is wrong Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Tools Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org The progress bar is never fully filled, even when 100% is hit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at First issue date, not Subscription start date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148 J Schmidt changed: What|Removed |Added CC||jschm...@switchinc.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18340] Progress bar length is wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18340 --- Comment #1 from Jonathan Druart --- Created attachment 61647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61647&action=edit Bug 18340: Fix progress bar length The progress bar (for background jobs) should be fully filled when 100% is hit, right? :) It has been introduced quite long time ago when the size of the progress bar has been changed from 150 to 200px, and the code has been refactored. Test plan: Launch a big modification/deletion of records/items in a batch. You should see the progress bar progressing to 100 and reach 100! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18340] Progress bar length is wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18340 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18341] New: NO-BREAK SPACE is not counted as white space in search queries.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18341 Bug ID: 18341 Summary: NO-BREAK SPACE is not counted as white space in search queries. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Created attachment 61648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61648&action=edit CSV file containing titles separated by NO-BREAK SPACE I've transcribed this from a ticket that one of our partners submitted. A librarian noted that she had an Excel spreadsheet of titles she was copying and pasting into Koha to search, and occasionally one of the titles wouldn't come up even though they have the book. ( CSV file containing titles is attached.) She noted if she just typed the title into Koha, it came up w/o a problem. Here's a screenshot of one of the failed searches. Notice the %C2%A0 between the words. That's the UTF-8 code for non-breaking space (see http://www.fileformat.info/info/unicode/char/00a0/index.htm). -- The underlying issue here is that when we paste in a search term containing the unicode NO-BREAK SPACE glyph, this arguably should be treated as white space, and the search should succeed if it matches strings with words separated by other whitespace characters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don' t work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 Jonathan Druart changed: What|Removed |Added Attachment #44011|Bug 15032: Make sure the|[OBSOLETE?] Bug 15032: Make description|filehandle is not close on |sure the filehandle is not |background mode |close on background mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don' t work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #20 from Jonathan Druart --- Created attachment 61649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61649&action=edit Bug 15032: Try to fix background jobs - batch_record_modification.pl I do not really understand how behave this patch, sometimes it works, sometimes not. It would be good to get other people testing and reading it to try and understand what's happening. It may be a first step to fix our background jobs. The thing is that we cannot close STDOUT, Plack (CGI::Emulate::PSGI) is expecting it opened (search for 'seek'). If we close STDOUT and keep 'text/html' in the headers, it works almost correctly: but we got the JSON content + the headers printed by the child. With the redirect we a getting the right page when the job is finished. But sometimes we see the plain text content (with the JSON headers) + a 302 Any thoughts? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339 --- Comment #5 from Marc Véron --- (In reply to Tomás Cohen Arazi from comment #4) > Are you sure you restarted plack? Yes. Several times. I even restarted the server. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don' t work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #21 from Tomás Cohen Arazi --- I thought about this a couple times. There's some race between parent process and the fork closing the file handle for STDOUT. The best approach is to use some lib for creating child processes that takes care of this, or look carefully at what process needs a handle for STDOUT and which doesn't. The backgrounded job is supposed to communicate its status through the DB, and the progress bars talk to a separate /svc endpoint, so the backgrounded job doesn't need STDOUT. That's why it is being closed (I guess) but it looks wrong at first glance. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don' t work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #22 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #21) > I thought about this a couple times. There's some race between parent > process and the fork closing the file handle for STDOUT. The best approach > is to use some lib for creating child processes that takes care of this, or > look carefully at what process needs a handle for STDOUT and which doesn't. > > The backgrounded job is supposed to communicate its status through the DB, > and the progress bars talk to a separate /svc endpoint, so the backgrounded > job doesn't need STDOUT. That's why it is being closed (I guess) but it > looks wrong at first glance. http://search.cpan.org/~bzajac/Proc-Background-1.10/lib/Proc/Background.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16660] Elasticsearch broken if OpacSuppression is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16660 --- Comment #6 from Srdjan Jankovic --- Claire, would you be able to have a look at the log file and tell me what is the error please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18314] Account lockout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com Status|Needs Signoff |Failed QA --- Comment #10 from Aleisha Amohia --- Hi, patch and db update apply cleanly. I see no change in behaviour in staff client nor opac side. I set the FailedLoginAttempts to 3, but I was able to attempt logging in with the wrong password unlimited times. Also, tests fail: # Subtest: update_password 1..7 ok 1 - Koha::Patron->update_password should warn if the userid is already used by another patron ok 2 - Koha::Patron->update_password should not have updated the userid ok 3 - Koha::Patron->update_password should not have updated the userid # Looks like you planned 7 tests but ran 3. not ok 8 - update_password # Failed test 'update_password' # at t/db_dependent/Koha/Patrons.t line 183. The method update is not covered by tests!# Looks like your test exited with 255 just after 8. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 15/22 subtests Test Summary Report --- t/db_dependent/Koha/Patrons.t (Wstat: 65280 Tests: 8 Failed: 1) Failed test: 8 Non-zero exit status: 255 Parse errors: Bad plan. You planned 22 tests but ran 8. Files=1, Tests=8, 3 wallclock secs ( 0.03 usr 0.01 sys + 1.28 cusr 0.10 csys = 1.42 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18110] Adds FR to the syspref AddressFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Aleisha Amohia changed: What|Removed |Added Attachment #61610|0 |1 is obsolete|| --- Comment #28 from Aleisha Amohia --- Created attachment 61651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61651&action=edit BUG 18110: Corrected display address format - minor changes on address format - corrected member-password so that steetnumber is given to the template Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18110] Adds FR to the syspref AddressFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Aleisha Amohia changed: What|Removed |Added Attachment #60695|0 |1 is obsolete|| --- Comment #27 from Aleisha Amohia --- Created attachment 61650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61650&action=edit BUG 18110 : Correct display and syspref AddFormat Add a field FR to the syspref AddressFormat Testplan 1 - Apply patch 2 - Check if there is a field FR in the syspref AddressFormat, enable it 3 - Create a new borrower and check the order of the fields for the address 4 - Check if it's address appears in a propper manner 27/02/17 : Fixed the display Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18110] Adds FR to the syspref AddressFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Aleisha Amohia changed: What|Removed |Added Attachment #61639|0 |1 is obsolete|| --- Comment #29 from Aleisha Amohia --- Created attachment 61652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61652&action=edit BUG 18810: Removed unwanted spaces https://bugs.koha-community.org/show_bug.cgi?id=18110 Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18110] Adds FR to the syspref AddressFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10357] Send email when serial received subscription link is hard to find
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10357 Aleisha Amohia changed: What|Removed |Added Attachment #61531|0 |1 is obsolete|| --- Comment #6 from Aleisha Amohia --- Created attachment 61653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61653&action=edit Bug 10357: Adding link for email notification for new subscription issues to opac-detail This patch adds the link to the opac-detail.pl page so it is less hard to find. Update: Fixing link to look like button, adding span ID around element To test: 1) Add a subscription, attach it to a record and select a notice under 'Patron notification'. Hit Next, fill in some fields and save the subscription 2) Go to that record detail page in the OPAC. Go to the subscriptions tab, click 'More details'. Notice how many clicks it takes to see the 'Subscribe' button 3) Apply patch and go back to the details page for the record 4) Notice now there is a 'subscribe' link 5) Confirm this link still works as expected Sponsored-by: Catalyst IT Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10357] Send email when serial received subscription link is hard to find
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10357 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Attachment #59032|0 |1 is obsolete|| --- Comment #6 from Aleisha Amohia --- Created attachment 61654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61654&action=edit Bug 4461: Add a context-sensitive 'Report a Problem' feature to OPAC This patch adds a 'Report a problem' link to the bottom of every page in the OPAC. The user can choose to submit their report to the library or Koha administrator. The report will store the user's problem message, but also their username and the page they were on when they clicked the 'report a problem' link. The patch adds a table 'problem_reports' to the db. Update: This patch adds a check for the KohaAdminEmailAddress and library branch email before sending the report. Update: Fix merge conflicts To test: 1) Apply patch, update database, rebuild schema 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that your library does NOT have an email address. 5) Confirm that your syspref KohaAdminEmailAddress is NOT filled. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) Notice that there are error messages alerting that library does not have an email address and that the Koha Administrator does not have email address. Both submit buttons will be disabled. 9) Add an email address for your library. You may have to restart memcached again. The error message for the library email address will have disappeared and the Submit button for 'Report to library' will now work. 10) Add an email address for the syspref KohaAdminEmailAddress. You may have to restart memcached again. The error message for the administrator email address will have disappeared and the Submit button for 'Report to Koha Administrator' will not work. 11) First try submitting a problem to the library. Confirm that the fields for 'Problem found on page' and 'Username' are correct, then fill out the 'Subject' and 'Message' and click Submit. 12) Confirm a message shows at the top of the page to show success. 13) Go into mysql and display records from the message_queue table. Confirm that the borrowernumber and subject are correct. Confirm that content shows the message from the problem report, but also the user's username and the problem page. Confirm that the to_address shows the library's email address and the from_address shows the user's email address. 14) Now try submitting a problem to the Koha Admin. Fill fields and click Submit. Confirm message shows at top to show success again. 15) Check message_queue for new problem report. Confirm that the to_address shows the email address from the syspref KohaAdminEmailAddress. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18035] Front-end changes to serials -> Claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #3 from Aleisha Amohia --- (In reply to julien.comte from comment #2) > 7) Reset button doens't work: nothing happens. Reset button works perfectly for me. The button is meant to reset any changes you make to the last saved version of the numbering pattern, so it'll look like nothing happens unless you change something such as the Name of the pattern. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Attachment #57874|0 |1 is obsolete|| --- Comment #18 from Aleisha Amohia --- Created attachment 61655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61655&action=edit Bug 16939: Making all 'add to basket' actions buttons Edit: Fixing 'clas' typo in addorderiso2709.tt Edit: Adding actions class to td Edit: Fixing js error Edit: circ/reserveratios.tt updated so that the plus icon doesn't show if there is no link Edit: fixing logic in circ/reserveratios.tt Edit: merge conflicts Edit: updating buttons to bootstrap 3, which i believe fixes the problem in comment 16 To test: 1) Go to Acqui -> find a vendor -> view a basket 2) Click add to basket -> fill in 'for an existing record' and hit search 3) 'View MARC' and 'Order' buttons should show under an Actions column with appropriate icons 4) Click Order 5) Click add item when you are redirected to the New order page (no need to fill in any details) 6) Confirm that 'Edit' and 'Delete' buttons now show under an Actions column with appropriate icons 7) Go back to your basket and click add to basket -> from a subscription (we are skipping from a suggestion because this already has a button before my patch) 8) Confirm that 'Order' shows as a button with appropriate icon 9) Go back to your basket and click add to basket -> from an external source 10) fill in any fields and click search to bring up results 11) 'Order' should now show as a button with appropriate icons. MARC and Card preview have been moved into a dropdown menu - confirm this works as expected. Links have not been changed when clicking on a row 12) Go back to your basket and click add to basket -> from a staged file 13) 'Add orders' should now show as a button with appropriate icon 14) Go back to your basket and click add to basket -> from titles with highest hold ratios 15) 'X to order' should now show as a button with appropriate icon Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 --- Comment #15 from Magnus Enger --- (In reply to Martin Renvoize from comment #14) > Magnus, I wanted to check whether you also wanted this in the NORMARC > configs? Sure, no objections from me! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
