[Koha-bugs] [Bug 18315] authentication and authorization refactoring
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18315 --- Comment #4 from Francesco Rivetti --- this is something i forgot to mention before: I replaced WrapCGI and CGIBin with Koha::Middleware::App It pretty much do the same thing as WrapCGI (fork and require the cgi script) but instead of having the script building the response, it uses a pipe and serialize the data back to the parent. It's the first step to move the logic from the scripts to proper functions. It handles script exit() properly, and should work properly with other forks, which make it relevant to Bug 15032 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Marcel de Rooy changed: What|Removed |Added Attachment #61301|0 |1 is obsolete|| --- Comment #38 from Marcel de Rooy --- Created attachment 61669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61669&action=edit Bug 17560: Improve wordings Signed-off-by: Marcel de Rooy Amended as per comment33 of Alex Sassmannshausen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #39 from Marcel de Rooy --- (In reply to Alex Sassmannshausen from comment #33) > Fwiw, I agree with this reasoning you, Marcel (though I think the tense > 'collecting' is not quite right): > You will be charged a hold fee of [% RESERVE_CHARGE %] when you collect the > item. Amended last patch. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #40 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #36) > Marcel, by chance could you rephrase with what you want on QAing? Of course :) [1] If we checkout in the staff client, wouldn't it be good to also show a message? (Just like the sco message.) See comment23, 27 and 30. Show the fee under Attention just like rental fees. [2] Provide a message to the SIP terminal at checkout time. (a.o. comment31, 34) Note that Colin suggested to do this on another report. In that case we could perhaps add a small "disclaimer" to the preference that SIP does apply, but not show the fee at checkout time. And as a side note, SIP currently does not show a fee when placing a hold. But this is just a theoretical thing; not really used. [3] Since we need to show the same message at three locations, we could consolidate that code (now in sco-main.pl) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18315] authentication and authorization refactoring
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18315 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14399] "missingitem" code from inventory.pl doesn't work properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy changed: What|Removed |Added Resolution|DUPLICATE |--- Status|CLOSED |REOPENED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14399] "missingitem" code from inventory.pl doesn't work properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #4 from Marcel de Rooy --- Hmm Sorry for this door slamming. The follow-ups on 12913 would be too much. I will put them here on second thought. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12913] Fix wrong inventory results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12913] Fix wrong inventory results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Marcel de Rooy changed: What|Removed |Added Attachment #31568|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 61670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61670&action=edit Bug 12913 - wrong inventory results when notforloan filter is not used In inventory tool, there is a test on scanned items notforloan value : if the value is not one of authorized values, the inventory results displays the problem "Change item status". The bug is that if notforloan filter is not used, the notforloan values array is not filled and so all scanned items are marked with this problem. Test plan : - Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN' - Check the authorized value category has at least value '0' - Create a new value in this category, for example '9' - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' and notforloan=0 - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' and notforloan=9 - Delete new value created above, for example '9' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and '' - Check 'Compare barcodes list to results' - Submit => without patch, you get 2 results with problem 'Change item status' even for item with notforloan=0 => with patch, you get 1 result with 'Change item status' on item with notforloan=9 Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12913] Fix wrong inventory results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 --- Comment #11 from Marcel de Rooy --- Created attachment 61671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61671&action=edit Bug 12913: [QA Follow-up] Reword 'change item status' and add zero status The zero status should be added in @notforloans. It is a legitimate status for available books. The zero status description can be translated in the template. The 'Change item status' is confusing. We mean that we saw a notforloan status that we do not expect (read: does not exist in the table). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12913] Fix wrong inventory results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12913] Fix wrong inventory results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12913] Fix wrong inventory results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 --- Comment #12 from Marcel de Rooy --- This looks good to me. Note that we are not solving all problems in the script now. But I cannot overload this report and its signed off status. Will continue on report 14399 (reopened it). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12913] Fix wrong inventory results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Marcel de Rooy changed: What|Removed |Added Blocks||14399 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 [Bug 14399] "missingitem" code from inventory.pl doesn't work properly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14399] "missingitem" code from inventory.pl doesn't work properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy changed: What|Removed |Added Depends on||12913 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 [Bug 12913] Fix wrong inventory results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14398] Duplicate inventory results when an item is in the wrong place ( ie using branch/location filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14398 Marcel de Rooy changed: What|Removed |Added Resolution|--- |DUPLICATE CC||m.de.r...@rijksmuseum.nl Status|NEW |RESOLVED --- Comment #3 from Marcel de Rooy --- The problem with Change item status-lines is now resolved on bug 12913. I will address the Item missing-problem on bug 14399. That makes this bug a duplicate, since we would only keep one line for the wrongly placed item. *** This bug has been marked as a duplicate of bug 14399 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14399] "missingitem" code from inventory.pl doesn't work properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #5 from Marcel de Rooy --- *** Bug 14398 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14398] Duplicate inventory results when an item is in the wrong place ( ie using branch/location filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14398 Marcel de Rooy changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14399] "missingitem" code from inventory.pl doesn't work properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy changed: What|Removed |Added Status|REOPENED|ASSIGNED Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18144] Removal of persona broke Google OAuth2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18144 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to master for 17.05, thanks Mark! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #13 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18035] Front-end changes to serials -> Claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #4 from Marc Véron --- Does bug title fit? - "Front-end changes to serials -> Claims" Bug seems to be related to numbering patterns :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14399] "missingitem" code from inventory.pl doesn't work properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12631 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=14399 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18285] Koha::Database schema cache accessors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #2 from Marc Véron --- I have the impression that 18226 can be removed from 'Blocks' because 18286 blocks 18226 as well (see dependency graph https://bugs.koha-community.org/bugzilla3/showdependencygraph.cgi?id=18285) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834 --- Comment #13 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #12) > The datelastseen field on the inventory form is actually useless. Not completely btw. Bug 12631 describes a scenario with two partial barcode files and using this inventory date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12913] Fix wrong inventory results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Marcel de Rooy changed: What|Removed |Added Status|Passed QA |BLOCKED --- Comment #13 from Marcel de Rooy --- Still needs some attention -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12913] Fix wrong inventory results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Marcel de Rooy changed: What|Removed |Added Attachment #61671|0 |1 is obsolete|| --- Comment #14 from Marcel de Rooy --- Created attachment 61674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61674&action=edit Bug 12913: [QA Follow-up] Reword 'change item status' and add zero status The zero status should be added in @notforloans. It is a legitimate status for available books. The zero status description can be translated in the template. The 'Change item status' is confusing. We mean that we saw a notforloan status that we do not expect (read: does not exist in the table). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #61521|0 |1 is obsolete|| --- Comment #73 from Olli-Antti Kivilahti --- Created attachment 61675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61675&action=edit Bug 12026: Adds auto-provisioning to shibboleth - Adds the option to map shibboleth attributes to koha user columns and allows mapping to auto create non-existant users Signed-off-by: Mirko Tietgen Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #61523|0 |1 is obsolete|| --- Comment #75 from Olli-Antti Kivilahti --- Created attachment 61677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61677&action=edit Bug 12026: [Followup] Rebasing Signed-off-by: Mirko Tietgen Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #61525|0 |1 is obsolete|| --- Comment #77 from Olli-Antti Kivilahti --- Created attachment 61679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61679&action=edit Bug 12026: [QA Follow-up] POD typo and tiny change in AddMember_Opac [1] Correct xml error in POD Copy-pasting this example from Auth_with_shibboleth.pm into koha-conf.xml did not work. We need a closing tag ;) [2] If AddMember_Opac calls AddMember_Auto, there is no need to call fixup_cardnumber. Adding trivial test for AddMember_Auto in Members.t. Signed-off-by: Marcel de Rooy Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #61524|0 |1 is obsolete|| --- Comment #76 from Olli-Antti Kivilahti --- Created attachment 61678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61678&action=edit Bug 12026: Fix small errors When running tests I got two errors. Do these changes make sense? Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #61526|0 |1 is obsolete|| --- Comment #78 from Olli-Antti Kivilahti --- Created attachment 61680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61680&action=edit Bug 12026: [Rebase Follow-up] - Fix Test Signed-off-by: Marcel de Rooy Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18269] Move field mappings related code to Koha::FieldMapping[s]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18269] Move field mappings related code to Koha::FieldMapping[s]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269 Nick Clemens changed: What|Removed |Added Attachment #61093|0 |1 is obsolete|| Attachment #61094|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 61681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61681&action=edit Bug 18269: Add Koha::FieldMapping[s] packages Tested both patches together, works as expected. Signed-off-by: Marc Véron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312 Jonathan Druart changed: What|Removed |Added CC||steven.schmie...@gmail.com --- Comment #14 from Jonathan Druart --- *** Bug 18301 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18269] Move field mappings related code to Koha::FieldMapping[s]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269 --- Comment #6 from Nick Clemens --- Created attachment 61682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61682&action=edit Bug 18269: Move field mappings related code to Koha::FieldMapping[s] The 3 subroutines GetFieldMapping, SetFieldMapping and DeleteFieldMapping from the C4::Biblio module were only used from the field mappings admin page. They can easily replaced with new packages Koha::FieldMappings based on Koha::Object[s] Test plan: Add and delete field mappings (admin/fieldmapping.pl, Home › Administration › Keyword to MARC mapping). Add an existing mapping > Nothing should be added Note that this page has not been rewritten and you will not get any feedbacks, but it's not the goal of this page to improve it. Followed test plan, works as expected. Signed-off-by: Marc Véron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18301] export_records.pl from the tools menu fails with the message Internal Server Error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18301 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 18312 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #61599|0 |1 is obsolete|| --- Comment #80 from Olli-Antti Kivilahti --- Created attachment 61684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61684&action=edit Bug 12026: [QA Follow-up] Add Tests for autocreate https://bugs.koha-community.org/show_bug.cgi?id=12026 Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #61527|0 |1 is obsolete|| --- Comment #79 from Olli-Antti Kivilahti --- Created attachment 61683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61683&action=edit Bug 12026: [QA Follow-up] Fix a POD line Still refers to a removed parameter of _autocreate. Signed-off-by: Marcel de Rooy Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Olli-Antti Kivilahti changed: What|Removed |Added CC||olli-antti.kivila...@jns.fi --- Comment #81 from Olli-Antti Kivilahti --- Fixes failing test in t/Auth_with_shibboleth.t Thanks for the fix! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12913] Fix wrong inventory results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #61522|0 |1 is obsolete|| --- Comment #74 from Olli-Antti Kivilahti --- Created attachment 61676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61676&action=edit Bug 12026: [Follow up] Added Documentation Updated to work with match point selection - The base bug that this patch enhances has added the ability to choose your match point in the configuration file. This patch adds code to take that change into account. Signed-off-by: Mirko Tietgen Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14399] "missingitem" code from inventory.pl doesn't work properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #6 from Marcel de Rooy --- Created attachment 61685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61685&action=edit Bug 14399: Fix the code for missing items in inventory.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14399] "missingitem" code from inventory.pl doesn't work properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #7 from Marcel de Rooy --- Not ready yet. The inventory date is only used in combination with the compare barcodes checkbox. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834
--- Comment #14 from Marcel de Rooy ---
Small code review:
+my $datelastseen = $input->param('datelastseen') || $input->param('setdate');
We should not do that. It will disrupt some workflows.
Datelastseen is the inventory date.
-my $dls = output_pref( { dt => dt_from_string( $datelastseen ),
- dateformat => 'iso' } );
+1 for removing those two lines :)
I am removing this whole block on bug 14399. It is weird code.
-if (none { $item->{barcode} eq $_->{barcode} && !$_->{'onloan'} }
@$wrongplacelist) {
+if (none { $_->{barcode} && $item->{barcode} eq $_->{barcode} &&
!$_->{'onloan'} } @$wrongplacelist) {
Looks like rescuable lines to me now.
-ModDateLastSeen($item->{'itemnumber'});
+ModItem({ itemlost => 0, datelastseen => $dls }, undef,
$item->{'itemnumber'});
I understand why you do it. But I guess we might need a checkbox for that ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17758] SIP checkin does not handle holds correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17758 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17758] SIP checkin does not handle holds correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17758 Nick Clemens changed: What|Removed |Added Attachment #61347|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 61686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61686&action=edit Bug 17758 - SIP checkin does not handle holds correctly This patch updates SIP checkin to use reserve_id as param, to fix regression introduced by Bug 14695. To test: Given 1 patron and 1 biblio with two items attached: 1) create two record level holds on one biblio on same user Using SIP client or telnet: 2) checkin item x on pickup branch, observe item is waiting and hold 1 is filled 3) checkin item y on pickup branch, observe item y now is waiting and x is available 4) apply this patch and repeat 1-3, now expected behaviour should be that both holds are filled and both items waiting Signed-off-by: Srdjan Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18266] Internal Server Error when paying fine for lost item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18266] Internal Server Error when paying fine for lost item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266 Nick Clemens changed: What|Removed |Added Attachment #61439|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 61687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61687&action=edit Bug 18266: Fix internal error when paying fine for lost item without.. item If a fine is created for a lost item but the itemnumber is not supplied, the system will return it. The item should not be mark as returned if there is no item linked to the fine. Test plan: 1. Turn StoreLastBorrower on 2. Create a manual invoice for a lost item, do not supply a barcode 3. Pay the fines 'Pay fines > Pay' => Without this patch applied you get Can't call method "last_returned_by" on an undefined value at /home/marc/koha/C4/Circulation.pm line 2188. => With this patch applied, you must not get the error. Signed-off-by: Marc Véron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |BLOCKED --- Comment #36 from Jonathan Druart --- Blocked by bug 17855. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18347] Hanging of the computer system having koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18347 Nick Clemens changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID CC||n...@bywatersolutions.com --- Comment #1 from Nick Clemens --- Hello, This sounds like a specific system configuration issue and not a koha bug. Bugzilla is not meant as a support forum, but you could try mailing the koha lists or the ubuntu lists to see if anyone can help you there: https://lists.ubuntu.com/ https://koha-community.org/support/koha-mailing-lists/ Good luck! -Nick -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #14 from Jonathan Druart --- In that case we could remove the confirmed param in the template, do you confirm? I can followup on QAing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18189] Elasticsearch sorting broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18189 --- Comment #10 from Jonathan Druart --- What about integers and dates? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18189] Elasticsearch sorting broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18189 --- Comment #11 from Jonathan Druart --- Does only work with author, our other fields are not marked as sortable by default (?!?) Moreover "Ó Cadhain, Máirtín" is sorted after "Yerby, Frank Garvin", terrible... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18189] Elasticsearch sorting broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18189 Jonathan Druart changed: What|Removed |Added Attachment #61494|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 61689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61689&action=edit Bug 18189 - Elasticsearch sorting broken To test: 1 - Have ES enabled and biblios and authorities indexed 2 - Perform a catalog search 3 - Try to sort results by author, it will fail 4 - Perform an authority search with sorting enabled, it will fail 5 - Apply patch 6 - Reindex, deleting current indexes perl /home/vagrant/kohaclone/misc/search_tools/rebuild_elastic_search.pl -d -v 7 - Repeat 3&4, they should succeed Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18189] Elasticsearch sorting broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18189 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18329] Batch record deletion broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18329] Batch record deletion broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18329] Batch record deletion broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329
Martin Renvoize changed:
What|Removed |Added
Attachment #61635|0 |1
is obsolete||
--- Comment #5 from Martin Renvoize ---
Created attachment 61690
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61690&action=edit
Bug 18329 - Batch record deletion broken
Hie, Tools > Batch record deletion seems broken.
Any deletion returns error :
Bibliographic record YYY was not deleted. An error occurred. (The error was:
{UNKNOWN}: DBD::mysql::db begin_work failed: Already in a transaction at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. at
/home/koha/src/C4/Biblio.pm line 3468 , see the Koha log file for more
information).
Looks like it is because of Bug 18242 which added a transaction in
C4::Biblio::_koha_delete_biblio_metadata : $schema->txn_do.
The script batch_delete_records created a transaction with $dbh->{AutoCommit} =
0;
This patch fixes by using also Koha::Schema in batch_delete_records to manage
transaction.
It also removes "$dbh->{RaiseError} = 1", this behavior is managed in
Koha::Database.
Test plan :
- Go to Staff interface : Tools > Batch record deletion
- Enter a few existing biblionumbers
- Click on "Continue"
- Click on "Delete selected records"
=> Without patch you get a DB error
=> With patch you get confirmation message
- Try to get the biblios to confirm they are deleted :
/cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx
- Test with and without Plack
Signed-off-by: Jonathan Druart
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18329] Batch record deletion broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 --- Comment #6 from Martin Renvoize --- Easy QA, works as expected, code changes are clear :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #41 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #40) > [1] If we checkout in the staff client, wouldn't it be good to also show a > message? (Just like the sco message.) > See comment23, 27 and 30. Show the fee under Attention just like rental fees. I would consider this as a new enhancement, the info did not show up before this patch set. I will submit a patch anyway. > [2] Provide a message to the SIP terminal at checkout time. (a.o. comment31, > 34) > Note that Colin suggested to do this on another report. > In that case we could perhaps add a small "disclaimer" to the preference > that SIP does apply, but not show the fee at checkout time. > And as a side note, SIP currently does not show a fee when placing a hold. > But this is just a theoretical thing; not really used. Same as previously, the message did not show up before. Why should we add a warning to the pref? > [3] Since we need to show the same message at three locations, we could > consolidate that code (now in sco-main.pl) Messages are now in staff and opac, there are no way to centralise them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #42 from Jonathan Druart --- Created attachment 61691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61691&action=edit Bug 17560: Add a message when a patron collecting a hold (staff interface) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18258] Add the Koha::Biblio->subscriptions method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258 Tomás Cohen Arazi changed: What|Removed |Added Attachment #61121|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 61692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61692&action=edit Bug 18258: Add the Koha::Biblio->subscriptions method Test plan: prove t/db_dependent/Koha/Biblios.t should return green Signed-off-by: Marc Véron Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18258] Add the Koha::Biblio->subscriptions method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 61693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61693&action=edit Bug 18258: (QA followup) Use Koha::Subscriptions Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18258] Add the Koha::Biblio->subscriptions method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18332] Add the Koha::Objects->last method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18332 Tomás Cohen Arazi changed: What|Removed |Added Attachment #61636|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 61694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61694&action=edit Bug 18332: Add the Koha::Objects->last method DBIx::Class does not provide such method, but it can be handy in some cases. Test plan: prove t/db_dependent/Koha/Objects.t should return green Test returned green. Signed-off-by: Marc Véron Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18332] Add the Koha::Objects->last method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18332 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18128] 'Go to page' option for search results in opac and staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Jonathan Druart changed: What|Removed |Added Status|Signed Off |BLOCKED CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Blocked by bug 13205. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15235] Add column filters to checkouts table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15235 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Signed Off |Patch doesn't apply --- Comment #25 from Tomás Cohen Arazi --- Patches don't apply cleanly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #31 from Jonathan Druart --- Created attachment 61700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61700&action=edit Bug 17835: Mock language pref value That way if prefs contain other languages, the test will still pass. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #27 from Jonathan Druart --- Created attachment 61696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61696&action=edit Bug 17835: Do not reselect translated_description if comes from search_with_localization If the Koha::ItemType object has been instanciated from a call to Koha::ItemTypes->search_with_localization, we already have the translated_description value. So there is no need to fetch it again from the DB. This is what this trick does: if the translated_description column exist in the DBIx::Class result source's column list, that means the value has already been retrieved. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #28 from Jonathan Druart --- Created attachment 61697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61697&action=edit Bug 17835: Replace GetItemTypes with Koha::ItemTypes Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835
Jonathan Druart changed:
What|Removed |Added
Attachment #60048|0 |1
is obsolete||
Attachment #60049|0 |1
is obsolete||
Attachment #60914|0 |1
is obsolete||
Attachment #60915|0 |1
is obsolete||
Attachment #60916|0 |1
is obsolete||
Attachment #60917|0 |1
is obsolete||
--- Comment #26 from Jonathan Druart
---
Created attachment 61695
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61695&action=edit
Bug 17835: Create a ItemtypeLocalization view
To properly move C4::Koha::GetItemTypes to Koha::ItemTypes we need
DBIx::Class to make a join on the localization table to retrieve the
possible translated description of the item types.
To do so there are 2 possibilities. The first one would have been to
rename the localization table to something like itemtype_localization.
That way we could have had a relationship between
itemtype_localization.code and itemtypes.itemtype
That would have meant to create one table per "entity" (here an entity
is itemtype) we allow the translability. There are pros and cons for
this choice, so I opt for another solution.
The other solution is to create a view on top of this localization
table. With this new view we can define the missing relationship.
That sounds like a quite clean solution and easy to implement.
Once we have this relationship, the
Koha::ItemTypes->search_with_localization will join on this view an
return the same result as GetItemTypes( style => 'array' ).
To replace
GetItemtypes( style => 'hash' )
which is the default behavior of this subroutine, we can do something like:
my $itemtypes = Koha::ItemTypes->search_with_localization;
my %itemtypes = map { $_->{itemtype} => $_ } @{ $itemtypes->unblessed };
This patchset must not introduce big changes but it changes certain
behaviors (which were wrong) in some scripts. Indeed sometimes the
descriptions of the item types were not the translated ones. Moreover it
happens that the item types displayed in a dropdown list were not
ordered by translated description, but by description of code
(itemtypes.itemtype value). These 2 behaviors are what we expect.
Test plan:
Bugs will be hard to catch since these patches change a lot of file, it
will be easier to read the diff and catch possible typos or logic
errors.
However signoffers can focus on modified files and the item types
values.
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #30 from Jonathan Druart --- Created attachment 61699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61699&action=edit Bug 17835: Add an additional LEFT JOIN condition using DBIx::Class The previous query was wrong. If an item type did not contain the translation in the interface's language, the ->search_with_localization did not return it at all. What we need is definitely to add a second condition on the join. For reference: http://search.cpan.org/dist/DBIx-Class/lib/DBIx/Class/Relationship/Base.pm#condition https://blog.afoolishmanifesto.com/posts/dbix-class-parameterized-relationships/ That sounds hacky but seems to be the DBIx::Class path to follow. Bug 17835: follow-up Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #29 from Jonathan Druart --- Created attachment 61698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61698&action=edit Bug 17835: Remove the subroutine GetItemTypes At this point the subroutine is no longer in used. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18258] Add the Koha::Biblio->subscriptions method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Jonathan Druart changed: What|Removed |Added Attachment #60984|0 |1 is obsolete|| Attachment #61629|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 61701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61701&action=edit Bug 18244: Patron card creator does not take in account fields with underscore (B_address etc.) Fields with underscore like B_address do not print on patron cards. To reproduce: - Create patron card layout using fields with underscore in their name (e.g. ) - Print (export) patron card - Verify that fields without underscore are replaced by their value, but fields with underscore do not replace but show the field name To test: - Apply patch - Try to reproduce and verify that fields with underscore are replace as expected Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 --- Comment #20 from Jonathan Druart --- I plan to QA it, but on top of bug 15498 and bug 14224 (also modifying checkouts.js). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #52 from Jonathan Druart --- There are now a lot of warnings from t/db_dependent/Circulation/issue.t: item-level_itypes set but no itemtype set for item () -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18001] LocalHoldsPriority can cause multiple holds queue lines for same hold request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18001 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart --- Please provide tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart --- >From bug 18042 comment 5: "- I think we should come up with updates to the default Bootstrap button styles if we are going to use more than the btn-default class. Bootstrap colors aren't designed to work with Koha's, and we should avoid looking like out-of-the-box Bootstrap." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18042 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18042] Update buttons in batch record modification and deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18042 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18078 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #28 from Jonathan Druart --- Failing for comment 27, please answer to comment 26. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #25 from Jonathan Druart --- Right, I forgot that, makes sense. It sounds weird to have ->delete behaving differently than Koha::Objects->delete, not blocker The pref name contains '_', it's unusual. Not blocker I'd rename the option's name of the script with --temp-uploads-days (currently --temp-uploads-override). What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Tomás Cohen Arazi changed: What|Removed |Added Attachment #60819|0 |1 is obsolete|| Attachment #60820|0 |1 is obsolete|| --- Comment #7 from Tomás Cohen Arazi --- Created attachment 61702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61702&action=edit Bug 18182: Make TestBuilder capable of returning Koha::Object This patch adds a new method to t::lib::TestBuilder so it can return Koha::Object-derived objects. The new method is called ->build_object and requires the plural of the target class to be passed. 'class' is a mandatory param, and a warning is raised and undef is returned if absent. It accepts 'value' as the original ->build() method, and that is passed as-is to ->build(). To test: - Apply the patches - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/TestBuilder.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Tomás Cohen Arazi changed: What|Removed |Added CC||kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #20 from Jonathan Druart --- Aleisha, Take a look at orderreceive.tt, it also uses additem.js when AcqCreateItem = "on receiving". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182
--- Comment #8 from Tomás Cohen Arazi ---
Marcel, I thought a bit more about this and...
(In reply to Marcel de Rooy from comment #3)
> Great, Tomas.
>
> Few remarks:
> I would rather remove the id column. We c/should take care of that in the
> code.
> Like:
> my @pk = $schema->source('Borrower')->primary_columns;
> Note that we theoretically can have multiple columns. (We don't have such
> Koha objects, but iirc we have one or two tables like that.)
I fixed it so the id is retrieved from the source. I did it so multi-pk works
as expected, and changed the tests so they use a multi key sample Koha::Object.
> Similarly, it would be more consistent and less confusing to use the
> singular form. We do so in build; I would expect the same for build_object.
> Additionally, you return just one singular object.
I decided not to do it, but instead enforce the idea that plurals should be
used. I even changed the wiki about this. Because singular vs. plural leads
(everywhere) to circular deps (boo). And so we need to ONLY include plurals
everywhere. The plural already loads the singular, so it will always be
available. This should be explained more bradly, but I think we should leave
the plural here to simplify things.
I hope you agree and we move this forward, as it will make writing tests more
seamless.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Jonathan Druart changed: What|Removed |Added Attachment #61703|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Created attachment 61704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61704&action=edit Bug 17828: Unit tests for Koha::Patron::Attribute->store Unit tests for an overloaded Koha::Patron::Attribute->store that checks attribute type's uniqueness property and raises an exception conveniently. It also tests for repeatable attribute type's property. Test plan on the implementing patch. Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 --- Comment #16 from Jonathan Druart --- Created attachment 61705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61705&action=edit Bug 17828: Overload Koha::Patron::Attribute->store to check for unique_id and repeatable This patch introduces a Koha::Patron::Attribute->store method that does the required check for the corresponding Koha::Patron::Attribute::Type and raises an exception if trying to store more than one unique attribute code/value combination, and another exception for non-repeatable attribute types being stored while already existing on the DB. This patch introduces exception definitions for that purpose. To test: - Apply the unit tests patches - Run: $ prove t/db_dependent/Koha/Patron/Attributes.t => FAIL: Tests fail - Apply this patch - Run: $ prove t/db_dependent/Koha/Patron/Attributes.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 --- Comment #17 from Jonathan Druart --- Created attachment 61706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61706&action=edit Bug 17828: (followup) Add Test::Exception as dependency Test::Exception is available on Jessie and already installed when koha-common gets installed Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 --- Comment #18 from Jonathan Druart --- Created attachment 61707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61707&action=edit Bug 17828: (QA followup) Add ->type and reuse it Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 --- Comment #20 from Jonathan Druart --- Created attachment 61709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61709&action=edit Bug 17828: return $self to be consistent Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
