[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Medium patch QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #40 from Marcel de Rooy --- QA: Working on this one now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #26 from Marcel de Rooy --- Applying: Bug 17600: Explicitly export the subroutines used fatal: sha1 information is lacking or useless (C4/Auth_with_cas.pm). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18432] Most code comments assume male gender
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 Eric Phetteplace changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18432] Most code comments assume male gender
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 Eric Phetteplace changed: What|Removed |Added Change sponsored?|--- |Sponsored Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18431] Import hangs when SearchEngine is set to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18431 --- Comment #1 from Barton Chittenden --- It turns out that I didn't have the 'elasticsearch' section set up in $KOHA_CONF... Command line tools warn about this; Staged Marc Management should too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18432] Most code comments assume male gender
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 Eric Phetteplace changed: What|Removed |Added Assignee|gmcha...@gmail.com |ephettepl...@cca.edu --- Comment #1 from Eric Phetteplace --- Created attachment 62155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62155&action=edit patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18432] New: Most code comments assume male gender
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 Bug ID: 18432 Summary: Most code comments assume male gender Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Developer documentation Assignee: gmcha...@gmail.com Reporter: ephettepl...@cca.edu QA Contact: testo...@bugs.koha-community.org Throughout the Koha codebase, the pronoun "he" is used to refer to a generic third person who could be of any gender. For instance, in C4/Suggestions.pm line #66: 'When a librarian manages the suggestion, he can set the status to "REJECTED" or "ACCEPTED".' That assumes all librarians are male. It's particularly problematic given that, in the US at least, the profession is heavily female. In other files, all borrowers are assumed to be male. In the interest of making the code base more inclusive, it'd be better to not assume a male gender. The patch—which touches *a lot* of disparate files but almost only comments—changes all instances of "he" or "him" I could find to "he or she" and "him or her" respectively. I'd also be in support of singular "they"/"their" in these situations if people prefer that. In a few cases, a non-human object was being referred to as "he", so I used "it" instead. FYI, the regex I used to find uses of the pronoun "he" and "him": - / (H|h)e (?!or she)/ - / (H|h)im (?!or her)/ I ignored "docs/history.txt" and "misc/release_notes" since those seem to refer to actual men who worked on Koha, and also the Maori translations. There were 3 "unimarc_framework_DEFAULT.sql" files also used "he" in a way that seemed to refer to a particular individual, though I'm not sure. Testing plan: - I can't really formulate a "testing plan" for this patch since it shouldn't impact actual executing code - The patch does touch strings in a few tests so at the very least these should continue to pass: M C4/SIP/t/06patron_enable.t M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt M t/db_dependent/Circulation.t M t/db_dependent/Koha/Patrons.t M t/db_dependent/Reserves.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18429] Receiving an item should update the datelastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 --- Comment #3 from Christopher Brannon --- Created attachment 62154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62154&action=edit [SIGNED OFF] Bug 18429 - Receiving an item should update the datelastseen To test: 0 - Ensure AcqCreateItem is set to 'placing an order' 1 - Order some items, note entrydate and datelastseen match 2 - Alter those dates to be earlier than today (or wait some days) 3 - Recieve the item and note datelast seen not updated 4 - Apply patch 5 - Repeat 1-3 6 - Date last seen should be updated. Followed test plan, works as expected. Signed-off-by: Marc Véron Works as expected. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18431] New: Import hangs when SearchEngine is set to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18431 Bug ID: 18431 Summary: Import hangs when SearchEngine is set to ElasticSearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Marc record import hangs when SearchEngine is set to ElasticSearch. To replicate: Make sure that ElasticSearch is running, and the SearchEngine syspref is set to ElasticSearch. Go to tools > stage marc records. Choose file, upload file, Click Stage Records for import. Click Import this batch into the catalog. The import hangs at 0%. I was able to import all records when SearchEngine was set to Zebra. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18429] Receiving an item should update the datelastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18429] Receiving an item should update the datelastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Marc Véron changed: What|Removed |Added Patch complexity|--- |Trivial patch CC||ve...@veron.ch Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18429] Receiving an item should update the datelastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Marc Véron changed: What|Removed |Added Attachment #62148|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 62153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62153&action=edit Bug 18429 - Receiving an item should update the datelastseen To test: 0 - Ensure AcqCreateItem is set to 'placing an order' 1 - Order some items, note entrydate and datelastseen match 2 - Alter those dates to be earlier than today (or wait some days) 3 - Recieve the item and note datelast seen not updated 4 - Apply patch 5 - Repeat 1-3 6 - Date last seen should be updated. Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Christopher Brannon changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 --- Comment #3 from Christopher Brannon --- Created attachment 62152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62152&action=edit [SIGNED OFF ]Bug 18201 - Export data -Fix "Remove non-local items" option and add "Removes non-local records" option for existing functionality It turns out the modules had the option expected built in, we just didn't call it. This patch set expands the options for passing to the export. To test: 1 - Go to Tools->Export data 2 - Perform an export and check 'Remove non-local items' 3 - Note that file contains only 'local' records, but includes all items on those records 4 - Apply patch 5 - Note Tools->Export data has a new option to remove records not owned by logged in branch 6 - Export as before checking records option, file should be as before 7 - Now check 'Remove items not owned by logged in branch' 8 - File should now only have local items (may have empty records) 9 - Check both boxes and recieve only 'local' records and items Works as described. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18430] Plugins page should have a link to viewing other types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18430 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #3 from Christopher Brannon --- Works as described. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18430] Plugins page should have a link to viewing other types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18430 --- Comment #2 from Christopher Brannon --- Created attachment 62151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62151&action=edit [SIGNED OFF] Bug 18430 - Plugins page should have a link to viewing other types To test: Go to the plugins page from Reports->Report plugins Tools->Tool plugins Admin->Manage plugins Ensure that you have a 'View plugins by class button' Ensure the button does what you would expect Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18430] Plugins page should have a link to viewing other types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18430 Christopher Brannon changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18420] Some tests fail without patron category 'S'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #19 from Marc Véron --- Re-testing on current master 16.12.00.024 Database dropped and recreated. Run through install, mandatory data only. No user, library etc. created. Applied patches Restart plack Testing prove t/db_dependent/Budgets.t OK prove t/db_dependent/Passwordrecovery.t FAIL (branchcode undefined) prove t/db_dependent/Members.t OK prove t/db_dependent/Suggestions.t OK prove t/db_dependent/Acquisition/OrderUsers.t OK prove t/db_dependent/Circulation.t OK prove t/db_dependent/Circulation/IsItemIssued.t OK prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t OK prove t/db_dependent/Holds/HoldFulfillmentPolicy.t FAIL 1/10 Can't use an undefined value as an ARRAY reference at t/db_dependent/Holds/HoldFulfillmentPolicy.t line 41. prove t/db_dependent/Holds/HoldItemtypeLimit.t OK prove t/db_dependent/Holds/LocalHoldsPriority.t OK prove t/db_dependent/Holds/RevertWaitingStatus.t OK prove t/db_dependent/Members/Attributes.t OK prove t/db_dependent/Patron/Borrower_Debarments.t OK prove t/db_dependent/Patron/Borrower_Files.t OK prove t/db_dependent/Serials_2.t OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18321] One more checkouts possible than allowed by rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 --- Comment #21 from Marc Véron --- k...@bywatersolutions.com 2017-04-13 12:28:01 UTC CC k...@bywatersolutions.com Status Passed QA Patch doesn't apply Re-tested on current master 16.12.00.022, patch applies fine here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18409] Error when updating pickup library on patron pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18409 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18409] Error when updating pickup library on patron pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18409 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | CC||tomasco...@gmail.com --- Comment #1 from Tomás Cohen Arazi --- This is bad. Tests for holds are raising 500 actually, so things might have been broken a while back. I'll take a look and provide a fix on monday, Kyle. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18430] Plugins page should have a link to viewing other types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18430 Nick Clemens changed: What|Removed |Added Assignee|gmcha...@gmail.com |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18430] Plugins page should have a link to viewing other types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18430 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18430] Plugins page should have a link to viewing other types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18430 --- Comment #1 from Nick Clemens --- Created attachment 62150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62150&action=edit Bug 18430 - Plugins page should have a link to viewing other types To test: Go to the plugins page from Reports->Report plugins Tools->Tool plugins Admin->Manage plugins Ensure that you have a 'View plugins by class button' Ensure the button does what you would expect -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18430] New: Plugins page should have a link to viewing other types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18430 Bug ID: 18430 Summary: Plugins page should have a link to viewing other types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Currentl you can access plugins via Reports->Report plugins Tools->Tool plugins Admin->Manage plugins But from report or tools it is not possible to get from one type to another (other than manipulating URL) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17978] Circ rules will not limit holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 --- Comment #10 from Christopher Brannon --- Finding that next available holds are ignored when it comes to hold limits on specific rules. Item specific holds are adhering to the limits set. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17978] Circ rules will not limit holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 --- Comment #9 from Christopher Brannon --- (In reply to Jonathan Druart from comment #8) > It's a long standing bug and it will need quite a lot of work to fix it. I assume that if this is a long standing bug, there must be another ticket somewhere. Do you know of one? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 --- Comment #2 from Nick Clemens --- Created attachment 62149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62149&action=edit Bug 18201 - Export data -Fix "Remove non-local items" option and add "Removes non-local records" option for existing functionality It turns out the modules had the option expected built in, we just didn't call it. This patch set expands the options for passing to the export. To test: 1 - Go to Tools->Export data 2 - Perform an export and check 'Remove non-local items' 3 - Note that file contains only 'local' records, but includes all items on those records 4 - Apply patch 5 - Note Tools->Export data has a new option to remove records not owned by logged in branch 6 - Export as before checking records option, file should be as before 7 - Now check 'Remove items not owned by logged in branch' 8 - File should now only have local items (may have empty records) 9 - Check both boxes and recieve only 'local' records and items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Nick Clemens changed: What|Removed |Added Assignee|gmcha...@gmail.com |n...@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Nick Clemens changed: What|Removed |Added Summary|Confusing language on |Export data -Fix "Remove |Export data - bibliographic |non-local items" option and |records "Remove non-local |add "Removes non-local |items" |records" option for ||existing functionality -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18429] Receiving an item should update the datelastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18429] Receiving an item should update the datelastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 --- Comment #1 from Nick Clemens --- Created attachment 62148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62148&action=edit Bug 18429 - Receiving an item should update the datelastseen To test: 0 - Ensure AcqCreateItem is set to 'placing an order' 1 - Order some items, note entrydate and datelastseen match 2 - Alter those dates to be earlier than today (or wait some days) 3 - Recieve the item and note datelast seen not updated 4 - Apply patch 5 - Repeat 1-3 6 - Date last seen should be updated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18429] New: Receiving an item should update the datelastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Bug ID: 18429 Summary: Receiving an item should update the datelastseen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18428] New: Duplicate key error in old_reserves table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18428 Bug ID: 18428 Summary: Duplicate key error in old_reserves table. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: gmcha...@gmail.com Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org I'm not exactly sure how we got ourseleves into this situation, but one of our libraries is getting the following error when trying to check in an item that is on hold: DBD::mysql::st execute failed: Duplicate entry '39' for key 'PRIMARY' [for Statement "INSERT INTO `old_reserves` ( `biblionumber`, `borrowernumber`, `branchcode`, `cancellationdate`, `expirationdate`, `found`, `itemnumber`, `itemtype`, `lowestPriority`, `notificationdate`, `priority`, `reminderdate`, `reserve_id`, `reservedate`, `reservenotes`, `suspend`, `suspend_until`, `timestamp`, `waitingdate`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='11198', 1='693', 2='CFOT', 3=undef, 4=undef, 5='F', 6=undef, 7=undef, 8='0', 9=undef, 10=0, 11=undef, 12='39', 13='2017-04-13', 14='', 15='0', 16=undef, 17='2017-04-13 06:19:29', 18=undef] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '39' for key 'PRIMARY' at /usr/share/koha/lib/Koha/Object.pm line 120 This is analogous to bug 18242 for old_issues. I wonder if we need to do the same thing for the deleted* tables. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #42 from Kyle M Hall --- Martin, I'm not sure what you are suggesting, but I think I have the idea. Consider this group structure: United States Pennsylvania Crawford County Meadville Public Library Saegertown Public Library Erie County Millcreek Public Library Edinboro Public Library New York Niagara County Niagara Public Library Falls Public Library Orleans County Orleans Public Library Beaver Public Library So, if this were the heirarchy, you'd expect the search options to include: Pennsylvania Crawford County Erie County New York Niagara County Orleans Count and selecting one of those would search all the libraries that are below that group or subgroup. Is that correct? If so, I think I agree and would be happy to implement that. (In reply to Martin Renvoize from comment #41) > The more I think about this the more I dislike the idea. > > Search Groups and Functional Groups may well need to be different. > > If I'm understanding it correctly, the idea of Bug 15707 is to allow for > preferences (i.e. things that govern functionality including lending rules, > holding rules etc etc) to be shared and inherited down a hierarchical > institution structure. As such, each entity should have one parent and only > one parent.. else inheritance gets super messy. > > Searches may well want to apply over completely different groups and may > well want to overlap. Think of a set of library branches spread across a > large area, you may well want to have search groups to allow searching of a > group of 'immediate neighbours'; as such depending on which branch you're > neighbours will be different and thus one entity will likely need to be part > of more than one group. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16954] Add the diff view to authorities in staged MARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16954 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14537] The system preference 'OverdueNoticeBcc' is mis-named.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Aleisha, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #126 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #13 from Kyle M Hall --- Pushed to master for 17.05, thanks Julian! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18375] Better readability of patron category table for zero ages and fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18375 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18274] C4::Items - Remove GetItemStatus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall --- Pushed to master for 17.05, thanks Tomas, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #28 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Alex! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14932] serials/ serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Olli! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18395] Wrong article request methods in Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18321] One more checkouts possible than allowed by rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18121] Rename opac_news.new with opac_news.content - replace notice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18121 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #13 from Tomás Cohen Arazi --- http://www.perlmonks.org/?node_id=1127880 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18413] Fix Letters.t (follow-up of 17866)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18413 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #20 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #17) > Serialitems should have a primary key. Since itemnumber is a unique key, we > could promote it to PK as well. Should be solved on a different report. Solved on bug 18427 now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18427] Add a primary key to serialitems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18427 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18427] Add a primary key to serialitems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18427 Marcel de Rooy changed: What|Removed |Added Attachment #62144|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 62147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62147&action=edit Bug 18427: Add a primary key to serialitems We drop the unique index serialitemsidx and add a primary key consisting of itemnumber just as the unique key did. Test plan: Run the db revision. Apply bug 18182. The TestBuilder.t should no longer fail on serialitems. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18427] Add a primary key to serialitems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18427 Marcel de Rooy changed: What|Removed |Added Attachment #62145|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy --- Created attachment 62146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62146&action=edit Bug 18427: DBIx schema changes Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18427] Add a primary key to serialitems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18427 --- Comment #1 from Marcel de Rooy --- Created attachment 62144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62144&action=edit Bug 18427: Add a primary key to serialitems We drop the unique index serialitemsidx and add a primary key consisting of itemnumber just as the unique key did. Test plan: Run the db revision. Apply bug 18182. The TestBuilder.t should no longer fail on serialitems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18427] Add a primary key to serialitems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18427 --- Comment #2 from Marcel de Rooy --- Created attachment 62145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62145&action=edit Bug 18427: DBIx schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 delaye changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||stephane.del...@biblibre.co ||m --- Comment #3 from delaye --- test in the sandbox 1 of biblibre with the test plan . It works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18427] Add a primary key to serialitems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18427 Marcel de Rooy changed: What|Removed |Added Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18427 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18427] Add a primary key to serialitems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18427 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18182 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #41 from Martin Renvoize --- The more I think about this the more I dislike the idea. Search Groups and Functional Groups may well need to be different. If I'm understanding it correctly, the idea of Bug 15707 is to allow for preferences (i.e. things that govern functionality including lending rules, holding rules etc etc) to be shared and inherited down a hierarchical institution structure. As such, each entity should have one parent and only one parent.. else inheritance gets super messy. Searches may well want to apply over completely different groups and may well want to overlap. Think of a set of library branches spread across a large area, you may well want to have search groups to allow searching of a group of 'immediate neighbours'; as such depending on which branch you're neighbours will be different and thus one entity will likely need to be part of more than one group. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #8 from Marcel de Rooy --- Tomas: I adjusted the POD to make your concerns more visible, and renamed the @id array to a more generic name @pars, since it indeed may contain an attrs hash. Additionally, I added a find subtest in Objects.t that contains a few tests where an attr hash is passed along to find. Signoff time :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #9 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > (In reply to Marcel de Rooy from comment #2) > > The indirect way of testing the changed find via TestBuilder works. > > Is it enough or should we add find tests in Koha/Objects.t? > > Note that I perhaps would have expected such a subtest already, but it does > > not exist ;) > > Yes we should definitely have one in Objects.t Done -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #171 from Martin Renvoize --- Is there a 'functional requirements' document anywhere for all this.. the more I read the code and linked bugs the more confused I get about what it's actually trying to achieve :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Marcel de Rooy changed: What|Removed |Added Attachment #61754|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 62142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62142&action=edit Bug 18361: Koha::Objects->find should accept composite primary keys Changes the $id parameter to an array. (IssuingRule has three keys.) The build_object method in TestBuilder.pm has been adjusted to pass multiple primary key values to find. Also adjusted the POD section to show more clearly that we accept the same parameters as DBIx ResultSet does. Test plan: Run t/db_dependent/Koha/Object.t Run t/db_dependent/Koha/Objects.t Run t/db_dependent/TestBuilder.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #7 from Marcel de Rooy --- Created attachment 62143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62143&action=edit Bug 18361: Additional tests for Koha::Objects->find Adding a subtest find in t/db_dependent/Koha/Objects.t. Test plan: Run t/db_dependent/Koha/Objects.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 --- Comment #13 from Lari Taskula --- Created attachment 62141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62141&action=edit Bug 14698 - AtomicUpdater - addAllAtomicUpdates This patch adds a new method Koha::AtomicUpdater->addAllAtomicUpdates that marks all pending atomicupdates as applied, but does not execute the database changes in them. This is required for fresh installations to avoid applying same updates after the installation. Binds this feature to web installer. To test: 1. prove t/db_dependent/Koha/AtomicUpdater.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18427] Add a primary key to serialitems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18427 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18361 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18427 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18427] New: Add a primary key to serialitems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18427 Bug ID: 18427 Summary: Add a primary key to serialitems Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org See bug 18361 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399
Marcel de Rooy changed:
What|Removed |Added
Attachment #62098|0 |1
is obsolete||
--- Comment #16 from Marcel de Rooy ---
Created attachment 62139
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62139&action=edit
Bug 14399: Interface changes
A part of the confusion around the inventory script may arise from the
fact that the form offers several options that are only used under
certain conditions. This patch hopefully rearranges a few options more
logically and only offers options when appropriate.
The barcode fieldset now also contains Compare barcodes and Do not check in
checkboxes. These are meaningful when a barcode file is uploaded.
The fieldset Item location filters (new name) contains fields that are
always used. Same for tne only control left under Additional options,
Export to CSV.
The fieldset Optional filters depends on the status of the barcode file
and the Compare checkbox. It is now shown or hidden depending on what
you select: if you do not upload a file, it is shown; or if you upload
a file and check Compare, it is shown. Otherwise we hide it, since the
script will not look at these values. Under this fieldset last inventory
date and Skip items on loan are added, since their behavior is the same
as the various item statuses.
Test plan:
In this test plan we test both the script changes from the previous patch
and the interface changes here. We follow the three main scenario's as
mentioned in the previous patch.
[1] First we prepare a few test items.
Pick two biblios A, B and create five items say A1,A2,B1,B2,B3.
Pick a not-existing callnumber range you want to test and move these
five items there. Add barcodes too (say A1..B3).
Edit one item A1 to a not-existing notforloan status (doing this on
the mysql command line is fastest).
Like: update items set notforloan = '9' where barcode='A1';
Now simulate that we did not add/edit these items today:
update items set datelastseen='2017-01-01' where barcode in
('A1','A2','B1','B2','B3');
Note: We need this when comparing with last inventory date in the last
scenario.
Scenario 1 (no barcodes uploaded)
[2] Enter the callnumber range on inventory form.
Verify that "Set inventory date", Compare barcodes and "Do not check
in" are disabled on the form. Check that you see the Optional filters
box.
Submit the form. Verify that you see all five items.
Do the same. Check Export to CSV. Check result file contents.
Scenario 2 (upload barcodes, do not compare)
[3] Create a barcode file with the barcodes of A1, A2 and B1. Add another
existing barcode outside the test callnumber range.
After uploading this file, verify that "Set inventory date", Compare and
"Do not check in" are enabled. The Optional filters should be hidden.
Leave "Set inventory date" to today. Enter the callnumber range again.
Submit the form.
What do we expect? Four items should have been updated (alert). We
should see barcode A1 with problem Unknown status. We should see
also the barcode from the other range (Found in wrong place).
Repeat this step with the same file. But now export to CSV. Verify that
you see two barcodes with problems again in the csv file.
Scenario 3 (upload barcodes, compare)
[4] Create another barcode file with barcodes of B2 and one existing barcode
outside the test callnumber range.
After uploading this file, check the Compare checkbox. Verify now that
the Optional filters box is displayed again.
Leave "Set inventory date" to today. Enter the callnumber range again.
Also set "Last inventory date" to today (important!).
Submit the form.
What do we expect now? Two items should be updated (see alert).
We should see barcode B3 with problem Missing. We should also see the
barcode from the other range (wrong place).
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy changed: What|Removed |Added Attachment #62099|0 |1 is obsolete|| --- Comment #17 from Marcel de Rooy --- Created attachment 62140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62140&action=edit Bug 14399: Results form also needs a few interface changes Currently, the value of compareinv2barcd is used to determine if the Seen column, the Select/Clear all buttons and the Mark seen buttons are displayed. But if we scanned barcodes, we already marked items as seen. So we should only display these buttons when we did not upload barcodes. Test plan: [1] Upload a barcode file. Check that the result form does not show the buttons. [2] Generate an inventory list, so do not upload a barcode file. Verify that you still see the buttons. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #15 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #14) > Will adjust the test plan a little bit still If you do not set datelastseen back to yesterday or earlier, you will not have B3 in the results of the last step because it was created today. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #62080|0 |1 is obsolete|| --- Comment #25 from Lari Taskula --- Created attachment 62138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62138&action=edit Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |BLOCKED --- Comment #14 from Marcel de Rooy --- Will adjust the test plan a little bit still -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #24 from Lari Taskula --- Depends on Bug 18413 (otherwise Letters.t fails) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18413] Fix Letters.t (follow-up of 17866)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18413 Lari Taskula changed: What|Removed |Added Blocks||14723 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 [Bug 14723] Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Depends on||18413 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18413 [Bug 18413] Fix Letters.t (follow-up of 17866) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #125 from Marcel de Rooy --- Thanks Julian -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #124 from Julian Maurice --- koha-qa is happy, prove is happy, and I couldn't find any issue during my tests, so I'm happy too :) Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What|Removed |Added Attachment #62055|0 |1 is obsolete|| --- Comment #123 from Julian Maurice --- Created attachment 62137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62137&action=edit Bug 9988: [QA Follow-up] Satisfy QA issues [1] See comment102. Moved sub reporting_tag_xml to MergeRequest.pm. Adjusted t/db_dependent/Koha/Authorities.t accordingly. This resolves the C3 inconsistent hierarchy errors. [2] Removed empty POD section Instance Methods from MergeRequests. This resolves the POD error in comment102 point 2. [3] Include a tag 100 for UNIMARC in reporting_tag_xml to resolve an error on encoding in MARC::File::XML. Subtest for oldmarc and subtest for reporting_tag_xml adjusted accordingly. Signed-off-by: Marcel de Rooy Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What|Removed |Added Attachment #61924|0 |1 is obsolete|| --- Comment #121 from Julian Maurice --- Created attachment 62135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62135&action=edit Bug 9988: Refactor the cron script The cron job is moved from migration tools to cronjobs. And renamed to a plural form. The script is now based on Koha objects. It does no longer include the code to merge one record. This can be done via the interface, and will be added to a maintenance script on bug 18071. Should not be part of this cron job. Adding a cron_cleanup method to MergeRequests; this method is called from the cron script to reset older entries still marked in progress and to also remove old processed entries. Tested in a separate unit test. Test plan: [1] Run t/db_dependent/Authorities/MergeRequests.t [2] Set AuthorityMergeLimit to 0. (All merges are postponed.) [3] Modify an authority linked to a few records. [4] Delete an authority linked to a few records with batch delete tool. [5] And select two auth records with linked records. Merge these two records with authority/merge.pl. Note: Do not select Default. See also bug 17380. [6] Check the need_merge_authorities table for inserted records. [7] Run misc/cronjobs/merge_authorities.pl -b and inspect the linked records and the record status in need_merge_authorities. Signed-off-by: Marc Véron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What|Removed |Added Attachment #61925|0 |1 is obsolete|| --- Comment #122 from Julian Maurice --- Created attachment 62136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62136&action=edit Bug 9988: Add the cronjob and print an upgrade message The Debian cron file and the misc crontab example are updated. A message is printed when upgrading. Note: At this moment the merge cron job is run once a day. This is imo a good starting point. The load for this job greatly depends on the value of pref AuthorityMergeLimit. Of course you can schedule the job more often, and if this need is felt more globally, we can adjust it later. Test plan: [1] Run the dbrev and see the message. [2] Read the changes to the cron files. Signed-off-by: Marcel de Rooy Signed-off-by: Marc Véron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What|Removed |Added Attachment #61921|0 |1 is obsolete|| --- Comment #118 from Julian Maurice --- Created attachment 62132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62132&action=edit Bug 9988: Remove further references to dontmerge [1] The preference was sent to HEA. We can now send both AuthorityMergeMode as well as AuthorityMergeLimit. [2] A comment in authorities/merge.pl is removed. Note that a subsequent patch will modify and test the cron job. [3] Script misc/batchRebuildItemsTables.pl temporarily enabled dontmerge. This is equivalent to setting the mergelimit to zero. The function defnonull is no longer needed. (If the pref was NULL, we restore that value. Sub merge won't mind.) Test plan: [1] Run t/db_dependent/UsageStats.t [2] Run misc/batchRebuildItemsTables.pl -t This just ensures you it still compiles; the changes speak for itself. [3] Now git grep on dontmerge. You should only find hits in atomicupdate and misc/translator/po. Signed-off-by: Marcel de Rooy Signed-off-by: Marc Véron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What|Removed |Added Attachment #61923|0 |1 is obsolete|| --- Comment #120 from Julian Maurice --- Created attachment 62134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62134&action=edit Bug 9988: Few subtle changes for postponed merge The fails in the previous test showed that we need the first three changes here. Some final polishing in points 4 to 6. [1] Sub merge: Refine the condition for initializing $tags_new. A postponed 'modify'-merge (A to B) makes that $authtypefrom is not defined when running merge later. When crossing the type boundary, we need a new field too. [2] Sub merge: Add condition for an empty @record_to array. This indicates also that a field should be removed, since we should otherwise only add a $9 subfield. [3] Sub merge: Adjust initializing @record_from. This change is tested by verifying a cleared subfield in the test. [4] DelAuthority: Adding a skipmerge parameter to allow the call from authorities/merge.pl to skip an unneeded merge. This also prevents that the 'delete-merge' would precede the 'modify-merge' under a hypothetical race condition. [5] DelAuthority: There is actually no need to call GetAuthority. The subfields of the old record are not relevant in this case. [6] Added a few POD lines to merge. [7] Removed a trailing space in a comment line in merge. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should no longer fail now. [2] See test plan of next patch. Signed-off-by: Marcel de Rooy Signed-off-by: Marc Véron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What|Removed |Added Attachment #61920|0 |1 is obsolete|| --- Comment #117 from Julian Maurice --- Created attachment 62131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62131&action=edit Bug 9988: Check the merge limit in sub merge At this point, we are replacing dontmerge functionality by the new AuthorityMergeLimit logic. Instead of doing this check before calling merge, we just call merge and check it there. In order to let the cron job do the larger (postponed) merges, we add a parameter override_limit. A subtest is added in Merge.t to test the 'postponed merge' feature. Since merge now also calls get_usage_count, an additional mock is added. All references to dontmerge are removed. In merge two lines, initializing $dbh and $counteditbiblios, are moved. The dontmerge test in DelAuthority and ModAuthority is removed. Since this did not leave much in ModAuthority, I fixed the whitespace on the remaining lines rightaway (yes, I know). A minimal set of changes is applied to the cron script; it will get further attention on a next patch. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Set AuthorityMergeLimit to 2. Modify an authority with two linked biblios. Check that the merge was done immediately. [3] Now modify an authority with more than 2 linked records. Verify that the merge was postponed; a record must be inserted in the need_merge_authorities table. [4] Testing of the merge cron job is *postponed* to a next patch. Note: I tested a modification, but the script just needs more attention. Signed-off-by: Marcel de Rooy Signed-off-by: Marc Véron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What|Removed |Added Attachment #61919|0 |1 is obsolete|| --- Comment #116 from Julian Maurice --- Created attachment 62130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62130&action=edit Bug 9988: Remove the Zebra code from sub merge Since we can now call linked_biblionumbers, we can now remove all Zebra related code from merge. We also add a parameter biblionumbers; we use it in the test now, but it may be handy too later in the maintenance script when we want to trigger a merge for specific biblionumber(s). See bug report 18071. All mocks for ZOOM, Context::Zconn, Search::new_record_for_zebra in the merge test can now be replaced by one mock for linked_biblionumbers. Note that we test the biblionumbers parameter in the last subtest without that mock. Remove unused vars $countunmodifiedbiblio, $counterrors from merge. Renamed zebrarecords to linkedrecords in the Merge test. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Modify an authority record. Check the linked biblio records. Signed-off-by: Marcel de Rooy Signed-off-by: Marc Véron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What|Removed |Added Attachment #61922|0 |1 is obsolete|| --- Comment #119 from Julian Maurice --- Created attachment 62133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62133&action=edit Bug 9988: Add a subtest for specific postponed merge issues This subtest shows that we need a few little tweaks to make merge work in some specific postponed merge situations. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should fail. Signed-off-by: Marcel de Rooy Signed-off-by: Marc Véron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What|Removed |Added Attachment #61917|0 |1 is obsolete|| --- Comment #114 from Julian Maurice --- Created attachment 62128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62128&action=edit Bug 9988: Add get_usage_count and linked_biblionumbers to Koha::Authority When replacing the Zebra code in sub merge, we actually need CountUsage as well as the results it gets from SearchEngine. In order to get count and/or results, we now create: [1] instance methods get_usage_count and linked_biblionumbers in Koha::Authority, [2] class methods of the same name in Koha::Authorities. The instance method calls the class method. The class method can be used for deleted authority records, and in 'legacy calls' before refactoring. Note: On BZ 18149 we will replace all CountUsage calls. Test plan: Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy Signed-off-by: Marc Véron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What|Removed |Added Attachment #61918|0 |1 is obsolete|| --- Comment #115 from Julian Maurice --- Created attachment 62129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62129&action=edit Bug 9988: Merge should have a parameter hash We will need a few additional parameters for merge later on. This patch puts the original parameters in a parameter hash. For the same reason DelAuthority gets a parameter hash here. Note: We remove the second parameter from the DelAuthority call in authorities/authorities-home.pl here. It was not used and could have presented problems in the future. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t. [2] Run t/db_dependent/Authorities/Merge.t. Signed-off-by: Marcel de Rooy Signed-off-by: Marc Véron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What|Removed |Added Attachment #61915|0 |1 is obsolete|| --- Comment #112 from Julian Maurice --- Created attachment 62126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62126&action=edit Bug 9988: Add Koha objects for table need_merge_authorities This patch adds two Koha objects: MergeRequest(s). MergeRequest has a new method and an oldmarc method. A class method reporting_tag_xml is added to MergeRequests.pm. All new routines are tested in Authorities.t. Removes a few unneeded modules from Koha::Authority. Test plan: Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy Signed-off-by: Marc Véron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What|Removed |Added Attachment #61913|0 |1 is obsolete|| --- Comment #110 from Julian Maurice --- Created attachment 62124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62124&action=edit Bug 9988: Table revision for need_merge_authorities In order to let merge do exactly the same when called from the merge cron job, we need three additional fields in the table. The use of these fields will be explained in a follow-up. Test plan: Run the dbrev (updatestructure step in webinstaller). Signed-off-by: Marcel de Rooy Also tested running kohastructure.sql for this table. Signed-off-by: Marc Véron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What|Removed |Added Attachment #61916|0 |1 is obsolete|| --- Comment #113 from Julian Maurice --- Created attachment 62127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62127&action=edit Bug 9988: Add extract_biblionumber to Koha/SearchEngine When we will replace the Zebra code in sub merge, we will call SearchEngine to pass records and we need a routine to extract a biblionumber from a search result record. A record from Zebra still must be converted to MARC::Record. This is no longer needed for a ElasticSearch record. Test plan: Run t/db_dependent/Koha/SearchEngine/Search.t Signed-off-by: Marcel de Rooy Signed-off-by: Marc Véron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What|Removed |Added Attachment #61914|0 |1 is obsolete|| --- Comment #111 from Julian Maurice --- Created attachment 62125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62125&action=edit Bug 9988: DBIx schema changes for need_merge_authorities As generated by misc/devel/update_dbix_class_files.pl. No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Marc Véron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What|Removed |Added Attachment #61912|0 |1 is obsolete|| --- Comment #109 from Julian Maurice --- Created attachment 62123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62123&action=edit Bug 9988: Database revision for AuthorityMergeLimit Introduce the new preference and remove dontmerge. If dontmerge was enabled, the new pref will be set to zero and we will print a message about raising this value now. Test plan: Run the database revision or a new install. In case of an upgrade, check the new pref value. Should be 0 when dontmerge was enabled, otherwise 50. Signed-off-by: Marcel de Rooy Also tested sysprefs.sql on a new database. Signed-off-by: Marc Véron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
