[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 --- Comment #8 from Marc Véron --- (In reply to Marc Véron from comment #7) > Tested both patches together on top of 17737. No problems found. > > However, QA tool complains with first patch: > FAIL opac/opac-reserve.pl >FAIL valid > "my" variable $patron masks earlier declaration in same scope I can not find out why QA tool complains, code seems OK to me. Maybe QAers can find out? - Singing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17864] Increase coverage on admin pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 --- Comment #8 from M. Tompsett --- P.S. This fails if plug ins are not enabled, as one of the tested pages is plugins. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17864] Increase coverage on admin pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 M. Tompsett changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #7 from M. Tompsett --- Looks like I forgot to change the status back to needs sign off. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18405] Self checkout: Fix broken silent printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18405 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18405] Self checkout: Fix broken silent printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18405 Alex Buckley changed: What|Removed |Added Attachment #61989|0 |1 is obsolete|| --- Comment #2 from Alex Buckley --- Created attachment 62187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62187&action=edit Bug 18405: Self checkout: Fix broken silent printing Fix broken 'silent printing' (without printer dialog) in self checkout. To reproduce: Set up silent printing to slip printers as described in: https://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently Verify that it works for check-outs in staff client. Verify that it does not work in Self checkout. To test: Apply patch Verify that silent printing works on SCO Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #179 from Alex Buckley --- In the 'Bug 17855 - Followup patch following requests in comments 176 and 177' patch I have addressed all issues brought up in comments 176 and 177, see below: 1. Removed the tag from all installer/*.tt files 2. I cannot remember the rationale for the change of the wording from 'update your database' so I have changed it back to 'Update your database'. Note: I have made only the first letter capitalised thus meeting coding guidelines. 3. I have changed 'Install Basic Configuration Settings' to 'Install basic configuration settings' so it meets the coding guidelines 4. In onboarding/onboardingstep5.tt I have removed max="10" limit on input boxes 5. I have written in default values for checkouts, loan, renewals and renewal period based on the values in the example circulation rule in the Koha 16.11 manual 6. Implemented min="0" attribute for months in "Create a new patron category" step 7. Implemented the "Continue to log in to Koha" link (which works successfully) if the install.pl is run after installation has been completed 8. I have checked and I can confirm that $step variable is an integer 9. I have set the $enrolementperioddate variable as a DateTime object, see below code snippet. I tried removing the dateformat field altogether however that made the enrolementperioddate field empty. 187 #Converts the string into a date format 188 if ($enrolmentperioddate) { 189 $enrolmentperioddate = output_pref( 190 { 191 dt => dt_from_string($enrolmentperioddate), 192 dateformat => 'DateTime', 193 dateonly => 1, 194 } 195 ); 196 } -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #178 from Alex Buckley --- Created attachment 62186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62186&action=edit Bug 17855 - Followup patch following requests in comments 176 and 177 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18437] Acquisitions fund edit repair
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18437] Acquisitions fund edit repair
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 --- Comment #1 from Christopher Brannon --- Created attachment 62185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62185&action=edit Bug 18437: Repair links & testing / Add buttons To Test: 1) Create fund. 2) Select owner. 3) Select user. 4) Select same user again. 5) Note owner does not show unless you save the changes and edit the fund again. 6) Note user can be added multiple times. 7) Apply patch. 8) Repeat steps 1-4. 9) Note owner now shows first time. 10) Note user cannot be added multiple times. 11) Note links by owner and users have been changed to buttons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18437] Acquisitions fund edit repair
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |cbran...@cdalibrary.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18437] New: Acquisitions fund edit repair
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Bug ID: 18437 Summary: Acquisitions fund edit repair Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org While editing a fund, if there is no owner and you select an owner, the owner does not appear until you save the edit and edit it again. Also, when adding users, the selection tool is not checking if the user selected is already added. Links next to owner and users should be converted to buttons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18432] Most code comments assume male gender
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 Marc Véron changed: What|Removed |Added Severity|normal |trivial Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18432] Most code comments assume male gender
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 Marc Véron changed: What|Removed |Added Attachment #62182|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18432] Most code comments assume male gender
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 --- Comment #7 from Marc Véron --- Created attachment 62184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62184&action=edit Bug 18432: code comments assume male gender Comments throughout the Koha codebase assume that all librarians or borrowers are male by using the pronoun 'he' universally. This patch changes to 'he or she' / 'him or hers'. Testing plan: - ensuring modifying tests still pass: + C4/SIP/t/06patron_enable.t + t/db_dependent/Circulation.t + t/db_dependent/Koha/Patrons.t + t/db_dependent/Reserves.t Sponsored-By: California College of the Arts No code changes detected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18433] Allow to select results to export in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Marc Véron changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18436] Add home library to the SIP2 patron info response 64
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18436 --- Comment #1 from Marc Véron --- Created attachment 62183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62183&action=edit Bug 18436: SIP: Add home library to the SIP2 patron info response 64 This patch adds the patron's home library code as AQ segment to response 64 (patron information) To test: - Set up Koha SIP2 server ( https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup ) - Test without patch, verify that AQ segement does not appear in response 64 - Apply patch, stop / start SIP2 server (maybe restart plack and memcached as well) - Verify that AQ segment with patron's home library code appears in response 64 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18436] Add home library to the SIP2 patron info response 64
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18436 Marc Véron changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |ve...@veron.ch |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18432] Most code comments assume male gender
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 --- Comment #6 from Eric Phetteplace --- Alphabetical order is one reason. As I said, I'd be happy to use singular "they/them" universally if people prefer that. I could also alternate orderings between "he or she" and "she or he". New patch with whitespace changes added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18432] Most code comments assume male gender
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 Eric Phetteplace changed: What|Removed |Added Attachment #62155|0 |1 is obsolete|| --- Comment #5 from Eric Phetteplace --- Created attachment 62182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62182&action=edit new patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18436] Add home library to the SIP2 patron info response 64
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18436 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18433] Allow to select results to export in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Marc Véron changed: What|Removed |Added Attachment #62170|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 62181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62181&action=edit Bug 18433: Allow to select results to export in item search This adds a column of checkboxes in the results table to be able to select the items to be exported Test plan: 1. Go to item search and click 'Search' 2. Without checking any checkbox, verify that the export still works (it should export all results) 3. Tick some checkboxes and re-export, verify that only selected items are exported Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18420] Some tests fail without patron category 'S'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18420] Some tests fail without patron category 'S'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron changed: What|Removed |Added Attachment #62164|0 |1 is obsolete|| --- Comment #28 from Marc Véron --- Created attachment 62180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62180&action=edit Bug 18420: Fix HoldFulfillmentPolicy.t and Passwordrecovery.t We are going out of scope here, but these tests need a branch/item. Test plan: Run the adjusted tests. Signed-off-by: Marcel de Rooy Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18420] Some tests fail without patron category 'S'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron changed: What|Removed |Added Attachment #62118|0 |1 is obsolete|| --- Comment #27 from Marc Véron --- Created attachment 62179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62179&action=edit Bug 18420: Replace hardcoded EUR in OrderUsers.t Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18420] Some tests fail without patron category 'S'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron changed: What|Removed |Added Attachment #62115|0 |1 is obsolete|| --- Comment #26 from Marc Véron --- Created attachment 62178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62178&action=edit Bug 18420: Do not use 'S' as patron category code in other tests Test plan: prove all these tests, they must all pass Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18420] Some tests fail without patron category 'S'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron changed: What|Removed |Added Attachment #62093|0 |1 is obsolete|| --- Comment #25 from Marc Véron --- Created attachment 62177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62177&action=edit Bug 18420: Use TestBuilder to create a patron category in Suggestions.t No need to do it that way, let's use TestBuilder. Test plan: prove t/db_dependent/Suggestions.t should still return green Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18420] Some tests fail without patron category 'S'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron changed: What|Removed |Added Attachment #62092|0 |1 is obsolete|| --- Comment #24 from Marc Véron --- Created attachment 62176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62176&action=edit Bug 18420: Fix Members.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Members.t should return green, even if no categories.categorycode 'S' exists Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Larry Baerveldt changed: What|Removed |Added CC||la...@bywatersolutions.com --- Comment #14 from Larry Baerveldt --- Just a FYI on this. I found that *not* using koha-foreach, and instead use the actual koha instance user also works. For example, instead of: root koha-foreach --enabled --email /usr/share/koha/bin/cronjobs/process_message_queue.pl if you use: INST-koha /usr/share/koha/bin/cronjobs/process_message_queue.pl it works. So taking a look at how koha-foreach switches to the user might provide some clues. Can confirm this also happens on Debian 8.4. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18420] Some tests fail without patron category 'S'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron changed: What|Removed |Added Attachment #62091|0 |1 is obsolete|| --- Comment #23 from Marc Véron --- Created attachment 62175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62175&action=edit Bug 18420: Fix Passwordrecovery.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Passwordrecovery.t should return green, even if no categories.categorycode 'S' exists Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18420] Some tests fail without patron category 'S'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron changed: What|Removed |Added Attachment #62090|0 |1 is obsolete|| --- Comment #22 from Marc Véron --- Created attachment 62174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62174&action=edit Bug 18420: Fix Budgets.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Budgets.t should return green, even if no categories.categorycode 'S' exists Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18432] Most code comments assume male gender
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #4 from Marc Véron --- QA tools complain for one file: FAILacqui/neworderempty.pl FAIL forbidden patterns forbidden pattern: tab char (line 157) Question: Why is the male form always at the first place ('he or she' / 'him or her')? Does that not introduce a new inequality? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18435] Message about Materials specified does not display when items are checked out and checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch Status|Needs Signoff |Signed Off Summary|Language entered in |Message about Materials |Materials Specified does|specified does not display |not display when items are |when items are checked out |checked out and checked in |and checked in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18435] Language entered in Materials Specified does not display when items are checked out and checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435 Marc Véron changed: What|Removed |Added Attachment #62172|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 62173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62173&action=edit Bug 18435 - Language entered in Materials Specified does not display when items are checked out and checked in This problem stems from bug 17642, if items.materials is not linked to an authorized value the contents are being tossed out. We shuold display them instead To test: 1 - Ensure items.materials 952$3 is not mapped to an authorized value 2 - Add a value to an item 3 - Check the item out, note the materials does not display 4 - Check the item in, note the materials does not display 5 - Apply patch 6 - Check the item out, note the materials does display 7 - Check the item in, note the materials does display Followed test plan, message about material displays as expected whil checking out and in. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18436] New: Add home library to the SIP2 patron info response 64
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18436 Bug ID: 18436 Summary: Add home library to the SIP2 patron info response 64 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: geo...@shoutbomb.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Koha's SIP2 server should provide additional patron related info, in this case the patron's home library. This will be a new segment and should be the key not the name. The following is an example from another ILS SIP2 response with the segment AQ providing the home library info. SIP2:response:: 64 00020170412 183401AOzzz|AA213919|AEWALKER JONNY|AQpcl|BZ0050|CA0020|CB0250|BLY|CQY|BHUSD|CC10.|BD12655 S KOHA AVE, HELLO, AZ, 9|BF111-222-|DJWALKER MOLLY|PB19950808|PCres|PE20190412 235900|PS20190412235900|ZYres|AY2AZB936 Thanks... George -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18435] Language entered in Materials Specified does not display when items are checked out and checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435 Nick Clemens changed: What|Removed |Added QA Contact|n...@bywatersolutions.com |testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17642] Authorised values code is broken because of the refactoring
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Nick Clemens changed: What|Removed |Added Blocks||18435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435 [Bug 18435] Language entered in Materials Specified does not display when items are checked out and checked in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18435] Language entered in Materials Specified does not display when items are checked out and checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435 Nick Clemens changed: What|Removed |Added Version|16.11 |master Patch complexity|--- |Trivial patch Depends on||17642 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | Severity|enhancement |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 [Bug 17642] Authorised values code is broken because of the refactoring -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18435] Language entered in Materials Specified does not display when items are checked out and checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435 --- Comment #1 from Nick Clemens --- Created attachment 62172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62172&action=edit Bug 18435 - Language entered in Materials Specified does not display when items are checked out and checked in This problem stems from bug 17642, if items.materials is not linked to an authorized value the contents are being tossed out. We shuold display them instead To test: 1 - Ensure items.materials 952$3 is not mapped to an authorized value 2 - Add a value to an item 3 - Check the item out, note the materials does not display 4 - Check the item in, note the materials does not display 5 - Apply patch 6 - Check the item out, note the materials does display 7 - Check the item in, note the materials does display -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18435] Language entered in Materials Specified does not display when items are checked out and checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18435] Language entered in Materials Specified does not display when items are checked out and checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435 Kelly McElligott changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18435] New: Language entered in Materials Specified does not display when items are checked out and checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435 Bug ID: 18435 Summary: Language entered in Materials Specified does not display when items are checked out and checked in Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Language entered in Materials Specified does not display when items are checked out and checked in. When checking out an item out and checking in an item in 16.11, the information listed in "Materials Specified" 952 subfield 3 does not display or alert the librarian with this language. In previous releases, the language in "materials specified" was alerted to staff at both check in and checkout. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18432] Most code comments assume male gender
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 --- Comment #3 from Eric Phetteplace --- I disagree that making code base gender inclusive is trivial. It discourages contributions from female developers. It's also just flat-out inaccurate, as in places where tests assume all juveniles are male (t/db_dependent/Koha/Patrons.t). I searched over the templates as well and they tended to not have this problem, it's almost entirely in comments or strings printed during tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18245] debian/templates/koha-conf-site.xml.in missing tls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18245 --- Comment #3 from M. Tompsett --- (In reply to Mirko Tietgen from comment #2) > If you want to add this, I think you also need to add , and ? You may be right, but check out the diff between etc/koha-conf.xml and debian/templates/koha-conf-site.xml/in currently. I'm not sure the correct way to add, because hard-coded-path/__KOHASITE__/rest-of-path is not the same as __SOME_THING_TO_FULLY_REPLACE__/rest-of-path. Thoughts? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #52 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17821] due date in intranet search results should use TT date plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to master for 17.05, thanks Frido! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #14 from Kyle M Hall --- Pushed to master for 17.05, thanks Alex! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18373] `make upgrade` is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18373] `make upgrade` is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Attachment #61840|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 --- Comment #1 from Nick Clemens --- Created attachment 62171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62171&action=edit Bug 18434 - Elasticsearch indexing broken with newer catmandu version To test: 1 - Make sure you have latest koha deps, catmandu versions should be: libcatmandu-marc-perl 1.09-1~kohadev1 libcatmandu-perl1.0304-2~kohadev1 2 - Reindex elastic 3 - Try searching and likely notice odd results 4 - Try: curl -XGET 'http://localhost:9200/koha_kohadev_biblios/data/792?pretty=true' with a known biblionumber and notice some null fields 5 - Apply patch 6 - Reindex 7 - Note fields are populated and search works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18433] Allow to select results to export in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18433] Allow to select results to export in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #1 from Julian Maurice --- Created attachment 62170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62170&action=edit Bug 18433: Allow to select results to export in item search This adds a column of checkboxes in the results table to be able to select the items to be exported Test plan: 1. Go to item search and click 'Search' 2. Without checking any checkbox, verify that the export still works (it should export all results) 3. Tick some checkboxes and re-export, verify that only selected items are exported -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18433] New: Allow to select results to export in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Bug ID: 18433 Summary: Allow to select results to export in item search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Searching Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org Depends on: 18394 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 [Bug 18394] Add an option to item search to export a barcodes file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Julian Maurice changed: What|Removed |Added Blocks||18433 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 [Bug 18433] Allow to select results to export in item search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18434] New: Elasticsearch indexing broken with newer catmandu version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Bug ID: 18434 Summary: Elasticsearch indexing broken with newer catmandu version Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Using the newly packaged catmandu it seems our mappings for multiple fields to a single index overwrite rather than append. vfernandes actually pointed out the problem and solution so major thanks to him -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18429] Receiving an item should update the datelastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 --- Comment #5 from Nick Clemens --- Hmm.. Date received defaults to today - I would say if you are changing that (receiving on past days) you might not physically have the item in hand so are confirming you saw it last on the day you received it? I would think it should be this way, but am open to changing it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17502] Add type check to output_pref and use exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17502] Add type check to output_pref and use exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502 Marcel de Rooy changed: What|Removed |Added Attachment #61518|0 |1 is obsolete|| Attachment #61519|0 |1 is obsolete|| --- Comment #28 from Marcel de Rooy --- Created attachment 62168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62168&action=edit Bug 17502: Add type check to output_pref This patch makes the following changes: [1] In Koha/DateUtils.pm, sub output_pref: Add a test if $dt is really a DateTime before calling method ymd. Preventing a crash like: Can't locate object method "ymd" via package "dateonly". See also BZ 17502/15822. [2] Adds a few unit tests in t/DateUtils.t. Test plan: [1] Run the adjusted unit test t/DateUtils.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17502] Add type check to output_pref and use exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502 --- Comment #29 from Marcel de Rooy --- Created attachment 62169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62169&action=edit Bug 17502: Throw some exceptions in output_pref Test plan: Run the adjusted t/DateUtils.t Signed-off-by: Josef Moravec NOTE: This patch is amended in QA. The exceptions are moved from a separate module to the general section of Exceptions.pm. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17821] due date in intranet search results should use TT date plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17821] due date in intranet search results should use TT date plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Marcel de Rooy changed: What|Removed |Added Attachment #58567|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 62167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62167&action=edit Bug 17821 - due date in intranet search results should use TT date plugin Intranet search results displays due date from item onloan. This should use the TT date plugin. Test plan : - set syspref dateformat not on -mm-dd, for example dd/mm/ - checkout an item - at intranet, perform a search where you see the item => You must see : "date due : dd/mm/" Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17821] due date in intranet search results should use TT date plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Marcel de Rooy changed: What|Removed |Added Attachment #62117|0 |1 is obsolete|| --- Comment #13 from Marcel de Rooy --- Created attachment 62166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62166&action=edit Bug 12930: Web installer does not show login errors Implemented invalid_username_or_password template variable being handed to Auth.tt. Removed indentation changes and modification to return value of checkpw Test plan: See comment #2 Alternative test plan: - Clear session cookies or close / open your browser - Go to [MY SERVER]/cgi-bin/koha/installer/install.pl - Verify that message appears if wrong username/pw provided - Verify that you can log in with databas administrator account Tested with alternative test plan, works as expected. Title and description in commit message adapted. Signed-off-by: Marc Véron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #19 from Kyle M Hall --- Comment on attachment 57425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57425 Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket Review of attachment 57425: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15685&attachment=57425) - ::: installer/data/mysql/kohastructure.sql @@ +2964,4 @@ >`basketgroupid` int(11), -- links this basket to its group > (aqbasketgroups.id) >`deliveryplace` varchar(10) default NULL, -- basket delivery place >`billingplace` varchar(10) default NULL, -- basket billing place > + create_items ENUM('ordering', 'receiving', 'cataloguing') default NULL; -- > when items should be created for orders in this basket The semicolon needs to be a comma, and an atomicupdate needs to be added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18373] `make upgrade` is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 --- Comment #7 from Marcel de Rooy --- Created attachment 62165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62165&action=edit Bug 18373: Re-add UpgradeBackup.pm Bug 18028 removed the install_misc directory but install_misc/UpgradeBackup.pm was still used by the 'upgrade' rule of make. Other files from install_misc were useless to it may be better not to reintroduce this directory with only 1 file. Test plan: `make` `sudo make install` `make upgrade` Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18373] `make upgrade` is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18373] `make upgrade` is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18429] Receiving an item should update the datelastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- Shouldn't it be today instead of date received ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18420] Some tests fail without patron category 'S'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #21 from Marcel de Rooy --- Marc, could you signoff? I will pass QA after that. Further problems not strictly related to the bug theme, we should move to a new report. A few fixes are strictly out of scope already.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18420] Some tests fail without patron category 'S'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #20 from Marcel de Rooy --- Created attachment 62164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62164&action=edit Bug 18420: Fix HoldFulfillmentPolicy.t and Passwordrecovery.t We are going out of scope here, but these tests need a branch/item. Test plan: Run the adjusted tests. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #50 from Nick Clemens --- Is this one still being worked on? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18432] Most code comments assume male gender
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- I am not sure if we should start changing all comments for this kind of trivial edits. I would better understand changing templates (what we actually see on the Koha interface). But you seem to touch scripts and modules only. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #51 from Marcel de Rooy --- QA Comment: Passing QA on this patch set. I am not really a fan of the resulting DBIx tric to get this working. Now each search with localization will need an additional view and an ugly relationship hack in the schema file. But I have no other solution too. Tested the sub with no, one or several languages in localization and it works perfect. Also want to mention that the unit test t/db_dependent/Koha/ItemTypes.t is much too simplistic. Adding 2/3 English localization is not sufficient to really prove that the sub works. You cannot test localization with only one language, and English is a bad example in Koha :) We need to mock getlanguage and put a few different languages in localization to really see if it works. (I did that now manually.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16116] Change of issue publication date doesn' t reflect on the next issue generated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16116] Change of issue publication date doesn' t reflect on the next issue generated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Josef Moravec changed: What|Removed |Added Attachment #61002|0 |1 is obsolete|| --- Comment #8 from Josef Moravec --- Created attachment 62163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62163&action=edit [SIGNED-OFF] Bug 16116 - Fix problem change of issue publication date doesn't reflect on the next issue generated Test plan : 1. In Cataloging > New with Z39.50, look for issn = 1536-6596 (National Geographic) into the LCC z39.60 server. Add the record. 2. Add a new subscription for National Geographic. Fill-in the form. - use the default values of the first page - for the second page : First issue publication date = 10/01/2016 Frequency = 1/month Subscription lenght = 12 issues Subscription start date = 01/01/2016 Numbering pattern = Number Begins with = 1 - Save 3. Receive the first issue. Change the status to "received". Note that the "Published on" date = 10/01/2016. This date goes to the "Date published" column in the serial collection page. 4. The second issue is generated. Edit serial to receive the issue. 5. Change the "Published on" date to 14/02/2016. Change the status to "received". Save. 6. "Date published" for the next issue generated is : 14/03/2016. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #50 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #49) > Another observation: we should also translate the item type description in > the items table of additem.pl. > Now you have an English description in the items table and a vernacular > description in the edited item. Well, that was too fast. Some refresh pops up the right language now. So forget this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #49 from Marcel de Rooy --- Another observation: we should also translate the item type description in the items table of additem.pl. Now you have an English description in the items table and a vernacular description in the edited item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #48 from Marcel de Rooy --- I am not really impressed by the DBIx constructs here. Still trying if we could simplify a bit here.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Attachment #61969|0 |1 is obsolete|| --- Comment #44 from Marcel de Rooy --- Created attachment 62159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62159&action=edit Bug 17835: Remove the subroutine GetItemTypes At this point the subroutine is no longer in used. Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Attachment #61971|0 |1 is obsolete|| --- Comment #46 from Marcel de Rooy --- Created attachment 62161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62161&action=edit Bug 17835: Mock language pref value That way if prefs contain other languages, the test will still pass. Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #47 from Marcel de Rooy --- Created attachment 62162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62162&action=edit Bug 17835: [QA Follow-up] Fix opac-search.pl Resolves: Global symbol "$itemtypes_nocategory" requires explicit package name. Signed-off-by: Marcel de Rooy Tested the added line with a debug statement. See itemtype facets in the search results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Attachment #61970|0 |1 is obsolete|| --- Comment #45 from Marcel de Rooy --- Created attachment 62160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62160&action=edit Bug 17835: Add an additional LEFT JOIN condition using DBIx::Class The previous query was wrong. If an item type did not contain the translation in the interface's language, the ->search_with_localization did not return it at all. What we need is definitely to add a second condition on the join. For reference: http://search.cpan.org/dist/DBIx-Class/lib/DBIx/Class/Relationship/Base.pm#condition https://blog.afoolishmanifesto.com/posts/dbix-class-parameterized-relationships/ That sounds hacky but seems to be the DBIx::Class path to follow. Bug 17835: follow-up Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Attachment #61967|0 |1 is obsolete|| --- Comment #42 from Marcel de Rooy --- Created attachment 62157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62157&action=edit Bug 17835: Do not reselect translated_description if comes from search_with_localization If the Koha::ItemType object has been instanciated from a call to Koha::ItemTypes->search_with_localization, we already have the translated_description value. So there is no need to fetch it again from the DB. This is what this trick does: if the translated_description column exist in the DBIx::Class result source's column list, that means the value has already been retrieved. Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Attachment #61968|0 |1 is obsolete|| --- Comment #43 from Marcel de Rooy --- Created attachment 62158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62158&action=edit Bug 17835: Replace GetItemTypes with Koha::ItemTypes Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Attachment #61966|0 |1 is obsolete|| --- Comment #41 from Marcel de Rooy --- Created attachment 62156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62156&action=edit Bug 17835: Create a ItemtypeLocalization view To properly move C4::Koha::GetItemTypes to Koha::ItemTypes we need DBIx::Class to make a join on the localization table to retrieve the possible translated description of the item types. To do so there are 2 possibilities. The first one would have been to rename the localization table to something like itemtype_localization. That way we could have had a relationship between itemtype_localization.code and itemtypes.itemtype That would have meant to create one table per "entity" (here an entity is itemtype) we allow the translability. There are pros and cons for this choice, so I opt for another solution. The other solution is to create a view on top of this localization table. With this new view we can define the missing relationship. That sounds like a quite clean solution and easy to implement. Once we have this relationship, the Koha::ItemTypes->search_with_localization will join on this view an return the same result as GetItemTypes( style => 'array' ). To replace GetItemtypes( style => 'hash' ) which is the default behavior of this subroutine, we can do something like: my $itemtypes = Koha::ItemTypes->search_with_localization; my %itemtypes = map { $_->{itemtype} => $_ } @{ $itemtypes->unblessed }; This patchset must not introduce big changes but it changes certain behaviors (which were wrong) in some scripts. Indeed sometimes the descriptions of the item types were not the translated ones. Moreover it happens that the item types displayed in a dropdown list were not ordered by translated description, but by description of code (itemtypes.itemtype value). These 2 behaviors are what we expect. Test plan: Bugs will be hard to catch since these patches change a lot of file, it will be easier to read the diff and catch possible typos or logic errors. However signoffers can focus on modified files and the item types values. Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/