[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #5 from Marcel de Rooy --- Still want to mention: [1] Should koha-remove remove a custom template cache dir? It currently does not and this is consistent with the way we handle other dirs like uploads. Although template cache files are better candidates for immediate removal. [2] Should we somehow allow a user to say that he does not want template caching? I think that it is good to enable template caching by default now in packaging, but should we make it easier to disable it ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18463] New: Hold request status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18463 Bug ID: 18463 Summary: Hold request status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: blac...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com User case - library with more brachces, especially with branches in ther physical location than main brach which are't operate everyday (example: storehouse without staff service) - transfers of items from/to branches - library with rotating staff team Problem: Borrower request item as hold to pull. Free item is at remote branche, so we need to send car for it. Very oftev are brach closed to public, so staff can' solve request immediately. It take some time and Koha don't make any mark at hold to pull request list. Staff members don't know status of request and need check details about request it again and again. Solution: - add new column into hold to pull request list named Status - list of status as authorized value for easy customization - if somebody change status Koha save it with information abou time a staff name into column - fiter over column Status foe easy sorting request by status - list can by sorted by timestamp that solve bug 18454 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Marcel de Rooy changed: What|Removed |Added Attachment #59512|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 62443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62443&action=edit Bug 17951: Make koha-create set template_cache_dir correctly This patch makes koha-create (and friends) handle the template_cache_dir config entry correctly. It does so by: - Adding a replaceable string to the template for koha-conf.xml - Making koha-create-dirs create the needed directories (i.e. /var/cache/koha/instance and /var/cache/koha/instance/templates) - Adding a --template-cache-dir switch to koha-create (so sysadmins can specify their favourite directory for the templates cache). - koha-remove now takes care of the instance's *templates* dir. - The install scripts now automatically create /var/cache/koha so it can be used later by koha-create and friends. It does so the same way it does for other install-created directories. To test, you should ideally be able to build your own packages. This instructions can be followed by people that doesn't have that ability yet. But can be used on a custom packages setup too. To test: - Make sure you have the latest misc4dev in your kohadevbox (if it is a fresh box you have it already) - Run: $ sudo perl misc4dev/cp_debian_files.pl - Manually create the /var/cache/koha dir (skip if you have your own packages): $ sudo mkdir /var/cache/koha - Create a new instance: $ sudo koha-create --create-db cachetest => SUCCESS: * /etc/koha/sites/cachetest/koha-conf.xml contains template_cache_dir and is populated with /var/cache/koha/cachetest/templates * The directory /var/cache/koha/cachetest/templates exists! - Create a new instance, pass your own cache dir: $ sudo koha-create --create-db --template-cache-dir /tmp cachetest2 => SUCCESS: etc/koha/sites/cachetest2/koha-conf.xml contains template_cache_dir and is populated with /tmp - Run: $ man koha-create => SUCCESS: The docs mention the --template-cache-dir option switch correctly. - Sign off :-D! Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #13 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #12) > Signed-off-by: Tomas Cohen Arazi Thx -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18448] Fix a few db_dependent tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18448 --- Comment #12 from Marcel de Rooy --- Thanks Marc and Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Marc Véron changed: What|Removed |Added Attachment #62440|0 |1 is obsolete|| --- Comment #9 from Marc Véron --- Created attachment 62442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62442&action=edit Bug 10267: Show error message if user tries to enter too many characters for cardnumber This patch displays a message if the user tries to enter more than the max number of characters for a cardnumber. To test: 1) Apply patch and go to Patrons -> New patron 2) Scroll down to Card number 3) Put in any characters. Notice that when you have entered the max number of characters, you are unable to type any more. 4) If you try to type again, the error message will show up. 5) if you backspace some characters, the message should disappear Sponsored-by: Catalyst IT Followed test plan, works as expected Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 --- Comment #21 from Marc Véron --- Created attachment 62441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62441&action=edit Bug 7550: SCO - Restrict access of patron's image With this patch if SelfCheckoutByLogin is set to 'username and password', only the logged in user will be able to see the image linked to his/her logged in account. If set to "barcode" we generate a token but it can be easily generated. You should add a warning in the about page if SelfCheckoutByLogin="barcode" and ShowPatronImageInWebBasedSelfCheck="Show". How I tested: - Go to SCO - Log - Enable self checkout, go to [Your Server]//cgi-bin/koha/sco/sco-main.pl - Log in with a user 'A' who has a patron image - Copy the address of the patron image into an other browser window - Change the borrowernumber to on of an other user 'B' having a patron image - Verify that the patron image is NOT displayed Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Marc Véron changed: What|Removed |Added Attachment #62311|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Marc Véron changed: What|Removed |Added Attachment #62289|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Marc Véron changed: What|Removed |Added Assignee|ve...@veron.ch |jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Needs Signoff --- Comment #20 from Marc Véron --- I'm not at all against the token approach, but I still think there is a misunderstanding about the original target of this bug. Since I do not want to block the bug I will sign of your alternative patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18186] Amounts with decimal comma instead of decimal dot breaking payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186 --- Comment #3 from Katrin Fischer --- Hi Alex, this is not easy to reproduce as it depends on the environment/Plack configuration (see comment from my coworker Ulrich). It's real, but not sure if a patch can be written to fix it. We thought it would be good to write up our finding in case another library runs into this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13617] Change wording on suspend
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13617 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #7 from Aleisha Amohia --- Is this still valid? The wording hasn't changed but I believe the icons would help enforce the action of the link? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18186] Amounts with decimal comma instead of decimal dot breaking payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|In Discussion --- Comment #2 from Alex Buckley --- Hi Katrin I tried following your test plan doing the following, on the latest version of Koha * Turning on plack * Creating a manual invoice with the value 10.00 * Going to the fines tab and observed both the individual fine and the total were displayed with . i.e. 10.00 not a , Therefore I am unable to replicate this test plan -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17462] Pay fines not accepting ', ' for EUR currency input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17462 Alex Buckley changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17462] Pay fines not accepting ', ' for EUR currency input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17462 Alex Buckley changed: What|Removed |Added Status|NEW |ASSIGNED CC||alexbuck...@catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Aleisha Amohia changed: What|Removed |Added Assignee|oleon...@myacpl.org |alei...@catalyst.net.nz Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 --- Comment #8 from Aleisha Amohia --- Created attachment 62440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62440&action=edit Bug 10267: Show error message if user tries to enter too many characters for cardnumber This patch displays a message if the user tries to enter more than the max number of characters for a cardnumber. To test: 1) Apply patch and go to Patrons -> New patron 2) Scroll down to Card number 3) Put in any characters. Notice that when you have entered the max number of characters, you are unable to type any more. 4) If you try to type again, the error message will show up. 5) if you backspace some characters, the message should disappear Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Aleisha Amohia changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
Srdjan Jankovic changed:
What|Removed |Added
Attachment #57583|0 |1
is obsolete||
--- Comment #119 from Srdjan Jankovic ---
Created attachment 62439
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62439&action=edit
bug_11213: Check for $item->{itype} presence to avoid warning
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What|Removed |Added Attachment #57580|0 |1 is obsolete|| --- Comment #116 from Srdjan Jankovic --- Created attachment 62436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62436&action=edit bug_11213: Include XSLT processing for searchResults() test * Added template paths to temp test dir, so XSLT templates can be picked up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What|Removed |Added Attachment #57582|0 |1 is obsolete|| --- Comment #118 from Srdjan Jankovic --- Created attachment 62438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62438&action=edit bug_11213: Added XSLTParse4Display() to Items test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What|Removed |Added Attachment #57581|0 |1 is obsolete|| --- Comment #117 from Srdjan Jankovic --- Created attachment 62437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62437&action=edit bug_11213: GetItemsInfo() test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What|Removed |Added Attachment #57579|0 |1 is obsolete|| --- Comment #115 from Srdjan Jankovic --- Created attachment 62435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62435&action=edit bug_11213: whitespace correction -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What|Removed |Added Attachment #57578|0 |1 is obsolete|| --- Comment #114 from Srdjan Jankovic --- Created attachment 62434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62434&action=edit bug_11213: Changed XSLTParse4Display() interface The list of biblio items is passed on now, instead of GetItemsInfo() being called. This is because the callers already have the list ready, so the GetItemsInfo() call is being duplicated unnecessarily. Search::searchResults() builds items list from XML, and that one is passed instead. * XSLT::XSLTParse4Display() - supply the items list as input param - removed hidden items list param - hidden should not be in the items list - changed buildKohaItemsNamespace() accordingly * Items - added sort_by input param to GetItemsInfo() * catalogue/detail.pl, opac/opac-detail.pl, shelfpage() - added items list to the XSLTParse4Display() call * Search::searchResults() - include all available info when building items lists - added combined items list (available, on loan, other) to the XSLTParse4Display() call To test: This change is a noop, so following screens need to be checked against any changes: * Intranet: - catalogue/search.pl (results) - catalogue/detail.pl - virtualshelves/shelves.pl * Opac - opac-search.pl (results, hidelostitems syspref on and off) - opac-detail.pl - opac-shelves.pl The display should stay the same before and after patch. The speed should increase though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17834] Change library news text for single-branch libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17834 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|oleon...@myacpl.org |alei...@catalyst.net.nz CC||alei...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17834] Change library news text for single-branch libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17834 --- Comment #1 from Aleisha Amohia --- Created attachment 62433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62433&action=edit Bug 17834: Change library news text for single-branch libraries To test: 1) Log into OPAC, go to home page 2) Confirm that the text shows as 'RSS feed for (branchname) library news' if single-branch library 3) Confirm text shows as normal for libraries with more than one branch Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17834] Change library news text for single-branch libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17834 Aleisha Amohia changed: What|Removed |Added Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #25 from Srdjan Jankovic --- (In reply to Owen Leonard from comment #23) > Created attachment 62294 [details] > Screenshot showing a problem with the checkout box > > something weird happens when the patron's fines are past the > noissuescharge limit. The checkout form is hidden from all users, whether > they have permission to override or not. That may be an existing condition. I've made some changes to take in account AllowFineOverride pref. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18186] Amounts with decimal comma instead of decimal dot breaking payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186 Alex Buckley changed: What|Removed |Added Status|NEW |ASSIGNED CC||alexbuck...@catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic changed: What|Removed |Added Attachment #60631|0 |1 is obsolete|| --- Comment #24 from Srdjan Jankovic --- Created attachment 62432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62432&action=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17214] Add item in LIST by Record number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|gmcha...@gmail.com |alei...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17214] Add item in LIST by Record number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214 --- Comment #4 from Aleisha Amohia --- Created attachment 62431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62431&action=edit Bug 17214: Add records to lists by biblionumber To test: 1) Apply patch and go to Lists 2) Click on an existing list or create a new list 3) Add items by barcode, confirm this functionality still works 4) Trigger error messages (adding duplicate barcodes, barcodes that don't exist) to confirm they still show as appropriate 5) Test adding by biblionumber, confirm this works as expected 6) Trigger error messages (adding duplicate biblionumbers, biblionumbers that don't exist). Confirm wording is appropriate in messages. 7) Add both barcodes and biblionumbers at the same time, confirm this works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17214] Add item in LIST by Record number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18462] Implemented bootstrap styling on the web installer and onboarding tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18462 --- Comment #7 from Alex Buckley --- Created attachment 62430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62430&action=edit Bug 18462 - Changed the display of the in the onboardinstep5.tt and the location of the onboarding string in onboardingstep3.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18462] Implemented bootstrap styling on the web installer and onboarding tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18462 --- Comment #6 from Alex Buckley --- Created attachment 62429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62429&action=edit Bug 18462 - Changed the position of installer strings on the onboarding screens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18462] Implemented bootstrap styling on the web installer and onboarding tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18462 --- Comment #5 from Alex Buckley --- Created attachment 62428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62428&action=edit Bug 18462 - Merged patches on bugs 17855 and 17942 to implemented the bootstrap styling onto the web installer and newly altered onboarding tool. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18462] Implemented bootstrap styling on the web installer and onboarding tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18462 --- Comment #4 from Alex Buckley --- Created attachment 62427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62427&action=edit Bug 17855 - Reverted back to original step 3 in the web installer so there is no basic and advanced setup mode and consequently no need for SQL files to be moved to a 'default' directory for all languages. Onboarding tool and the rest of the web installer still exists in this commit How I tested in my VM (Current master): - Dropped database - Recreated database - Went through installer - Language en, Marc21 - Installed mandatory data only - Went through Onboarding tool - After finishing, logged in as superlibrarian that was created by onboarding tool Everything worked fine. Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart Bug 17855 - Followup patch following requests in comments 176 and 177 Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart Bug 17855: perltidy onboarding.pl Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Bug 17855: Do not create a new dbh, get it from C4::Context->dbh Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Bug 17855: Redirect to the installer if installation process is not done yet Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Bug 17855: No need to resend the library list to the template This has been done at the beginning of the script Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Bug 17855: Simplify the onboarding tool This patch should not modify a lot the behaviours of the onboarding tool. Its goal is mainly to remove duplicated as well as useless (because copy/pasted from existing script files) code. It assumes that the onboarding tool will be done on an empty database and will skip steps that are not needed. For instance if a library already exists, the first step will be skipped. One of the main problem was the lack of feedback messages sent to the user when something wrong/ok happened. Explanation on main changes: 1. Use checkauth first, then get_template_and_user => As we do not know the template to use, it's better to use checkauth first to know if the user is logged in, then retrieve the template we need, depending on the success or the failure of the action 2. Create a @messages variables Pushing messages to this variable and handling the messages via an include files (onboarding_messages.inc) simplify error handling. Note that we could remove this include file if we merge all the onboardingstepX.tt files altogether 3. Simplify creation of the admnistrator user This patch removes some unecessary checks done on the user's info (passwd to short, mandatory fields Todo (minor): Add style to feedback messages Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Bug 17942 - Update style of the web installer with Bootstrap 3 This patch makes style and markup changes to the web installer and new onboarding tool (Bug 17855). - Markup has been corrected, improved, and in many places reindented. - Some page titles have been made more specific. - Some JavaScript and CSS have been moved to separate files. In the onboarding tool I have removed form validation from the markup and JavaScript in many cases where the requirements were not matched elsewhere in Koha. For instance, we shouldn't limit item type descriptions to only letters because the database doesn't require such a limit. To test, apply the patch and run the web installer with an empty database. Confirm that the installation process completes correctly and that each page looks good and works correctly. Signed-off-by: Josef Moravec Signed-off-by: Liz Rea https://bugs.koha-community.org/show_bug.cgi?id=18462 Bug 17942 - Add anti-clickjack code to installer doc head close -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18462] Implemented bootstrap styling on the web installer and onboarding tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18462 --- Comment #3 from Alex Buckley --- Created attachment 62426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62426&action=edit Bug 17855: Onboarding tool Tested 3 patches together on current master - Dropped database - Recreated database - Went through installer - Language en, Marc21 - Installed mandatory data only - Went through Onboarding tool - After finishing, logged in as superlibrarian that was created by onboarding tool Everything worked fine. Signed-off-by: Marc Véron Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18462] Implemented bootstrap styling on the web installer and onboarding tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18462 Alex Buckley changed: What|Removed |Added Attachment #62425|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18462] Implemented bootstrap styling on the web installer and onboarding tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18462 Alex Buckley changed: What|Removed |Added Attachment #62424|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18462] Implemented bootstrap styling on the web installer and onboarding tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18462 --- Comment #2 from Alex Buckley --- Created attachment 62425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62425&action=edit Bug 18462 - Merged patches on bugs 17855 and 17942 to implemented the bootstrap styling onto the web installer and newly altered onboarding tool. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18462] Implemented bootstrap styling on the web installer and onboarding tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18462 --- Comment #1 from Alex Buckley --- Created attachment 62424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62424&action=edit Bug 17942 - Update style of the web installer with Bootstrap 3 This patch makes style and markup changes to the web installer and new onboarding tool (Bug 17855). - Markup has been corrected, improved, and in many places reindented. - Some page titles have been made more specific. - Some JavaScript and CSS have been moved to separate files. In the onboarding tool I have removed form validation from the markup and JavaScript in many cases where the requirements were not matched elsewhere in Koha. For instance, we shouldn't limit item type descriptions to only letters because the database doesn't require such a limit. To test, apply the patch and run the web installer with an empty database. Confirm that the installation process completes correctly and that each page looks good and works correctly. Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #3 from Alex Buckley --- This patch does not undo the security bug fixes of bug 18275 (opac-memberentry.pl security vulnerabilities) because all tests in the unit test t/db_dependent/Auth.t run successfully with this patch applied. See test output below: kohadev-koha@kohadevbox:/home/vagrant/kohaclone/t/db_dependent$ prove Auth.t Auth.t .. ok All tests successful. Files=1, Tests=21, 3 wallclock secs ( 0.03 usr 0.00 sys + 2.12 cusr 0.08 csys = 2.23 CPU) Result: PASS kohadev-koha@kohadevbox:/home/vagrant/kohaclone/t/db_dependent$ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15490] Changing SIP response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15490 Liz Rea changed: What|Removed |Added CC||l...@catalyst.net.nz Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Liz Rea --- Link is broken. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #2 from Alex Buckley --- Created attachment 62423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62423&action=edit Bug 18442 - Implemented assignment of the $userid variable before the haspermission call so that a defined $userid with a value is being passed to the haspermission() method. Previously the $userid variable was undefined when it was handed to the haspermission() method and this was causing 'Error: You do not have permission to access this page' errors when logging into the staff interface as database user. However if you viewed the url in a new tab you could view the staff interface. Test plan: 1. Drop and recreate your db 2. Clear memcached 3. Go through the installer (to speed up this test plan install all sample data so you dont have to create libraries, patron categories etc. later) 4. On the installer page login as the database user and notice that it does not work on the first attempt ( you get 'Error: You do not have permission to access this page') 5. Try logging in as database user for a second time and notice you are logged in successfully this time 4. In staff interface create a patron account with superlibrarian permissions 5. Logout of the staff interface 6. Login as database user 7. Notice you cant log in. You get the 'Error:: You do not have permission to access this page' error 8. Try a second attempt and notice you get the same error 9. Open the URL in a new tab and notice the staff interface appears showing that you are logged in 10. log out and log back in as the superlibrarian user you created and notice it works on first login attempt 11. Apply patch 12. Log out and try logging back in as database user and notice that you can login successfully on first attempt 13. Repeat steps 1,2,3 and login as database user and notice the login works on first attempt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18382] action_logs entry for module HOLDS, action SUSPEND is spammy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18382
--- Comment #2 from Barton Chittenden ---
(In reply to Aleisha Amohia from comment #1)
> I am not seeing this error.
> When I click Suspend, this is the entry that gets inserted into the action
> log:
>
> $VAR1 = {'waitingdate' => undef,'itemnumber' => undef,'timestamp' =>
> '2017-04-18 23:54:43','notificationdate' => undef,'priority' =>
> '1','biblionumber' => '21','expirationdate' => undef,'cancellationdate' =>
> undef,'reminderdate' => undef,'found' => undef,'reservedate' =>
> '2017-04-18','suspend_until' => bless( {'locale' => bless(
> {'default_time_format_length' => 'medium','en_complete_name' => 'English
> United States','native_territory' => 'United
> States','default_date_format_length' => 'medium','native_language' =>
> 'English','en_territory' => 'United States','native_complete_name' =>
> 'English United States','en_language' => 'English','id' => 'en_US'},
> 'DateTime::Locale::en_US' ),'tz' => bless( {'name' => 'UTC'},
> 'DateTime::TimeZone::UTC' ),'utc_rd_days' => 736440,'utc_rd_secs' =>
> 0,'local_rd_secs' => 0,'offset_modifier' => 0,'local_rd_days' =>
> 736440,'rd_nanosecs' => 0,'local_c' => {'year' => 2017,'month' => 4,'day' =>
> 21,'day_of_quarter' => 21,'quarter' => 2,'hour' => 0,'minute' =>
> 0,'day_of_year' => 111,'day_of_week' => 5,'second' => 0},'formatter' =>
> undef,'utc_year' => 2018}, 'DateTime' ),'lowestPriority' => '0','branchcode'
> => 'CPL','suspend' => 1,'reserve_id' => '232','reservenotes' =>
> '','itemtype' => undef,'borrowernumber' => '51'};
>
> It's a little long, sure, but it doesn't separate for each new line like in
> your attachment.
My formatting came from the fact that I queried action_logs via the command
line, using mysql's '\G' query terminator, which puts in the line breaks.
Apparently your 'locale' variable is fairly compact... mine isn't.
In any case 'suspend_until' is still refers to a datetime object which is
dumped in its entirity, that *may* get huge, and none of it is information that
the user will need or want.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 --- Comment #19 from Jonathan Druart --- (In reply to Marc Véron from comment #18) > So again: Are we talking about different things? > Are you talking about accessing the SCO screen by guessing the card number? Well it will be hard to answer binarily apparently as you are considering it's 2 different things and I consider it's the same thing. When you load sco-main.pl it GET sco-patron-image.pl, so there is no different for me. As I said earlier both versions do the same thing and have the same problem. Just considering using Koha::Token is the way to go. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 --- Comment #18 from Marc Véron --- Could it be that we talk about different things? The initial comment was: - The patron image display in the self-checkout takes a GET parameter from the image source, so if someone copied the image location and substituted the barcode string they could browse through all patron images: It would offer patrons better privacy to limit that request based on the currently-logged-in user. - (Note that meanwhile the param is borrowernumber). So somebody who is logged in to SCO can browse through the images by guessing/changing the borrowernumber: http://192.168.1.31/cgi-bin/koha/sco/sco-patron-image.pl?borrowernumber=1 http://192.168.1.31/cgi-bin/koha/sco/sco-patron-image.pl?borrowernumber=2 With my two patches applied, a hash is added, based on the contents of the image. The contents of the image is stored in the database (as blob) The new link to display the image is something like: http://192.168.1.31/cgi-bin/koha/sco/sco-patron-image.pl?borrowernumber=1&ck=a0923303852da8c10a383fb81f1a73d3 If you copy this addres and change borrowernumber e.g. to 2, the image won't display. To create a hash that fits to borrowernumber 2, you would need the image, otherwise it is impossible. So again: Are we talking about different things? Are you talking about accessing the SCO screen by guessing the card number? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Chris Cormack changed: What|Removed |Added Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Alex Buckley changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Alex Buckley changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #5 from Alex Buckley --- (In response to Owen Leonard in comment 3) Hi Owen As that onclick event isn't necessary I have removed it in the patch I just attached. Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 --- Comment #4 from Alex Buckley --- Created attachment 62422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62422&action=edit Bug 18438 - Removed onclick event on 'Confirm hold' button to adhere to coding guidelines following feedback -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18346] Improved web installer containing basic and advanced setup modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18346 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 --- Comment #17 from Jonathan Druart --- I do not understand how your approach can protect the image in any way if SelfCheckoutByLogin="barcode". Hit /cgi-bin/koha/sco/sco-main.pl Guess a cardnumber => You see the image Both approaches have the same problem, that's why I suggest to add a warning on the about page. The only difference is that the second approach uses Koha::Token that it already used at different places. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18462] New: Implemented bootstrap styling on the web installer and onboarding tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18462 Bug ID: 18462 Summary: Implemented bootstrap styling on the web installer and onboarding tool Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuck...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com This is implementing the bootstrap styling work that Owen Leonard did in bug 17942 onto the onboarding tool (bug 17855) and the web installer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18462 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Version|17.05 |16.11 --- Comment #1 from Chris Cormack --- I've had this occur on 16.11 also. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 --- Comment #16 from Marc Véron --- (In reply to Jonathan Druart from comment #15) > (In reply to Marc Véron from comment #14) > > (In reply to Jonathan Druart from comment #12) > > > Created attachment 62400 [details] [review] [review] [review] > > > [ALTERNATIVE-PATCH] Bug 7550: SCO - Restrict access of patron's image > > > > > > With this patch if SelfCheckoutByLogin is set to 'username and > > > password', only the logged in user will be able to see the image linked > > > to his/her logged in account. > > > If set to "barcode" we generate a token but it can be easily generated. > > > You should add a warning in the about page if > > > SelfCheckoutByLogin="barcode" and > > > ShowPatronImageInWebBasedSelfCheck="Show". > > > > Hmm, my patch worked with a hash generated with the image file (as > > recommended in comment #7), and it did not leave a security hole with > > SelfCheckoutByLogin="barcode" > > Yes it does, on the same way as my patch. If you know the cardnumber (easy > to guess) of someone you can access his^Ctheir image. $patron_image->imagefile is a blob, no? - Really easy to guess. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18461] Internal server error while approving OPAC-edited patron attributes containing umlauts (äöü)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18461 Marc Véron changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18339 Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339 Marc Véron changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18461 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18461] New: Internal server error while approving OPAC-edited patron attributes containing umlauts (äöü)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18461
Bug ID: 18461
Summary: Internal server error while approving OPAC-edited
patron attributes containing umlauts (äöü)
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs@lists.koha-community.org
Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
If a OPAC user enters text containing umlauts (äöü) in a patron atribute and
saves it, the Staff client will get an inernal server error in
members-update.pl (approving).
E.g. a text like 111ä222 leads to the following in plack error log:
malformed UTF-8 character in JSON string, at character offset 14 (before
"\x{fffd}2","code":"T...") at (...)/Koha/Patron/Modifications.pm line 100.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814 Jonathan Druart changed: What|Removed |Added Version|16.11 |master CC||jonathan.dru...@bugs.koha-c ||ommunity.org Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814 Jonathan Druart changed: What|Removed |Added Attachment #61927|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 62421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62421&action=edit Bug 17814: koha-plack --stop should make sure that Plack really stop koha-plack --stop doesn't ensure that Plack was really stopped before returning So in case that koha-plack --stop was quickly follows by koha-plack --start (e.g. logrotate), it could leave Plack in stop state. This is due to koha-plack --start think that Plack was already started, while it actually is being stopped. For me I think this is the cause why I got random Plack stop when logrotate is run. It should be similar to the case of Zebra in Bug #16885, and the solution might be the same: adding "--retry=TERM/30/KILL/5;" to start-stop-daemon command. TEST PLAN - 1) Login to staff client and do something that will hold connection for a long time, e.g. a batch import or a slow report. 2) sudo koha-plack --stop mykoha 3) ps aux | grep plack <-- a Plack process will still running work in 1) 4) wait for 1) to finish and all Plack processes exit 5) sudo koha-plack --start mykoha 6) apply the patch 7) repeat step 1)-2) 8) ps aux | grep plack <-- There should be no Plack process running now 9) Note that work in step 1) might get terminated midway. Since we force Plack to stop after some wait. Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339 Marc Véron changed: What|Removed |Added Attachment #62405|0 |1 is obsolete|| --- Comment #13 from Marc Véron --- Created attachment 62420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62420&action=edit Bug 18339: (followup) Remove warnings on adding a patron modification This patch removes warnings raised because hash values existence is not checked before comparing them. As the sub is deleting fields that are similar from the modification, I considered the following use cases - Both fields are defined, need to compare values, should delete if they match - One of the fields is defined, the other isn't, discrepancy, should not delete. - Both fields are not defined, they match, should delete. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339 Marc Véron changed: What|Removed |Added Attachment #62403|0 |1 is obsolete|| --- Comment #12 from Marc Véron --- Created attachment 62419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62419&action=edit Bug 18339: Remove ->opac_editable ->opac_display from Koha::Patron::Attribute Trying to simplify the implementation of 13757, I replaced some legacy code in favour of a Koha::Object-based implementation for the OPAC controller scripts. On doing so I went too far with this methods, as what was needed was a way to retrieve the type of the attribute and ask it about such properties. This patch removes those methods, its tests, and replaces its uses in the codebase like this: $attribute->opac_editable for $attribute->type->opac_editable To test: - Run $ prove t/db_dependent/Koha/Patron/Attributes.t => SUCCESS: Tests still pass - Try changing the opac_editable and opac_display properties and play in the OPAC with those attributes. Verify that everything works as expected. - Sign off :-D Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339
--- Comment #11 from Marc Véron ---
No more internal server error when editing in OPAC. I tested repeatable and non
repeatable text fields and a YES_NO field.
However I get an internal server error in staff client (approving). I can
trigger it by entering text with äöü etc.
E.g. with a text like 111ä222 I get the following in plack error log:
malformed UTF-8 character in JSON string, at character offset 14 (before
"\x{fffd}2","code":"T...") at /home/marc/koha/Koha/Patron/Modifications.pm line
100.
I can reproduce it with and without patches. Should that go to a separate Bug?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18448] Fix a few db_dependent tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18448 Jonathan Druart changed: What|Removed |Added Attachment #62398|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 62418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62418&action=edit Bug 18448: Fix a few db_dependent tests Tests in db_dependent may expect a Koha database, but should not rely on hardcoded categories, currencies, branch codes, etc. This patch fixes a bunch of those. But this is a continuous project. We also need QA to closely watch new edits. Accounts.t: hardcoded category PT replaced Acquisition/OrderFromSubscription.t: hardcoded USD Acquisition/StandingOrders.t: same ArticleRequests.t: create itemtype, branch and category for testing AuthorisedValues.t: remove $dbh, add two test branches AuthoritiesMarc.t: add hardcoded GEOGR_NAME authtype Bookseller.t: add test currency Koha.t: add test itemtype instead of hardcoded BK UsageStats.t: add test branch and category Test plan: Run the adjusted tests. Signed-off-by: Marcel de Rooy All tests successful (see comment #9) Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18448] Fix a few db_dependent tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18448 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 --- Comment #15 from Jonathan Druart --- (In reply to Marc Véron from comment #14) > (In reply to Jonathan Druart from comment #12) > > Created attachment 62400 [details] [review] [review] > > [ALTERNATIVE-PATCH] Bug 7550: SCO - Restrict access of patron's image > > > > With this patch if SelfCheckoutByLogin is set to 'username and > > password', only the logged in user will be able to see the image linked > > to his/her logged in account. > > If set to "barcode" we generate a token but it can be easily generated. > > You should add a warning in the about page if > > SelfCheckoutByLogin="barcode" and ShowPatronImageInWebBasedSelfCheck="Show". > > Hmm, my patch worked with a hash generated with the image file (as > recommended in comment #7), and it did not leave a security hole with > SelfCheckoutByLogin="barcode" Yes it does, on the same way as my patch. If you know the cardnumber (easy to guess) of someone you can access his^Ctheir image. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18433] Allow to select results to export in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Jonathan Druart changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #17 from Jonathan Druart --- I think I finally found what was wrong. Take a look at the 2 last patches. What you actually want is Koha::AuthorisedValues->get_description_by_koha_field. But you missed a TT plugin for an easy access. This method is cached and so certainly much powerful than what your were trying to do. Let me know if you have any questions. If you agree we will need to use this sub from the 2 other files, remove the tests and the new method you added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18433] Allow to select results to export in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #15 from Jonathan Druart --- Created attachment 62416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62416&action=edit Bug 18433: Add new subroutine GetDescriptionByKohaField to AuthorisedValues TT plugin To allow quick access to AV description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18433] Allow to select results to export in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #14 from Jonathan Druart --- Created attachment 62415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62415&action=edit Bug 18433: Use existing pattern for find_by_koha_field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18433] Allow to select results to export in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #16 from Jonathan Druart --- Created attachment 62417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62417&action=edit Bug 18433: Use the TT plugin for itemsearch_item.json.inc TODO: includes/catalogue/itemsearch_item.csv.inc modules/catalogue/itemsearch.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 --- Comment #14 from Marc Véron --- (In reply to Jonathan Druart from comment #12) > Created attachment 62400 [details] [review] > [ALTERNATIVE-PATCH] Bug 7550: SCO - Restrict access of patron's image > > With this patch if SelfCheckoutByLogin is set to 'username and > password', only the logged in user will be able to see the image linked > to his/her logged in account. > If set to "barcode" we generate a token but it can be easily generated. > You should add a warning in the about page if > SelfCheckoutByLogin="barcode" and ShowPatronImageInWebBasedSelfCheck="Show". Hmm, my patch worked with a hash generated with the image file (as recommended in comment #7), and it did not leave a security hole with SelfCheckoutByLogin="barcode" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #11 from Kyle M Hall --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372 Kyle M Hall changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Attachment #62073|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372 --- Comment #10 from Nick Clemens --- Created attachment 62414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62414&action=edit Bug 18372 - transits are not created at check in despite user responsing Yes to the prompt If the AutomaticItemReturn system preference is set to "Don't" and you check in an item which belongs to another library, a dialog will ask you if you want to transfer. This patch corrects a bug to enable the "Yes" buttons to work, triggering the transfer. To test, apply the patch and check in an item which belongs to another library. In the dialog, click the 'Yes' button and confirm that the item has been made 'in transit' to the correct library. Perform the same test with the 'Yes, print slip' and 'No' buttons and confirm they are working correctly. Since this patch changes the behavior of many other popups triggered from this template, test other operations which trigger a 'print slip' option like: - Checking in an item which is part of a rotating collection - Checking in an item which is on hold for a patron Signed-off-by: Colin Campbell Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18456] Update Italian installer sample files for 17.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18456 Marc Véron changed: What|Removed |Added Attachment #62363|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18456] Update Italian installer sample files for 17.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18456 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch Status|Needs Signoff |Signed Off --- Comment #4 from Marc Véron --- Forgot to mention that I tested on current master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18456] Update Italian installer sample files for 17.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18456 --- Comment #3 from Marc Véron --- Created attachment 62413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62413&action=edit Update Italian installer sample files for 17.05 Update and translate sample SQL file of the Italian installer. To test: - Start with an empty database - Install it-IT - Run the web installer in it-IT/Italian - Verify all files, especially sample notices, sample_frequencies, sample_numberpatterns load without any problems. https://bugs.koha-community.org/show_bug.cgi?id=18456 While applying I got a 3-way-merge. Verified in staff client places mentioned above, notices, frequencies, sample_numberpatterns, HSBND_FREQ Works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18459] Add the Koha::Item->biblioitem method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18459 Jonathan Druart changed: What|Removed |Added Attachment #62407|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 62412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62412&action=edit Bug 18459: Add the Koha::Item->biblioitem method Test plan: prove t/db_dependent/Koha/Items.t Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18459] Add the Koha::Item->biblioitem method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18459 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18460] Remove itemtype-related Serials.t warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18460 Jonathan Druart changed: What|Removed |Added Depends on||14598 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Jonathan Druart changed: What|Removed |Added Blocks||18460 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18460 [Bug 18460] Remove itemtype-related Serials.t warnings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18460] Remove itemtype-related Serials.t warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18460 Jonathan Druart changed: What|Removed |Added Attachment #62406|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 62411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62411&action=edit Bug 18460: Fix undefined itemtype warning in Serials.t This patch makes the test create an itemtype, and use it for the created item so there's no warning. To test: - Run: $ prove t/db_dependent/Serials.t => FAIL: item-level_itypes set but no itemtype set... warning raised - Apply the patch - Run: $ prove t/db_dependent/Serials.t => SUCCESS: Tests pass and no warning is raised - Sign off :-D Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18460] Remove itemtype-related Serials.t warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18460 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17502] Add type check to output_pref and use exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502 --- Comment #33 from Jonathan Druart --- I am expecting explosions with these patches but that will help to discover hidden bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17502] Add type check to output_pref and use exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502 Jonathan Druart changed: What|Removed |Added Attachment #62168|0 |1 is obsolete|| Attachment #62169|0 |1 is obsolete|| --- Comment #30 from Jonathan Druart --- Created attachment 62408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62408&action=edit Bug 17502: Add type check to output_pref This patch makes the following changes: [1] In Koha/DateUtils.pm, sub output_pref: Add a test if $dt is really a DateTime before calling method ymd. Preventing a crash like: Can't locate object method "ymd" via package "dateonly". See also BZ 17502/15822. [2] Adds a few unit tests in t/DateUtils.t. Test plan: [1] Run the adjusted unit test t/DateUtils.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17502] Add type check to output_pref and use exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17502] Add type check to output_pref and use exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502 --- Comment #31 from Jonathan Druart --- Created attachment 62409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62409&action=edit Bug 17502: Throw some exceptions in output_pref Test plan: Run the adjusted t/DateUtils.t Signed-off-by: Josef Moravec NOTE: This patch is amended in QA. The exceptions are moved from a separate module to the general section of Exceptions.pm. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17502] Add type check to output_pref and use exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502 --- Comment #32 from Jonathan Druart --- Created attachment 62410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62410&action=edit Bug 17502: Add info when throwing the exception Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18459] Add the Koha::Item->biblioitem method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18459 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18459] Add the Koha::Item->biblioitem method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18459 Marc Véron changed: What|Removed |Added Attachment #62387|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 62407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62407&action=edit Bug 18459: Add the Koha::Item->biblioitem method Test plan: prove t/db_dependent/Koha/Items.t Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
