[Koha-bugs] [Bug 18472] Add system preferences to manage online help system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 --- Comment #20 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #19) > I personally do not think it is a good idea, I'd like to get other QAers > point of view. At first glance, I would think so too. But I did not study all code changes. Marc: Could you convince the QA team why this is a good idea? What is the impact on the news module itself? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #6 from Josef Moravec --- Comment on attachment 62811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62811 Bug 18450 - Implemented check if either AllowRenewLimitOverride or AllowRenewalIfOtherItemsAvaliable were set to allow, so the user is only blocked if both of these sysprefs are set to 'Dont allow' Review of attachment 62811: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18450&attachment=62811) - ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt @@ +119,5 @@ > +name="override_limit" value="1" /> > +name="override_holds" value="1" /> > +class="approve"> Override and renew > + > +[% ELSIF > ((Koha.Preference('AllowRenewalLimitOverride')) && > !(Koha.Preference('AllowRenewalIfOtherItemsAvailable'))) %] wrong copy paste in AllowRenewalIfOtherItemsAvailable preference name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #83 from Marcel de Rooy --- (In reply to Philippe Audet-Fortin from comment #82) > Hi Marcel, I was wondering what you want to show in your first subparagraph, > because it seems normal to me that it will not work if there is no table in > front of the field. Koha need to know the table where the field come from. > (Sorry for my english :)) Hmm. Maybe a misunderstanding. Comment81 refers to some lines in the code including the comment "# Remove the table name if exists." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #31 from Katrin Fischer --- Patches eyeball well on first glance otherwise! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #30 from Katrin Fischer --- Starting to take a look at this (finally!). There are some complaints by the QA script: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude.inc OK forbidden patterns FAIL git manipulation The file has been added and deleted in the same patchset OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude3.inc OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template : filter not found FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt OK forbidden patterns OK git manipulation FAIL spelling seperate ==> separate OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt FAIL forbidden patterns forbidden pattern: tab char (line 337) OK git manipulation OK spelling OK tt_valid OK valid_template As there have been no sign-offs yet, sqashing the patches should usually be alright if you want to (for the remove/add complaint). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 Katrin Fischer changed: What|Removed |Added Attachment #62498|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 63046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63046&action=edit [SIGNED OFF] Bug 18465 - Patron card creator: Print on duplex card printer Card printers with duplex functionality need as input a PDF file where odd pages contain the front side and even pages the back side of the cards. This patch adds such functionality. To prepare test: - In Patron card creator > Templates, prepare a 1 up template (1 column / 1 row) that fits to a single card. Give it a name like 'Duplex card template' (Attention, Card with and Card height seem to have wrong labels, that will go to a separate bug). - In Patron card creator > Layouts create a layout for the front side and one for the back side. Give them names to easily remember (Card front layout, Card back layout) - Go to Patron card creator > Batches and test both layouts together with the 1 up template. Save and keepp both test files as reference. To test: - Apply patch. Restart memcached and plack. - Go to Patron card creator > Batches - Click "Export" for a batch - In the following screen, note the new field "Select a layout for the back side" with a hint what it is used for - Leave it on 'Back side layout not used', export and compare output with test ooutput from preparation. It should be the same - Select the layout you prepared for the back side. - Export - this file should contain 2 PDF pages per patron, one first with the front side, second with the back side. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 --- Comment #11 from Katrin Fischer --- Mine were not quite as pretty as yours - but it works really well! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #13 from David Cook --- (In reply to Jonathan Druart from comment #8) > I was not aware of this script and I think it does not make sense to have it. > I'd prefer to remove it than adding more code to the codebase to maintain it. > > Opinions? I was not aware of this script until recently, but I have been using it to double-check that I've set up the timezone for Koha correctly in Apache. I'm OK with removing the script overall, but could we add timezone information to the About page in the "Server information" tab? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 --- Comment #11 from David Cook --- (In reply to Marc Véron from comment #10) > Still valid? Not sure. I haven't looked in a while. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #36 from M. Tompsett --- I haven't tested it, but I think the find is a way of ensuring the member has been added. A cache flush? A pause? Remove it and test with a plack-based system, before deciding to remove it. Also, before the code was added and at the end means for debugging, I could assert that $borrower would be a valid patron. Which is conceptually beautiful. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #35 from M. Tompsett --- ARG! I really hate them constantly changing the interface. It makes it so much harder to help people set up. First you need to confirm the Google OAuth works normally: Go to https://console.developers.google.com/project Log in Click '+ Create Project' Type in a project name and click 'CREATE' -- the notification bell will highlight Select the creation notification with the project just created Click 'Go to APIs overview' Click 'Credentials' in the left panel Click the 'Create credentials' drop-down button Click 'OAuth client ID' Click 'Configure consent screen' Put it a meaningful string into the Product Name (e.g. South Pole Library Authentication) Fill in the other fields as desired (or not) Click 'Save' Click the 'Web application' radio button Change the 'AUTHORIZED JAVASCRIPT ORIGINS' to your OPACBaseURL. (http://localhost:8080) Change the 'AUTHORIZED REDIRECT URIS' to point to the new googleoauth2 script (http://localhost:8080/cgi-bin/koha/svc/auth/googleopenidconnect) Click 'Create' Copy and paste the 'Client ID' into the GoogleOAuth2ClientID system preference. Copy and paste the 'client secret' into the GoogleOAuth2ClientSecret system preference. Change the GoogleOpenIDConnect system preference to 'Use'. Click 'Save all Administration preferences' Click 'OK' to dismiss the client ID and client secret dialogue. In the OPAC, click 'Log in to your account'. -- You should get a confirmation request, if you are already logged in, OR a login screen if you are not. -- You need to have the primary email address set to one authenticated by Google in order to log in. -- OPACBaseURL system preference needs to be set as well. This confirms you have the Google Authentication set up. Make sure your google email is not associated with an account now, or you have a second account to test with that has no patron matching. Apply the patch Upgrade the database Make sure you set the three new system preferences: GoogleOpenIDConnectAutoRegister - Allow GoogleOpenIDConnectDefaultBranch - Any valid existing branchcode. GoogleOpenIDConnectDefaultCategory - Any valid existing patron category. Attempt to log in with a Google account not associated with a Koha account. -- should succeed Searching for patron in Staff client should show they are that branch and category. Run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #62504|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #41 from Alex Buckley --- Created attachment 63045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63045&action=edit Bug 17944 - Overridden Koha::Object->delete with Koha::ItemType->delete and implemented exception to be shown if the itemtype cannot be deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #62505|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #62503|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #62500|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #62502|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #62499|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Philippe Audet-Fortin changed: What|Removed |Added CC||philippe.audet-fortin@inlib ||ro.com --- Comment #82 from Philippe Audet-Fortin --- Hi Marcel, I was wondering what you want to show in your first subparagraph, because it seems normal to me that it will not work if there is no table in front of the field. Koha need to know the table where the field come from. (Sorry for my english :)) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Assignee|cnighswon...@foundations.ed |n...@bywatersolutions.com |u | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 --- Comment #1 from Nick Clemens --- Created attachment 63044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63044&action=edit Bug 18535 - Clicking 'edit printer profile' in label creator causes software error 1) Go to Tools > Label creator 2) If you don't have a printer profile defined, create one. 3) Go to manage > Printer profiles 4) Click the 'edit' button on any of the profiles. 5) INTERNAL SERVER ERROR! "Can't use string ("fields") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Creators/Lib.pm line 147" 6) Apply patch 7) Click the 'edit' button on any of the profiles. 8) Things work as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18472] Add system preferences to manage online help system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 Jonathan Druart changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl, ||n...@bywatersolutions.com, ||tomasco...@gmail.com --- Comment #19 from Jonathan Druart --- I personally do not think it is a good idea, I'd like to get other QAers point of view. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18472] Add system preferences to manage online help system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 --- Comment #18 from Marc Véron --- (In reply to Jonathan Druart from comment #17) > Could you explain why did you reuse the news system instead of creating a > new fresh module? Because the news module contains all the functionality needed, and users are used to it. I did not want to reinvent the wheel. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18535] New: Clicking 'edit printer profile' in label creator causes software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Bug ID: 18535 Summary: Clicking 'edit printer profile' in label creator causes software error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To re-create. 1) Go to Tools > Label creator 2) If you don't have a printer profile defined, create one. 3) Go to manage > Printer profiles 4) Click the 'edit' button on any of the profiles. This will cause a software error; the plack error log will show Can't use string ("fields") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Creators/Lib.pm line 147. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #34 from Jonathan Druart --- Can we get an updated test plan? It sounds like the Google APIs interface has changed. The last line you added to opac/svc/auth/googleopenidconnect (Koha::Patrons->find) is not necessary, $borrower is not used later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Jonathan Druart changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 --- Comment #1 from Nick Clemens --- Created attachment 63043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63043&action=edit Bug 18534 - When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl To recreate: 1 - Place a hold for pickup at Midway 2 - Enable independentbranches 3 - Login to staff interface as admin without superlibrarian status from a different branch 4 - View the holds for the title you placed a hold on 5 - The hold placed in step 1 should show a dropdown with current branch as pickup location, current branch is the only in that dropdown 6 - Verify it displays correctly for superlibrarian 7 - Apply patch 8 - The correct pickup location should show and not be editable 9 - Verify it is a dropdown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18534] New: When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 Bug ID: 18534 Summary: When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The pickup location pulldown is populated with only the users branch when IndependentBranches is enabled - if the actual pickup location is a different library you instead see the current library To recreate: 1 - Place a hold for pickup at Midway 2 - Enable independentbranches 3 - Login to staff interface as admin without superlibrarian status from a different branch 4 - View the holds for the title you placed a hold on 5 - The hold placed in step 1 should show a dropdown with current branch as pickup location, current branch is the only in that dropdown 6 - Verify it displays correctly for superlibrarian -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18472] Add system preferences to manage online help system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 --- Comment #17 from Jonathan Druart --- Could you explain why did you reuse the news system instead of creating a new fresh module? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Jonathan Druart changed: What|Removed |Added Version|3.20|unspecified CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #7 from Jonathan Druart --- Would not it make sense to add it everywhere? % git grep ', thanks' **/*.tt|cut -d':' -f1|uniq koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/printinvoice.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt It seems that occurrences in pay.tt are not relevant, we do not display payments in this table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 Jonathan Druart changed: What|Removed |Added Attachment #63001|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 63042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63042&action=edit Bug 18299 - Removed unused env_tz_test.pl based on user testing feedback Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 --- Comment #19 from Jonathan Druart --- (In reply to Jonathan Druart from comment #18) > Regarding the description of this bug we are expecting the Leader 9 for > UNIMARC records to be blank, does it make sense to set it in > SetMarcUnicodeFlag? I do not think it makes sense actually, must be done elsewhere. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18153] UNIMARC bib records exported with invalid 'a' char in label pos.9
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18153 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #7 from Jonathan Druart --- Must it be done when importing as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 --- Comment #18 from Jonathan Druart --- Paul, Stéphane, Regarding the description of this bug we are expecting the Leader 9 for UNIMARC records to be blank, does it make sense to set it in SetMarcUnicodeFlag? Let me know if you agree with the last patch, otherwise I will adapt the tests to make them pass without it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 --- Comment #17 from Jonathan Druart --- Created attachment 63041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63041&action=edit Bug 18152: Leader 9 for UNIMARC records must be blank -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 --- Comment #16 from Jonathan Druart --- Created attachment 63040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63040&action=edit Bug 18152: Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18533] New: MARC::Record->encoding does not handle UNIMARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18533 Bug ID: 18533 Summary: MARC::Record->encoding does not handle UNIMARC records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcha...@gmail.com Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 18152 Regarding bug 18152 MARC::Record->encoding should not be called directly from our codebase. C4::Charset::SetMarcUnicodeFlag should call MARC::Record->encoding for MARC21 and NORMARC but does the UNIMARC trick for UNIMARC records. It seems that MARC::Record->encoding calls should be replaced with C4::Charset::SetMarcUnicodeFlag everywhere. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 Jonathan Druart changed: What|Removed |Added Blocks||18533 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18533 [Bug 18533] MARC::Record->encoding does not handle UNIMARC records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Jonathan Druart changed: What|Removed |Added Summary|AUTO_RENEWALS should be a |AUTO_RENEWALS should be a |patron messaging|patron messaging preference |preferences | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #56 from Tomás Cohen Arazi --- Accountlines are tied to patrons. That means they might better be placed in /patrons/{patron_id}/accountlines. Is there a place in Koha where all accountlines are listed somehow that would require this kind of global endpoint? I don't see the use case for it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18518] The staff interface "blink" for different actions after upgrading to Firefox 53
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Philippe Audet-Fortin changed: What|Removed |Added Attachment #62927|0 |1 is obsolete|| --- Comment #8 from Philippe Audet-Fortin --- Created attachment 63039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63039&action=edit Bug 18518: Hide patron list dialog by default This patch hides the patron list dialog by default to prevent it to display shortly when koha/members/member.pl is called. There are more reasons for the blinking of the page, but at least the yellow patron list dialog does no longer display without having to. To test: - Slow down system by enabling syspref DumpTemplateVarsIntranet - Try to reproduce issue, see a yellow dialog come up for a very short time when member.pl is displayed (e.g. with a search) - Apply patch - Go to patron page - Try to reproduce. Page still blinks, but the dialog as one of the elements that produce bilnking does no longer show up - Verify that patron list functionality works as before (Select some patrons and add them to a patron list). Signed-off-by: paudet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Owen Leonard changed: What|Removed |Added Attachment #58651|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 63038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63038&action=edit Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking boxes in the "checkout settings" panel the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable OnSiteCheckouts and decreaseLoanHighHolds system preferences. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the label or checkbox for "Automatic renewal", "Don't decrease checkout length based on holds" and "On-site checkout" - Confirm that the focus has moved to the barcode field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Owen Leonard changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15705] Notify the user on auto renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #63 from Jonathan Druart --- Nick, I added a --send-notices flag to the script. I opened bug 18532, which may be sponsored soon, to tuned this option more granularly. Hope it makes sense to you to have this enhancement in as it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] New: AUTO_RENEWALS should be a patron messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Bug ID: 18532 Summary: AUTO_RENEWALS should be a patron messaging preferences Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Depends on: 15705 The AUTO_RENEWALS notices sent by the automatic_renewals.pl cronjob should be controlled and configurable at user level, like CHECKIN and CHECKOUT That way digest will be supported as well. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 [Bug 15705] Notify the user on auto renewing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15705] Notify the user on auto renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Jonathan Druart changed: What|Removed |Added Blocks||18532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 [Bug 18532] AUTO_RENEWALS should be a patron messaging preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15705] Notify the user on auto renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Jonathan Druart changed: What|Removed |Added Attachment #61498|0 |1 is obsolete|| Attachment #61500|0 |1 is obsolete|| --- Comment #61 from Jonathan Druart --- Created attachment 63036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63036&action=edit Bug 15705: DBIC Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15705] Notify the user on auto renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #62 from Jonathan Druart --- Created attachment 63037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63037&action=edit Bug 15705: Add --send-notices to the cronjob script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18512] GetAuthorisedValues.GetByCode Template plugin should return code ( not empty string) if value not found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 Jesse Maseto changed: What|Removed |Added CC||athiescha...@smac.edu --- Comment #8 from Jesse Maseto --- *** Bug 18180 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18180] Sort Field 2 Blank on Patron Details Page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18180 Jesse Maseto changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC||je...@bywatersolutions.com --- Comment #1 from Jesse Maseto --- *** This bug has been marked as a duplicate of bug 18512 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18415] Advanced Editor - Rancor - return focus to editor after successful macro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18415 Jonathan Druart changed: What|Removed |Added Attachment #62291|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 63035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63035&action=edit Bug 18415 - Advanced Editor - Rancor - return focus to editor after successful macro After running a macro we should return focus to the editor screen so editing can continue from keyboard To test: 1 - Create a macro 007=vd cvaizq 2 - Run it and note focus is not on editor 3 - Apply patch 4 - Reload page 5 - Run macro 6 - Note focus is returned to editor Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 --- Comment #15 from Jonathan Druart --- (In reply to stephane.delaune from comment #12) "MARC::Record does not handle UNIMARC records correctly" and "MARC::Record->encoding('utf-8') add 'a' char in the 9th label'pos, it's ok in MARC21 and NORMARC but not in UNIMARC" mean the same thing to me -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18415] Advanced Editor - Rancor - return focus to editor after successful macro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18415 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #50 from Josef Moravec --- Created attachment 63031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63031&action=edit [SIGNED-OFF] Bug 18137: (follow-up) Fix handling DBIx::Class::Exception messages - DBIx::Class::Exception should use ->{msg} Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #51 from Josef Moravec --- Created attachment 63032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63032&action=edit [SIGNED-OFF] Bug 18137: (QA-follow-up) Fix pod fail Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #49 from Josef Moravec --- Created attachment 63030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63030&action=edit [SIGNED-OFF] Bug 18137: Remove x-mojo-around-action Mojolicious::Plugin::OpenAPI does not support x-mojo-around action. This patch removes it from our specification document. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #52 from Josef Moravec --- Created attachment 63033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63033&action=edit [SIGNED-OFF] Bug 18137: (follow-up) Sort definitions.json Before this file grows, we should sort it alphabetically. To test: 1. prove t/db_dependent/api/v1 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #53 from Josef Moravec --- Created attachment 63034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63034&action=edit [SIGNED-OFF] Bug 18137: List Mojolicious::Plugin::OpenAPI and JSON::Validator as dependencies Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #48 from Josef Moravec --- Created attachment 63029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63029&action=edit [SIGNED-OFF] Bug 18137: Make /holds Mojolicious::Plugin::OpenAPI compatible Also - adding some missing and new response definitions into Swagger spec. - fixing failing tests due to Bug 17932's change of boolean values To test: 1. prove t/db_dependent/api/v1/holds.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #46 from Josef Moravec --- Created attachment 63027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63027&action=edit [SIGNED-OFF] Bug 18137: Make /patrons Mojolicious::Plugin::OpenAPI compatible Also: - adding some missing and new response definitions into Swagger spec. - fixing failing test due to Bug 17932's change of boolean values To test: 1. prove t/db_dependent/api/v1/patrons.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #47 from Josef Moravec --- Created attachment 63028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63028&action=edit [SIGNED-OFF] Bug 18137: Make /cities Mojolicious::Plugin::OpenAPI compatible Also: - adding some missing and new response definitions into Swagger spec. To test: 1. prove t/db_dependent/api/v1/cities.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #45 from Josef Moravec --- Created attachment 63026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63026&action=edit [SIGNED-OFF] Bug 18137: Migrate from Swagger2 to Mojolicious::Plugin::OpenAPI This patch migrates from Swagger2 to Mojolicious::Plugin::OpenAPI as Swagger2 is no longer actively maintained. This migration involves some minor changes to our Swagger specification documents and to controllers. Each operation is migrated in following patches separately. Please see Mojolicious::Plugin::OpenAPI and its tutorial for more documentation. The patch also refactors some API authentication -related code by taking advantage of Koha::Exceptions. Authentication is now handled via Mojolicious's "under->to" functionality. The actual authentication & authorization checks are moved to Koha::REST::V1::Auth. Added a HTTP 503 response for when database update is required, instead of returning an authentication failure as before. To test: 1. prove t/db_dependent/api/v1/auth.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Josef Moravec changed: What|Removed |Added Attachment #62781|0 |1 is obsolete|| Attachment #62782|0 |1 is obsolete|| Attachment #62783|0 |1 is obsolete|| Attachment #62784|0 |1 is obsolete|| Attachment #62785|0 |1 is obsolete|| Attachment #62786|0 |1 is obsolete|| Attachment #62787|0 |1 is obsolete|| Attachment #62788|0 |1 is obsolete|| Attachment #62789|0 |1 is obsolete|| Attachment #62816|0 |1 is obsolete|| --- Comment #44 from Josef Moravec --- Created attachment 63025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63025&action=edit [SIGNED-OFF] Bug 18137: Add useful Koha::Exceptions Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16606] Checkout settings dropdown should have a preference to stay open all the time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16606 --- Comment #6 from Marjorie Barry-Vila --- (In reply to Christopher Brannon from comment #0) > Not everyone is concerned with the additional space taken up with the new > Checkout settings. It would be helpful if these options could be set to > always show. > > For now I will use a jQuery to force it open, but a preference would be > preferable. No pun intended. > > Christopher Hi, Could you share your code JQuery? I did not find it on wiki. Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16606] Checkout settings dropdown should have a preference to stay open all the time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16606 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18531] REST api: Add an endpoint for use by GOBI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18531 Tomás Cohen Arazi changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18531] REST api: Add an endpoint for use by GOBI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18531 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18531] New: REST api: Add an endpoint for use by GOBI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18531 Bug ID: 18531 Summary: REST api: Add an endpoint for use by GOBI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org GOBI (formely YBP) is an aquisitions management system. It handles most of the acquisitions workflow, and traditionally generated MARC files to be included on the institution's library systems. Those files were usually served on an FTP server, for the institution to download and import on their ILS. GOBI implemented what they call GOBIapi, which is a simple workflow for them to directly inject that acquisitions information and resulting records through the use of webservices. In Koha, this means having an endpoint accepting GOBI order messages (in their documented XML format) and have it follow the internal Koha workflow for baskets: - Create a basket - Fill it with the record and budget information, etc - Close the basket and mark it as received. - Deal with the received MARC data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 Josef Moravec changed: What|Removed |Added Attachment #63018|0 |1 is obsolete|| --- Comment #2 from Josef Moravec --- Created attachment 63024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63024&action=edit [SIGNED-OFF] Bug 18529 - Template cleanup of patron clubs pages This patch addresses template issues with the newly-added patron clubs pages. - Move Clubs tab out of second position in Circulation page tabs. - Link patron name in enrollments list to the patron record - Make page titles on some pages more specific - Correct label "for" attributes so that it matches input id - Correst style of buttons: Buttons in tables must be "btn-xs," all Bootstrap buttons must have "btn-default." - Correct "Edit" icons: Should be "fa-pencil" This patch also revises the club template editing form to make it more consistent with similar interfaces in Koha and (hopefully) make it more clear. To test, apply the patch and test adding clubs and club templates and enrolling patrons in clubs via the staff client and OPAC. Confirm that everything looks and work okay. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Owen Leonard changed: What|Removed |Added Blocks||18530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530 [Bug 18530] Remove event attributes from patron clubs templates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18530] Remove event attributes from patron clubs templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530 Owen Leonard changed: What|Removed |Added Depends on||12461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008 Josef Moravec changed: What|Removed |Added Attachment #59769|0 |1 is obsolete|| --- Comment #4 from Josef Moravec --- Created attachment 63023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63023&action=edit Bug 18008: Make pagination generated in templates It generates pagination in bootstrap style (as bug 18005 also do) Modified pages: acqui/neworderbiblio.pl authorities/authorities-home.pl cataloguing/addbooks.pl cataloguing/value_builder/marc21_linking_section.pl cataloguing/value_builder/unimarc_field_210c.pl cataloguing/value_builder/unimarc_field_4XX.pl reports/guided_reports.pl reviews/reviewswaiting.pl tags/review.pl virtualshelves/shelves.pl Test plan: 0) Apply the patch 1) go through pages from the list above/use cataloguing plugins, and make the data to be big enough for pagination 2) confirm that pagination looks nice and behave correctly 3) git grep pagination_bar should return just C4/Output.pm and opac templates (I'll deal with it on another bugs) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086 Jonathan Druart changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #5 from Jonathan Druart --- Please answer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #49 from Jonathan Druart --- Created attachment 63022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63022&action=edit Bug 17942 [Follow-up] Update style of the web installer with Bootstrap 3 This patch makes changes following QA comments: - Login error messages now have a style - Select all/Select none links should now be translatable - Date format hint now correctly detects date format preference - Unused JS is removed from onboarding.js This patch also modifies the 'category_code_check' validation method to allow numbers as well as letters. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #48 from Jonathan Druart --- Created attachment 63021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63021&action=edit Bug 17942: Remove type for messages It it no longer in used by the templates. Also add the include files for step5 (if the circ rule is not inserted) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #47 from Jonathan Druart --- Created attachment 63020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63020&action=edit Bug 17942 - Add anti-clickjack code to installer doc head close Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Jonathan Druart changed: What|Removed |Added Attachment #62861|0 |1 is obsolete|| Attachment #62862|0 |1 is obsolete|| Attachment #63013|0 |1 is obsolete|| --- Comment #46 from Jonathan Druart --- Created attachment 63019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63019&action=edit Bug 17942 - Update style of the web installer with Bootstrap 3 This patch makes style and markup changes to the web installer and new onboarding tool (Bug 17855). - Markup has been corrected, improved, and in many places reindented. - Some page titles have been made more specific. - Some JavaScript and CSS have been moved to separate files. In the onboarding tool I have removed form validation from the markup and JavaScript in many cases where the requirements were not matched elsewhere in Koha. For instance, we shouldn't limit item type descriptions to only letters because the database doesn't require such a limit. To test, apply the patch and run the web installer with an empty database. Confirm that the installation process completes correctly and that each page looks good and works correctly. Works as advertised Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18098] Add an index with the count of not onloan items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18098] Add an index with the count of not onloan items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 --- Comment #6 from Marcel de Rooy --- Seems to work fine (MARC21), but we still need biblio-zebra-indexdefs.xsl for unimarc and normarc. Note that 'working fine' in my case included restarting zebra and indexer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18530] New: Remove event attributes from patron clubs templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530 Bug ID: 18530 Summary: Remove event attributes from patron clubs templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org The patron clubs templates add a lot of instances of "onclick," in violation of coding guidelines. https://wiki.koha-community.org/wiki/Coding_Guidelines#JS9:_Avoid_the_use_of_event_attributes_like_.22onclick.22_to_attach_events They should be removed in favor of defining events in JavaScript instead of markup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Owen Leonard changed: What|Removed |Added Blocks||18529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 [Bug 18529] Template cleanup of patron clubs pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 Owen Leonard changed: What|Removed |Added Depends on||12461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 --- Comment #1 from Owen Leonard --- Created attachment 63018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63018&action=edit Bug 18529 - Template cleanup of patron clubs pages This patch addresses template issues with the newly-added patron clubs pages. - Move Clubs tab out of second position in Circulation page tabs. - Link patron name in enrollments list to the patron record - Make page titles on some pages more specific - Correct label "for" attributes so that it matches input id - Correst style of buttons: Buttons in tables must be "btn-xs," all Bootstrap buttons must have "btn-default." - Correct "Edit" icons: Should be "fa-pencil" This patch also revises the club template editing form to make it more consistent with similar interfaces in Koha and (hopefully) make it more clear. To test, apply the patch and test adding clubs and club templates and enrolling patrons in clubs via the staff client and OPAC. Confirm that everything looks and work okay. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18094] Patron search filters are broken by searchable attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 --- Comment #14 from Jonathan Druart --- You need the 2 patches, not just the tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #73 from Alex Arnaud --- And note that CancelExpiredReserves is only caled by the script misc/cronjobs/holds/cancel_expired_holds.pl. Nowhere else if i'm not wrong. So if we remove the check of ExpireReservesMaxPickUpDelay from this sub, we get a kind of "force cancel reserves". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18094] Patron search filters are broken by searchable attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 --- Comment #13 from Mason James --- this patchset currently fails for me on 16.05.x $ prove t/db_dependent/Utils/Datatables_Members.t t/db_dependent/Utils/Datatables_Members.t .. 1/30 # Failed test ''Dupont' is contained in 2 surnames and a patron attribute. Patron attribute one should not be displayed if searching in specific fields (Bug 18094)' # at t/db_dependent/Utils/Datatables_Members.t line 407. # got: '2' # expected: '1' # Looks like you failed 1 test of 2. # Failed test 'ExtendedPatronAttributes' # at t/db_dependent/Utils/Datatables_Members.t line 409. # Looks like you failed 1 test of 30. t/db_dependent/Utils/Datatables_Members.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/30 subtests Test Summary Report --- t/db_dependent/Utils/Datatables_Members.t (Wstat: 256 Tests: 30 Failed: 1) Failed test: 30 Non-zero exit status: 1 Files=1, Tests=30, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.74 cusr 0.22 csys = 2.00 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/