[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649

--- Comment #24 from Marcel de Rooy  ---
I would opt for pushing the two patches as they were in PQA.
Not allowing the zero should be solved on another report.
Showing the zero here is fine with me.
No need to put this in NSO again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18754] New: Translatability: Get rid of exposed tt directives in opac-detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18754

Bug ID: 18754
   Summary: Translatability: Get rid of exposed tt directives in
opac-detail.tt
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

The file opac-detail.tt exposes a lot of template directives to translation
where translators should not be confronted with.

Some examples from po file are:

$[% SUBFIELD.code %] [% SUBFIELD.value %]

%s [%% INCLUDE \"openlibrary-readapi.inc\" bib = { normalized_isbn => "
"normalized_isbn, lccn => lccn, normalized_oclc => normalized_oclc } %%]

See: [% IF ( nextTitle ) %][% nextTitle |html %][% ELSE %]next biblio[% END "
"%]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18748] Noisy t/db_dependent/AuthorisedValues.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748

Lee Jamison  changed:

   What|Removed |Added

 CC||ldjami...@marywood.edu

--- Comment #2 from Lee Jamison  ---
I ran 'prove t/db_dependent/AuthorisedValues.t' however I did not encounter any
noise. For me, the test was successful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18741] Web installer broken ? default data won't load

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18741

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

--- Comment #27 from Srdjan Jankovic  ---
Heh, 5+ years ago when I created it there was no DBIx...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #26 from M. Tompsett  ---
I'm going to be picky about the License. The DBIx vs DBI suggestions probably
could slide, though QA might fault you. Also, rather than assume the DB's have
category codes and branches, consider the use of TestBuilder.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

--- Comment #25 from M. Tompsett  ---
Comment on attachment 60539
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60539
bug_7520 Added Meta handler to API v1 for metadata lists

Review of attachment 60539:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=7520=60539)
-

::: Koha/REST/V1/Meta.pm
@@ +12,5 @@
> +# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License along
> +# with Koha; if not, write to the Free Software Foundation, Inc.,
> +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

Since this is new, please use
https://wiki.koha-community.org/wiki/Coding_Guidelines#Licence

::: t/db_dependent/api/v1/meta.t
@@ +12,5 @@
> +# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License along
> +# with Koha; if not, write to the Free Software Foundation, Inc.,
> +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

Since this is new, please use
https://wiki.koha-community.org/wiki/Coding_Guidelines#Licence

@@ +32,5 @@
> +my $builder = t::lib::TestBuilder->new();
> +
> +my $dbh = C4::Context->dbh;
> +$dbh->{AutoCommit} = 0;
> +$dbh->{RaiseError} = 1;

This isn't necessary, since you can do it with the schema. No sense switching
between DBI and DBIx ways of doing things. It gets ugly if they conflict.

@@ +37,5 @@
> +
> +my $t = Test::Mojo->new('Koha::REST::V1');
> +
> +my $categorycode = 
> Koha::Database->new()->schema()->resultset('Category')->first()->categorycode();
> +my $branchcode = 
> Koha::Database->new()->schema()->resultset('Branch')->first()->branchcode();

my $schema = Koha::Database->new()->schema();
$schema->storage->txn_begin();
Then use $schema for the categorycode and branchcode.

@@ +77,5 @@
> +  ->json_has('/types/0/code')
> +  ->json_has('/types/0/description')
> +  ->json_has('/types/0/imageurl');
> +
> +$dbh->rollback;

$schema->storage->txn_rollback();

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

M. Tompsett  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

M. Tompsett  changed:

   What|Removed |Added

  Attachment #61196|0   |1
is obsolete||

--- Comment #8 from M. Tompsett  ---
Created attachment 64097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64097=edit
[SIGNED-OFF] Bug 18292 - t/db_dependent/Circulation.t doesn't need to return 1;

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #64071|0   |1
is obsolete||

--- Comment #24 from Srdjan Jankovic  ---
Created attachment 64096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64096=edit
Bug 17602 Add Oneclickdigital integration to Koha

Add OneClickdigital to the users page in the public interface

To Test:
1/ Apply all 3 patches
2/ Set the sysprefs to valid values (you will need a test account with
Oneclickdigital)
3/ Try a search
4/ Login to the OPAC, try to place a hold, or check an item out
5/ Check the opac-user page, see if your items are showing on the
oneclickdigital tab

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #64070|0   |1
is obsolete||

--- Comment #23 from Srdjan Jankovic  ---
Created attachment 64095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64095=edit
Bug 17602 Add OneClickDigital Integration to Koha

Koha::ExternalContent::OneClickDigital - a wrapper around
WebService::ILS::OneClickDigital::PartnerPatron

OneClickDigital* sysprefs

Nothing functional to test with this patch yet.
But you can run the tests that come with it

 t/db_dependent/Koha_ExternalContent_OneClickDigital.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

--- Comment #6 from Aleisha Amohia  ---
Created attachment 64094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64094=edit
Bug 3137: [FOLLOW-UP] Remove checkboxes, add collapsing sections

This patch removes the checkboxes from my previous patch and adds
collapsing/uncollapsing sections.

Follow the above test plan until step 6. The fields selected in
HideFieldsAddPatronForm will still be hidden, but can now be shown and
collapsed again (as well as all other sections) much more easily and
without scrolling.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18753] t/00-testcritic.t fails Perl::Critic on test 221

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18753] t/00-testcritic.t fails Perl::Critic on test 221

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64090|0   |1
is obsolete||

--- Comment #5 from M. Tompsett  ---
Created attachment 64093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64093=edit
Bug 18753 - t/00-testcritic fails Perl::Critic

Bug Description:
When performing a unit test on t/00-testcritic.t with the command
'prove t/00-testcritic.t' test 221 fails Perl::Critic with

not ok 221 - Test::Perl::Critic for "reserve/request.pl"
   Failed test 'Test::Perl::Critic for "reserve/request.pl"'
   at /usr/share/perl5/Test/Perl/Critic.pm line 110.

Perl::Critic found these violations in "reserve/request.pl":
"$itemnumbers_of_biblioitem" is declared but not used at
line 314, column 5. Unused variables clutter code and make it
harder to read  (Severity: 3)

Cause of bug:
The variable $itemnumbers_of_biblioitem is declared but never used
in reserve/request.pl which causes the Perl::Critic violation.

Patch Description:
This patch removes the variable $itemnumbers_of_biblioitem from
reserve/request.pl in order to satisfy Perl::Critic. The variable
$itemnumbers_of_biblioitem is never used anywhere in
reserve/request.pl other than its declaration so it should not
cause any undesired effects.

Test Plan:
1) Drop into koha-shell and run the command 'prove t/00-testcritic.t'.
2) Test 221 fails.
3) Apply the patch.
4) Re-run 'prove t/00-testcritic.t'.
5) All of the tests pass now.
6) Quit out of koha-shell.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18753] t/00-testcritic.t fails Perl::Critic on test 221

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64090|1   |0
is obsolete||

--- Comment #4 from M. Tompsett  ---
Comment on attachment 64090
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64090
Bug 18753 - t/00-testcritic fails Perl::Critic

There actually is a hash declaration version earlier! DOH! This is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18753] t/00-testcritic.t fails Perl::Critic on test 221

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64092|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18753] t/00-testcritic.t fails Perl::Critic on test 221

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753

M. Tompsett  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18753] t/00-testcritic.t fails Perl::Critic on test 221

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64090|0   |1
is obsolete||

--- Comment #3 from M. Tompsett  ---
Created attachment 64092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64092=edit
Bug 18753: t/00-testcritic.t fails

TEST PLAN
-
$ export TEST_QA=1
$ sudo apt-get install libtest-perl-critic-perl
$ prove t/00-testcritic.t
-- test 221 will fail
apply patch
$ prove t/00-testcritic.t
-- all tests will pass

NOTE: Obsoleted Lee's patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18753] t/00-testcritic.t fails Perl::Critic on test 221

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |In Discussion

--- Comment #2 from M. Tompsett  ---
I think this is the wrong solution. The problem is that variable is used as a
hash elsewhere. I think the problem is % vs $ not the variable name. Providing
counter-patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18746] Text_CSV_Various.t parse failure

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746

--- Comment #2 from M. Tompsett  ---
Created attachment 64091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64091=edit
Bug 18746: Text_CSV_Various parse failures

While it might be an idea to just delete it,
this patch attempts to catch everything and make it
clear that Text::CSV::Unicode (binary) is the parser
that should be used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18746] Text_CSV_Various.t parse failure

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746

M. Tompsett  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18741] Web installer broken ? default data won't load

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18741

Jonathan Druart  changed:

   What|Removed |Added

   Severity|major   |critical

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18753] t/00-testcritic.t fails Perl::Critic on test 221

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753

--- Comment #1 from Lee Jamison  ---
Created attachment 64090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64090=edit
Bug 18753 - t/00-testcritic fails Perl::Critic

Bug Description:
When performing a unit test on t/00-testcritic.t with the command
'prove t/00-testcritic.t' test 221 fails Perl::Critic with

not ok 221 - Test::Perl::Critic for "reserve/request.pl"
   Failed test 'Test::Perl::Critic for "reserve/request.pl"'
   at /usr/share/perl5/Test/Perl/Critic.pm line 110.

Perl::Critic found these violations in "reserve/request.pl":
"$itemnumbers_of_biblioitem" is declared but not used at
line 314, column 5. Unused variables clutter code and make it
harder to read  (Severity: 3)

Cause of bug:
The variable $itemnumbers_of_biblioitem is declared but never used
in reserve/request.pl which causes the Perl::Critic violation.

Patch Description:
This patch removes the variable $itemnumbers_of_biblioitem from
reserve/request.pl in order to satisfy Perl::Critic. The variable
$itemnumbers_of_biblioitem is never used anywhere in
reserve/request.pl other than its declaration so it should not
cause any undesired effects.

Test Plan:
1) Drop into koha-shell and run the command 'prove t/00-testcritic.t'.
2) Test 221 fails.
3) Apply the patch.
4) Re-run 'prove t/00-testcritic.t'.
5) All of the tests pass now.
6) Quit out of koha-shell.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18753] t/00-testcritic.t fails Perl::Critic on test 221

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753

Lee Jamison  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #64088|0   |1
is obsolete||

--- Comment #78 from Philippe Audet-Fortin  
---
Created attachment 64089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64089=edit
Bug 11317 - Update the link under reports

Signed-off-by: Paudet 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #77 from Philippe Audet-Fortin  
---
Created attachment 64088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64088=edit
Bug 11317 - Update the link under reports

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9188] Remove 'debug' information from patron statistics

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188

--- Comment #10 from M. Tompsett  ---
P.S. This does NOT fix the row/column not fully selected problem, as that is
beyond scope.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9188] Remove 'debug' information from patron statistics

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188

--- Comment #9 from M. Tompsett  ---
If you believe the counter patch is good, obsolete the first patch and sign off
the second. If you believe there is need for more discussion, discuss away. Do
not apply both patches, just one or the other.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9188] Remove 'debug' information from patron statistics

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188

--- Comment #8 from M. Tompsett  ---
Created attachment 64087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64087=edit
Bug 9188: counter patch -- just meaningful filter information

TEST PLAN
-
run patron statistics without filtering
-- notice lots of text at top.
run patron statistics with filtering
-- notice lots of text at top.
apply patch
run it without and without filtering
-- amount of text should be small or none and be related to the filtering
selected.
run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18753] t/00-testcritic.t fails Perl::Critic on test 221

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753

Lee Jamison  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|ch...@bigballofwax.co.nz|ldjami...@marywood.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18753] New: t/00-testcritic.t fails Perl::Critic on test 221

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753

Bug ID: 18753
   Summary: t/00-testcritic.t fails Perl::Critic on test 221
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: ldjami...@marywood.edu
QA Contact: gmcha...@gmail.com

Unit Test t/00-testcritic.t fails to pass Perl::Critic on Test 221.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9188] Remove 'debug' information from patron statistics

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |In Discussion

--- Comment #7 from M. Tompsett  ---
I agree the top part is messy. However, I believe the things which are not
filtered expressly don't need to be listed.

For example, I chose a particular category code and branch code, and there
would have been no way to know the branch code without the mess at the top. And
yes, it was just a single number.

I agree the Query parts are rather pointless.

I think if you choose a row and column, there is no need to display a value for
either the row or column unless it is filtered to that value. This means there
should only be two lines at most at the top.

As such, I don't think this patch is the correct way to do it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729

--- Comment #2 from Kyle M Hall  ---
(In reply to Tomás Cohen Arazi from comment #1)
> (In reply to Kyle M Hall from comment #0)
> > This is do to the fact that on those two pages the API is used and it used
> > the PUT for hold to update all hold fields, which requires this permission.
> > Another endpoint for updating only the pickup location should be added that
> > does not require the "modify_holds_priority" permission.
> 
> Kyle, could you specify what exact permission should be needed?

A permission shouldn't be needed, as that is not needed to set the pickup
branch on any of the other pages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16437] Automatic item modifications by age needs prettying

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

--- Comment #15 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #14)
> (In reply to Jonathan Druart from comment #4)
> > 1/ The age field is not mandatory
> > 2/ The right member of the substitutions is not mandatory (you could empty
> > it)
> 
> I think that I have missed to check these 2 remarks before passing it.
> The age field is not mandatory (and should not) as well as the substitutions.

See bug 18752.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18752] New: Automatic item modifications by age should allow 'blank' values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18752

Bug ID: 18752
   Summary: Automatic item modifications by age should allow
'blank' values
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Per comment 14 on bug 16437 the right side of the editor should not require a
vlue - with YAML we could supply a blank here and we should be bale to again

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18752] Automatic item modifications by age should allow 'blank' values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18752

Nick Clemens  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |oleon...@myacpl.org
 Depends on||16437


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437
[Bug 16437] Automatic item modifications by age needs prettying
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16437] Automatic item modifications by age needs prettying

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

Nick Clemens  changed:

   What|Removed |Added

 Blocks||18752


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18752
[Bug 18752] Automatic item modifications by age should allow 'blank' values
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

--- Comment #7 from M. Tompsett  ---
(In reply to M. Tompsett from comment #5)
> Ryan Higgins

P.P.S. 10ish years ago. I suspect all of these are cut and paste from early in
the project.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

--- Comment #6 from M. Tompsett  ---
(In reply to Olli-Antti Kivilahti from comment #4)
> This patch is just cosmetic and seems to have no impact on test results.

Actually, while generally true, I think a microscopic time gain would happen if
all of them were fixed. 1-2 less lines for 127ish out of 1000+ tests to load.
Who knows if any of them trigger paging in the OS while running. ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18749] xt/sample notices fails with "No sample notice to delete"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749

--- Comment #1 from Lee Jamison  ---
Created attachment 64086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64086=edit
Bug 18749 - xt/sample_notices.t fails

Bug Description:
When performing a unit test on xt/sample_notices.t with the command
'prove xt/sample_notices.t' 11 tests fail with the error message
"No sample notice to delete".

Cause of bug:
The failures are caused by an incorrect file path on Line 25 of
xt/sample_notices.t.

Patch Description:
This patch corrects the failures by changing $base_notices_file from
"en/default/sample_notices.sql" to "en/mandatory/sample_notices.sql"

Test Plan:
1) Drop into koha-shell and run the command 'prove xt/sample_notices.'
2) 11 unit tests fail.
3) Apply the patch.
4) Re-run 'prove xt/sample_notices.t'
5) All of the tests pass now.
6) Quit out of koha-shell

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10132] MarcOrgCode would be useful on branch level

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10132

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #2 from Tomás Cohen Arazi  ---
*** Bug 18751 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18751] Make it possible to specify a MARCOrgCode per branch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18751

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Tomás Cohen Arazi  ---
I noticed this was already requested, but mistakenly created the bug by
pressing  he.

*** This bug has been marked as a duplicate of bug 10132 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18749] xt/sample notices fails with "No sample notice to delete"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749

Lee Jamison  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #5 from M. Tompsett  ---
(In reply to Marc Véron from comment #3)
> What about the tons of *.t files with 1; as last line?
> 
> git grep '^1;' -- *.t

Comparing
git grep '^1;' -- *.t | wc
with
git grep -- *.t | wc

I believe 'tons' is an exaggeration. :)
This is a small patch. It doesn't hurt.

P.S.

for i in `git grep -l '^1;' -- *.t`; do git blame $i | tail -1 | cut -f2 -d'('
| cut -f1 -d2 | sed -e "s#\s*\$##g"; done | sort -u
Alex Sassmannshausen
A. Sassmannshausen
Charles Farmer
Emmanuele Somma
Galen Charlton
Jacek Ablewicz
Jared Camins-Esakov
Jonathan Druart
Kyle M Hall
Lari Taskula
Marcel de Rooy
Martin Renvoize
Paul Poulain
Ryan Higgins
Tomás Cohen Arazi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18751] New: Make it possible to specify a MARCOrgCode per branch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18751

Bug ID: 18751
   Summary: Make it possible to specify a MARCOrgCode per branch
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18750] t/db_dependent/Circulation/Branch.t fails.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18750

--- Comment #1 from M. Tompsett  ---
Created attachment 64085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64085=edit
Bug 18750: t/db_dependent/Circulation/Branch.t fails

TEST PLAN
-
prove -v t/db_dependent/Circulation/Branch.t
-- nice kaboom
apply patch
prove -v t/db_dependent/Circulation/Branch.t
-- everything passes
run koha qa test tools

BIG DISCLAIMER EXPLAINING IN DISCUSSION STATUS:
Look for 'WrongBranch' vs 'NeedsTransfer' logic elsewhere
I have not spent time doing this, which is why this
is 'In Discussion'. If it is fully confirmed that it does
not break anywhere else, then and only then feel free to
sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18750] t/db_dependent/Circulation/Branch.t fails.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18750

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18750] New: t/db_dependent/Circulation/Branch.t fails.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18750

Bug ID: 18750
   Summary: t/db_dependent/Circulation/Branch.t fails.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: gmcha...@gmail.com

prove t/db_dependent/Circulation/Branch.t fails test 12
not ok 12 - AddReturn respects default return policy - return to homebranch

In C4::Circulation, the CanBookBeReturned returns 0 for the wrong branch, but
never tests if it is returnable for the right branch. Adding in logic triggers
the NeedsTransfer else case near the end of the AddReturn function. It is
unclear what else might break as a side-effect of this patch method.

I will put this into Discussion, unless someone else can verify this is the
correct way to fix the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18749] xt/sample notices fails with "No sample notice to delete"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749

Lee Jamison  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|ch...@bigballofwax.co.nz|ldjami...@marywood.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18749] New: xt/sample notices fails with "No sample notice to delete"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749

Bug ID: 18749
   Summary: xt/sample notices fails with "No sample notice to
delete"
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: ldjami...@marywood.edu
QA Contact: gmcha...@gmail.com

Testing xt/sample_notices.t results in 11 test failures of "No sample notice to
delete".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18748] Noisy t/db_dependent/AuthorisedValues.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748

--- Comment #1 from M. Tompsett  ---
Created attachment 64084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64084=edit
Bug 18748: Noisy t/db_dependent/AuthorisedValues.t

This noise is from a failure. This patch expands the delete
regardless of framework.

TEST PLAN
-
prove t/db_dependent/AuthorisedValues.t
-- should have ugly message like in comment #0
apply patch
prove t/db_dependent/AuthorisedValues.t
-- should be green
run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18748] Noisy t/db_dependent/AuthorisedValues.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748

M. Tompsett  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17249] Koha:: AuthorisedValues - Remove GetKohaAuthorisedValuesFromField

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18748

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18748] Noisy t/db_dependent/AuthorisedValues.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17249

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18748] Noisy t/db_dependent/AuthorisedValues.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18748] New: Noisy t/db_dependent/AuthorisedValues.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748

Bug ID: 18748
   Summary: Noisy t/db_dependent/AuthorisedValues.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: gmcha...@gmail.com

prove t/db_dependent/AuthorisedValues.t

DBD::mysql::st execute failed: Duplicate entry 'ACQ-952-c' for key 'PRIMARY'
[for Statement "INSERT INTO `marc_subfield_structure` ( `authorised_value`,
`frameworkcode`, `kohafield`, `tagfield`, `tagsubfield`) VALUES ( ?, ?, ?, ?, ?
)" with ParamValues: 0='LOC', 1='ACQ', 2='items.location', 3=952, 4='c'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry 'ACQ-952-c' for key
'PRIMARY' at /home/mtompset/kohaclone/Koha/Object.pm line 121
# Child (search_by_*_field + find_by_koha_field + get_description) exited
without calling finalize()
not ok 15 - search_by_*_field + find_by_koha_field + get_description

Seems that bug 17249 adds both a 952$c for the '' and 'ACQ' framework, but the
deletes above only delete the '' framework one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #145 from Marc Véron  ---
For the records (from Bug 18734):
- Export to CSV leads to an Internal Server error, see Bug 18734
- It can be fixed by changing line 174 from exit(1); to exit(0);
  But then a new issue appears: The export has an empty line above the header
line, and the header line is mixed with and without double quotes:

mfirstname;card
number;firstname;branchname;date;accounttype;amount;title;barcode;"itype"

Noting it here to make the original authors of this feature aware.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18734] Internal server error in cash_register_stats.pl when exporting to file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734

--- Comment #1 from Marc Véron  ---
The internal server error can be fixed by changing line 174 from exit(1); to
exit(0);

But then an new issue appears: The export has an empty line above the header
line, and the header line is mixed with and without double quotes:

mfirstname;card
number;firstname;branchname;date;accounttype;amount;title;barcode;"itype"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649

--- Comment #23 from Marc Véron  ---
Where do we go from here?

- The original aim of this bug is not to expose the tt directive to translators
(without changing the original behaviour). It is kind of string patch.

- Can we agree to let this patch do what it does and move the 0-discussion to a
new bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18746] Text_CSV_Various.t parse failure

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18746] Text_CSV_Various.t parse failure

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
It seems that the failures are expected.
I'd suggest to remove this file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649

--- Comment #22 from Jonathan Druart  
---
It is wrong to store 0 and it is wrong to display an empty string when 0 is
stored.
I did not say your last patch modified that, just that it should not be changed
here.
I was more answering to Marcel than commenting your patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18747] New: Select All in Add Patron Option in Patron Lists only selects the first 20 entries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747

Bug ID: 18747
   Summary: Select All in Add Patron Option in Patron Lists only
selects the first 20 entries
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ka...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Select all only selects the first 20 records in the Add Patrons option of
Patron Lists, even if you change the view to show 50, 100, or all options. The
expected behavior is that Select All would select all the options.

To recreate this issue, go to Patrons -> Patron Lists -> Select a patron list
-> Select Add Patrons in the Action button menu. Next, select 50, 100 or All
entries to show. Then, click on Select All. Only the first 20 entries are
selected, not all of the entries on the screen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18746] New: Text_CSV_Various.t parse failure

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746

Bug ID: 18746
   Summary: Text_CSV_Various.t parse failure
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: ldjami...@marywood.edu
QA Contact: gmcha...@gmail.com

Unit Test command 'prove -v xt/author/Text_CSV_Various.t' fails even with
prerequisite modules installed

According to the Koha Wiki signoff documentation, in order for 'prove xt/' to
pass, the following modules must be installed:

Test::Pod;
Test::Pod::Spelling
Text::CSV::Unicode

however, even with these modules installed, running the prove command on
Text_CSV_Various.t exits with the following outputs:


not ok 10 - parse (Text::CSV)
not ok 13 - parse (Text::CSV::Unicode)
not ok 16 - parse (Text::CSV_XS)
not ok 19 - parse (Text::CSV)
not ok 22 - parse (Text::CSV::Unicode)
not ok 25 - parse (Text::CSV_XS)
ok 26 - parse (Text::CSV_XS (binary))
ok 27 - Number of fields (6 of 6)
field 1: field1
field 2: second field
field 3: field3
field 4: do_we_have_a_e_problem? (the _e_ appears to have a dot over it
which appears - after researching - to be the 9th letter of the Lithuanian
alphabet)
field 5:  f!fth field
field 6: lastfield

# For each of the above "not ok" and "ok" failures, it prints the following
message:
Failed test 'parse (Module::Name)'
at xt/author/Text_CSV_Various.t line 57.
Wide character in print at xt/author/Text_CSV_Various.t line 63.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649

--- Comment #21 from Marc Véron  ---
(In reply to Jonathan Druart from comment #20)
> Sounds like there is something wrong with the "0", but if it's a bug we must
> fix it somewhere else.

I do not think that there is anything wrong with enrolmentperiod = 0, it is
simply not displayed if it is 0. That's the original behaviour, this patch does
not change it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18737] Noisy t/db_dependent/00-strict.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18737

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from M. Tompsett  ---
My debian/scripts directory did not match a clean clone. This meant there was a
directory plack which was out of date and triggering issues.

Using git ls-files and diff with a file . -type f, I operated, re-ran, and this
is a non-issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745

--- Comment #1 from Julian Maurice  ---
Created attachment 64083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64083=edit
Bug 18745 - Serial claims: save supplier info on serial-level

This allows to change the subscription's supplier while keeping the info
of supplier for previous serials, which allows to claim late/missing
serials to the right supplier

Test plan:
1. Create 2 suppliers, S1 and S2
2. Create a new subscription with S1
3. Generate some late/missing serials
4. Change supplier to S2
5. Generate some more late/missing serials
6. Go to /cgi-bin/koha/serials/claims.pl and see you have late/missing
issues for both suppliers
7. Check that you have the expected issues for each supplier
8. prove t/db_dependent/Serials/Claims.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18745] New: Serial claims: save supplier info on serial-level

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745

Bug ID: 18745
   Summary: Serial claims: save supplier info on serial-level
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15644] City dropdown default selection when modifying a patron matches only on city

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15644

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #1 from Kyle M Hall  ---
*** Bug 18744 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15644] City dropdown default selection when modifying a patron matches only on city

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15644

--- Comment #2 from Kyle M Hall  ---
Created attachment 64082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64082=edit
Example

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18744] City selector may select wrong option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18744

Kyle M Hall  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Kyle M Hall  ---


*** This bug has been marked as a duplicate of bug 15644 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18744] New: City selector may select wrong option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18744

Bug ID: 18744
   Summary: City selector may select wrong option
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The select_city select in the patron editor ( code in
member-main-address-style-us.inc ) will select the wrong option of there are
multiple options with the same city but different zipcodes. For example, let's
say a city has 3 zip codes 16001, 16002, and 16003. If I live in 16003, the
chooser will show and have selected the 16001 zip code. This is because the
"selected" modifier is set for each option if just the city is a match,
ignoring the zipcode, state and country.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #7 from Jonathan Druart  
---
Ha yes, you might be right.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729

--- Comment #1 from Tomás Cohen Arazi  ---
(In reply to Kyle M Hall from comment #0)
> This is do to the fact that on those two pages the API is used and it used
> the PUT for hold to update all hold fields, which requires this permission.
> Another endpoint for updating only the pickup location should be added that
> does not require the "modify_holds_priority" permission.

Kyle, could you specify what exact permission should be needed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] New: Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Bug ID: 18743
   Summary: Filter suggestion lists correctly for
IndependentBranches
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: severine.que...@bulac.fr
QA Contact: testo...@bugs.koha-community.org

There should be an automatic filter on current site when working on the
suggestion list ansd using the syspref IndependentBranches.
The filter in the last menu "Acquisition information" doesn't work, and the
first option "Organize by" only sort them in the same tab.

It created a display bug when a librarian from the A library accepted/refused 2
suggestions for the B library and tried to change the site : these 2
suggestions now appear on the "OPAC Purchase suggestions" when there is no user
logged.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18742] Circulation statistics wizard no longer exports the total row

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18742

--- Comment #1 from Nick Clemens  ---
Created attachment 64081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64081=edit
Bug 18742 - Circulation statistics wizard no longer exports the total row

To test:
Run the circulation wizard
Export to csv
Note there is no total row
Apply patch
Export to csv
Total row totally there!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18742] Circulation statistics wizard no longer exports the total row

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18742

Nick Clemens  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7679] Add new filters to circulation statistics wizard

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

Nick Clemens  changed:

   What|Removed |Added

 Blocks||18742


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18742
[Bug 18742] Circulation statistics wizard no longer exports the total row
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18742] Circulation statistics wizard no longer exports the total row

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18742

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 Depends on||7679
   Patch complexity|--- |Trivial patch


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679
[Bug 7679] Add new filters to circulation statistics wizard
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18742] New: Circulation statistics wizard no longer exports the total row

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18742

Bug ID: 18742
   Summary: Circulation statistics wizard no longer exports the
total row
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

It seems like a few lines were lost from issues-stats.pl in bug 7679:

# footer
print "TOTAL";
$cols = @$results[0]->{loopfooter};
   print map {$sep.$_->{totalcol}} @$cols;
print $sep.@$results[0]->{total};

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18296] C4::Items - Remove GetItemInfosOf

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18296

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #11 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18741] Web installer broken ? default data won't load

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18741

Jonathan Druart  changed:

   What|Removed |Added

Version|17.05   |master
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649

--- Comment #20 from Jonathan Druart  
---
Sounds like there is something wrong with the "0", but if it's a bug we must
fix it somewhere else.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13311] NewItemsDefaultLocation preference should not populate items.permanent_location

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13311

Baptiste  changed:

   What|Removed |Added

 CC||baptiste.wojtkowski@biblibr
   ||e.com

--- Comment #1 from Baptiste  ---
Could not reproduce on master, is this problem still existing ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16899] Add ability to disallow overpayments via SIP

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #61379|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 64080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64080=edit
Bug 16899 - Add ability to disallow overpayments

Some SIP services ( such as Comprise ) require that an attempt at
over-paying a patron's account via SIP2 should fail, rather than create
a credit on the account. We should make this a configurable option on a
per-login basis in the SIP2 config file.

Test Plan:
1) Apply this patch
2) Enable the new parameter
   disallow_overpayment="1"
   for the login to be used in this test.
3) Restart your SIP server
4) Create or find a patron with fines
5) Attempt to send a payment via SIP for more than what the
   patron's balance is
6) Note the response indicates a payment failure
7) Attempt to send a payment via SIP for the account balance or
   less
8) Note the response indicates the payment has succeeded
9) Verify in Koha that the payment was processed

Signed-off-by: Rhonda Kuiper 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16899] Add ability to disallow overpayments via SIP

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649

Marc Véron  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #19 from Marc Véron  ---
Resetting to NSO because restored patch lost SO line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649

Marc Véron  changed:

   What|Removed |Added

  Attachment #64049|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649

--- Comment #18 from Marc Véron  ---
Created attachment 64079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64079=edit
Bug 18649: (Restored earlier version) Translatability: Get rid of tt directive
in translation for admin/categories.tt and onboardingstep2.tt

Restored earlier version (patches #63724 + #63757) to get the old behaviour,
see comment #15

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18641] Translatability: Get rid of template directives in translations for *reserves.tt files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18641

Marc Véron  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #15 from Marc Véron  ---
Hope it's OK to set this back to PQA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18641] Translatability: Get rid of template directives in translations for *reserves.tt files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18641

--- Comment #14 from Marc Véron  ---
Created attachment 64078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64078=edit
Bug 18641: Followup for pendingreserves.tt (less %s)

Change as of comment #13 to reduce %s

After creating a new translation for a "language" aa-AA, we have
the following in the file aa-AA-staff-prog.po

msgid ""
"(Inclusive, default is %s days ago to %s days ahead. Set other date ranges "
"as needed.)"
msgstr ""

msgid ""
"(Inclusive, default is %s days ago to today. Set other date ranges as "
"needed.)"
msgstr ""

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #6 from Nick Clemens  ---
I think we shouldn't round the tax rates - they should be applied with as much
precision as possible

you have one ROUD where you want ROUND

spent.pl will need an update too

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14039] Add patron title to checkout screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039

--- Comment #12 from Owen Leonard  ---
(In reply to Tomás Cohen Arazi from comment #7)
> I suggest that such a change should be optional

This patch does not make the change hidden by default, but I have signed off
because I think it's okay the way it is. I believe that if libraries are
collecting this information they most likely would like to see it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14039] Add patron title to checkout screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039

Owen Leonard  changed:

   What|Removed |Added

  Attachment #64069|0   |1
is obsolete||

--- Comment #11 from Owen Leonard  ---
Created attachment 64077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64077=edit
[SIGNED-OFF] Bug 14039 - Add patron salutation to checkout screen

To test:

Install this patch.
Ensure a user has a salutation (Mr, Dr, Miss etc) set, and checkout an
item to this user.
In the area above the barcode box, the patron's title should display,
e.g:

Checking out to Mr John Doe (0001).

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14039] Add patron title to checkout screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16726] Text in Preferences search box does not clear

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726

--- Comment #13 from Owen Leonard  ---
I think the "you searched for" text should be in a .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/